earlier today I was trying to patch the audio devices context menu with something that uses the plugin settings and it kept crashing saying cannot access length of undefined (???????), would this be able to fix that??
#👾-core-development
rugged spire
limber skiff
show stack trace
rugged spire
is this a try it and see moment
hold on
the code is not committed and it's on my laptop
give me 2-3 mins
limber skiff
I'm about to merge context menu api changes so that's your best time
rugged spire
Also do note that the crash occurs after the patch has been rendered twice
rugged spire
let me guess
documented already and i didnt find it by searching
const AudioDeviceContextMenuPatch: NavContextMenuPatchCallback = (children, props: { renderInputVolume?: boolean; }) => () => {
const s = settings.use(["isEnabled", "timeout"]);
console.log(s);
// const s = { isEnabled: true, timeout: 300 };
if ("renderInputVolume" in props) {
children?.push(
<Menu.MenuGroup
label="Auto Mute"
>
<Menu.MenuCheckboxItem
checked={s.isEnabled}
id="vc-auto-mute-toggle"
label="Enable Auto Mute"
action={() => {
settings.store.isEnabled = !settings.store.isEnabled;
}}
/>
<Menu.MenuControlItem
id="vc-auto-mute-timeout"
label="Inactivity Timeout"
control={(props, ref) => (
<Menu.MenuSliderControl
{...props}
ref={ref}
minValue={15}
maxValue={900}
value={s.timeout}
onChange={debounce((value: number) => settings.store.timeout = value, 10)}
renderValue={(value: number) => `${value} seconds`}
/>
)}
/>
</Menu.MenuGroup>
);
}
};
dont mind some of the debugging junk
yes it was originally being destructured
limber skiff
yop
rugged spire
what is it
limber skiff
basically the second callback you are using is only ran once
rugged spire
where?
limber skiff
but react component need to always run the same amount of hooks
(children, props) => () => {}
you return a function
the hook wouldnt work either way because the current context menu api is bad
the pr I'm merging will fix it
rugged spire
oh?
limber skiff
give me a sec
limber skiff
const AudioDeviceContextMenuPatch: NavContextMenuPatchCallback = (children, props: { renderInputVolume?: boolean; }) => {
const s = settings.use(["isEnabled", "timeout"]);
if ("renderInputVolume" in props) {
children.push(
<Menu.MenuGroup
label="Auto Mute"
>
<Menu.MenuCheckboxItem
checked={s.isEnabled}
id="vc-auto-mute-toggle"
label="Enable Auto Mute"
action={() => {
settings.store.isEnabled = !s.isEnabled;
}}
/>
<Menu.MenuControlItem
id="vc-auto-mute-timeout"
label="Inactivity Timeout"
control={(props, ref) => (
<Menu.MenuSliderControl
{...props}
ref={ref}
minValue={15}
maxValue={900}
value={s.timeout}
onChange={debounce((value: number) => settings.store.timeout = value, 10)}
renderValue={(value: number) => `${value} seconds`}
/>
)}
/>
</Menu.MenuGroup>
);
}
};
pull from dev
this should be your new patch
rugged spire
okay
rugged spire
wait what
limber skiff
contextMenus: {
"navId": AudioDeviceContextMenuPatch
}
no need to manually use start and stop anymore
rugged spire
so
contextMenus: {
"audio-device-context": AudioDeviceContextMenuPatch
},
yes!
rugged spire
I know
limber skiff
copy and paste the new patch again
limber skiff
alright
limber skiff
thanks a lot @brazen bone
limber skiff
does the checkbox update when you click?
rugged spire
yes
limber skiff
nice
rugged spire
something very much not working with my code though
limber skiff
SSHUT UP
frail sky
limber skiff
that's so fast
limber skiff
something very much not working with my code though
what's the issue?
rugged spire
good question idk how to explain it properly but thing activating when i dont want it to
rugged spire
real commit
limber skiff
for real
brazen bone
Rookie mistake
rugged spire
Here you can see my incompetence
rugged spire
limber skiff
I wanna try running better discord with vencord now
rugged spire
I wanna try running better discord with vencord now
why tho
brazen bone
If that is possible to support, that's cool
limber skiff
I mean
limber skiff
that's the reason I did this
limber skiff
for example I know better discord hooks the push method too
because of my commit vencord wont overwrite the better discord hook if it runs after
but better discord still overwrites vencord hooks
can't control that though
horror
rugged spire
but better discord still overwrites vencord hooks
WorseDiscord
limber skiff
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/c996860ce238551d10cbb77cd14dfabb120cc...
**patchWebpack.ts: **Lines 32-34
// The property descriptors in the monkey patches are used to ensure that if anything else (maybe another mod) hooks the same stuff as we do, we don't overwrite their hooks.
// Of course the other mods should also do this, but we can't control that, so lets at least make sure in our end we do it.
const webpackChunkPropertyDescriptor = Object.getOwnPropertyDescriptor(window, WEBPACK_CHUNK);
so technicallyyy if someone runs better discord first, then vencord after
rugged spire
dumb question but
limber skiff
vencord should at least not overwrite the better discord hooks
limber skiff
oh
rugged spire
inb4 "random"
limber skiff
let me show
this is in the vencord preload
it runs Vencord in the window, then runs the normal discord stuff
rugged spire
yop
limber skiff
if you want better discord to run first you just need to add the line above the vencord one
rugged spire
is that determined usually by which mod you install first?
rugged spire
so you'd have to inject it manually?
limber skiff
I could try installing better discord
rugged spire
horror
limber skiff
and modifying this
rugged spire
and modifying this
what the fuck
limber skiff
to run this after the better discord one
webFrame.executeJavaScript(readFileSync(join(__dirname, "renderer.js"), "utf-8"));
(the vencord one)
in fact I wil try rn
brazen bone
I could try installing better discord
Your sacrifice will be remembered
rugged spire
just cursed
still wasp
I could try installing better discord
rugged spire
@limber skiff Please press 1 if you are being held hostage by DevilBro
limber skiff
goodbye
rugged spire
Please press 2 if you are about to explode.
limber skiff
fuck
it cant patch discord dev
it will be in canary then
installing didnt work
nice
hi
rugged spire
@limber skiff run bd in vesktop 
limber skiff
but I think shelter still works even without my changes
I could be wrong but I think it barely touches webpack
hmm
I could use this
rugged spire
Is updating a settings.store value not a setter that calls onChange?
it should be IMO
would that be considered a bug?
brazen bone
Pretty sure that only applies when changing it through the menu
rugged spire
You are right
brazen bone
Whether it should is a different question
brazen bone
Setting .store.foo does run .use() hooks at least
limber skiff
nah it worked
just their original preload doesnt work
but vencord does
now I'm gonna try running bd together
well the bd loader doesnt work
charred monolithBOT
limber skiff
@cunning canyon what's the difference between TimestampMode NOW and TIME
cunning canyon
<@393694671383166998> what's the difference between TimestampMode NOW and TIME
time will show like 7:45:26 elapsed and that is same as my local time
limber skiff
ohh that's cool
limber skiff
Merge Merge Merge
limber skiff
oh fuck off
rugged spire
rugged spire
me sitting here with my fucked up dev flow where I commit to feature branch, merge to personal stable, then repeat until cozy or i forget about the feature, then i will eventually pr
limber skiff
sometimes it's another
limber skiff
wdym?
limber skiff
right now I'm using this as my personal use
rugged spire
oh
limber skiff
rugged spire
force push war
limber skiff
here goes the force push into dev
limber skiff
thanks for pointing it out ven
limber skiff
omg lmao
limber skiff
@austere talon this is caused by this line, specifically mainWindow
do you think maybe reassigning it to a variable could fix?
limber skiff
nvm I dont think that can fix, it was just a guess
austere talon
Object has been destroyed means like the window was closed
limber skiff
yeah
austere talon
but i cant repro no matter what i do
well it means the window was closed
but like
how would it be closed?
surreal fiber
I've seen many people have the javascript error in timers, not sure if it's always the same position
austere talon
i guess?
limber skiff
I will push this
austere talon
<@343383572805058560> this is caused by this line, specifically mainWindow
is thatn ur error?
austere talon
<@343383572805058560> this is caused by this line, specifically mainWindow
but that looks like windows
austere talon
well
Any help possible? this is making using discord and playing games unbearable, Keeps popping up whenever I open roblox, seems to effect the theme for some reason?
why tf does roblox trigger the watchers
limber skiff
nono it's not roblox issue
limber skiff
and also I play roblox this never happened lmao
^^
austere talon
mm
well i think it means that the window is somehow being destroyed?
maybe we should add a listener for window created
and grab the new one
but our pather should already do this
austere talon
just this will probably fix it?
limber skiff
we already monkey patch the window constructor
shouldnt that catch every window?
so no need for listener
austere talon
but our pather should already do this
yea thatgs what i said
limber skiff
just this will probably fix it?
It's guess but prob lmao
austere talon
but still need to remove old listeners
limber skiff
ye this will remove the old listeners
limber skiff
quickCssWatcher?.close();
ya
austere talon
while youre at it add a .catch(() => {}) to the open()
lime stone
when vencord broke? xd
limber skiff
yes lmao
charred monolithBOT
odd heath
when vencord broke? xd
wait thats so long ago? horror
limber skiff
why when I'm always in bed I think of stuff I could have done better
like why do I remember the most random code I wrote
austere talon
why dont subscribe to all
limber skiff
oh
austere talon
im thinking of a case where some action might use settings
limber skiff
the subscription is to update the checkmark when quickCss toggle is changed
austere talon
for example we might add additional capabilities in the future
limber skiff
I only need to subscribe to that setting
austere talon
like plugins adding checkboxes
limber skiff
I think you are confusing of what the commit changed
austere talon
im saying it should sub to all settings in case some toolbox action uses settings
like a plugin action
charred monolithBOT
limber skiff
well
then the action should use the setting hook on its own
it makes no difference
I added that setting subscription with the context menu changes
I just only realized now it was subscribing to everything
I wondered if listen together is easily fixable
or they fucked it up hard
@shy veldt would you know anything about that?
or maybe you @median rapids
sorry for pingies but you two know everything that happen lmao
austere talon
im on stable with this experiment enabled
i doubt the experiment makes a difference
maybe spotify fixed spotify crack?
limber skiff
maybe spotify fixed spotify crack?
nono
I don't have premium and it works now
I don't even think they can fix it
discord handles it purely client side I guess
spotify only gives the api key for unlimited permissions
austere talon
I don't even think they can fix it
they can fix it
by restricting the permissions of the spotify token
to only allow pause and nothing else
but that would also break SpotifyControls
cause SpotifyControls also uses discords spotify token
limber skiff
but how would listen together work then lol
austere talon
for non premium users i mean
austere talon
idk why they dont check at all lol
charred monolithBOT
Shows the Date you and someone else became friends in the user popout.
Implements https://github.com/Vencord/plugin-requests/issues/157
limber skiff
shhh keep it like this
austere talon
yeah xd
odd heath
What class would I even use for that from what i understand discord also just uses fragments
charred monolithBOT
austere talon
all of these
the h2 is just FormTitle but maybe with custom class
use react devtools to look at their code
odd heath
it is identical but it does this
although for some reason the div class didnt get applied properly but thats fixed now
surreal fiber
maybe friends since should be in its own .section
odd heath
ooh
austere talon
yeah chrome changed them iirc
median rapids
sorry for pingies but you two know everything that happen lmao
what happened to it
and dw 
limber skiff
@austere talon btw I think role context menu only exists if you have developer mode to show the button to copy ids
limber skiff
also while you are at it, change the plugin name and add option to copy role color
austere talon
true true
austere talon
nop
limber skiff
It's difficult isnt it
I remember it was bad
Ohh yeah
can you fix resurrect home readme image for me
I couldnt find the assets issue
limber skiff
can you fix resurrect home readme image for me
the pull request for it as an image
austere talon
we could just force enable developerMode
findByProps("DeveloperMode").DeveloperMode.updateSetting
brazen bone
Why does it require developer mode at all?
limber skiff
the context menu doesnt exist without it enabled
the button it normally exists is the copy role id button
so with it enabled the menu doesnt exist it all
austere talon
this is it
its used in a few places
also copy command id
okay removing the check is pain
we'd need to patch this and check if label is the localised role label
i think just force enabling dev mode is okay
charred monolithBOT
odd heath
Force push smh
brazen bone
The css class hashes are always of the form _[0-9][0-9a-f]{4}|[a-f][0-9a-f]{5}. Wonder why that is.
limber skiff
cool
austere talon
The css class hashes are always of the form `_[0-9][0-9a-f]{4}|[a-f][0-9a-f]{5}`...
wdym?
they're that way cause that's how the generator makes them
brazen bone
Yeah but why isn't it like, always six hex digits
limber skiff
yeah
limber skiff
I'm fixing
austere talon
might also be good to make another browser release
if u do push to main
oki bai have fun
limber skiff
nice
I hate this find but there is not anything better
there is a new mod pretty much identical to it, and it's also super small with very generic stuff
rugged spire
https://github.com/Vendicated/Vencord/blob/main/docs/1_INSTALLING.md?plain=1#L99
why is it telling people to go to support for something unsupported
cunning canyon
it is written long time ago
rugged spire
it was last touched 5 months ago
austere talon
thats from back when installing from source was still the official way to install
before we had prebuilds and a http updater
it should be updated however
rugged spire
oh really
rugged spire
the only reason I even noticed was because I was updating the readme for my personal "stableish-but-not-ready-for-upstream-fork" or whatever to tell my friends to NOT bother y'all
rugged spire
funny old vencord readme
contribute your soul by join join join join join join join join join join join join join join join join join join join join join join join join join
austere talon
never check the history of the LICENSE file
rugged spire
never check the history of the `LICENSE` file
morbid curiosity time
||The Giant Penis License (GPL)||
.
charred monolithBOT
rugged spire
i can confirm the RUBBISH I made is working well
charred monolithBOT
charred monolithBOT
dusk hill
is there some kind of api for toolbar buttons?
spark pivot
Look at how vencord toolbox does it
dusk hill
is there also a api for message menu ?
spark pivot
is there also a api for message menu ?
Look at ViewRaw
brazen bone
ViewRaw ironically does not patch the message context menu
spark pivot
Same concept
austere talon
sounds good @placid wave
placid wave
sounds good <@373833473091436546>
good
I will do this when I dont have 1727373829 exams
you can assign me
i will rewrite all of vesktop and still never get contributor
rare shale
horrible idea: for systemwide vesktop keybinds we make a cli helper and then
bindsym $mod+Shift+Mod1+Control+l exec "vesktop-cli --mute-also-manti-is-gay"
lime stone
--manti=gay
austere talon
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/b0d37c981e6bbb47b4b25f28d3e87488f9038...
**index.tsx: **Lines 116-117
const guild = GuildStore.getGuild(guildId);
const role = guild?.roles[id];
TypeError: Cannot read properties of undefined (reading '461281895557365760')
unavailable guild?
limber skiff
yeah maybe
austere talon
but hmm
limber skiff
should wrap that in a error boundary anyways
austere talon
then it wouldn't be able to render the role
austere talon
should wrap that in a error boundary anyways
yep
we should go through plugins and see which ones don't use error boundaries and fix it
limber skiff
yeah but
austere talon
we can probably automate it
limber skiff
there is a lot...
should context menu api use error boundary?
I've never thought of that
austere talon
find all index.tsx files that contain $self and don't import ErrorBoundary
austere talon
menu api can only use menu items
limber skiff
yeah
austere talon
but yeah it's also not needed for things like menus or popups
because worst case scenario they will crash the app and crash recovery will recover
that's okay imo
brazen bone
Yeah if they crash it'll just close the menu
austere talon
if it only is rendered after a specific user action and recoverable then it's not necessary
brazen bone
It's poor ux and should be fixed asap, but it's not exactly fatal
austere talon
it's only necessary when it's always rendered (like spotifycontrols or similar) to prevent crash loops
limber skiff
yeah
if you wanna like
pick half of the plugins and go through
I can do the other half later or something
brazen bone
Does anyone know what the 23 in s.el("865981").then(s.t.bind(s,"865981",23)) means? It's on some but not all lazy modules
limber skiff
oh wtf
that's new
it's not using the wreq
it's using wreq.t
I've never noticed that
brazen bone
Oh, that's true, didn't even notice that
limber skiff
we need to find what it does differently and make our stuff do it
brazen bone
Which is... exports.createFakeNamespaceObject = "__webpack_require__.t";?
Maybe it's different in rspack, should check that
limber skiff
Does anyone know what the `23` in `s.el("865981").then(s.t.bind(s,"865981",23))`...
that's not even picked up by my lazy chunk regex
grave mangoBOT
https://github.com/web-infra-dev/rspack/blob/d451d235ccb4eae3b4c457ae7bff05f89ad...
**create_fake_namespace_object.js: **Line 9
__webpack_require__.t = function(value, mode) {
**create_fake_namespace_object.js: **Lines 9-26
__webpack_require__.t = function(value, mode) {
if(mode & 1) value = this(value);
if(mode & 8) return value;
if(typeof value === 'object' && value) {
if((mode & 4) && value.__esModule) return value;
if((mode & 16) && typeof value.then === 'function') return value;
}
var ns = Object.create(null);
__webpack_require__.r(ns);
var def = {};
leafPrototypes = leafPrototypes || [null, getProto({}), getProto([]), getProto(getProto)];
for(var current = mode & 2 && value; typeof current == 'object' && !~leafPrototypes.indexOf(current); current = getProto(current)) {
Object.getOwnPropertyNames(current).forEach(function(key) { def[key] = function() { return value[key]; } });
}
def['default'] = function() { return value };
__webpack_require__.d(ns, def);
return ns;
};
**create_fake_namespace_object.js: **Lines 3-8
// create a fake namespace object
// mode & 1: value is a module id, require it
// mode & 2: merge all properties of value into the ns
// mode & 4: return value when already ns object
// mode & 16: return value when it's Promise-like
// mode & 8|1: behave like require
it's absolutely lovely how unreadable these methods are
livid heath
23 is eerything except 8
>>> 23 & 1 == 1
True
>>> 23 & 8 == 8
False
>>> 23 & 2 == 2
True
>>> 23 & 4 == 4
True
>>> 23 & 16 == 16
True
>>>
Also mode & 8|1 is clearly a bug, should be mode & (8|1)
livid heath
its a comment
brazen bone
Though I guess it's just meant as pseudo syntax so whatever
limber skiff
Does anyone know what the `23` in `s.el("865981").then(s.t.bind(s,"865981",23))`...
does it use the return value?
brazen bone
Used like this (I think 865981 is the lottie runtime) ```js
async componentDidMount() {
let [animationData, { default: _default }] = await Promise.all([
require.el("432201").then(require.t.bind(require, "432201", 19)),
require.el("865981").then(require.t.bind(require, "865981", 23)),
]);
this._animItem = _default.loadAnimation({
container: this._lottieRef,
renderer: "svg",
loop: true,
autoplay: false,
animationData,
});
}
ohh
it's probably just a way to load the chunks, require and merge into a return
and it seems to be a Lottie related chunk
which our reporter ignores
livid heath
search for \w\.el\("[\w\d]+?"\).then\(\w\.t\.bind\(\w,"[\w\d]+?",\d+\)\)
limber skiff
HORROR
livid heath
it works
livid heath
nop
limber skiff
virus
brazen bone
30 matches
livid heath
i'm getting way more than 30
brazen bone
Huh, weird
livid heath
but yeah these are more or less lottie related
limber skiff
Huh, weird
they prob just have some lazy chunk loaded which has more of that stuff
livid heath
fym not found
brazen bone
Oh that's why I only got 30
rg --count only counts once per line (aka once per file) unless you use -o
With -o it gives 111 matches
livid heath
just search in devtools
brazen bone
I'm not a masochist so no thanks
brazen bone
It's really no trouble
livid heath
i mean
you do you
limber skiff
using devtools is no trouble
limber skiff
okay and what is the error?
odd heath
Cannot read properties of undefined at object.rolegroupcolor
brazen bone
It's like 8-ish clicks to download it, and then I can browse it with ripgrep, a good formatter, multiple tabs, etc
odd heath
disable role color everywhere
Oki ty
austere talon
fym not found
that only uses cache
if the module wasn't required ever it won't be found
livid heath
husk
austere talon
you can find it manually then require it
wreq(findModuleId("emojiTermsImporter:")).emojiTermsImporter
austere talon
husk
using non cache isn't possible because then we'd have to require every module which will lead to side effects
so you have to manually do it
livid heath
yeah fair wnough
austere talon
wreq(findModuleId("emojiTermsImporter:")).emojiTermsImporter
this should work but make sure the find is unique
it uses same find as a patch would
brazen bone
Or you can use findByProps("getTermsForEmoji"), which wraps that function
austere talon
huh?
if that module is loaded then the one he wants would also be loaded
unless it lazy loads it when you call the function
brazen bone
It's... weird ```js
let a0 = new _0.default(function (b0) {
{
let c0 = require("952110").emojiTermsImporter[b0];
return void 0 !== c0 ? c0().then((d0) => d0.default) : Promise.resolve({});
}
});
It's a lazy require but not a lazy chunk, don't see a lot of those
austere talon
until you call the func for the first time
difference is very simple
inline require = lazy require without lazy chunk
inline import() = lazy chunk
because inline require is synchronous it can't split the chunk
since inline import is async it can split it into a new chunk
brazen bone
Makes sense
limber skiff
@austere talon can you push an update to role color everywhere to main?
it's kinda bad to have the clients crash
turbid hatch
@real flower re: flatpak, yeah i dont know either
it's something wrong with the main repo (rerunning the build causes the same error) but it's not documented and it's not even in the linter source code
so i don't know what the error means and i have no discernable way of fixing it
but there was also an appstream error that needs to be fixed so
charred monolithBOT
turbid hatch
that is fixed now
the other linter issue, no clue lol
actually that might not work
might have to wait for flathub updater to go "hey there's a new update available for the appstream file"
austere talon
okay so guild object no longer have roles
where are they now
odd heath
in GuildRecordWithRoles
horror
real flower
<@306158896630988801> re: flatpak, yeah i dont know either
odd
real flower
but there was also an appstream error that needs to be fixed so
good to know
yeah i realized after a it more digging how stupid of an error it was
real flower
EXACTLY LIKE HOW 
turbid hatch
i searched for it on google and the linter's github and it just
austere talon
discord is so insane wtf
turbid hatch
didnt exist
limber skiff
some discord dev is cooking crazy stuff
austere talon
hmm
so how tf we we get roles now??
there has to be some way
ofc we could always patch but id rather not if it's not needed
btw there are more than just rce that use roles
limber skiff
g is roles
m is guilds
haha CRAZY
stable guildstore doesnt even have those methods
real flower
i searched for it on google and the linter's github and it just
of course it doesnt
why would it exist
why would they have good documentation
austere talon
imo just add error boundary for now and we can fix it if they push it to stable
limber skiff
I'm gonna do a fake lazy find which checks for getAllGuildsRoles
so when stable dont fail for it, we fix it
limber skiff
search for `.roles`
ye
austere talon
I'm gonna do a fake lazy find which checks for getAllGuildsRoles
wha?
limber skiff
eh
nvm
it was for the reporter to warn us when they push that stuff to stable
but it's whatever
austere talon
we'll notice it sooner than reporter xd
limber skiff
bad commit name
limber skiff
I love how it's always after an extension bump
rare shale
https://github.com/tuxinal/Vesktop/commit/8d3196c96ce03c4bdabf13a9f388eca5802740...
@lime stone rate
lime stone
https://github.com/tuxinal/Vesktop/commit/8d3196c96ce03c4bdabf13a9f388eca5802740...
for some reason i thought they rewrote in go
rare shale
whar
lime stone
i thought i was looking at go code
rare shale
bruh
no
for like 1 hour straight we were trying to get mf ipc working between the two instances
lime stone
wait global keybinds, cool
lime stone
rewrite vesktop in go
austere talon
did they revert @limber skiff
limber skiff
^^
austere talon
oh
charred monolithBOT
charred monolithBOT
charred monolithBOT
rugged spire
`bindsym $mod+Shift+Mod1+Control+l exec "vesktop-cli --mute-also-manti-is-gay"`
i would personally just make this a part of vesktop directly no vesktop-cli
rare shale
i would personally just make this a part of vesktop directly no vesktop-cli
we already did
charred monolithBOT
Describe the bug
Vesktop uses more resources than Discord app on Windows 11, thats all :)
To Reproduce
Just open both app and compare.
Expected behavior
Expected to use less resources than Discord app.
Screenshots
Desktop (please complete the following information):
- OS/Distro: [Windows]
- Version: [11]
charred monolithBOT
fleet depot
Being literate challenge: impossible
lime stone
a
rugged spire
fucking github users
charred monolithBOT
This PR adds a card at the top of CustomRPC settings that tells the user that their custom RPC won't be visible if their game activity isn't enabled, with a button to quickly enable it.
Here's a recording of the feature in action:
and here's a screenshot of the card itself:
charred monolithBOT
charred monolithBOT
Describe the bug
When trying to open any server, Vesktop crashes.
To Reproduce
- Open Vesktop
- Try to open any server
- Crash
Expected behavior
No crash occurs
Screenshots
Desktop (please complete the following information):
- OS/Distro: EndeavourOS
- Desktop Environment (linux only): dwm
- Version: 6.4
Command line output
...
charred monolithBOT
junior olive
^ this works fine with the current worker too, I just need this changing so I can switch
limber skiff
you are paying with your own money for that? @junior olive
junior olive
you are paying with your own money for that? <@890228870559698955>
Partially, some of it is from gh sponsors
limber skiff
oh nice
junior olive
Ideally I cut the cost though
limber skiff
🙏 at least you got some help
junior olive
Yup I'm grateful
austere talon
didn't i raise concerns about that before the plugin was even made
that's why fully selfhosting is still really good
reviewdb gets a shit ton of requests too but it's all handled by our go server
limber skiff
reviewdb gets a shit ton of requests too but it's all handled by our go server <...
which runs in your oracle server right
and it's the free tier
junior olive
that's why fully selfhosting is still really good
fully selfhosting decor would not be fun imagine selfhosting all the decorations
austere talon
how much storage does it use
dusk blaze
reviewdb gets a shit ton of requests too but it's all handled by our go server <...
what if oracle bombs it
junior olive
regardless i can get the cost down by this means its not a difficult change
dusk blaze
what if oracle bombs it
like what they did to mantika
austere talon
then i switch to a different server
junior olive
how much storage does it use
its not the storage (but it's around 1gb) it's the amount of requests for the images
austere talon
not a big deal
dusk blaze
then i switch to a different server
can't you like make one account per person?
or does it let you make other servers
austere talon
its not the storage (but it's around 1gb) it's the amount of requests for the im...
if you generate unique filenames then you can put cloudflare in between and set cache headers to a year and have cloudflare cache 99%
that's what i do for vencord badges
junior olive
once this change is merged i can just switch to r2 public access and boom costs gone (with cache and evrything)
austere talon
can't you like make one account per person?
?
austere talon
once this change is merged i can just switch to r2 public access and boom costs ...
okay so it's high priority?
will merge tomorrow
charred monolithBOT
charred monolithBOT
This adds a option that can be selected to use this little prettier Channel Section.
Inspired by https://github.com/Vencord/plugin-requests/issues/173
UserPopout
UserProfileModal
PrivateChannelProfile
 {
const plugin = plugins[pluginName];
for (const prop in plugin) {
const value = plugin[prop];
if (value == null) continue;
const valueStr = value.toString();
if (valueStr.includes("VencordCreateElement") && !valueStr.includes("ErrorBoundary")) {
console.log("plugin:", pluginName, "prop:", prop, "=", value);
}
}
}
some false positives but we can just ignore them
better than search for every manually
charred monolithBOT
charred monolithBOT
charred monolithBOT
rugged spire
Have the webhooks for the other related projects been moved yet?
charred monolithBOT
brazen bone
Those star messages are kinda annoying imo
rugged spire
,
rugged spire
Those star messages are kinda annoying imo
yeah
still wasp
Those star messages are kinda annoying imo
Yeah they have like no use
brazen bone
The pr hooks are nice though
nimble crag
rugged spire
channel tabs be like
i mean discord itself is the reason its so fucking slow
but it is like 10x more noticable using channeltabs
brazen bone
I don't know what that is but it sure doesn't look good
analog knoll
Is vesktop supposed to run into a runtime error when there's no internet connection on startup?
rugged spire
Is vesktop supposed to run into a runtime error when there's no internet connect...
I think so?
rugged spire
I don't know what that is but it sure doesn't look good
Performance graph of switching guild and back
i mean this is not using channeltabs (discord's shitcode still makes it lag 400-600ms)
analog knoll
I think so?
Hm. Perhaps it would be nice if it didn't.. I'll look into it today. We could put shiggy under a tap water image there - just a proposal
jagged reef
channel tabs be like
Me when while (true)
rugged spire
Hm. Perhaps it would be nice if it didn't.. I'll look into it today. We could pu...
wet shiggy
rugged spire
Me when `while (true)`
dont do that then
analog knoll
wet shiggy <:husk:1026532993923293184>
Because it looks so silly. Just as you not having an internet connection yet trying to load Vesktop 
rugged spire
Because it looks so silly. Just as you not having an internet connection yet try...
Just as you not having an internet connection yet trying to load Vesktop
autostart on a laptop
not an unrealistic situation
analog knoll
Hm. That's fair. Even more reasons for it to not crash. I am sure the first thing you want to see when you open a laptop is a Vesktop runtime error splashed on your screen. I would rather see a wet silly shiggy splashed there instead with a retry button or something.
^ wet in a meaning of water, as mentioned above, a tap water #🦊-shiggy-and-friends message
rugged spire
^ wet in a meaning of water, as mentioned above, a tap water <:blobcatcozy:10265...
sometimes elaborating is a bad thing
this is one of those cases
woeful sable
> Just as you not having an internet connection yet trying to load Vesktop
autos...
by the time autostart programs actually get launched, my internet is already connected
rugged spire
by the time autostart programs actually get launched, my internet is already con...
true
woeful sable
internet also tends to connect while entering password for me
but i think i enter it a bit too quick since my internet doesnt get connected until like 2s after i unlock
(also wasn't talking in this channel locked to a specific role before or something)
austere talon
Because it looks so silly. Just as you not having an internet connection yet try...
will fix next version
that's the update check
actually it shouldn't be
analog knoll
that's the update check
I see. I though it was some type error on a failing fetch
austere talon
i honestly don't know what it is
analog knoll
Well, it probably is, but I though it was trying to access discord api not vesktop
austere talon
there shouldn't be a request that can fail
unless there's a bug and it downloads all vencord files every time you open it
ill debug
woeful sable
Wouldn't replicating discord's functionality when theres no internet be fine?
analog knoll
What's the behaviour?
woeful sable
it just has a timer which retrys, and adds up exponentially
u can try it urself rn just disable internet and open a discord client
austere talon
Wouldn't replicating discord's functionality when theres no internet be fine?
that is not the problem
woeful sable
does it just crash?
analog knoll
charred monolithBOT
analog knoll
Bruh, quick question - I see that we've got prettier inside of the vesktop repo. I ran prettier -fix and it fixed most of the files. Is there something wrong with prettier reading that file or has anyone never ran it
For instance I was doing some work on src/main/utils/http.ts and this file in particular it formatted a lot. Could anyone check if that's indeed the case
Nevermind, my bad
analog knoll
ill debug
I debugged it and found out there was an onerror and a try catch missing
I'll just handle the possible undefines now
austere talon
this makes sense but i don't like the way you solved it
you should be able to differentiate between an error during dns lookup / connection (request fails, aka Internet no work) and http error (request succeeded but responded 404/etc)
and in the former case it should retry until it works
rugged spire
@austere talon can i scare you with a disgusting no good horribly inefficient idea I had
austere talon
and in the former case it should retry until it works
optimally with an exponential back off like discord
rugged spire
what if i inject css to set heights and offsets and similar but dynamicslly load the css classes using findByPropsLazy
i should just be using parent selectors shouldn't I
brazen bone
Uh, that sentence makes no sense
rugged spire
i already hack in some always resolving parent selectors anyway to prioritize my custom css rules
brazen bone
What's the context
austere talon
btw we should look into switching to the fetch api anyway
i think our electron version has it
rugged spire
What's the context
Changing Discord's hardcoded 22px vertical offset for overlays so the titlebar shows
analog knoll
you should be able to differentiate between an error during dns lookup / connect...
Alright. I'll do that
rugged spire
Changing Discord's hardcoded 22px vertical offset for overlays so the titlebar s...
do a search for .platform-win in devtools to see what i mean
I probably sound crazy
rugged spire
you should be able to differentiate between an error during dns lookup / connect...
how about invalid SSL certificate errors
those are also common enough to need to be handled too
austere talon
?
github is never gonna have ssl errors
but that would fall under the first category
rugged spire
are you talking about the loading splash screen still
rugged spire
github is never gonna have ssl errors
local mitm (& dns?)
charred monolithBOT
analog knoll
you should be able to differentiate between an error during dns lookup / connect...
Well, it would seem like I can get this info from the error.code that I get in catch. I can check for stuff such as ENOTFOUND, EAI_AGAIN etc. I get EAI_AGAIN when I disable my network interface, but the same error is what I'd probably get on dns lookup fail. Should I just implement a retry mechanism for all cases?
austere talon
don't bother checking what it is
austere talon
are you talking about the loading splash screen still
never were
rugged spire
horror
analog knoll
@austere talon does discord have a hard cap on the backoff? like 100 seconds or something
austere talon
don't hack more on the https.get
austere talon
<@343383572805058560> does discord have a hard cap on the backoff? like 100 seco...
- unpack their desktop core asar and see for yourself
analog knoll
Alright this should be good
I limited it at 5 retries, but perhaps that's not even needed because of the backoff now is it
livid heath
why not just reject(err) atleast you'll get the extra props set on err when catch-ing, as opposed to new Error
analog knoll
good point. is the backoff good like this? https://github.com/Vencord/Vesktop/pull/432/commits/90e32a454d3806399385d295b7f74d8e42015ce1
charred monolithBOT
turbid hatch
i'd just write the fix now and do the thing we did before where we make it work on both
until it's pushed to stable
then remove the old code
austere talon
messy
charred monolithBOT
shy veldt
bro when is discord gonna push the role change to stable
a what
brazen bone
They did something so roles are no longer in GuildStore, I think
livid heath
husk
brazen bone
2 days is plural
austere talon
https://media.discordapp.net/attachments/1029315212521771020/1215766561835712512...
insanity yeah
