#πΎ-core-development
austere talon
charred monolithBOT
charred monolithBOT
rare shale
should we make the theme link thingy only accept http/https?
i feel like this is too much trolling
Vencord.Settings.themeLinks = ["data:text/css;base64,KnthbmltYXRpb246ciA0bXMgaW5maW5pdGUgbGluZWFyfUBrZXlmcmFtZXMgcnt0b3t0cmFuc2Zvcm06cm90YXRlKDF0dXJuKX19"]
there's no reason to be able to run this shit since quickcss exists
austere talon
i hate anti malware detections so much they're so stupid
ill try to do some changes to the installer to reduce detections
austere talon
no that doesn't solve them
austere talon
ill try to do some changes to the installer to reduce detections
the latest version is flagged as remote executable downloader trojan by one engine, i wonder if it's the self updater https://github.com/Vencord/Installer/blob/main/self_updater.go#L52
grave mangoBOT
the latest version is flagged as remote executable downloader trojan by one engi...
**self_updater.go: **Line 52
filename := Ternary(buildinfo.UiType == buildinfo.UiTypeCli, "VencordInstallerCli.exe", "VencordInstaller.exe")
odd heath
lmao
austere talon
another potentially sus thing is that it checks all Discord folders in AppData/Local https://github.com/Vencord/Installer/blob/main/find_discord_windows.go#L127
grave mangoBOT
another potentially sus thing is that it checks all Discord folders in AppData/L...
**find_discord_windows.go: **Line 127
if ExistsFile(path.Join(programData, username, discordName)) || ExistsFile(path.Join(programData, username, discordName)) {
so i might change it to where instead of checking each folder it instead just reads the AppData Local folder and then filters for Discord paths
odd heath
**find_discord_windows.go: **Line 127
```go
if ExistsFile(path.Join(programData,...
why is there 2 times the same thing
like to me it looks like that line is saying if a || a
lime stone
it's more like if a() || a()
that may not seem important but functions can have side effects
maybe go is so broken you need to check twice
odd heath
lmao
austere talon
no
im just dumb lmao
i think they used to be two different conditions but during a refactor at some point the second condition become obsolete
and i didnt fully remove it
lime stone
i was wondering if it was some kind of multithreading shenanigans and this fixed some dumb bug...
odd heath
and i didnt fully remove it
lmao classic
charred monolithBOT
austere talon
what?
we might as well support win7 if it's as simple as reducing go version
we can drop support once discord drops support
frail sky
odd heath
we can drop support once discord drops support
I mean it's 2 months away so it seems kinda useless imo
mortal fractal
we can drop support once discord drops support
its already dropped on canary so
its been ~4 days since 28 was pushed to canary
dapper tiger
cyn
austere talon
@urban wraith hilarious timing, someone complained about it the same time u opened the pr
unless that person was why u prd
urban wraith
pure coincidence 
I tried to reinstall after updating my discord and realised it was using the wrong path
austere talon
silly
it was just brainfart from me
i looked at that if else during refactor and was like ohh both parts are the same
so i removed it
turns out, they were not in fact the same
charred monolithBOT
austere talon
@topaz thistle is glibc always such a fucking pain in the ass
i love compiling on my system and then it doesn't run on other people's systems so i have to build in ancient ubuntu container instead
could they not have made glibc backwards compatible
topaz thistle
<@349609234985517057> is glibc always such a fucking pain in the ass
Yes
topaz thistle
i love compiling on my system and then it doesn't run on other people's systems ...
Flatpak :)
That's also fucked
Not always and not perfect
austere talon
there was a stupid linux bug in the vencord installer
but i didn't want to make a new version just for the small bug
so. i just replaced the release binary with my own build
FUCK UBUNTU STOP SHIPPING ANCIENT SOFTWARE
topaz thistle
I don't get how people run such ancient glibc though
austere talon
ubuntutards need to become normal and switch to fedora
austere talon
I don't get how people run such ancient glibc though
it's not people it's fucking ubuntu
austere talon
yes
topaz thistle
A developers worst nightmare is straight up ubuntu
austere talon
are you on your pc rn
topaz thistle
I can't tell you how much trouble I've had with that shit
topaz thistle
are you on your pc rn
Just woke up
austere talon
mmm
topaz thistle
Have to get ready for exam
austere talon
Have to get ready for exam
best of success!
charred monolithBOT
topaz thistle
kinda need to fix library but I wanna sleep now
Which one is it? Simply the installer?
I can take a look after the exam (will probably be done at 12:30 or something)
topaz thistle
@austere talon can we have a bot that instantly closes issues that contain Screen-Share and audio with a notice to transfer it to venmic?
topaz thistle
Also - do I have permission to close issues like this?
I'd actually prefer not to transfer them but close them instead so that they will reopen in Venmic with the required data
charred monolithBOT
My version is 1.5.0
It is happening, I just tested it.
I'll look at Venmic and make an issue there tho.
crude hearth
i love compiling on my system and then it doesn't run on other people's systems ...
glibc is awful
I had deranged experience with rust extension while working on oracle
oracle linux has decade old glibc version
crude hearth
it's not people it's fucking ubuntu
wth is wrong with ubuntu
snap is awful yes but what else if horrible
rugged spire
i just remembered
i am about to accidentally implement global shortcuts on wayland
please do NOT actually use my plugin I am building to do so though
limber skiff
can we make vencord devbuild inject command use cli
charred monolithBOT
Here you go, thanks for the fast reply :)
id 29, type PipeWire:Interface:Node/3
object.serial = "29"
factory.id = "10"
priority.driver = "20000"
node.name = "Dummy-Driver"
id 30, type PipeWire:Interface:Node/3
object.serial = "30"
factory.id = "10"
priority.driver = "19000"
node.name = "Freewheel-Driver"
id 42, type PipeWire:Int...
rugged spire
i am about to accidentally implement global shortcuts on wayland
Hey fellow dumb nocturnal developers where's the setSelfMute function
austere talon
lol how did u even find that issue
topaz thistle
lol how did u even find that issue
austere talon
horror
topaz thistle
@austere talon I can build a workaround for this, which would be an additional function that would require me to know which node.id the screenshare node has, can you get that info from the JS side?
If I were to add it, you could simply call that function and venmic would manually fix the created links by electron
Could be an additional toggle in the audio tab
austere talon
yes
wait why does the js side need the node id
the part calling venmic would be native
topaz thistle
Because I need to know which node is the screenshare
austere talon
well you can check that from main
not from js
ohhh
okay i misunderstood
i assumed by js side you meant the renderer
but you mean js in general
yeah okay
austere talon
it should be really easy
grave mangoBOT
https://github.com/Vencord/Vesktop/blob/main/src/main/venmic.ts#L19-L21
**venmic.ts: **Lines 19-21
.getAppMetrics()
.find(proc => proc.name === "Audio Service")
?.pid?.toString() ?? "owo"
But fuck pipewire on Debian I guess
austere talon
getAppMetrics is what u need
topaz thistle
Does that also return the screenshare node?
topaz thistle
But fuck pipewire on Debian I guess
I think I can also take the EasyEffects approach and set a redirect prop in the metadata which would make it way more clean
topaz thistle
just experiment with it
Will check it out
charred monolithBOT
topaz thistle
I think I can also take the EasyEffects approach and set a redirect prop in the ...
Ugh
Actually I'm not even sure if this will work
Because I think the redirection has to happen when the node is created not once it's already created
Got an idea
not the fanciest but should work π΅βπ«
@austere talon since the issue is #15 I'm tempted to call the workaround flag burgerking_foot_lettuce
topaz thistle
I need to figure out if the node is the screenshare audio node, before I can know it from JS Side
austere talon
the binary name should be vesktop, but i wouldn't rely on it if possible
lime stone
<@343383572805058560> since the issue is #15 I'm tempted to call the workaround ...
what's wrong with you
austere talon
just try logging all nodes and see if you can find it by name or smth?
topaz thistle
So I'd go with a combination of application.process.binary contains vencord and media.name being RecordStream
austere talon
binary would be vesktop most likely, but like i said i wouldn't rely on it
topaz thistle
node name would be "chromium input"
I guess with regards to the time frame we're working with it'd be ok if I just take the next node that's a RecordStream and Chrome related
Ah
Wait I can figure it out based on the PID
Because I can know that up front
topaz thistle
what's wrong with you
austere talon
Wait I can figure it out based on the PID
yeah there u go
that's better
also hate to be that guy but didn't u want it to work with browsers as well
you'd be throwing it out of the window
lime stone
<:trolley:1024751352028602449>
the number 15 makes me think of an age when i was stupid. not this
charred monolithBOT
topaz thistle
the number 15 makes me think of an age when i was stupid. not this
I am damaged beyond repair
Can someone please invent break for ifs
I'm so close to using goto rn
austere talon
Can someone please invent break for ifs
make a separate function then you can just return
topaz thistle
yeah I re-organized it properly
austere talon
but goto is fine as well tbh, idk why people think it's evil
topaz thistle
I also don't have a big problem with goto as long as it's not excessive
austere talon
vencord uses goto in some places 
topaz thistle
based
austere talon
well js doesn't have goto , but smth very similar
austere talon
/run ```js
console.log("before block")
block: {
console.log("inside block")
break block
console.log("unreachable")
}
console.log("after block")
vital lionBOT
Here is your js(18.15.0) output @austere talon
before block
inside block
after block
okay
I'm not sure if I want to keep the name
Imagine someone reads the code lmao
austere talon
/run ```js
console.log("before block")
block: {
console.log("inside block")...
you can nest blocks and achieve insane goto capabilities
topaz thistle
but I'll save the target as lettuce_target
because that is shorter than workaround_target
topaz thistle
you can nest blocks and achieve insane goto capabilities
that's really useful
austere talon
Imagine someone reads the code lmao
that's funnier
i don't think I've seen anyone use blocks like that tho
i like using things that most developers think is evil
i also like using var to hoist variables out of try catch / if else
topaz thistle
i like using things that most developers think is evil
evil is a social construct
austere talon
i also like using var to hoist variables out of try catch / if else
virgin
let thing: string;
try {
thing = getThing();
} catch {
return
}
console.log("thing")
``` vs chad ```ts
try {
var thing = getThing();
} catch {
return
}
console.log(thing)
always take the most sane approeach to reach your goal
if that happens to be using goto
fine
topaz thistle
virgin
```ts
let thing: string;
try {
thing = getThing();
} catch {
retu...
lol
insane
austere talon
i prefer the var version
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/debug/Tracer.ts#L21-L24
**Tracer.ts: **Lines 21-24
if (IS_DEV) {
var traces = {} as Record<string, [number, any[]]>;
var logger = new Logger("Tracer", "#FFD166");
}
you can do this as well
lime stone
/run ```js
console.log("before block")
block: {
console.log("inside block")...
you can do this in java too
i remember people being annoyed when i did so
lime stone
i prefer the var version
if only you could make it const though
austere talon
well you can either choose var or let
both are mutable
there's a const method but it's uuuuugly
austere talon
this would be solved if js had blocks as expressions
const thing = try {
getThing()
} catch {
return
}
many other languages allow this
lime stone
i'm not a fan of blocks as expressions...
austere talon
need this in js
austere talon
everything being an expression is hot
topaz thistle
Just remove try catch
austere talon
there's a reason tons of languages are adding it
topaz thistle
it's really ugly
austere talon
horror
lime stone
everything being an expression is hot
when you do multiple levels of blocks-as-expressions i don't think it's any better than ternary nesting
topaz thistle
expected<> π
limber skiff
I honestly love kotlin var thing = that ?: return
limber skiff
true
dusky sonnet
with rust you can just do `?`
Assuming your return type supports it :)
lime stone
π
lime stone
Assuming your return type supports it :)
every system has its pro's and con's i guess
(do not critisise the approstophy, its' required to make it readable)
lime stone
Result<(),Box<dyn std::Error>>
my beloved
dusky sonnet
If you actually do it like that lmao
topaz thistle
Alright, moment of truth, now I need to make Vesktop use my local venmic build and check if shit explods
lime stone
with exceptions it's nice you can yeet stuff without any boilerplate*
* apart from writing a whole exception class
dusky sonnet
Anyway nah you gotta match every single dangerous call
Back to the point of block expressions lol
austere talon
with exceptions it's nice you can yeet stuff without any boilerplate*
\* apart ...
apart from writing a whole exception class
/run ```js
throw "pipe bomb"
@austere talon I only received js(18.15.0) error output
/piston/jobs/f003871b-af2d-47da-8f86-ce7cf0a3a7a2/file0.code:1
throw "pipe bomb"
^
pipe bomb
(Use `βnode --trace-uncaught ...`β to show where the exception was thrown)
Node.js v18.15.0
Uncaught pipe bomb
lime stone
/run
struct ExceptionsMyBeloved : std::exception {
const char *msg;
const char *what() const noexcept override { return msg; }
};
int main() {
throw ExceptionsMyBeloved{"pipe bomb"};
}
@lime stone I received c++(10.2.0) compile errors
file0.code.cpp:1:45: error: expected class-name before '{' token
1 | struct ExceptionsMyBeloved : std::exception {
| ^
file0.code.cpp:3:17: error: 'const char* ExceptionsMyBeloved::what() const' marked 'override', but does not override
3 | const char *what() const noexcept override { return msg; }
| ^~~~
chmod: cannot access 'a.out': No such file or directory
/piston/packages/gcc/10.2.0/run: line 6: ./a.out: No such file or directory
c++ never works the first time
topaz thistle
@austere talon can I quickly get the vencord PID from devtools?
topaz thistle
c++ never works the first time
hold my beer
topaz thistle
/run
```c++
struct ExceptionsMyBeloved : std::exception {
const char *msg;
...
Use std::expected
austere talon
<@343383572805058560> can I quickly get the vencord PID from devtools?
no
you can only get the pid from main process
topaz thistle
alright
austere talon
the best way to eval code in main is to add --inspect-brk or whatever it was to launch flags and attach a debugger
topaz thistle
okay yeah I'm just gonna run a new build then xD
austere talon
see the comment here
and copy paste that file into vesktop repo
pretty easy to set up actually
you can configure launch flags by copying .env.example to .env and editing it
could even create a vscode launch task that automatically launches vesktop with a debugger attached
topaz thistle
Alright artificially reproduced the bug
Time to test the workaround
So that should work?
Do I need another pnpm install after?
austere talon
also make sure you have the same structure as the bundled package
topaz thistle
also make sure you have the same structure as the bundled package
should be roughly the same
austere talon
it uses the prebuild folder
austere talon
might be easier to just manually replace the file in the node modules folder
topaz thistle
probably but I think I got it
nvm
will replace lmao
moment of truth
fuck
Nvm
Didn't even call it lmao
I don't understand https://cdn.discordapp.com/emojis/886899606955388969.webp?size=48&name=pepecry&quality=lossless
I have it exactly the same as easyeffects
yet shit refuses to work
identifying the node also works correctly
dapper crest
What is that software?
topaz thistle
qpwgraph
charred monolithBOT
topaz thistle
@austere talon will you punch me for this
topaz thistle
the data param's type isn't quite simple
so I'd rather use it like this
or do you have any suggestions?
Will make a PR shortly just review there I guess
@austere talon how can I add a Checkbo in AudioSourcePickerLinux?
austere talon
for what
topaz thistle
Found it
topaz thistle
why even add a checkbox, is that necessary
Don't want to force it on for everyone
topaz thistle
@austere talon does this look ok?
Text should probably rather be: "Workaround for issue that causes the microphone to be shared instead of selected audio"
austere talon
don't say debian
topaz thistle
Just Workaround?
austere talon
do you think mint or ubuntu users know what debian is
austere talon
explain like the user is a 10yo (they are)
topaz thistle
Number 15 Workaround
So just:
Workaround
- Workaround for issue that causes the microphone to be shared instead of selected audio
?
Or "Force Audio"?
dapper crest
"Linux fix:
Stops microphone audio shared in screeshare. Only use if you have problems"
dapper crest
It's a Debian fix. But they don't know it's Debian, but saying Linux helps narrow down the people who do use it
austere talon
It's a Debian fix. But they don't know it's Debian, but saying Linux helps narro...
Windows users don't even see that
topaz thistle
It's a Debian fix. But they don't know it's Debian, but saying Linux helps narro...
They'll only see it when they're already on Linux
It will make them even more confused
topaz thistle
Maybe do some checks to see if it's Debian based and apply automatically
Horror
austere talon
"
Microphone Workaround
Work around an issue that causes the microphone to be shared instead of the correct audio. Only enable if you're experiencing this issue.
"
smth like that
topaz thistle
c&p
dapper crest
"
## Microphone Workaround
Work around an issue that causes the microphone to b...
That's good
topaz thistle
looks good to me
Will open PR
Will have to wait for this motherfucker to finish before merging though
austere talon
pog good work
austere talon
hmm
idk if i would
could the pid change?
probably best to not
considering this is a very rare call it's whatever
i just meant use variable instead of calling it twice in a row
dapper tiger
@austere talon give me something to do for vencord or vesktop
austere talon
surely this is old enouigh right
charred monolithBOT
Describe the bug
On Windows, I'm unable to disable the unread notification count seen in taskbar.
I thought turning off this setting in Vesktop would work but it doesn't appear to do what I think it should do (i.e. disable unread notification count in taskbar). I can't really tell what this toggle actually does otherwise and so either this is a bug or this issue is a feature request.
![...
charred monolithBOT
topaz thistle
@austere talon it would be awesome if venmic supported more complex inclusion/exclusion logic
I thought about having the mode be either include or exclude but both modes support boolean expressions - that way we wouldn't need mixed include/exclude as well
The only problem is how to represent the logic expressions
I thought about writing my own boolean expression parser for this that supports a minimal amount of operations, in this case ==, !=, &&, ||, contains, startsWith, endsWith maybe?
So we could for example have the current system audio logic where everything except Vesktop is included be:
props["application.process.id"] != "1337"
And if someone wanted to include Firefox but not a specific instance for example it could be:
props["node.name"] == "Firefox" && props["application.process.id"] != "<some-pid>"
I don't think we have the need for complicated expressions like that right now but it could be useful in the future maybe
charred monolithBOT
livid heath
I thought about writing my own boolean expression parser for this that supports ...
jq 
topaz thistle
jq <:superyes:1030570911834837122>
The CLI JSON parser?
livid heath
yop
topaz thistle
How is that related xd
livid heath
And if someone wanted to include Firefox but not a specific instance for example...
^ you could write expressions like this and jq will handle the filtering for you
topaz thistle
Huh interesting, but that would not be suitable for this use-case, as I'd need it as a library not as a cli tool
And I don't really need a JSON parser
A really simple expression parser is more than enough
livid heath
you'd have to decide on the syntax, write a parser and implement the filtering
jq can already handle that for you
iirc there are some jq bindings
topaz thistle
I've already decided on the Syntax and writing the parser is quite simple I think
And as I've already mentioned I don't need JSON parsing, iirc jq filtering only works on JSON
Then I'd have to serialize the data to JSON, run jq on it, deserialize it
and in the worst case even spawn a subprocess to Interact with jq
I don't see how that is any better than writing an expression parser
livid heath
Β―_(γ)_/Β―
turbid hatch
@austere talon can we kill supporting win7
theres not much point in trying to anymore
the OS has been dead for almost 10 years
charred monolithBOT
Obs has an option to display cursor, is it possible to add similar in vesktop? Or is it also an electron limitation?
charred monolithBOT
Is your feature request related to a problem? Please describe.
When using the platform indicators plugin, i appear as web not desktop
Describe the solution you'd like
To make the vesktop client be visible as desktop not web server-side
Additional context
spark pivot
im making a remix plugin but i can not for the life of me find a working and maintained ui image editing library
so im gonna make my own
wish me luck
austere talon
wasn't there alr one
spark pivot
wasn't there alr one
i found one that costs literally like $150/year
any other one i found had no docs and were deprecated
spark pivot
im making a remix plugin but i can not for the life of me find a working and mai...
nvm its not that hard
charred monolithBOT
charred monolithBOT
charred monolithBOT
rugged spire
im making a remix plugin but i can not for the life of me find a working and mai...
as someone who is interested in a remix plugin, have you considered building a version that lets you
- mark image as a remix separately to the edit functionality
- edit with system image editor
charred monolithBOT
surreal fiber
I thought I'd ask here instead of support.. is it known that if you open rtc debug on vesktop you can't close it, it closes the main vesktop window instead
austere talon
charred monolithBOT
spark pivot
as someone who is interested in a remix plugin, have you considered building a v...
- whar
- kinda useless
anyway
ignore my todo list lol
hmm i might be able to spoof the remix tag
that would be quite silly
spark pivot
hmm i might be able to spoof the remix tag
sadly it looks like discord removes this when you upload the file
sadge
spark pivot
discord actually making their api do something 
verbal pumice
sadly it looks like discord removes this when you upload the file
i think you also need to prefix the file name with REMIX_
could be spreading misinformation tho
spark pivot
"filename": "1192174392839520346remix-1706336625969.png",
"flags": 4,
flags 4 is remix, there is remix in the filename but idk
spark pivot
docs say its 1 >> 2
spark pivot
yeah sadly doesnt work
charred monolithBOT
still wasp
I assume patching out the chill zone would be bannable?
jagged cloak
prob would just return 429 or something
still wasp
Hmmm
charred monolithBOT
charred monolithBOT
Builds on the idea of the callTimer plugin but adds timers to all users in guild voice calls.
Note: this only keeps track of users as long as Discord is open. When restarting Discord for any reason the data is lost.
Looks like this
Please let me know if you have any questions or suggestions for improvement.
still wasp
Holy shit i am unreasonably proud of this plugin
lime stone
Holy shit i am unreasonably proud of this plugin
my main complaint would be the comma separated values
a lot of plugins do that ig
also the name probably isn't appropriate for vencord
odd heath
Just replace the "fuck" with "no" and it's fine
still wasp
also the name probably isn't appropriate for vencord
I'm not gonna pr it 
Just showing it :p
austere talon
yeah sadly doesnt work
how are u sending the file
you can definitely send proper remix tag
spark pivot
Not on computer rn Iβll go look soon
spark pivot
show code
export function sendRemix(blob: Blob) {
const body = new FormData();
body.append("payload_json", JSON.stringify({
content: "",
attachments: [{
id: 0,
filename: "remix.png",
flags: 4
}]
}));
body.append("files[0]", blob, "remix.png");
RestAPI.post({
url: `/channels/${Util.getCurrentChannel().id}/messages`,
body,
});
}
i see
spark pivot
look at voice message plugin
export function sendRemix(blob: Blob) {
const currentChannelId = Util.getCurrentChannel().id;
const reply = PendingReplyStore.getPendingReply(currentChannelId);
if (reply) FluxDispatcher.dispatch({ type: "DELETE_PENDING_REPLY", currentChannelId });
const upload = new CloudUtils.CloudUpload({
file: new File([blob], "remix.png", { type: "image/png" }),
isClip: false,
isThumbnail: false,
platform: 1
}, currentChannelId, false, 0);
upload.on("complete", () => {
console.log(upload);
RestAPI.post({
url: `/channels/${currentChannelId}/messages`,
body: {
channel_id: currentChannelId,
content: "",
nonce: SnowflakeUtils.fromTimestamp(Date.now()),
sticker_ids: [],
type: 0,
attachments: [{
id: "0",
filename: upload.filename,
uploaded_filename: upload.uploadedFilename,
size: blob.size,
flags: 1 << 2,
}],
message_reference: reply ? MessageActions.getSendMessageOptionsForReply(reply)?.messageReference : null,
},
});
});
upload.on("error", () => showToast("Failed to upload remix", Toasts.Type.FAILURE));
upload.upload();
}
the image sends but no remix tag
austere talon
message type 0 is likely wrong
spark pivot
what should it be then
charred monolithBOT
odd heath
0 seems correct
spark pivot
there isn't any other ones
odd heath
but it should be 19 for the reply case
spark pivot
replys still work on 0 lol
odd heath
oh
spark pivot
anyway it looks like discord strips out any attachment flags when you send them
so i don't think it's possible sadly
spark pivot
true
mobile just sends everything normal except the attachment has flag 4
actually the CloudUpload platform param might do something
well it just breaks if i change it so thats a no
austere talon
discord type
is it connected to a webpack export
you'd usually put it in webpack commons
see how types work there
topaz thistle
lol????
austere talon
patch-2
rancid dragon
Engineer's pronouns on discord are just the word "Engineer"
at least based on the id used in the author field
austere talon
webpack
search for the class in sources and you'll find the module
you can findByProps it
crude hearth
impressive
median rapids
@crude hearth why are you not the latest and greatest Windows 11
crude hearth
Windows 10 better
median rapids
norp
charred monolithBOT
shy veldt
```ts
export function sendRemix(blob: Blob) {
const currentChannelId = Util....
its not flags: 1<<2
its is_remix: true
then it will work
:3
shy veldt
it didnt work lol
how come
spark pivot
oh nvm just had to be in all caps
shy veldt
what?? π
shy veldt
issue of skill :3
spark pivot
clearly it is a skill issue then
i prob reloaded before it could finish building
anyway it work
shy veldt
why does docs say its a flag then
which docs https://cdn.discordapp.com/emojis/1047507626801516604.webp?size=512&name=clueless&quality=lossless
shy veldt
clearly use https://docs.discord.sex
while it doesnt have that you need to send is_remix, is_clip, is_thumbnail
it will.
spark pivot
ok time to make this look good and pr
oh yeah how can i load the color picker cause it doesnt find the module until you load the color picker somewhere else
shy veldt
oh yeah how can i load the color picker cause it doesnt find the module until yo...
see how ClientTheme settings page does that?
findComponentByCodeLazy(".Messages.USER_SETTINGS_PROFILE_COLOR_SELECT_COLOR", ".BACKGROUND_PRIMARY)");
idk
spark pivot
yeah but it finds nothing if you havent loaded the color picker yet
I did something similar for the file upload button cause i stole that from some plugin
shy veldt
yeah but it finds nothing if you havent loaded the color picker yet
does it?
i reloaded discord and it found it fine
spark pivot
whar
i reload discord and test the find and it says nothing
then i go to settings page and it works
shy veldt
well idk
spark pivot
crude hearth
dzuriwa
crude hearth
hello
shy veldt
are discords devtools lazy loaded or nah
since I'm pretty sure that their devtools have color picker
crude hearth
have you tried wndows 10
shy veldt
have you tried wndows 10
nop
crude hearth
soon
charred monolithBOT
austere talon
oh yeah how can i load the color picker cause it doesnt find the module until yo...
you need to force load it
charred monolithBOT
spark pivot
you need to force load it
how
charred monolithBOT
charred monolithBOT
Potentially also there is an issue after a certain period of time of a guild being unopened events stop being dispatched but this is only an intuitive guess that should be checked
I don't think so as this worked for me
charred monolithBOT
spark pivot
it does now <:blobcatcozy:1026533070955872337>
does it?
mortal fractal
i feel bad for whoever has to review this pr
spark pivot
the voices
jagged cloak
horror
charred monolithBOT
fringe basalt
probably because of guild subscriptions
you'd have to dispatch gateway opcode 14 or 37 to subscribe to their events
charred monolithBOT
verbal pumice
there's probably info about it on https://discord-userdocs.vercel.app
or the funny alternative url https://discord.sex
fringe basalt
the client has a function called updateGuildSubscriptions() i think?
you could use that one
i can get on pc in a moment and see
fringe basalt
from a quick look at the caller, you should be able to dispatch GUILD_SUBSCRIPTIONS_FLUSH instead
tho im not exactly sure what params do you need to subscribe to the members voice events
that'd be something for dolfies xd
nvm figured it out
you only need typing: true
so something like this should workjs FluxDispatcher.dispatch({type: "GUILD_SUBSCRIPTIONS_FLUSH", subscriptions: {"guild id": {typing: true}}})
don't send a separate event for every guild
you can combine them all into the subscriptions field
limber skiff
you could also patch the gateway somewhere to log everything you send, and check what events are sent when you open a large server
that way you can mimic exactly what discord does
fringe basalt
you could also patch the gateway somewhere to log everything you send, and check...
you can just use this
also this is exactly what discord does
fringe basalt
yeah except discord subscribes to more events
limber skiff
why is it typing true π€
fringe basalt
but there's no need to do that in the background for that person's plugin
so just typing is fine
fringe basalt
why is it typing true π€
Β―_(γ)_/Β―
ye
op 36 is request channel statuses
it's why you see a CHANNEL_STATUSES response
(aka irrelevant here)
ye
you don't need to subscribe to other events, just typing is enough for voice updates
austere talon
pretty sure this is a terrible idea
the inbox does this and if you're in a lot of guilds it gets you rate limited from the gateway and disconnects you
fringe basalt
inbox subscribes to individual channels
this doesn't do that
also the client is already subscribed to non-big guilds like that by default
austere talon
the inbox does this and if you're in a lot of guilds it gets you rate limited fr...
https://github.com/Vendicated/Vencord/pull/552
but fixed now apparently https://github.com/Vendicated/Vencord/commit/a82544e93ed72f445fd35b007e7b03851b530d2f
anyway it's still a bad idea i think
fringe basalt
but why
austere talon
personally im in a lot of very large guilds
the performance impact of subbing to all of those is probably bad xd
there's a reason discord doesn't do it by default
what's this for anyway
fringe basalt
a vc timer plugin i think
austere talon
why do you need to be subbed to all guilds for that
so you can show timers for random guilds you don't normally use?
fringe basalt
they're trying to track the times since client start i believe yeah
austere talon
i would just forget about these, you're not gonna have an accurate time anyway if people are already in vc when you open the client
just only use the guilds discord is already subbed to
but also why do u even care how long random people were in vc for
crude hearth
https://github.com/Vendicated/Vencord/pull/552
but fixed now apparently https:/...
did they
opening inbox tab still causes death on my discord
oh nvm now its running smoothly
increadible discord
hazy scaffold
austere talon
will see what else can be added and then maybe make a release
but i also really wanna get auto updating ready sooon
cause its inconvenient otherwise
turbid hatch
yes but when you tried it did you have issues with rpc if you ever played
austere talon
yes but when you tried it did you have issues with rpc if you ever played
dunno i didnt test
turbid hatch
shrug
i commented on the issue
one of the assumptions is really bad about multiple clients
but besides that it seems like an okay doc change
median rapids
for guilds you aren't subscribed to, discord will periodically sync you the voice states
through the PASSIVE_UPDATE_V1 event
so you don't have to do this
median rapids
why is it typing true π€
you need to subscribe to typing events to subscribe to the guild
for... reasons
charred monolithBOT
austere talon
please someone with this issue investigate why it happens #π₯-vencord-support-π₯ message
i dont have the issue
the only time my vesktop suspends is when my pc suspends but thats to be expected, also happens with stock discord
austere talon
horror
vale idol
interesting thing, i found an extension that's able to disable CSP in firefox, which i thought was basically impossible because of extension restrictions
maybe a variant of this could be used to make the vencord firefox addon work again?
austere talon
vencord does exactly that
vale idol
oh huh
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/browser/background.js#L11-L32
**background.js: **Lines 11-32
chrome.webRequest.onHeadersReceived.addListener(
({ responseHeaders, type, url }) => {
if (!responseHeaders) return;
if (type === "main_frame") {
// In main frame requests, the CSP needs to be removed to enable fetching of custom css
// as desired by the user
removeFirst(responseHeaders, h => h.name.toLowerCase() === "content-security-policy");
} else if (type === "stylesheet" && url.startsWith("https://raw.githubusercontent.com/")) {
// Most users will load css from GitHub, but GitHub doesn't set the correct content type,
// so we fix it here
removeFirst(responseHeaders, h => h.name.toLowerCase() === "content-type");
responseHeaders.push({
name: "Content-Type",
value: "text/css"
});
}
return { responseHeaders };
},
{ urls: ["https://raw.githubusercontent.com/*", "*://*.discord.com/*"], types: ["main_frame", "stylesheet"] },
["blocking", "responseHeaders"]
);
i see
seems like for the Last FM Scrobble presence to work it needs to unblock the endpoint URL for it as well
austere talon
interesting thing, i found an extension that's able to disable CSP in firefox, w...
you shouldnt use this btw
it disables csp on all websites = shit security
austere talon
**background.js: **Lines 11-32
```js
chrome.webRequest.onHeadersReceived.addList...
this only disables discord csp but mozilla doesnt allow it
vale idol
i was hoping to find an extension that lets me modify it in a more fine-grained way
austere talon
so cant be on store
no cause its against mozilla rules
if u find an extension that does it on the store, its just mozilla being dum dum
vale idol
LMFAO
austere talon
they didnt notice it in vencord for like a year then suddenly flagged it
austere talon
ya not allowed
use firefox nightly and just install vencord
or use a firefox fork that enables installing extensions
mozilla kinda cringe
vale idol
yea..
austere talon
"we care about freedom and decentralisation" until you try to install an extension that doesnt follow their expectactions
vale idol
theres a problem specifically with the LastFMRichPresence plugin which fails due to CSP because it reaches out to ws.audioscrobbler.com
i could just like, use vesktop but apparently the webview for it cant use bitmap fonts so it uses the vector version which looks awful
lime stone
the only time my vesktop suspends is when my pc suspends but thats to be expecte...
maybe they just have a shorter suspend timeout?
median rapids
LMAO
lime stone
when i suspend i often get logged out though
livid heath
extremely rare firefox W i guess
firefox Ws are not rare smh
vale idol
firefox Ws are not rare smh
name another W it has then
(no, being not chromium doesn't count)
vale idol
better dev tools are kind of subjective, firefox doesnt have lighthouse and stuff for example
austere talon
better dev tools
lie
i hate firefox devtools so much
horrible
cannot use that shit
olive aurora
ff devtools is only good at css
austere talon
doesnt even have https://developer.chrome.com/docs/devtools/console/utilities
olive aurora
lighthouse u can run anywhere though
livid heath
we'll not talk about that
austere talon
you shouldnt use lighthouse in devtools cause its inconsistent
vale idol
you shouldnt use lighthouse in devtools cause its inconsistent
this is also true lmao
livid heath
i cba to ever add aria-* stuff
olive aurora
this one color renders the page completely unsightreadable
aria is v simple but you don't need it most of the time
if you use html properly
olive aurora
horror
austere talon
this one color renders the page completely unsightreadable
this is whats failing btw
imo thats enough contrast
devtools disagrees
olive aurora
prob not accounting the font size/weight
austere talon
oh im 0.02 off
it needs to be 3 i have 2.98
thats why it looks fine, cause it is fine (nearly)
olive aurora
trolled
