#👾-core-development

1 messages · Page 157 of 1

turbid hatch
#

nvm that looks fine to me

#

although i might just be php brained atm

#

(php has {$interpolation})

austere talon
# 
https://google.com/search?q=$1<urlComponent>

🔥

turbid hatch
#

oh christ

#

$1<uriComponent>

austere talon
#

mm

turbid hatch
#

its not bad per se but <>

#

hm

#

although i suppose those arent too hard to type?

#

and its unambiguous when parsing

#

with the toggle then there is no issue

charred monolithBOT
crude hearth
#

Holy sheet its the famous Vencord plus

#

I think you should listen to it ven

charred monolithBOT
crude hearth
#

Lets goo

#

GUHHH

austere talon
#

(i don't eat lunch blobcatcozy)

crude hearth
#

Just review the diff

#

Explodeeeee

turbid hatch
#

Today I will Self-Review my Code

#

yes i think my PR looks good

#

i will merge

#

@austere talon

#

that is a fat commit description

#

holy

#

also why does it have like 3 prs in it

#

is that just the result of me manually merging stuff

austere talon
#

how's bd usercss doing anyway

turbid hatch
#

not

#

they stopped working on the branch a couple of months ago, idk how far it is from completion

#

but it seems relatively easy to implement so i dont know whats taking them so long

#

all of the changes in the usercss pr from now have mainly just been bugfixes of really silly stuff that would've most likely been caught in review anyway

#

4 months ago was the last commit

image.png
#

so i dont know how long it's going to take for it to release

#

i dont think we should bother trying to follow BD's release date on the feature

#

we've already got a standards-compliant usercss system with an extension to support plugins (via vc-requiredPlugins)

#

dont use that one

#

use my fork's branch

#

cause that's where they actually go to xd

#

the feat/usercss branch on vencord was an accident

#

it prevents you from enabling themes now as well if you dont have the plugins on just to discourage you from using themes wrong

#

but its just a csv of plugin names you want

#

so

#

a,b,c would require plugin a, b, and c to be enabled

crude hearth
#

I will make a everything plugin which will depend on all plugins

turbid hatch
#

some themes might theme the spotify component

#

so you might want SpotifyControls in that list too

#

though of course if its optional then no :p

turbid hatch
charred monolithBOT
charred monolithBOT
turbid hatch
#

that'd be vee though

#

not me

thick kestrel
#

this quote should be forever preserved

obraz.png
#

actually @turbid hatch did you figure out the weird issue I was having on Vesktop

turbid hatch
#

which one

thick kestrel
#

basically themes disappearing

#

actually I'll just pull and test again

turbid hatch
#

oh yeah i think i did

#

it was an issue with the web stubs

thick kestrel
#

yeah they show now! great, now I can actually test it

#

ok themes are broken

#

I swear, I can find weird bugs without any effort

#

how do I see loaded CSS in Chrome devtools?

#

equivalent of this in Firefox

obraz.png
turbid hatch
#

go to elements and findd the vencord themes style tag, should be at the bottom

#

all loaded themes go there

#

@thick kestrel

#

you can then look in the network tab to find the content

thick kestrel
#

okay, it looks like the theme is loaded, so that's weird

#

I'll try a simpler theme

#

@turbid hatch the issue is that the @-moz-document declaration isn't removed

turbid hatch
#

guess i have to parse it

#

if you remove the declaration it works right

thick kestrel
#

yeah

#

it is required by the spec as regular userstyle managers need to know when to apply the style and when not to

#

here it doesn't really apply, but it would be good to support it, so we don't have a separation between Vencord userstyles and regular userstyles

turbid hatch
#

suppose so

thick kestrel
#

I guess it could apply if you used a theme that supported other websites alongside Discord...

#

that's rather rare I think

turbid hatch
#

tbf

#

@document hasnt been supported for a long time

#

usercss managers shouldnt be adding it

#

it never made it into any release

image.png
#

its only really part of the spec for legacy reasons

thick kestrel
#

it isn't supported by browsers, yes

#

and you shouldn't use it for your website

turbid hatch
#

yeah but the compiler uses it because

#

of course it does

#

its really stupid

#

its the only thing i know that actually supports or requires this

thick kestrel
#

think of it as a CSS extension for userstyles

turbid hatch
#

its funny cuz it doesnt actually

#

use it properly

#

its just parsing it

# 
/**
 * Extracts @-moz-document blocks into sections and the code between them into global sections.
 * Puts the global comments into the following section to minimize the amount of global sections.
 * Doesn't move the comment with ==UserStyle== inside.
 * @param {Object} _
 * @param {string} _.code
 * @param {boolean} [_.fast] - uses topDocOnly option to extract sections as text
 * @param {number} [_.styleId] - used to preserve parserCache on subsequent runs over the same style
 * @returns {{sections: Array, errors: Array}}
 * @property {?number} lastStyleId
 */
#

i dont really wanna do this cause it sucks

thick kestrel
#

yeah, since it's not part of the current CSS spec

#

it's only part of the userstyle spec

turbid hatch
#

tempted to just say "fuck it" and not do it

thick kestrel
#

it's part of the spec though 😭

#

and it also makes sense for userstyles

#

since how else would you tell the manager when to apply the style

turbid hatch
#

tbf i could just ignore the moz-document stuff

#

but then i have to write it in a compatible way between compilers

#

blegh

thick kestrel
turbid hatch
#

the thing is that the entire stylus extension is really

#

not written very well

#

its using require.js and stuff

#

so its going to take a while to port

thick kestrel
#

not supporting that creates a gap between the spec and what's in Vencord, effectively making a second de facto standard. which in turn also makes it harder for theme devs to support both Vencord and regular userscript managers.

#

so I think it's worth to support it even if it's not easy.

turbid hatch
#

i mean we're already causing issues with the spec SilvGiggle

#

@vc-requiredPlugins and if vencord { } are technically spec violations

#

you have to tell the parser to ignore it to make it work

#

(which is very stupid btw, it means old parsers cant parse new code even if it could just ignore the new attribs)

#

i can try to get this to work but its

#

blegh

thick kestrel
#

true

turbid hatch
#

essentially, vencord-specific usercss wont work on standard usercss extensions anyway

#

because the parsers on the extensions are too strict by default and theres no way to tell them to ignore it

thick kestrel
#

but it'd only be incompatible one way, not another

turbid hatch
#

true, i can try and make extension usercss work

#

well ill see how this goes

#

because this entire thing is using a parser with a ton of vulnerabilities in it so i dont think its a good idea to use SilvGiggle

#

the css parser module also has vulns and doesnt even parse css properly

thick kestrel
#

if many themes will start using the Vencord-flavored userstyles, it will basically exclude web users entirely

#

and if a theme would want to support both regular userstyles and Vencord ones, it'd need two separate releases, which is a pain

turbid hatch
#

(youll need to do that to avoid the aforementioned @vc-requiredPlugins problem)

#

actaully

#

ah nvm

lime stone
#

also, why would a theme depend on a plugin

turbid hatch
brazen bone
#

Why would you need @vc-requiredPlugins anyway?

lime stone
#

oh, i guess some add classes

turbid hatch
#

themeattributes

#

because it makes some themes work

#

so if its not present the theme just doesnt work

lime stone
#

just make themeattributes a required plugin anyway

turbid hatch
#

also platformindicators was mentioned earlier

lime stone
#

yeah but it's not like not having the plugin would cause issues for the theme?

turbid hatch
#

uh

#

yes

#

it would

brazen bone
#

Put that in the header comment then

turbid hatch
#

if a theme expects themeattributes to exist then it will most likely break

thick kestrel
#

this will sound stupid

turbid hatch
lime stone
#

I mean platformindicators

thick kestrel
#

but what about a second header

turbid hatch
#

users probably dont care

#

to open a file just to work it out

#

its a safety thing in the usercss stuff

lime stone
#

if your theme affects platformindicators you still shouldn't force users to use the plugin

turbid hatch
#

it flags up as an error

turbid hatch
#

silly

thick kestrel
lime stone
#

people may assume that's how you're meant to use it 😭

thick kestrel
turbid hatch
#

its documented as "Required plugins for this style to work." not "Plugins that this theme affects"

thick kestrel
#

the other way would be to talk about this with the people maintaining the actual library

turbid hatch
turbid hatch
lime stone
#

hmm. apart from for ThemeAttributes I'd argue it's not really necessary

turbid hatch
#

im giving people the option

#

because it also allows people to make snippets for plugins as usercss

#

that can be modified using the settings UI

#

it wouldnt make sense to allow those snippets to run if the plugin isnt enabled

#

:p

lime stone
#

from a ux perspective what happens if you try to disable a plugin required by a theme

turbid hatch
#

it disables the theme card and shows a plugin icon that, when hovered, tells you what plugins are required

brazen bone
#

:root:not([data-vc-plugins*="ThemeAttributes"])::before { content: "ThemeAttributes is required" }

turbid hatch
#

that is an awful idea

turbid hatch
grave mangoBOT
turbid hatch
#

this is their official way of doing it

#

unknownKey: assign

brazen bone
#

Less awful than breaking css spec

lime stone
#

will this vencord extension to the specification actually cause problems with extensions?

turbid hatch
#

i dont know, i assume so, because the parser errors when it encounters unknown attributes by default

#

its stupid

#

it doesnt just ignore them

lime stone
turbid hatch
#

maybe

lime stone
#

or maybe use their own lib to begin with?

turbid hatch
#

well lets test

lime stone
#

it'd be totally against the way css and html works to not load it if there are any errors

turbid hatch
#

also it looks like @-moz-document isnt supported anymore

lime stone
#

:p

turbid hatch
#

my userstyle manager just told me when i pasted the moz-document syntax that its the old legacy syntax

#

its called "mozilla format" when you paste it and "classic mode" when you try to use it

#

so it looks like the managers just

#

do it directly

#

oh it does work

#

okay thats not a problem then

#

i guess its just something funny with my parser

#

lol

#

yeah

thick kestrel
turbid hatch
#

it specifically says

#

that the mozilla version of the usercss

thick kestrel
turbid hatch
#

aka moz-doc

#

is only supported with classic managers

turbid hatch
lime stone
#

worst case couldn't you add a entirely different vencord header xd

#

instead of needing two files

turbid hatch
#

it only happens when you paste something with -moz-doc in

#

its their name for the classic one

turbid hatch
#

need to

#

i dont know how this owrks

#

lol

#

wait

#

OH

#

THIS IS A STYLUS THING

#

LOL

#

THIS IS STUPID

lime stone
thick kestrel
turbid hatch
#

write new style -> paste

#

ive worked it out

#

its a thing with how stylus does stuff

#

it has its own format for storing this stuff

#

then it also has usercss support

#

okay

#

right

#

that makes sense

#

it complains but it doesnt seem to have an issue with it beyond that

image.png
#

right mystery solved

#

okay

#

now i need to find something to parse this shit

lime stone
thick kestrel
thick kestrel
turbid hatch
#

usercss sucks lol

#

too many different things with too many different extensions

#

:p

#

okay i think ive worked it out

thick kestrel
#

it's old

#

old standards tend to suck

lime stone
#

it's horrifying

lime stone
turbid hatch
#

im just going to assume the first -moz-doc is the discord mozdoc

#

lol

thick kestrel
#

I mean... that's fair

#

somebody can improve on that later

#

it will most likely cover 99% of use cases

#

also, a feature suggestion

#

actually I think there's also a bug attached to it nevermind

#

I set those to be disabled by default in the header

image.png
#

but they are enabled by default instead

turbid hatch
#

hm?

#

hm

thick kestrel
#

the text ones work correctly

obraz.png
#

the checkbox ones don't

turbid hatch
#

that would be a bug with the parser most likely

#

but i would double check

#

are you setting it to 1/0 or true/false

thick kestrel
#

1/0

#

is that perhaps wrong...? I didn't doublecheck that

turbid hatch
#

no it is correct

#

1/0 is the right serialisation

#

im just trying to work it out

thick kestrel
#

yeah

turbid hatch
#

derp

thick kestrel
#

as for the feature suggestion - it'd be nice to have a "restore to defaults" option for either every setting separately, all of them at once or both

#

Stylus has that and it's handy

turbid hatch
#

checkbox parsing should be fixed

turbid hatch
#

would be useful

#

i could add it as a button at the top

thick kestrel
#

found another bug - after removing a theme and restarting Vencord this pops out repeatedly. not sure what's the exact condition for it to do that, but it just happened now.

image.png
turbid hatch
#

it wont happen again

#

you removed it whilst it was enabled didnt you

thick kestrel
#

yes

turbid hatch
#

fun

#

yeah its the equivalent of deleting it off of the filesystem

thick kestrel
#

I did exactly that, went to the themes directory and pressed Delete

#

lol

turbid hatch
#

yeah if you do that

#

then

#

it doesnt know the theme has been removed until it tries to compile it

#

you should disable the theme first then delete it

turbid hatch
#

not just the file not existing

#

so

thick kestrel
turbid hatch
#

i mean it does work

thick kestrel
#

so it's probably a good idea to safeguard it somehow

turbid hatch
#

it wont load it again after that point

thick kestrel
#

so if I restart it should be gone?

turbid hatch
#

yes

#

if you restart again it wont error

#

because it auto disables it

thick kestrel
#

I did a soft restart and it still pops out lol

turbid hatch
#

compiler errors on start mean the theme wont be loaded again

#

right then thats broken on vesktop ig

thick kestrel
#

I'll try a hard restart

#

yep, still there

#

gonna readd the theme and disable it lol

#

that worked so there's that

#

also it's weird because it repeatedly popped out

#

I mean, it was notification spam lol

#

after it disappears another appears in it's place

turbid hatch
#

it should only show once

#

it only compiles once on startup

thick kestrel
#

from what you're saying it sounds like it should only show once... exactly

turbid hatch
#

and once when you enable it (after it being disabled)

thick kestrel
#

so yeah... it doesn't. if you say that's a Vesktop issue then it probably is.

charred monolithBOT
thick kestrel
#

btw, why doesn't that notification use the usual Vencord notification system?

#

the kind that pops out in the bottom right corner

turbid hatch
#

it uses toasts

#

we use toasts in a few places

#

mainly for short lived notifications that dont really matter

austere talon
#

toast delicious

turbid hatch
#

yes

thick kestrel
turbid hatch
#

anyway can you pull and recompile

#

and see if it works

turbid hatch
#

unless it only shows when you hover

#

hm

#

that wouldnt be too bad of an idea

thick kestrel
#

I'd make it appear only on modified settings, and only be a small "X" on the right of the textbox

#

that would not be cluttered in my personal opinion

turbid hatch
#

ill leave it like that for now

#

but i think on hover would work fine

thick kestrel
#

I guess it would be good as well

#

I love my bug luck

obraz.png
#

there's three errors on that screen

#

I pressed the new restore to defaults button

turbid hatch
#

what the fuck

#

lmfao

#

OH

#

OKAY

thick kestrel
#

what's the "That also failed :(" dialog for actually

turbid hatch
#

recovery

thick kestrel
#

I've never seen that before

#

oh

#

guess it just doesn't happen on web

#

makes sense as that's a native pop-out

thick kestrel
turbid hatch
#

yeah

austere talon
turbid hatch
#

just me being silly

austere talon
#

when you crash, it tries to recover from the crash by closing everything and rerendering

#

it tries a few times then it gives up

#

if it still fails it checks for updates and if there is an update prompts you to update

#

if update also fails it shows "that also failed"

turbid hatch
#

@thick kestrel try

thick kestrel
#

works great, both the checkbox defaults and restoring

turbid hatch
#

i did a silly

#

thats all

thick kestrel
#

👌

turbid hatch
#

i reset the settings by deleting them, and then tried to render them

#

but

#

its empty

#

so there are no settings

#

so it crashes

thick kestrel
#

lol

turbid hatch
#

closing the dialog first and then forcing a refresh fixes it because then it reinits the settings from scratch

#

magic

#

(which was the intended effect)

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
turbid hatch
# charred monolith

re armcord: they use a custom window frame completely done in html, whilst discord and vesktop do not, which means it wouldn't actually be a native appearance (and you can see it in the armcord window, it doesn't fit the GTK buttons or window theme because you have to turn the frame off).

charred monolithBOT
lime stone
#

with gnome 40+ i believe adwaita is the only officially supported theme (or maybe it was always like that :P)

charred monolithBOT
#
NolonQ
[Vencord/Vesktop] Issue opened: #334 Streaming with audio does not work

Describe the bug
No matter which streaming quality i select in vesktop, when the "stream with audio" option is enabled, nothing happens when i klick start streaming / go live. I can stream in over 1080p with vesktop which doesn't work with normal discord unless you're retarded enough to pay for that, however when streaming with vekstop only works if the "stream with audio" option is disabled.
What causes this issue? Can the developers reproduce this? Can i fix this anyhow?

**To Repro...

mortal fractal
#

it wouldnt be hard to implement

turbid hatch
#

i just said that's what armcord does on linux

#

but on linux, discord does not

mortal fractal
#

yeah and im saying just reuse the windows one as an option

turbid hatch
#

could do

charred monolithBOT
#
CodaBool
[Vendicated/Vencord] Pull request opened: #2110 feat(plugin): Toggle sidebar hotkeys

:warning: low quality

I am a bit out of my depth on this one. This PR would require some attention and care to bring it up to other Vencord plugin standards. I am willing to work with other contributors to make this happen but won't happen overnight.

My hope is that the usefulness of this plugin will come across and others can feel inspired to help me make this happen.

If that interest doesn't materialize, this can be closed.

:triangular_flag_on_post: Functionality

This adds a ...

turbid hatch
#

oh dear

spark pivot
#

What is bro yapping about

mortal fractal
spark pivot
#

It uses hot keys

mortal fractal
#

and it uses dom manipulation, whats your point

spark pivot
#

Also doesn’t use eslint and doesn’t use typescript typing at all

#

So yeah this gonna get closed

#

Well this kinda requires dom manipulate cause discord wouldn’t have code to close either of those

mortal fractal
#

i could make something better but i shrimply do not care

mortal fractal
#

shrimply add a button and hotkey listener to have it add class names and animate it css if desired

jagged cloak
turbid hatch
#

new vencord usercss extension

# 
@keybind (shift a) {
    .apply {
        this: property;
     }
}
still wasp
jagged cloak
#

real

#

usercss when

turbid hatch
#

i think i fixed the last major bug today

#

so it just needs codereview and we should be okay

still wasp
charred monolithBOT
still wasp
# charred monolith

I love the giant black bars that make it hard to see what the plugin even does NAH

charred monolithBOT
lime stone
#

i missed shitposting on jason citron's profile

charred monolithBOT
jagged cloak
#

true

lime stone
#

you should give me admin so i can pretend to be jason

#

why do i get the nice reviews pleadey

image.png
#

can somebody say something really horrible

still wasp
lime stone
#

i can delete it now

#

i might do a pr to open reviews in the model!!???

#

would that be appreciated

austere talon
#

wdym

lime stone
#

profile modal

#

instead of custom dialog

#

although maybe it's too small

#

would be nice to open reviews somehow from the modal

#

:O big brain idea could be just growing the modal like is done with serverinfo trolley

#

or having show reviews in the context menu so you can access it from the three dots

austere talon
#

i still dont understand

#

this is what u want?

image.png
lime stone
austere talon
#

horror

#

idk if thats useful

#

there are alr way too many tabs

lime stone
#

add it under the ... then?

#

otherwise it's super annoying to get their reviews

#

you need to copy id, ping them in a dm

austere talon
#

idgi

lime stone
#

say you've opened the profile from the members page where you can't open the popout

#

this would come in handy

image.png
long stream
#

putting it there means only like, 2 people would actually know its there

lime stone
#

not really?

#

it's where the rest of the actions are

#

might as well add it for consistency with guilds

#

maybe also move the view reviews below server info, and add it to the right-click menu as well as the arrow menu...

still wasp
#

It looks kinda clunky when its crammed in the user info

lime stone
#

there's less space in the modal

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
charred monolithBOT
still wasp
#

The discord link not work 🗣️

fringe basalt
#

the invite works fine, if that's what they mean

charred monolithBOT
fringe basalt
#

they made the same issue in vendetta 😭

chrome_vr4aZXFqtA.png
charred monolithBOT
junior olive
#

a 4th tab for reviews is fine imo

cunning canyon
#
  • activity tab
    + mutual group dms tab
fringe basalt
#

yop

#

no space for more tabs

DiscordCanary_jxSh4aEFy5.png
jagged cloak
#

eated them all

junior olive
fringe basalt
#

nop

median rapids
#

make it

charred monolithBOT
charred monolithBOT
glass jasper
charred monolithBOT
#
FL4MIN
[Vendicated/Vencord] Issue opened: #2112 [FEATURE REQUEST] SpotifyControls - Toggle to swap the player location from bottom to top

Content

Dear devs,
Could be possible to kindly consider adding a toggle to swap the player location from bottom to top in SpotifyControls plugin?

  • Example:
    image

If the request really goes against the rules please delete it or redirect me to the right place.
I couldn't find any other place where to make a feature request (checked on Discord already).

Request Agreement

  • [X] I ...
cunning canyon
#

css

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
#
katlyn
[Vendicated/Vencord] Pull request opened: #2113 feat(plugin): RedirectYouTube

This is more of an experiment than anything else, and I'm not really sure if the way that the patchCspDirective function is done is a way that fits well with the rest of vencord's codebase - in any case though, I decided that making a draft PR would be good to get feedback and potentially discuss other options.

I'm fairly hesitant about the currently hardcoded instances, perhaps the defaults could be updated every so often if needed. There is an API we could query as well but this is ver...

golden gulch
#

@austere talon here is the result of my messing around with things tonight, it's not very polished at all but I mostly wanted to get the idea of manipulating CSP headers out there now that it's easier to do with the native plugin code

#

it's entirely possible I missed how to let iframes bypass csp by patching them like with fixspotifyvolume, but from what I saw there wasn't a way to modify the src of a frame directly

#

also i haven't actually tried it with piped yet, I assume it works though

#

will try in the morning

charred monolithBOT
olive aurora
#

i think itd be neat if csp was patched based on settings

#

its possible afaik

#

so it only allows the instance you set it to

golden gulch
#

that is what this pr does, yeah

#

it wasn't this easy to implement until the plugin specific native code though (at least, this feels a lot cleaner than it might have been before)

golden gulch
#

thinking about it, this approach could also be used for any plugins that include external scripts

brazen bone
#

Native means running in the electron host, right?

charred monolithBOT
charred monolithBOT
austere talon
#

it's already very full even without mutual groups plugin

charred monolithBOT
fringe basalt
#

can't fool me

olive aurora
#

but its just a default list

austere talon
#

before next vesktop release: make it also migrate indexeddb from old location

#

maybe also localStorage but i think localStorage is purely used as cache by discord and token (need to relogin but eh it's OK)

charred monolithBOT
crude hearth
#

never

charred monolithBOT
austere talon
#

blocked

#

he's not even banned

turbid hatch
lime stone
austere talon
#

tried to ping everyone with an invite (spam bot)

#

so he was actually hacked but tbh i don't even wanna unban now

lime stone
#

how is one meant to appeal xd

austere talon
#

not by shitting up the git repo

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
rare shale
#

serious discussion before I actually start implementing this - adding an option to message logger to make it so in edited messages, removed/added words are easier to see (something like a diff file?)

brazen bone
#

I'm not sure how well that would work with markdown formatting

charred monolithBOT
austere talon
#

jumpscare

austere talon
brazen bone
#

I've made a plugin for that

#

Doesn't do any diffing, but flipping back and forth usually makes it easy to tell

charred monolithBOT
austere talon
# 
mainWindow.webContents.setWindowOpenHandler(({
  url,
  frameName,
  features
}) => {
  if (frameName.startsWith(DISCORD_NAMESPACE) && (0, _securityUtils.checkUrlOriginMatches)(url, WEBAPP_ENDPOINT) && getSanitizedPath(url) === '/popout') {
    return popoutWindows.openOrFocusWindow(url, frameName, features);
  } else if ((0, _securityUtils.shouldOpenExternalUrl)(url)) {
    (0, _securityUtils.saferShellOpenExternal)(url);
  }
  return {
    action: 'deny'
  };
});
#

need to reverse engineer this a bit and implement the same for vesktop

grizzled epoch
#

vscode-neovim is so fire

#

Should I use main or dev as base branch for contributions? @austere talon

#

oh sorry for the ping

charred monolithBOT
austere talon
#

dev

charred monolithBOT
grizzled epoch
#

oki

austere talon
charred monolithBOT
placid wave
charred monolithBOT
crude hearth
placid wave
#

@crude hearth Windows 11

charred monolithBOT
slim marsh
#

Vesktop-Based

grizzled epoch
#

LOL

topaz thistle
charred monolithBOT
placid wave
#

nicee

charred monolithBOT
inland fable
austere talon
#

its just discord popout code

austere talon
topaz thistle
#

I meant what it was responsible for but the commit message cleared it up

austere talon
#

no way

#

incredible

charred monolithBOT
brazen bone
austere talon
inland fable
#

WTF Vesktop Based

charred monolithBOT
topaz thistle
austere talon
#

ah ok

#

yep

charred monolithBOT
inland fable
topaz thistle
#

finally infected venmic 3.2.2

lime stone
# inland fable virus

we need a glossary which contains virus, EXPLOD, lmao, whitename and shiggy (the main words used in this server) blobcatcozy

topaz thistle
#

veectonary

charred monolithBOT
austere talon
#

btw noah there are a bunch of issues about venmic not linking the right nodes

#

are those all fixed in v3?

crude hearth
#

Vencord

topaz thistle
topaz thistle
austere talon
topaz thistle
#

Interesting, I'd have to know the steps to reproduce this and the input Vesktop calls venmic with

The latter is now logged by venmic so should be easy to find out

#

Can you transfer the issue?

austere talon
#

okay so once vesktop with new venmic is out we should ask them if it's fixed

#

if not you can debug it w them

topaz thistle
#

Yes

austere talon
#

actually this is a Linux user i can tell to run from source

#

actually no i don't wanna make them do that

topaz thistle
#

btw can you give me perms to transfer issues?

austere talon
#

cause latest update migrates your configs so if they run the new one and then keep using old it will fuck up their config lmao

austere talon
topaz thistle
#

nope

austere talon
#

you're an org member no?

topaz thistle
topaz thistle
austere talon
#

well you need vesktop write access to move issues

#

ill give you triage on vesktop maybe that's enough

lime stone
#

you need it on the source and target repo i thought

charred monolithBOT
lime stone
#

eh, my brain might have made that up

austere talon
#

try now

topaz thistle
#

I think I have full access on venmic

lime stone
#

abmin

topaz thistle
#

uhh looks like I can assign and close but not transfer

austere talon
#

now?

topaz thistle
#

Ah

#

Now its there

#

Yes

austere talon
#

lol discord dumb

charred monolithBOT
austere talon
#

you need write access to move issues

#

not just triage

topaz thistle
#

alright

austere talon
#

that's meh

topaz thistle
#

true

austere talon
#

i don't really wanna give u write access on vesktop

#

not cause i don't trust u but because it's unnecessary and best for security to give only permissions that are actually needed

topaz thistle
#

absolutely understandable

#

I'll just ask to transfer

austere talon
#

dumb that github does it this way, you're telling me the role that's literally issue manager can't transfer issues

topaz thistle
#

we could have a bot lmao

austere talon
#

oh god that's insane

#

hey @nimble pendant transfer this issue

topaz thistle
#

do it

#

haha

austere talon
#

i unironically might

austere talon
#

or message context menu command

charred monolithBOT
#
Curve
[Vencord/venmic] New tag created: v3.2.3
austere talon
#

is this relevant

#

do i need to bump again

topaz thistle
#

yes sorry

austere talon
#

😭

#

why does the order matter

topaz thistle
#

I move above

#

Don't know why I had it below

#

I blame sleep deprevation

austere talon
#

ya but does it actually matter

topaz thistle
#

Yes

austere talon
#

why

topaz thistle
#

After it's moved its garbage

austere talon
#

right cause you move it

#

funny

#

will it segfault

topaz thistle
#

no

#

it has to be in a valid state after being moved

#

but the log is basically useless then

austere talon
#

do u mean like zero value struct

topaz thistle
#

depends on the implementation

#

but for vector it's usually empty

austere talon
#

funny

charred monolithBOT
topaz thistle
charred monolithBOT
charred monolithBOT
charred monolithBOT
topaz thistle
#

@austere talon I think the publish is done now

#

can you update?

charred monolithBOT
austere talon
#

autogain

charred monolithBOT
#
WmeLuna
[Vencord/Vesktop] New comment on issue #333: Add a proper CSD that fits the application

The windows one works just fine on linux
i used this to enable it, though itd be nice to enable this for linux devices without this stuff:

Vesktop.Settings.store.discordWindowsTitleBar = true
Vencord.Settings.winNativeTitleBar = true 
Vencord.Settings.frameless = true
if (navigator.platform?.toLowerCase().includes("linux")) VCDP.getPlatformClass= () => {return "platform-win"}

the last line just makes this part rounded (i have the snippet in a plugin so it auto applys that)
!...

charred monolithBOT
#
MonsterObserver
[Vencord/Vesktop] New comment on issue #333: Add a proper CSD that fits the application

The windows one works just fine on linux i used this to enable it, though itd be nice to enable this for linux devices without this stuff:

Vesktop.Settings.store.discordWindowsTitleBar = true
Vencord.Settings.winNativeTitleBar = true 
Vencord.Settings.frameless = true
if (navigator.platform?.toLowerCase().includes("linux")) VCDP.getPlatformClass= () => {return "platform-win"}

the last line just makes this part rounded (i have the snippet in a plugin so i...

charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
#
Vendicated
[Vencord/Vesktop] New tag created: v1.5.0
austere talon
#

wait

charred monolithBOT
#
Vendicated
[Vencord/Vesktop] New tag created: v1.5.0
austere talon
#

The workflow is not valid. .github/workflows/release.yml (Line: 44, Col: 29): Unexpected symbol: '"mac"'. Located at position 20 within expression: matrix.platform == "mac" && secrets.APPLE_SIGNING_CERT

charred monolithBOT
#
Vendicated
[Vencord/Vesktop] New tag created: v1.5.0
austere talon
# 
# recreate tag
tag="$(git describe --tags --abbrev=0)"
gh api -X DELETE "repos/:owner/:repo/git/refs/tags/$tag"
git tag --delete "$tag"
git tag "$tag"
git push --tags

# recreate tag
$tag = git describe --tags --abbrev=0
gh api -X DELETE "repos/:owner/:repo/git/refs/tags/$tag"
git tag --delete "$tag"
git tag "$tag"
git push --tags
charred monolithBOT
#
Vendicated
[Vencord/Vesktop] New tag created: v1.5.0
austere talon
#

failed again :/

charred monolithBOT
#
Vendicated
[Vencord/Vesktop] New tag created: v1.5.0
austere talon
#

DSUJIAIOUJFUI)GJEIOFGIJOJIEO=GQJIOEGFJIOEG

#

I HATE ACTIONS

charred monolithBOT
#
Vendicated
[Vencord/Vesktop] New tag created: v1.5.0
austere talon
#

its finally working omg

#

surely noone will notice that i bumped from v0.4.4 -> v1.5.0

#

looks like mac worked @turbid hatch

#

oh i forgot to bump version ._.

charred monolithBOT
still wasp
charred monolithBOT
austere talon
#

I=UJWIJOFEJIOEFGJIOEFG

#

NBO

charred monolithBOT
#
Vendicated
[Vencord/Vesktop] New tag created: v0.4.4
#
Vendicated
[Vencord/Vesktop] New tag created: v1.5.0
austere talon
#

prepend that didnt happen

charred monolithBOT
still wasp
austere talon
#

i hate windows so much

#

btw @turbid hatch we should also sign the installer now

#

do u know how to do that with cli

#

looks like its just codesign cli

charred monolithBOT
austere talon
#

whats this again @turbid hatch

#

why not make it open pr in the flatpak repo

charred monolithBOT
#
Vendicated
[Vencord/Vesktop] branch deleted: ci/meta-update
austere talon
#

inb4 flagged as malware cause it reads "other app"'s (old "VencordDesktop") AppData/Roaming

charred monolithBOT
woeful sable
#

@austere talon when there’s a new vesktop update should the download not open in app like other links? it’s kinda inconsistent

austere talon
#

sorry what

still wasp
woeful sable
#

like when you click update now

#

it opens my browser to download

austere talon
#

that screen is going away anyway

#

in fabour of auto updates

woeful sable
lime stone
#

i've heard windows has a native system for auto-updates...

austere talon
austere talon
#

oh nvm

#

that uses squirrel

#

horror

#

i thought it supported same targets as electron-autoupdater

#

pain

woeful sable
#

shrimply create your own

charred monolithBOT
austere talon
#

:/

#

so bloat

#

not really possible to reduce size much without major rewrite

image.png
grave mangoBOT
# austere talon no wonder its so bloat when they add a dependency just for this https://github.c...

**main.ts: **Lines 1-27

export class Lazy<T> {
  private _value: Promise<T> | null = null
  private creator: (() => Promise<T>) | null

  constructor(creator: () => Promise<T>) {
    this.creator = creator
  }

  get hasValue() {
    return this.creator == null
  }

  get value(): Promise<T> {
    if (this.creator == null) {
      return this._value!!
    }

    const result = this.creator()
    this.value = result
    return result
  }

  set value(value: Promise<T>) {
    this._value = value
    this.creator = null
  }
}
charred monolithBOT
#
nekolifestyle
[Vencord/Vesktop] Issue opened: #336 Debian build has updating issues

Describe the bug
The latest release is not updating Vesktop to the latest build

To Reproduce
Steps to reproduce the behavior:

  1. Download the latest release as of now 1.5.0
  2. Install build and has no errors
  3. Vesktop is showing as older release 0.4.4
  4. Prompt is asking to update Vesktop again

Expected behavior
Should update to the latest release

Desktop (please complete the following information):

  • OS/Distro: Linux
  • Desktop Environment (linux only): ...
charred monolithBOT
charred monolithBOT
austere talon
#

NO

#

it keeps doing it to autumn

charred monolithBOT
lime stone
#

i really don't get what i'm meant to do here

#

it feels like it's been at least 5 business years since this comment

charred monolithBOT
charred monolithBOT
icy quest
icy quest
median rapids
charred monolithBOT
charred monolithBOT
charred monolithBOT
turbid hatch
#

and it should be upstreamed according to flatpak devs

charred monolithBOT
austere talon
#

unless we need it for anything else

#

btw merge that steam os pr

#

oh u did

turbid hatch
#

well it cant make a pr to fp anyway

#

however can u make one for me

#

to fix the flatpak

austere talon
#

as for update the fix should just be replacing vencorddesktop with vesktop everywhere

turbid hatch
#

cause its not called vencorddesktop anymore so it cant build

#

ye

#

im on mobile atm going to work

austere talon
#

im going to bed

turbid hatch
#

fair enough

#

delayed flatpak release

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
warped turret
#

How can I change channel position in category?

topaz thistle
warped turret
#

No, I'm asking about api. Tried different stores, but couldn't find a method

brazen bone
#

Drag a channel around and check in devtools what request is sent

warped turret
#

Oh, no I don't wanna send http request for doing this. I'm looking for api

brazen bone
#

Oh, client-only reordering?

warped turret
#

Of course no. A normal channel order change, but just with api. Exactly as discord is doing it when you drag a channel. Obviously it has a method that eventully sends an http request and I'm looking exactly for such a method.

#

What I want to achieve in the long run is having a context button that moves the channel to the top of its category.

charred monolithBOT
brazen bone
#

Then send that request and check the stacktrace

#

Looks like it's called through batchChannelUpdate, from module 667771

charred monolithBOT
charred monolithBOT
#
Sinestia
[Vencord/Vesktop] Issue opened: #338 Wayland scaling on Gnome is broken

Describe the bug
When running vesktop on Gnome on Arch Linux and scaling set to 2x, it looks fine in X11 mode. However, the performance is poor so even when running default Discord I force it to Wayland with
--enable-features=UseOzonePlatform --ozone-platform=wayland

Which works fine, especially on other third-party clients.

With vesktop however, it does not scale properly when Wayland is enabled, looking blurry. This seems unique to vesktop.

One can throw in --force-device-...

charred monolithBOT
charred monolithBOT
austere talon
#

1.5.0 fully made the vencord desktop -> vesktop rename which means the binaries and co have all been renamed to vesktop now

#

but the config still refers to the old "vencorddesktop" name

charred monolithBOT
charred monolithBOT
charred monolithBOT
austere talon
#

holy shit that's an ancient electron

charred monolithBOT
topaz thistle
charred monolithBOT
dapper tiger
#

I like seeing my addition being used

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
dapper crest
#

if I made a pr for onepingperdm to have an option to use debounce so sends one ping per every 30 seconds instead of one ping when its not unread, would people use it

spark pivot
#

Are you having a stroke or am I stupid

jagged cloak
#

sounds like some people would use it

dapper crest
#

I would be implementing new logic that allows future pings beyond the oldest unread

charred monolithBOT
verbal pumice
#

!

!

spark pivot
#

!

!

charred monolithBOT
austere talon
#

wtf is that issue

#

like.. congratulations on your 3 vesktops buddy?

#

im confused xd

crude hearth
#

NOT PLANNED?

#

WHY

charred monolithBOT
topaz thistle
warped turret
#

Is it possible to check whether user's DMs are open via api?

austere talon
#

no

median rapids
brazen bone
#

If you mean "whether the page the client is currently displaying is a dm channel", then I would assume that's possible via some module

#

If you mean "whether an arbitrary user is susceptible to unsolicited dms", no

charred monolithBOT
fringe basalt
median rapids
#

why didn't i think of that ari

fringe basalt
charred monolithBOT
still wasp
#

Why do people always make that lmao

lime stone
#

good way to learn i guess

#

you would've thought people would be more familiar with a project before contributing...

still wasp
#

Yeah husk

charred monolithBOT
#
SoMuchForSubtlety
[Vencord/Vesktop] New comment on issue #340: system tray entry does not have an icon

I looked a little closer at the dbus communication, and found this error (1.3059 is vesktop and 1.33 is gnome shell)

‣ Type=method_call  Endian=l  Flags=0  Version=1 Cookie=104458  Timestamp="Tue 2024-01-16 22:43:22.503812 UTC"
  Sender=:1.33  Destination=:1.3059  Path=/com/canonical/dbusmenu  Interface=com.canonical.dbusmenu  Member=AboutToShow
  UniqueName=:1.33
  MESSAGE "i" {
          INT32 0;
  };

‣ Type=error  Endian=l  Flags=1  Version=1 Cookie=24  ReplyCookie=104458  Ti...
austere talon
#

tbh idek why it broke on flatpak

#

nothing much changed

charred monolithBOT
topaz thistle
spark pivot
#

bro what 😭

still wasp
charred monolithBOT
austere talon
#

incredible intelligence on display

topaz thistle
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

spark pivot
#

if someone could review/merge any of these prs that would be great, i've been waiting on them for a long time

image.png
fringe basalt
#

only 3 months

#

pathetic

#

im chilling at 7 months

chrome_mP2o4kDasi.png
median rapids
#

pathetic

#

im sitting comfortably at 9 blobcatcozy

#

i love contributing to open source

charred monolithBOT
austere talon
charred monolithBOT
spark pivot
#

lmk if you need help, id be willing to do so

charred monolithBOT
jagged cloak
#

w use of inline blocks, dont see many using it

#

ig its too new still

charred monolithBOT
#
wwmm
[Vencord/venmic] New comment on issue #13: [All Inputs] Incompatible with EasyEffects

EasyEffects now reads the custom PW_KEY_TARGET_OBJECT set by the user to the stream node and tries to not touch the stream if it is not recording from the same input device EasyEffects is using. There are some limitations. For example the stream has to be started when EasyEffects is already running. And if EasyEffects is started when the stream is already there there is a chance that we do not know yet which input device we have to use by the time pipewire tells us about the stream properti...

harsh iris
# austere talon but the config still refers to the old "vencorddesktop" name

looking at it again, changing the app id didn't our effect our packaging since electron-builder doesn't really give us paths that depend on that. we just used vencorddesktop as the name for some things (like the main electron wrapper that runs the unpacked asar) since that's what electron-builder's appimage generator and the flathub used before for whatever reason

austere talon
#

for whatever reason
because that was the internal name

harsh iris
#

yeah but the flatpak was already using vesktop as well in other places

#

like startvesktop and using dev.vencord.Vesktop in app icons for example

#

just was odd to me since it's pretty easy to name the files whatever you want, but ig that comes from using the appimage as a basis

austere talon
#

it was half renamed because renaming the app makes users lose all their data.

#

i added migration logic and fully did the rename this version

harsh iris
#

i know, i'm just saying the app's binary name and things like desktop files could be changed regardless of that. like here in the flatpak manifest for example, things were already being renamed

image.png
#

it's not a requirement, and it makes more sense to name a binary vesktop for example and not care about that internal name

austere talon
#

the packaging process is automatic

#

we have not much control over it

harsh iris
#

which is why i said

ig that comes from using the appimage as a basis

austere talon
harsh iris
#

the appimage is autogenerated, which explains a lot of the weirdness

#

the flatpak isn't compiled from source like most other linux packages or the nixpkgs version, where we do have control over it - just that appimage

austere talon
#

oh

#

cause it literally doesn't matter

charred monolithBOT
#
NyaomiDEV
[Vencord/Vesktop] Issue opened: #341 [Linux] Using native titlebar causes wonky behaviour in child windows

Describe the bug
Child windows have both the client-side window decoration and the server-side window decoration. They don't obey the "Show Menu Bar" option you can configure in Vesktop. Closing a child window through the clientside close button closes the main window instead.

To Reproduce
I think the most straightforward approach to reproduce this is to take a look at the stream debug child window.

Expected behavior
Behaviour should be consistent between the main Discord...

harsh iris
charred monolithBOT
#
NyaomiDEV
[Vencord/Vesktop] Issue opened: #342 [Linux] Ozone platform hint

Is your feature request related to a problem? Please describe.
This solves a problem with consistency on Wayland desktops.

Describe the solution you'd like
The .desktop file could have --ozone-platform-hint=auto appended to it. It would be possible to pass it straight from the app's code via app.commandLine.appendSwitch('ozone-platform-hint', 'auto') but I couldn't get it to ever work in my Electron test thingamajigs.

Describe alternatives you've considered
XWayland...