#πΎ-core-development
1 messages Β· Page 155 of 1
Should I just make nomosaic a dependency or fix it to work with mosaic
eh it would probably be easier to make it a dependency
not like anyone actually likes mosaics anyway
Ok
oh @spark pivot i might have found a glitch. unless its intentional, if you favourite an image and then re send it the favourite button doesnt show up on it.
ah cause it's a url embed now which is different for some dumb reason
yeah my way of doing it isn't the best but i dont think there was another way tbh

i messed up smth
how do i import my css file only when my plugin is enabled? cause right now it doesnt do that
You can do that with import "style.css?managed", but usually I think you would make it so that the stylesheet just doesn't have any effect if it isn't enabled
i did that but now even when my plugin is enabled it doesn't apply
ah i need start and stop stuff
now it works
just curious, how are you importing the css?
import style as "./whatever.css?managed"
...
// in plugin
start() {
enableStyle(style);
},
stop() {
disableStyle(style);
}
oh wait thats possible? 
ikr
any particular reason why?
only downside is you have to fully restart discord for it to do anything and it's stupid
turns out all i needed was one patch to get all images to work
now to get mosaic to work
blegh
nvm im just that good at programming
it just worked
didn't even do anything lol

have you pushed the media text thingy?
awesome ima get it
:3
ok now theres another weird thing
if you favourite an image, then re send it, it lets you re favourite it
only sometimes tho
cause one is an attachment and one is a link
it's stupid and i dont think there's much i can do about it
well
maybe
can you send that link here
the favourited link?
yeah i found one on my end
i had another idea btw, it would be cool if the media button would default to the favourites instead of going to the shitty facebook mom gif catalogue
eh that's not really related to this plugin sadly
i also hate that page dont get me wrong
ah yeah true
id try figure it out myself but i have the iq of a pebble
ll it NoFacebookMomGifPage
i swear im never gonna figure out how code patching works
that shit is like minecraft enchanting table
there used to be a funny bug where favorited videos would play their audio when they were displayed in the gif menu
uh oh
videos save the thumbnails instead of the video now 
https://cdn.discordapp.com/attachments/716339549961453579/1189708541292990525/silly.mp4?ex=65a85feb&is=6595eaeb&hm=924e8a44c40f1bdf6eb3f9e8cc4349c885347227d697416a8a53bb5b3a48a097& anyway this was playing when i found this bug
it was very funny
i am so adding this bug back as an option
its funny
ok this is fixed now
just got rid of the expiry junk from the urls
which also fixed the videos saving as thimbnails somehow
update
it works
but at what cost
how can i add a context menu patch to reactions specifically? im strugglin here 
WHAT THE HELL IS THIS @crude hearth
i don't think it's mantikafasi's account somehow
this code has more == TRUE statements than i ever wanted to see
ITS NOT RELATED TO ME

what the hell is this guy
impersonating me
Some notes about this PR:
- With native Windows titlebar, it'll make Vesktop resizable compared to before. Maximize button is still disabled (even tho for good reason as it glitches titlebar when Vesktop is maximized)
- With custom discord titlebar,
transparency: trueis still required as it won't display Mica backgroud correctly - Requires at least Electron 28.1.1 or higher
I've experienced the same issue. Alongside high pitched noises people have also told me they hear increasingly loud beeping or a lot of static noise. All of this goes away as soon as I use something like the official Discord web client.
Lots of the beeping and noises for me it's not present (as long as KRISP is indeed enabled) but I do indeed share the same experience as you
Thereβs an api for this no need for patches, look at translate
Are you using venmic by any chance?
For me it's happening even with 0 plugins or themes. Clean install of Vesktop.
@high oracle venmic is for screensharing, it shouldnt affect regular voice
though @topaz thistle knows better than me
ok
It doesn't - However in earlier pipewire versions it would sometimes fuck up the audio a little when creating links - this seems to not happen anymore though
so would the advice be to try upgrade pipewire?
Yes but afaict that problem is fixed since ages so unless they're using Ubuntu (which is not the case) their pipewire version should be recent enough for it not to occur given that they even use venmic as none of them have stated that they're sharing their screen, if they don't Venmic will not do anything so it shouldn't happen either
For me it's happening even with 0 plugins or themes. Clean install of Vesktop.
Venmic is not a plugin - It will be activated during screenshare with audio
@X1nto Thank you for reminding me that I should have wrote down a list of active plugins, added it to the original post!
which plugins do a good job of showcasing how to add things to vencord toolbox?
badgeapi
gracias
my dumbass is still on this, what should i pass as plugin? 
yourself
I've added a new default-on setting ignore_devices which will prevent microphones or speakers from being linked to the virtual-mic.
I am still not sure how this would happen in the first place though - anyhow it's good to have a fail-safe for this now.
None
None
None
None
None
None
None
None
For me it's happening even with 0 plugins or themes. Clean install of Vesktop.
Venmic is not a plugin - It will be activated during screenshare with audio
Was not aware what it was. I am not screensharing or watching a screenshare when it happens. Just a normal one on one voice call.
For me it's happening even with 0 plugins or themes. Clean install of Vesktop.
Venmic is not a plugin - It will be activated during screenshare with audio
Was not aware what it was. I am not screensharing or watching a screenshare when it happens. Just a normal one on one voice call.
Thanks for confirming!
the plugin instance if u didnt figure that already
i gathered, but where can i grab the plugin instance from?
definePlugin is your instance
ahhhhhhh ok thank you
@austere talon Can you bump Venmic to 3.2.0?
force push jumpscare
wanted to understand when the devs want to merge that :/
next update.
Thanks for the reply! anyway great job for that client is my save for sharing and other congrats
another day, another ven force pushing incident
(he secretly put malware)
vencord is keylogher guys!!1!
I tried this on Windows and Vesktop on Windows does not experience the same issue. I have only been getting it on Vesktop for Linux. (Ubuntu 23.10).
Please let me know if this also reproduces when never starting a Screen-Share
It does reproduce consistently also while having a screenshare, but not necessarily at the precise moment you start it. This I know for a fact.
It does reproduce consistently also while having a screenshare, but not necessarily at the precise moment you start it. This I know for a fact.
This sadly doesn't really help, I'd have to know if it also reproduces when never starting a screen share in the first place
Would you like to try in about 10 minutes in Vencord server?
Please let me know if this also reproduces when never starting a Screen-Share
Never as in, having never done it on that PC at all? Or having never started one in that call instance?
I DID NOT
it's codeberg sync lmao
cause i forgot to update the github workflow
btw I can repro that noise issue
but for me it's just an issue with my microphone, it even happens outside of discord
but on windows it doesn't happen, either cause driver difference or cause krisp works better on windows
Please let me know if this also reproduces when never starting a Screen-Share
Never as in, having never done it on that PC at all? Or having never started one in that call instance?
Never as in never having started a screenshare in that vesktop instance
Please let me know if this also reproduces when never starting a Screen-Share
Never as in, having never done it on that PC at all? Or having never started one in that call instance?
Never as in never having started a screenshare in that vesktop instance
Yes, it happens then too. Yesterday I installed the flatpak to see if it happens there too. Clean install and I immediately go in a voice call to test, without cloud sync or settings on, and it immediately ...
Please let me know if this also reproduces when never starting a Screen-Share
Never as in, having never done it on that PC at all? Or having never started one in that call instance?
Never as in never having started a screenshare in that vesktop instance
Yes, it happens then too. Yesterday I installed the flatpak to see if it happens there too. Clean install and I immediately go in a voice call to test, without cloud sync or settings o...
Confirming the same thing too then!
Also quick question, is everyone who is affected by this issue running on Ubuntu (or similar)?
I have noticed @midblep saying he is running Ubuntu 23.10, I was running Kubuntu 23.10 until yesterday and now 24.04 (which is virtually identical).
If so we might finally have a clue on what it could be.
Confirming the same thing too then!
Also quick question, is everyone who is affected by this issue running on Ubuntu (or similar)? I have noticed @midblep saying he is running Ubuntu 23.10, I was running Kubuntu 23.10 until yesterday and now 24.04 (which is virtually identical).
If so we might finally have a clue on what it could be.
Actually, my bad, I am also running Kubuntu, not Ubuntu. π
Been meaning to upgrade to 24.04 soon as well, so I suppose we have rather identic...
i have this issue as well, but in my case it's just an issue with my microphone that also happens outside of vesktop. on windows it's fine. either because of driver differences or because krisp works better on windows
As said I did notice this happens primarily when I am quiet for some time and then starts talking, my guess is that it's not a KRISP issue but a gain issue.
Might be connected to an old bug I noticed, despite automatic gain control being disabled my microphone is still adjusted all the time up and down based on my level of voice, this bug is still happening to this day, could the two bugs be related?
the automatic gain control toggle is not implemented in vesktop. automatic gain control is always on, see https://github.com/Vencord/Vesktop/issues/161
Yes, that's my point, could it be a bug on the way that is implemented instead of being a KRISP issue?
days since last force push:
88fc157 webContextMenus: add Show My Camera item (#2086) - sunnniee
3eada99 fix(ToolBox): don't add entries of disabled plu... - Vendicated
thanks but the way you check if the plugin is enabled is wrong. thus, superseded by https://github.com/Vendicated/Vencord/commit/3eada99ad623ae783a39eb2c8238ac66ed371132
that's the github equivalent of an L + ratio holy shit
i don't really like this way of storing the window. it will unnecessarily keep it around even after a close
i think instead of storing it at all you could use BrowserWindow.getAllWindows().find(w => w.title === "Vencord QuickCSS Editor"). or at least attach an .on("close" handler to set the variable to null when the window is closed
this is kinda hell. you could avoid all the escaping by doing something like
{
match: String.raw`/^\`\`\`...`,
replace: whatever
}
i hate how bad git is at determining renames, makes the diff sooo bad to look at
this is bad wording for a boolean option
description: "Whether to anonymise file names by default",
nitpicky (kinda): discord usually makes strike-throughs go from bottom left to top right. your icon's strike-through goes from bottom right to top left. it would be better to be consistent with discord

thats the spotify icon url
nop lmao
btw I noticed permissions viewer doesn't patch thread context menu
Huh, so skjul means mute in norweigan? That's funny, in swedish it means shed (as in small usually detached building)
There's a rare swedish word "skyla" that means to hide/cover, probably related
waiiit i didnt know js worked this way
i would assume it always evaluates factory()
this is soooo much boilerplate
soon
im learning norwegian so i can understand varg's stories
well he mostly talks in english so that joke doesnt work
oop
so true
vee is going crazy 
should i add the contextMenuPatches: property
soon plugins will have no more code they will just be json
everything will be turned into a property
That route risks forward incompatibility if a plugin happened to have its own contextMenuPatches property that was previously inert
we don't have to care about compatibility
cause all plugins are first party
Right, that's true
In that case I'm all for it, and other similar properties like message accessories and quick buttons
maybe another time
it's not important rn
this doesn't seem right.. why use trackData.name here? isn't that the song name?
this description and name are misleading. floor is still a round (down)
something like
description: "Always rounds relative timestamps down, so 7.6y becomes 7y instead of 8y",
soundboard volume is also one
hilarious you are discord
6530526 Updater: Fix grammar (1 Updates => 1 Update) (#... - moxie-coder
how's the status on it, did they fix it now?
i literally tested this the other day and it worked :face_with_spiral_eyes:
anyway, it might be more future proof to add export const { DraftType } = findByPropsLazy("DraftType") to webpack commons and use that everywhere?
be9ec3b SendTimestamps: add setting to disable message ... - jedenastka
tbh i dont like having two such similar plugins. i suggest merging the two plugins into one and using settings to make the separate features configurable
as i mentioned on discord, this doesn't really add anything of value so i'll close it
thanks anyway :3
isnt it already? it's already there as an enum, not sure why whoever didnt just do this to begin with lol
probably, but please merge both patches into one! you can make replacement an array
this name is slightly confusing. maybe something like this instead?
"Which avatar to use if both default animated (Nitro) pfp and UserPFP avatars are present",
please just move this type to the main file
oh funny
when are they releasing poll 
trueee
have you heard of pollsjson

draft_clear?
pollsjson is how polls used to be done
like
when they were hackweek project
the uploaded file persists after command
inch resting
they released ios testflight builds with polls support but never android or desktop(?)
so sad
now we wait for real release
holy shit
o
nvm thats useless
anyway when are you renaming it to Veesktop
i changed it to use the webpack common, but there's still the following issue:
it doesn't clear the slash command draft after you submit it. the fix is likely to just clearDraft(DraftType.SlashCommand), but i'm confused because Discord doesn't do that and it works fine for them :/
hi, could you please show an updated image
if its in a dm channel and !serverNotifications, then it ignores it?
there was probsbly a reason for that hang on
d5c58ab updater: Add top and bottom margins between com... - TheEvilSkeleton
i don't think this is a good idea, since some issues might still be okay
or sometimes i ask people to open an issue when i confirmed their issue and want to track it
@AutumnVN this is okay, right?
both of your code snippets should work, however you also need to prevent the default action. both those click handlers should obtain the event as first argument. calling event.preventDefault() will prevent it
0d6bb35 TextReplace: allow replacing with nothing (#1933) - effctcodes
good catch, i dont know why i did it like this lol (disabling would still keep dms)
i confuse myself let me just change it 
can any mac users repro
this seems like a bogus report tbh
but also really old lol
also holy shit browser is so outdated lmao
poor chrome users
the vencord desktop on my mac is so old it doesnt even have an update prompt lmao
oh i straight up didnt read the issue because i was doing this lmao
i will use
LMAOO
Dont you also need a theme for transparency to work
fr π
idk tbh
You're not gonna get much transparency without a transparent theme, yeah
Since most of discord's colors are opaque
88fc157 webContextMenus: add Show My Camera item (#2086) - sunnniee
3eada99 fix(ToolBox): don't add entries of disabled plu... - Vendicated
4d198e4 fix wrongly patching 'Events' context menu - Vendicated
13961a4 ReverseImageSearch: add support for image modal - Vendicated
6530526 Updater: Fix grammar (1 Updates => 1 Update) (#... - moxie-coder
None
None
None
None
None
None
None
None
@limber skiff i want to port reporter to test prs somehow (on manual review to make sure there isn't a token logger or smth in the pr)
but it seems really hard
if its talking about translucency options they seem to work fine
how would it send the results?
ngl reporter is one of the coolest vencord features
real
@austere talon
i was using discord without a theme
its so much faster
can anything be done about that
im specifically using this theme https://catppuccin.github.io/discord/dist/catppuccin-mocha.theme.css
i know its the css selectors
maybe some kind of compilation layer?
process selectors find all the matches and cache that
yes: dont use heavy themes
use nitro theme or https://vencord.dev/plugins/ClientTheme
so lightweight
ulgy
for optimal performance u should only do a basic recolour
this looks pretty good imo
guhhh finee
use client theme its actually really good
but couldnt selectors be processed and cached
You mean like, replace all [class*="container_"] with :is(.container_hioaw,.container_u1390,.container_u14209,.container_aufwi1)?

yes
soon
those are irrelevant
7500 for me
6848
noobs how yall got so little
discor element hack
function shouldIgnore(channel: Channel) {
switch (channel.type) {
case ChannelTypes.DM:
if (settings.store.dmNotifications) return false;
break;
case ChannelTypes.GROUP_DM:
if (settings.store.groupDmNotifications) return false;
break;
}
return !settings.store.serverNotifications;
}
Does this look less confusing (also changed to webpack export)
dms > false, gdms > false, everything else (they're all guild channel types afaik) > rely on server notifications
double check before i push dumb things
animal insane
That's equal to ```js
if(channel.type === ChannelTypes.DM) return !dmNotifications && !serverNotifications;
if(channel.type === ChannelTypes.GROUP_DM) return !groupNotifications && !serverNotifications;
return !serverNotifications;
And I think that one's way clearer
yes
Seems pretty weird having serverNotifications be a master switch anyway; shouldn't they be independently toggleable
not really
i dont see a benefit of toggling an announcement channel independently from other guild text channels
for example
Yeah but DMs should be independent from guilds
they are now
Not in the code you sent
oh ffs
0b01732 make hardwareAcceleration setting more intuitive - Vendicated
done via https://github.com/Vencord/Vesktop/commit/18925ad5839124a17afce4d9a9a696b573abdff6
if you want it immediately, build from source. but i will make a new release very soon
no i think this one is correct wym
unless i just made it overly complicated
The switch bodies are equal to js if (settings.store.dmNotifications) return false; else return !settings.store.serverNotifications; aka return !settings.store.dmNotifications && !settings.store.serverNotifications;
looks good. could you please also add a settings switch for Auto start minimised? I'm not sure how to word it, just take inspiration from Discord Windows settings
LOVE
@turbid hatch sorry, remind me what the result of our dbus experiment was?
for enabling autostart via portal
i think we were still trying to work it out but concluded we need some library to do it
we cant do it through the command line because the cli tools dont support what we're trying to do
so we need a native
no, we established it didnt support the types needed
because we need to pass a dictionary or something like that and the cli tool doesnt support it
yes but then i found a different program
there
riiight i couldnt test further cause i was on phone
ill test rn
and see if it does anything
(i love restarting!!)
this is really strange because i've never had this happen. likely related to power saving. we should check what flags Discord passes and see if any of them could relate to this issue
can't reproduce on gnome. likely an issue with plasma, as also mentioned by malte in the linked issue
try on a different DE/WM
since this issue is out of our control and there's nothing we can do, i'll close this as wontfix. screenshare is controlled by chromium & your desktop environment, not us
i don't think this is easily possible, since electron only supports screens & windows
try searching in the electron issues
can any mac users reproduce? https://github.com/Vencord/Vesktop/issues/293
i hate portalss
what is this supposed to mean?
Didn't know that JS has raw strings. However, you apparently aren't able to escape backticks in them, so I needed to do something like:
String.raw`/^${"```"}...`
Looks weird but seems like there's no better solutions. Is this okay?
I changed the replace value as well, to get rid of the backslashes.
wow this embed had a stroke
why do u repeat the entire string
match: String.raw`/^${"```"}(?:([a-z0-9_+\-.#]+?)\n)?\n*([^\n][^]*?)\n*${"```"}`,
if you avoid matching this /, you can just set replace to replace: "$&\n?/"
no real reason, I had to test the regex before making the MR and then just left it like this. will change.
done
actually hm
I could fix this embed stroke as well
but that's out of scope for the current name/description
idk if I should do that now or in a later MR
what?
yes
hm, okay
it's definitely much less of a problem
it's just that Discord Markdown is different to normal Markdown
and not an actual bug in the implementation
because this gap sure looks like a bug from both code and usability perspective
youre using the old header btw
oh
dont copy paste from other file, let eslint autofix insert it
anyway it doesnt matter
ay
@topaz thistle is this doc outdated? or is the typescript definition wrong
according to the type, both include and exclude are required
seems to be that the type is just wrong
i tried and it works fine without include
i found something interesting
in discord/0.0.39/modules/discord_desktop_core/core.asar
but they only use that if you're watching a video or smth like that
so really cant be..
IdleStore seems interesting thats purely the afk stuff
in gateway: M.default.remotePowerMonitor.on("resume", this._handlePowerResume))
but that just sends a heartbeat
gdbus call --session --dest org.freedesktop.portal.Desktop --object-path /org/freedesktop/portal/desktop --method org.freedesktop.portal.Background.RequestBackground "a" "{'Autostart':<true>}"
i hate dbus
I GOT IT
spawnSync("gdbus", [
"call",
"--session",
"--dest", "org.freedesktop.portal.Desktop",
"--object-path", "/org/freedesktop/portal/desktop",
"--method", "org.freedesktop.portal.Background.RequestBackground",
"",
`{'autostart':<true>,'commandline':<['${process.execPath}', '--start-minimized']>}`
], { encoding: "utf-8" });
d57147e autoStart: add linux portal implementation - Vendicated
actually don't worry about that, ill add it as part of https://github.com/Vencord/Vesktop/pull/322
I'd just mirror the actual svg but honestly no idea how without throwing it in an editor and have it spit out an even bigger one
I got the crossed out one from the same source so yea
yop no one will notice
pushed a somewhat dirty fix that just mirrors the strike-through svg with css. it looks fine to me, so this is probably okay? unless you have a better svg for it
i think this is good enough :shipit:
Yeah only one of both is required
But the API endpoint specifics are a little different from the node api
It's hard to express that in the types though, so one should just pass an empty array instead
That you can select devices as well I suppose
Venmic supports that already
Is there an api to open discord links natively without reloading the page?
In particular, I'm looking for a way to go to a message as if it happens when you click β #info message
NavigationRouter
looks like gruvbox material
Didn't know if easter eggs were allowed so they're disabled by default
yeah it's gruvbox material. try monokai pro it looks pretty similar and is maybe better (u can easily pirate it if u like it and don't wanna pay)
you can actually do this with ts overloads. require one or the other
anyway the type doesn't have to be precise
True
Yeah doesn't matter really
also i disagree, an empty array implies nothing is excluded / included
but not passing the option at all for include means everything is included
True
Will update later, even though they're technically equivalent it might help imply meaning
Same issue in Pop!_os 22.04 Ubuntu based distro, I will try restart and not start a screenshare.
As of now it looks like 3 out of 3 people experiencing this issue have an Ubuntu based distro then.
Please if anyone using something else can write a comment I would be very happy, at least we can finally say for certain the issue is there. Try to use Vesktop on Arch, Gentoo, Fedora or whatever peeps!
As of now it looks like 3 out of 3 people experiencing this issue have an Ubuntu based distro then.
Please if anyone using something else can write a comment I would be very happy, at least we can finally say for certain the issue is there. Try to use Vesktop on Arch, Gentoo, Fedora or whatever peeps!
I use Arch Linux x86_64 and unfortunately have the same problem:
- Stable 256231 (96a39c5)
- Vencord D73790e (Vesktop V0.4.4)
- Electron 27.1.2
- Chromium 118.0.5993.144
- Li...
Does seem to be specific to Vesktop. Not getting the same problem in the official Discord app modded with Vencord, or other ones that have it as installation options like ArmCord.
As of now it looks like 3 out of 3 people experiencing this issue have an Ubuntu based distro then.
Please if anyone using something else can write a comment I would be very happy, at least we can finally say for certain the issue is there. Try to use Vesktop on Arch, Gentoo, Fedora or whatever peeps!I use Arch Linux x86_64 and unfortunately have the same problem:
* Stable 256231 (96a39c5) * Vencord D73790e (Vesktop V0.4.4) * Electron 27.1.2
...
When I try to screenshare on Hyprland (NixOS), I get the following error continuously:
[30147:0106/182551.162630:ERROR:shared_screencast_stream.cc(241)] PipeWire stream state error: no target node available
The following portals are loaded and active
$ systemctl --user list-units --type=service | grep portal
xdg-desktop-portal-hyprland.service loaded active running Portal service (Hyprland implementation)
xdg-desktop-portal.service loaded active running Port...
@austere talon That'll work right?
Okay I'm not too sure if that'll work
Nvm seems to work but the auto-complete is a little fucked then
I can also do it like that lmao
Oh you already made both optional
I'll stick to your changes then
yep
i think this should work?
link(data: {include: Prop[], exclude?: Prop[], ignore_devices?: boolean} | {include?: Prop[], exclude: Prop[], ignore_devices?: boolean}): boolean;
sorry you don't actually need overloads
this is either an issue with Nix, or more likely the hyprland portal. i have seen maaany reports of hyprland users with broken screenshare
i recommend trying on gnome instead
anyway since this isn't an issue on our end, ill close this
Yeah thats the two combined, probably the most sane approach
it works on hyprland lol nix issue or skill issue
It all comes down to ease of use
And simplicity
It does one thing and it does it relatively well
change discord's themes
and it also allows you to create your own color themes with no compromise on quality
what is that
where is it?
is it in vencord?
its a close to finished pr
but it does require for the presets to exist and/or to be written by hand, right?
that's already how it works
what are the actual capabilities of usercss?
Like, this usercss? https://github.com/openstyles/stylus/wiki/Usercss
And colorways also have presets to make colors work with other themes or make them behave a certain way
i NEED usercss for this messagebar
could make it default but would prefer a switch method via usercs
s
Yeah, this goes beyond what I designed colorways for
they are color-only themes, meant to be easy to use, create and share
isnt that clienttheme but import/export
also
this lowkey slaps
I'm also working on making it more acessible for developers to add their own presets, that can then be used by the plugin in a myriad of ways
font
huh
except for the preview panel overflowing, I can't reproduce the issue
seems to be a theme issue, cause on default discord I can't seem to reproduce it
its not, i tried it without any themes or css. weird
oh
wait
nope
still can't reproduce it
(on my laptop, which has the latest version)
oh its a zoom thing
i just tested it zoomed out by 1. it doesnt do it now
makes sense
I even tried zooming, huh??
oh well
I will fix these issues soon, but right now, I want to work a bit on the bd version, just for the funsies
and possibly a new theme(?)
it works on hyprland lol nix issue or skill issue
Are you using xdg-desktop-portal-hyprland or xdg-desktop-portal-wlr? It works great on gnome and another person had the same problem in this thread, which is why I thought it might be a general hyprland issue. Then again they also seem to be using NixOS.
@austere talon I've updated the types a little so that either exclude or include are required
ok this just lags the discord website for me
using gnome's desktop portal works as expected on nixos. this is most definitely an issue with hyprland's portal (or at least older versions) rather than vesktop or electron. see this thread for more
using upstream's flake (i.e., xdg-desktop-portal-hyprland-git for non-nixos users out there) or i'm guessing v1.3.0 should solve this
how do i add this to my vencord client
https://github.com/Vencord/vencord.dev/pull/35 hi, could someone look at this? it's been sitting there for a while.
we really need to update the vesktop "branding"
at this point it has many upsides over stock discord, especially on linux
also does the "nothing is loaded" state have to be yellow, is that like an electron thing
so we should really work on
- a better description
- a quick overview of the differences and why you should use vesktop
- a proper website for it
It can be argued that for a lot of people including me the working audio from screen shares is the most important feature
honestly i never intended vesktop to be linux focused but it kinda is now ig?
i mean it has the most benefit on linux
so we could cater more to the linux audience with our "branding"
by being the only fucking thing that works xd
but its still a good alternative on windows & mac
Yeah we're the only ones with proper audio support (not counting discord-screenaudio cuz I wouldn't call that proper)
Honestly don't see the reason of using it other than the themes on windows. I think better discord dominates in that field though. On a Mac it doesn't seem to support audio when screen sharing it would seem, correct?
The native discord client also doesn't support it on a Mac
actually i should create a roadmap kinda document for vesktop
i have a lot of plans but i keep forgetting them and its good for tracking
they do now
30bc979 feat(Urban Dictionary): Chooses top rated defin... - jewdev
7e395fc Update codeburger mirror - Vendicated
d0dfdbb fix: Vencord_cloudSecret check (#2077) - lewisakura
a963a19 fix(Decor): Fix AvatarDecorationModalPreview fi... - FieryFlames
1eb2510 feat(Decor): Enforce guidelines more (#2035) - nexpid
new audio share thing?
yeah that's my last stance as well
but crapple made some screen capture kit kinda thing that allows apps to record audio
its pretty new but discord uses it now
ohh that's neat
you should talk to our apple people for more info
it was mostly @junior olive who talked about it
maybe we can make venmic be a small wrapper around that
^
It'll require native code anyway right?
probably?
im assuming electron will support it sooner or later
swift more like, no?
I don't think the current description on GitHub is great and the point is not really valid since both vesktop and discord use electron that bundles chromium
can swift c++-interop
Well if we add it to venmic then it'll be Obj-C(++)
yes
its kinda meaningless
it makes it seem like vesktop is just the same as discord desktop but slightly more convenient cause vencord installed
Yeah I think so but otherway around is cursed
you can yeah but i think just writing objective-c would unironically be easier than setting up the swift toolchain
surprisingly not
btw are u also gonna use venmic for whatever ur app was called again
it just .. works
This
or is that unrelated
Kind of
I will re-use a lot of it
But the implementation will be a lot different
eventhough
Now that we have mixed include/exclude support
I think I can even yank the whole thing
- (void)presentWithCompletion:(void (^)(BOOL success))completion;
oh what the fuck is this
it looks like it wont be as simple as just recording audio
instead you'll likely need to use screencapturekid for the entire recording
ugh
and make electron use that
it shouldnt be that much harder, just another monkeypatch in js world

None
None
None
None
i aint got a fucking clue what this is
but its apparently a type signature for async api calls
which SCK uses throughout the entirety of its api
but in swift its marked as an async throws signature so the interop is easier
this looks really simple
@high oracle was looking into it
None
None
None
None
we can probably write a slightly nicer wrapper in swift and expose it to C++ since it autogenerates the C header and does the type interop for you
I love swift
Xinto is Elon fr
Obj-C synatax is fucked - I seriously have no clue why anyone in their right mind would still use that shit nowadays
Idk even know if clangd has proper supprt for it
**applescript.m: **Lines 3-8
void runScript(const char *s) {
NSString *script = [NSString stringWithUTF8String:s];
NSAppleScript *applescript = [[NSAppleScript alloc] initWithSource:script];
NSDictionary *errInfo = nil;
[script executeAndReturnError:&errInfo];
}
like what the fuck is this
But since apple contributed a lot to llvm I guess it does
not fun :)
im trying to put html + react components into the vencordtoolbox code, im getting the error
A component threw an Error
Error: Menu API only allows Items and groups of Items as children. Received h1 (object) instead
is there a way that i can fix it? or am i just gonna have to make an item (whatever tf that is)
error is pretty self explanatory
menu api only allows menu api items
you cannot put random elements
This is not really a direct roadmap, mostly just tracking features that are planned
- [ ] Implement global keybinds
- [ ] Get rid of the update prompt
- [ ] Auto update on Windows via electron autoupdater
- [ ] Disable entirely on Linux. Auto updating will be done via flatpak / package manager (set up apt/rpm repo?)
- [ ] Likely disable entirely on Mac. OR, steal someone's code signing certificate and use auto updating
- Maybe use [screencapturekit](https://developer.apple.com/d...
if u have anything else just say
Btw i set up brew tap for vesktop
Brew requires us to sign before we can put it into their main repositories
well thats not gonna happen lol
what is brew?
macos package manager

ah
In that case we could create the tap inside of vencord github Organisation and have it as one of the official ways to install it on a Mac
i mean im gonna end up buying an apple developer account soon

yeah i was gonna be a dumbass, im probably just gonna make a second tab for toggling all my random bullshit
im going knee deep into the apple ecosystem in like
a couple of months
so im going to have an account anyway
i can just buy it a tad early
you can have smth like this
NO
I CAN STILL SAVE U......
Instead of going through the update process of uninstall vesktop and reinstalling, it updates with all of your other brew packages
THE POT HAS BEEN MADE
THE PAYCHECKS HAVE BEEN SPLIT
APPLE HAS TAKEN MY SOUL........................,
oh thats actually a good idea
except my 2 brain cells could never figure it out 
also i sorta just wanted it cause i want to actually start publishing apps on ios lol
not to u
its really easy
to have a submenu just use a Menu.MenuItem with more menuitems as children
for checkbox, it's Menu.MenuCheckbox
and there's Menu.MenuRadio for radio
Btw i have an apple dev account
ahhhhhhh
theyre all typed so u should have no issues
so is menu just a general tool for making context menus and similar things with vencord?
I will take a look into it, but most likely there would be my Organisations name in there, which idk if you guys would be ok with
But it would be enough to make it to brew, which i could then maintain
yes but its by discord, not us
they use it everywhere as well
That would be amazing
But don't do it just for the purpose of signing vesktop, because as i said, I've got a dev account as well that could potentially do the job
isnt signing even a requirement for making apps for ios
there was an app a long time ago that i quite liked using
to publish them yeah
essentially it was just a very tiny app that let you send clips to everyone you had added on it
that was the entire app
everyone got to see the clip once
and then it was gone
just a nice way of keeping in touch with people
...snapchat
sort of?
but focused on video only and has basically no UI
and the videos get sent to all of your contacts you have added, you dont pick who to send it to
W
its a keeping in touch sort of app
not an app to send personalised messages, just sending people what you're up to
because some people quite like that! i found it fun
well if u wanna do that and set it up
thatd be cool
then we could also add auto update on macos
and would have vesktop auto update on all platforms
you know you can just run autofix, riiight...
btw lewi did u see https://github.com/Vencord/Vesktop/pull/322
oh yeh, havent had time to look at it yet
atit
it works!
well in gnome host anyway..
i havent tested it inside flatpak or anything
likely needs a new talk permission to work
https://github.com/flathub/dev.vencord.Vesktop/blob/master/dev.vencord.Vesktop.yml#L19
might or might not need
- --talk-name=org.freedesktop.portal.Desktop
# or this?
- --talk-name=org.freedesktop.portal.Background
or maybe it just doesnt
is there a method to get the current plugin instead of having to do just
Settings.plugins.PluginName
to get setting values?
const settings = definePluginSettings({})
definePlugin({
settings,
})
console.log(settings.store.mySetting);
thanks! :3
actually while im already migrating settings
what if rename app properly now
are you ACTUALLY renaming it to veecord 
packagers will love this change
@harsh iris heads up ^
i think this will require some changes to the nix flake?
**package.nix: **Line 114
# yes, upstream really packages it as "vesktop" but uses "vencorddesktop" file names
i should make a package maintainer role
i did but idk scrumps or leahs discord so didnt give it to them
thanks for the heads up! i'll make sure this gets in next release
im pretty sure they're not in here
ic
im surprised to even see so many chinese discord users
isnt discord banned there
wait the icon broke somehow
nvm
just cause u need to install to have proper icon
^o^ it worked
if it's actual malware then they chose the worst combination of registrar and tld they could
both hostinger and gen.xyz will take it down very fast after a report

yeah i already reported to google + hostinger
didnt know about gen.xyz
will also report there
im still wondering about the endgame of vencord.app
they've been up for many months now without doing anything
at least this impersonator was smart enough to just copy our html and edit it
This is such a minor thing but it's bothered me enough to ask for it. I would want for the cute loading window to be dragged around with my mouse, as sometimes it's right in the middle of something I am doing. Plus, for consistency with how Discord actually does stuff, it'd be better if it was entirely draggable.
lmao
I love how it tries to disable windows defender at first
what suprizes me is only 11 detections
they even obfuscated the code lmao
I honestly have 0 idea wth this is doing
wth are those
this is a stupid game what the hell
since when malwares include games
my impersonation reporter finding this website a day after it was made
when we normally would have found it way later
maybe they werent aiming to be harmful
sounds dumb but ehhh
they even made a complete new website
wth is that impersonation reporter
scans every TLD for OK responses and lists them
then sends the data to a discord webhook
love
yep
husk
is there a way to get an array of all the custom emojis the user has? (from all servers)
there are way less TLDs than what I thought
how does this take 9 minutes 
single threaded?
wait its async too
i honestly forgor why i made it async
oh cause some were timing out on my network cause i was sending them too fast i think
i dont care that it takes 9 minutes honestly
there's around 1400 tlds iirc
understandable
im just surprised it actually caught something
you know you can just run autofix, riiight...
Sorry about that. I repeated pnpm test on my end but it was throwing thousands of CR errors because I'm on Windows π
Thanks for autofixing for me
using gnome's desktop portal works as expected on nixos. this is most definitely an issue with hyprland's portal (or at least older versions) rather than vesktop or electron. see this thread for more
using upstream's flake (i.e.,
xdg-desktop-portal-hyprland-gitfor non-nixos users out there) or i'm guessing v1.3.0 should solve this
Thanks you so much, [v...
Node-objc interop is a pain in the ass so it's probably better to wait for electron to use SCK
re: plugin natives, in general
you can already call functions from the plugin class, so it wouldn't be unreasonable to add a way for natives to call imported functions would it? or add a util method so plugins can receive data from the native side- (probably easier)
not sure which approach if any you wanna take so i'll hold off on a pr
actually not sure how this even works besides reading a bit on how electron ipc works lol
does this still happen? seems fixed for me
it is indeed solved, after I reload the page
I didn't opened an issue for that bug but it lasts since half a month : #π₯-vencord-support-π₯ message
Lmao what was it obfuscated with
no idea
but that guy seems to put game code inside it
I even double checked if I was looking at wrong file
Lol
It often says that on the module attributes
i'm using electron's globalShortcuts api here which doesn't have a way to detect tell the difference between keyup and keydown. this means the push to talk/mute/deafen/etc actions don't really work. we'd probably have to switch to something else at some point
partially resolves #18
huzzah
the replacement variable can be an array to not have to find the same module twice
you should use \i instead of .{1,2} to match variables. eslint will yell at you as it wasn't patched here unlike in main vencord; just tell it to shot up with an // eslint-ignore
in fact that second patch can be done in a way simpler way
{
find: "[kb store] KeybindStore: ",
replacement: {
match: /inputEventRegister\(parseInt\(\i\),\i,\i,\i\);else{/,
replace: "$&$self.registerKeybind(...arguments);"
}
}
this transforms the arguments taken into the function to (id, shortcut, callback, options) (and you'll need the options cause that's what distates if it's keydown or keyup), and the toString function can be reobtained with const { toString } = findByPropsLazy("keyToCode") at the top of your file
also there are some extra keybind options locked away by default as "desktop only" even though they work fine on web
in the same module as the first patch
{
match: /\(0,\i.isDesktop\)\(\)/g,
replace: "true"
}
and remove the "Push-To-Talk is limited" warning
{
find: ".Messages.PTT_LIMITED_TITLE,",
replacement: {
match: /\i.isPlatformEmbedded/g,
replace: "true"
}
}
sorry for dropping all of this at once
i tried to add global keybinds before and gave up because of the aforementioned globalShortcut issue
yeah globalShortcut seems like a really bad pick for this kind of thing
it's all good don't worry π
how would this work on macos and linux...
on macos don't you need to ask permission? on linux with x11 i think you can just log keys without permission
but it's not like that on wayland (?)
works on x11 as far as my testing goes
i'd assume electron handles all that since we are using its api? (though i don't think we would be for long)









