#πŸ‘Ύ-core-development

1 messages Β· Page 155 of 1

austere talon
#

use Vencord.Plugins instead

spark pivot
#

Should I just make nomosaic a dependency or fix it to work with mosaic

still wasp
#

not like anyone actually likes mosaics anyway

austere talon
#

no

#

don't make it depend on an unrelated plugin

spark pivot
#

Ok

still wasp
#

oh @spark pivot i might have found a glitch. unless its intentional, if you favourite an image and then re send it the favourite button doesnt show up on it.

spark pivot
#

ah cause it's a url embed now which is different for some dumb reason

#

yeah my way of doing it isn't the best but i dont think there was another way tbh

still wasp
spark pivot
#

i messed up smth

#

how do i import my css file only when my plugin is enabled? cause right now it doesnt do that

brazen bone
#

You can do that with import "style.css?managed", but usually I think you would make it so that the stylesheet just doesn't have any effect if it isn't enabled

spark pivot
#

i did that but now even when my plugin is enabled it doesn't apply

#

ah i need start and stop stuff

#

now it works

still wasp
spark pivot
#
import style as "./whatever.css?managed"
...
// in plugin
start() {
    enableStyle(style);
},

stop() {
    disableStyle(style);
}
still wasp
#

oh wait thats possible? NAH

spark pivot
#

ikr

still wasp
#

ive been literally just making a new style element this whole time

#

ffs

spark pivot
#

that's what copilot told me

#

but we almost NEVER do dom manip

#

in plugins

still wasp
#

any particular reason why?

spark pivot
#

cause it sucks

#

and there's better ways

still wasp
#

fair enough

spark pivot
#

only downside is you have to fully restart discord for it to do anything and it's stupid

spark pivot
#

now to get mosaic to work

#

blegh

#

nvm im just that good at programming

#

it just worked

#

didn't even do anything lol

charred monolithBOT
still wasp
#

have you pushed the media text thingy?

spark pivot
#

the wha

#

oh yeah it's all pushed

still wasp
#

awesome ima get it

#

:3

#

ok now theres another weird thing

#

if you favourite an image, then re send it, it lets you re favourite it

#

only sometimes tho

spark pivot
#

cause one is an attachment and one is a link

#

it's stupid and i dont think there's much i can do about it

#

well

#

maybe

#

can you send that link here

still wasp
#

the favourited link?

spark pivot
#

the original

spark pivot
#

yeah i found one on my end

still wasp
#

i had another idea btw, it would be cool if the media button would default to the favourites instead of going to the shitty facebook mom gif catalogue

spark pivot
#

eh that's not really related to this plugin sadly

#

i also hate that page dont get me wrong

still wasp
#

id try figure it out myself but i have the iq of a pebble

spark pivot
#

ll it NoFacebookMomGifPage

still wasp
#

i swear im never gonna figure out how code patching works

#

that shit is like minecraft enchanting table

spark pivot
#

there used to be a funny bug where favorited videos would play their audio when they were displayed in the gif menu

#

uh oh

#

videos save the thumbnails instead of the video now trolley

charred monolithBOT
spark pivot
#

its funny

spark pivot
#

just got rid of the expiry junk from the urls

#

which also fixed the videos saving as thimbnails somehow

still wasp
#

it works

#

but at what cost

still wasp
#

how can i add a context menu patch to reactions specifically? im strugglin here bruhcat

charred monolithBOT
austere talon
lime stone
#

i don't think it's mantikafasi's account somehow

#

this code has more == TRUE statements than i ever wanted to see

crude hearth
crude hearth
#

what the hell is this guy

#

impersonating me

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
spark pivot
charred monolithBOT
charred monolithBOT
charred monolithBOT
turbid hatch
# charred monolith

@high oracle venmic is for screensharing, it shouldnt affect regular voice

#

though @topaz thistle knows better than me

high oracle
#

ok

topaz thistle
turbid hatch
#

so would the advice be to try upgrade pipewire?

topaz thistle
#

Yes but afaict that problem is fixed since ages so unless they're using Ubuntu (which is not the case) their pipewire version should be recent enough for it not to occur given that they even use venmic as none of them have stated that they're sharing their screen, if they don't Venmic will not do anything so it shouldn't happen either

turbid hatch
#

fun

charred monolithBOT
charred monolithBOT
charred monolithBOT
still wasp
#

which plugins do a good job of showcasing how to add things to vencord toolbox?

turbid hatch
#

badgeapi

still wasp
#

gracias

still wasp
#

my dumbass is still on this, what should i pass as plugin? bruhcat

turbid hatch
#

yourself

still wasp
#

do i just like

#

shove my head in the cpu

#

or something

charred monolithBOT
#
[Vencord/venmic] New tag created: v3.2.0
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
jagged cloak
still wasp
jagged cloak
#

definePlugin is your instance

still wasp
#

ahhhhhhh ok thank you

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
topaz thistle
charred monolithBOT
charred monolithBOT
charred monolithBOT
verbal pumice
#

force push jumpscare

charred monolithBOT
austere talon
#

I DIDNT FORCE PUSH

#

it keeps lying

charred monolithBOT
crude hearth
#

(he secretly put malware)

thick kestrel
#

vencord is keylogher guys!!1!

charred monolithBOT
charred monolithBOT
austere talon
#

it's codeberg sync lmao

#

cause i forgot to update the github workflow

#

btw I can repro that noise issue

#

but for me it's just an issue with my microphone, it even happens outside of discord

#

but on windows it doesn't happen, either cause driver difference or cause krisp works better on windows

charred monolithBOT
#

Please let me know if this also reproduces when never starting a Screen-Share

Never as in, having never done it on that PC at all? Or having never started one in that call instance?

Never as in never having started a screenshare in that vesktop instance

Yes, it happens then too. Yesterday I installed the flatpak to see if it happens there too. Clean install and I immediately go in a voice call to test, without cloud sync or settings on, and it immediately ...

#

Please let me know if this also reproduces when never starting a Screen-Share

Never as in, having never done it on that PC at all? Or having never started one in that call instance?

Never as in never having started a screenshare in that vesktop instance

Yes, it happens then too. Yesterday I installed the flatpak to see if it happens there too. Clean install and I immediately go in a voice call to test, without cloud sync or settings o...

#

Confirming the same thing too then!

Also quick question, is everyone who is affected by this issue running on Ubuntu (or similar)?
I have noticed @midblep saying he is running Ubuntu 23.10, I was running Kubuntu 23.10 until yesterday and now 24.04 (which is virtually identical).

If so we might finally have a clue on what it could be.

#

Confirming the same thing too then!

Also quick question, is everyone who is affected by this issue running on Ubuntu (or similar)? I have noticed @midblep saying he is running Ubuntu 23.10, I was running Kubuntu 23.10 until yesterday and now 24.04 (which is virtually identical).

If so we might finally have a clue on what it could be.

Actually, my bad, I am also running Kubuntu, not Ubuntu. πŸ˜…
Been meaning to upgrade to 24.04 soon as well, so I suppose we have rather identic...

#

As said I did notice this happens primarily when I am quiet for some time and then starts talking, my guess is that it's not a KRISP issue but a gain issue.

Might be connected to an old bug I noticed, despite automatic gain control being disabled my microphone is still adjusted all the time up and down based on my level of voice, this bug is still happening to this day, could the two bugs be related?

charred monolithBOT
charred monolithBOT
charred monolithBOT
verbal pumice
#

days since last force push:

austere talon
#

this is the last one

#

the previous ones were cause cobu sync was broken

verbal pumice
#

that's the github equivalent of an L + ratio holy shit

charred monolithBOT
austere talon
#

it was just one line fix so its faster for me to just push it myself than review pr and wait for them to apply

#

wdym

#

do u wanna use it in a theme

#

patches just patch discord's javascript code

#

you need to find the code of your desired component and write a regex that patches it to do what you want

#

it would be simpler to just say what u want and i can add it

charred monolithBOT
austere talon
#

horror

#

thatsalready a thing

#

the title attribute

#

check the parent

#

title="Not Even Ghosts Are This Empty"

#

ohhh wait youre talking about discords spotify activity

#

i thought u meant vencords spotify controls

#

has all u need

tropic wagon
#

this song is a banger

austere talon
#

ohhhh

#

i mean u dont need that either

#
/* song */
.content_ .nameNormal_ {}
/* artist */
.content_ .detailsWrap {}
/* album */
.content_ .state_  {}
#

that will get all activities tho

#

if u want only spotify u can do like

.activity_:has(> img[src="/assets/7231645d01e0b14f58cc.svg"])
#

thats the spotify icon url

charred monolithBOT
austere talon
#

LOL WHY IS THIS A USER CONTEXT MENU

#

@limber skiff did u know about this

charred monolithBOT
limber skiff
#

btw I noticed permissions viewer doesn't patch thread context menu

brazen bone
#

Huh, so skjul means mute in norweigan? That's funny, in swedish it means shed (as in small usually detached building)

austere talon
#

it means hide

#

im learning it

brazen bone
#

There's a rare swedish word "skyla" that means to hide/cover, probably related

austere talon
#

waiiit i didnt know js worked this way

#

i would assume it always evaluates factory()

#

this is soooo much boilerplate

#

im learning norwegian so i can understand varg's stories

#

well he mostly talks in english so that joke doesnt work

charred monolithBOT
austere talon
#

oop

limber skiff
long stream
#

vee is going crazy yaya

austere talon
#

soon plugins will have no more code they will just be json

#

everything will be turned into a property

brazen bone
#

That route risks forward incompatibility if a plugin happened to have its own contextMenuPatches property that was previously inert

austere talon
#

cause all plugins are first party

brazen bone
#

Right, that's true

brazen bone
#

In that case I'm all for it, and other similar properties like message accessories and quick buttons

limber skiff
#

it's not important rn

jagged cloak
#

hilarious you are discord

charred monolithBOT
jagged cloak
# charred monolith

isnt it already? it's already there as an enum, not sure why whoever didnt just do this to begin with lol

jagged cloak
#

when are they releasing poll HappyBun

austere talon
#

trueee

junior olive
jagged cloak
#

i have not been digging discord code for fun

austere talon
#

wait

#

how do u clear the draft

jagged cloak
#

draft_clear?

junior olive
austere talon
#

like

junior olive
#

when they were hackweek project

austere talon
#

the uploaded file persists after command

jagged cloak
#

inch resting

junior olive
#

they released ios testflight builds with polls support but never android or desktop(?)

#

so sad

#

now we wait for real release

austere talon
#

holy shit

jagged cloak
#

make poll

#

i'm always on a testflight build trolle

junior olive
#

no lik

#

there was 2 builds that explicitly had polls

#

they were hackweek builds

jagged cloak
#

o

austere talon
jagged cloak
#

anyway when are you renaming it to Veesktop

charred monolithBOT
jagged cloak
#

what looks wrong about it

#

should i flip that too?

austere talon
#

if its in a dm channel and !serverNotifications, then it ignores it?

jagged cloak
#

there was probsbly a reason for that hang on

charred monolithBOT
jagged cloak
#

i confuse myself let me just change it sillytime

austere talon
#

can any mac users repro

#

this seems like a bogus report tbh

#

but also really old lol

#

also holy shit browser is so outdated lmao

#

poor chrome users

jagged cloak
#

the vencord desktop on my mac is so old it doesnt even have an update prompt lmao

austere talon
#

LMAOO

#

moment

#

why u on vesktop

#

its discord desktop not vesktop

jagged cloak
#

i will use

austere talon
#

LMAOO

jagged cloak
#

you know whats funny

#

that

#

siri so dum

#

vencord.app LMAOO

austere talon
#

SIRI??

#

😭

#

fuck siri gotdamn

jagged cloak
#

Dont you also need a theme for transparency to work

jagged cloak
austere talon
brazen bone
#

You're not gonna get much transparency without a transparent theme, yeah

#

Since most of discord's colors are opaque

charred monolithBOT
#

88fc157 webContextMenus: add Show My Camera item (#2086) - sunnniee
3eada99 fix(ToolBox): don't add entries of disabled plu... - Vendicated
4d198e4 fix wrongly patching 'Events' context menu - Vendicated
13961a4 ReverseImageSearch: add support for image modal - Vendicated
6530526 Updater: Fix grammar (1 Updates => 1 Update) (#... - moxie-coder

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

austere talon
#

@limber skiff i want to port reporter to test prs somehow (on manual review to make sure there isn't a token logger or smth in the pr)

#

but it seems really hard

jagged cloak
limber skiff
#

ngl reporter is one of the coolest vencord features

jagged cloak
#

real

dapper tiger
#

@austere talon

#

i was using discord without a theme

#

its so much faster

#

can anything be done about that

#

im specifically using this theme https://catppuccin.github.io/discord/dist/catppuccin-mocha.theme.css

#

i know its the css selectors

#

maybe some kind of compilation layer?

#

process selectors find all the matches and cache that

austere talon
#

so lightweight

dapper tiger
#

ulgy

austere talon
#

for optimal performance u should only do a basic recolour

#

this looks pretty good imo

dapper tiger
#

guhhh finee

austere talon
#

use client theme its actually really good

dapper tiger
#

but couldnt selectors be processed and cached

austere talon
#

how...

#

r u gonna fork chromium

dapper tiger
#

yes

#

like some middle layer

#

before loading the css file

#

venchord will do

austere talon
#

how

#

fork chromium and do

brazen bone
#

You mean like, replace all [class*="container_"] with :is(.container_hioaw,.container_u1390,.container_u14209,.container_aufwi1)?

austere talon
dapper tiger
dapper tiger
#

is there a way to find the matching element for a selecotr

#

programatically

brazen bone
#

document.querySelectorAll

#

Alias $$ in devtools, at least in firefox

dapper tiger
#

venmium

#

ven will do $$("*")

brazen bone
#

That returns an array of 3728 elements

#

That's fewer than I expected honestly

austere talon
#

7500 for me

jagged cloak
#

6848

austere talon
#

noobs how yall got so little

jagged cloak
#

discor element hack

#
function shouldIgnore(channel: Channel) {
    switch (channel.type) {
        case ChannelTypes.DM:
            if (settings.store.dmNotifications) return false;
            break;
        case ChannelTypes.GROUP_DM:
            if (settings.store.groupDmNotifications) return false;
            break;
    }
    return !settings.store.serverNotifications;
}

Does this look less confusing (also changed to webpack export)
dms > false, gdms > false, everything else (they're all guild channel types afaik) > rely on server notifications

#

double check before i push dumb things

dapper tiger
#

animal insane

brazen bone
#

That's equal to ```js
if(channel.type === ChannelTypes.DM) return !dmNotifications && !serverNotifications;
if(channel.type === ChannelTypes.GROUP_DM) return !groupNotifications && !serverNotifications;
return !serverNotifications;

#

And I think that one's way clearer

dapper tiger
#

yes

jagged cloak
#

thought so

#

dont need switches for everything

brazen bone
#

Seems pretty weird having serverNotifications be a master switch anyway; shouldn't they be independently toggleable

jagged cloak
#

not really

#

i dont see a benefit of toggling an announcement channel independently from other guild text channels

#

for example

brazen bone
#

Yeah but DMs should be independent from guilds

jagged cloak
#

they are now

brazen bone
#

Not in the code you sent

jagged cloak
#

oh ffs

charred monolithBOT
jagged cloak
#

unless i just made it overly complicated

brazen bone
#

The switch bodies are equal to js if (settings.store.dmNotifications) return false; else return !settings.store.serverNotifications; aka return !settings.store.dmNotifications && !settings.store.serverNotifications;

charred monolithBOT
dapper tiger
dapper tiger
#

i was gonna do thast myself someday but never bothered

austere talon
#

@turbid hatch sorry, remind me what the result of our dbus experiment was?

dapper tiger
#

*minimized

#

btw

austere talon
#

for enabling autostart via portal

turbid hatch
#

we cant do it through the command line because the cli tools dont support what we're trying to do

#

so we need a native

austere talon
#

uhhh

#

did we not establish that it did support it

turbid hatch
#

no, we established it didnt support the types needed

#

because we need to pass a dictionary or something like that and the cli tool doesnt support it

austere talon
#

yes but then i found a different program

turbid hatch
#

uhh

#

i dont remember then beyond that

austere talon
#

there

charred monolithBOT
austere talon
#

riiight i couldnt test further cause i was on phone

#

ill test rn

#

and see if it does anything

#

(i love restarting!!)

charred monolithBOT
austere talon
dapper tiger
#

i hate portalss

austere talon
#

what is this supposed to mean?

charred monolithBOT
thick kestrel
#

wow this embed had a stroke

austere talon
#

why do u repeat the entire string

charred monolithBOT
thick kestrel
#

done

thick kestrel
#

actually hm

#

I could fix this embed stroke as well

#

but that's out of scope for the current name/description

#

idk if I should do that now or in a later MR

austere talon
#

what?

austere talon
#

idk if doing that is a good idea

thick kestrel
thick kestrel
#

it's definitely much less of a problem

#

it's just that Discord Markdown is different to normal Markdown

#

and not an actual bug in the implementation

#

because this gap sure looks like a bug from both code and usability perspective

austere talon
#

youre using the old header btw

thick kestrel
#

oh

austere talon
#

dont copy paste from other file, let eslint autofix insert it

#

anyway it doesnt matter

charred monolithBOT
thick kestrel
#

ay

austere talon
#

@topaz thistle is this doc outdated? or is the typescript definition wrong

#

according to the type, both include and exclude are required

#

seems to be that the type is just wrong

#

i tried and it works fine without include

jagged cloak
midnight raven
#

in discord/0.0.39/modules/discord_desktop_core/core.asar

#

but they only use that if you're watching a video or smth like that

#

so really cant be..

#

IdleStore seems interesting thats purely the afk stuff

#

in gateway: M.default.remotePowerMonitor.on("resume", this._handlePowerResume))

but that just sends a heartbeat

charred monolithBOT
charred monolithBOT
midnight raven
#
gdbus call --session --dest org.freedesktop.portal.Desktop --object-path /org/freedesktop/portal/desktop --method org.freedesktop.portal.Background.RequestBackground "a" "{'Autostart':<true>}"
charred monolithBOT
austere talon
#

i hate dbus

#

I GOT IT

#
spawnSync("gdbus", [
    "call",
    "--session",
    "--dest", "org.freedesktop.portal.Desktop",
    "--object-path", "/org/freedesktop/portal/desktop",
    "--method", "org.freedesktop.portal.Background.RequestBackground",
    "",
    `{'autostart':<true>,'commandline':<['${process.execPath}', '--start-minimized']>}`
], { encoding: "utf-8" });
charred monolithBOT
austere talon
#

just with css

olive aurora
#

yop no one will notice

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
topaz thistle
topaz thistle
topaz thistle
topaz thistle
#

Venmic supports that already

warped turret
#

Is there an api to open discord links natively without reloading the page?
In particular, I'm looking for a way to go to a message as if it happens when you click β†’ #info message

cunning canyon
#

NavigationRouter

charred monolithBOT
topaz thistle
#

Looks like colorful gruvbox

verbal pumice
#

looks like gruvbox material

topaz thistle
#

Ah rip in that case

#

Gruvbox Material looks ass with cpp

#

Sadly many themes do

charred monolithBOT
austere talon
austere talon
#

anyway the type doesn't have to be precise

charred monolithBOT
topaz thistle
austere talon
#

but not passing the option at all for include means everything is included

topaz thistle
#

True

#

Will update later, even though they're technically equivalent it might help imply meaning

charred monolithBOT
charred monolithBOT
#

As of now it looks like 3 out of 3 people experiencing this issue have an Ubuntu based distro then.

Please if anyone using something else can write a comment I would be very happy, at least we can finally say for certain the issue is there. Try to use Vesktop on Arch, Gentoo, Fedora or whatever peeps!

I use Arch Linux x86_64 and unfortunately have the same problem:

  • Stable 256231 (96a39c5)
  • Vencord D73790e (Vesktop V0.4.4)
  • Electron 27.1.2
  • Chromium 118.0.5993.144
  • Li...
charred monolithBOT
#

As of now it looks like 3 out of 3 people experiencing this issue have an Ubuntu based distro then.
Please if anyone using something else can write a comment I would be very happy, at least we can finally say for certain the issue is there. Try to use Vesktop on Arch, Gentoo, Fedora or whatever peeps!

I use Arch Linux x86_64 and unfortunately have the same problem:

* Stable 256231 (96a39c5)

* Vencord D73790e (Vesktop V0.4.4)

* Electron 27.1.2

...

charred monolithBOT
charred monolithBOT
charred monolithBOT
#

When I try to screenshare on Hyprland (NixOS), I get the following error continuously:

[30147:0106/182551.162630:ERROR:shared_screencast_stream.cc(241)] PipeWire stream state error: no target node available

The following portals are loaded and active

$ systemctl --user list-units --type=service | grep portal
  xdg-desktop-portal-hyprland.service loaded active running Portal service (Hyprland implementation)
  xdg-desktop-portal.service          loaded active running Port...
topaz thistle
#

@austere talon That'll work right?

#

Okay I'm not too sure if that'll work

#

Nvm seems to work but the auto-complete is a little fucked then

#

I can also do it like that lmao

#

Oh you already made both optional

#

I'll stick to your changes then

charred monolithBOT
#
[Vencord/venmic] New tag created: v3.2.1
austere talon
#

yep

austere talon
#

sorry you don't actually need overloads

charred monolithBOT
topaz thistle
torn knot
#

It's a theming plugin

#

though the themes are on a different repo

charred monolithBOT
torn knot
#

It all comes down to ease of use

#

And simplicity

#

It does one thing and it does it relatively well

#

change discord's themes

#

and it also allows you to create your own color themes with no compromise on quality

#

what is that

#

where is it?

#

is it in vencord?

verbal pumice
#

its a close to finished pr

torn knot
#

but it does require for the presets to exist and/or to be written by hand, right?

#

that's already how it works

still wasp
#

what are the actual capabilities of usercss?

brazen bone
torn knot
#

And colorways also have presets to make colors work with other themes or make them behave a certain way

oak hull
#

i NEED usercss for this messagebar

#

could make it default but would prefer a switch method via usercs

#

s

torn knot
#

Yeah, this goes beyond what I designed colorways for

#

they are color-only themes, meant to be easy to use, create and share

oak hull
#

isnt that clienttheme but import/export

torn knot
still wasp
#

this lowkey slaps

torn knot
#

I'm also working on making it more acessible for developers to add their own presets, that can then be used by the plugin in a myriad of ways

still wasp
#

wtf how did you do the line thing?

torn knot
#

font

still wasp
#

uhhhhhhh

#

if you open up multiple dropdowns it kinda gets fucked

torn knot
#

huh

still wasp
torn knot
#

except for the preview panel overflowing, I can't reproduce the issue

torn knot
# still wasp

seems to be a theme issue, cause on default discord I can't seem to reproduce it

charred monolithBOT
still wasp
torn knot
#

oh

#

wait

#

nope

#

still can't reproduce it

#

(on my laptop, which has the latest version)

still wasp
#

oh its a zoom thing

#

i just tested it zoomed out by 1. it doesnt do it now

#

makes sense

torn knot
#

I even tried zooming, huh??

#

oh well

#

I will fix these issues soon, but right now, I want to work a bit on the bd version, just for the funsies

#

and possibly a new theme(?)

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
#
[Vencord/venmic] New tag created: v3.2.2
topaz thistle
#

@austere talon I've updated the types a little so that either exclude or include are required

charred monolithBOT
analog knoll
austere talon
#

we really need to update the vesktop "branding"

#

at this point it has many upsides over stock discord, especially on linux

tawny cipher
#

also does the "nothing is loaded" state have to be yellow, is that like an electron thing

austere talon
#

so we should really work on

  • a better description
  • a quick overview of the differences and why you should use vesktop
  • a proper website for it
turbid hatch
#

vesktop.vencord.dev

analog knoll
#

It can be argued that for a lot of people including me the working audio from screen shares is the most important feature

austere talon
#

honestly i never intended vesktop to be linux focused but it kinda is now ig?

turbid hatch
#

i mean it has the most benefit on linux

austere talon
#

so we could cater more to the linux audience with our "branding"

turbid hatch
#

by being the only fucking thing that works xd

austere talon
#

but its still a good alternative on windows & mac

topaz thistle
#

Yeah we're the only ones with proper audio support (not counting discord-screenaudio cuz I wouldn't call that proper)

analog knoll
#

Honestly don't see the reason of using it other than the themes on windows. I think better discord dominates in that field though. On a Mac it doesn't seem to support audio when screen sharing it would seem, correct?

austere talon
#

yes

#

on mac its kinda downgrade until we implement that new audio share thing

turbid hatch
#

usercss time

#

brb

analog knoll
#

The native discord client also doesn't support it on a Mac

austere talon
#

actually i should create a roadmap kinda document for vesktop

#

i have a lot of plans but i keep forgetting them and its good for tracking

charred monolithBOT
topaz thistle
austere talon
#

uhhh

#

until recently u needed a kernel module to record app audio

topaz thistle
#

yeah that's my last stance as well

austere talon
#

but crapple made some screen capture kit kinda thing that allows apps to record audio

#

its pretty new but discord uses it now

topaz thistle
#

ohh that's neat

austere talon
#

you should talk to our apple people for more info

#

it was mostly @junior olive who talked about it

topaz thistle
#

maybe we can make venmic be a small wrapper around that

austere talon
#

^

topaz thistle
#

It'll require native code anyway right?

turbid hatch
austere talon
#

probably?

topaz thistle
#

Probs Objective C

austere talon
#

im assuming electron will support it sooner or later

turbid hatch
#

yeah

#

it'll require obj-c

#

because it's in framework

austere talon
analog knoll
austere talon
#

can swift c++-interop

topaz thistle
#

Well if we add it to venmic then it'll be Obj-C(++)

austere talon
#

its kinda meaningless

#

it makes it seem like vesktop is just the same as discord desktop but slightly more convenient cause vencord installed

topaz thistle
turbid hatch
turbid hatch
austere talon
turbid hatch
#

it just .. works

austere talon
#

or is that unrelated

topaz thistle
#

Kind of

#

I will re-use a lot of it

#

But the implementation will be a lot different

#

eventhough

#

Now that we have mixed include/exclude support

#

I think I can even yank the whole thing

turbid hatch
#
- (void)presentWithCompletion:(void (^)(BOOL success))completion;
#

oh what the fuck is this

austere talon
#

it looks like it wont be as simple as just recording audio

#

instead you'll likely need to use screencapturekid for the entire recording

topaz thistle
#

ugh

austere talon
#

and make electron use that

turbid hatch
#

hm

#

noah

#

it might be easier to actually write swift for this

austere talon
#

it shouldnt be that much harder, just another monkeypatch in js world

turbid hatch
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

turbid hatch
#

but its apparently a type signature for async api calls

austere talon
turbid hatch
#

which SCK uses throughout the entirety of its api

#

but in swift its marked as an async throws signature so the interop is easier

austere talon
junior olive
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

turbid hatch
#

we can probably write a slightly nicer wrapper in swift and expose it to C++ since it autogenerates the C header and does the type interop for you

junior olive
#

I love swift

junior olive
topaz thistle
turbid hatch
#

njeither

#

ive written objective c before

#

i did not enjoy it

topaz thistle
#

Idk even know if clangd has proper supprt for it

grave mangoBOT
turbid hatch
#

like what the fuck is this

topaz thistle
#

But since apple contributed a lot to llvm I guess it does

topaz thistle
still wasp
#

im trying to put html + react components into the vencordtoolbox code, im getting the error

A component threw an Error
 Error: Menu API only allows Items and groups of Items as children. Received h1 (object) instead

is there a way that i can fix it? or am i just gonna have to make an item (whatever tf that is)

turbid hatch
#

what

#

what are you trying to do

austere talon
#

menu api only allows menu api items

#

you cannot put random elements

charred monolithBOT
#

This is not really a direct roadmap, mostly just tracking features that are planned

  • [ ] Implement global keybinds
  • [ ] Get rid of the update prompt
    • [ ] Auto update on Windows via electron autoupdater
    • [ ] Disable entirely on Linux. Auto updating will be done via flatpak / package manager (set up apt/rpm repo?)
    • [ ] Likely disable entirely on Mac. OR, steal someone's code signing certificate and use auto updating
  • Maybe use [screencapturekit](https://developer.apple.com/d...
austere talon
#

if u have anything else just say

analog knoll
#

Btw i set up brew tap for vesktop

analog knoll
#

Brew requires us to sign before we can put it into their main repositories

turbid hatch
#

well thats not gonna happen lol

still wasp
austere talon
#

actually someone offered their signing cert

#

i forgot to reply i think

turbid hatch
austere talon
still wasp
analog knoll
#

In that case we could create the tap inside of vencord github Organisation and have it as one of the official ways to install it on a Mac

turbid hatch
austere talon
#

really

#

what for..

turbid hatch
#

yeah

#

im going to be doing ios dev

still wasp
austere talon
#

well that works

turbid hatch
#

im going knee deep into the apple ecosystem in like

#

a couple of months

#

so im going to have an account anyway

#

i can just buy it a tad early

austere talon
#

I CAN STILL SAVE U......

analog knoll
# austere talon what for..

Instead of going through the update process of uninstall vesktop and reinstalling, it updates with all of your other brew packages

turbid hatch
#

THE POT HAS BEEN MADE

#

THE PAYCHECKS HAVE BEEN SPLIT

#

APPLE HAS TAKEN MY SOUL........................,

still wasp
#

except my 2 brain cells could never figure it out trollf

turbid hatch
#

also i sorta just wanted it cause i want to actually start publishing apps on ios lol

turbid hatch
#

i can do it on andoot easily enough

#

but not ios

austere talon
#

to have a submenu just use a Menu.MenuItem with more menuitems as children

#

for checkbox, it's Menu.MenuCheckbox

#

and there's Menu.MenuRadio for radio

analog knoll
#

Btw i have an apple dev account

still wasp
#

ahhhhhhh

austere talon
#

theyre all typed so u should have no issues

still wasp
#

so is menu just a general tool for making context menus and similar things with vencord?

analog knoll
charred monolithBOT
analog knoll
austere talon
#

they use it everywhere as well

still wasp
#

oh damn

#

awesome

#

thanks for helping :3

turbid hatch
#

anyway yeah i can buy my account today if u want

#

:3

analog knoll
#

That would be amazing

#

But don't do it just for the purpose of signing vesktop, because as i said, I've got a dev account as well that could potentially do the job

turbid hatch
#

its not

#

like i said ive got ios stuff i wanna sign

austere talon
#

what u makin

austere talon
turbid hatch
#

there was an app a long time ago that i quite liked using

turbid hatch
turbid hatch
#

that was the entire app

#

everyone got to see the clip once

#

and then it was gone

#

just a nice way of keeping in touch with people

austere talon
#

...snapchat

turbid hatch
#

sort of?

#

but focused on video only and has basically no UI

#

and the videos get sent to all of your contacts you have added, you dont pick who to send it to

junior olive
turbid hatch
#

its a keeping in touch sort of app

#

not an app to send personalised messages, just sending people what you're up to

#

because some people quite like that! i found it fun

austere talon
#

thatd be cool

#

then we could also add auto update on macos

#

and would have vesktop auto update on all platforms

charred monolithBOT
midnight raven
charred monolithBOT
turbid hatch
midnight raven
#

atit

#

it works!

#

well in gnome host anyway..

#

i havent tested it inside flatpak or anything

#

likely needs a new talk permission to work

#

or maybe it just doesnt

charred monolithBOT
still wasp
#

is there a method to get the current plugin instead of having to do just

Settings.plugins.PluginName

to get setting values?

midnight raven
#
const settings = definePluginSettings({})

definePlugin({
  settings,
})

console.log(settings.store.mySetting);
still wasp
#

thanks! :3

austere talon
#

what if rename app properly now

still wasp
#

are you ACTUALLY renaming it to veecord NAH

charred monolithBOT
midnight raven
#

packagers will love this change

charred monolithBOT
austere talon
#

works on windows

#

back to linux

charred monolithBOT
austere talon
#

i think this will require some changes to the nix flake?

grave mangoBOT
austere talon
#

i should make a package maintainer role

#

i did but idk scrumps or leahs discord so didnt give it to them

harsh iris
#

thanks for the heads up! i'll make sure this gets in next release

harsh iris
austere talon
#

ic

#

im surprised to even see so many chinese discord users

#

isnt discord banned there

austere talon
#

wait the icon broke somehow

#

nvm

#

just cause u need to install to have proper icon

charred monolithBOT
charred monolithBOT
fringe basalt
# charred monolith

if it's actual malware then they chose the worst combination of registrar and tld they could

#

both hostinger and gen.xyz will take it down very fast after a report

austere talon
#

yeah i already reported to google + hostinger

#

didnt know about gen.xyz

#

will also report there

fringe basalt
#

here

austere talon
#

ya alr there

#

done

austere talon
#

im still wondering about the endgame of vencord.app

#

they've been up for many months now without doing anything

#

at least this impersonator was smart enough to just copy our html and edit it

charred monolithBOT
crude hearth
#

I love how it tries to disable windows defender at first

#

what suprizes me is only 11 detections

#

they even obfuscated the code lmao

#

I honestly have 0 idea wth this is doing

#

wth are those

#

this is a stupid game what the hell

#

since when malwares include games

spark pivot
#

my impersonation reporter finding this website a day after it was made

#

when we normally would have found it way later

crude hearth
#

sounds dumb but ehhh

#

they even made a complete new website

crude hearth
spark pivot
#

scans every TLD for OK responses and lists them

#

then sends the data to a discord webhook

crude hearth
#

love

spark pivot
#

it takes like 9 minutes to run lol

#

cause it runs on gh actions

#

every week

crude hearth
#

how does it run btw

#

does it check every tld

spark pivot
#

yep

crude hearth
#

husk

spark pivot
still wasp
#

is there a way to get an array of all the custom emojis the user has? (from all servers)

crude hearth
#

there are way less TLDs than what I thought

#

how does this take 9 minutes trolldayruined

#

single threaded?

#

wait its async too

spark pivot
#

i honestly forgor why i made it async

#

oh cause some were timing out on my network cause i was sending them too fast i think

#

i dont care that it takes 9 minutes honestly

#

there's around 1400 tlds iirc

crude hearth
#

understandable

spark pivot
#

im just surprised it actually caught something

charred monolithBOT
charred monolithBOT
high oracle
charred monolithBOT
jagged cloak
#

re: plugin natives, in general
you can already call functions from the plugin class, so it wouldn't be unreasonable to add a way for natives to call imported functions would it? or add a util method so plugins can receive data from the native side- (probably easier)
not sure which approach if any you wanna take so i'll hold off on a pr
actually not sure how this even works besides reading a bit on how electron ipc works lol

charred monolithBOT
topaz thistle
crude hearth
#

no idea

#

but that guy seems to put game code inside it

#

I even double checked if I was looking at wrong file

topaz thistle
#

Lol

topaz thistle
charred monolithBOT
lofty notch
#

huzzah

charred monolithBOT
verbal pumice
#

in fact that second patch can be done in a way simpler way

{
    find: "[kb store] KeybindStore: ",
    replacement: {
        match: /inputEventRegister\(parseInt\(\i\),\i,\i,\i\);else{/,
        replace: "$&$self.registerKeybind(...arguments);"
    }
}

this transforms the arguments taken into the function to (id, shortcut, callback, options) (and you'll need the options cause that's what distates if it's keydown or keyup), and the toString function can be reobtained with const { toString } = findByPropsLazy("keyToCode") at the top of your file

#

also there are some extra keybind options locked away by default as "desktop only" even though they work fine on web
in the same module as the first patch

{
    match: /\(0,\i.isDesktop\)\(\)/g,
    replace: "true"
}
#

and remove the "Push-To-Talk is limited" warning

{
    find: ".Messages.PTT_LIMITED_TITLE,",
    replacement: {
        match: /\i.isPlatformEmbedded/g,
        replace: "true"
    }
}
#

sorry for dropping all of this at once

#

i tried to add global keybinds before and gave up because of the aforementioned globalShortcut issue

lofty notch
lofty notch
lime stone
#

how would this work on macos and linux...

#

on macos don't you need to ask permission? on linux with x11 i think you can just log keys without permission trolley but it's not like that on wayland (?)

lofty notch
#

works on x11 as far as my testing goes
i'd assume electron handles all that since we are using its api? (though i don't think we would be for long)

lime stone
#

tbh people should stop using x11

#

(I'm using x11)