#๐พ-core-development
1 messages ยท Page 152 of 1
None
None
None
None
None
None
None
None
real ones know the link from memory
what does it just open the tab
send the link of a search
Does anyone know how I could see if a user and the user in UserStore.getCurrentUser() are friends
disable gw compression
u already receive the raw message content, why make any api requests?
11a9713 fixes... probably. dunno i didnt test any of this - Vendicated
now its time to test on windowss
รl SAS1989;43
?
i love when my code works first try
w
this is not a bad idea, but i don't like the implementation
It would be much simpler to
- download the cli
- create a shortcut (or .desktop file on linux) that calls
vencord-installer-cli --install --location C:\Path\To\Discord && discord. the user can then just use that shortcut instead of the normal discord shortcut and it'll always patch discord before launching it
for ^, we need to add a command line flag to skip updating
so it will purely patch
(currently, patch will always first update ur vencord files)
also jeez going back from crystal to go makes me want crystal back so bad
go sucks ass compared to crystal
sad to see this pr die, smh my head
code was quite shit though
Content
I have tried to make a pr for this, but it didnt really work out (never got merged).
Request Agreement
- [X] I have read the requirements for opening an issue above
i really hope im not violating any rules lole
it just feels like i did something wrong and i havent figured it out yet

it has a text parameter and sends the link to google whatever you put in
also yeah idrc about merging anything i just thought it was funny
this has been bugging me for way too long hahaha (and I don't feel like manually making a new dev build for everytime this thing gets updated)
@Vendicated yeah, that's unfortunately very true. Do you think is there any way to leverage the VAAPI codecs already present in FlatHub? If you tap into those builds you should be able to have a fast video rendering with HW acceleration no? To give an idea this package has the full support for hardware rendering.
org.freedesktop.Platform.ffmpeg-fullThis would be the best way to fix screen sharing using any discord client on Linux until Discord fixes it themselves.
Some...
seemed to autoupdate fine
did it completely in place
yep
works even if the filename is different

code looks fine to me too
this is not a bad idea, but i don't like the implementation
It would be much simpler to
- download the cli
- create a shortcut (or .desktop file on linux) that calls
vencord-installer-cli --install --location C:\Path\To\Discord && discord. the user can then just use that shortcut instead of the normal discord shortcut and it'll always patch discord before launching it
it could also very easily be made a service using that exact same set of steps, and then the user doesn't have t...
installing a system service is extremely undesirable and i will outright say the worst possible solution - it usually requires admin privileges and that should be completely unnecessary to install a client mod...
what is the obsession with making the installer a system service
no
its dumb
stop
my idea is to have an option in the installer to create multiple different shortcuts
- vanilla discord shortcut
- auto repatch shortcut
then they can pin those to taskbar or have them wherever they want
installing a system service is extremely undesirable and i will outright say the worst possible solution - it usually requires admin privileges and that should be completely unnecessary to install a client mod...
it does not require admin services to create a service, nor would this be undesirable. It could be a simple additional option for those who don't want to have to redownload and repair vendors every discord update.
Many other client mods, self hosted, and various other projects ...
literally does
on windows
there is no concept of a user service
you have to have admin to install a service
you can RUN them as another user, but it requires admin to install
and usually running them as a user account that's interactive is actually an extremely bad idea
(the service idea is rejected from the getgo anyway im not doing that)
Amoguscord
it does not require admin services to create a service
windows does, there's no concept of a set of user services and every service should run under a system service account (either one of the existing ones or something under the NT SERVICE\ domain), not a user account. you can't even start and stop services without admin, let alone install one.
nor would this be undesirable
you can't.. state that our own viewpoint is wrong. we see it as undesirable and we won't be doing ...
more correcting, but yes im not going to respond to him anymore like this
this is silly
and yeah i told him we arent doing it like this
we have our own plans for implementation that involves shortcuts like vee previously mentioned.
now i have slightly gotten this wrong
windows does have per-user services, but not on the desktop operating systems
only on windows server
i think?
or maybe its for desktop experience on windows server
well either way it still requires admin rights to install
it does not require admin services to create a service
windows does,
there's no concept of a set of user services(i am wrong, but it still requires admin to install and configure) and every service should really run under a service account (either one of the existing ones or something under theNT SERVICE\domain), not a user account. you can't even start and stop services without admin, let alone install one.nor would this be undesirable
you can't.. state that ou...
no, we create a shortcut for you as part of the install step, you dont have to do it yourself
no, we create a shortcut for you as part of the install step, you dont have to do it yourself
what about users that have multiple shortcuts, shortcuts on the taskbar, start menu, file explorer? you expect them to manually change them all
ok this is getting silly
we dont expect users to change anything, we're giving them a shortcut to use instead, they can just repin it to the taskbar or whatever.
we will NOT do a service because installing one varies on the operating system and varies in permission level, plus overall it is a very strange thing for a client mod installer to run a service on someone's system in the background. doing it on linux, for instance, will be a nightmare because different service managers exist and we'd have to write a us...
๐
oh yeah
@placid wave did you test the steamos changes
with the promise queue
i forgot
thank you for reminding me I will today lol
ty
@ me when you've confirmed if they work so i can merge
i merged in dev recently
is it already out of date
np
hopefully it'll be mainline soon ๐ค
do post reviews and comments on it btw
does help
they need to be in the themes folder with .user.css as the extension, otherwise they'll be loaded as BD themes
if it's not loading, open devtools
BD themes are just loaded as regular css files
with metadata
they have no concept of configuration or anything so the best we can do is give you info about them
usercss on the other hand does so we'll give you a config window
oh
uh
yes
it should do that
i believe something was written into the theme manager
like
thing.user.css ?
or just user.css
must ask
have you rebuilt
did you pnpm i && pnpm build too
or just build
hm
wonky 
you're missing a namespace btw
but it should still load it just without the metadata
or
well
load on a best case effort
it shows up here for me

can you double check devtools
i am bewildered then
are you using the "open themes folder" button to get the right folder?
and then using load missing themes after
and the commit hash it shows is 85b510b
?
wat
yeah that means its on the right hash
im just confused on why the feature isnt working
should be
but use the button since its guaranteed to load from wherever that button goes
hmmmm
@austere talon just want to do a quick recap for the end of the year on what projects i've got running:
- usercss
- glory to usercss
- seems to basically be done, just needs codereview and some minor testing it seems on the mac side of things
- translations
- new but plenty to talk about
- seems like the demand for translations is going up, i've been seeing a couple of people wondering if we'll ever translate vencord
- will be difficult but i think it'd be worth it in the end
- wailsinstaller
- hasn't been updated in a while but seems to [still be quite useful](#๐ฅ-vencord-support-๐ฅ message)
- we should take a look at updating this with the new go installer stuff and potentially moving to it over the old imgui installer? with the new updates it'll take a little bit to add the right things on the frontend but after that it should be smooth sailing
can you go to your vencord data dir
config
and that themes folder is where you're putting your usercss?
and none of those are loading?
specifically?
that's odd
are you using vesktop or discord?
i mean even then
worst case it'll fall back to loading them as betterdiscord styles
so there's no errors at all?
hm?

magic ig
whaaaaaaa?
i mean for me your theme does actually do nothing
its being loaded
i can see the contents here
but its not actually doing anything to discord
try this @crystal walrus
i need to look into wailsinstaller
writing ui with giu gives me cancer so wails might be better
but even writing it in go itself gives me moderate cancer at this point
bleh
io heavy code is NOT FUN to write in go
i mean yeah
with the if statements and stuff its awful
in devtools, if you go to elements, find a style tag with id vencord-themes, is anything actually in there?
id say let's riicrystal but there's not a good ui framework that isn't just sfml
so i think we should just keep it go/wails for future dev
lollll
for now
electron soon
cry
god no
at least with webview stuff its rare you'll get prompted to download it xd
when the theme is on there should be an import with a blob url
do bd themes work?

that doesnt seem like a me thing then
or
well
it might be
but it seems like the theme loader just
isnt working
let me take a look, give me a few

if you restart discord does it work @crystal walrus
after enabling a theme
the fuck
hm?
lol amazing
it should've ignored that file but
oih well
okay so its creating the style
but then its not loading any of the links

its one of the first things it should be doing
thats ery odd
on vesktop it should result in the same issue so im unsure
can you open devtools and reload?
see if there's any errors there
it could be that its erroring out when initing themes
hence why its not working anymore
ah
yeah that'll do it
i think this is a bug in how the theme loader works
let me add a fix
before i go any further, can you click the quickCss.ts:104 and show me the file
wat
right okay
@crystal walrus pull and build
should fix the issue
npnp
just made it soft fail instead of failing hard
:p
make sure to use a preprocessor to make life easy with if statements
it'll compile it for you
Could anyone help me, I'm trying to make a patch where if it shows this pop up it will run a certain function but im not sure what patches to make
and obviously hide the popup
what are you actually trying to do
I'm creating a MessageSplitter basically it splits long messages over the char limit into multiple messages, I've coded all of that and tested it on 2k and it splits, the only thing i need to do now is get rid of that pop up and still call the preSend
how is that now api abuse /gen
now?
this was already made before and rejected cause its kinda useless
just upload as file
i mean its not not useless
Braindead take
You can't view files on mobile
because it's not unrealistic to send 2-3 messages back to back
just make sure to handle slowmode
just make C infinite or put a false in the if check.
search for applyChatRestrictions: thats the module this is in
Oh sorry
@austere talon can you take 5mins to reply to my PR? been waiting nearly two months
Your PR is a draft PR.
You need to make it an official one if you want them to merge it or anything
not asking to merge, just been waiting for a reply to my questions in my latest comment in the PR
Ohhh right mb
Built from:
[46538:1227/163949.950135:ERROR:shared_screencast_stream.cc(241)] PipeWire stream state error: no more input formats
[46538:1227/163949.950174:ERROR:shared_screencast_stream.cc(204)] PipeWire remote error: no more input formats
Warning: vkCreateInstance: Found no drivers!
Warning: vkCreateInstance failed with VK_ERROR_INCOMPATIBLE_DRIVER
at CheckVkSuccessImpl (../../third_party/dawn/src/dawn/native/vulkan/VulkanError.cpp:101)
at CreateVkInstance (../../third_...
You are missing or have incompatible drivers. This is not a vencord/vesktop issue
least broken nixos setup 
one day your brain will run nixos
Well, you could help me fix that problem? I don't like left being high and dry. Are you sure that the issue is with Vulkan? Because I think the issue is with PipeWire, and if I'm right, that's more difficult.
Built from:
[46538:1227/163949.950135:ERROR:shared_screencast_stream.cc(241)] PipeWire stream state error: no more input formats
[46538:1227/163949.950174:ERROR:shared_screencast_stream.cc(204)] PipeWire remote error: no more input formats
Warning: vkCreateInstance: Found no drivers!
Warning: vkCreateInstance failed with VK_ERROR_INCOMPATIBLE_DRIVER
at CheckVkSuccessImpl (../../third_party/dawn/src/dawn/native/vulkan/VulkanError.cpp:101)
at CreateVkInstance (../../third_...
please do not open new issues after your old issue has been closed. we do not maintain the nix package, we cannot help you
u cannot make this shit up ๐ญ
Because I think the issue is with PipeWire, and if I'm right, that's more difficult.
vkCreateInstance failed with VK_ERROR_INCOMPATIBLE_DRIVER
hmmm
or i guess both errored
i love that it takes like 2 seconds to google the library in the stacktrace and see that it's a WebGPU library
lmao
buddy u just need gpu drivers.. mesa...
vulkan initialization failed due to unsupported drivers? looks like a vesktop issue to me tbh
it isnt
i am being sarcastic
oh lol
Please do not reply to fresh (and valid) issues or support requests dismissively, condemning the author for their choice of technological stack. As any other Linux user, it is your obligation to respect people's choice. What is not your obligation is providing support; however doing so is very appreciated. And what you should not do is dismiss people rudely. If you follow basic social contract and exercise proper etiquette, people will like you. If you do not behave yourself, people w...
the author
okay thank god
None
None
None
None
but i really really did want to point out his hypocrisy
no dont reply
If you do not behave yourself, people will disrespect you and disregard your wishes, and open duplicate issues, which may prove to be a nuisance.
it sounds like this guy is the teacher of a kindergarten class
None
None
None
None
If you do not behave yourself, people will disrespect you and disregard your wishes, and open duplicate issues, which may prove to be a nuisance.
wow, ok, so you're going to act in bad faith because we dont want to support something we explicitly have said we do not support in the past
i wont lol
I AM POINTING OUT THE HYPOCRISY.
u need to stop arguging with these people and just ignore them ๐ญ
whats sad is that they dont seem like a troll
the installer service guy as well
their profile looks serious
maybe i should just shut up because ive never actually used linux although i really doubt that driver issues have anything to do with vesktop, lol
I do not believe that you know nothing about the issues below
we know enough to realize it's not our problem
I mean, this is obviously none of your business, but you could have been more professional with something along the lines of "This is a downstream issue, report the issue to NixOS."
saying "your OS is bad" is dismissive and can make people mad when there's no reason to do so
i agree it was a little unprofessional but it didnt constitute the last issue
HUIDASHIJUOFUJIOEHUJNIGEWHUJIEGWOIJEWGIOJEGWIOUJEGIOJERGDSIOJERGJOIEGJOIEGIOJE
we have no reason to provide help to someone who demands support for something that isnt even our problem
NOOO
all we know that it's not our problem
jesus
and that's what i said
and his issue complaining about our conduct accuses us of knowing how to fix it but not telling
WHAT IS WRONG WITH THIS GUY HAHAHA
we literally know fuck all
we dont maintain the nix package
we maintain a flatpak
that's IT
make sure he doesnt
im reading through how the nixpkg even works
i dont know why they're doing half of this shit
there's probably some good reason why but i dont get it
yeah, just saying the last comment (the Fedora link) might have been a bit more professional about it
it's a running joke and if he genuinely got hurt by it then i dont know what to say
fucking hell i cant stop laughing
this is genuinely hilarious to us
cant this mf open an issue wherever the vencord package is
they should
(so we dont have to deal with him)
but he immediately comes to us blaming us, and then refuses to go to them even though we've said its not our problem
I AM NOT PROFESSIONAL
VENCORD IS NOT PROFESSIONAL
VESKTOP IS NOT PROFESSIONAL
I HAVE NO OBLIGATION TO BE PROFESSIONAL
(/lh)
well ok
so true
vencord is a personal project originating from a joke
i do not understand what he gets out of trying to file an issue on our own repo reporting our conduct to us
me when "the cutest discord client" isnt meant to be professional
like i get the sentiment
๐คฏ
it's like reporting an employee that is unprofessional to the employee that's unprofessional
explicitly ignores the modmail reasons
and then tries to talk to us
modmail is for the SERVER
not for DEVELOPMENT or the MOD
no thats totally fine, i welcome people pointing out if i or another maintainer / contributor actually do misconduct, feedback is good and welcome
but
- that was absolutely not misconduct
- if you read our COC, you're supposed to send an email, not open an issue
fr read our cock
point 2 was the point i was making mostly
because said people violating conduct can just delete the issue
(which is what i did, because its stupid)
and im willing to be very clear in saying that i did it because vesktop issues should be reserved for.. vesktop issues
not someone complaining that we refused to help with nixos and being accused that we're hiding info on how to fix it
idk this guy is definitely weird, I just thought they could've been handled better
i have actually read through that issue and i literally dont know whats going on beyond that its some nixos weirdness with how drivers work
funniest thing is i accidently closed that modmail
i didnt mean to
i was gonna check if its him and then close it but misclicked cause cold hands
but thankfully it was indeed him so the close was okay

i mean in the end
OSS is ran by the people who maintain the projects
we can do whatever we like as long as we're within github's rules
and we are!
yeah ofc
also yeah i have no idea what this nixpkg does
but also searching up "nixos vulkan" gives a bunch of things talking about how vulkan doesnt really work properly
dfc6970 fix(security): use promise queue for steam pipe... - lewisakura
oh yeah
@placid wave there you go its in main now
i dont know if you tested it but shrug
it should be fine
buggy packaging happens but reporting buggy packaging to upstream is dumb
the only packaging that can be reported to us upstream is what we ship on releases and flatpak
how tf is upstream supposed to fix your issue
that's what i said ๐ญ
i looked up the error and found a stack exchange forum that seemed to fix the issue
i'm closing this because you have not correctly updated the dependency (lock file also needs an update)
however, i will experiment with & test electron 28 myself and if all works correctly bump myself
thanks for bringing this issue & its fix to our attention!
what's the point of adding this dependency? your use case is just glob("./dir/*") which could be replaced with a simple fs.readdir
this comment is really only relevant for understanding this change, but not for future readers
what's the point of importing inline? should likely be moved to the top level
what's the point of passing these settings via ipc? the main process also has access to these settings so you don't need to do that
consider inline requiring this module to fix the circular dependency issues in a cleaner way
why move these exports into a global variable? i don't really like that. i think it was better before
Fair point, I'll refactor things
as far as i understood, tray badge is not available on mac, right? if so, this copy should not happen on mac
@austere talon you can put icons in the menu bar in the top right
im unsure if this pr works with that though
does building on mac imply targeting mac?
usually - electron-builder will use the host OS
this is pretty cool, thanks for working on this!
Can implement the badge image creation live instead of in build step in case other modifications to the tray icon are needed (voice connected, etc.)
that does sound like the most future proof / maintainable solution, i agree. just passing the arrayBuffer to the renderer, creating the image with canvas api and passing it back to node. i think that's actually also what the Discord app does
tray needs to be held in an object of some sort because it can change change or be assigned to null. I figured if I was creating a singleton for tray anyway might as well move mainWindow in there to clean up the need for require hacks elsewhere
yes! artifacts are built on their respective platform. cross-compiling is technically supported, but
- i don't think you can cross compile mac builds
- we don't cross-compile (and don't support it)
does mac not have a tray?
menu bar top right
i remember there being some issue with the vencord tray icon being MASSIVE on mac in the past
oh yeah lmfao
icons usually go up here though
which is mac's equivalent to the system tray
a la
I didn't know that- will change
why is mac unsupported anyway? can you not customise the menu bar icons?
you can import the settings api from src/main/settings.ts
i think its kinda funny that vesktop has a fully reactive settings api for vencord settings but vencord itself doesnt xd
we could port it 
i need to refactor vencord itself to port the vesktop goodies over
this is literally just an improved version of vencord's settings store api https://github.com/Vencord/Vesktop/blob/main/src/shared/utils/SettingsStore.ts
and i made it so that when u change a setting in renderer, it notifies the main process of what changed
which is amazing cause u can have code like this
// main process
Settings.addChangeListener("someSetting", () => {
doThing();
})
// renderer process
settings.store.someSetting = 42
vencord can only DREAM of having that
i remember we have something similar cause we have change listeners for uhhhh
quickcss
but its not like that
**settings.ts: **Lines 10-11
export const Settings = new SettingsStore(VesktopNative.settings.get());
Settings.addGlobalChangeListener((o, p) => VesktopNative.settings.set(o, p));
**SettingsStore.ts: **Lines 72-74
* @param pathToNotify Optional path to notify instead of globally. Used to transfer path via ipc
*/
public setData(value: T, pathToNotify?: string) {
ahh thats it
vencord main process code has horrible access to settings
basically it reads and parses the file on demand
and has no way of detecting settings changes
Provided to YouTube by Universal Music Group
Buddy Holly ยท Weezer
Weezer
โ A Geffen Records Release; โ 1994 UMG Recordings, Inc.
Released on: 1994-01-01
Producer: Ric Ocasek
Studio Personnel, Engineer: Chris Shaw
Studio Personnel, Asst. Recording Engineer: Hal Bellknap
Studio Personnel, Asst. Recording Engineer: David Heglmeirer
Stud...
whoops
that wasnt the
right link
YES IT WAS FYM
also another thing i dislike is having to copy paste code between vencord and vesktop
optimally i would want to make a separate stdlib package
**quickCss.ts: **Line 121
addSettingsListener("userCssVars", initThemes, false);
there we go
yeah that was it.. i had to add a new false thing to prevent it from like
yes that was it
we had no wildcard listener
so i had to add exact
butttt that's really painful to maintain cause then you have to
- update the stdlib package
- update dependency in both projects
- somehow import the package into both projects (npm??? PAIN!)
the urge to monorepo...

girl? we do
you pass null or empty string as first arg
ohhh
:P
in this case i need to recompile themes every time a usercss var updates
so we use a wildcard listener that checks if the path starts with userCssVars
sorry
if it includes userCssVars
its sorta shitty but works
actually that should really be changed to startswith

you can change let exports
export let tray: BrowserWindow;
// later
tray = newWindow;
i dont like the boolean
const enum PathMatchStrategy {
Exact,
StartsWith,
EndsWith,
SubString
}
function addSettingsListener(path: string, callback: yes, patchMatchStrategy = PathMatchStrategy.Exact);
well i'll rework settings anyway
do u have any better idea for stdlib than to use npm / monorepo
should i leave it for now and we can add those strategies into the rework?
submodule?
git submodules? but then you have to manually update every commit
u still have to edit two git repos which sucks
Doesn't this require reimporting the module every time you want to access the up to date object? I guess I'm not actually sure how module import semantics work...
hm
hmm
hmmmmmmmmmmmmmm
wtf
why is mcr on
okay
sure
wait
could manage through npm using github as the release method, so we arent distributing a package but we can just download it or update it easily via a pnpm up
why is mac unsupported anyway? can you not customise the menu bar icons?
yes but they can only contain black and alpha
no, imports update dynamically. the next time you access the import it will be updated
i think submodule is the cleanest way to have always up to date shared files
probs, and also i suppose it means it fixes it between releases so if we need to go back for whatever reason we have the exact commit of the stdlib we used
it does
I added this toggle to SendTimestamps as I don't like the default behavior and I'd like to have the option to disable it
should I also add a corresponding toggle for the button?
oh
that looks shit
wtf is thjat lewi ๐ญ
vencord mac logo
but because it has black borders
just making it black doesnt work
hm
also any better ideas on the description and name
as I feel like mine are shit
i will test NOW
can u please test that ur nvidia pr still works aagamer
cause there were also other changes to the window show logic
uhhhh sure
soon
very soon
steamer first
i still hate that that is the nvidia fix
we will fork chromium to fix soon
vromium
why are we waiting for that issue? according to the first link it should already work, no?
also this is literally wrong
and see if that fixes it first
transparencyOption = windows mica
wdym
could be remembering wrong tho
transparencyOption is windows only 
oh
i mean
you need
transparent: true
but im just misreading
anyway time to shutdown terrible windows and boot steameros
well according to that issue you don't need it for mica to work
deck bios has a horrible bug where if it detects a windows partition it overrides the boot order to put windows first
so you have to use the boot menu or make a systemd service set bootnext every boot
also i love the ssd showing up as efi hard drive
sanest bios
please make this configurable (disabled by default)
otherwise this is not mergeable because it breaks windows convention and is inconsistent with stock discord
valve is getting creative with steamos codenames
"SteamOS 3.5.12 Preview: Elves in Tuxedos"
amazing
FIXED A SYSTEM REBOOT WHEN CONNECTING JOY-CON CONTROLLERS
HOW DID THEY MANAGE
oh my god 6 minute update for 3 bug fixes
guhhh
still faster than windossw updates
@austere talonlmk when electro 28 pushed
i will test
why introduce this versioning scheme? i don't like it
just add handling for the case that reading state.json fails with ENOENT and transfer the state data from settings.json
is that actually the entire movie
wow, I did not know that's what export let did... what the fuck. I'll change it back to the require hack as well then
your balls will fall off
test now
wont be happening for a bit
oh hey its scrumplex
good
pretty cool
it's better than if let in rust
what's a cross platform way to detect first launch of the app (including first launch after reinstall)
currently vencord just has a "setting" firstLaunch
I don't think you really can do that
write a file somewhere and then delete that file in the installer every time you uninstall/reinstall/repair/etc.
like at sll
but if you uninstall and reinstall vesktop it obviously will still have that setting
we dont really control the installers...
this is for vesktop
yeah I think you have to just live with that
it needs to work on all packaging formats
hm
to put it bluntly
you're fucked
there is no crossplat way that is guaranteed to work every time
my first idea was to write the file in the exe dir (cause i assume that directory is nuked on uninstall) but that won't work on linux cause most of the time that dir will be root owned
can we use the create date of the exe dir?
what do we actually need to do first time every time
just so we arent x/y probleming ourselves
basically
const installedAt = stat(dirname(exePath)).createdAt;
if (!settings.firstLaunch !== installedAt) {
isFirstLaunch = true;
settings.firstLaunch = installedAt;
}
will this work
no
okay fedora is updating 600 pa kagss
find to test steamer
windows create date can be finnicky
I'm surprised to hear casted require being called cleaner than just normal imports in a typescript context... but sure
**fixes.ts: **Lines 25-33
if (isFirstRun) {
// Hide "Download Discord Desktop now!!!!" banner
localStorage.setItem("hideNag", "true");
// Enable Desktop Notifications by default
waitFor("setDesktopType", m => {
m.setDesktopType("all");
});
}
nix users will murder you for this I imagine
ah i see
just do the first one if these always
no reason not to
good
actually waittt
lol
that code in paritcular uses localStorage
isnt that supposed to get pruned after reinstall...
no
no
then why do you get logged out after reinstall
vesktop only

desktop notifications are disabled by default on web (cause of permissions)
we want to enable them by default
but we also don't want to enable them after the user explicitly disabled them
so we can't just unconditionally enable them, we need a way to determine first launch
you could also say you need to determine whether the user explicitly disabled them
i think just doing it in settings is fine enough
if they've turned it back off then i dont think we should do it again if they reinstall
i am the biggest opponent of X/Y problems i would never!
!!!!
maybe
but also even then we still need a reliable way to detect first launch
no
there are so many things i wanna do better on clean installs
for example i want to force update vencord files on reinstall
so if vencord is broken users can reinstall vesktop to fix it
that was so easy to find
i will patch it you're right aagamer
HOW DO I CANCEL GIT STUPID ASS REBASE ON PULL
SendTimestamps adds two features allowing to send timestamps: the button in the input area, and the replacement of timestamps in message contents. This allows disabling content replacement if the user only wants to have the input area button.
Something I'm not sure on is whether a corresponding setting for the input area button should be added as well. The description of the setting might also use some improvement.
GUHHHH
ctrl+c
git rebase --abort

my most used command /hj
hey you said cancel
no errors at all
without ur fix?
how do people even push broken code like that
@austere talon I'll confirm since we're pulling Settings into appBadge.ts now as well: you would prefer the right version over the left version here?
surely you'd notice during testing right?
(says me who hardly ever tests code before pushing)
dsGet returns undefined, not null, when a key is missing, so this check never worked (which I'm now confused about because I tested this...)
check the modification date of the executable you're running from
i was gonna do === undefined but got lazy and realised that this is either going to be undefined or a string
so
and if its an empty string its also wrong xd
not crosscompat with windows
modified date isnt when the executable was written
in a lot of cases
it's when the executable was built
imagine if that worked on some platforms... obviously wouldn't work universally...
huh
do you mean downloaded?
even the second commit was just me reading the code some time later and noticing issues (still didnt test)
but guess what it just worked immediately during my first test
is there a http header to set the date??
average ven commit
u love
i do
you
https://decky.xyz sending a test link
รร
ยถ
yeah ive done that before
do you ever
รฆลฟยถWรฤฆยงยฎ ฬฤฆรยฎยงยงฤฆรยฎ ฬฤฆ ฬแบฤฆ ฬรฤฆยช ฬฤฆแบ ฬยชฤฆฬ - midnight
Signed-off-by TheKodeToad TheKodeToad@msn.com
(rรฆl email address)
@turbid hatch
building fltpaker
LMAO
you love
i will send this to my nixos user friend
why does bro have /games in his root folder
OHH right
lol
/usr/games the horror
@tame escarp january 7th
i was about to check if i have /usr/games but IM ON FUCKING WINDOWS
wsl:
january 6th would be a beautiful name for a young girl
kill
remind me to order NUC tmrw aagamer
guhh i wil try to rember
if you saw my taskbar you would die
lmfao
Forgot to run pnpm test after renaming the variable as well.
@austere talon
fastest pnpm i on windows
LMAO
LOL WHAT TERMS DID HE ADD
loveee vs build tools
at least shrimpkey supports mutes

gotobrazil doesnt
i wanted to mute a keyword but couldnt
i wanted to mute mutualaid cause there has been a huge influx of posts on my feed and they annoy me
(nothing against asking for help i just dont want those posts on my feed cause im not gonna give a stranger money)
oh my god starting vesktop dev just doesnt work this is such a windows moment
?
white shig screen
when using flatpak vesktop in steamos
i think its always done this but its still insane
can we default the splash to dark ons teamer since there IS NO LIGHT MODE ANYWAY
in the steam ui
wait i forgot we had flatpak why dont we just tell nixos users to use flatpak
3 year install time incoming
vee
cause they'd explode
uhhh
the ui only has dark mode
well seemingly they explode regardless
so while in steam ui we could just make the splash dark mode
or default to dark if that spossible
so might as well tell them to use a good package manager that's actually supported 
but i dont think it is
@turbid hatch works on flapker
does that not work on steamer?

it works for me iirc
seemingly only in the flatpak
i will check again
because gtk themes dont apply to flatpaks
it uses some insane portal gamescope probably doesnt implement is my guess
@Vendicated to confirm since we'd need the require hacks for settings as well, you'd prefer the first version over the second version below?
<img src="https://github.com/Vencord/Vesktop/assets/8976828/601b92d4-2bd0-4236-b9d1-7415183211b4" width="50%" /><img src="https://github.com/Vencord/Vesktop/assets/8976828/baaaeaa9-5cf5-4217-b9a7-4b197a1ebad2" width="50%" />
As I know, you can use GNOME Tweaks to solve this problem: sudo dnf install gnome-tweaks (or Tweaks in GNOME Software) and in the Appearance tab set Legacy Applications to Adwaita-dark. At least that's how I solved the problem.
riight
i had to do this to fix some issue with flatpakker
insanepak
anyway deck doesnt use gnome
so irrelavent
they use gamescope in game mode and plasma x11 in desktop mode
can u log electron.nativeTheme.shouldUseDarkColors in flatpakker
and see if it works correctly
I wanted to test the feat/usercss branch and
my theme (regular ass BetterDiscord format theme) isn't visible in the settings
but it's applied and works
it's funny
btw @turbid hatch reminder when you make a release once all of this is done to add the steamer stuff to flatpak
so you dont forgor
yop
check devtools for errors
@austere talon
native theme dark? false
console.log("native theme dark?", nativeTheme.shouldUseDarkColors);
baddd
yes
don't see anything out of the ordinary
no
nativeTheme.themeSource = "light" | "dark" | "system"
oh, there is an error when I open the page, nevermind
electron 28 seems to work no issues
yes
check what e is
i love pnpm upgrade --latest
yop
yes
that's why the error has garbage names bruh
but everything but the userscript comes with sourcemaps
actually even the userscript might have sourcemaps
try to turn on sourcemaps in devtools
if you show me where it is
How do you get a custom badge?
i can roughly reverse it enough in my head to map it back to the original typescript
lol
but just jump to the error location and show the code
like just show me the source of where the error is
okay yeah the userscript does not have sourcemaps
The Flatpak always detects light theme, but SteamOS only has a dark mode so we can just always use dark mode there.
To the 1 person using a light theme with decky: you are insane go explode.
they are enabled and I just checked, there's no sourcemap in the file
should check if this is an issue with flatpak in general or just steamerosser
@austere talon
how do yall get a custom badge?
idk but at least on steamos we have the simple fix
lol
if flatpakker issue we could make it do flatpak in genera
do yk how to get a badge?
cuz some people use light mode
donate 5$ or more
and this channel is for development, not asking questions, please use #๐ฅ-vencord-support-๐ฅ in the future
yeah but imo hardcoded dark mode > hardcoded light mode
i would assume the majority of our users uses dark
thats stripBom
yeah
let me double check
const themes = await VencordNative.themes.getThemesList();
const { fileName, content } of themes
**vencordDesktopRenderer.js.LEGAL.txt: **Lines 35-39
/*!
* virtual-merge
* Copyright (c) 2023 Vendicated
* SPDX-License-Identifier: MIT
*/
how do themes work on web?
bomb
wonder if this is something i've done by accident
stripBomb()
@austere talon how do natives work on web?




