BADGE API
#๐พ-core-development
austere talon
not api
turbid hatch
we could take this opportunity to stop using csv to make it easier to manage them :P
keep the csv file as a fallback but then new badges get done in a different way
then kill the csv when barely anyone is requesting it
livid heath
migrate to a db 
austere talon
we could take this opportunity to stop using csv to make it easier to manage the...
?
it doesnt get easier than csv
turbid hatch
csv's annoying to edit if you need to remove something automatically
i hate dealing with csv so much
austere talon
well youre not the one dealing with it
turbid hatch
well
yes
i'm expressing my opinion on csv
lol
reading and writing by tools has so many pitfalls
austere talon
dusk hill
u had a json file laying around u never told no one ๐ญ
austere talon
?
dusk hill
u wont be using the github one right?
livid heath
Pretty confident this is up to Vencord standard
mood
charred monolithBOT
limber skiff
review the pr that adds shit to ClientTheme
it's done
please wait, I was reviewing decor yesterday
austere talon
devtools crash is fixed btw
junior olive
Gm vencord dev 
tired orbit
HOW do i write a plugin 
tired orbit
lovely 
limber skiff
but you can prob learn more looking at other plugins
junior olive
but you can prob learn more looking at other plugins
yeah, the docs are kinda meh starting point it's easier to reference other plugins
limber skiff
๐ I did my first plugin looking at the docs
tired orbit
ok i give up
limber skiff
or should I say, my first patch
charred monolithBOT
umbral hedge
^ any opinions on which solution is best
junior olive
or should I say, my first patch
I did my first patch in a vc with ven months ago LMAO
tired orbit
i wanted to make something but need persistent storage
junior olive
did you want to make a persistent message logger
tired orbit
no
i wanted to make a thing where if you copy a link it prompts you for a title and it saves it permanently somewhere
limber skiff
i wanted to make something but need persistent storage
there are solutions to that
junior olive
oh ok well there's persistent storage
tired orbit
so you can copy memes all day and have them available
junior olive
That seems easy enough
limber skiff
@dapper crest I think I'm gonna reimplement the color picker to use a round button like this
junior olive
nookies abt to write this plugin in full for this person
limber skiff
I found out the color picker component we use runs the CustomColorPicker on click
tired orbit
oh noo please dont do that 
limber skiff
so I just need to make the parent wrapper which is the round button and on click handler
limber skiff
nookies abt to write this plugin in full for this person
nono I got more to do
umbral hedge
^ any opinions on which solution is best
i will just do the first solution if people don't really care lmao
limber skiff
oh I didnt see
@umbral hedge I think second is better
spotify utils is part of what? spotify controls?
limber skiff
ye but we have a wrapper around it too
ig just make a patch in spotify controls to fix that
it should be easy prob
umbral hedge
using speakers and stuff
austere talon
i would just make it not reject on 202
umbral hedge
ye
that's the 2nd solution i wrote in the issue
it's still really weird that they reject on 202
discord moment
junior olive
is it a intentional reject?
umbral hedge
ye
junior olive
weird
umbral hedge
the request works fine and the track skips
but discord has a specific check for 202
junior olive
yeah thats weird af
umbral hedge
yeah lmao
verbal pumice
cause that's how you normally use lodash?
junior olive
shrug, it's not really necessary but not really a issue either
just was curious why conform to that in a plugin
junior olive
yeah
turbid hatch
lodash style guide
charred monolithBOT
dapper crest
<@280411966126948353> I think I'm gonna reimplement the color picker to use a ro...
sounds good
I like the current color picker because it's identical to the one the original experiment used
umbral hedge
ez
charred monolithBOT
elder garnet
lewi how do i update to the newest commit lol, do i have to do it via the cli?
elder garnet
you cant escape strings in stylus?
this means?
turbid hatch
did you use gh cli
elder garnet
did you use gh cli
ye
turbid hatch
recheckout
elder garnet
oh okay
turbid hatch
this means?
just realised that im not actually handling strings properly
but
i cant handle them properly in stylus
umbral hedge
if this is a problem why don't we lint it out
elder garnet
i mean in practice
turbid hatch
if someone types a string like "this is lewi's testing string" then that's literally unparsable
by stylus
limber skiff
if this is a problem why don't we lint it out
why did you add it though
turbid hatch
because i have to escape one or the other to make it a string
limber skiff
it wasnt there, doesnt need to add
umbral hedge
eslint
turbid hatch
but you cant escape
umbral hedge
added it
turbid hatch
so essentially in stylus you can't have a string with both types of quotes in it
its just impossible
charred monolithBOT
turbid hatch
we really should have support for it though
i already support it for less by replacing all quotes with \"
elder garnet
maybe you could prioritise " over ' so if " " is around ' ' then you handle ' as a string
olive aurora
concat the strings
elder garnet
wait can you open a string with " and close it with '?
olive aurora
replace " with "+'"'+"
olive aurora
what
turbid hatch
in variable definitions it might
ahhh it does
hmmmmm
good to know
alright i can work with this
elder garnet
your fix works perfectly fine btw
turbid hatch
yip just fixing text
elder garnet
thank you :3
oh also, is it possible to have options that depend on the state of a checkbox, for example if you have Hide-Nitro enabled you can then show more checkboxes to hide something like the gift icon or the nitro button in dms
elder garnet
custom value 
turbid hatch
replace " with `"+'"'+"`
this sucks
me and my dad collectively discovered that stylus doesnt have escape sequences
(yes my dad got interested in me writing vencord code)
elder garnet
lol
umbral hedge
pog
austere talon
why does discord specifically reject on 202
@umbral hedge
umbral hedge
oh i replied but ig i forgot to send it or smth
they probably noticed sometimes requests return a 202, but it's not documented in the API docs for some reason, so they probably rejected it since it doesn't meet the api spec
when spotify.exe is running, it returns 204, but when using spotify connect instead, it returns 202
there's nothing actually wrong with a 202 response, it basically just says "We've forwarded the request to your device"
charred monolithBOT
junior olive
tbh I always thought lodash as _ is a little odd, following that even in a plugin seems silly to me but ultimately it's just preference and doesn't really matter
dapper crest
probably has its roots in being designed as helper methods for common problems, so the code you write using the library should be small, so having _. instead of lodash. is prefferable
why not just destructure in imports? /shrug
dapper crest
why not just destructure in imports? /shrug
Destructuring and Imports were added to JS in 2015
Lodash started in 2009
So it would've been a pain in the ass to extract every method you used from lodash it started, so they went for _ to be short?
junior olive
yeah
I mean I understand why lodash is how it is but we're 14 years down the line I don't think it has to be used like that anymore
dapper crest
because its convenient and there is no real downside
dapper crest
wtf f53 inconsistent code style?! /s
it's whoever who wrote those who are wrong, not me /s
woeful sable
where do i download vencord DEV build?
dapper crest
git switch dev
and if you don't understand that, you probably don't want the dev build
limber skiff
what happened
shy veldt
the canary one
limber skiff
I don't understand #๐ง-discord-changes
shy veldt
what happened
(webpackChunkdiscord_app.push([[''],{},e=>{m=[];for(let c in e.c)m.push(e.c[c])}]),m)
try it
it returns []
findByProps exploded
limber skiff
uh
junior olive
i just updated and my client seems oook
limber skiff
can you screenshot webpack runtime
junior olive
hmm
shy veldt
doesnt seem so
limber skiff
okay I ran
shy veldt
its just chunkid or something
limber skiff
yeah it's chunk id
shy veldt
according to the silly @mortal fractal
shy veldt
how nice of them (die?)
discord try not to break client mods for a year challenge (fail)
limber skiff
it's running on stable first
frail skyBOT
shy veldt
so true
limber skiff
well at least reporter seems to work
frail skyBOT
junior olive
my vencord is fine too so idk
shy veldt
nothing exploded
rare
limber skiff
we vibing
junior olive
some error from patchWebpack lolz
junior olive
shy veldt
how do you actually know they changed stuff <@1001086404203389018>
whar?
junior olive
fails to read the value of require.c[id]
limber skiff
odd
junior olive
wait
limber skiff
junior olive
shy veldt
https://discord.com/channels/1015060230222131221/1105582084237570088/11799329484...
script when it just r.u is not a function
limber skiff
it's not gone all finds worked
shy veldt
๐ข
junior olive
yeah i misinterpreted
junior olive
devtools took me to the wrong line
shy veldt
and not just findByProps
hollow
do I have like some shitty old ass vencord
what is the latest version
shy veldt
what is the latest version
(extension version)
limber skiff
lmao you are making me so confused
junior olive
sorry
shy veldt
it works but it doesn't (real?)
junior olive
(extension version)
1.6.4
limber skiff
script when it just r.u is not a function
wreq.u is still a function, reporter uses it
shy veldt
okay so yes i do have the latest
frail skyBOT
grave mangoBOT
this cutie exploded
https://github.com/Dziurwa14/discord-scraping/blob/main/src/...
**loadLazyLoadedChunks.ts: **
// @ts-nocheck
export default async function loadLazyLoadedChunks(): Promise<void> {
await (async (r) => {
for (let i = 0; i < 100000; i++) {
if (r.u(i)) {
try {
await r.e(id);
} catch (error) {
console.error(error);
}
}
}
})(webpackChunkdiscord_app.push([
[Symbol()], {},
e => e
]))
}
yeah no i just tried main branch on latest canary im all good
maybe its web specific issue????
limber skiff
**loadLazyLoadedChunks.ts: **
```ts
// @ts-nocheck
export default async functio...
silly
shy veldt
hollow
limber skiff
they dont return the value of the callback anymore
r is undefined
it's been like that since ages
shy veldt
it's been like that since ages
ages
it stopped working 1h ago
:wires:
limber skiff
so when you do e => e, . push doesnt return e
junior olive
i just tried vesktop its fine...wtf
limber skiff
>ages
>it stopped working 1h ago
>:wires:
vencord broke cuz of that like a month ago
when rspack I think i don't remember
junior olive
rsfold when
limber skiff
but if you look how we grab require we not longer depend on.push returning it
shy veldt
hopped on pc
junior olive
im just confused why dziurwas vencord webpack is fucked
limber skiff
**loadLazyLoadedChunks.ts: **
```ts
// @ts-nocheck
export default async functio...
fix it @shy veldt
junior olive
idk i dont do code
dziurwagpt
shy veldt
dziurwagpt
how code?
junior olive
no
limber skiff
**loadLazyLoadedChunks.ts: **
// @ts-nocheck
let r;
webpackChunkdiscord_app.push([
[Symbol()], {},
e => r = e
])
export default async function loadLazyLoadedChunks(): Promise<void> {
for (let i = 0; i < 100000; i++) {
if (r.u(i)) {
try {
await r.e(id);
} catch (error) {
console.error(error);
}
}
}
}
real...
shy veldt
**loadLazyLoadedChunks.ts: **
```ts
// @ts-nocheck
let r;
webpackChunkdiscord_a...
hopping on github mobilum rn.,,
limber skiff
indentation is kinda fucked up but whatever
frail skyBOT
limber skiff
lmao the normal reporter ran
limber skiff
(it fucking exploded)
what's the error
frail skyBOT
shy veldt
yeah ๐
limber skiff
**loadLazyLoadedChunks.ts: **
// @ts-nocheck
export default async function loadLazyLoadedChunks(): Promise<void> {
let r;
webpackChunkdiscord_app.push([
[Symbol()], {},
e => r = e
])
for (let i = 0; i < 100000; i++) {
if (r.u(i)) {
try {
await r.e(id);
} catch (error) {
console.error(error);
}
}
}
}
horrible indentation but fixed
limber skiff
yes
shy veldt
it did
limber skiff
you just have to fix indentation lol
junior olive
clienttheme is in dev right
shy veldt
I'm already on my way to diff it (fuck this im not doing it)
limber skiff
why?
junior olive
i was thinking clienttheme was in dev and that the light mode pr was wanted before dev -> main merge
shy veldt
I'm already on my way to diff it (fuck this im not doing it)
getScoreWithoutFetchingLatest -> getScore
getFrequentlyWithoutFetchingLatest -> getFrequently
limber skiff
ah
I was messing around with client theme today
but I haven't got a thing to work yet
junior olive
rip
limber skiff
I didnt try for long though since I had to go
limber skiff
I'm already on my way to diff it (fuck this im not doing it)
I'm surprised it was still working
shy veldt
whar
shy veldt
real
shy veldt
I'm already on my way to diff it (fuck this im not doing it)
i did anyway
nothing interesting
austere talon
they dont return the value of the callback anymore
wrong
they still do
it's just that in the early stage of webpackGlobal it gives some yeeyee ass fake webpack require
without cache
it's only added later
limber skiff
well dzi stuff just broke cuz of that
limber skiff
I see
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/webpack/webpack.ts#L77-L79
**webpack.ts: **Lines 77-79
instance.push([[Symbol("Vencord")], {}, r => wreq = r]);
instance.pop();
if (!wreq) return false;
when I was experimenting in how vencord grabbed the require I noticed that
austere talon
**webpack.ts: **Lines 77-79
```ts
instance.push([[Symbol("Vencord")], {}, r => w...
you just need to either load later when it's already initialised, or keep pushing until it works
limber skiff
it's cuz the first pushes happen when.push isnt patched yet
austere talon
cause for the first like 80 chunks or so, webpack.push isn't the proper webpack push yet
junior olive
it isnt
limber skiff
no lol
austere talon
it wouldn't be a big deal anyway
junior olive
i misinterpreted devtools error
limber skiff
it wouldn't be a big deal anyway
so true
junior olive
it took me to wrong line i was misinformed
austere talon
it wouldn't be a big deal anyway
i already have a hack for working around unexported webpack cache
shy veldt
i already have a hack for working around unexported webpack cache
i will hack you..,,
junior olive
huh?
mortal fractal
webpackRequire.c
mortal fractal
no
junior olive
huh??
mortal fractal
no its not
junior olive
guh???
mortal fractal
freshly loaded instance
junior olive
one moment ig
terse fractal
no its not
hi, do u maybe know that when ur using the vencord browser extension u can still add plugins from other mods?
or do u need to have vencord installed?
mortal fractal
vns
nimble pendantBOT
mortal fractal
then ven probably added the private cache extractor idk
limber skiff
then ven probably added the private cache extractor idk
it's not added
junior olive
canary
limber skiff
it's right there
mortal fractal
???????
limber skiff
canary, just updated
mortal fractal
did they revert it
junior olive
magicrequiresplosion
mortal fractal
tf is wrong with your clients wtf
mortal fractal
[default] [BUILD INFO] Release Channel: canary, Build Number: 250415, Version Hash: 1d24c75bf1c1c67cde5fbee4b506d79ef3ccc6f4
junior olive
Canary 250411 (0d3fa7c) Vencord 3e7d946Electron 22.3.26Chromium 108.0.5359.215Host 0.0.357 arm64 OS X 10.15.7 (23.1.0)
um...
limber skiff
[BUILD INFO] Release Channel: canary, Build Number: 250415, Version Hash: 1d24c75bf1c1c67cde5fbee4b506d79ef3ccc6f4
mortal fractal
it's right there
web.1478845241b4821128fa.js yes?
limber skiff
c is still there
junior olive
is the magic require not that magic.. 
limber skiff
huh
mortal fractal
WHY IS SENTRY OVERWRITING WEBPACKREQUIRE
mortal fractal
sentry.402450ae91f0dd03660c.js is overwriting webpackRequire
at least for sideloaded webpack modules
w/e im just not going to say shit here anymore
junior olive
w/e im just not going to say shit here anymore
why :(
limber skiff
what's the issue with you saying here
sage summit
I can't post in the third party plugins channel, which is very cool, so I have a quick question - I notice that hardly any plugins interact with the member list. Is this due to lack of interest, or is it impractical to do so, for example, to override member colors?
mortal fractal
what's the issue with you saying here
my own mental sanity and the fact i feel like i have stockholm syndrome or w/e
charred monolithBOT
charred monolithBOT
austere talon
sentry.402450ae91f0dd03660c.js is overwriting webpackRequire
ohhh did u accidently grab sentrys wreq
austere talon
that happened to my webpack grabber userscript, i accidently got react devtools webpack and was so confused
mortal fractal
shits so fucked its like 3 instances of webpack running at once that im surprised the normal app isnt beyond fucked
austere talon
discord moment
mortal fractal
im just
beyond fucking frustrated and burnt out
i dont want to have to fuck up the entire internals of hh just to get the fucking client to work
i should be in fucking bed by now but i want this to just not fucking be postponed
jagged cloak
shy veldt
discord at its finest
charred monolithBOT
there is no sound
Add "Capture application audio"
Set it to your app via Proprieties
Then set "Monitor audio and send it to the output" on Monitor audio
charred monolithBOT
charred monolithBOT
spark pivot
Why did they do it in the installer repo
dusky sonnet
Why did they do it in the installer repo
probably because its the closest thing to vencord in the vencord org
real zenith
using the exposed Vencord object in the browser console, how would I mute the user (as if they clicked on mute in the bottom-left)
er wait, I'd probably also have to check if the user is in a vc in the first place
although I could probably just listen to the join event for that, right?
real zenith
using the exposed Vencord object in the browser console, how would I mute the us...
yeah ig this still applies then
charred monolithBOT
charred monolithBOT
dusky sonnet
huh
verbal pumice
new channel just dropped
wispy elm
being able to pin plugins would be great
also those 2 buttons do the same thing in clienttheme plugin settings window, along with clicking outside of it
which is save and close
cancel button doesn't cancel lol
dapper crest
also those 2 buttons do the same thing in clienttheme plugin settings window, al...
Not sure if it's possible for me to fix this.
A core component of the thing is being able to see changes right as you make them
And I don't know how to integrate reversal of changes when cancel is pressed.
stark prairie
Not sure if it's possible for me to fix this.
A core component of the thing is b...
Delete user's account
dapper crest
being able to pin plugins would be great
ClientTheme will have it's own option in the vencord theme menu and the discord appearance menu eventually.
There is a lot being worked on so that will take a bit
wispy elm
Not sure if it's possible for me to fix this.
A core component of the thing is b...
what about saving the current theme color to then apply it with the cancel button
dapper crest
I don't know how to do anything with the buttons on the settings modal
limber skiff
ClientTheme will have it's own option in the vencord theme menu and the discord ...
about that I started working on it yesterday but couldnt do much cuz I didnt have much time, and today I'm kinda busy too
dapper crest
about that I started working on it yesterday but couldnt do much cuz I didnt hav...
Can we just merge the light mode support and theme menu button in the mean time?
limber skiff
Can we just merge the light mode support and theme menu button in the mean time?
I wanna pr the appearence button and then review later
to be fair it's no biggie for light mode support to wait a little lol
dapper crest
to be fair it's no biggie for light mode support to wait a little lol
The button in the theme tab is kind of a biggie imo.
limber skiff
not really, if someone enabled client theme they already know where to find the color picker
and they prob wont change the colors so much
it doesnt have to be added in a hurry
dapper crest
True
elder garnet
startospeech
turbid hatch
@limber skiff just to check did u see that i asked for ur review
limber skiff
I didnt lol
turbid hatch
oh lol
turbid hatch
yeah if u can pls review my insanity
limber skiff
yeye as soon as I can, since I will be busy with client theme until I can get the thing I wanna do to work and review
turbid hatch
dwdw
rough gazelle
what a simp
verbal pumice
is this what schizophrenia feels like
shy veldt
yea
serene elm
hi
lime stone
horrific
junior olive
@limber skiff you think maybe main merge today? wondering if i should hold off on releasing winter decors
limber skiff
it's not in my control
junior olive
oh ok wasn't sure if you did those sometimes
limber skiff
main branch is protected and you can only merge if it passes tests
but for that it requires you to pr
only ven can push without pr
limber skiff
unless I can?
because now the dev branch is tested
@austere talon can I try to git push origin dev:main?
limber skiff
but for that it requires you to pr
and then the reason I dont do it is cuz I dont want all the commits to turn into one
junior olive
yeh
junior olive
<@343383572805058560> can I try to `git push origin dev:main`?
wouldnt that push main to dev
limber skiff
right
lime stone
huh
junior olive
limber skiff
wrong order ๐
lime stone
isn't that the dev origin and the main branch
junior olive
yeah i dont think thats correct at all lmaoo
limber skiff
I fixed the order
austere talon
<@343383572805058560> can I try to `git push origin dev:main`?
is that actually a thing
limber skiff
huh
junior olive
nookies.. merge
limber skiff
doesnt push work
austere talon
stop pressuring people so much fiery
junior olive
i doubt
junior olive
stop pressuring people so much fiery
i didnt mean like literally merge
i meant git merge not git push
limber skiff
doesnt push work
to be fair I havent tried in so long I dont know lmao
junior olive
no merge may
austere talon
<@343383572805058560> can I try to `git push origin dev:main`?
im 99% sure this command doesn't work
when you specify two args to push the first one is the remote (origin) and the second the branch
limber skiff
how do you push dev commmts to main?
junior olive
im 99% sure this command doesn't work
yea exactly i was trying to point out it's git merge not git push 
limber skiff
okay I fixed the command now
olive aurora
no merge 2024
junior olive
oh maybe that works
austere talon
how do you push dev commmts to main?
git checkout main
git reset --hard dev (or git merge dev but it makes merge commit)
git push
limber skiff
oh lmao
austere talon
anyway ill merge later
junior olive
I wasn't trying to pressure, i was just wondering. I'm sorry if it came off that way?
limber skiff
it does work
limber skiff
anyway ill merge later
it's just cuz I want to see if I can push to main
because before I couldnt since it required tests to pass
limber skiff
it does work
I knew i wasnt tripping @junior olive ๐
junior olive
I knew i wasnt tripping <@890228870559698955> ๐
yeah that command makes more sense
git push dev main on the otherhand
limber skiff
yeah I had wrote it wrong
junior olive
limber skiff
charred monolithBOT
junior olive
can u find a webpack module's code by its props out of curiosity
limber skiff
no
junior olive
thought so rip
austere talon
you can
mortal fractal
im going to assume theres been 0 issues with ReactCurrentDispatcher disappearing halfway through a render on vencord
somber lintel
so im relatively new to vencord as one would be probably able to guess, im trying to patch the updateVideoQuality function in discord, any tips? its very different from betterdiscord as we all know
charred monolithBOT
spark pivot
the
gleaming trellis
and itโs deleted
limber skiff
bro look at this match @junior olive
let a = /(\.trackEmojiSearchEmpty,200(?=.+?isBurstReaction:(\i).+?(\i===\i\.EmojiIntention.REACTION)).+?\[\2,\i\]=\i\.useState\()!1\)/;
junior olive
bro look at this match <@890228870559698955>
```ts
let a = /(\.trackEmojiSearch...
i cant tell if good or bad
ah r u fixing that
limber skiff
made a bit more generic
junior olive
that one wasnt mine iirc
limber skiff
I mean I made the new patch more generic
limber skiff
I modified this one with force push
junior olive
I mean I made the new patch more generic
Yeah
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
turbid hatch
OKAY YOU DONT HAVE TO YELL
charred monolithBOT
turbid hatch
@topaz thistle i might need your help in a bit
turbid hatch
i'm trying to package vesktop for flatpak so i need to know if there's anything special i need for venmic to work
topaz thistle
<@349609234985517057> i might need your help in a bit
Sure
turbid hatch
i've already added the pipewire run dir as a permission for flatpak but am unsure if any other perms need to be granted or any flags need to be passed to electron
topaz thistle
we also need pulseaudio perms
topaz thistle
With that as as base and pipewire perms added it should work fine ^^
turbid hatch
alrighty
austere talon
you can also just implement it in vencord with the flag
austere talon
yes
charred monolithBOT
turbid hatch
why fork to ur personal acc
because im the maintainer
of the flatpak
it's how they do things
like how we have shiggybot fork winget-pkgs to itself because its submitting it
(it forking to vencord org was actually a mistake in the end so)
austere talon
ojfajposikfjpikoawipjofwqajio
you love
honestly i have no clue why it pastes as grafik ahahahha
my github is in english
i have my firefox in germna
maybe thats why
real zenith
why from the console
too lazy to recompile vencord
crap
didn't mean to ping
my bad
austere talon
blud leaving the update window open for hours
someone try https://github.com/Vencord/Vesktop/pull/248
charred monolithBOT
austere talon
yea but it shouldnt
austere talon
uh are u sure? <@96269247411400704>
cause
turbid hatch
in fact the main app starts maximised!
ahahaha
worked it out
if the app was maximised when you quit it, it will restart maximised regardless
let me edit my comment
charred monolithBOT
austere talon
```typescript
mainWin!.maximize();
mainWin!.hide();
```
oh ic
turbid hatch
if you dont do it then when you restart the app it wont be maximised
turbid hatch
weird side effect of electron i suppose, but it makes sense
you cant maximise a nonexistent window
austere talon
it doesnt support pnpm
austere talon
error This project's package.json defines "packageManager": "yarn@pnpm@8.11.0". However the current global version of Yarn is 1.22.21.
LOL?? no it doesnt lmao
austere talon
how do we fix it 
turbid hatch
rerun!
austere talon
i dont think that will work ๐ญ
turbid hatch
no it's an issue with the new yarn release
lol
the action uses the latest version of yarn
austere talon
we could just stop using the action
austere talon
https://github.com/samuelmeuli/action-electron-builder/blob/master/index.js
like this is really just
pnpm install
pnpm build
pnpm electron-builder --linux --publish always
if u read it
yeah literally
turbid hatch
alright
austere talon
i'll just move away from it
turbid hatch
let me rewrite it
charred monolithBOT
austere talon
oh i can do it rq
austere talon
nop
me
- name: Run Electron Builder
run: |
case "${{ matrix.os }}" in
macos-latest) platform=mac ;;
ubuntu-latest) platform=linux ;;
windows-latest) platform=windows ;;
esac
pnpm install
pnpm build
pnpm electron-builder --$platform --publish always
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
should work i think?
turbid hatch
GH_TOKEN
austere talon
wdym
turbid hatch
env should be GH_TOKEN
austere talon
oh right
turbid hatch
GITHUB_TOKEN was a thing that only the action did
austere talon
no pnpm
austere talon
I FORGOT
turbid hatch
yeah
turbid hatch
idk what ur smoking
austere talon
strategy:
matrix:
os: [macos-latest, ubuntu-latest, windows-latest]
include:
- os: macos-latest
platform: mac
- os: ubuntu-latest
platform: linux
- os: windows-latest
platform: windows
yeah that might work
though out of curiosity
do we actually need to run it like this
charred monolithBOT
turbid hatch
electron builder supports cross compilation does it not
Donโt expect that you can build app for all platforms on one platform.
oh nevermind
lime stone
oh god
lime stone
i still have ptsd from trying to use electron builder in gitlab CI
charred monolithBOT
swift fjord
kitkat
charred monolithBOT
woeful sable
DoubleClickRename plugin?
lime stone
have you made it?
woeful sable
no haha it's a concept
woeful sable
i think it could be useful if you only want to rename the channel, especially when you have multiple ones to rename
austere talon
kinda useless just right click > edit
woeful sable
going through the channel settings page then leaving it everytime is pain a bit
it's just a suggestion though, i think it could help going faster
and since double clicking a channel doesn't do anything currently, i find it being a good opportunity
austere talon
this doesnt belong here anyway
woeful sable
ah my bad, the suggestion channel is closed so i sent it here to talk to devs and get their opinion
austere talon
ah my bad, the suggestion channel is closed so i sent it here to talk to devs an...
the suggestions are closed for a reason and not an invitation to abuse dev channels
girl what... @nimble plaza
nimble plaza
it was the same issue as a while ago when native plugins were introduced
it got mad if nothing was exported
woeful sable
the suggestions are closed for a reason and not an invitation to abuse dev chann...
so we can't share ideas at all?
austere talon
correct
nimble plaza
simple fix, export default () => {}
austere talon
ohhh
nimble plaza
it exports something when theres no export calls
so u need to do it urself with a function
i dmed u the broken plugin a while back
austere talon
this has no exports
but it does have imports
does your file that's broken have impoorts?
austere talon
send the file contents
nimble plaza
austere talon
terrible file
)
austere talon
AHAHHAHAH i downloaded and opened and it tried to open as a video
austere talon
ayy flatpak works on steamos @turbid hatch
turbid hatch
๐
charred monolithBOT
charred monolithBOT
charred monolithBOT
analog knoll
https://github.com/Vencord/Vesktop/pull/248#discussion_r1412835063
Could you explain the though behind the
mainWin!.maximize();
mainWin!.hide();
part instead of simply checking if it should or shouldn't start minimized before maximizing
austere talon
because if you just skip it, it won't be maximised once you do launch it
charred monolithBOT
turbid hatch
@austere talon my friend has had a deranged idea where if we do the konami code on the website it shows men kissing
should i implement
austere talon
horrorrro
turbid hatch
"that's a yes" - dy
frail skyBOT
frail skyBOT
limber skiff
WANST ME I THINK VEN]
austere talon
WANST ME I THINK VEN]
you will move back
charred monolithBOT
Adds a 4th option that allows you to manually input the resolution, framerate and bitrate of the stream.
austere talon
raw requires by id
fear
don't require by id they're not stable and will change at any time
always use findByProps or equivalent
and it would likely help readability to move most things to the top level instead of having it all be members of ur plugin
@brave minnow
this is kinda like that other pr but more sane (not 200 files)
limber skiff
๐ ๐ ๐ ๐
that's actually reviewable
you can make all of this a single findBulk
look at how permissions viewer does it
austere talon
the first one is just webpack commons moment
limber skiff
you are right
austere talon
that's actually reviewable
the code is kinda insane but nothing that can't be fixed
limber skiff
yeah, but thankfully it's not 200 files
gleaming trellis
Are we finally getting semi stable class names for themes
limber skiff
no
gleaming trellis
more CPU intensive and there are some duplicate names out there
the theme I want to use makes the UI unbearably laggy cause of all the advanced selectors (and my computer isnโt that weak)
charred monolithBOT
brave minnow
tysm for the tips, i tidied things up n did what u guys said, had some issues with findBulk with some modules (guessing it's cause they load rlly late compared to the other ones? dunno) but it should be a bit better now,,.,
torn knot
should I report this as a bug or is it a wontfix?
austere talon
wontfix
arrpc needs to impl it
and likely won't
get arrpc to add support then it's no longer a wontfix
torn knot
I see
good to know
though I don't think that:
a) I'll be the first one reporting this and
b) My report will have much of an impact
But I'll give it a try later
verbal pumice
while most of these are valid theyre just nits that have no reason to be brought up
right ryan isnt here
well whatever
junior olive
They left?
verbal pumice
they got banned
junior olive
LMAO why
cunning canyon
๐
verbal pumice
having no idea what theyre talking about and giving bad advice, and just generally being a dick
verbal pumice
having no idea what theyre talking about and giving bad advice, and just general...
which now that i think about it, also applies to these reviews
austere talon
kinda mini arjix
just kinda too direct and thus rude
and insisting on certain points
turbid hatch
is this a linux thing? i think this is a linux thing