ill add that back
#👾-core-development
junior olive
limber skiff
but you don't really need to take all my advices
junior olive
(?<==)\i=>{let{children.{20,100}decorationGridItem
junior olive
ok decor now uses the new find, grouped patches, and has improved patches now
austere talon
we love backtracking
junior olive
i can probably do some destructuring that you implemented
lemme take a look
this totally could couldn't it
actually no it can't bc of the tostring thing
but i should move that to use the byCode filter
austere talon
this totally could couldn't it
yep
junior olive
@austere talon you love
const persistFilter = filters.byCode("zustand");
export const { persist }: typeof import("zustand/middleware") = findLazy(m => m.persist && persistFilter(m.persist));
is the destructuring nested
i assume i cant destructure this mf
junior olive
yea
no point switching it at all then tbh
HOWEVER
i can update that find i think
austere talon
yes you can just use findByCode
junior olive
no i can't
austere talon
you can
junior olive
unless it changed
austere talon
findComponentByCode I mean
livid heath
there's this annoying ass bug where my states just reset upon switching channels
i've tried getting the previous value and what not it just doesn't work
junior olive
hello typings my old friend
this is fine right
wait could i destructure the type.. no right
i don't think i can
austere talon
can
junior olive
i love how the fucking avatar decoration plugin is pushing the boundaries of the current vencord apis
austere talon
they're pretty different in how they function
junior olive
i think findComponentByCodeLazy doesn't work in this case
i need to use this w/o using lazycomponent
easy enough
it was not easy enough
NoopComponent fucks it up
i should just leave this as the proxylazy tbh
findLazy*
ah ok so this fucks up this whole file
im just gonna leave this one untouched
livid heath
@lime stone do i put the reply ping before everyone or after
livid heath
shouldn't it be right-aligned?
since all the options are at the left wouldn't having it at the left be better for UX?
lime stone
wait, this is editing?
livid heath
yes
livid heath
eh this looks good enough to me
lime stone
you can't really change pings after an edit though, so what's the point
livid heath
you can't really change pings after an edit though, so what's the point
you definitely can
lime maple
Hi, so I am currently using BetterDiscord, but considering swapping to Vencord since it supports TypeScript and their TOS isn't wack. 😂
Is there any API documentation? I went looking, but didn't find any.
livid heath
@lime stone :)
lime stone
why doesn't the ping toggle appear without a <@!>
also you can't really
it won't do anything
livid heath
why doesn't the ping toggle appear without a <@!>
i forgot to add a condition to render the bar if there are no mentions but it is a reply edit
lime stone
it won't actually notify the user when you edit with a ping
so i can't see a use-case
livid heath
it wont notify them, but the highlight is toggled
an option is better than no option imo
verbal pumice
Hi, so I am currently using BetterDiscord, but considering swapping to Vencord s...
not atm
best we have is https://github.com/Vendicated/Vencord/blob/main/CONTRIBUTING.md and looking through how other plugins use stuff
livid heath
it's bloat!
sounds like a valid reason
although in that case i prefer making another option to enable this feature
pine topaz
are we waiting on anything for my svg
long stream
limber skiff
NoopComponent fucks it up
why does it
austere talon
are we waiting on anything for my svg
yes we're waiting for you to shut up
stop asking so much
limber skiff
@austere talon I was thinking of doing something to make webpack common components Noop for default to avoid react crashes, what do you think?
limber skiff
kinda like I default to it here
austere talon
kinda like I default to it here
im not sure i like that
errorboundaries solve it too
dapper crest
is this
import lightStyleFixes from "./lightModeFixes.css?managed";
...
start() {
enableStyle(lightStyleFixes);
...
},
stop() {
disableStyle(lightStyleFixes);
...
}
what Ven meant by "make your css managed"
austere talon
yes
css you import is always active even if your plugin isn't enabled
if you make changes that affect discord itself you need to make it managed
just like that
dapper crest
thanks
dapper crest
LightClientTheme is ready for review again
honestly I really like light theme like this
oak hull
lightreader
dapper crest
charred monolithBOT
dapper crest
will do
...
Edit QuickCSS
</Button>
{Vencord.PlainSettings.plugins.ClientTheme.enabled && (
<Button
onClick={() => openModalLazy(async () => modalProps => {
return <PluginModal {...modalProps} plugin={Vencord.Plugins.plugins.ClientTheme} onRestartNeeded={() => { }} />;
})}
size={Button.Sizes.SMALL}
>
Edit ClientTheme
</Button>
)}
is there anything absolutely wrong about the way I implemented this?
limber skiff
you can use Vencord.Settings instead of PlainSettings
dapper crest
limber skiff
yeah that looks better
also check the props for button component, I think you can make Reset Theme Color be red
junior olive
you should make the red text stand out more somehow
olive aurora
hexToLightness
contrast is a diff function since hsl isnt normalised: ```ts
function relLuminance(colour: number) {
const [r, g, b] = unpackRgb(colour)
.map((x) => x <= 0.03928 ? x / 12.92 : ((x + 0.055) / 1.055) ** 2.4);
return r * 0.2126 + g * 0.7152 + b * 0.0722;
};
tbh it may not i need to re-test
limber skiff
tbh it may not i need to re-test
well I might remove it
cuz ven prefers to use ErrorBoundary instead
olive aurora
junior olive
The code i'm running these finds through does not like proxies so
i'll give it another try i guess
it works
but it's kinda like if it ain't broke don't fix it?
limber skiff
why wouldnt the second work though
dapper crest
you should make the red text stand out more somehow
@limber skiff what are your thoughts on just making the error section use the default discord background color to ensure it always has good contrast?
The problem with the current system is that having a variable background color screws with our ability to pick something that contrasts well
junior olive
why wouldnt the second work though
it does work, i thought it was causing issues but it was the other bit of code in that
i added destructuring this at the same time and confused the two
limber skiff
<@235834946571337729> what are your thoughts on just making the error section u...
if it doesnt look bad sure lol
limber skiff
it does work, i thought it was causing issues but it was the other bit of code i...
ah
junior olive
but still i'm not sure if there's a point to switching to this new find in this case
austere talon
not really other than it being more compact
austere talon
cuz it wraps with LazyComponent
yeah but he only searches it to extract some module ids lmao
doesn't even use
junior olive
yeah
limber skiff
oh lmao that's right
dapper crest
if it doesnt look bad sure lol
limber skiff
arent you using the stickerpickerpreview component?
junior olive
not as a component
limber skiff
damn that doesnt look good lol
limber skiff
okay it doesnt matter then
dapper crest
damn that doesnt look good lol
I'm keeping it like that until we find a better solution, looks better than an warning for poor text contrast with poor contrast itself
limber skiff
I'm keeping it like that until we find a better solution, looks better than an w...
kk
limber skiff
I'm keeping it like that until we find a better solution, looks better than an w...
actually do the opposite theme background color
so white in that case
maybe that will look better
I'm thinking of how to adding the color picker here
olive aurora
//@ts-explode
limber skiff
maybe a section like the "Color" one under the theme picker?
limber skiff
maybe we can even add it to Preview themes?
junior olive
users are stupid
limber skiff
🤔
small flare
the eol eslint setting seems to be fucked in the vesktop source?
i would attach an image but its literally just an error at the end of every line
dapper crest
actually do the opposite theme background color
junior olive
looks fine
dapper crest
what
olive aurora
>`hexToLightness`
contrast is a diff function since hsl isnt normalised: ```ts
f...
this
wait im dumb
dapper crest
>`hexToLightness`
contrast is a diff function since hsl isnt normalised: ```ts
f...
ohh
dapper crest
if you want to find good values for all the warnings using that function then go ahead and review it in
current system of looking at luminance works fine enough and I don't understand relLuminance well enough to get it implemented proper myself
inland fable
<@235834946571337729> what are your thoughts on just making the error section u...
maybe transparent dark bg to make it always fit the theme while letting the text be readable, idk
maybe (i dont know anything abt design
junior olive
99 commits
fear.
dapper crest
maybe transparent dark bg to make it always fit the theme while letting the text...
I am happy with how I have it looking currently
olive aurora
try this (just git apply mrw.diff)
also maybe good to let contrastWarning = false bc typescript is crying
inland fable
how do you make diff files
olive aurora
git diff
austere talon
the eol eslint setting seems to be fucked in the vesktop source?
no.
issue on your end
austere talon
I'm thinking of how to adding the color picker here
Button on the right of the sync button
limber skiff
I can prob style the picker to be round lol
dapper crest
@olive aurora
Here is that diff with better values for warnings
You can add this to my pr, I wouldn't want to take credit
olive aurora
<@1079479184478441643>
Here is that diff with better values for warnings
You ca...
you can just add it no problem
id have to open a PR
if you really want you can commit it with Co-authored-by: rini <rini@rinici.de> at the last line
wary void
moving from #🏥-vencord-support-🏥; does electron not have any way to use WMI apis? vesktop starting wmic every 4 seconds to get all programs just looks silly and sus https://i.imgur.com/aLSyxzY.png
charred monolithBOT
lunar gull
Quick Question, will Vencord Support @var like BetterDiscord is planning on implementing?
pine topaz
probably
vencord supports pretty much everything else BD does theme-wise, wouldnt make sense to suddenly not
lunar gull
Ok cool, thanks
charred monolithBOT
wary void
moving from <#1026515880080842772>; does electron not have any way to use WMI ap...
a real issue I have with it is that this is spamming my Process Hacker logs while I'm figuring out some other issue
dapper crest
What would be better words for "Swap Theme" here that would better imply the switch from light to dark/vise versa
crude raptor
depending on current theme, change the wording
if you're in light theme: "Change To Dark Theme"
if you're in dark theme: "Change To Light Theme"
also how does it handle the nitro themes
dapper crest
Nitro themes are just skins on top of dark/light mode
crude raptor
yeah i just checked i guess they're called "colours"
dapper crest
I will add an error when there is an active nitro theme
limber skiff
meh don't
charred monolithBOT
turbid hatch
moving from <#1026515880080842772>; does electron not have any way to use WMI ap...
WMI uses COM
limber skiff
you said it yourself there are people that use kt without gradients
wary void
WMI uses COM
is that an answer?
wary void
the entire world is aware
turbid hatch
we'd have to write a bunch of VC++ or what have you
wary void
COM is the worst thing ever created
wary void
.NET has simple apis for WMI where they deal with COM shit and you just write an sql query
dapper crest
you said it yourself there are people that use kt without gradients
its just a warning, won't stop the people who use both
turbid hatch
@topaz thistle have you worked with COM on windows before
limber skiff
its just a warning, won't stop the people who use both
aight
dapper crest
this whole time I have been trying to find a store that would give me the info I need but I don't know how and have been guessing ever since I saw fakenitro didn't have my answer
turbid hatch
actually you could probably do it in plain C++ compiled with MSVC
but it's still nightmarish
wary void
you can't use .NET to write a native module
I don't think you need to write a native module or something. just make that .net program send stuff with IPC to Vesktop every 4 seconds, run the program once
turbid hatch
bad
wary void
but better
turbid hatch
then we have to run a background process
dapper crest
this whole time I have been trying to find a store that would give me the info I...
wait
findStore("UserSettingsProtoStore").settings.appearance
limber skiff
this whole time I have been trying to find a store that would give me the info I...
what info
turbid hatch
we might as well just make it a native
limber skiff
oh
I will have to check when I'm home
but I'm almost sure there is a proper place to know it without accessing the proto
maybe something with Gradient
dapper crest
const nitroThemeEnabled = findStore("UserSettingsProtoStore").settings.appearance.clientThemeSettings.backgroundGradientPresetId !== undefined
so not this
limber skiff
search for appearance.clientThemeSettings on the devtools
see where it's used
to maybe find the store for it
dapper crest
which part of the devtools?
limber skiff
only those?
dapper crest
yup
limber skiff
maybe search for backgroundGradientPresetId instead
that's gonna get you a lot of results though
limber skiff
I'll help you when I get home if you still need
I will just reverse engineer the selector for gradient themes to see what it uses
frail sky
dapper crest
I will just reverse engineer the selector for gradient themes to see what it use...
That took me far too long
const NitroThemeStore = findStoreLazy("ClientThemesBackgroundStore");
function ThemeSettings() {
...
const nitroTheme = useStateFromStores([NitroThemeStore], () => NitroThemeStore.gradientPreset);
const nitroThemeEnabled = nitroTheme !== undefined;
Minified react is hell
dire thicket
imagine hideattachments but for things that aren't attachments
some moments i could really do with that
inland fable
elaborate
dire thicket
like
it hides the content of the message just like how hideattachments does it
but for the text content
dire thicket
probs easily possible by slightly modifying hideattachments
dire thicket
whole message or only content
just the content, so the name and avatar are still there and such
there are some messages i just don't want to see
and this envisioned plugin could solve that
dapper crest
who's new find?
austere talon
also this error sucks @limber skiff
austere talon
who's new find?
who is new find? idk you tell me
dapper crest
I don't grammar with apostrophes well
dapper crest
not intuitive to me
austere talon
also this error sucks <@235834946571337729>
there made it better
for some reason that find fails the first time you open a profile, but works the second time
seems like a race condition with lazy loaded code
dapper crest
I was thinking of it as
ven's = property/owned by ven
who's new find = who owns that find
charred monolithBOT
limber skiff
That took me far too long
```js
const NitroThemeStore = findStoreLazy("ClientThe...
👏 👏 👏
limber skiff
for some reason that find fails the first time you open a profile, but works the...
changing the find fixed it?
limber skiff
oh that's what handleModuleNotFound is for lol
limber skiff
lol
I wish we could do something like null | undefined | any for find returns
that way people are forced to ?. or something when using them
austere talon
horror
austere talon
i made consoleshortcuts put all webpack commons on the window
limber skiff
to avoid errors like "trying to access property banana of undefined"
limber skiff
pog
inland fable
omg this is a thing
vendetta has a plugin for that too i think
didn't notice vencord does too
charred monolithBOT
limber skiff
@austere talon what is there to remove from webpack? like the outdated stuff
mapMangled...?
austere talon
kinda still needed i think
well actually
let me see
i think no xd
rewriting everything that uses it rn
lol this is broken and noone noticed
noone uses that
i just removed it
limber skiff
lmao
austere talon
that module doesnt even have openUntrustedLink anymore
wait
the permission viewer context menu doesnt show
oh its in a diff place
ok seems to all be working
i killed mapMangledModule
limber skiff
😭 it deserved more
austere talon
next we should remove nested webpack search
charred monolithBOT
austere talon
grave mangoBOT
https://github.com/Vencord/Vesktop/blob/49e0411be6a75472a0b08064daff501279dc37d3...
**spellCheck.tsx: **Line 78
ContextMenu.close();
guhh have to update this now (cause it's now ContextMenuApi.closeContextMenu)
limber skiff
😛
austere talon
guhh have to update this now (cause it's now ContextMenuApi.closeContextMenu)
i mean its not a big deal
its just slightly bad UX
but doesnt cause any actual issues
okay lets just see how bad it breaks if i just remove nested search
wait it all just works
yeah all works
but im scared theres smth i dont catch rn but causes issues later xd
way faster than before
spark pivot
I wonder if that’s the actual accuracy or floating point precision errors
Probably the latter
Cause javascript
austere talon
?
spark pivot
Notice how there’s like 10 digits of decimals
limber skiff
but im scared theres smth i dont catch rn but causes issues later xd
me yesterday:
charred monolithBOT
austere talon
i just removed it with no changes
and everything seems to work
but please test for me as well
i turned on all plugins
and it all seems to work
omg this is horror
WHY IS EVERYONE IDLE
STOP BEING IDLE
@limber skiff you will finish your reporter change that tests webpack finds
WE NEED IT RN
austere talon
horror what are u doing
limber skiff
I wanna understand it
austere talon
its pretty simple
limber skiff
i just removed it with no changes
no way it didnt break anything
austere talon
i can explain it to you if you want
limber skiff
sure
austere talon
actually what exactly are you trying to understand
limber skiff
actually no need to
I'm almost finished reading the file
I'll tell if you if I have questions
love this though
austere talon
should test if that still is needed
legit when i wrote the code it kept crashing with cryptic errors and that try catch fixed it
HOW DOES THAT CODE FAIL
charred monolithBOT
austere talon
doesnt happen anymore
limber skiff
I noticed something
austere talon
we can probably remove it
austere talon
I noticed something
what
austere talon
we can probably remove the if statement cause it works even for arrows
limber skiff
neat
austere talon
yweah works
inland fable
what's the 0, for
limber skiff
is this what makes the patched code searcheable on the sources
austere talon
no but it gives them a good name
these names
otherwise they would be called VM23604 lol
inland fable
hi vee question
limber skiff
these names
oh
austere talon
actually yeah it doesnt seem to search unnamed files
limber skiff
how does this not make it appear on the search though
inland fable
i could find this out from the source code so sorry for asking; those modules you provide in the vencord api do you find them or do you like retrieve them the moment they're added to the webpack chunk
limber skiff
i could find this out from the source code so sorry for asking; those modules yo...
most stuff in Common is retrieved the moment they are added
austere talon
limber skiff
but most ones specific to plugins are searched on first use
limber skiff
I get it now
austere talon
did you test dev
limber skiff
nop
I'm still in debugger lol
wait why are we doing this in the patcher
we should do it when we change all replacements to array
austere talon
eh
why
thats more work
doing it there makes it so that its only done on demand
not for all of them
limber skiff
wait werent we meant to remove this lmao
austere talon
i removed it latest commit
charred monolithBOT
austere talon
oh i didnt poush
limber skiff
oh
austere talon
how far from done is ur webpack find tester
limber skiff
💀 I didnt start lmao
austere talon
horror
limber skiff
should we just merge into main now
ig we could
austere talon
i wanna test all finds first
to make sure none broke
i tested surface level and its all oki
but just to make sure
god this is such a large refactor
im worried many things will break somehow xd
limber skiff
are we sure no mod exports an object we need to search the props outside of .default?
cuz wouldnt that make byProps filter not work for them
austere talon
wdym
there shouldnt be any such case
cause you'd just findByProps that export name
limber skiff
right
austere talon
we already had to fix all filters that were now changed to named exports during rspack update (so basically all filters that relied on nested search)
cause the length check made all of them fail
anyway we should just finish the find tester
it should not be hard tbh
just monkey patch all webpack find methods to push into some array
then once all chunks are loaded force run all of them
limber skiff
anyway we should just finish the find tester
should we do it before merge to main
cuz like a lot of stuff is broken in main it needs an update soon
limber skiff
wtf
if exports is t.exports, why do we have to set exports to module.exports, it's literally it already?
damn nice zoom discord
there are 3 images btw
limber skiff
okay I understand how it works (webpack patching, not the curse above)
junior olive
webpack patching is a thing of all time
charred monolithBOT
This is especially annoying because the Loading Vesktop... popup is always on top and both the popup and tray is not interactable until you press Ok on the error message.
limber skiff
lmao we are logging traces for non successfull finds
austere talon
yes
limber skiff
is that intentional
I was so confused how those finds were running before patching webpack
it's because waitFor executes them
austere talon
trace is unaware of how the function added
anyway
dont change webpack rn
im changing it
limber skiff
kk
limber skiff
o
austere talon
then we can just access an prop on all of them from tester to force run them
then check if there are errors
limber skiff
WHY IS THIS A THING
austere talon
hmmm but how to do it for components
limber skiff
javascript is insane
austere talon
WHY IS THIS A THING
LOL what
austere talon
hmmm but how to do it for components
how to trigger lazycomponents
austere talon
how to trigger lazycomponents
any idea?
limber skiff
how to trigger lazycomponents
I think you should add the factories to the array
so you can just run them
austere talon
hmm true
tame escarp
@austere talon i run the dev branch and just updated to your DISGUSTING webpack refactor and it.blew up my computer. i will be contacting your lawyers "vendicated" (if tnat is even your real name)
limber skiff
limber skiff
rini is watching
tame escarp
rini is always watching day and night
olive aurora
the only case it inlines funcs is x => x (and sometimes just doesnt because fuck you)
austere talon
so bad
olive aurora
hop on terser when
olive aurora
oh
it only works with function x()
declarations
esbuild so dumb
@austere talon
austere talon
@limber skiff
austere talon
its kinda meh that we don't have a way to know where the find came from
unless we use stacktrace?
olive aurora
vencord logs your search history..
limber skiff
its kinda meh that we don't have a way to know where the find came from
yeah...
olive aurora
babel macros when
austere talon
unless we use stacktrace?
meant to reply to this
olive aurora
you will Error().stack
limber skiff
yeah
livid heath
stolen
livid heath
@mortal fractal said something about the client jpegging them
livid heath
charred monolithBOT
limber skiff
we should test non lazy finds too
austere talon
well yeah but they'll already error
limber skiff
oh right
austere talon
and tbh i dont think we have amny
austere talon
truee
charred monolithBOT
limber skiff
cuz 1 plugin uses it
austere talon
i think it didnt work
austere talon
why doesnt it give u console log output
limber skiff
does it look like this for you
austere talon
yes
Got unexpected error %c[LoginQRSocket]
font-weight: bold;
color: purple;
Could not complete QR code login, trying to restart with a new QR code.
its stuck on login??
limber skiff
let me run it locally
limber skiff
wha
austere talon
and some of these are lazy loaded
austere talon
and some of these are lazy loaded
^
limber skiff
yeah
austere talon
buildEmojiReactionColorsPlatformed is hiddenChannels
is that lazy loaded or just borked
charred monolithBOT
limber skiff
wtf
limber skiff
why was it cause of this
limber skiff
that's the only error
austere talon
just urs
limber skiff
yeah
limber skiff
💀
austere talon
in waitFor
Uncaught TypeError: kt is not a function or its return value is not iterable
limber skiff
did we even touch it
limber skiff
🤨
austere talon
and doesnt properly initialise it
wait no it hoisted those funcs
it moved them out of the module
check this
the wrappers are hoisted and webpack find is inside some module
esbuild bug??
livid heath
take a break
limber skiff
wtf
livid heath
limber skiff
what does g( do
austere talon
oh i know why
limber skiff
lmao why does it move that stuff to another place
limber skiff
oh
austere talon
i will just lazy import
limber skiff
we love circular imports
austere talon
or better yet move LazyComponent to a different file
charred monolithBOT
limber skiff
made esbuild isnt minifying as hard
austere talon
I HATE CIRCULAR IMPORTS
oh wait
i should add back maybe
or not?
it will make it so that late waitFor wont resolve ever
limber skiff
yeah add it back
charred monolithBOT
austere talon
push to main?
limber skiff
yeah
charred monolithBOT
austere talon
scary
limber skiff
ahhh shit
time to break vencord for thousand of users
now we wait for the complaints
idk how to write
austere talon
ok gn
austere talon
https://github.com/Vendicated/Vencord/security/code-scanning/9
wow can't believe you'd give me vulnerable code @mortal fractal
wait she can't see that
mortal fractal
i cant see it
limber skiff
austere talon
ill just dismiss it
limber skiff
@mortal fractal btw have you found a way to stop this horrible image compression?
mortal fractal
havent looked yet
limber skiff
aight
livid heath
destructuring lazy is in main branch now right?
limber skiff
yeah
austere talon
<@150745989836308480> btw have you found a way to stop this horrible image compr...
shouldn't be too hard probably
livid heath
thanks
mortal fractal
okay i am wrong about it being clientsided
livid heath
so it was indeed the proxy
limber skiff
what is it
livid heath
oh yeah i noticed that yesterday
limber skiff
oh it's that dumb thing
I saw that too
let me try to help you find where it's set
limber skiff
didnt know it was broken lol
austere talon
i mean
junior olive
how can i integrate my car into discord
austere talon
actually it might just be broken because i made it a dev build this release
it wasn't previously
and devbuilds throw on failed finds
so maybe it threw
we should stop using devbuild again and instead add a new define
i can do that tmrw
livid heath
patch src to remove format query param 
limber skiff
<@&1069716270695583934> .SUPPORTS_WEBP&&
livid heath
thats so dumb of them
livid heath
yeah
limber skiff
~~<@&1069716270695583934>~~ .SUPPORTS_WEBP&&
@mortal fractal
no idea how that happened but ok
livid heath
Vencord.Webpack.findByProps("SUPPORTS_WEBP").SUPPORTS_WEBP = false
limber skiff
no
livid heath
yeah that breaks gifs
limber skiff
it's one of those
livid heath
do not husk me ven, i dont like webp
limber skiff
omg this image quality
livid heath
patch src to remove format query param <:trolley:1024751352028602449>
this is still a solution
junior olive
i wonder if avatar decos have webp versions on the cdn
limber skiff
it's one of those
and this is getSrc
livid heath
looking at getImageSrc rn
return null != o && (c.format = o),
(s !== n || a !== r) && (c.width = 0 | s,
c.height = 0 | a),
!i.isEmpty(c) && (u += "?" + l.stringify(c)),
found it
limber skiff
and this is getSrc
here is enough prob
livid heath
it happens in getSrc yeah
proxyLazy(() => {
for (const id in wreq.m) {
const module = wreq.m[id].toString();
if (module.includes(".replaceIcon") && module.includes(".AtIcon")) {
return wreq(id as any).default;
}
}
})
please tell me there's a better way to do this
limber skiff
honestly we could just replace d.SUPPORTS_WEBP with false
livid heath
`Vencord.Webpack.findByProps("SUPPORTS_WEBP").SUPPORTS_WEBP = false`
^ i did and gifs broke
mortal fractal
id personally rather do it in getImageSrc
livid heath
i say we patch format to be null so it uses whatever format the image is
instead of forcing it it to be webp or png
limber skiff
i say we patch format to be null so it uses whatever format the image is
true
mortal fractal
why does this break gif on hover wtf
livid heath
d.SUPPORTS_WEBP && (n || !e.isAnimated(this.props))
because .webp is used for animated (gifs count as animated)
wait
no
mortal fractal
guh why does gif on hover rely on it being webp instead of fucking using passthrough like apng does
discordddddddddddddddddd
livid heath
if my plugin depends on a store do i add that store to webpack common or in the plugin
given that store isn't already in common
mortal fractal
does fakenitro not use it?
mortal fractal
search all files and see if anything else uses it
junior olive
guh why does gif on hover rely on it being webp instead of fucking using passthr...
the passthrough shit is so hacked together i feel
the moment they make their cdn not strip animation it's over
livid heath
no results except my plugin
livid heath
livid heath
top notch quality
limber skiff
{
find: "getImageSrc:",
replacement: {
match: /(?<=ratio:\i=1,)format(?=:\i=null)/,
replace: "_format"
}
}
ofc there is
limber skiff
```
{
find: "getImageSrc:",
replacement: {
match...
@austere talon do you recognize what I did here?
limber skiff
yop
livid heath
ofc there is
(the function is wrapped by .replaceIcon so findByCodeLazy doesn't work)
mortal fractal
```
{
find: "getImageSrc:",
replacement: {
match...
does this not break gifs
limber skiff
omg images look so good
limber skiff
does this not break gifs
nope
mortal fractal
wtf
austere talon
are u sure
mortal fractal
oh wait
limber skiff
https://media.discordapp.net/attachments/935989994735169546/1030885629975871578/...
yeah I tested with this one
austere talon
wait
mortal fractal
i think discord's gif check is stupid enough that it just expects .gif at the end
livid heath
copy paste them
bu-but redesigned icons toggle
limber skiff
they work fine
austere talon
use one on the cdn
livid heath
cdn gif
limber skiff
I'm making the format null
this is what the format can be
webp or png
I dont see how that affects gifs
livid heath
don't webpack search svgs
i will loose redesign toggle then
junior olive
copy paste them
what was the reason for this again
limber skiff
return d.SUPPORTS_WEBP && ((!animated || !autoPlay) || !e.isAnimated(this.props)) ? c = "webp" : (!animated || !autoPlay) && (c = "png"),
I would rather patch this place though
austere talon
i will loose redesign toggle then <:agony:1124777468834889798>
okay who gives a shit
livid heath
okay i'll copy paste
austere talon
what was the reason for this again
that you can't webpack search them cause they're all wrapped
and we had many issues in the past where svg searches broke
junior olive
sad
limber skiff
{
find: "handleImageLoad=",
replacement: {
match: /(getSrc\(\i\){.+?format:)\i/,
replace: "$1null"
}
}
this works too
@austere talon should I?
topaz thistle
Did I get tagged somewhere?
charred monolithBOT
charred monolithBOT
zenith elm
What happened to this? Did it get removed?
There is no discussion #1335 😕
cunning canyon
What happened to this? Did it get removed?
There is no discussion #1335 😕
discussion is disabled
zenith elm
How come?
spark pivot
cunning canyon
what
zenith elm
Oh
charred monolithBOT
Adds role icon between role circle and role name (if icon exists)
livid heath
is progress indicator necessary? there's UploadAttachmentStore which handles everything (except the progress event) so adding progress indicator would require mirroring (like 50~100 lines) the handlers of UploadAttachmentStore
lime stone
LOL that can actually be a problem
but in this case it's obviously not
computers are dumb
dapper crest
Why isn't this just 3 separate plugins?
Having them all together is kind of dumb imo
dapper crest
I don't care for show media names or allowed mentions.
From the viewpoint of someone looking for cool plugins, I appreciate the name of a plugin being very self describing so I look at it
dapper crest
could be toggles
Extra complexity when it could just use the existing plugin toggler
lime stone
AllowedMentions/MentionControl, EditAttachments, ShowMediaNames lol
I don't like the pascal names, why are they not just spaced I can't remember
livid heath
Why isn't this just 3 separate plugins?
Having them all together is kind of dum...
i can separate the last but the first 3 share some patches
but i felt grouping them was better since they have one purpose of making messages better
dapper crest
i can separate the last but the first 3 share some patches <:blobcatcozy:1026533...
Vencord has a system for plugins being required as dependencies does it not
livid heath
Vencord has a system for plugins being required as dependencies does it not
yes but idk about patches
inland fable
From the viewpoint of someone looking for cool plugins, I appreciate the name of...
i apple
Agree
austere talon
STOP DOING NIXOS
verbal pumice
i use nix btw
livid heath
i use nix btw
perish
olive aurora
STOP DOING NIXOS
is this true
fiery torrent
hey! just popping in to ask if the maintainer of the clearURLS plugin would like to look at my PR? https://github.com/Vendicated/Vencord/pull/2005
fiery torrent
thank you 
charred monolithBOT
junior olive
@limber skiff heyy do you think you'd be able to review more of decor? I'd like to try and get it as refined as possible so we can get it merged quickly
junior olive
alright no worries, and if you're willing to review it at any other point i would greatly appreciate it
olive aurora
why do people come with the most niche setups and expect us to figure out what they messed up
limber skiff
@austere talon I found out when we force load all chunks not all actually get required
austere talon
<@343383572805058560> I found out when we force load all chunks not all actually...
wait wdym
oh do you mean the modules itself are not all required
limber skiff
yeah
austere talon
I mean that's fine, no?
limber skiff
that's why UserSettings finds are not being found in the reporter
austere talon
we patch them anyway
limber skiff
that's why UserSettings finds are not being found in the reporter
it only actually requires the modules when we open UserSettings manually
austere talon
ohh
limber skiff
let me show you why
austere talon
is this for webpack find testing
limber skiff
yeah
austere talon
ah ic
limber skiff
createPromise: ()=>n.el("420610").then(n.bind(n, "420610"))
el loads all these chunks "shared", "app", "64827", "73850", "15556", "86213", "57832", "62597", "56122", "48528", "75232", "29232", "98904", "495" and then requires 420610 itself later
however 420610 itself is not a chunk id, so when we call wreq.e with all the chunk ids 420610 is not required
however 420610 itself is not a chunk id, so when we call wreq.e with all the chunk ids 420610 is not required
as in it's not present in this mapping
we just need to wreq() all the keys on this mapping
but it's not exported 💀
charred monolithBOT
After setting transparent to true in ~/.config/VencordDesktop/VencordDesktop/settings/settings.json as well as enabling Splash theming in the GUI, the splash screen is successfully transparent:
But not the app:
This is what it's supposed to look like (`armcord --enable-features=UseOzonePlat...
charred monolithBOT
austere talon
but it's not exported 💀
that's not a problem
limber skiff
that's not a problem
how would we access it
austere talon
> however 420610 itself is not a chunk id, so when we call wreq.e with all the c...
420610 is the id of the entry module of that chunk
it's like
loadChunks().then(() => require(420610))
limber skiff
yes I know
austere talon
then what's the question
limber skiff
but we can only know that using the non exported object or by looking at every .el() call on modules
as I said 420610: "some chunk url" doesn't exist
limber skiff
> however 420610 itself is not a chunk id, so when we call wreq.e with all the c...
this
austere talon
we just need to wreq() all the keys on this mapping
what are these?
limber skiff
we just need to wreq() all the keys on this mapping
basically, every key on this object is the entry point of executing some part of chunked code (which can be formed of more than one chunk)
createPromise: ()=>n.el("420610").then(n.bind(n, "420610"))
chunks it loads: "shared", "app", "64827", "73850", "15556", "86213", "57832", "62597", "56122", "48528", "75232", "29232", "98904", "495"
when you open the UserSettings that el() function call gets executed
discord loads all those chunks (shared, app. 64827, etc)
and then requires the entry point for the UserSettings which is 420610
in the current approach we force load every chunk and require the entry point of it using the map inside webpack.u, but that doesn't necessarily require all the modules of that chunk
for example it doesn't require 420610
austere talon
we can't really require all modules
it'll cause issues
many modules require on other modules being initialised
limber skiff
yes that is true
austere talon
or even can't be required outside of a specific context
limber skiff
but if we were able to access that non exported object we could call.el on every key
austere talon
are you sure it wouldn't cause issues
limber skiff
which would require pretty much all the code discord does use
austere talon
is it only the settings module that's causing issues
limber skiff
yeah, surprisingly enough only finds that depend on it are causing issues
limber skiff
are you sure it wouldn't cause issues
I doubt it, but idk how we would get access to it too
austere talon
so it's only settings?
then why not just specifically require settings but nothing else
limber skiff
lol
austere talon
yeah, surprisingly enough only finds that depend on it are causing issues
i think cause we generally avoid using modules that are lazy loaded
limber skiff
yeah
austere talon
we only use settings ui code cause it's safe to do so in our settings code
limber skiff
I'm thinking of manually fetching discord webpack entry point script and regex matching the object
limber skiff
we can't patch it cuz it's the webpack entry point
so idk another way than fetching
austere talon
not a problem
i mean fetching it is fine but also seems unnecessary
i will check in a bit
junior olive
@limber skiff you could try and search for this https://github.com/Vendicated/Vencord/pull/910/files#diff-41dbe18403537328a3c7357c73fe6525be0a23ed0f6a7427f7f4e0ed2e15d7bfR11-R12
