#👾-core-development
fresh cloak
FATAL ERROR: tsfn_to_js_proxy napi_call_function
z/home/sarah/Documents/github/Vesktop/node_modules/electron/dist/electron exited with signal SIGABRT
that's so awesome
It detects the key and then kills itself
Maybe it's time we build our own native hotkey module
I hate relying on other people
livid heath
Maybe it's time we rewrite the client for good
livid heath
I refuse to use software related to erkinalp
fresh cloak
so now of course the question is can i access this function from Vesktop
ahh okay i can execute javascript in the main window
fresh cloak
i got it working 
now i'm gonna have to fuckle together an interface and settings for these keybinds
charred monolithBOT
ruby coyote
uncut glen
Anything else you guys think I should add/fix in the plugin?
livid heath
lol
topaz thistle
new commits will now be verified
new commits will now be anti-verified
umbral hedge
uncut glen
quick question, how long dose it usualy takes for vee to look at a a PR?
soory if thats a bad question
main trout
quick question, how long dose it usualy takes for vee to look at a a PR?
It'll be reviewed between today & around 70 years from now
Jokes aside it'll take a while
Could take a week could take a month
main trout
little wing
I hope volumebooster for vesktop gets taken a look sometime
someone commented in the issue saying they would try but I think they never did
livid heath
Could take a week could take a month
A month you say
main trout
Skill issue
livid heath
not mine
lime stone
LOL
main trout
lime stone
dependaboat
hire this man
(i'm not going to share their name but this is a very cool bio)
main trout
hire this man
Renovate?
charred monolithBOT
umbral hedge
lmao??
burnt ridge
Lol
charred monolithBOT
charred monolithBOT
junior olive
@austere talon Can we try to get Decor reviewed (and ideally merged) tonight, please? I resolved your first review's notes and implemented the better patch to add Decor decorations from Cynthia. I understand if stuff came up last night or you didn't feel like doing it, but leaving me in the dark about whether or not it was gonna happen felt really shitty and I just want to get Decor into Vencord so we can be over with this for a bit :/
junior olive
be patient
I have been, Ven said on Wednesday after half-reviewing it that they'd review the rest tomorrow (Thursday) and when it didn't seem like that was going to happen I asked them if it was going to happen (so I could get out of adhd mode) and got ignored :/
charred monolithBOT
I suggest adding some kind of hint when there are no sounds logged yet. Currently it looks a bit empty there
mortal fractal
this is what happens to all plugins
and thats what makes me not even want to contribute because the model doesnt work for a public client mod unless you have 5-10 reviewers around the clock to be able to review things in a timely manner
patent nova
may i know the error reason
patent nova
this error was because of this plugin https://github.com/sh3devil/faeffect/tree/main
dire trench
this error was because of this plugin https://github.com/sh3devil/faeffect/tree/...
if u want profile effects try my plugin
patent nova
https://github.com/ryan-0324/vencord
does it support decoration and effects?
dire trench
does it support decoration and effects?
it supports profile theme colors and profile effects
charred monolithBOT
dire trench
and it has a very easy to use ui
dire trench
its src/plugins/fakeProfileThemesAndEffects
use something like https://download-directory.github.io/ to download just that folder
dire trench
will try now ty
u also gotta add this to the list of devs in src/utils/constants.ts
ryan: {
name: "ryan",
id: 479403382994632704n
},
even if i put the plugin in userplugins?
dire trench
even if i put the plugin in userplugins?
yeah but put the plugin in src/plugins
dire trench
theres already a plugin that does that
should get added soon
its called decor
doesnt rely on 3y3
patent nova
cna't find it
dire trench
cna't find it
this one has changes outside of its plugin folder
if u look at the commits u can see what those changes are
would probably be easier to just clone the whole repository then add fakeProfileThemesAndEffects to it and update the dev constants
patent nova
https://github.com/FieryFlames/Vencord/tree/decor
tysm
dire trench
whats the point of that thing
unkempt oak
patch helper
dire trench
i just use devtools
junior olive
im cooking
whatchu trying to cook tho
unkempt oak
like the vencord dev build has
dire trench
why u need to get module number to write patch
unkempt oak
you dont really
unkempt oak
i didnt even realize that was out of app
yop i stole most of the styles 
flint jewel
Is there a way to determine which text channel you're viewing? I want to add right click functionality to the call button in group/user dms but I'm not sure how to do that
my previous plugin in betterdiscord used mutation observers but there has to be a better way lol
unkempt oak
in vendetta you use SelectedChannelStore ts find(x => x?.getName?.() === "SelectedChannelStore").getChannelId();
however there might be a better version for pc clients
austere talon
youre asking massive X/Y problem question
first patch the context menu
it already gives you the channel
unkempt oak
why do pc clients have to be so much more complicated
austere talon
???
flint jewel
in vendetta you use `SelectedChannelStore` ```ts
find(x => x?.getName?.() === "S...
yeah I was hoping there might've been some event that would trigger upon switching channels
austere talon
its easier
austere talon
yeah I was hoping there might've been some event that would trigger upon switchi...
why
thats just wrong
patch the context menu
it gives you the channel
flint jewel
alright then I'll try that, thanks
austere talon
why do pc clients have to be so much more complicated
so complicated 🤯
charred monolithBOT
mortal fractal
in vendetta you use `SelectedChannelStore` ```ts
find(x => x?.getName?.() === "S...
Flux.Store.getAll().find(x=>x.getName() === "SelectedChannelStore")
charred monolithBOT
unkempt oak
added diff
spark pivot
I'm really struggling to find where messages are received in discord's code, everything i find ends up being something else, any help?
some of them are when it's received but it's after the point i need it to be, i need to find exactly when the client receives it
austere talon
what for
unkempt oak
in that case listen to the message create flux event no
spark pivot
i need to modify the data in the received message
unkempt oak
oh
spark pivot
.
unkempt oak
@junior olive 
https://patchhelper.vercel.app/
its not showing the shiggy gif in the embed
jagged cloak
unkempt oak
this is how you're meant to use it
unkempt oak
spark pivot
this is how you're meant to use it
no like this
spark pivot
i need to modify the data in the received message
i am dying inside trying to find where this is
junior olive
<@890228870559698955> <:trolley:1024751352028602449> https://patchhelper.vercel....
Very cool
spark pivot
yeah i think ik why
unkempt oak
yeah i think ik why
love vercel
spark pivot
just let discord be your cdn
austere talon
@cunning canyon hmm why not do this for all timestamps in discord? https://github.com/Vendicated/Vencord/pull/1671
its probably not much harder to do
well it does already have a lot of stuff, just not the days ago
<t:1699663282>
oh i see, joined date is like very weird xd it doesnt even use proper timestamp
discord moment
charred monolithBOT
hmm i think it'd be better to format the date exactly like Discord's own timestamps
i think they use moment for that
jagged cloak
fear
charred monolithBOT
spark pivot
try and ping me i dare you
jagged cloak
@spark pivot hiii
spark pivot
reply ping*
austere talon
try and ping me i dare you
a
dire trench
reply ping*
spark pivot
no ping https://cdn.discordapp.com/emojis/1155918238442606713.gif?size=32&name=hypershiggy&quality=lossless
austere talon
why
cunning canyon
maybe i will just close because of #1784
jagged cloak
i didnt even know git let you do this
austere talon
is this the right XSOverlay? https://store.steampowered.com/app/1173510/XSOverlay/
jagged cloak
yes
austere talon
who paying 10 bux for that
jagged cloak
many
spark pivot
damn
jagged cloak
people are just malding about him changing from unity ui to web ui
lol
anyways uhh you can just use steamvr dashboard now it doesnt suck as much as it used to (it still sucks tho)
you're paying for quality of life as usual
or use one of the free ones that are probably worse because they dont get paid to develop their shit
charred monolithBOT
jagged cloak
why did you husk own review
cunning canyon
seems very convoluted / overengineered
btw the days ago is because i like it in aliucord
austere talon
days ago is cool
austere talon
guh syntax highlighting broke
cunning canyon
3-line tooltip
jagged cloak
Are the dispatch logs from console optimistic or something?
mentioned, stickers and stuff from viewraw arent in this object
cunning canyon
how
austere talon
Are the dispatch logs from console optimistic or something?
`mentioned`, `sticke...
these are gateway messages
they differ from what flux dispatches
wp.Common.FluxDispatcher.subscribe("MESSAGE_CREATE", console.log)
jagged cloak
they differ from what flux dispatches
still
jagged cloak
not saying theyre the exact same but what im using has worked for me
junior olive
well try some of these props
prolly allowoverflow?
cunning canyon
still same
jagged cloak
also can you even get optimistic events from other users
jagged cloak
actually no that doesnt matter
jagged cloak
oh my god i hate shithub
that was entirely my fault but i like blaming guhhub
check again when you feel like it
charred monolithBOT
jagged cloak
didnt i already do thar
charred monolithBOT
jagged cloak
also definitely ignore the two commits i included on accident lol
charred monolithBOT
jagged cloak
oh its just incredibly slow
junior olive
lmao [-](https://www.githubstatus.com)
I NOTICED THIS
charred monolithBOT
junior olive
i was pushing to my server. and expecting it to build docker container
jagged cloak
veb crashed shithub again real
thick kestrel
not sure if this is the right channel regarding plugin development questions
junior olive
it is
thick kestrel
good
I'm a decent-ish programmer with non-zero experience with JS (it's not a lot though). I never used other Discord modifications, so I have no experience with that. I've read the plugin development documentation and now I have some idea about how code modification is done in Vencord.
now, I'm struggling to understand how would I go around finding the right snippet to patch, other than just beautifying Discord's JS and then clueless grepping through it. which I've attempted, with minimal success - since the names are minified, looking for keywords wasn't very helpful, mostly leading to translation strings.
what I'd like to try making is a plugin that'd change the inline CSS Discord puts into nicknames based on the role color, to be based on something else.
void echo
I'm a decent-ish programmer with non-zero experience with JS (it's not a lot tho...
Once you have vencord installed you can open developer tools as you would in chrome, then find the react dev tools
You can select the element you're patching
thick kestrel
Once you have vencord installed you can open developer tools as you would in chr...
do I need to install the desktop client for development then?
I use Firefox
void echo
do I need to install the desktop client for development then?
Vesktop or web
midnight raven
using browser for development is suicide
void echo
oops
midnight raven
cause u need to manually reinstall ext each time
jagged cloak
that has to be deliberate
it happens on unpatched 64bit canary and they dont seem like theyre gonna fix it anytime soon
who am i kidding though
midnight raven
its cause their css bundle is fucked up
void echo
you can use desktop if you want just open devtools before its launched fully lmao
thick kestrel
Vesktop or web
well, I do use the web version, in particular with the userscript version of Vencord (since the Firefox version got poofed out of existence)
void echo
well, I do use the web version, in particular with the userscript version of Ven...
If you seriously want to get into developing just install Vesktop
thick kestrel
well, I do use the web version, in particular with the userscript version of Ven...
but you said "as you would in Chrome", so I assume I need Chrome or desktop (not sure what Vesktop is), not Firefox
jagged cloak
do you know regex, if you dont learn or you will hate yourself
working with vencord patches
thick kestrel
yeah regex is an essential skill in software development lol
and even daily use of computers tbh
so yeah, I am quite familiar with the Perl flavor, which the JS flavor is kinda similar to as far as I can tell
(as well as somewhat with the Vim flavor but uh yeah)
so Vesktop is a repackaged version of Discord web with Vencord preinstalled
spark pivot
Yes
thick kestrel
guess gonna install that just for development, though I will stay with Firefox for daily use, it's convenient to have just a single browser running lol
thick kestrel
guess gonna install that just for development, though I will stay with Firefox f...
ah yes, Chromium for Linux not having autoscrolling so I can't scroll the server list
gonna add the scrollbar back
void echo
@spark pivot How hard would it be to create an inverse of your plugin?
so if metions are off it mentions me anyway
wait
spark pivot
easy (i think)
void echo
/*
* Vencord, a Discord client mod
* Copyright (c) 2023 Vendicated and contributors
* SPDX-License-Identifier: GPL-3.0-or-later
*/
import { Devs } from "@utils/constants";
import definePlugin from "@utils/types";
import { MessageStore, UserStore } from "@webpack/common";
import { MessageJSON, UserJSON } from "discord-types/general";
export default definePlugin({
name: "AlwaysReplyPings",
description: "Ensures getting pinged by replies, even if the sender turned it off",
authors: [Devs.MrDiamond],
patches: [
{
find: "_channelMessages",
replacement: {
match: /receiveMessage\((\i)\)\{/,
replace: "$&if($self.shouldAddMention($1))$1.mentions.push($self.getCurrentUserMention());"
}
}
],
shouldAddMention(e: MessageJSON): boolean {
if (!e.message_reference) return false;
const repliedMessage = MessageStore.getMessage(e.channel_id, e.message_reference.message_id);
if (!repliedMessage) return false;
return repliedMessage.author.id === UserStore.getCurrentUser().id && !e.mentions.some(mention => mention.id === UserStore.getCurrentUser().id);
},
getCurrentUserMention(): UserJSON {
const currentUser = UserStore.getCurrentUser();
return { id: currentUser.id, username: currentUser.username, discriminator: currentUser.discriminator };
}
});
would it be that simple
mortal fractal
why not just modify shouldNotify
midnight raven
wont add the yellow highlight
charred monolithBOT
spark pivot
vscode plugin is so cool
test
void echo
again?
void echo
someone reply ping me please
thick kestrel
someone reply ping me please
here
thick kestrel
again plss
:)
dire trench
someone reply ping me please
_ _
fringe eagle
vscode plugin is so cool
my plugin just adds plugin creation
but i'm gonna update it rn
void echo
what is venticord
fringe eagle
modified vencord
void echo
whats the mod
void echo
kewllll
i did see ur vscode thing
a min ago
/*
* Vencord, a Discord client mod
* Copyright (c) 2023 Vendicated, Mr Diamond, ant0n and contributors
* SPDX-License-Identifier: GPL-3.0-or-later
*/
import { definePluginSettings } from "@api/Settings";
import { Devs } from "@utils/constants";
import definePlugin, { OptionType } from "@utils/types";
import { MessageStore, UserStore } from "@webpack/common";
export const settings = definePluginSettings({
alwaysPingOnReply: {
type: OptionType.BOOLEAN,
description: "Always get pinged when someone replies to your messages",
default: false,
}
});
export default definePlugin({
name: "ReplyPingControl",
description: "Control whether to always or never get pinged on message replies",
authors: [Devs.ant0n, Devs.MrDiamond],
settings,
patches: [
{
find: "_channelMessages",
replacement: {
match: /receiveMessage\((\w+)\)\{/,
replace: "$&$self.modifyMentions($1);"
}
}
],
modifyMentions(message) {
const isReplyToCurrentUser = this.isReplyToCurrentUser(message);
if (settings.store.alwaysPingOnReply && isReplyToCurrentUser) {
if (!message.mentions.some(mention => mention.id === UserStore.getCurrentUser().id)) {
message.mentions.push(this.getCurrentUserMention());
}
} else if (!settings.store.alwaysPingOnReply && isReplyToCurrentUser) {
message.mentions = message.mentions.filter(mention => mention.id !== UserStore.getCurrentUser().id);
}
},
isReplyToCurrentUser(message) {
if (!message.message_reference) return false;
const repliedMessage = MessageStore.getMessage(message.channel_id, message.message_reference.message_id);
return repliedMessage && repliedMessage.author.id === UserStore.getCurrentUser().id;
},
getCurrentUserMention() {
const currentUser = UserStore.getCurrentUser();
return { id: currentUser.id, username: currentUser.username, discriminator: currentUser.discriminator };
}
});
is there anything obviously awful
with this
AHH
ok
thats the done one
thick kestrel
how do I even use Vesktop for development, for Firefox I ran pnpm buildWeb and installed the userscript
for desktop the docs say to pnpm inject
but what about Vesktop then
fringe eagle
how do I even use Vesktop for development, for Firefox I ran `pnpm buildWeb` and...
you download vesktop, build your vencord, and then change the dist in the vesktop tray settings
it hink
ith ink
i th in k
ithnk
thick kestrel
fringe eagle
try looking in the Vesktop repo
cunning canyon
vesktop settings
thick kestrel
vesktop settings
thanks
welp, I still don't see the plugin
oh, perhaps a full restart is needed
dire trench
why user ids in dev constants stored as bigints when they are strings everywhere else
thick kestrel
oh, perhaps a full restart is needed
yes, that was the issue
austere talon
why user ids in dev constants stored as bigints when they are strings everywhere...
bigints are the future
discord also uses bigints in some places
dire trench
bigints are the future
do u know a better way to get badges other than Vencord.Util.fetchUserProfile?
austere talon
there isn't a better way
austere talon
im getting rate limited
yes why do you think badges everywhere isn't a vencord plugin
it's api spam
dire trench
there is an alternative
austere talon
the alternative is not having it
dire trench
the user object has a flag variable
dire trench
its a number that represents the badges a user has
bitwise shift and u can figure out what badges
but i would have to hardcode the badges cuz i cant find anywhere in the api to get a list of all possible badges
livid heath
guh use user profile store
austere talon
that's only cached users
iirc the normal user object doesn't have the flags you need
livid heath
that's only cached users
if a user's messages are being rendered (and assuming thats the only place the plugin would add badges), then the user would definitely be cached?
austere talon
no it doesn't
fetching is a different function and fetching all users in chat is braindead
mortal fractal
it doesnt you have to use another function from another module to fetch profile
livid heath
random user never opened profile
livid heath
😭 discord so ass
junior olive
could a cloudflare worker that caches user profile heavily for badges be done
austere talon
no
livid heath
tbh why even make such a plugin
dire trench
perhaps the error is related...
livid heath
random user never opened profile
so well you could try to get the cached profile and fetch if not available rather than spamming profile regardless
dire trench
nah i dont need to get the profile for this
i just need to find a list of all badges
to get their values
so i dont have to hardcode them
livid heath
profile has list of badges
livid heath
or you wait for the day when community team goes insane and adds /users/:id/badges endpoint
dire trench
profile has list of badges
im talking about something like this
mortal fractal
this is vencord dev
vns
nimble pendantBOT
this is vencord dev
austere talon
<@&1088566810976194693> moment
dire trench
this plugin not only gets me rate limitted but makes my discord freeze every 2 seconds
livid heath
well that should give you a clear indication
austere talon
shrimply don't make the plugin
livid heath
bad plugin idea
dire trench
it can be done
ill just hardcode the badges
livid heath
this is a i will do it just because i can moment
livid heath
it can be done
ill just hardcode the badges
and how do you plan on getting user flags
dire trench
UserStore
livid heath
what if not cached
dire trench
nvm i dont even need to do that
the message author object has a user object with the flags im pretty sure
dire trench
i will update the plugin
livid heath
manual updating :lipbite:
dire trench
i removed the fetchUserProfile part and its still freezing
austere talon
maybe it's time to abandon the plugin
dire trench
this runs for every user
fetch("https://gist.githubusercontent.com/Vendicated/51a3dd775f6920429ec6e9b735ca7f01/raw/badges.csv")
.then((res: Response): Promise<string> => { return res.text(); })
.then((data: string) => {
const badges: string[][] = data.split("\n").map((s: string) => s.split(","));
const userBadges: [string, string][] = [];
for (let i: number = 0; i < badges.length; i++) {
if (badges[i][0] === author.id)
userBadges.push([badges[i][1], badges[i][2]]);
}
setVCBadges(userBadges);
})
.catch(e => { console.error(e); });
every message actually
livid heath
no cache moment
austere talon
you will use .filter()
dire trench
chad for loop vs soy filter
charred monolithBOT
unkempt oak
ok patch helper is finished https://patchhelper.nexpid.xyz
verbal pumice
horror
dire trench
Do people actually use the patch helper
dire trench
U know u can press the un minify button in devtools
verbal pumice
unless you can like, share patches through it
verbal pumice
U know u can press the un minify button in devtools
yes
dire trench
Then what's the point of the patch helper
verbal pumice
ok patch helper is finished https://patchhelper.nexpid.xyz
actually you know what this could use
dire trench
Regex search is built into devtools
verbal pumice
filling from clipboard
turbid hatch
Then what's the point of the patch helper
to see how a patch is applied
unkempt oak
filling from clipboard
livid heath
<:thumbsup:1085810729753522296>
please put the diff in a codeblock
verbal pumice
i think its better not being in a codeblock tbh
unkempt oak
mmmyes inspect data using ⬛⬛⬛⬛⬛ and ⬛⬛⬛⬛⬛
light mode user
livid heath
any problem with that
unkempt oak
no
unkempt oak
<@853550207039832084> it seems you are using chunk ids as module ids
ohhh so thats where the id comes from
livid heath
i haven't updated this to work with rspack yet, but it whould give you a rough idea https://github.com/arHSM/discord-builds-dissector/blob/main/dissector/discord_web/webpack/chunk.ts
unkempt oak
test
unkempt oak
<@853550207039832084> it seems you are using chunk ids as module ids
finally understood how modules are loaded and now you can property inspect them
(all of these are uncommited changes btw)
cunning canyon
why do the plugin for pfp need to have badge lmao
woeful sable
little wing
this guy gets it
wary void
duplicate
there doesn't seem to be an actual gh issue, so I assume this means it's known, right?
austere talon
wary void
ah, a classic "github search sucks" moment (and me being blind, as it's the 4th latest open issue). thanks
void echo
@spark pivot I'm not able to make a PR to your no-reply-pings but I've created a README.md and updated the plugin
also if anyone sees anything really stupid on that plugin lmk cz im very new to TS
also, I had an idea for creating readmes where I could try feeing plugins to the codex LLM and letting it create one based on that
might be a lot faster for the plugins that alr don't have them and then moving forward we can manually add them
spark pivot
I’ll look at in a bit and just make a new pr for it
void echo
wouldnt let me weirdly
do you have them disabled?
or do you mean a new PR to main vencord
void echo
I forked MrDiamonds
fresh cloak
fresh cloak
doesn't matter which branch you're on
void echo
oops
fresh cloak
it's still forked from the same repo
void echo
smmhmgnfgng i did the wrong thing
void echo
<@145224646868860928>
Yeah
spark pivot
k cool
spark pivot
ugh shithub let me comment on a review without making a new review
void echo
I'm currently not even importing UserJSON
spark pivot
huh
void echo
void echo
pnpm i?
LOL IM SO DUMB
i swear i did that
thats the insomnia kicking in
u sure is should be as Unknown?
void echo
@spark pivot
can you no ping reply to me
wait
no this fix doesnt work
the one you suggested
im getting this on all my msgs
void echo
yea i dont get a ping for that
youll need to clone then manually add
https://github.com/Vendicated/Vencord/pull/1975#discussion_r1390258420
and
import { MessageJSON, UserJSON } from "discord-types/general";
void echo
The return statement in modifyMentions is only executed if isReplyToCurrentUser returns false, which means it exits the function early for non-reply messages.
modifyMentions(message: MessageJSON) {
if (!this.isReplyToCurrentUser(message)) return;
if (settings.store.alwaysPingOnReply) {
if (!message.mentions.some(mention => mention.id === UserStore.getCurrentUser().id)) {
message.mentions.push(this.getCurrentUserMention());
}
} else {
message.mentions = message.mentions.filter(mention => mention.id !== UserStore.getCurrentUser().id);
}
}
this is it before
void echo
try that
spark pivot
ok reply to me with pings off?
e
void echo
ok now reply with pings on
spark pivot
ok reply to me with pings off?
e
void echo
now on again
void echo
/*
* Vencord, a Discord client mod
* Copyright (c) 2023 Vendicated, Mr Diamond, ant0n and contributors
* SPDX-License-Identifier: GPL-3.0-or-later
*/
import { definePluginSettings } from "@api/Settings";
import { Devs } from "@utils/constants";
import definePlugin, { OptionType } from "@utils/types";
import { MessageStore, UserStore } from "@webpack/common";
import { MessageJSON, UserJSON } from "discord-types/general";
export const settings = definePluginSettings({
alwaysPingOnReply: {
type: OptionType.BOOLEAN,
description: "Always get pinged when someone replies to your messages",
default: false,
}
});
export default definePlugin({
name: "ReplyPingControl",
description: "Control whether to always or never get pinged on message replies",
authors: [Devs.ant0n, Devs.MrDiamond],
settings,
patches: [
{
find: "_channelMessages",
replacement: {
match: /receiveMessage\((\w+)\)\{/,
replace: "$&$self.modifyMentions($1);"
}
}
],
modifyMentions(message: MessageJSON) {
if (!this.isReplyToCurrentUser(message)) return;
if (settings.store.alwaysPingOnReply) {
if (!message.mentions.some(mention => mention.id === UserStore.getCurrentUser().id)) {
message.mentions.push(this.getCurrentUserMention());
}
} else {
message.mentions = message.mentions.filter(mention => mention.id !== UserStore.getCurrentUser().id);
}
},
isReplyToCurrentUser(message: MessageJSON) {
if (!message.message_reference) return false;
const repliedMessage = MessageStore.getMessage(message.channel_id, message.message_reference.message_id);
return repliedMessage && repliedMessage.author.id === UserStore.getCurrentUser().id;
},
getCurrentUserMention() {
return UserStore.getCurrentUser() as unknown as UserJSON;
}
});
yum
fresh cloak
is there anything we can do about screensharing on vesktop? electron GPU features report video encode is available but.. y'know
spark pivot
updated the review
charred monolithBOT
spark pivot
fresh cloak
is there anything we can do about screensharing on vesktop? electron GPU feature...
streams you run will often report a yellow exclamation mark indicating packet loss? people who are watching me are reporting very low fps when this happens
this seems to only happen on these webpage based discord clients
void echo
this seems to only happen on these webpage based discord clients
i was under the impression it was a chromium hardware acceleration limitation
fresh cloak
but why would it be?
GPU features report hardware accelerated encoding is available and enabled
charred monolithBOT
fresh cloak
but regardless of that it's still all done on cpu
patent nova
@spark pivot i know how to setup third party pluggins
i just don't know how to use it
literally no info
dusky sonnet
can anyone give some feedback on this?```ts
{
find: "getUserAvatarURL:",
replacement: {
match: /(i=a.*??).+?(:f.AVATAR_SIZE)/,
replace: "$1(arguments[2]==80?300:arguments[2])$2"
}
}
works but the regex is pretty ugly
spark pivot
what's the code you need to match
stark barn
<@523338295644782592> i know how to setup third party pluggins
can you tell me how to set up
void echo
@patent nova @stark barn #🏥-vencord-support-🏥
dusky sonnet
function C(e) {
var t;
let n = arguments.length > 1 && void 0 !== arguments[1] && arguments[1]
, i = arguments.length > 2 && void 0 !== arguments[2] ? arguments[2] : f.AVATAR_SIZE // this line
, r = arguments.length > 3 && void 0 !== arguments[3] ? arguments[3] : null;
return null !== (t = I(e, n, i, r)) && void 0 !== t ? t : g(e.id, e.discriminator)
}
can you not just put i = arguments.length > 2 && void 0 !== arguments[2] ? arguments[2] : f.AVATAR_SIZE into it and regex-ify it
aka remove spaces and escape other regex characters
and use \i for i and f
fresh cloak
maybe we're not using an electron build with vaapi enabled
austere talon
discord code does not have unnecessary spaces
void echo
so that then
void echo
OH Ok
{
find: "getUserAvatarURL:",
replacement: {
match: /(\i=arguments\.length>2&&void 0!==arguments\[2\]\?arguments\[2\]:)f\.AVATAR_SIZE/,
replace: "$1(arguments[2]==80?300:arguments[2])"
}
}
except for the void 0 one cause that would error lol
i really want to add a place for just pasting a whole patch into the patch helper
it's annoying going into each field and pasting them
austere talon
do it
spark pivot
do it
ugh patches arent actual JSON objects cause they have regex and stuff so I have to find a workaround
charghpt says eval but there has to be a better way
charred monolithBOT
austere talon
you can just eval them
charred monolithBOT
austere talon
since its a developer tool i assume people who paste stuff there are smart enough not to paste malicious scripts
patch helper currently already evals your replacement
spark pivot
that's true
dusky sonnet
How are you supposed to format the header in the files
pnpm test doesnt seem to like mine lol
dusky sonnet
eslint seems to be forcing this ```ts
/*
- Vencord, a Discord client mod
- Copyright (c) 2023 Vendicated and contributors
- SPDX-License-Identifier: GPL-3.0-or-later
*/
but still says its invalid
void echo
/*
* Vencord, a Discord client mod
* Copyright (c) 2023 Vendicated, Mr Diamond, ant0n and contributors
* SPDX-License-Identifier: GPL-3.0-or-later
*/
could it be because im not importing devs?
void echo
Yeah you optionally can
Good practice if u wna show this stff on portfolio
its weird literally noone ads themselves to the license
dusky sonnet
should the name be discord username or Github username?
dusky sonnet
Good practice if u wna show this stff on portfolio
yeah thats gonna be pointless anyway since i wouldnt be using my "public" github
void echo
You can add whatever you want as your name
Your dev constant should link back to whatever account you want the badge on though
dusky sonnet
yeah
the header is still broken :/
still is forced to ```ts
/*
- Vencord, a Discord client mod
- Copyright (c) 2023 Vendicated and contributors
- SPDX-License-Identifier: GPL-3.0-or-later
*/
what you got under ur header
dusky sonnet
/*
* Vencord, a Discord client mod
* Copyright (c) 2023 Vendicated and contributors
* SPDX-License-Identifier: GPL-3.0-or-later
*/
import { disableStyle, enableStyle } from "@api/Styles";
import { Devs } from "@utils/constants";
import definePlugin from "@utils/types";
import styles from "./style.css?managed";
export default definePlugin({
name: "LargeProfileAvatars",
description: "Makes avatars take up the full width of the profile modal and scales resolution accordingly",
version: "1.0.0",
authors: [
Devs.board
],
patches: [
{
find: "getUserAvatarURL:",
replacement: {
match: /(\i=arguments\.length>2&&void 0!==arguments\[2\]\?arguments\[2\]:)f\.AVATAR_SIZE/,
replace: "$1(arguments[2]==80?300:arguments[2])"
}
}
],
start() {
enableStyle(styles);
},
stop() {
disableStyle(styles);
}
});
``` sorta doubt this is gonna get accepted anyway lolsorta doubt anything will get accepted
void echo
```ts
/*
* Vencord, a Discord client mod
* Copyright (c) 2023 Vendicated and c...
that's fine. are you sure you've done pnpm i
dusky sonnet
that's fine. are you sure you've done `pnpm i`
hadnt done it until now
didnt seem to change anything though
void echo
I'm not getting any header errors anyway so dw about that
dusky sonnet
to be fair its showing the wrror here aswell
void echo
only error i get is lack of css ofc
dusky sonnet
.userPopoutOuter_d739b2 .avatarPositionNormal__1797c,
.userPopoutOuter_d739b2 .avatarPositionPremiumBanner__1e83d,
.userPopoutOuter_d739b2 .avatarPositionPremiumNoBanner__8bf3b {
position: static;
order: -1;
z-index: 1;
}
.userPopoutOuter_d739b2 .avatarHint__8e5b9 {
height: 340px;
width: 100%;
}
.userPopoutOuter_d739b2 .wrapper_edb6e0[style^="width: 80px"] {
width: 340px !important;
height: 340px !important;
}
.userPopoutOuter_d739b2 .avatarHintInner__3d1c9 {
box-shadow: none;
}
.userPopoutOuter_d739b2 .bannerSVGWrapper__3e7b0:not([viewBox$="120"]) {
display: none;
}
.userPopoutOuter_d739b2 .bannerSVGWrapper__3e7b0 mask circle {
display: none;
}
.userPopoutOuter_d739b2 .avatarHoverTarget__3a360 .wrapper_edb6e0 svg {
width: 115%;
height: 115%;
}
.userPopoutOuter_d739b2 .avatarHoverTarget__3a360 .wrapper_edb6e0 svg circle {
display: none;
}
.userPopoutOuter_d739b2
.avatarHoverTarget__3a360
foreignObject
.avatarStack__6604a {
transform: translate(0, 0);
}
.userPopoutOuter_d739b2 .roundedBanner__9fa0a {
border-radius: 0;
}
/* Following hopefully fixes decorations */
.userPopoutOuter_d739b2 .avatarDecorationHint__03e0b {
height: 340px;
width: 100%;
}
.userPopoutOuter_d739b2 .avatarDecoration_ae35e3,
.userPopoutOuter_d739b2 .bannerSVGWrapper__3e7b0 mask {
display: none;
}
that built fine
dusky sonnet
also the patch seems broken
oh wait
maybe i shouldnt just blindly copy regex lmao
wow as long as i run my own dev build i can pretend to be a contributor lmao
jagged cloak
well yeah xD
midnight raven
it's insane just hwo fast discord loads if you're only in a few guilds and have no friends
midnight raven
it's insane just hwo fast discord loads if you're only in a few guilds and have ...
god why are my recordings laggy
gnome pleasee
charred monolithBOT
Makes avatars take up the full width of the profile modal and renders them in higher resolution.
dusky sonnet
well then lets hope that was good enough lol
dusky sonnet
makes profile look ugly tho xd
lol that’s fair
You think I should make the theme part a toggle?
Then again the situations where you’d want this without the theme part seem very rare
jagged cloak
maybe if the profile picture was the background of the profile
but cant that just be a theme (maybe not)
the way they are top and bottom like this tho... to each their own xP
maybe im just too used to discord lol
dusky sonnet
@void echo thanks for all the input :D
void echo
Nws, it's nothing major and I'm sure the others will have stuff to say but that's some basic things
dusky sonnet
What exactly do you mean by this?
void echo
What exactly do you mean by this?
Fallbacks are basically css styles that are applied if the first one fails somehow
I'm not really familliar with how vencord deals with css so it might be just my inner web designer talking
.element {
display: -webkit-box; /* Fallback for older browsers that support only old flexbox syntax */
display: -ms-flexbox; /* Fallback for IE 10 that supports only the prefixed version of the new syntax */
display: flex; /* Newer, preferred method */
}
here's a fallback example
I'm 99% syre you're safe to ignore that haha
charred monolithBOT
void echo
Yeah it's just super basic stuff like
"what it do"
"what settings do"
"what it look like"
dusky sonnet
Yeah it's just super basic stuff like
"what it do"
"what settings do"
"what it l...
Yeah :D
sick cypress
hi how easy is it to compile and manually install vencord urself
dire trench
easy
austere talon
yes it seems x11 only, but
- is it even possible for backgrounded apps to read key strokes in wayland? I thought this was one of the big arguments for wayland
- the electron api doesn't support detecting key up/down, so PTT isn't possible
@topaz thistle
topaz thistle
xdg-dekstops approach offers a portable way for global hotkeys
topaz thistle
yes it seems x11 only, but
1) is it even possible for backgrounded apps to read ...
Hm, does official discord support Wayland?
Also discord-screenaudio uses the KDE shortcut API which is an implementation of the xdg-deaktop protocol mentioned earlier
sick cypress
is there not place to sugggest plugins anymore?
dire trench
is there not place to sugggest plugins anymore?
what ideas u got
sick cypress
topaz thistle
Also discord-screenaudio uses the KDE shortcut API which is an implementation of...
You could use a DBus library to manually use the xdg desktop approach as well
sick cypress
i know about that plugin that makes the server list wider and opens them vertically alongside the whole other bar
austere talon
misty raptor
who approves these
spark pivot
maintainers
misty raptor
is there like a team of people who just can approve them
how do some newer PRs get get approved before oldder ones
whats the process behind that
austere talon
only first time contributors need approval
misty raptor
only first time contributors need approval
i see...
whats the typical approval rate
austere talon
xdg-dekstops approach offers a portable way for global hotkeys
time for iohook fork
topaz thistle
~~time for iohook fork~~
I will probably write my own library for it for soundux
austere talon
hmm, why not base it on iohook instead? it already supports all major platforms except wayland
charred monolithBOT
austere talon
you'd just need to rewrite / extend its linux part
misty raptor
should i expect to wait up to 2 weeks for an approval or like hows the timing
austere talon
depends on a lot of factors
topaz thistle
hmm, why not base it on iohook instead? it already supports all major platforms ...
Because I don't want to take it's approach
topaz thistle
Too much to fork it
misty raptor
depends on a lot of factors
which factors are relevant rn and which factors are in my control
topaz thistle
I would majorly change the windows implementation and go the desktop portal approach for Linux
austere talon
i think discord also uses iohook
topaz thistle
Also modern C++
spark pivot
which factors are relevant rn and which factors are in my control
well patience is one
austere talon
i think discord also uses iohook
so if we were to use iohook we could probably very easily hijack discords keybind renderer code
topaz thistle
so if we were to use iohook we could probably very easily hijack discords keybin...
Hm if discord actually uses it that would probably be nice but also make a lot of Wayland users mad xd
dire trench
turns out findByProps was causing all the lag
dire trench
its called for each badge on each message 💀
dire trench
just to get the className for the badge component
austere talon
it's literally checking all exports of thousands of modules
dire trench
i froze for like 7 seconds when u sent that message
spark pivot
i froze for like 7 seconds when u sent that message
i wonder why
dire trench
i fixed it by only retrieving the class name once
spark pivot
junior olive
its called for each badge on each message 💀
why the fuck
dire trench
why the fuck
was just a prototype
what other badge sources are their?
i can think of vendetta, aliucord, and reviewdb
junior olive
vd has no badges
dire trench
vd has no badges
what are all the badges i see on profiles on vendetta from then?
junior olive
idk tbh
void echo
can someone send a message with an email in it
pls?
topaz thistle
junior olive
void echo
ooh ok
topaz thistle
This fucker is not using the cache anymore 😢
dire trench
topaz thistle
help@me.thistakessofuckinglong
dire trench
support@vencord.dev
topaz thistle
support@vencord.dev
Tell #🏥-vencord-support-🏥 to write emails instead
dire trench
idk tbh
i searched https:// in the vendetta github repo
couldnt find anything related to badges so it has to be a plugin doing it
charred monolithBOT
dire trench
or they hardcoded them
also searched badge and found nothing tho so prob not
dire trench
tf is goose mod
junior olive
or they hardcoded them
also searched `badge` and found nothing tho so prob not
ryan i developed vendetta i know there's no badges
dire trench
ryan i developed vendetta i know there's no badges
i thought they came from vendetta itself but i think they actually come from @dusk hill's badge plugin
junior olive
yeah
dusk hill
wuts this bout
dire trench
im using all the badge sources in ur plugin for my show badges in chat plugin
also tf is goose mod
frail skyBOT
limber skiff
those shc broken patches can wait to get fixed
midnight raven
so lazy xd
frail skyBOT
limber skiff
so lazy xd
not home lol
midnight raven
yea im just messing
maiden sapphire
rustic oxide
Hey, sorry if this is the wrong place, but because the Discord Blur extension got broken, I was thinking of asking for a version of BlurNSFW extension that works on all images and media. Should I make a GitHub issue for that request?
ornate herald
Question. Does vencord work on MaOS Sonoma (the new major update to MacOS)
Before someone bashes me for having a MacBook (screw off), I don’t have the money and resources to build my own PC as of yet due to sudden financial turmoil.
livid heath
vns
nimble pendantBOT
ornate herald
👉 <#1026515880080842772>
Thank you. Now delete yourself /jk
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
jagged cloak
sounds like discord
