ill give you my regex tho
#๐พ-core-development
mortal fractal
junior olive
it will i think im goood
mortal fractal
/(?<=avatarDecorationOverride:(.)}.+?void 0:(.)\.avatarDecoration,.+?)return{avatarPlaceholderSrc:.,avatarDecorationSrc:(.),isAvatarDecorationAnimating:(.),/
mortal fractal
```js
/(?<=avatarDecorationOverride:(.)}.+?void 0:(.)\.avatarDecoration,.+?)retu...
ven cringing at the fact we still use .+?
austere talon
huhh why
mortal fractal
idk i thought you were anal about it in vencord patches
austere talon
nah thats fine cause its in a lookbehind
austere talon
idk i thought you were anal about it in vencord patches
it depends on the context
mortal fractal
ah
dire trench
why use .+?
austere talon
if it can be avoided yes absolutely
but we commonly use it in lookbehinds to match variables
although we put the lookbehind BEHIND the match
it does the same thing, just more performant (usually) and easier to digest imo
junior olive
I'm gonna keep the avatarDecorationURL patch, ditch the user patching though
austere talon
it does the same thing, just more performant (usually) and easier to digest imo
cause it first matches the normal part THEN walks back
austere talon
I'm gonna keep the avatarDecorationURL patch, ditch the user patching though
uh why, shouldn't be necessary at all assuming the hook is used everywhere
junior olive
uh why, shouldn't be necessary at all assuming the hook is used everywhere
create decoration page
places where the override is used
its fine it'll work out
charred monolithBOT
About SoundBoardLogger
SoundBoardLogger is a plugin that lets you log all soundboard sounds that are played in a voice chat.
Main menu
People that played the sound
Info about a specific user
Open SoundBoard Log icon
(The user can choose where should the button to open the logs be displayed)
Toolbar button
junior olive
waht i thought it wasnt fixed
austere talon
i fixed it blud
junior olive
ok
austere talon
okay i REALLY sleep now
spark pivot
add a review comment
jagged cloak
okay i REALLY sleep now
the 67 lions are coming
27 lions sorry they multiplied for a second
wintry violet
jagged cloak
u wot
uncut glen
as i was saying we are fixing everything and we are optimizing with svgo
jagged cloak
kfc men lmao
uncut glen
kfc men lmao
i had the pfp for that acc saved on my pc and thats the name that poped up for me lol
jagged cloak
you became the very thing you swore to destroy
actions exploder
i hope there are no conflicts with me pushing this lmao
charred monolithBOT
austere talon
FUCK YOU SHITHUB WHY MAKE A BRANCH
charred monolithBOT
pine olive
Why vencord-installer isnt running
spark pivot
vns
nimble pendantBOT
jagged cloak
i used shithub editor for the first time in years <:horror:1098245658248495233>
shithub so bad
whys it showing it twice
it should just be a reply its not a separate review gh 
spark pivot
whys it showing it twice
have you tried turning it off and on again
jagged cloak
i have tried devourign a macbook
spark pivot
did you turn it on afyt eajmkarweoe
jagged cloak
whar
spark pivot
cgdhj,t, nb TURN IT ON fnewioak jm,tgwae
jagged cloak
same energy as this
spark pivot
energy? what's that
jagged cloak
in ur walls
spark pivot
can i eated it
jagged cloak
do eat drywall
spark pivot
i cant because I EATED ITN KJAEWLW>
uncut glen
all is now fixed and optimized 
jagged cloak
wait why
dire trench
dev constants conflict
cuz new plugin got merged
yeah there was definitely an easier way to do this
jagged cloak
ded link moment
dire trench
guess only i can see it
jagged cloak
yeah
conflicts redirects to pr if you dont have any
but if its not ur pr it 404s because ???
dire trench
there is no way to undo a commit from the github website
its not in their api
its just impossible
thanks microsoft
fringe eagle
created a vsc plugin that lets you create plugins
prob gonna update it soon to make it for userplugins
dire trench
had to download github desktop and clone just to revert
fringe eagle
same
austere talon
git reset --hard HEAD~1
git push --force origin yourbranch
deletes last commit
destructive
stop using shithub desktop for everything got damn
teach urself git cli basics, future you will thank you
fringe eagle
i know git cli basics
fringe eagle
most of the time it's git clone, git push, git pull, and git add .
jagged cloak
i have been learning it as needed
but most of the time its just pulling changing branch or git reset --hard lol
uncut glen
Fixed
olive aurora
i use lazygit because im lazy
its actually really good bc it doesnt abstract away what git is like gh desktop does
but lets you do lots of advanced things easily
fire
jagged cloak
peppy jumpscare
uncut glen
peppy jumpscare
AHHHH
fringe eagle
https://github.com/Vendicated/Vencord/pull/1930/conflicts
404'd
wai
FUCK
CHAT SCROLL
dire trench
uncut glen
GitHub did funny and showd the index and css files in a non existent folder๐
Had to reupload both
fringe eagle
imagine i actually contribute to Vencord (i will not because i dont have plugin ideas)
livid heath
imagine i actually contribute to Vencord (i will not because i dont have plugin ...
plugin to make discord faster
uncut glen
imagine i actually contribute to Vencord (i will not because i dont have plugin ...
I saw some1 ask a while ago if there is a way to download soundboards so I got together with 2 friends to make a soundboard logger
Just look at what ppl here are searching for and make that
fringe eagle
maybe i should find a bd plugin 5-year olds want to use in vencord and recreate it in vencord
oak hull
plugin to make discord faster
remove the discord stylesheet
it will make discord 200% faster
dire trench
web 1.0 discord
livid heath
remove all the js, will be as ffast as light
uncut glen
maybe i should find a bd plugin 5-year olds want to use in vencord and recreate ...
Just look in the support chat every day I see some1 ask if there is a bd plugin in vencord
dire trench
discord but its in vbscript
uncut glen
Just see what ppl are most looking for and make that ez
dire trench
discord.hta
zenith jackal
guys my discord is really really fast but it doesnt work help
i removed all the js and css
uncut glen
Looks good
uncut glen
What are u doing in the plugin?
fringe eagle
prob something like the 3y3 encoded profile thems
uncut glen
Oooo
dire trench
prob something like the 3y3 encoded profile thems
we got enough 3y3 shit
no more profile space
theres probably more invisible characters that can be used tho
the 3y3 chars are from 0xE0001 to 0xE007E inclusive
but those are special cuz they are invisible and zero-width
fringe eagle
i'm looking at FakeProfileThemes source
junior olive
Why did nobody tell me how powerful lookaheads are.
dire trench
i'm looking at FakeProfileThemes source
dire trench
Why did nobody tell me how powerful lookaheads are.
how do u not know about those
thats like the most useful feature of regex
u might as well not use regex
junior olive
bruh i learnt enough to make a big ass plugin
dire trench
what was ur prior experience?
dire trench
like even outside of vencord plugin development
junior olive
vendetta dev
dire trench
outside of that?
dire trench
all i know is some java ๐
the mf public static void main(String[] args)
i love java
shy veldt
i love java
horror
dire trench
58 billion soon...
junior olive
ok chat humor me
if ids is undefined, will this set the ids parameter?
I think it will
bc ids?.length will result in undefined
and undefined !== 0 = true
@austere talon this is why i had that explicit ids check
dire trench
just test in console
dire trench
if ids is null or undefined then ids?.length will be undefined
dire trench
and you are checking against 0
junior olive
mhm
dire trench
strict type
junior olive
gonna js add a ids && before it
dire trench
yeah thats the best way to do it
fringe eagle
if i add myself to the devs list when making a pr-
fringe eagle
it's okay right
dire trench
yeah thats what ur supposed to do
fringe eagle
k
junior olive
i swear to god i look at the decor plugin funny and it gains 10 lines of code
uncut glen
and i broke discor
Rip
fringe eagle
cause i didnโt pnpm install
uncut glen
Oh lol
fringe eagle
just added a 3y3 command for looking at this
but i forgot to change it to content
i mean
the 3y3
cause this happens
rare shale
i will explod gradle
cunning canyon
ven ancient pfp
fringe eagle
wow an issue
charred monolithBOT
browser : chrome dev 121.0.6103.3
extensions : a lot
steep burrow
wow an issue
yessir
I'm the bug reporter ๐ซก
umbral hedge
austere talon
<@343383572805058560> this is why i had that explicit ids check
yes. I already said that
but that only applies to !==, not ===
crude raptor
stupendous
livid heath
doesnt look like vencord issue
nimble plaza
yeah
dusky sonnet
when the bug starts with logitech
steep burrow
well
as I said, I tried to disable the themes BUT it changed nothing
charred monolithBOT
steep burrow
well
as I said, I tried to disable the themes BUT it changed nothing
proof
dapper crest
junior olive
but that only applies to !==, not ===
guhh
livid heath
๐ <#1026515880080842772>
make it so that venbot pings the replied user
ocean garden
Hey, if I edit a message's content in MessageStore after it's loaded into the UI (I'm using a flux handler for CHANNEL_SELECT to do this), is there a way to trigger a refresh afterwards so that the updated message shows up on the UI? I tried dispatching a MESSAGE_UPDATE flux dispatch on the message but I didn't see any change immediately until I switched to another channel and came back.
pseudocode of what I'm trying to achieve
async CHANNEL_SELECT({ guildId, channelId }) {
let messages = MessageStore.getMessages(channelId)._array;
messages.forEach(async (m: MessageObject) => {
if (m && meetsCondition(m.content))) {
m.content = modifyMessage(m.content);
await FluxDispatcher.dispatch({ type: "SOME_EVENT", message: m });
}});
ocean garden
No it's not possible to patch message content on UI like fakenitro does it because I need to call an async function there and I learned yesterday that there is no way to get a return value from an async function in a sync function.
charred monolithBOT
limpid badger
huh?
nimble plaza
read the commit name
void echo
How can I verify that the user has nitro before applying a patch?
verbal pumice
you probably cant
void echo
ah
verbal pumice
you'll probably need to check at runtime
void echo
yeah
verbal pumice
you probably cant
you cant unless the module is lazy loaded*
void echo
non nitro users who use SuperReactionTweaks are getting this
if then enable the always super react option
junior olive
https://cdn.discordapp.com/attachments/1026515880080842772/1172209256905330738/2...
This is why I had it default to false
limber skiff
https://cdn.discordapp.com/attachments/1026515880080842772/1172209256905330738/2...
bruh
why doesnt discord code check for it
charred monolithBOT
junior olive
but that only applies to !==, not ===
junior olive
no bc i want to check if they pass ids but it's got zero entries..
if (ids && ids.length === 0) return {};
austere talon
yes
void echo
why doesnt discord code check for it
That's what I thought too
dire trench
you can use UserStore from @webpack/common
const user = UserStore.getCurrentUser();
if (user.premiumType < 1) // Disable super reacts
they do tho
when you press the super react button
we just change the default state to true
verbal pumice
you can use `UserStore` from `@webpack/common`
```ts
const user = UserStore.getC...
..which isnt accessible at patch time
austere talon
but the state can never be true in vanilla discord if u don't have nitro
void echo
austere talon
..which isnt accessible at patch time
you can just use it inside patch
void echo
there was a guy in support complaining abt it
Idk if we should default to false though since then nothing changes by default
dire trench
couldnt you add a setting to disable it that requires restart?
junior olive
predicates are weird to me there's no indication the plugin needs restarting to patch after a setting changes
void echo
it would be nice to just be able to grey out an option that's nitro only
junior olive
u could use the disabled feature
dire trench
you could even add an if statement in the patch that uses $self to fetch a variable
default the variable to true
and in start() get the current user and set false if not nitro
austere talon
predicates are weird to me there's no indication the plugin needs restarting to ...
wdym?
it should be self explanatory to the developer
and you can mark specific settings as requiring a restart
junior olive
its fine to a dev but to a end user not
junior olive
and you can mark specific settings as requiring a restart
where
junior olive
didn't know that
void echo
I think there's some sort of conflict too
It's just outright not working for some people
junior olive
works fine for me
dire trench
how u react that fast
junior olive
shift key
void echo
@sour rain
dire trench
nah even with shift key thats too fast
void echo
has that issue
junior olive
not really
lime stone
nah even with shift key thats too fast
๐คจ
junior olive
you must have high ping
sour rain
wut
void echo
i was js mentionning u here
sour rain
wtf
void echo
wdym
sour rain
i cant do that
i have to click this button here
the add reaction button
see
when i do the other way it wont work
void echo
waht's the other waty
junior olive
oh bruh thats expected
sour rain
yall mfs are not that quick at manually clicking add reaction and selecting random emojis
void echo
you can hold shift and it keeps the react panel open
sour rain
oh rlly?
void echo
yeah
void echo
if we messed with the right click ones that would be a nightmare for non nitro users
sour rain
๐
dire trench
yeah
the nitro ad that shows when u open the reaction picker can be hidden with css
[class*=emojiPicker_] [class*=wrapper_]{display:none!important}
ok but it doesnt load anything other than the first page of emojis unless you click the x button so nvm
void echo
Should I just default it to false
or add a note saying "You need nitro for this to work"
dire trench
did u try any of what i suggested earlier?
dire trench
you could even add an if statement in the patch that uses $self to fetch a varia...
this could work
void echo
you could even add an if statement in the patch that uses $self to fetch a varia...
I havent tried this yet
im on my laptop without vscode
dire trench
ill see if it works
steep burrow
https://media.discordapp.net/attachments/787393056630112256/1139203086481641602/...
true
dire trench
I havent tried this yet
so the problem is people have superReactByDefault set to true but they dont have nitro?
shy veldt
the nitro ad that shows when u open the reaction picker can be hidden with css
`...
good point
sadly
dire trench
yeah the css isnt a solution for it
void echo
u are late to the rollout </3
shy veldt
u are late to the rollout </3
so called nitro filter rollout
charred monolithBOT
steep shore
this should be faced with a warning
so you don't accidentally press it like the dumbass that I am did
if you have one already
limpid badger
since when sort button causes the cursor to act like it's about to select an text
void echo
since when sort button causes the cursor to act like it's about to select an tex...
guys we got a zero day over here
limpid badger
welp, i think i gotta stop overlooking at small details
dire trench
since when sort button causes the cursor to act like it's about to select an tex...
what is that from?
void echo
what is that from?
plugins menu
dire trench
could easily be fixed with css then
void echo
yea but it'd need to be added to base client
dire trench
oh that plugin menu
void echo
no point making a quickcss js for that
dire trench
no point making a quickcss js for that
i think this will work
{
find: ".hasAvailableBurstCurrency)",
replacement: {
match: /(?<=\.useBurstReactionsExperiment.{0,20}useState\()!1(?=\).+?(\i===\i\.EmojiIntention\.REACTION))/,
replace: "!!Vencord.Webpack.Common.UserStore.getCurrentUser().premiumType&&$self.settings.store.superReactByDefault&&$1"
}
}
could you test it? i have nitro and i dont have any alts lmao
dire trench
i dont have nitro and the super react ad doesnt show for me
just need someone with nitro to test
lime stone
i think this will work
```ts
{
find: ".hasAvailableBurstCurrency)",
repl...
why !!
you don't ned that i don't think
:/ i prefer to do != null but javascript has multiple nulls
dire trench
why !!
premiumType can either be undefined, 1, or 2
i want it to be false if undefined and true if 1 or 2
!undefined is true
!!undefined is false
lime stone
it's redundant though
dire trench
its the shortest and best way to accomplish what i was trying to accomplish
it worked for me
lime stone
you can just remove it ๐ญ
dire trench
wdym
lime stone
i think?
lime stone
just Vencord.Webpack.Common...
shy veldt
premiumType can either be undefined, 1, or 2
i want it to be false if undefined ...
and 3
lime stone
UserStore isnt global
no, remove the !! at the front
dire trench
new nitro teir $25 per month
lime stone
there's just basic and full
dire trench
no, remove the `!!` at the front
undefined && true is undefined
lime stone
(technically you can get classic but you shouldn't)
dire trench
also null && true is null
lime stone
cold turkey
nocturne haven
i stayed away from discord for like 2 years
should've kept that
dire trench
fr
its fr just a distraction
@void echo also im pretty sure
shouldPlayBurstReaction(playingCount: number) {
if (settings.store.unlimitedSuperReactionPlaying) return true;
if (playingCount <= settings.store.superReactionPlayingLimit) return true;
return false;
}
could be replaced with:
shouldPlayBurstReaction(playingCount: number) {
return settings.store.unlimitedSuperReactionPlaying || playingCount <= settings.store.superReactionPlayingLimit;
}
u could even just put it directly in the patch
junior olive
<@145224646868860928> also im pretty sure
```ts
shouldPlayBurstReaction(playingC...
I did it like that for verbosity
junior olive
u could even just put it directly in the patch
pointless..
Would just make it more confusing
dire trench
cuz u made the variable names so long
i did that at first with my plugin and it just got so unreadable
junior olive
They're fine lol
dire trench
for example, shouldPlayBurstReaction could be changed to playSuperReaction
junior olive
it's fine as it is
Having a func that the patch just calls is way neater than putting the func in the patch
more obvious what it's deciding doing to decide to play
dire trench
in this specific case i think it could be more readable actually
dire trench
{
find: ",BURST_REACTION_EFFECT_PLAY",
replacement: {
match: /(?<=BURST_REACTION_EFFECT_PLAY:\i=>{.{50,100})(\i\(\i,\i\))>=\d+/,
replace: "!($self.settings.store.unlimitedSuperReactionPlaying||$1<=$self.settings.store.superReactionPlayingLimit)"
}
},
nah thats honestly cleaner than the function
dire trench
only made the change cuz i was already looking at the plugin to fix an issue with it
junior olive
pointless change though
dire trench
ur header doesnt give eslint error but mine does
junior olive
what
dire trench
so the super react plugins header includes names and mine doesnt
thats the only difference
but when i add my name to my plugins header, i still get the eslint error
junior olive
weird
@cunning canyon could you separate the highlighted code into a utility similar to Decor's?
or like smt, bc vesktop uses a very similar func too
dire trench
<@145224646868860928> also im pretty sure
```ts
shouldPlayBurstReaction(playingC...
also the max super reaction settings thing should just be a number input
idk why u would limit it to certain preset numbers
junior olive
it's fine bruh ๐ญ
dire trench
bro what
junior olive
i wanted a slider and the slider is a pain to use
dire trench
just make it a number input
isnt this for the users of the plugin tho?
why limit it to 5, 10, 20, 40, 60, 80, and 100
u cant even select 0
junior olive
5 = discord
20 intervals = full message of super reacts
at some point it's pointless to finely control how many can play.. just turn on unlimited
you can only hover over so many at once
add 0 sure, but the slider is fine
if the user really wants a fine grained number they can set it in the console, but for most ppl the slider is fine and provides a way nicer experience than a number box
dire trench
nah thats crazy
charred monolithBOT
dire trench
goes against every ux philosophy
junior olive
ezpz slider providing nice default numbers that work well vs clueless number box that you have to think of a number for
it is fine
just fix what u wanted to fix.. leave the rest alone it is fine :/
dire trench
imagine if the mfs who made operating systems had that same viewpoint
dire trench
did you confirm the max burst reaction thing even works?
olive aurora
ur mom is nicer
dire trench
setting it to 0 doesnt do anything
junior olive
did you confirm the max burst reaction thing even works?
yes it did when i made it
dire trench
even 0?
olive aurora
anyways if you really want you can manually set the config
dire trench
thats crazy to expect people to do that
when u can just do OptionType.NUMBER
nobody will complain about it not being a slider
but somebody will complain about it not being a number input
why limit user input when you dont have to
especially when there are no downsides to not limiting user input
olive aurora
me when i set NaN
junior olive
ryan
junior olive
ryan please js cease
junior olive
the limit does work on the version in vencord right now
ryan i do not want to use a number field nor does ant0n
leave the slider and shouldPlayBurstReaction function alone
fix the super react by default issues like you wanted to
dire trench
u crazy
charred monolithBOT
dire trench
nah thats stupid
if i wish for something bad for the users doesnt mean it will get merged
like what
junior olive
dude it is literally fine as is
dire trench
nah makes 0 sense
junior olive
fix the thing you wanted to fix
junior olive
no
livid heath
I think slider is better
junior olive
the 0 limit works fine
dire trench
i have it on 5 but none play
junior olive
just doesn't apply to the random ones
dire trench
ok 0 works i just thought it would make them default reacts
but on 5 none of them play
junior olive
5 and 10 work fine for me lol
dire trench
only like 1 plays
junior olive
ยฏ_(ใ)_/ยฏ
void echo
only like 1 plays
On 5 I got 5 to play
Thereโs also the random ones that arenโt affected
shy veldt
ermm what
jagged cloak
ermm what
woeful sable
ermm what
dire trench
On 5 I got 5 to play
Ok it works then, I just misunderstood
dire trench
@void echothis is what i got
export const settings = definePluginSettings({
superReactByDefault: {
type: OptionType.BOOLEAN,
description: "Reaction picker will default to Super Reactions",
default: true,
},
unlimitedSuperReactionPlaying: {
type: OptionType.BOOLEAN,
description: "Remove the limit on Super Reactions playing at once",
default: false,
},
superReactionPlayingLimit: {
description: "Max Super Reactions to play at once",
type: OptionType.SLIDER,
default: 20,
markers: [0, 5, 10, 20, 40, 60, 80, 100],
stickToMarkers: true,
},
}, {
superReactionPlayingLimit: {
disabled() { return this.store.unlimitedSuperReactionPlaying; },
}
});
export default definePlugin({
name: "SuperReactionTweaks",
description: "Customize the limit of Super Reactions playing at once, and super react by default",
authors: [Devs.FieryFlames, Devs.ant0n],
patches: [
{
find: ",BURST_REACTION_EFFECT_PLAY",
replacement: {
match: /(?<=BURST_REACTION_EFFECT_PLAY:\i=>{.{50,100}\i\(\i,\i\)>=)\d+/,
replace: "$self.settings.store.superReactionPlayingLimit&&!$self.settings.store.unlimitedSuperReactionPlaying"
}
},
{
find: ".hasAvailableBurstCurrency)",
replacement: {
match: /(?<=\.useBurstReactionsExperiment.{0,20}useState\()!1(?=\).+?(\i===\i\.EmojiIntention\.REACTION))/,
replace: "!!Vencord.Webpack.Common.UserStore.getCurrentUser().premiumType&&$self.settings.store.superReactByDefault&&$1"
}
}
],
settings
});
didnt include header and imports cuz discord message limit
when i set it to unlimited they dont all animate
is that how its supposed to be?
i was expecting them to all animate at once
i guess it works tho cuz when its 0 none play
and on values above 0 some will play
void echo
i was expecting them to all animate at once
No it doesn't force them, it just allows them. Often it won't go past like 10-15 anyway. I'll test this in a minute thanks
junior olive
@austere talon by the way i resolved the reviews you made
torpid thicket
so decor has been working, however I noticed that the reviewdb plugin isn't showing up in the plugins section, is this a bug?
cunning canyon
<@393694671383166998> could you separate the highlighted code into a utility sim...
done
torpid thicket
so decor has been working, however I noticed that the reviewdb plugin isn't show...
wait nvm I had not realized that reviewdb got deleted from vencord
cunning canyon
LMAO
toxic bough
Day 48439483 of asking for a free avatar decor plugin!
olive aurora
mf
junior olive
Day 48439483 of asking for a free avatar decor plugin!
we're at the final stretch
austere talon
how to make tytd a PartialObjectDeep<Message, {}>
WTF IS A TYTD
dire trench
WTF IS A TYTD
im guessing it stands for three y three
idk what d stands for
wouldve said decoded but its set to the encoded value
cant start vars with numbers so thats probably why they did that
frail sky
spark pivot
is there anyway i can change the data of a flux event that is sent to the client? like i have a message_create event that i want to change something on, can i change it before it is used by the client?
little wing
we're at the final stretch
huge
charred monolithBOT
fresh cloak
Gosh, i was looking into the global keybind api and it does not support keyup/down
implementing ptt alone would be rather involved likely requiring iohook
simple things like mute/deafen shortcuts would be easy though
austere talon
why in the world does iohook have 1k stars but only 300 monthly Downloads
and why does it require such weird dependencies
fresh cloak
No idea
After looking around that seems to be able to do it though
I'll experiment with it
austere talon
and why does it require such weird dependencies
oh it's just for downloading prebuilds
cursed
fresh cloak
If someone else can find the functions that toggle ptt that would be awesome
austere talon
it looks fine probably
austere talon
If someone else can find the functions that toggle ptt that would be awesome
likely a flux dispatch
search for
TOGGLE_PUSH
TALK_TOGGLE
fresh cloak
No idea what that means i write native code usually
austere talon
ctrl shift f in devtools
fresh cloak
But yes I'll check (somewhere)
austere talon
actually i can just check myself from phone
fresh cloak
None of the other web discords have this implemented either
austere talon
doesn't seem to be a flux event
fresh cloak
Looking at one implementation from another app it didn't look that bad
fresh cloak
doesn't seem to be a flux event
Fun
austere talon
PTT might not be possible
austere talon
no
discord desktop uses their own custom voice chat native module
discord web uses webrtc
webrtc doesn't seem to support push to talk
austere talon
oh huh
fresh cloak
Works on webcord
And in that's discord screen audio thing
And in browser normally
Of course we can do it
It's just about having a global hotkey that calls it
fresh cloak
Of course i could but i want to hold it down
junior olive
yeah
fresh cloak
And not be constantly muted
junior olive
shrug
fresh cloak
Because then people don't talk to me thinking I'm afk
junior olive
yeah was just a idea
austere talon
i never understood PTT people tbh, just single button press to toggle mute is way more convenient
fresh cloak
It's just years of muscle memory and the reason above
We can easily implement mute hotkeys with the global hotkey api
austere talon
anyway just reverse engineer to find the PTT function then
not the best guide but it works
fresh cloak
this would be so much easier if this was a native application
austere talon
no it wouldn't lmao
fresh cloak
it literally would
just IDA it ๐ญ
it's so great because there's no actual button i can search for
austere talon
just IDA it ๐ญ
that makes no sense
disassembled bytecode is more readable than human readable Javascript code that you can debug and run any scripts on?
austere talon
it's so great because there's no actual button i can search for
then just search for keywords instead using ctrl shift f
PTT
PUSH_TO_TALK
pushToTalk
or look at the event listeners for keypresses
getEventListeners(window)
fresh cloak
lol none of these keypresses have.. any letters assigned to them
ahh
you have to expand them
junior olive
@fresh cloak module 227602 may be of use
fringe eagle
anyways SOMEBODY give me a way to turn a string into a PartialObjectDeep<Message, {}>
fresh cloak
<@280664130476572673> module 227602 may be of use
sorry, one again first time diving into this, how do i look at that module?
austere talon
anyways SOMEBODY give me a way to turn a string into a PartialObjectDeep<Message...
look at other plugins
junior olive
sorry, one again first time diving into this, how do i look at that module?
wpex(227602) i believe
fresh cloak
found a handleKey function but where do i go from whatever this is
e.exports.prototype.handleKey = n("986083"),
no wait lemme just
fresh cloak
wpex(227602) i believe
no that's not real
austere talon
no that's not real
it is
Vencord.Webpack.extract(227602)
you only get the shortcut if you enable consoleshortcuts plugin
fresh cloak
so i've pretty much found what happens when you press the PTT key
[g.GlobalKeybindActions.PUSH_TO_TALK]: {
onTrigger(e, t) {
T.default.getMode(t.context) === g.InputModes.PUSH_TO_TALK && (O[g.GlobalKeybindActions.PUSH_TO_TALK].isPressed = e,
T.default.getMediaEngine().eachConnection(t=>t.setForceAudioInput(e, !1), t.context))
},
keyEvents: {
keyup: !0,
keydown: !0
},
isPressed: !1
},
now i ned to figure out what this T is
fringe eagle
somebody fill me in on this
fresh cloak
See if this was a native application i could simply be taken to the definition of T with a button press
jagged cloak
oh thats why you said ida
fresh cloak
The constructor takes me to some weird looking function
jagged cloak
its you
austere talon
it's really not, you're just having what we call a little skill issue
but you'll get there
fresh cloak
I will come to your house
fresh cloak
it's really not, you're just having what we call a little skill issue
It really is though
fresh cloak
dont worry this is just worse harmony patching (its not even close lol)
Plugin hooks are :')
Gotta regex to find your function 
jagged cloak
austere talon
hooking? 
jagged cloak
hookers? you've been at the bar too much
fresh cloak
But yeah no this is definitely worse
Hunting down one definition is like a blindfolded scavenger hunt
jagged cloak
have fun
austere talon
it really is just skill issue 
fresh cloak
Like i already found the function
jagged cloak
it is likely more than one ocurrence
fresh cloak
But it's on some mysterious T object and i have no idea where it ends. It's probably an object on an object on an object on an object
fresh cloak
Yes i know
austere talon
you just put a breakpoint and jump to the definition or even just search for the name
takes 5 seconds
fresh cloak
I already put a breakpoint but the constructor takes me God knows where
austere talon
or you literally just type findByProps("getMediaEngine") in the console
fresh cloak
that's not real i think
jagged cloak
wym
livid heath
there took me 2 seconds, its module 42887
fresh cloak
maybe part of the console shortcuts plugin
livid heath
Vencord.Webpack.findByProps
fresh cloak
please stop thinking i know anything about this stuff
i'm literally just diving in blind
thank you
livid heath
there's a first for everything
jagged cloak
u think i patch shit 
fresh cloak
if i had to write a website i'd write it in rust
that should tell you how much i know about js etc
livid heath
YES PLEASE
livid heath
rsx
fresh cloak
dom manipulation through js interop, still 5x faster than react
austere talon
banned permanently
livid heath
idk ven, rust aint all that bad for web dev
austere talon
idk ven, rust aint all that bad for web dev
it's terrible lol
jagged cloak
i almost exclusively use svelte thats it
austere talon
wasm is garbage for frontend ui
fresh cloak
mfw still faster than react
austere talon
that's just blatantly wrong lol
fresh cloak
it's not
austere talon
but react is bad anyway
livid heath
it's terrible lol
you're telling me your dont wanna write html in rust!?!??!?
fresh cloak
:)
austere talon
id rather cut my leg off
fresh cloak
rare v L
livid heath
in all fairness tho, rust ui state isn't great right now
fresh cloak
mhm
anything serious using them usually has to fork and expand
which is in turn good when those contributions make it back upstream
i.e. PopOS
austere talon
heavily using js apis like dom from wasm will always perform terribly compared to pure js
and using webgl / canvas rendering instead ruins accessibility and UX
using rust or similar for frontend is just massive cope
use svelte, it's good
livid heath
heavily using js apis like dom from wasm will always perform terribly compared t...
webgpu
webgl can krill itself
fresh cloak
real
void echo
webgl can krill itself
HEY
jagged cloak
opengl in current year is just death by the same 27 lions
void echo
its no better than it ever was
jagged cloak
for basically anything unless you want to be deemed old as fuck
i dont think it was even meant to do as much as people used it for
livid heath
heavily using js apis like dom from wasm will always perform terribly compared t...
actually there are some rust crates which create dom nodes directly instead of rendering in a canvas (which makes a11y instantly better)
but about the first statement, yeah calling js apis from wasm might be slow, but since wasm is being more adopted i assume browsers would make appropriate optimizations for it
fresh cloak
yes, it is slow
austere talon
serialisation is inherently slow
fresh cloak
that's true
it's still a very fast framework all things considered
and once wasm finally gets native dom manipilation that'll go away too
austere talon
using anything but js for frontend is delusional and has no future unless browsers add wasm bindings for dom which they'll never do or in 20 years from now
livid heath
right you have to serialize objects between wasm and js :blobpain:
just use shared memory /j
fresh cloak
i remember trying to make wasm interact with unity
i had to directly fuck with memory to pass anything more than a number around
then i said "fuck this"
livid heath
anyone using rust and wasm to do web dev is already coping so i dont think they'd care about performace that much
austere talon
i never understood why people even do it
you're literally just shooting yourself and also your users in the foot
but tbf you gotta be a masochist to even like rust
fresh cloak
i am
austere talon
fresh cloak
livid heath
they just wanted to say "we use the blazing fast ๐๐ฆ๐ rust language" 
austere talon
i never understood why people even do it
you're literally just shooting yoursel...
i tried fixing someone's compose web site once and literally wanted to kill myself
using what's essentially a wrapper instead of raw css makes everything so much harder, it's like using scratch instead of normal java
livid heath
but tbf you gotta be a masochist to even like rust
i like rust but i'm not a masochist ๐ญ
austere talon
well now you're just contradicting yourself ๐
austere talon
i never understood why people even do it
you're literally just shooting yoursel...
just try svelte/astro they're infinitely better than react
and are some of the best performing options you can get (other than just rendering everything on the server)
livid heath
i used astro for my personal website
and react for anything else
austere talon
svelte is just hot
<script>
let count = 0;
function handleClick() {
count += 1;
}
</script>
<button on:click={handleClick}>
clicks: {count}
</button>
{#if count === 727}
<p>holy shit</p>
{/if}
astro loads fast, but the 3js blob rendering in the background makes performance on mobile infinitely worse
void echo
if statements in html ๐คค
austere talon
yeah instead of using js conditionals and array map like react, in svelte you have those things in your markup
livid heath
also 727 lol
void echo
ok that's next on my list
grave mangoBOT
https://github.com/Vencord/vencord.dev/blob/main/src/components/pages/plugins/Pl...
**Plugins.svelte: **Lines 76-83
<div class="criteria">
{#each criteria as c}
<label>
<input type="checkbox" bind:checked={c.state} />
{c.name}
</label>
{/each}
</div>
taking notes for my rust gui crate 
austere talon
NO
livid heath
its native gui
void echo
it looks too good to be true whats the catch
livid heath
wasm support is just more work
fresh cloak
rust native gui can look nice
jagged cloak
also 727 lol
lol wysi lol lmao
austere talon
yeah instead of using js conditionals and array map like react, in svelte you ha...
and it has inbuilt animations/transitions and use: which lets u run code on nodes it's applied to whenever they render / are updated
https://github.com/Vencord/vencord.dev/blob/main/src/components/pages/plugins/Plugins.svelte#L53-L68
grave mangoBOT
and it has inbuilt animations/transitions and `use:` which lets u run code on no...
**Plugins.svelte: **Lines 121-126
<p
use:overflowTooltips={p}
class="description ellipsis-overflow"
>
{@html highlightMatches(p.description)}
</p>
**Plugins.svelte: **Lines 53-68
function overflowTooltips(node: HTMLElement, _: PluginData) {
const applyTitle = () => {
const hasOverflow =
node.scrollWidth > node.clientWidth ||
(!node.classList.contains("author") &&
node.scrollHeight > node.clientHeight);
node.title = hasOverflow ? node.textContent! : "";
};
applyTitle();
return {
update() {
applyTitle();
},
};
okay ill stop shilling svelte now sorry
junior olive
i like react and jsx
fresh cloak
what the FUCK is a Set
austere talon
HashSet
junior olive
I LOVE SetS
austere talon
it's a HashSet
void echo
is SolidJS any good
livid heath
.get
void echo
or
jagged cloak
i tried fixing someone's compose web site once and literally wanted to kill myse...
was it zt/xinto lol
austere talon
[...set] gives you a plain array
fresh cloak
i have
austere talon
was it zt/xinto lol
zt
fresh cloak
[...set] gives you a plain array
where do i put this
austere talon
or just use set.forEach(v => {})
livid heath
oh right .get is for maps
junior olive
ven
fresh cloak
i swear to god the forEach loop was not working earlier
ahh i've found something much better i htink
findByProps("getMediaEngine").getMediaEngine().connections.forEach(v => {
v.input.setPTTActive(false)
})
cool
this works
now to look at iohook
limber skiff
what does ptt mean
limber skiff
oh
fresh cloak
it's annoying, electron has an api for global hotkeys
which is great for mute/deafen toggles
but it doesn't support keyup/down
so now i have to work around that
Why does js do weird shit like setting this to a random variable in scope while intermittently using both this and the new variable
Just seems like.. random waste
livid heath
huh
fresh cloak
Yeah
livid heath
wdym random variable in scope
fresh cloak
It was using this a lot
livid heath
this has a very well defined meaning
fresh cloak
I notice that input was on a variable r
livid heath
well it is how it is
fresh cloak
That's literally an expansion, adding an extra assignment
And useless if you're using this most of the time anyways
livid heath
this.someMethod(this.someProp, this.otherProp) vs r = this; r.someMethod(r.someProp, r.otherProp)
fresh cloak
Unless the browser figured out that r is this except in that one occasion
And then shows me this instead of r?
No idea
Either way I'm happy i finally found it
It's fun stepping into things you know nothing about and learning
fresh cloak
Wha
What do you mean
Oh
Idk bro I'm just talking about the code i looked at to find the function
Complain to discord
fresh cloak
iohook doesn't work on node15
fresh cloak
there's a different one but it wont build