#πŸ‘Ύ-core-development

1 messages Β· Page 127 of 1

junior olive
#

why do so many people use discord on web i don't get it

austere talon
#
  • vesktop is fire
junior olive
#

not vesktop like in browser discord

#

strange imo

placid wave
#

because theyre deranged

hazy kindle
#

maybe css flexbox order

placid wave
#

idfk

#

@austere talon

#

@austere talon

#

@austere talon

#

do you know

#

does appimager auto update

austere talon
#

Links & Images (Copy/Open Link/Image), Text Area (Copy, Cut, Paste, SpellCheck)

#

all these context menus don't exist on web - the plugin adds them back

junior olive
#

@austere talon not to be impatient but please could you hop on decor review soon it's been 2 weeks since it's been ready

#

i didnt meanto send like that but wtvr

placid wave
#

true you will review that

#

soon

#

true

#

flatpak sooooon

austere talon
#

oh

#

no it doesnt

placid wave
#

you will wrap in appimageupdater

austere talon
#

cause you'd need to use this insane shit https://www.npmjs.com/package/electron-updater

placid wave
#

does exe auto update

#

like

#

windows vesktop

austere talon
#

no

placid wave
#

oh lol

austere talon
#

and didnt find it useful enough to warrant it

olive aurora
#

appimage horror

austere talon
#

ig we could just add it back maybe

#

but eh

placid wave
#

add because windows users are incredibly lazy and will never update

#

then they will @austere talon @austere talon in support 300000 times why it doesnt work

austere talon
#

true but 200kb bloat is insane

olive aurora
#

electron

austere talon
#
#

so bloat

placid wave
#

also btw

austere talon
#

why do you need 100kb to parse a version string

placid wave
#

can you make this upload artifacts

austere talon
#

pr

placid wave
#

guhhhh ci explode

#

no

hazy kindle
#

do 200kb really matter when dc rushes to eat 1gb of ram?

placid wave
#

working on ci is miserable

olive aurora
#

const semver = (s) => s.split(".")

charred monolithBOT
long stream
crude raptor
#

hm,,, i found a good stackexchange page with a solution to flipping 2 things in a list...
but.. only some of the fields are updating when things get swapped...

#

only the tickboxes..

austere talon
#

why tf does vencord not have react eslint setup

#

i will add

junior olive
#

:/

crude raptor
austere talon
dire trench
#

why do switches not toggle

crude raptor
#

i don't think it actually a list

#

just a- array that im misnaming

placid wave
#

vencord switch component hurts me

#

i hate

#

incorrect animation

austere talon
#

whar

placid wave
#

doesnt do the click animation thing

#

sinc its fake

#

i get it renders faster but guhhh ugly

#

wait

#

now it doesnt

#

guess you fixed it

#

nvm

#

the ones in plugins still do it

dire trench
#

im not spam clicking it btw

crude raptor
#

i guess... the switches have checked just be a pointer to the value of the bool it wants but... textinputs store their own text and then update the variable when changed- so i need a way to work backwards??

hazy kindle
# dire trench

have to give it credit for trying really hard to toggle

placid wave
#

i know i realized its only the plugin cards now

hazy kindle
dire trench
#
return (
    <Switch
        value={false}
        title={"TITLE"}
        note={"NOTE"}
        onChange={(value: boolean): void => {
            console.log("Switch changed to " + value.toString());
        }}
    >
        {"TEST"}
    </Switch>
);
austere talon
#

how do you expect that to work

#

you need to pass a state as value

#

and set it in onChange

dire trench
#

really??

#

i thought that would be built in

austere talon
#

yes wtfhamster

crude raptor
#

yall this is probably horrendous practise but at this point i just wanna get this functioning so someone who knows what they're doing can fix it- how can i force this... jsx element.. thing? that im returning, to rebuild itself

austere talon
#
const [enabled, setEnabled] = useState(false)

<Switch value={enabled} onChange={setEnabled}  />
crude raptor
crude raptor
#

you wil lcry

dire trench
#

possibly

crude raptor
#

also idk which part i'd need to show

woeful sable
#

sry

hazy kindle
crude raptor
#

what

#

oh damit i keep using l;ist and array interchangeably

#

the react component (???) seems to rebuild itself when the array changes size, but i want to rebuild it manually

dire trench
#

yeah thats why i was confused about the switch

#

i thought it was only rendered once when it was returned

crude raptor
#

terrible practise im CERTAIN but also i just wanna finish this

hazy kindle
#

want to rebuild it manually
why?

crude raptor
#

because iiiii don't know how else to achieve what i want lol

hazy kindle
#

(
btw the answer to this q was: you are showing all the steps in replacement-processing the test string. Which is v cool πŸ™‚

also confusing at first: you used dice unicodes as a hack

crude raptor
#

yeah!

#

i think i could actually drop them whenever the multitudes of changes im hoping for are finished, but it works for now!

hazy kindle
#

(
bit more of the layout/ screen real estate bikeshedding:
since you use a 2 line layout now, you could move the β€œguard field” (3rd field) to the upper line

crude raptor
#

idk- anyway how do i rebuild the component or whatever

hazy kindle
#

you should prbly show code

charred monolithBOT
crude raptor
#

the nbewest comment

#

(also this is a pr to a fork which is why there was no popup here or whatever)

dire trench
#

ik you didnt write this part but this is just lazy and bad practice

#

so many extra itterations when you could have just done a for loop πŸ’€

turbid hatch
crude raptor
#

for the love of all that is holy please fix everything about this plugin

dire trench
#

this was autumnvn right?

crude raptor
#

uh i think so- i wanna say there were 2 devs attributes before i showed up

#

well they still are lol

#

just check the bottom IG

#

one of them

dire trench
#

someone did the same thing with fakeprofilethemes

#

gimsuy

turbid hatch
#

the flags

dire trench
#

this is what js does to a mf

#

.map().filter().map().join()

#

just use a for loop πŸ’€

austere talon
#

nop

#

loops suck

dire trench
#

its more performant

austere talon
#

it doesnt matter

dire trench
#

only 1 iteration

crude raptor
#

im so glad you're distracted by this and not my god awful component

dire trench
#

wdym performance doesnt matter?

austere talon
#

it doesnt

dire trench
#

that function runs like 20 times when you view someones profile btw

austere talon
#

it does not matter

#

when your code completes in 0.004ms instead of 0.008ms bigbrain

#

it literally does not matter

dire trench
#

still bad practice

austere talon
#

no

#

bad practice is trying too hard to write "performant" code

dire trench
#

when taken too far yes

austere talon
#

write readable clean code

then later if there are performance issues, figure out why and fix those specific things

dire trench
#

but them same thing could have been easily done with a foor loop

turbid hatch
#

if your code optimization ends up making it unmaintainable and you're not in a performance-relevant scenario what's the point

crude raptor
#

you're all missing the absolutely unreadable* chaos that is further down the file lmao

dire trench
#

true but in that specific situation it could have been done easily while making it maintainable

austere talon
#

like i said it literally does not matter

dire trench
#

ok whatever i just enjoy making it performant

#

makes me happy

crude raptor
#

do it

dire trench
#

after i add this feature to my plugin ill look

crude raptor
#

you will cry

austere talon
#

v8 is very good at JIT

charred monolithBOT
austere talon
#

chances are, the .map().filter().map().join() might be faster because it's predictable so v8 compiles it better

#

always write ur code as readable and maintainable as possible. optimisation should only be a second thought - or if it ever ends up performing poorly: use proper tools to debug what exactly performs poorly and specifically optimise those parts

tame escarp
#

i love chaining a bunch of random array functions personally

#

its like functional programming except for insane people

austere talon
#

i love array method chaining

charred monolithBOT
tame escarp
#

javascript should get pipe operator and take advantage of it

#
[1, 2, 3]
|> contains(2)
|> map(v => v + 1)
#

would be fire

austere talon
#

malware

tame escarp
#

gleam reference

austere talon
#

wtf is contains(2) supposed to do

tame escarp
#

filter out everything that doesnt contain 2 (???)

#

actually i have literally no idea what i was cooking there

#

u get what i mean though

#

at least as syntax sugar over chaining i think it might look nice idk

austere talon
#

thats just worse

#

you replace . with |>

limber skiff
#

how is that better than
[1, 2, 3]
.contains(2)
.map(...)

austere talon
#

js already has pipe operator πŸ”₯:

thing
.  filter()
.  map()
turbid hatch
#

because that's not how the pipe operator is meant to work

#

:P

limber skiff
#

lmao

turbid hatch
#

the pipe operator is meant to replace the first argument of the function with the previous value

austere talon
#

yeah it's more a replacement for deeply(nested(function(calls))))

turbid hatch
#

yes

limber skiff
#

now that makes more sense

turbid hatch
#
function pipeable(something, anotherThing) {
    do(something, with(anotherThing));
}

thing |> pipeable("abc"); // pipeable(thing, "abc");
tame escarp
#

okay but it COULD be a replacement for my case too πŸ™„πŸ™„πŸ™„πŸ™„πŸ™„

turbid hatch
#

but yeah it's like what ven said

turbid hatch
#

its mainly to replace nesting functions with that

austere talon
crude raptor
#

im so lost

austere talon
#

i thought it would just support 1 param funcs

turbid hatch
#

it does that too

#
thing
|> deeply()
|> nested()
|> function_()
|> calls()
turbid hatch
turbid hatch
#

invert the pipeline

austere talon
#

yes

turbid hatch
#
thing
|> calls()
|> function_()
|> nested()
|> deeply()
austere talon
turbid hatch
#

thats elixir style piping

#

which is my favourite

#
"Elixir rocks" |> String.upcase() |> String.split()
["ELIXIR", "ROCKS"]
#
"elixir" |> String.ends_with?("ixir")
true
junior olive
#

piping seems cool

austere talon
#

how do you have multiple values in the pipeline

turbid hatch
#

brackets are optional in elixir so

#
"Elixir rocks" |> String.upcase |> String.split
["ELIXIR", "ROCKS"]
#

also works in a pipeline

turbid hatch
austere talon
#

so bad

turbid hatch
#

that is

#

a violation of the FP principle

austere talon
#

:(

turbid hatch
#

you work on one value in a pipeline silly

austere talon
#

:((

#

i work on two values...

turbid hatch
#

then pass it as one

#

silly

#
["ELIXIR", "ROCKS"] |> something |> that |> Means.something
austere talon
#

:(

junior olive
#

that's kinda husk

turbid hatch
#

okay think about it this way

charred monolithBOT
turbid hatch
#

how do you operate on two values in a single argument

junior olive
#

it makes sense it's just husk

turbid hatch
#

also i wish js let you do ? and ! in function names but i know that wont be possible due to the null coalescing operators

charred monolithBOT
#
[Vencord/Vesktop] New tag created: v0.4.3
hazy kindle
charred monolithBOT
austere talon
#

seems to work fine

charred monolithBOT
austere talon
slate spade
charred monolithBOT
austere talon
#

insane @placid wave

#

it doesnt only apply to AppImage

#

it doesnt even seem necessary

#

are u sure it is

olive aurora
#

its necessary as a stupid fix for permissions

#

you should fix perms so sandbox works instead

charred monolithBOT
placid wave
#

okay so

charred monolithBOT
placid wave
#

@austere talon stop

#

I applied it wrong lmao

#

you're only supposed to apply it to appimage target

austere talon
#

fix

placid wave
#

in the json

#

guhhh don't publish new build yet

#

I will fix in a few minutes

austere talon
#

works on my machine

#

even without the fix

austere talon
placid wave
#

idk I'll see

austere talon
#

test without fix first

placid wave
#

I will do

olive aurora
#

if its 0755 it explod

placid wave
#

@austere talon

#

doesnt work

placid wave
austere talon
#

okay then add fix properly

placid wave
#

i will

austere talon
#

anyway uh

#

it will run without sandbox on many machines where it doesnt need to

placid wave
#

i knwo i will add fix correctly

#

now

#

wait a bit

olive aurora
#

why does sandbox not work then

#

cuz disabling it is kinda bleh

placid wave
#

its broken if in appimage & that kernel option is off

austere talon
#

but it told me its off

placid wave
#

idk its a known thing according to appimage docs

#

that if that option is off and ur using appimage it will break on many platforms

#

fedora has weird selinux shit maybe that fixed it

#

idk

#

aactually i dont think workstation uses selinux

austere talon
#

nvm just borked?

placid wave
#

Whar.

austere talon
placid wave
#

kernel version?

austere talon
#

i didnt even know

#

horror

placid wave
#

what the fuck lmaoo

austere talon
#

Linux vendingmachine 6.5.8-200.fc38.x86_64 #1 SMP PREEMPT_DYNAMIC Fri Oct 20 15:53:48 UTC 2023 x86_64 GNU/Linux

#

anyway just pr fixed

#

and i will test

placid wave
#

i think i need to fork this package

olive aurora
#

πŸ₯°

#

isn that option like v unsafe

placid wave
austere talon
#

From Linux 5.10, all users are allowed to create user namespaces by default. This will allow programs such as web browsers and container managers to create more restricted sandboxes for untrusted or less-trusted code, without the need to run as root or to use a setuid-root helper.

placid wave
#

deck is a modern version tho what

#

also it doesnt exactly complain because of that

#

its some weird ass zygote error

#

lemme check smth

austere talon
#

The previous Debian default was to restrict this feature to processes running as root, because it exposed more security issues in the kernel. However, as the implementation of this feature has matured, we are now confident that the risk of enabling it is outweighed by the security benefits it provides.

#

maybe steam deliberately enabled it

placid wave
#

disabled

#

mayb

olive aurora
#

why appimage anyway

placid wave
#

deck doesnt have that thing

#

what

olive aurora
#

doesnt deck use pacman

austere talon
#

Note that various desktop and container features will not work with this restriction in place, including web browsers, WebKitGTK, Flatpak and GNOME thumbnailing.

#

uh what?

placid wave
#

to build the system yes

#

user cant use it sanely

austere talon
#

so this is just AppImage insanity

placid wave
#

because ro rootfs

placid wave
#

crapimage

olive aurora
placid wave
#

@austere talon

#

[9947:1031/192108.594014:FATAL:zygote_host_impl_linux.cc(201)] Check failed: . : Invalid argument (22)

#

this

olive aurora
#

does flatpak work

#

we will

placid wave
#

only happens in game mode and doesnt happen with nosandbox

placid wave
austere talon
#

so its unrelated

#

just need to disable sandbox

placid wave
#

wdym unrelated

austere talon
#

can u try smth different

placid wave
#

YES THATS WHAT THIS PACKAGE DOES BRUH

#

try what

#

lemme see where this comes from

austere talon
#
if (isDeckGameMode) app.commandLine.appendSwitch("--no-sandbox");

#

put this below src/main/mainWindow.ts line 30

placid wave
#

ive tried this but ok

#

maybe i forgot the --

#

what do you mean line 30

#

thats in the middle of imports

#

lmao

austere talon
#

index.ts

#

not mainWin

placid wave
#

bruh

austere talon
placid wave
#

gotta wait for it to reboot

#

that zygote error borks steam really badly

charred monolithBOT
olive aurora
#

the only mention of this error i can find is on some google groups page where a guy compiled their chrome on another server and didnt copy all files

#

fire

charred monolithBOT
placid wave
#

@austere talon

#

doesnt work

#

needs to be done pre-launch

#

i can just modify that package to make it a steamos only thing

austere talon
#

don't fork

#

just make it a script in scripts/ folder

placid wave
#

good

olive aurora
#

Merlin May 9, 2023, 5:40:25β€―PM
to Chromium-dev
I've just compiled Chromium on Arch Linux on a VPS. My local machine is on the same distro and they both are up to date.

I then downloaded out/build1/chrome onto my local machine and ran it. A few times it threw exceptions, which I dealt with downloading some files from the "out" directory onto my local machine. However, eventually I got into this one which I haven't been able to resolve thus far:

./my_chromium

[229623:229623:0509/140628.363314:FATAL:zygote_host_impl_linux.cc(201)] Check failed: . : No such file or directory (2)
zsh: trace trap (core dumped) ./my_chromium

If I use --no-sandbox flag it won't resolve the error but will make it a slightly more different:

./my_chromium --no-sandbox
zsh: trace trap (core dumped) ./my_chromium --no-sandbox

--no-zygote-sandbox -- the same as the 1st error

What's the matter? How to fix this?

placid wave
#

different error

#

same line

olive aurora
#

this is the only mention of the error like ever

#

fire

austere talon
#

you love

charred monolithBOT
placid wave
#

almost got it

placid wave
#

we ball

#

it works

#

pr incoming

#

@austere talon love

#

only applies in game mode since desktop doesnt need it i think

olive aurora
#

huh so the setuid flag is basically how sudo works

placid wave
#

lemme make sure

olive aurora
#

@austere talon i will riir doas and make it epic and super safe

placid wave
#

do not

#

is riir reimplement in rust

olive aurora
#

rewrite it in rust

#

ys

placid wave
#

HELP

#

@austere talon

#

MY DECK WENT CREEPYPASTA MODE

#

HELP

olive aurora
#

mb

placid wave
#

WHY IS IT SO SATURATED

austere talon
#

duh

#

setuid is funny

austere talon
charred monolithBOT
placid wave
#

@austere talonpr made

#

merge NOW

#

(test first)

austere talon
#

did u even test the code

placid wave
#

i did

#

it works for me

#

u test too

austere talon
#

oh you just dont use the broekn function lmao

#

i was saying cause u dont import chalk

#
const log = (message, dotFormatting = chalk.blue) => {
    console.log(`  ${dotFormatting("β€’")} ${message}`);
};
#

this func is unused

#

hop off

placid wave
#

oh good

#

i will do

#

did

austere talon
#

didnt u wanna only make it do it for AppImage

placid wave
#

doesnt matter

austere talon
#

it does

placid wave
#

it only applies to game mode anyway

austere talon
#

cause it breaks aur package

placid wave
#

it shouldnt break aur package guhhh ill fix tho

austere talon
#

cause now you need to copy both .bin and normal binary

placid wave
#

@austere talon

#

do u build appimage seperately

#

or all at once

austere talon
#

all at once

placid wave
#

because i dont think i can do it all at once bruhh

#

hm

austere talon
#

can u put it here

#

in here

#

or does that not work

placid wave
#

whats aur package target

austere talon
#

dir

placid wave
#

its just dir?

austere talon
#

yes

#

"package:dir": "pnpm build && electron-builder --dir",

placid wave
#

oh i meant

#

do you biild appimage at the same time as

#

non appimage

#

or do you do them in seperate commands

austere talon
#

yes

#

actually idk lol

placid wave
#

what lmao

austere talon
#

its a github action that does it

placid wave
austere talon
#
jobs:
    release:
        runs-on: ${{ matrix.os }}

        strategy:
            matrix:
                os: [macos-latest, ubuntu-latest, windows-latest]

        steps:
            - name: Check out Git repository
              uses: actions/checkout@v3

            - uses: actions/setup-node@v3
              with:
                  node-version: 18

            - name: Run Electron Builder
              uses: samuelmeuli/action-electron-builder@e4b12cd06ddf023422f1ac4e39632bd76f6e6928
              with:
                  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
                  RELEASE: true

#

idk how it works

#

dont care either

#

it works perfectly

#

i think electron-builder does most things

placid wave
#

this is programmed insanely

#

im looking at it

#

it just runs yarn run and shit

austere talon
#

right its so little code lol

placid wave
#

fuckin

austere talon
#

i just copy pasted this from some other repo lol

placid wave
#

it is all at once

#

god damnit

#

give me a bit

#

WHY DID THEY DO IT THIS WAY

#

GUIHHHH

charred monolithBOT
placid wave
#

@austere talonoh my god i found a way

#

monkeypatching target.build in the hook to be able to apply the script for appimage and then undo it after

#

this is cursed but it works

#

it doesnt change the run behaivour at all i just need it to detect when it starts/ends appimage build

charred monolithBOT
#

Do I have to install pnpm? Kinda goes back to messing with installing things that will get wiped

cd Vesktop
pnpm i
pnpm package
Cloning into 'Vesktop'...
remote: Enumerating objects: 1623, done.
remote: Counting objects: 100% (788/788), done.
remote: Compressing objects: 100% (263/263), done.
remote: Total 1623 (delta 660), reused 574 (delta 524), pack-reused 835
Receiving objects: 100% (1623/1623), 694.30 KiB | 10.06 MiB/s, done.
Resolving deltas: 100% (996/996), done.
bas...
placid wave
#

theres no other way

#

cuz electron-builder devs hardcode too much shit

austere talon
#

need it to detect when it starts/ends appimage build
does electron builder not have events

placid wave
#

no

#

lmao

#

it has events but

#

none for this

#

that im aware of atleast

#

wait

#

maybe

#

hold on

austere talon
placid wave
#

we will explode them soon

#

OH MY GOD WHY

#

WHAT

#

UNDOCUMENTED HOOK FOR THIS

#

WHY

#

ELECTRON BUILDER DEVS WILL EXPLODE NOW

#

oh its documented but

#

super badly

#

guhhhhhhhhhhh STOP BEING SO INSANE I HATE ELECTRON BUILD<ER

#

EDPLODE

junior olive
#

electron builder docs suck hard

austere talon
#

no its amazing tbh

#

just doccer not the best

junior olive
#

i said docs..

austere talon
#

oh

#

i cant read

junior olive
#

on that note did you see my message earlierrr

charred monolithBOT
placid wave
#

@austere talonlovee

#

they have to be seperate js files so i have to do funny shit to pass data between them

#

no more monkeypatch tho

charred monolithBOT
placid wave
#

@austere talon im gonna explode

#

this doesnt work because IT BUILDS ALL TARGETS AT ONCE

charred monolithBOT
placid wave
#

actually idea 2s

#

it does all platforms at once

#

not all targetrs

#

i think

austere talon
#

it dont

#

it does targets

#

it builds all targets for current platform

#

uhh

#

AppImage is just an archive right

#

could you patch the AppImage afterwards

placid wave
#

its hell to do that

#

i think i have smth working

#

doesnt help electron builder takes 7 business days to create tar archive

olive aurora
#

brainrot has consumed me error: could not find `Cargo.toml` in `/home/rini/git/ventop` or any parent directory

placid wave
#

why is it taking so long

olive aurora
#
β”Œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”
β”‚ New version of electron-builder available! β”‚
β”‚ Current Version: 24.6.3                    β”‚
β”‚ Latest Version: 24.6.4                     β”‚
β””β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”˜
placid wave
placid wave
#

this is insane

olive aurora
#

electron builder so slowww

#

β¨― to build rpm, executable rpmbuild is required, please install: sudo apt-get install rpm

#

VIRUS

charred monolithBOT
olive aurora
#

appimages are the .exes of executables

placid wave
#

i have no idea how to do this

olive aurora
#

i think its fucked up windows' executable format is just called executable

placid wave
#

i know how to do it

#

theres no other way

#

youre gonna hate me for this

olive aurora
#

also electron builder just crashed for me

#

skull

charred monolithBOT
olive aurora
#

7z can unpack appimages

#

kinda fire

placid wave
#

they can also unpack themselves

olive aurora
#

wait what

austere talon
#

yeah its a flag lol

#

./Vesktop.AppImage --appimage-extract

olive aurora
#

lmao ? ?

#

but i mean u could use 7z to modify the appimage

#

people without 7z will simply explod

placid wave
#

why is this so slow to compress

#

horror

austere talon
#

dont decompress

#

u can edit in place probably?

#

or return to monkey(patch)

olive aurora
#

7z

austere talon
#

yop 7z will become a build dep soon

junior olive
#

this sounds like a lot of work for deck support

placid wave
#

@austere talonLMAO

#

deranged monkeypatch

#

works

#

perfectly

#
❯ pnpm run package --linux appimage

> VencordDesktop@0.4.3 package /home/aa/repos/Vesktop
> pnpm build && electron-builder "--linux" "appimage"


> VencordDesktop@0.4.3 build /home/aa/repos/Vesktop
> tsx scripts/build/build.mts

  β€’ electron-builder  version=24.6.4 os=6.5.5-zen1-1-zen
  β€’ loaded configuration  file=package.json ("build" field)
  β€’ description is missed in the package.json  appPackageFile=/home/aa/repos/Vesktop/package.json
  β€’ writing effective config  file=dist/builder-effective-config.yaml
  β€’ packaging       platform=linux arch=x64 electron=27.0.0 appOutDir=dist/linux-unpacked
ran afterPack hook /home/aa/repos/Vesktop/dist/linux-unpacked vencorddesktop
patched target
got build args [ '/home/aa/repos/Vesktop/dist/linux-unpacked', 1 ]
copying to apply appimage fix /home/aa/repos/Vesktop/dist/linux-unpacked /home/aa/repos/Vesktop/dist/linux-unpacked-appimage-1-fix
copied
  β€’ building        target=AppImage arch=x64 file=dist/Vesktop-0.4.3.AppImage
  β€’ default Electron icon is used  reason=application icon is not set
build ret
cleaning up
charred monolithBOT
placid wave
#

okay

#

this code is

#

deranged

#

however

#

it works

placid wave
#

lemme test on console rq

placid wave
#

can my deck stop janking out please

#

and actually launch the appimage

olive aurora
#

stablest steamos

#

if steamos is so good why doesnt valve make a 3.0

frail skyBOT
#
Bad Patches

NoTrack (found no module):
ID: -
Match: window.DiscordSentry=

Bad Starts

None

Discord Errors

None

olive aurora
#

Holy Hell they can count to three

crude raptor
#

oh FUCK

frail skyBOT
#
Bad Patches

ViewIcons (had no effect):
ID: 763866
Match: /\{src:(\i)(?=,avatarDecoration)/

MessageDecorationsAPI (had no effect):
ID: 93332
Match: /currentUserIsPremium:.{0,70}{children:\i(?=}\))/

ShowMeYourName (had no effect):
ID: 93332
Match: /(?<=onContextMenu:\i,children:).*?\}/

NoTrack (found no module):
ID: -
Match: window.DiscordSentry=

Bad Starts

None

Discord Errors

None

crude raptor
#

what do these things mean

limber skiff
#

means our shit broke

olive aurora
#

nooooooooooooooo not smyn

charred monolithBOT
austere talon
#

oh wait

limber skiff
#

the bump right after things break

#

this is so sad

austere talon
#

well they're canary

#

well too late to cancel xd

dire trench
#

how do i set a settings name instead of it being autogenerated from the variable name

austere talon
#

you cant

placid wave
#

guhhhhhh almost done getting this working

#

its being slightly goofy

austere talon
#

message decors is the worst one but eh

#

chrome users will wait

dire trench
#

so there just isnt a way to get a space inbetween Hide and 3y3?

charred monolithBOT
dire trench
#

not another db plugin husk

#

why should we have to trust another person
i dont see why usrbg couldnt just add that as a feature

placid wave
#

aight

#

works

#

testing now

cunning canyon
austere talon
#

should work

dire trench
gritty iris
placid wave
#

have fun understanding this

gritty iris
#

I just simplified and fixed it

austere talon
#

omg what is that

#

monster code

placid wave
#

truly

#

theres no other way

placid wave
#

the events suck because you can only have async handlers

#

so while you start modifying one of the targets it starts building other targets on top of it

#

sanely designed build tool

austere talon
#

isnt it supposed to log

#

oh

#

checkout failed

placid wave
#

LMAO

#

nice one

crude raptor
austere talon
#

yop works

placid wave
#

incredible

cunning canyon
crude raptor
#

wonderful, how many times did you cry

austere talon
#

you are insane

#

well noone will ever look at that

crude raptor
#

idk i have like- 5 layers of divs just to position things iirc

#

i would call my textreplace PR a gold plated turd

#

it looks very nice on the outside

thats about it

placid wave
#

i can fix if you want

austere talon
#

i did

charred monolithBOT
#
[Vencord/Vesktop] New tag created: v0.4.3
placid wave
#

good

#

0.4.3 real edition

crude raptor
#

lmao

austere talon
#

help why my vesktop broken @placid wave

placid wave
#

NO

charred monolithBOT
crude raptor
#

i forgot there were 2 repos

#

vencord and vesktop

placid wave
#

how to get people to stop pinging you: just nickname someone else to vendicated

austere talon
#

vesktop dont launch?? it say "native java erro: SteamerOs is not defined"

placid wave
#

true

austere talon
placid wave
#

@crude hearth fix this

#

you are java

austere talon
#

you dont wannaknow how often people say java error

#

its so funny

placid wave
#

LMAO

#

java error

charred monolithBOT
austere talon
#

amazing

charred monolithBOT
austere talon
#
if (IS_NSIS || IS_APPIMAGE) require("electron-updater").init()
#

so u dont bundle 200kb useless code on non updatable targets

olive aurora
#

cant u do two esbuilds

austere talon
#

wait

#

can we use this

olive aurora
#

squirrel jumpscare

austere talon
#

oh squirrel

#

so bad

#

aww no forks

#

i wanted to see if there is a debloated fork

#

WAIT MONOREPO JUMPSCARE

olive aurora
austere talon
#

wait are docs outdated

#

it says only APpImage

#

but there are deb, rpm etc here

olive aurora
#

oh wait did cookies revert it

cunning canyon
#

@crude raptor is there any reason to use import without merge
i think it's always better to merge, not at risk losing anything (cuz no warning lol), and people could just delete all rules before import if they really want to have a clean import

crude raptor
#

i personally couldn't imagine myself using a merge- but i kept it cause its what you already had

austere talon
#

does merge properly deduplicate?

crude raptor
#

no

#

it just goes through the list of rules you supply and adds them to the end of the list

#

maybe a merge with deduplication would work- especially if the move up/down buttons get fixed lol

austere talon
#

merge should definitely dedupe

#

although dupe rules are irrelevant if rules r written correctly

#

but still better to dedupe

crude raptor
#

idk i guess you could get like

#

^(h) -> hello

#

hey -> helloey -> helloelloey

#

so yeah i guess merge with deduplication would be fine

limpid badger
austere talon
#

?

#

no

#

nothing will change

limpid badger
#

Hmm

#

I was wondering if this applies to win zip file

cunning canyon
#

done dedupe

austere talon
crude raptor
#

just got an email about autumn working on things, just wanna mention that i thought rearranging the devs would make sense cause the pfps stack, and that weirdly puts me, the smallest and newest dev, on... top? and you, the creator.. on the bottom, mostly covered

#

god just looking at the changes its like "oh wow, that makes sense!!... why did i do it this way anyway??"

dire trench
#

so if you have a profile effect set discord will force you to have profile theme colors

#

and you cant get the default profile look by changing the colors

charred monolithBOT
austere talon
#

@placid hinge catstare

charred monolithBOT
dire trench
#

@austere talon I added the ability to create backwards compatible 3y3 strings to the plugin
so now it really can 100% replace FakeProfileThemes

austere talon
#

wrong repo

#

that's normal vencord repo

#

why only sidebar anyway

#

Also how does electron know what the sidebar is

jagged cloak
#

me neither

#

lol

#

i just tried it to dual vc and nope

#

back to jackbox

#

discord moment i guess

#

L

west plank
#

hi, author of the PR here, I could make a dropdown menu if that's fine for y'all πŸ˜„

#

I mostly used fullscreen-ui because I was trying to get the same effect as Slack's newest design and they use the fullscreen-ui material.

#

gotcha, should i just have the two options or just all the possible materials?

#

Cool, will look into this later this week.

crude hearth
charred monolithBOT
oak hull
#

duke will fix

west plank
#

Silly dev question that I couldn't find an answer for in the docs (maybe I missed something): is there a better/faster way to test changes to the patcher/settings stuff than running npm run build && npm run inject and re-patching Discord?

cunning canyon
#

pnpm watch

west plank
#

that doesn't re-patch Discord tho, right? (but thx i didnt notice the watch script πŸ˜„ )

cunning canyon
#

restart discord (ctrl + r)

austere talon
#

then you just need to rebuild and restart discord

#

or watch and you don't have to manually rebuild

crude hearth
#

One Day ven will rename himself to vvgaming and realize who is his long lost brother

livid heath
#

WWGaming

west plank
west plank
#

Oops I forgor

#

Hold on

#

Done πŸ˜…

#

Can you add that in the PR’s comments so I don’t miss it tomorrow?

west plank
#

The && false thing is there to make TS happy since I wanted to keep the old option to make it so ppl who had it enabled didn’t revert back to β€œno vibrancy”.

#

I can’t check rn (pretty late here so I’m in bed) but basically if I removed the option from the Settings type obviously I can’t β€œsafely” check for its value in the form but removing the switch while keeping the option in the type for the old option threw a TS error (I don’t remember exactly which one however).
So the && false basically made it so the switch isn’t displayed but is there β€œtechnically” in the type like that other unstable transparency option a few lines above.

livid heath
#

&& false would make the entire expression false

charred monolithBOT
lime stone
#

i'd suggest moving them by dragging them though

charred monolithBOT
charred monolithBOT
blazing dome
tough folio
#

can this be bypassed

verbal pumice
#

no

#

use an actual upload service

tough folio
#

wym

charred monolithBOT
tough folio
#

whats this

topaz thistle
nimble pendantBOT
lime stone
#

too late

#

i love scrolling through 500 bot prs trying to find something made by humans

blazing dome
placid wave
#

no

placid wave
#

it doesn't create a pr until you hit the button on the security issue

#

also this pr is useless you didn't set up npm

#

only actions

nimble plaza
#

its built in to github

charred monolithBOT
half notch
#

ty for the years of bettertweetdeck

#

still techincally using it

tidal cloud
charred monolithBOT
austere talon
lime stone
#

can't the latter be a plugin

#

and the former, can't you already do that

nimble plaza
#

nop

lime stone
#

you can change discord's icon

#

like you do with any other application

nimble plaza
#

only that

tight dagger
#

Is it possible to make the badge color of MoreUserTags in the color that the user has as display color?

austere talon
#

is streamer mode even a thing on web

#

idk tbh

lime stone
#

can't you edit the lnk file in the start menu folder?

austere talon
#

if yes, probably? need to write code to detect obs

lime stone
#

it's been a while since i touched windows

lime stone
surreal fiber
lime stone
#

huh

austere talon
lime stone
#

what if you pin it

austere talon
#

whar?

#

shouldn't happen

#

try urself

stark flint
#

seems to be the case

charred monolithBOT
crude raptor
austere talon
#

vscode

lime stone
austere talon
lime stone
#

you could just make the element move and the other elements move around it

austere talon
grave mangoBOT
# austere talon 1) add draggable=true to your elements 2) add these handlers to all destinations...

**index.html: **Lines 209-256

field.addEventListener("dragover", e => {
  if (canMoveFromTo(puzzleGrid, dragee.idx, i)) {
    e.preventDefault();
  }
});

field.addEventListener("dragstart", e => {
  dragee = {
    idx: i,
    kind: puzzleGrid[i]
  };

  field.classList.add("field-dragging");
  for (let i = 0; i < puzzleGrid.length; i++) {
    if (canMoveFromTo(puzzleGrid, dragee.idx, i)) {
      fields[i].classList.add("field-drop-target");
    }
  }
});

field.addEventListener("dragend", e => {
  field.classList.remove("field-dragging");
  for (let i = 0; i < puzzleGrid.length; i++) {
    fields[i].classList.remove("field-drop-target");
  }
});

field.addEventListener("drop", e => {
  const { idx, kind } = dragee;

  fields[idx].classList.remove("field-dragging");

  const knight = fields[idx].firstElementChild;
  // appending to field will remove it from the previous field
  field.append(knight);

  puzzleGrid[idx] = BLANK;
  puzzleGrid[i] = kind;

  moves++;
  movesText.textContent = `Moves: ${moves}`;
  if (moves === 1) {
    startTime = Date.now();
    setInterval(() => {
      timeText.textContent = `${formatDuration(Date.now() - startTime)}`;
    }, 1000);
  }
});
austere talon
#

obv the logic inside the handlers will look differently

limber skiff
#

wtf I didnt knew drag dropping was so easy

austere talon
#

btw discord also has their own drag and drop

#

maybe you can reuse theirs

#

like u know the role list sort?

#

does findByProps("useDrag") work?

limber skiff
#

kinda

#

let me see what role list sort uses

austere talon
#

that's this library

oak hull
#

SAME

#

i used scoop, how else did you install it

verbal pumice
limber skiff
verbal pumice
#

react-dnd's docs are surprisingly good

limber skiff
#

they actually seem to be yeah

oak hull
#

oh

#

i see

limber skiff
#

horror

#

oh it's all the same function

austere talon
limber skiff
#

just re-exported

austere talon
#

remember rspack update unmerged modules

verbal pumice
austere talon
#

swc merged all modules together if exports were only used in one place

limber skiff
#

just findByProps("useDrag", "useDrop", "useDragDropManager", "DropTarget") :)

verbal pumice
#

(findByProps("useDrag", "DropTarget")) is enough

limber skiff
#

that's why we have a bunch of re-exports now

limber skiff
#

it's whatever

oak hull
#

huh, weird
winget is working

#

:fiiure

austere talon
limber skiff
#

what's this command called

#

I forgot the linux version too

austere talon
#

like

// hooks.ts
export useDrag;

// index.ts
export * from "./hooks.ts"
#

now you'll have two modules exporting useDrag

austere talon
#

swc would merge these entirely but rspack doesn't

limber skiff
#

😭

charred monolithBOT
#

Content

Hi its not an issue more like a super important thing to me.
The message logger is so extremely helpful when it comes to moderating server and creeps in dms.
Never let it die its so amazing.
I might donate at some point. Thats it!

Request Agreement

  • [X] I have read the requirements for opening an issue above
livid heath
verbal pumice
#

do they have a reason to use swc now?

#

can they even?

livid heath
#

Rspack internally uses SWC to perform code downgrade compilation which you can configure by presetEnv, so there is no need to use babel-loader to perform code downgrade compilation.
Inchresting

#

Given this answer in the FAQ

Even if webpack + SWC-loader solves the performance problem of babel-loader, webpack itself still has many performance bottlenecks, such as the make and seal stages, which are single-threaded. However, Rspack breaks through these limitations, so Rspack has better performance than webpack + SWC-loader, especially in multi-core scenarios.
I don't think they'll hook up swc

verbal pumice
#

yeah rspack is overall quite the W for client mods

west plank
limber skiff
#

though I have to say the destructuring is quite annoying

#

(for regex matching)

crude raptor
#

uhhh so- i don't think ive updated vesktop yet- ive also not changed a single thing since yesterday....

#

anyone got any idea whats happening here? lmfao

austere talon
#

did u just install it

#

WHY DO YOU USE WHATSAPP WEB 😭

#

probably missing some drivers

#

run with --disable-gpu

crude raptor
charred monolithBOT
oak hull
#

a little buggy on my end though'\

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
torn knot
# oak hull

where do yall find these color only themes?

charred monolithBOT
torn knot
#

I forgor that plugin was there SKULL_SKELETON

charred monolithBOT
oak hull
#

but im using the css verison

#

@import url(https://css.f53.dev/discord/ClientTheme.css);

#
:root {
  --theme-h: 223;
  --theme-s: 22%;
  --theme-l: 11%;
}
woeful sable
#

is there a way to request an plugin?

uncut glen
#

or the better option learn to make the plugin

charred monolithBOT
#

I believe this is supported in the native discord app but not here. When I watch a stream on Vesktop, both the stream audio and the voice chat audio are playing back through the same stream.

image
Screenshot from pavucontrol, showing there is no separate stream for the screenshared audio.

If we could separate them into individual streams I can change which device the stream audio gets sent to,...

woeful sable
uncut glen
#

he needs the first thing first

#

he needs to know how to build

woeful sable
#

thanks

uncut glen
#

for vesktop you just choose the vencord folder in the settings

surreal fiber
uncut glen
#

lol

woeful sable
uncut glen
#

some1 should remake the 1_INSTALLING.md file and add vesktop install

#

i could but to lazy rn