#πŸ‘Ύ-core-development

1 messages Β· Page 125 of 1

austere talon
#

but dont send the repo link

charred monolithBOT
austere talon
#

send the direct link or as a css snippet

tidal cloud
#

yes, this is good

topaz thistle
#

Yes, as stated in my aforementioned message

proper badge
#

hmm ok will check later

calm wharf
#

Looks good to me, I assume dismissing the alert would leave telemetry undefined so it would show again?

turbid hatch
#

yep

calm wharf
#

Awesome

turbid hatch
#

so it'll show up again

#

alright, cheers you two poi_thumbsup

charred monolithBOT
oak hull
#

do i update vencord

turbid hatch
#

why did i change "readd" to "read"

junior olive
turbid hatch
#

that was a mental typo

turbid hatch
oak hull
#

oh

junior olive
#

consent v1 was so good they made a v2

turbid hatch
#

the telemetry api doesnt even exist

#

it's still in a draft PR on vencloud

#

so dw

oak hull
#

ah, i see

charred monolithBOT
#

Discord Account

deepinyahmum

What happens when the bug or crash occurs?

Reactions from other server no longer work. Assuming its a plugin.

What is the expected behaviour?

Emojis from other server to properly display.

How do you recreate this bug or crash?

Just try and use a reaction on someone's message. Won't work, will just dissapear.

Errors

No crash log.

Request Agreement

  • [X] I am using Discord Stable or tried on Stable and this bug happens there as ...
tidal cloud
#

will you be doing the docs on your own too, lewi

topaz thistle
#

[Bug] <Title>

#

Lmao

oak hull
#

going to guess this is a fakenitro

charred monolithBOT
lime stone
#

Just try and use a reaction on someone's message. Won't work, will just dissapear.
they should be grey

oak hull
#

is the reply correct

turbid hatch
#

if their discord is accurate then they're not here

#

which means that they didnt follow the requirements

junior olive
#

deepinyahmum

#

πŸ”₯

lime stone
#

huh

tidal cloud
#

issue number 1922 jeez

lime stone
#

you can see whether they are a contributor on github

#

or you mean the moderator requirement?

oak hull
turbid hatch
#

no the contributor requirement is that a contributor here asked them to open it

oak hull
#

ohh

turbid hatch
#

if we only wanted contributors to open issues we would just block everyone from doing so unless they have previously made accepted prs

charred monolithBOT
oak hull
tidal cloud
junior olive
austere talon
#

or else i might just do that

turbid hatch
#

GitHub does not provide issues-only access permissions

#

agh

#

:(

tidal cloud
#

I have been ever since this was ven's funny personal mod in js

verbal pumice
limber skiff
#

you are right, the 8th patch causes it

woeful sable
#

hey its me

desert portal
#

if you open a folder and then right after open a server, the client just freezes completely

oak hull
desert portal
#

most likely a betterfolders bug

desert portal
#

when is it getting fixed

oak hull
#

idk

desert portal
#

I've already done it twice accidentally ._.

limber skiff
#

I'm fixing it rn

oak hull
limber skiff
#

it freezes when you have a server that is in a folder selected, and you try to open a folder which is not the one the server is in

#

if you want to avoid it for now

desert portal
#

so i literally just am not allowed to open folders ._.

oak hull
#

disable plugin for now until fix

desert portal
#

it is a betterfolders bug right

oak hull
#

yes

limber skiff
#

lol

desert portal
limber skiff
#

yikes

desert portal
#

😭

limber skiff
#

actually

#

@desert portal keep the folder the server is in open

#

and it will work

desert portal
#

oh

#

πŸ‘

charred monolithBOT
#

After update 0.4.1, the app just hangs on a white screen when I try to open it. reinstalling doesn't work, and updating also doesn't.
Platform - Linux, Wayland.
Here's what I get in the logs when opening the app through the terminal:
`(node:17256) UnhandledPromiseRejectionWarning: ReferenceError: IS_EXTENSION is not defined
at VencordDesktopMain:5:737
at VencordDesktopMain:5:225
at VencordDesktopMain:5:2229
at VencordDesktopMain:5:225
at VencordDesktopMain:5:2657
...

real zenith
#

wait can I send messages over the console-exposed Vencord api

junior olive
#

oh my god why does vencord keep uninjecting

#

it's every update now i feel

charred monolithBOT
limber skiff
#

lmao this is funny, me and juby did a patch in the same place, and I didnt even look at his code when I did mine

charred monolithBOT
charred monolithBOT
charred monolithBOT
junior olive
#

but thought it was safari skill issue

charred monolithBOT
sacred plover
limber skiff
sacred plover
limber skiff
#

what covers what buttons

#

can you screenshot

sacred plover
#

yeah

#

or i guess just someone who actually knows how to program (not me) makes an official plugin so we can have it on not just web

limber skiff
#

☠️

junior olive
limber skiff
#

how did the extension creator even think that was a good idea

sacred plover
#

i mean
its not bad
its just that the button is a pain

limber skiff
#

to put a button that blocks the elements under it

sacred plover
#

no clue

charred monolithBOT
limber skiff
#

yes that button is super dumb

sacred plover
#

im sure its just a simple tweak

charred monolithBOT
sacred plover
#

i tried messing with it a few months back but never got it fixed

limber skiff
#

let me try to fix it real quick

#

and send you a modified version

sacred plover
#

k

#

although as foretold

or i guess just someone who actually knows how to program (not me) makes an official plugin so we can have it on not just web

limber skiff
#

eh I don't wanna do it lol

sacred plover
#

i assume you'd kinda just be able to plug and play

#

yeah lmao

#

which...
it should also hide the additional folders section if possible but yeah i know you don't wanna make a project out of it

limber skiff
#

the button doesnt show for me

sacred plover
#

address bar

limber skiff
#

yeah it's enabled

sacred plover
#

idk its a screwy thing to begin with if it have elements that just overlay stuff ._.

#

maybe if there's an internal to-do list, put a note about this extension, and keep it as food for thought as an official plugin

#

it'd be handy for multitasking lmao

limber skiff
#

the extension isnt working for me

#

it's not even hiding the stuff

sacred plover
#

yeah i have no freaking clue

#

oh

charred monolithBOT
sacred plover
#

that ^?

limber skiff
#

yeah

sacred plover
#

weird

limber skiff
#

and nothing happens

sacred plover
#

i guess its the end of the road then lmao

limber skiff
#

yep

sacred plover
#

welp, thank you for trying though

austere talon
#

problem is that 99% of suggestions we get are absolutely stupid and waste our time

#

hence why they're closed

wooden dawn
#

very understandable (not sarcasm)

#

You can see the same kind of thing when you make an announcement about betterfolders not working and then every 3rd message in #πŸ₯-vencord-support-πŸ₯ is about betterfolders not working

#

like... really?

austere talon
charred monolithBOT
dire trench
charred monolithBOT
limber skiff
#

@austere talon can you merge that into main πŸ˜”

spark pivot
#

I'm using useSettings in my component and it keeps throwing Rendered more hooks than during the previous render., but the hook isn't called conditionally, it's at the top of the function

austere talon
#

you're misusing react if that happens

#

construct your component properly with jsx, not by calling it as a function

spark pivot
#

yep that worked

woeful sable
woeful sable
#

nah i saw some files called .ts, so i got confused why use jsx when you could use tsx

spark pivot
#

we use tsx

#

jsx + ts = tsx

woeful sable
#

oh you do? i must not of gone that far then

austere talon
#

jsx = tsx

#

same thing

woeful sable
#

basically yea

charred monolithBOT
charred monolithBOT
dire trench
#

after 25 hours i finally finished the plugin

charred monolithBOT
dire trench
#

the 3y3builder is on the profiles settings page

charred monolithBOT
charred monolithBOT
frail skyBOT
#
Bad Patches

NoTrack (found no module):
ID: -
Match: window.DiscordSentry=

Bad Starts

None

Discord Errors

None

dire trench
#

plugin demo

frail skyBOT
#
Bad Patches

NoTrack (found no module):
ID: -
Match: window.DiscordSentry=

Bad Starts

None

Discord Errors

None

woeful sable
#

no way

fringe eagle
#

does the monaco folder in the dist folder mean something

charred monolithBOT
fringe eagle
#

and why does buildWeb exit after build

austere talon
#

wha

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
fringe eagle
#

i wanna focus on monaco folder

#

i just reforked because i can't pull from vencord because when i pushed the original venticord it wasn't a fork

charred monolithBOT
rapid summit
# austere talon hence why they're closed

just joined as GH discussions are gone, and i this is why the discussions on GH are closed?
i was going to request a (should-be) simple plugin idea that fixes a really minor quirk in VCs but i guess i can't really suggest that anymore

charred monolithBOT
#

Discord Account

godlyavenger

What happens when the bug or crash occurs?

Whenever I'm in an audio channel, my Vencord crashes. It happens intermittently, probably once a day. I can't really reproduce it, but it still happens even when all plugins are off. The error I get is below.

What is the expected behaviour?

I expect Vencord to not crash when I'm in an audio channel.

How do you recreate this bug or crash?

I can't really reproduce it. Sometimes I can be in an audio ch...

jagged cloak
#

audio channel

#

discord cookign new channel types fiure

#

voice message only channel

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
slender helm
#

Is the auto update toggle perhaps broken?

#

I have it toggled on but when there's an update it doesn't automatically restart :^)

woeful sable
#

What's this chanel for again, I'm confused

gentle spruce
#

are we on trending again

woeful sable
gentle spruce
#

we are

woeful sable
#

Let's goo, ven

nimble pendantBOT
#

owo

nimble pendantBOT
#

owo

verbal pumice
#

okay it isnt

#

i was like wtf

#

hey at least it's still in trending in typescript

#

wait no that's vesktop lmaoo

charred monolithBOT
#

I can confirm that the issue still occurs.
There are three odd behaviours that can be noted.

  1. If you have pinned DM's and unpinned DM's you can see only a portion of the unpinned ones. A scrollbar is also present, despite the dm's not exceeding the screen space and requiring an overflow. When you scroll down the missing DM's show up as if they had a "display:none" property removed.
  2. If you have pinned DM's but no unpinned DM's, the list freaks out and starts showing multiple "No DM's" ...
austere talon
#

ate them?

cunning canyon
#

eat

austere talon
#

what Halen

#

happen

cunning canyon
#

it's gone when lumap fix it lol

austere talon
#

huhhh

#

wdym

charred monolithBOT
cunning canyon
austere talon
#

fear

#

how'd that happen

teal halo
charred monolithBOT
#

I managed to fix the issue by clearing my data but after a while it started
happening again so it's probably because you are storing the user ids
incorrectly and JavaScript rounds them maybe?

On Sun, Oct 29, 2023, 7:23 PM DaimeneX @.***> wrote:

I can confirm that the issue still occurs.
There are three odd behaviours that can be noted.

  1. If you have pinned DM's and unpinned DM's you can see only a
    portion of the unpinned ones. A scrollbar is also present, de...
woeful sable
charred monolithBOT
charred monolithBOT
nimble plaza
#

LMAO

charred monolithBOT
turbid hatch
#

the mistakes in this aren't even mistakes lol

#

Stable, Canary, or PTB is different to Stable, Canary or PTB

nimble plaza
#

yeah

#

like

turbid hatch
#

the latter is correct

nimble plaza
#

oxford comma

turbid hatch
#

oxford comma being used here is wrong

nimble plaza
#

yeah

turbid hatch
#

as a professional english speaker myself, this PR is bollocks

austere talon
#

curious

turbid hatch
#

oh

#

hacktoberfester

austere talon
#

makes it very obv it's spam

charred monolithBOT
turbid hatch
#

oh god i didnt even notice that

#

i just saw the comment

#

lmfao

#

wait

#

@austere talon

#

even better

#

look at the tabs

#

hacktoberfest repo list, ours, and then GRAMMARLY

austere talon
#

honestly im surprised we didn't get more spam than that

#

# 1 trending during hacktoberfest

turbid hatch
#

we arent that high up on the list it seems

#

we're beaten by bitwarden and stuff

austere talon
#

Fuck you discord

#

we used to be #​1 trending for like half a day

turbid hatch
austere talon
#

god im renaming the stupid onboarding channels

turbid hatch
#

call them ob-#

austere talon
#

#1

#

finally

long stream
mental lotus
#

i had a dream that prs were closed down to 41

#

im surprised how dreams can bring such type of fiction to reality

austere talon
#

whaa

turbid hatch
#

HEY

#

OOMFIE

#

DOCUMENTATION TIME

austere talon
#

nope

#

going to the store to buy chips time

turbid hatch
#

oomfie

austere talon
turbid hatch
#

do docs with me after

#

oki

#

i need css help :(

austere talon
#

mmmmm

charred monolithBOT
turbid hatch
#

hmm

#

on that note oomfie i might just use astro's content system

#

anyway showertime

#

i had one earlier but i dont feel clean

charred monolithBOT
inland zinc
woeful sable
atomic crater
#

how can I add a setter for exports of modules?

turbid hatch
#

@austere talon you're gonna have to help me clean up the css for this cause it's.. horrific to say the least

#
#docs-picker {
    position: fixed;
    top: 6.5em;
    left: 2em;

    width: calc(var(--horizontal-margin) - 4em);
    height: calc(100% - 13em);

    border-right: 1px solid var(--bg5);
}
atomic crater
# atomic crater how can I add a setter for exports of modules?
instance.push([[Symbol()], {}, require => {
    require.d = (target, exports) => {
        for (const key in exports) {
            if (!Reflect.has(exports, key)) continue;

            Object.defineProperty(target, key, {
                get: () => exports[key](),
                set: v => { exports[key] = () => v; },
                enumerable: true,
                configurable: true
            });
        }
    };
}]);
instance.pop();

I tried this

austere talon
#

why would you ask that here

atomic crater
#

where would I ask that then?

austere talon
#

not here?

atomic crater
#

it's core related

austere talon
#

you could ask in the BD server

atomic crater
#

what

austere talon
#

no it isn't

atomic crater
#

it worked before you updated patchWebpack.ts

austere talon
#

you don't need setters on exports unless you're monkey patching, which is not something we do

atomic crater
#

I roll back and it works

charred monolithBOT
#
[Vencord/vencord.dev] New branch created: feat/docs
#

This is a VERY large change for multiple reasons:

  • we have migrated to Astro 3, which changes a lot of things
  • Cloudflare integration is currently BROKEN (releases/[repo].ts), need assistance on it!
  • the documentation system added here is still heavily work in progress, and we need to actually write the documentation before we can merge this really
#

Deploying with Β <a href="https://pages.dev"><img alt="Cloudflare Pages" src="https://user-images.githubusercontent.com/23264/106598434-9e719e00-654f-11eb-9e59-6167043cfa01.png" width="16"></a> Β Cloudflare Pages

<table><tr><td><strong>Latest commit:</strong> </td><td>
<code>da4e69a</code>
</td></tr>
<tr><td><strong>Status:</strong></td><td>Β βœ…Β  Deploy successful!</td></tr>
<tr><td><strong>Preview URL:</strong></td><td>
<a href='https://575a1652.vencord-website.pages.dev'...

oak hull
#

markdown failure

charred monolithBOT
olive aurora
#

[Vencord/vencord.dev] Pull request opened: #31 refactor: transition to actix

turbid hatch
#

voimit

charred monolithBOT
turbid hatch
#

❌

#

not sending errors

#

people can report them but we're not adding an error tracker

olive aurora
#

how about instead of telemetry you call it plugin statistics

verbal pumice
#

it should be obvious its telemetry tbh

olive aurora
#

yes but the former is super vague

#

and looks scarier than it is

woeful sable
#

who is seeing telemetry and turning it on 😭

charred monolithBOT
verbal pumice
#

on by default blobcatcozy

olive aurora
#

make it on by default for random users

#

ab test optin optout

turbid hatch
turbid hatch
#

it's vencord version and operating system

#

it's not just plugins

woeful sable
#

ban lewi and rini for adding telemetry

olive aurora
#

why os

turbid hatch
#

so we know what platforms people are using vencord on so we can better optimize for them

long stream
turbid hatch
#

it's why we aren't using /boop as the url for where we're sending telemetry

olive aurora
#

what can you even optimise

turbid hatch
#

we're calling it this on purpose so people with adblockers and stuff can turn it off

turbid hatch
olive aurora
#

dont downloads already have stats

turbid hatch
#

and also linux support for screensharing

#

etc.

turbid hatch
woeful sable
#

you just want stats bro?

#

there's no way I see ven adding this

turbid hatch
#

you mean, ven, who helped contribute to what we should be collecting

woeful sable
#

ven is evil

turbid hatch
#

we are PURPOSELY making it as little as possible whilst being able to get the most data out of it

#

and the fact it requires you to explicitly opt in means that we arent just gathering data for the sake of it

#

we explain what its for

woeful sable
#

will this information be public?

turbid hatch
#

yes

#

in fact that's the point

#

we want to publish this info

#

well, i do anyway!

#

i think it's interesting

woeful sable
#

alright

#

no longer evil

turbid hatch
#

actually if u want

olive aurora
#

i still think calling it telemetry outright is gonna make 0 people care about it

turbid hatch
#

you can already access the stats we have for cloud here

woeful sable
#

call it statistics

turbid hatch
#

i suppose that could be better wording on the UI front

#

but idk

verbal pumice
#

does it also store if its desktop/web/vesktop

turbid hatch
#

no

woeful sable
turbid hatch
#

yes

#

same dashboard

woeful sable
#

nice

#

you should put what it saves in the note

turbid hatch
#

i thought i did

woeful sable
grave mangoBOT
turbid hatch
#

it tells you when you're asked about it

#

initially

#

it'd be too long to fit in the note

woeful sable
#

ok cool

turbid hatch
#

not really a good idea cuz it costs money

#

shrug, i dont see the use

austere talon
#

wouldn't it make more sense to make it a different repo?

turbid hatch
#

so the docs themselves are in the src/content/ folder

#

i dont believe you can use a collection from an external source

austere talon
#

whjy would we

#

it should optimally just be a subdomain

#

independent from the main website

#

imo

turbid hatch
#

cause im developing it as part of the main website

#

because every documentation platform fucking sucks

#

vitepress wont behave and requires me to define a ton of components that we probably will never use, and its vue based, starlight won't theme like we want so it sticks out like a sore thumb, docusaurus is react based and i really dont want to port a ton of components

charred monolithBOT
elfin heart
#

ok

charred monolithBOT
charred monolithBOT
olive aurora
#

mdbook >>>>>>>>>

turbid hatch
violet axle
#

hi

hybrid obsidian
olive aurora
#

why do we have mdx components

#

skull

#

docs shouldnt be super complicated to write

turbid hatch
#

RAHHHHHHHH

#

it's so we can have warning cards and stuff

#

without having to do weird markdown hacks in astro

#

mdx is the correct way of doing it

turbid hatch
#

@austere talon

#

does that make you happy

austere talon
#

YES

dire trench
#

how do i set the hover type of Button from webpack/common

#

nvm i got the result i wanted without setting the hover type

frail skyBOT
#
Bad Patches

NoTrack (found no module):
ID: -
Match: window.DiscordSentry=

Bad Starts

None

Discord Errors

None

#
Bad Patches

NoTrack (found no module):
ID: -
Match: window.DiscordSentry=

Bad Starts

None

Discord Errors

None

charred monolithBOT
woeful sable
#

are we still on trending

charred monolithBOT
spark pivot
#

nope

austere talon
#

nop

charred monolithBOT
snow burrow
#

I found vencord because of the trending

austere talon
#

lie

charred monolithBOT
quick isle
#

1k stars in 4 days is crazy

dire trench
#

the plugin is 100% done

charred monolithBOT
dire trench
#

this took 36 hours πŸ’€

charred monolithBOT
woeful sable
#

also does it have custom effects or just stock discord ones

dire trench
woeful sable
#

oh? could you link me to it

dire trench
#

it has all the discord stocks ones
the effect ids are not hardcoded so if discord ever adds any more they will be available

woeful sable
dire trench
woeful sable
#

still looks great

dire trench
#

that was before i refactored the plugin and polished up the ui

woeful sable
#

oh?

#

custom effects πŸ₯Ί

dire trench
#

that would require encoding the last portion of a discord cdn url

#

its possible but someone else would have to make the effect images

junior olive
#

Decor has custom effects on the todo

dire trench
#

yeah this is just a direct improvement over FakeProfileThemes

charred monolithBOT
dire trench
#

uses less way less chars too

woeful sable
#

vencord best client

charred monolithBOT
junior olive
austere talon
cunning canyon
#

lol

normal chasm
charred monolithBOT
charred monolithBOT
grave merlin
#

Is it normal the latest release dates all the way back to 2022 ?

verbal pumice
#

you can see that the hash matches up with the latest commit

charred monolithBOT
grave merlin
charred monolithBOT
#

If I'm watching a screenshare and screenshare myself, then on my end (looking at the preview) and on everyone else's end, the screenshare infinitely loads.

I can screenshare just fine if I stop watching all other screenshares first.

Vencord Debug Info

  • Vencord: v1.6.1 β€’ 522fdcd (Vesktop v0.4.2) - 28 Oct 2023
  • Discord Branch: stable
  • Client: Vesktop v0.4.2
  • Platform: Win32
  • GPU: NVIDIA (no iGPU)
  • Outdated: false
  • OpenAsar: false

Enabled Plugins (42):

AlwaysT...
austere talon
#

it should be

normal chasm
#

I think you should consider adding backwards compatibility, then.

dire trench
#

No need to make it backwards compatible
If I gets added you can easily update the 3y3 string in your bio in a few seconds using the 3y3 build I made

austere talon
#

not just vencord has the plugin

#

it also exists on many other mods

normal chasm
#

it would be very annoying to suddenly update to this plugin and lose access to everyone's already existing colours

dire trench
#

There are 126 3y3 chars

#

126th is separator

#

Other 125 are used to encode in base125

#

I'd have to do 2 passes

#

Possible but scuffed

#

FakeProfikeThemes does not encode to base125 (reason why it takes so many chars)
Meaning any of the chars in a FakeProfileThemes 3y3 strings could just be a part of a long base 125 string and it would be hard if not impossible to differentiate

normal chasm
#

Users don't care if your code is scuffed. They will care if suddenly it stops working 'for no reason'

dire trench
#

I'll see what I can do

normal chasm
#

Thanks, I'm sure you can figure out a good solution

normal chasm
charred monolithBOT
nimble plaza
#

water gun,,,

charred monolithBOT
nimble plaza
#

you have an empty folder mayve

jagged cloak
#

any random file in plugins or user plugins breaks it

austere talon
#

imo erroring is better than invalid plugins silently not being included

charred monolithBOT
cunning canyon
#

click profile
hacktoberfest

nimble plaza
#

can we repo block hacktoberfest fucks

austere talon
#

I removed the label

nimble plaza
#

good

dire trench
#

the shortest possible value generatable by the FakeProfileThemes plugin is [0,0]
if interpreted as base125 and decoded to base10 it is 22065130967 which is greater than the max 24bit color value 16777215

nimble plaza
#

digital pin husk

dire trench
#

tf is hacktoberfest

#

some github thing?

dire trench
austere talon
#

the previous years they gave free tshirts so it was actually pretty cool, I love my 2022 shirt

#

but this year they only give nfts basically

dire trench
#

nfts πŸ’€

austere talon
#

2022 shirt

dire trench
#

why would they do that knowing that they will get tons of hate

austere talon
#

not actually nfts

#

whatever this is

charred monolithBOT
dire trench
#

more fomo

#

who asked for that

#

npc review

austere talon
#

fake review lmao

dire trench
#

all of them are like that

charred monolithBOT
dire trench
#

this happening to anyone else or did i break something?

spark pivot
#

Reviewdb is in the trash

#

Oh wait it’s a 522

verbal pumice
#

most stable mantika code

dire trench
#

its because cross orgin requests not allowed

#

idk why they would set that when its not a discord.com url

verbal pumice
dapper crest
nimble plaza
#

NOO MY FAVOURITE MEDIA PLUGIN BROKE

#

i cant favourite pngs anymore

#

i will die

nimble plaza
#

why is my plugin not erroring

#

im not getting a "patch had no effect" message

#

wuh

limber skiff
#

means your match is broken

nimble plaza
#

matches can be strings right

#

this should still work

#

HUH

#

IT WORKS?????

nimble plaza
#

wtf

verbal pumice
#

obv

#

the only way to deal with extensionless images is to patch somewhere else where you can check content-type

#

or actually

#

why cant you just always enable it

nimble plaza
#

it doesnt play well with videos

verbal pumice
#

since non media wont be in the media element

nimble plaza
#

i mean i could try

#

i patched that and it shows things are gifs but doesnt show the fav icon?

verbal pumice
#

hm i wonder what the isAnimated function indicates

nimble plaza
#

thats the only place the regex is used

#

and id assume thats what decides if you can favourite it, since you can only favourite gifs?

#

patching this to include more types works

charred monolithBOT
verbal pumice
#

uh

#

yeah looking at it no idea where the component is added

woeful sable
#

@cunning canyon did you fix imageZoom?

#

there’s a bug?

#

random scroll bar is added

verbal pumice
#

let me quickly

dire trench
#

@austere talon ok it is now backwards compatable

#

just need to do some final refactoring

patent minnow
verbal pumice
#

true..

charred monolithBOT
#

it'd be funny

Routes (courtesy of https://gist.github.com/ghostrider-05/8f1a0bfc27c7c4509b4ea4e8ce718af0)

Discord app protocol routes

Home:

  • /: discord://-/
  • friends: discord://-/channels/@me/
  • nitro: discord://-/store
  • message requests: discord://-/message-requests
  • family centre: discord://-/family-center

General:

  • apps: discord://-/apps
  • discovery - guilds: discord://-/guild-discovery
  • gift: discord://-/gifts/
  • gift (with login screen...
nimble plaza
#

itd be funny

oak hull
#

we will commit a few acts of mischievious tomfoolery

rare shale
#

when you put a link <like this>, does discord's proxy ignore it or does it get ignored clientside?

limber skiff
#

proxy I think

rare shale
#

awww

austere talon
#

wdym proxy

#

oh

#

it's server side

#

you can easily request embeds for arbitrary links tho

rare shale
#

so if we wanted to implement force embed show or something like that, we wouldnt have to expose people's ip to the link's server

austere talon
#

it uses discord's api

limber skiff
#

findByProps("unfurlEmbedUrl").unfurlEmbedUrl

#

you can prob use useExtractEmbedPreview too

#

it uses unfurlEmbedUrl internally

austere talon
limber skiff
#

yeah

#

that's how I found it

austere talon
#

i wonder, where does discord use it?

limber skiff
austere talon
#

no

#

i mean

#

where in the ui do they actually use it

#

forum post drafts it seems

limber skiff
#

in this thing

#

idk what it is

#

let me see what L is

austere talon
#

also forum post draft

#

whatever that is

limber skiff
#

oh it might be to display media channel images

vague oracle
#

what file in dev tools do i look at to fib d where to patch?

limber skiff
#

there is no exact answer to that

#

what do you want to patch?

rare shale
vague oracle
#

I want to port over this enmity plugin i made

#

it modifies the user profile popout UI

limber skiff
#

does it add a section

vague oracle
#

yes

limber skiff
#

like this

vague oracle
#

yep

limber skiff
#

then you can just look how permissions viewer does it

grave mangoBOT
rare shale
limber skiff
#

nope

vague oracle
#

is there a webview equivalent for vencord? IFrame?

verbal pumice
#

you mean for discord or something else

vague oracle
#

yes

charred monolithBOT
austere talon
vague oracle
austere talon
#

?

#

thats alr a stock feature

vague oracle
#

i wanna add it to the user profile

austere talon
#

horror

vague oracle
#

ok?

austere talon
#

that seems terrible

vague oracle
#

why do you care

austere talon
#

you could add a button where the other buttons are

vague oracle
#

?

austere talon
#

play button

vague oracle
#

this is what it is

topaz thistle
#

@austere talon A Flatpak is still being worked on right?

oak hull
#

that's a different plugin

austere talon
#

yes

austere talon
charred monolithBOT
vague oracle
#

bio

austere talon
#

that isnt statically linked yet

#

i just bumped it 15 minutes ago

junior olive
#

I love using bio for storage of metadata it is so maintainable long term it's not like there's a character limit

vague oracle
#

why do you care holy shit

#

is there a webview equivalent or no

austere talon
#

why would anyone want this in their bio WHAT

topaz thistle
#

@austere talon Updated the comment to clarify glibc 2.36 is on master

vague oracle
#

yall are toxic af

austere talon
#

constructive criticism = toxic

junior olive
vague oracle
#

and you aren't providing a solution to my problem or a solutio alongside your constructive criticism

#

you're just shitting on me with no actual solution

austere talon
#

you can literally just google your question in 10 seconds

vague oracle
#

thanks

junior olive
#

I think the replugged mod would be very appreciative of this plugin idea!

oak hull
#

(includes token storage)

lime stone
#

skill issue. honestly you should touch grass.

junior olive
vague oracle
rare shale
charred monolithBOT
#

Some slight clarification:

The current minimum requirement for venmic is GLIBC 2.36 (on master) which was released in August of 2022.

In case your system still ships an older glibc version, I'd either suggest upgrading your system or to try the (upcoming) flatpak

At least Debian 12, the shipped glibc version is 2.36 exactly (https://packages.debian.org/bookworm/libc6)

Its very likely this is the case for Ubuntu 22.04 LTS too and the systems based on it.

vague oracle
rare shale
rare shale
#

:(

woeful sable
#

fuck !

vague oracle
#

is there like a github for databasedb or smth

rare shale
woeful sable
rare shale
rare shale
#

oh thats funny

woeful sable
#

i will find a way to break it

rare shale
#

i made fuck/ greedy so its checking if / is in a-zA-Z0-9

woeful sable
rare shale
woeful sable
charred monolithBOT
#

I think it also happens with invalid links, for reference here is the relevant part from my Vencord config

{
 "themeLinks": [
        "https://localip.github.io/dark-discord/src/source.css",
        "#https://capnkitten.github.io/BetterDiscord/Themes/Material-Discord/css/source.css",
        "#https://KillYoy.github.io/DiscordNight/DiscordNight.css",
        "https://nyri4.github.io/Discolored/main.css",
        "https://d3sox.me/complementary-discord-theme/complementary.theme...
unkempt oak
oak hull
nimble plaza
#

should i actually make metadatadb

woeful sable
#

wild

verbal pumice
#

that is me

woeful sable
#

@torn knot how many error you order

torn knot
#

hmm?

#

h-huh?

#

ah

#

ye

#

I opened a new file to check the wp module for getuser

woeful sable
#

oh

oak hull
#

43k lines whag

charred monolithBOT
charred monolithBOT
charred monolithBOT
torn knot
dire trench
#

ok after 41 hours total its done fr this time

charred monolithBOT
charred monolithBOT
grave merlin
#

Would there ve any way to still provide instructions for installing it unofficially?

#

Well it's still possible to install it on devedition

#

That's what I did personally since I don't want to use Chromium

charred monolithBOT
exotic barn
#

there is a way to install custom plugins

grave merlin
charred monolithBOT
charred monolithBOT
#

β€’ example use case: purging URL parameters that aren’t covered by ClearURL, e.g. the new cdn 24h expiry params (usually useless): (?<=https://cdn.discordapp.com/attachments/[0-9]+/[0-9]+/[^?]*)\?ex=[a-f0-9]+&is=[a-f0-9]+&hm=[a-f0-9]+& (← i will also post this one to #textreplace-rules after this pr gets accepted or rejected)
β€’ untested (i don’t have a dev build set up (yet?))
β€’ prompted by #support request #πŸ₯-vencord-support-πŸ₯ message...

hazy kindle
austere talon
# charred monolith

@cunning canyon why did you add those checks for .replace? did it cause any issues when you didn't have them?

#

that pr seems plausible but i think there might have been a reason to have those checks

#

btw effect you could also just match in a group and use $1

hazy kindle
#

reason
could be

#

$1
you referring to my lookbehind example?

#

this is starstriking, hilarious, and wholesome! Truly a pr convo of all time

#

do

charred monolithBOT
cunning canyon
cunning canyon
charred monolithBOT
hazy kindle
#

that sounds big. But is it β€œjust” the thing from a week ago that vc devs fixed in like a day?

hazy kindle
#

does dc push changes first to Canary, Dev, same time, or unpredictable?

austere talon
#

unpredictable

#

they do what they want

#

but generally canary changes only come to stable a day or two later

gilded meteor
#

ive noticed a weird problem with the fake nitro plugin

#

its very minor, but with the custom logo thingy

#

whenever i click on a server, it switches back to normal. but when i hover over it, it goes back to the custom one

austere talon
charred monolithBOT
half glacier
#

Willing to pay someone to make and publish a plugin that modifies emoji favorite locations via drag & drop (across all devices too please). $30 sounds fair? Will pay first if you have published plugins currently

gilded meteor
austere talon
#

fastest needy for support of my life

spark pivot
frail skyBOT
#
Bad Patches

NoTrack (found no module):
ID: -
Match: window.DiscordSentry=

Bad Starts

None

Discord Errors

None

#
Bad Patches

NoTrack (found no module):
ID: -
Match: window.DiscordSentry=

Bad Starts

None

Discord Errors

None

crude raptor
#

(if this is the wrong channel oopsie)
im reading through the text replace code (possibly going to try and tweak things tomorrow :D)
is there a reason to check if (stringRules) before doing the for (const rule of stringRules)

#

afaik- stringRules will never not be an interatable object- and i can't imagine that a for loop with 0 iterations is any slower than an if statement

hazy kindle
#

@cunning canyon ^

crude raptor
#

woah that person looks so cool

hazy kindle
#

unfathomably cool explodingBoar

cunning canyon
#

idk, it was made when i know nothing nyaboom

crude raptor
#

lmaooo

austere talon
#

why u even asking

#

it's not like it matters much, does it

hazy kindle
#

it's not like it matters much is it (edited)
it's not like it matters much, does it (edited)
~~same reason you did that edit CL0_KekGiggle ~~↓ ok wrong assumption on my part then

crude raptor
#

i was just wondering if it was good prectise that i should copy lol

charred monolithBOT
hazy kindle
#

it’s raining stars

hazy kindle
crude raptor
#

ah well- too late now

hazy kindle
cunning canyon
woeful sable
hazy kindle
crude raptor
#

im very glad for text replace's existance lol- it was like EXACTLY what i wanted and i accidentally stumbled on it while having issue with another client mod (and unmodded discord) forcing me to use browser

hazy kindle
#

forcing me to use browser
so you could userscript it yourself?

crude raptor
#

huh?

#

idk what was up but the discord app itself just wouldn't launch- iirc fatal javascript error even when uninjected lol

hazy kindle
crude raptor
#

anyway- then i discovered vencord (just randomly on chrome webstore lmfao) and i like it alot

woeful sable
crude raptor
#

oh fuck my website has been looked at

woeful sable
#

this is an atrocity

#

the chair, please sit down

woeful sable
crude raptor
#

i love oneko

austere talon
crude raptor
#

i might actually have a look at that on my desktop tomorrow lol- screenshare on linux is a ballache (at least i have xwayland bridge or whatever now)

austere talon
charred monolithBOT
hazy kindle
#

in TextReplace settings, would be nice if the TEST RULES replaced field "Message with rules applied" would update on every keystroke while writing rules. It does so for changing the test input string, but for the 3 rules fields, it only updates when leaving the field.

Might be an easy fix for someone with proper React skill (not me):

https://github.com/Vendicated/Vencord/blob/522fdcd15de906ffd86ae868f5eb0905812b908a/src/plugins/textReplace/index.tsx#L199C1-L204C75 triggers update on keystroke:

function TextReplaceTesting() {
    const [value, setValue] = useState("");
    return (
        <>
            <Forms.FormTitle tag="h4">Test Rules</Forms.FormTitle>
            <TextInput placeholder="Type a message" onChange={setValue} />```


https://github.com/Vendicated/Vencord/blob/522fdcd15de906ffd86ae868f5eb0905812b908a/src/plugins/textReplace/index.tsx#L156C1-L160C39 triggers update only on field leave for some reason:
```js
<Input
    placeholder="Find"
    initialValue={rule.find}
    onChange={e => onChange(e, index, "find")}
/>```
grave mangoBOT
hazy kindle
#

why does it only pull the first line tho sobTaco

cunning canyon
charred monolithBOT
charred monolithBOT
livid heath
charred monolithBOT