and use it instead of hardcoded main
#๐พ-core-development
austere talon
nimble plaza
or make it an esbuild constant
nimble plaza
oki
GUH
still shows the updates but no update button
do what it says :3
OH YOURE TALKING TO ME
no i dont
im dumb
limber skiff
@nimble plaza I will merge that into dev and you test
nimble plaza
oki
limber skiff
it's gonna scream at you that your local copy has more recent commits though
limber skiff
doesnt it have the fix you just made lol
charred monolithBOT
limber skiff
well whatever then you will have to manually pull and build
charred monolithBOT
limber skiff
lmao
we are checking for updates using origin/branch though
your origin dev won't have the upstream dev commits
so checking wont work
nimble plaza
origin is vendicated/vencord for me
limber skiff
ohh
nimble plaza
limber skiff
makes sense
livid heath
how do you close tabs in your browser 
lime stone
ctrl+w
livid heath
brain.exe has crashed
lime stone
brain.exe has crashed
this is like in american english, crisps is chips, chips are fries, jam is jelly, jelly is jello, or the previous three terms are just used interchangably
ctrl+w closes a tab or the whole window
lime stone
[X] I have read the requirements for opening an issue above
rustic sigil
lime stone
@austere talon you might as well post a link to #1765
austere talon
what
lime stone
CustomSounds
austere talon
placid wave
their vencord fork is just loadingquotes changes
and insane badges plugin it seems
royal bane
seems to be discord related
nimble plaza
hm
austere talon
there's nothing we can do
austere talon
a long time ago you could make emotes bigggee than 256kb
iron summit
ohhhhh
austere talon
I have some emotes that are 1mb
nimble plaza
can we make it use a lower resolution?
iron summit
so it needs a resize
nimble plaza
mm
iron summit
theres ezgif
austere talon
I would personally just keep not supporting them, but maybe show a better error
iron summit
free online resize
austere talon
explaining why it happens
iron summit
its 258ko
verbal pumice
I would personally just keep not supporting them, but maybe show a better error
people will just ask why not keep the limit at 1mb then
iron summit
resized it
to below 256ko
and it works now
added it to my server
thanks for the help ๐
nimble plaza
since we use gifenc for fakenitro, can we use that to scale it down?
austere talon
gifenc
nimble plaza
(has know clue what gifenc does https://cdn.discordapp.com/emojis/902180197107916870.png?size=48&quality=lossless)
austere talon
it's only encoder
nimble plaza
ah
austere talon
you'd also need decoder
nimble plaza
blehh
austere talon
you'd need to decode the gifs, resize the frames with canvas and then reencode
nimble plaza
eww
austere talon
and optimally do multiple runs to achieve the highest possible resolution
or somehow figure out how to do it with math
iron summit
seems complicated
i think a better error message saying to resize the gif yourself is a better option
nimble plaza
i might pr later
austere talon
yeah agreed
royal bane
are there any emotes that are large in vencord that i can test with
austere talon
no
royal bane
rip
austere talon
it was only possible many years ago
royal bane
make new account
stone horizon
royal bane
^
woeful sable
https://cdn.discordapp.com/emojis/1024751291504791654.gif?size=48&name=shiggy&qu...
tiny shiggy!!!!
lime stone
get Current User ().premiumType = 0
= undefined is less broken
= 0 breaks file uploads
livid heath
that doesnt work for me, i have to Vencord.Webpack.findStore("UserStore").getCurrentUser().premiumType = <type here>
lime stone
it's like it thinks you have nitro type 0 which doesn't exist ๐ญ
livid heath
it's like it thinks you have nitro type `0` which doesn't exist ๐ญ
you sure?
charred monolithBOT
lime stone
hm
well it doesn't seem to exist on the client
IDK ๐ญ
your premium type is null
limber skiff
discord code moment
livid heath
at this point i just want to completely rewrite the client
limber skiff
that makes so much sense, that's why everything kept breaking when I set premium type to 0
livid heath
omfg this company
simple surge
we maintain plugins, not themes
my bad, i wrote in the thread now
limber skiff
it's okay
opaque pewter
at this point i just want to completely rewrite the client
austere talon
jumpscare
charred monolithBOT
oblique belfry
lime stone
cool person
charred monolithBOT
woeful sable
imdespair
[Vendicated/Vencord] New star added
distant flax
did the updater break on dev?
nimble plaza
i thought the git function returned a string waaa
OH I NEED .stdout.trim()
ill pr
nimble plaza
oki
distant flax
no problem haha, just noticed while trying to debug my plugin
limber skiff
thanks for reporting lol
distant flax
np
nimble plaza
lime stone
how???
limber skiff
isn't that role just a space
javascript evaluates it to false ๐คท
lime stone
if it's empty it gets reset and the asterisk clearly indicates it needs to have a value
limber skiff
no idea if it's a space or what
charred monolithBOT
half shell
\uFEFF
limber skiff
lmao
limber skiff
broo this bundler uses so much comma
all of this and I can't even see the semicolon
mortal fractal
all of this and I can't even see the semicolon
just replace a , with a ;, insert your own shit and then end it with ;let
i do it all the time when i dont care to find the return/a break in variables
limber skiff
just replace a , with a ;, insert your own shit and then end it with `;let `
lmao that's smart
I just inserted my thing there though
mortal fractal
i mean if you're adding to props anyways yeah that works
limber skiff
ye
austere talon
what i did in some patches was changing it to themeOverride_$: r = myOwnValue
rigid viper
.<
austere talon
forcing r to always be my own value
limber skiff
what i did in some patches was changing it to `themeOverride_$: r = myOwnValue`
also smart damn
dire thicket
betterfolders stll dead?
jovial forge
:)
charred monolithBOT
jovial forge
:)
limpid badger
sounds alright imo
nimble plaza
guh
absolutely not
im on mobile so cant review but can someone yell at them for that patch
junior olive
good
limpid badger
it's fine but who is using the app icons feature on desktop to begin with
if it was only on mobile then it would be alright but the fact that it's added to the desktop makes it look like cash grabbing considering that you have css
shy veldt
austere talon
can u not easily do this with css
long stream
can u not easily do this with css
maybe but imo its convenient and it just looks nicer
you could say the same about the banger plugin
wooden dawn
I'm having a smooth brain no wrinkles moment - I vaguely recall seeing a doc about setting up and creating a vencord plugin but I cannot find it for the life of me
austere talon
docs folder
dire trench
fake profile colors and effect using only 13 3y3 chars
there are 126 possible 3y3 values
im using the 126th as the separator and encoding the base10 profile colors and profile effect id to base125
charred monolithBOT
mortal fractal
there are 126 possible 3y3 values
im using the 126th as the separator and encodi...
yeah but you're forgetting that tag characters are 2 byte characters
dire trench
yeah but you're forgetting that tag characters are 2 byte characters
i did not forget
discord counts it as 38 chars
mortal fractal
exactly
dire trench
im just comparing it to the other plugin
anyone know why navigator.clipboard.writeText() converts \u{0000d} to \u{00020}?
it seems to only be happening with this character
not using this to copy in the plugin, just using it to test
dire trench
this is such an oversight
setTimeout(async()=>await navigator.clipboard.writeText(""), 3000)
limber skiff
I have something to say
woeful sable
fake profile colors and effect using only 13 3y3 chars
that's only client side right
austere talon
thanks i would have forgot nookies lmao
dire trench
that's only client side right
wdym
limber skiff
I did something
austere talon
that shit would have still been there in 2 years
dire trench
As in, should i be able to see it?
its saved in your about me and anyone with the plugin will see the fake profile colors and fake profile effect
mortal fractal
dire trench
it copies a newline for me lol
what does Clipboard from @webpack/common use to write to the clipboard
mortal fractal
its a cross platform wrapper
dire trench
hopefully whatever that is wont change codepoints
mortal fractal
if you're on web it checks queryCommandEnabled("copy") and queryCommandSupported("copy")
otherwise it'll use the copy function in DiscordNative
mortal fractal
yeah it doesnt use the modern clipboard api
otherwise it uses DiscordNative.clipboard.copy
interesting
frail skyBOT
limber skiff
@austere talon we love
mortal fractal
๐ฉ
mortal fractal
HTML
yeah did you not know that browsers copy raw html in some cases
firefox does
and discord used to parse it
endpwn had an install method that abused the fact it parsed it
using onload and onerror
the onerror would trigger when parsing the image for the upload shelf
mortal fractal
yeah it was
not anymore tho
this was like 2018 so
and it also abused the fact that native module require wasnt sandboxed properly
thus set the webapp/update endpoint to target for installing endpwn
frail skyBOT
mortal fractal
idk when im going to fix highlight pr for rspack
cause i also have to fix folder structure
dire trench
Clipboard does the same thing
\u{0000d} gets changed to \u{00020}
import { Clipboard } from "@webpack/common";
const num: bigint = 1139323101881061467n;
const base125Num: Array<number> = [];
for (let i: bigint = num; i > 0n; i /= 125n)
base125Num.unshift(Number(i % 125n + 1n));
const testString: string = String.fromCodePoint(...base125Num);
for (let i: number = 0; i < testString.length; i++)
console.log(testString.codePointAt(i).toString(16));
Clipboard.copy(testString);
why the redundant type annotations
dire trench
i like types
it correctly prints d at index 6 but \u{00020} gets copied to clipboard
though if i do Clipboard.copy("\u{000d}") it works
this makes 0 sense
austere talon
dire trench
no way im gonna manually build strings of escaped codepoints
the only way to do this is to use eval() ๐
charred monolithBOT
austere talon
should fix this undefined
dire trench
import { Clipboard } from "@webpack/common";
const num: bigint = 1139323101881061467n;
const base125Num: Array<number> = [];
for (let i: bigint = num; i > 0n; i /= 125n)
base125Num.unshift(Number(i % 125n + 1n));
const testString: string = String.fromCodePoint(...base125Num);
let stringToBeCopied: string = '"';
for (let i: number = 0; i < testString.length; i++) {
const h: string = testString.codePointAt(i).toString(16);
console.log(h);
stringToBeCopied += "\\u{" + h.padStart(5, "0") + "}";
}
Clipboard.copy(eval(stringToBeCopied + '"'));
not even this works
dire trench
```ts
import { Clipboard } from "@webpack/common";
const num: bigint = 11393231...
wtf this doesn't work either
Clipboard.copy("\u{00014}\u{0000f}\u{0002a}\u{0005a}\u{00033}\u{00027}\u{0000d}\u{00075}\u{0005d}");
actually wrong autumn
cunning canyon
ah
so it's just discord broke it
charred monolithBOT
jagged cloak
elements tab is just broken cause discord stupid lol
white bear
doesnt happen on vesktop but it does on vencord
proper badge
Hi Noah, this seems to be a function that captures the screen on an electron application however Discord's client doesn't make use of getUserMedia, they use their native node module instead
Btw Vesktop devs, I added Vesktop as a way to screenshare with audio on my repo here https://github.com/edisionnano/Screenshare-with-audio-on-Discord-with-Linux#for-beginners
austere talon
to answer your question: no there isn't, and it doesn't seem possible without replacing discords electron with standard electron
discord removed getUserMedia from their electron fork, so it is not available on discord desktop. unless there is a way to do it without it, it likely isn't possible
in any case, vesktop strives for (mostly) feature parity with discord desktop, so you don't really notice you're not using the desktop app
there are only a few features not ported, for example global keybinds
junior olive
venmic for macos
austere talon
does discord support audio on mac
junior olive
yeah they have a extension that adds it
idk if its a kernel or system
it's lame tho bc it's not needed
austere talon
venmic for macos
you make
junior olive
nuh uh..
austere talon
Also need to figure out windows audio share soon
proper badge
discord removed getUserMedia from their electron fork, so it is not available on...
yeah I'm aware, the fork is public
austere talon
the quality is so bad for some reason
proper badge
they have some patches that they apply on every release
glass elm
hi, is it possible to make plugin that improves the perfomance of discord? Make it less cpu usage and etc?
proper badge
but why would you use getUserMedia on the client? the biggest advantage of the client is it not using conventional webrtc
junior olive
nvm idgaf ab venmic on macos anymore
i updated the kernel extension
its still lame but it works
austere talon
but why would you use getUserMedia on the client? the biggest advantage of the c...
to retrieve an audio stream of venmic. directly patching discords voice stuff seems pretty unreasonable because it's all native. you'd need to patch the binary or use some hooking framework or similar
junior olive
so apple silicon users need to get it directly from rouge amoeba
austere talon
do you have any better idea?
junior olive
venbot not support
proper badge
to retrieve an audio stream of venmic. directly patching discords voice stuff se...
someone actually did that using frida
frail skyBOT
proper badge
they managed to add support for wayland and there's also an experimental branch for audio
my idea was rewriting the whole discord-voice module
white bear
btw is this a vesktop bug that the text just appears behind the titlebar when using transparancy(for context this isnt a real mac os titlebar its done with css)
austere talon
someone actually did that using frida
that's definitely out of scope, unless an outside contributor wants to work on that and their implementation is reasonable
frail skyBOT
austere talon
btw is this a vesktop bug that the text just appears behind the titlebar when us...
try to disable your theme and #๐ฅ-vencord-support-๐ฅ
white bear
try to disable your theme and <#1026515880080842772>
already tried a different theme and it does the same thing as i replace the original discord titlebar with the custom macos one wich would be transparent wich the default discord one isnt
proper badge
that's definitely out of scope, unless an outside contributor wants to work on t...
it's a bit hacky yes, frida patches on the fly but one could ship a pre-patched binary provided that this works
my idea was to rewrite the module from scratch
this was as far as I got
austere talon
my idea was rewriting the whole discord-voice module
like rewrite discords voice module from scratch? that seems very ambitious but also a cool project
proper badge
I haven't worked on it since january tho
dire trench
yeah im not proud of that variable name
i wanted to use i for the index of the for loop
but i also needed an index variable for the array
this took me 12 hours ๐
proper badge
this is basically a rewrite of the module, so far it has the basic skeleton, some stubs, it can list input, output and video input devices, it can ping discord's servers and rank them and it can also capture a webcam and present on video settings with 2 ways. What it can't do is everything else
livid heath
like rewrite discords voice module from scratch? that seems very ambitious but a...
The voice module helps en/decode sending/recieving voice data right?
Vesktop could always fork https://github.com/Rapptz/discord-ext-native-voice and work on that
austere talon
stock discord issue.
limber skiff
I did this on mobile
proper badge
The voice module helps en/decode sending/recieving voice data right?
Vesktop cou...
it does WAY much more
limber skiff
lets see if I got it right
proper badge
it basically handles everything when it comes to calls
limber skiff
shit I forgot to uncomment
knotty narwhal
anyone know name of watermark in top left corner
proper badge
I wrote a shim back then to intercept the function calls between discord and the module https://github.com/edisionnano/discord_voice-stub
Might seem stupid now but I didn't know much about it when I made it
limber skiff
@austere talon can you test if that option works for me?
limber skiff
it's okay, thanks
charred monolithBOT
charred monolithBOT
charred monolithBOT
rugged spire
@cunning canyon thank you this is very cute and unobtrusive <3
rare shale
olive aurora
not the eslint ignore ๐ญ
jagged cloak
not the guh()
olive aurora
you are both the same people
rare shale
you are both the same people
what
olive aurora
insane
rare shale
yeah wrong nea
olive aurora
wrong nea
rare shale
@hot pecan ๐ฅฐ
olive aurora
poor wrong nea
jagged cloak
kid named nea
topaz thistle
that's definitely out of scope, unless an outside contributor wants to work on t...
I could hook the responsible function on load of venmic
oak hull
how long until Discord implements this
junior olive
the code for this is kinda horrifying
like why does the func u use to get the user's auth directly open the modal to auth
charred monolithBOT
patent flint
@cunning canyon considering you're the pro here. Do you think, this way to fix it is acceptable? It was something with the animation i suppose
reef summit
sry if this is the wrong channel but how do i enable transparency on themes
nimble pendantBOT
sry if this is the wrong channel but how do i enable transparency on themes
reef summit
ok thanky
patent flint
sry if this is the wrong channel but how do i enable transparency on themes
Also that's for the themes themselve
You have to know css
reef summit
oh
cunning canyon
<@393694671383166998> considering you're the pro here. Do you think, this way to...
idk
reef summit
i was using that website online that edits stuff but i gave up rly fast and just decided to use dark+
purple cool so idm
limber skiff
<@393694671383166998> considering you're the pro here. Do you think, this way to...
is that a fix for freezing
patent flint
is that a fix for freezing
Si
limber skiff
hmm
I think it's not the animation fault though
it's it combined with something else
patent flint
it's it combined with something else
ic ic
limber skiff
the something else is the issue I haven't figured it yet
patent flint
the something else is the issue I haven't figured it yet
Now that you mentioned it. The way i tried to replicate the freezing did stopped... But, i think there is still other ways to freeze it
cunning canyon
it can freeze with only sideBar on alone
disable any of 1st 4th 6th 8th 11th patch stop it
exclude 1st 6th 11th, those just disable sidebar
4th is just for export value so i think issue on 8th patch
topaz thistle
@austere talon Do you know if the native module is contained in the Discord binary or if it is in a separate file?
topaz thistle
Happen to know where they are on linux
turbid hatch
wherever your app installs!
topaz thistle
I have no modules folder in /opt/discord
turbid hatch
interesting they're put there, wonder if its an autoupdater thing
topaz thistle
Happen to know if the screenshare audio stuff is in the voice or rpc module?
topaz thistle
interesting they're put there, wonder if its an autoupdater thing
Probably
turbid hatch
vvvvvvvvvoice
i believe
voice should handle anything relating to voice chat natives
austere talon
interesting they're put there, wonder if its an autoupdater thing
because discord install dir is root owned
they can't write to discord dir
austere talon
Happen to know if the screenshare audio stuff is in the voice or rpc module?
voice
rpc is game activity and such
topaz thistle
And does anyone by chance know which functions are responsible for the screen-share audio stuff?
austere talon
you can require them in console to inspect
DiscordNative.nativeModules.requireModule("discord_voice")
topaz thistle
I can see them in Ghidra as well xd
topaz thistle
discord::media::soundshare
That's probably the namespace we're looking for
I could reverse it and detour it at runtime when venmic is loaded to implement our own logic there
discord::media::soundshare::AudioDevice::Attach(unsigned int)
This is probably the method that's used to start the screenshare, not sure if the id that's passed there is useful for us, I can debug that when I'm at my PC at home
If that is indeed the method called for starting the audio share I could hook it and just start venmic
@austere talon Loading the Node Module in the desktop client is feasible right?
charred monolithBOT
austere talon
<@343383572805058560> Loading the Node Module in the desktop client is feasible ...
yeah ofc
charred monolithBOT
austere talon
desktop works quite the same as vesktop, you'd also need to just use ipc
topaz thistle
`discord::media::soundshare::AudioDevice::Attach(unsigned int)`
This is probabl...
@austere talon Could we also, in case the ID we get there is bogus, replace the id with the Node-ID for example?
austere talon
desktop works quite the same as vesktop, you'd also need to just use ipc
or actually if you'd just be hooking discord voice you might not even require ipc since it'll all be in main
topaz thistle
or actually if you'd just be hooking discord voice you might not even require ip...
I just need the venmic native module to be loaded, from there I can detour everything
austere talon
ya that's super easy
topaz thistle
Nice, I'll look into it then
austere talon
you can just import it somewhere in main, like here https://github.com/Vendicated/Vencord/blob/main/src/main/patcher.ts
topaz thistle
Alr nice
Will look into it when I find the time ^^
But if it's as simple as hooking the attach method that should be a quick implementation
charred monolithBOT
austere talon
But if it's as simple as hooking the attach method that should be a quick implem...
i doubt that'll even get called on linux
topaz thistle
i doubt that'll even get called on linux
Could be, if so I'll try and debug (JS horror, I'd rather read through assembly lmao)
Why would you hide the UI for venmic if a virtual device is selected
I guess you could add a warning box above the venmic stuff stating that you probably don't want to use both at the same time
hot pecan
not the eslint ignore ๐ญ
im sorry but that es lint ignore is entirely appropriate here?
tacit marten
Can I get some help with updating my PR for the new Discord update?
cinder moon
debian repo wen
tacit marten
Mine is a plugin that edits the loading quotes, but the problem is that I need help with using an async function to assign a value in normal (synchronous) context.
charred monolithBOT
tacit marten
._loadingText=function(){
How can I replace this with a call to an asynchronous function?
Before the update, I used Promise .then(), but this time it casues a react error.
austere talon
insane
dire trench
discord-types is so outdated :(
elder garnet
the platformindicator plugin doesnt update in chat for some people, until you click the profile and load it, is it possible to force it to update?
elder garnet
LMAO
topaz thistle
i doubt that'll even get called on linux
Sadly it's not that easy lmao
I'll find out what happens, just as a note: You have to explicitly patch the index.js to even load the soundshare module on linux (Suprisingly it doesn't crash what so ever)
At least the module has a lot of symbols which makes reversing easier
The module was compiled on Ubuntu 7
Holy fuck
cunning canyon
ven rejected it
tacit marten
Mine is a plugin that edits the loading quotes, but the problem is that I need h...
If this is considered too much of a noob question, tell me and I'll just stop instead of disturbing the convo.
tacit marten
where were you putting .then?
Can I send the match and replace?
tacit marten
return e[o.random(n.length - 1)].then?
Uh, this is unrelated?
lime stone
well you matched the random
hm, then you look for a semicolon, but idk where it would have been in the previous build ๐ญ
tacit marten
hm, then you look for a semicolon, but idk where it would have been in the previ...
I can explain the old one, but I think it would be faster to compare to Vee's loadingQuotes plugin.
The important part (currently) is this._loadingText=function() {
Vee changes it by adding return self.quote like this:
this._loadingText=function() {
return self.quote;
[rest of default code]
}
oh, i'm stupid
lime stone
The important part (currently) is `this._loadingText=function() {`
Vee changes i...
so do that then?
tacit marten
so do that then?
Well, how?
Since the function returns a promise.
Mine uses fetch, which is async, to get a random fact from Wikipedia.
lime stone
what did the patched code look like before
tacit marten
Before, I did something like this:
;$self.quote().then(quoteText => somvariable._loadingText = quoteText);
The semicolon is there because it was just a part of the code? As in, it was like ;somevariable._loadingText=someOtherVariable;
Hence it was easy to just replace someOtherVariable and use .then().
I hope I am making any sense.
Right now, it is included in an array, if I understood the code properly.
A constructor initializes the variables in an array.
tacit marten
The important part (currently) is `this._loadingText=function() {`
Vee changes i...
This is the relevant part that I want to edit.
tacit marten
The semicolon is there because it was just a part of the code? As in, it was lik...
Does this answer your question, KodeToad?
lime stone
so maybe make the function return this.randomQuoteLoadingText or something
charred monolithBOT
lime stone
then you can set that
tacit marten
so maybe make the function return this.randomQuoteLoadingText or something
Well, HOW? The problem is that it is an async function.
lime stone
this._loadingText = function() { return this.randomQuoteLoadingText; }; $self.quote().then(quoteText => this.randomQuoteLoadingText = quoteText);
tacit marten
this._loadingText = function() { return this.randomQuoteLoadingText; }; $self.qu...
I cannot add code after the function because I am editing value in an initializer array.
tacit marten
this._loadingText = function() { return this.randomQuoteLoadingText; }; $self.qu...
Also, wouldn't returning an async function return a Promise value that is not useable?
self.quote() is an async function.
async quote() {
return quoteText
}```
`quoteText` is the value extracted from `fetch()`'s json.Well, I updated it for the new code, it produces a minified react error.
lime stone
what is the error
tacit marten
Any clue how to get the proper error?
tacit marten
Well, I updated it for the new code, it produces a minified react error.
^
Just tell me how to get the proper error and I'll send it here.
lime stone
it usually has a link, doesn't it?
tacit marten
One sec please, let me reproduce.
charred monolithBOT
tacit marten
Btw in this case, I'll have to replace the whole existing function because it will be obsolete.
Aka use this rule:
match: /(.{0,10}\._loadingText)=function\(\)\{.+\}/
lime stone
are you sure that matches the function?
lime stone
that will match past the function ๐ญ
tacit marten
are you sure that matches the function?
Double checking.
lime stone
if it's greedy it will swallow other functions
tacit marten
if it's greedy it will swallow other functions
Oh yeah I remember that problem.
lime stone
if it's lazy it might get stuck on something inside the function
lime stone
yes
lime stone
then it might stop before the end of the function
tacit marten
then it might stop before the end of the function
Let me check if the function has any extra }.
Yup, it does.
lime stone
so try putting random
charred monolithBOT
lime stone
{.+?random.+?} ๐ฟ that's ugly but it should work
tacit marten
so try putting random
random? What does it do?
lime stone
makes it work some of the time
tacit marten
Btw another and cleaner fix is to change it to }(),.
tacit marten
Updated:
match: /(.{0,10}\._loadingText)=function\(\)\{.+?\}\(\),/,
Time to test.
Now I get this:
Current replacement rules:
replacement: [
{
match: /(.{0,10}\._loadingText)=function\(\)\{.+?\}\(\),/,
replace: "$self.quote().then(quoteText => $1 = quoteText),",
},
{
match: /(.{0,10}\._eventLoadingText)=function\(\)\{.+?\}\(\),/,
replace: "$self.quote().then(quoteText => $1 = quoteText),",
predicate: () => settings.store.replaceEvents
}
]
}(), should match the ending of the function.
Tried testing the match on a regex site, looks good, thankfully.
Actually turns out it matches earlier than it should.
Now it magically works, thankfully!
Thanks for the help!
Had to use Notepad++ to format the code to be able to properly read it, how the #%&#$ do you format it in VS Code? When I paste the minified code, it just LAGS.
tacit marten
devtools can format code for u
How? I am a noob.
limber skiff
it can freeze with only sideBar on alone
disable any of 1st 4th 6th 8th 11th pat...
god sent
limber skiff
How? I am a noob.
click the {} button on bottom left
turbid hatch
it does
charred monolithBOT
turbid hatch
it doesnt log your PRs
that would involve us leaking our webhook info to your forks, which is a bad idea
tacit marten
that would involve us leaking our webhook info to your forks, which is a bad ide...
No no no, I was referring to the force push in the PR.
tacit marten
click the {} button on bottom left
OH, thank you!
Didn't notice that button before.
turbid hatch
the notifications are done through github's notification system - our repo has the notification hook, yours won't, so when you push code we don't get told about it because your PR's commits is hosted on a different repo
tacit marten
the notifications are done through github's notification system - our repo has t...
I got confused because I forgot that the normal commits in PRs don't get included in the notification, only the comments and reviews get posted.
My bad.
Got it, thanks for the explanation!
topaz thistle
The JS-Code on Linux doesn't even call into the native module on Linux (at least for the Screenshare part, for audio it obviously does)
So to debug this there'd need to be some serious patching to the JS side and I'd probably need the JS-Code that's loaded on the Windows client to cross reference some stuff
(I've enabled soundshare in the index.js of the module, so this seems to not impact the other loaded js code in any way)
This new Media Gallery thing looks so fucked lmao
topaz thistle
The JS-Code on Linux doesn't even call into the native module on Linux (at least...
In case anyone has a JS Dump from the Windows client that'd be helpful ^^
summer hull
i got a plugin idea that could be useful
https://github.com/localip/dnd-bypass this thing
nimble plaza
summer hull
they closed it
charred monolithBOT
lime stone
WHY IS IT ZOOMING IN LIKE THAT
u love mosaic
woeful sable
u love mosaic
it shouldn't be affecting single image messages?? ๐ญ
austere talon
IT DIDNT SHOW ME IMAGE 2 AND 3 WTF
lime stone
diskord moment
woeful sable
IT DIDNT SHOW ME IMAGE 2 AND 3 WTF
me either
topaz thistle
IT DIDNT SHOW ME IMAGE 2 AND 3 WTF
Had the same problem
Instantly enabled Disable Mosaic lmao
austere talon
discord moment
topaz thistle
Would you be willing to help me dig through that?
I can reverse the native stuff
Just need to get Discord to actually call it lmao
austere talon
the audio stuff?
topaz thistle
the screenshare stuff yeah
midnight raven
topaz thistle
diskot moment
proper badge
hey all
rancid dragon
*hey y'all
proper badge
I smell soundshare talk
topaz thistle
Yeah
proper badge
what's the issue?
topaz thistle
we'd both have to look into it
That's what I meant
topaz thistle
what's the issue?
Look at my messages above
topaz thistle
Ah lmao
proper badge
Look at my messages above
discord isn't calling discord_voice.node?
for screenshare
topaz thistle
Yes, all the functions that would signal that soundshare is supported are hard coded to error out
(In JS)
(I don't know where the problem is)
tacit marten
IT DIDNT SHOW ME IMAGE 2 AND 3 WTF
Same.
tidal cloud
any reason why telemetry is opt in on next restart? I understand it's very little but it just reads like "oh so we are going to collect data about you next time, unless you do something it about it lol"
charred monolithBOT
turbid hatch
that's if it gets merged
junior olive
yah
lime stone
you can put that in the pr
turbid hatch
any reason why telemetry is opt in on next restart? I understand it's very littl...
so you have a choice to not have anything sent
proper badge
Yes, all the functions that would signal that soundshare is supported are hard c...
I think the relevant function is setDesktopSourceWithOptions
turbid hatch
i dont quite understand how that is a bad read
it's more ethical than any telemetry solution i've ever seen
lime stone
so you have a choice to not have anything sent
why not send the data when the user accepts
turbid hatch
why not send the data when the user accepts
because the telemetry probe is only ever sent once
we aren't constantly sending data
tidal cloud
in my opinion telemetry should be very opt in, like if the user decides one day
turbid hatch
we send it once after startup and it's over
turbid hatch
in my opinion telemetry should be very opt in, like if the user decides one day
then we'd never get any data that's worth it
lime stone
why not send it once when you accept and once on startup from then on
turbid hatch
because it's easier just to say "hey we'll send telemetry next time if you don't turn it off"
junior olive
Yeah this is harmless telemetry
lime stone
because it's easier just to say "hey we'll send telemetry next time if you don't...
that may concern some
turbid hatch
..how
we're informing you of its existence, we havent sent anything yet, we'll send something next time if you leave it on
is it the wording?
junior olive
Lewi just turn telemetry into a userplugin /j
turbid hatch
???
yes thats the point
you get an option to turn it off
before we send anything
lime stone
that will make people feel like you are taking advantage of laziness
turbid hatch
and if you dont turn it off
charred monolithBOT
tidal cloud
that will make people feel like you are taking advantage of laziness
mostly what I meant
turbid hatch
if you're that lazy that you cant click two buttons to turn it off then god help you when you want to add a theme that takes more than that
i literally give you a link to settings, and then it's there in the settings where to turn it off
i dont understand how i can make that any easier
hm
oh i know
lime stone
just say
do you want telemetry?
yes | no
turbid hatch
that'll work
topaz thistle
I think the relevant function is setDesktopSourceWithOptions
Which always passes null and false
tidal cloud
I'm ok with telemetry personally, just that starting to probe on next restart seems fishy to me
turbid hatch
ah but what if you dismiss it
junior olive
ok but use the power of Jedi mind tricks and have it be no / yes with no grey and yes green
turbid hatch
I'm ok with telemetry personally, just that starting to probe on next restart se...
i actually dont understand this viewpoint though
junior olive
we all know what most users will do with that
topaz thistle
Which always passes null and false
Because all other relevant functions are basically empty
turbid hatch
i would prefer it if software asked me first before sending telemetry
rather than sending telemetry then asking me
like most software does
the "on the next restart" thing is literally developer convenience lol
tidal cloud
wait sorry worded it wrong
calm wharf
It's the fact it's not opt in - yes it's better than telling you after the fact, but it's still not opt in
tidal cloud
yeah this thanks
calm wharf
People don't like opt out for tracking/telemetry
proper badge
Because all other relevant functions are basically empty
that's weird, I'm not home but I can check in a bit
lime stone
the "on the next restart" thing is literally developer convenience lol
what's the purpose of the startup ping
i meant to not ping you in that message ๐ญ
proper badge
you can try my shim https://github.com/edisionnano/discord_voice-stub
calm wharf
ah but what if you dismiss it
I'd not send telemetry and show the message again on next restart until they actually say yes/no
lime stone
ah but what if you dismiss it
just make sure the user doesn't
some dialogs already do that
topaz thistle
and the arguments passed
Already had a breakpoint on all of them
I don't think the shims gonna help a lot, but I might try it the next few days
proper badge
Already had a breakpoint on all of them
I don't think the shims gonna help a lo...
do you still want the windows module?
topaz thistle
No not the module but the all of the JS that's loaded on the client
junior olive
It's the fact it's not opt in - yes it's _better_ than telling you after the fac...
yeah but as it's been said before if it was opt in they would get no useful telemetry
calm wharf
That's basically admitting that you need to be scummy to get data
oak hull
is it not simple as asking the user if they consent for data or not
and is that not what is happening here
tidal cloud
mostly yes and no
proper badge
No not the module but the all of the JS that's loaded on the client
the files loaded from the server?
turbid hatch
People don't like opt out for tracking/telemetry
alright, i'll add the option to the dialogue
turbid hatch
what's the purpose of the startup ping
version, plugins at time of ping, os
proper badge
I think these are the same regardless of the platform
turbid hatch
we arent sending a live feed of what you're doing
turbid hatch
and is that not what is happening here
no i understand the viewpoint now
proper badge
I will take an extensive look on the module in about an hour
turbid hatch
it took me a little bit because i've obviously been looking at this one way
proper badge
what have you done so far?
turbid hatch
the point is that the current notice assumes an implicit "yes" from the user
when it should ask explicitly
proper badge
how deep are you in?
turbid hatch
otherwise what's the point of notifying at all
topaz thistle
I think these are the same regardless of the platform
I don't think so, look at my message above the functions are literally hard coded to throw
topaz thistle
what have you done so far?
Disassembled the linux native module, debugged which internal native functions are called
oak hull
no i understand the viewpoint now
๐
calm wharf
no i understand the viewpoint now
Now if only big company developers could do the same ๐
proper badge
Disassembled the linux native module, debugged which internal native functions a...
I see thanks. I had a node playground and I got the module to capture the screen, iirc soundshare was a different function. setOnSoundshare or sth like that
I will check again to see if things changed
topaz thistle
Yes, the set callback function is indeed called but the callback passed to it is never called nor the failed callback
proper badge
Yes, the set callback function is indeed called but the callback passed to it is...
for soundshare?
turbid hatch
@tidal cloud @calm wharf how's this
topaz thistle
Yep
turbid hatch
proper badge
did you declare it as supported on index.js?
@austere talon would a #soundshare-dev channel be a good idea?
austere talon
you can make a thread if you really want, but i generally just prefer normal channel
more accessible
ancient timber
hey! I made a lil theme that replaces the default throbber with a lil shiggy gif
cant put it in css-snippets
austere talon
now you can
topaz thistle
you can make a thread if you really want, but i generally just prefer normal cha...
Would also prefer normal chat ^^