#👾-core-development
1 messages · Page 120 of 1
my plugins arr ususlly all doable with flux dispatcher events thankfully
except the patch i stole from somewhere that replaces playing with watching
was looking at some random js file and it was full of loops with single letter variables

average vr recording
wtf
INSANITY
nop
can you shiggy in vr
if it alllowed images in the body lol
make your character shiggy
okay one more time replay and say something silly
perfect
:3
i believe so
I can't proxyLazy a memoized component
well
I want to memoize a discord component for use in one of my modals
there was
bc when the user is typing text in a field the component rerenders and it causes the pfp to restart animation
Ima sleep but i want to memoize findByCode("AvatarDecorationModalPreview")
i cba to get error
i'm getting insane lags that vee was talking about
i'm getting insane lags that vee was talking about
i'm getting insane lags that vee was talking about
i'm getting insane lags that vee was talking about
i'm getting insane lags that vee was talking about
I know
'tis done, review at your own convenience

finally got that shit out of 6month git stash purgatory
Arch Linux (6.5.8-zen1-1-zen)
Hyprland
vencord-desktop-git r209.19c3112-1
If you update Vencord this should be fixed. Discord changed a lot of compiler settings recently which made everything :nyaboom:
Nuked the vencord folder in .config, seems to have fixed it. I thought I had updated it because I updated the package, apparently not.
Probably leave this open for a bit so its easy for other people to find?
When launching Vesktop in a FreeBSD Linuxjail using a wrapper that usually works for Discord I get the following output:
halley~⇥ vencord
No matching processes belonging to you were found
W: [(null)] caps.c: Normally all extra capabilities would be dropped now, but that's impossible because PulseAudio was built without capabilities support.
executed this shit! (wexp)
[52490:1026/133442.734212:ERROR:file_path_watcher_inotify.cc(822)] Failed to read /proc/sys/fs/inotify/max_user_watch...
FreeBSD is not supported. the error is very self explanatory, and an issue on your side
istg if he brings back polyfills im combusting
tsoding is cool
Any chance we could have these re-ordered? Personally, I'm very used to "Paste" being the bottom-most option.
Vesktop:
Discord PC:

?
i think they shouldn't be using Object.hasOwn cause even i hesitated to use it in vencord since its somewhat new
but why would they handle errors of js globals potentially not existing
at that point they should just polyfill again
🤷♀️ what if you run in internet explorer
i doubt pre change code worked in ie lol
that's probably a white screen xd
duh? don't use IE
though yeah hasown is like really new
it doesn't feel that long ago that you could use modern websites in IE 😭
but yeah lmao
you'd at least expect that to be polyfilled for the people with an ancient host still on electron 13
if you are using Internet Explorer now you are living under a rock
still seems there's these two issues in vencord after the fixes:
ShowHiddenChannelsPlugin doesn’t allow channels in categories to collapse if there are unreadsImageZoomPlugin minimizes/dismisses fullscreen preview of image when magnifying and left mouse button is released
(just sending here so they can be noted)
the latter has a tracking issue
i do have a question, unrelated to what happened. if i wanted to make a request for two different plugins to be made compatible with each other, where would i do that?
example: currently, with NoReplyMention, you can set specific users to have it default OFF to, but the QuickReply plugin doesn't respect those options.
(genuine question, sorry if it's stupid)
since i started using it like a few days ago it doesn't
can you show what settings you have for quick reply
ye will do in a few mins when i get home
first hacktoberfestf spam pr?
lmao
a repo i maintain had a pr to add a full stop
😭
first time they put it after badges
Why so many typo or
then they realised that a series of badges is not a sentence
Prs*
actually we got two prs
Hmm
mm okay nvm, sorry to waste your time. apparently i only had it set to "enabled" instead of the correct option "follow noreplymention", don't mind my blond moment
😭
they are prs from the guy above
gitmuslim 😭
Could have like fixed the previous.
i probably should have blurred their name
there was also this
it changed a single word 😭
where are the add typo prs
interesting typo
it's giving 
🤨
hmm
Is that star repo armies
Starmies? 
Mhmm
where i report bug ? in github ?
thx
Is that the cursed photo thing
It seems as if getting banned on discord is becoming easier
maybe this should be implemented in vesktop
not sure if i mentioned it but i'm pretty sure it's new
...so i probably didn't mention it because it didn't exist 😭
déjà vu
i think i just talked about something similar
the opening channel links?
try implementing it yourself
but arrpc likely needs to implement it
this is how invite launch works
but i doubt arrpc supports message links
i think i talked about implementing it before discord did with a custom extension (but that would be a pain)
but now discord has implemented this feature
it does not
updated my plugin pr to fix new changes 
i currently have these 2 issues https://github.com/Vendicated/Vencord/pull/1779/files#diff-ed33dde8091b3e7de06464ee8c12501020a7dbd3a0554eb48a08eeb2308126c3R23-R24 and i cant figure out how to fix them
how do i know if openasar is working
Why so many stars
i like the way discord's official app's rpc doesn't work but vesktop's does
wait when could we talk here?
also contains #28 because i'm silly and forgot to switch base branches :P
hmm so many people starring
did you find vencord yourself or somewhere
myself lol
i think we're the only functional mod
no like
BD is badly broken
yeah
I assume a lot of people basically switched as bd died
I found it from a youtube vid about client mods
So this is a storm of new Vencord users coming from various mods
Ive been using vencord for a while now
Long time ago here for me, early 2023
macOS Gatekeeper will prevent this from working properly, and we aren't spending the money on an Apple Developer Account at this time because it's such a waste for a false sense of security. It sounds like this will cause a lot of annoyance for Homebrew users if we don't sign.
Still broken: EmoteCloner, petpet
I think I’ve been using it since 5 months ago
I don’t remember exactly
also petpet
<< emoji
and message logger has a small bug if you edit a message with a link with embed
Since https://flathub.org/en-GB/apps/xyz.armcord.ArmCord is there I doubt it would be problematic.
i will take a look at automating this
and then we can just forget about it
similar to winget
we should have a way to test finds using the reporter
maybe we load all chunks and then test the finds
another one of these
we could have a special mode where find calls add to an array so we can test all later
so many modules have names and can be findbyprops'd now ❤️
what if they end up unnamed and proxy functions in the future
nvm, am i misunderstanding it 
uh kinda possible
flatpak is weird
yeah it is possible
i think i've fixed EmoteCloner lol. it was pretty easy.
we'd need to monkey patch lazy webpack finds and then force run all of them after loading all chunks
we just have to execute the finds after we load every chunk
yep
I will do it today
it's a very good idea
ill fix the webpack patch issues soon
nice nice
no
hm
in which case this is going to be annoying as shit
flatpak is the most horrible system
but we should likely just write the initial flatpak manually for the best experience
then we can automate updating it
that's what im trying to work out
updating it just means updating hashes, links and version
maybe
don't do from scratch
hm, i wonder if you could get RPC to work
definitely not a github action though that's sane, might have to write my own 
check out armcord and discord flatpaks
and copy paste
ive been meaning to work on flatpak for ages, just been preoccupied with other stuff
it goes to /run/user/1000/app/app.id.here/discord-ipc-0 iirc
yes
discord flatpak has a workaround
you need to link /run/user/1000/discord-ipc-0 to /run/user/1000/app/com.discordapp.Discord/discord-ipc-0 which is annoying
yeah just taking a look now
yeah^^
this feels like a massive hack 
the chat is moving too fast for my brain
Just wanna give all you devs props for fixing Vencord so fast yesterday ❤️
I was watching this channel a bit and saw you guys zoomin' 
i can probably just use sed
to autofill in some manifest stuff
it'll be good enough
SED
THEIR OFFICIAL FLATPAK
USES SED
LOL
THIS IS AMAZING
"sed -e 's/Icon=discord/Icon=com.discordapp.Discord/' -e 's|Exec=/usr/share/discord/Discord|Exec=discord|' /app/discord/discord.desktop > /app/share/applications/${FLATPAK_ID}.desktop",
I LOVE
does vencord really installs the installer to just inject?
wait when could we talk in here?
no(?)
Am I even allowed in here?
yes
re: this. sorry about the necroing a pr. i'm dumb and didn't realize i was on a pr and not an open issue. but i'm curious what version of glibc I should have for vencord, and if you happen to know what version of ubuntu i should be on to get it?
run vesktop from terminal and it tells you
i mean hey I anit complaining
in any case it might work on latest ubuntu (not lts)
i'll probably just do a detached fork of the armcord manifest and change it
you should just switch to the flatpak eventually, that will fix the glibc++ issues
ive been thinkabout getting vesktop. is it really all that worth it?
it sucks that C++ is like that
yeah but i have a jackbox event i'm streaming for this saturday so i need a fix before then 😭
try it and see - also while yes anyone can talk here, this channel is for development. so general questions like that belong in #🧊-off-topic-iceman-only or #🏥-vencord-support-🏥
run the app from terminal and see what it comlpains about
let see
run from the terminal and it'll tell you the glibc++ version. or just try installing gcc version 13
how else would we install vencord, other than with the installer?
hmm alrighty
okay it needs 3.4.32.... now to figure out which version of ubuntu has that
like i said, just trying to install gcc 13 might be a good idea
yeah thanks, i'm getting there 
according to StackOverflow™️
sudo add-apt-repository ppa:ubuntu-toolchain-r/test
sudo apt-get update
sudo apt-get install --only-upgrade libstdc++6
try that
but yeah it does say gcc 13 so either or
ven you will merge vencord.dev#two9 NOW
reminds me i need to dye my hair pink again
it works!!!! thanks vee ❤️ you're my hero
it kinda reminds me of google chrome chan in a way
i really dont care just wanted to know why, also does execFileSync work on windows because it seems to not been launching at all the launcher
hmm, maybe we could detect the glibc++ error and display this fix to users?
doing that will be difficult depending on the error
well surely you can check what glibcxx versions are available
yes, easily, but are we loading before glibc++ is?
well
i guess we can shell script it
cant we
macOS Gatekeeper will prevent this from working properly, and we aren't spending the money on an Apple Developer Account at this time because it's such a waste for a false sense of security. It sounds like this will cause a lot of annoyance for Homebrew users if we don't sign.
At least you can open them, because upgrading them with releases is a pain
if [ glibc we want is not available ]; then
cry
exit -1
fi
run vesktop
it drives me nuts that discord hasn't figured out basic features of their app for linux users. 😦
thank you so much for making it usable
yes
okay
it is not worth it
i know
it is not worth it
i know
don't do it lewi...
i'm pissed off with the amount of issues we have because of that fucking gatekeeper
and i know this is exactly what they want people to do
shrimply do not support mac
they want people to cave in and buy the account

but we have a lot of people who actually use mac and i want to at least give them a good first time user experience
apple is just evil, it's now 2023 can we already stop buying their products
userscript
<Billionaires> $100 is reasonable right? that's like, a whole minute of work!
is terrible
i mean i don't think anyone has ever complained beyond the having to right click the installer to open it
userscript is literally a last resort option 
it's really whatever
well i cant use anything else on firefox and it's good
also, someone said universal binaries don't need signature
does electron support this?
i will bet: no
this is a half-truth
we could give this a shot
it just combines multiple .app
funny mac moment
wait electron builder literally supports universal
asking me to come back

contrary to popular belief i am not a crippling alcoholic
whyd you give them your email
how'd they know you were there
yes
i have notifications on for the stuff i work on
:P
oh are you saying they're two different emails
yeah
i thought that was the subject of the spam mail 😭
oh no lmfao
ofc i have email notifs too
i use *@lewisakura.moe
bro I use this stupid hamster emote too much but I love it
and for sorting
I get millions of them mostly repos
https://x.lewisakura.moe/23/10/chrome_2023-10-26_14-22-33.png god i wish i was rich enough
"only" 
lewi is unstoppable
he sees, wants, gets
if i sign it we're saving $5
oh wait i just realised
it'll say "Vesktop by Lewis Crichton" on it
crazy that the usd is so cheap now a days
because we arent a company so i cant put a custom name there
that's SHITE
fuck it
ven, want to establish an LLC?
if we don't sign it, we're saving 100$ 
HOW
literally just a "create a delaware tax haven company"

wait a minute
wait holy shit we would actually have stock in this theoretical company
that's fucking hilarious
i want to have vencord llc stock
Vintage Energy Ltd
Vencord Apple Signatory LLC
LEWI WTF
for the small price of
vencord stock
500 DOLLARS

HOLY SHIT
worth
actually that's not a lot of money
for establsihing a company half way across the world
in a tax haven
owned by stripe
where you dont have to do any of the legal shit
lewi you don't seem too good with financial decisions
and you get an IP assignment
oh no im very good
sometimes
first the license purchasing now you want to establish an llc 
think about it ven
Vencord is trending today :)
we'll even have a Delaware Company Agent™️
that's cool but also not even the first time 
unironically vencord breaking is good for us
NOOOOOOOOOOOO
vencord breaking = we gain popularity
deliberately breaking vencord again soon so we get more users
ah ye I see
just like elon musk does ?
I wonder how many days it will take devilbro to fix his plugins
I mean unironically yeah
it's just moving the legal part of tax payment between a person and the company itself
interesting
the fact that he's doing all these terrible things to twitter makes it the talk everywhere
STOP STARRING
negative attention is still attention
"there is no such a thing called bad adveristment"
OMG it's full of stars
what wh
this!!!
just starred to spite you 🤞
Lots of people are switching from various mods lol
That's a mood
our relations are already bad enough with devilbro
other betterdiscord is meh
i think this already happens enough without us doing it
like one guy going "omg bd so broken" and then some other person telling them to hop on vencord
I was using discord screen audio before
we even get a vencord bank account
It’s the same cycle of telling someone to use alternatives
i wonder what's gonna happen to that once vesktop becomes more widely known
oh yeah we really should create https://vencord.dev/vesktop soon and advertise it way more
vesktop is in a really good state now and id like for more people to know if its existence
I always wondered on why Vesktop wasn’t on the site
Yk
I'd offer to help but I'm waist deep in my own projects 😭
christ okay so i can either pay $100 a year for a personal apple licence or spend like $600/yr for a delaware corporation, then an apple dev licence
way too often do people go "omg i wish I knew about vesktop before this is so good"
i love the "pay taxes" button
why do you even want the license? what benefit would it actually give us? sure it's annoying, but i don't think users having to right click > open is inconvenient enough to warrant 100$
it has never really been that big of a deal, everyone just makes do
as an LLC you can use that to then fund said "LLC" essentially it means unlimited PC/Food/ECT.
i have a dev account if needed but its under a weird name
because i have a strong belief that if we did that more people would actually use the desktop app
also it means i can do tax writeoffs on whatever i buy as long as i use it for vencord development
:^)
/s
i mean not really unlimited but it goes back on taxes as a write off
is there even much mac users
also i dont want a random vietnamese person signing our product
yeah fair
i wish apple did open source discounts or something
It depends considering that the majority of people are windows users
I use a Mac for work
you know what would be really useful to determine the viability of an apple developer licence?
Telemetry!
I hate it
With Vencord Telemetry we will be-
if i go any further ven will probably hire a sniper

i swear if i ever get into an accident and can't come online for a few weeks i will come back to lewi having created a telemetry empire
yes.
Daddy IBM pays the bills though
I WILL HAVE MY NUMBERS
vecord with ads when
I WILL HAVE EVERYTHING
I WILL MICROOPTIMIZE THE SHIT OUT OF THIS PRODUCT
WITH NUMBERS
look in #🧊-off-topic-iceman-only pins :3
is this actually something you can do?
yeah lol
if you buy something personally you can write it off if it ends up getting used by a company
Uhh then what you will get
a lot of people establish companies just to do tax writeoffs because their projects are under it

wait for next april fools
it's basically ordering stuff under the company to 'use' by the company, and as long as you actually end up using it for something you're perfectly legal
are you sure it's not bd breaking
and replugged
github default pfp people
that guy has java app
hey i used to have the default pfp
delete random core file when
LOL
I never thought default pfp people had repos
it is impossible for a pfp to be too gay
blue hair = gay confirmed?

Please set up a security policy so we can report Vulnerabilities .
uh what
ven is blonde, i can sense the nordic blood in their body
?
🤨
just report on github lol
What the fuck was that

everyday I wonder what kind of vulnerabilities you can find in a simple installer
reporting vulerabilities publicly isn't the greatest idea
well yes
BUT THIS IS A INSTALLER
everyday I wonder what kind of vulnerabilities you can find in a simple installer
well i will report one .
I mean, it’s still not safe even if it was a installer…?
bet it ain’t a real vuln
if they've genuinely found an issue couldn't they use modmail for now
I want to watch this
yes LOL
Lemme just prepare my popcorn
either join our Discord server and use modmail, or email vendicated@riseup.net. you may use https://vendicated.dev/pgp_key.asc.txt for signing your email
ven loves signing emails
need to verify that ven sent the email to ven
im too used to using gpg to sign my commits
i wonder what the junior penetration tester from algeria found in our product installer
i wonder if it drops files
Let’s see lol
Basically this is #177 but not fixed by doing what that person did.
Things i tried:
- Nuke Vencord in ~/.config/Vencord
- Update from tray icon
Both options don't do anything. Also launching vencorddekstop from terminal does not output any logs in the terminal.
Distro: NixOS
Kernel: 6.5.7-xanmod1
Gpu: AMD (mesa 23.1.7)
"fun fact if you execute the installer it installs" 
although to be fair, we should actually have a properly stated security policy
that would be a good idea
oh it's a nixos user
common nixos moment
he has tryhackme account
HAHAHAHA
I love that we noticed that at the same time
it's always nixos that has these issues
lmfao
god I hate tryhackme everything is paid
Vencord is not supported on Nix or NixOS officially (we do not maintain the package override), and therefore we will not provide support.
why nixos users exist
oh yeah ven
wailsinstaller™️ is basically done i think
we just need to test it further to make sure it works
I want to see my stats. How do you get this
but i think we can release it
there are some websites that generate for you
just google
this is most likely an issue with your system. it works fine on every major distro. make sure you have your environment properly set up. you could also try running with --disable-gpu
Could just use some simple distro
I would want answer to both questions
yeah, idk why it's always nixos (and also arch) users doing that. you never get issues like that from gentoo users
gentoo users learned to cope with their broken setups I think
B-
sheeesh
mm
cause we did finish it
i want to fully review it before that
alright
idk about that stat though. just a c?
it is done though from what i remember
ill check it out soon, i have some more important things to still do rn
yipyip
(i say that as im chilling in bed bantering about nix and gentoo users)
lmao
you mean arian blood?
do i count as a programmer
i've been too busy to code recently
https://cdn.auravoid.dev/images/share/VtKr7K8fbD5Q.png


im blonde, blue eyes. but not tall
i mean i basically beat my stats from last year. 200ish contributions last year and this year 1300 contributions
arian it is then 
ve exposed
Got B- lmao
The Github Readme Stats spam is real holy
i'm A 
this thing is definiletly racist
I am sure
how am I A-
negative point to turkish people
ven is A+ which means its made by german people
correct
yes
extra point to germans
Maybe over all commits count?
The logic is explained in the repo of the guy that made these btw
i don't think it counts stars in orgs
Not sure where though
because i should have 200+ stars
It doesn't - sadly
scwumplex
I KNEW IT
about that guy who opened a BSD issue on vesktop yesterday
I wonder how vesktop would even work on bsd
our code switches over process platform and expects it to be either of the three
yes
sefa eyeoğlu is turkish name
so it might just error even if U get it to run
help
do
ven when will you give me riseup email
im going to start planning telemetry 
do not harrass the vending machine

well i lied im going to write code
power poisoning
but it'll be pseudocode
invites closed
if vencord ever reaches 10k stars lewi would fill it with adveristment
have been for like a year now
no that's across the line

i wouldnt fill the mod with ads
wrong
you would just put too many ads
not fill it with ads
vencord 1.7.0 ads and telemetry update
Fr
hi
i didn't get time to react because dicsord crashed
it's still erorr?
vns
lol
!!
sounds like a minecraft update
yes jt is
either join our Discord server and use modmail, or email vendicated@riseup.net. you may use https://vendicated.dev/pgp_key.asc.txt for encrypting your email
Done .
LOL
The Vencord Installer codebase allows for user input from command-line arguments, specifically the
locationFlagandbranchFlag, without proper validation or sanitization. This lack of input validation exposes the application to the risk of command-line injection attacks.
what
I’m confused by this
is this ai generated
good cause it doesn't make sense 😭
why do I felel ike this is chatgpt jumpscare
Probably
you tell it where to install...
and it.. installs there?
that's the vulnerability?
chatgpt
there is no way that guy wrote this himself
Isn’t that’s literally what the installer is about
it just looks ai generated
it does
ai gen alright
especially because we do have validation
its ai generated
like
100%
please dont use chatgpt to submit security reports
you cant just point it to system32 and it overwrites the entire directory
thats not how it works
This is just ridiculous
ugh
but even though it is chatgpt
it is nonsensical
you cant do anything by providing cli arguments
chatgpt often generates nonsense
actually yeah
its normal
- The development team should immediately address this vulnerability by implementing the suggested mitigation steps.
- The code should be reviewed for other potential security vulnerabilities, and a comprehensive security review should be conducted to identify and remediate any further issues.
- The development team should establish security best practices and integrate them into the development process to prevent future vulnerabilities.
do this
why would you even use command line injection when you already have the ability to execute binaries on the host

what the fuck is
command line injection
like i understand what it is
but not in the context they're using it
is passing command line arguments injection?
apps like vencord installer inherently cannot have vulnerabilities unless we messed up something like the github downloading and somehow you could abuse that to download malicious files
my understanding is that injection is where you have a shit shell script
or rather, they can have vulnerabilities but they cannot have any impact
9.9 critical vulnerability
hroror
that's like finding a bug in a minesweeper game


I wonder what tool even is that
why
there was some guy doing the same thing
:youtried:

it should be some website that scans github repos and creates a report
I want to eat oreo
i remember using something like that before
I saw vitepress being used for docs and vitepress is awesome
show
does this still work
alright thanks good friend
🐸
i should clone the "bettervencord" fork and see how bad it is
actually no i shouldnt
the storm has settled :v
ToadMod
it uses browserfs 
wth is bettervencord
itll kill my indexeddb
found it in vencord's forks, lemme find it
its vencord with bdapi
horror
why is this starred
omg i forgot about that person
look at your github "following" feed
its named vencordplus now
tbf we pushed like 100 commits in the last 2 days
because there's another star
The cutest Discord client mod + BD plugin support. Contribute to Davilarek/Vencord development by creating an account on GitHub.
that
So it's really just slightly out of date
hell
thats... scary
yeah
I was considering to do same thing in vencord plus but was too lazy
i would clone but itll kill my indexeddb and i dont wanna clear it
yeah
fuck it ive already reset vesktop recently, might aswell
ill do it next class
what even was that false installer vuln lmao
devilbro jumpscare
that the arguments change the behaviour of the program

"it's called Vencord because it's made by ven,
it's called BetterVencord because it's bettter than Vencord"
- Davilarek
@teal halo
Code Vulnerability Report
Project: Vencord Installer
Prepared by: Rafik Saifi
Executive Summary
This vulnerability report aims to address a critical security concern identified within the Vencord Installer codebase. The vulnerability pertains to the potential for command-line injection, which could allow malicious actors to execute arbitrary commands on the system where the application is running.
Vulnerability Description
The Vencord Installer codebase al...



