#👾-core-development
1 messages · Page 116 of 1
cant you grab wreq
by pushing your own module or smthn
bad
yeah that's the plan
Discord Account
tsaitou7361
What happens when the bug or crash occurs?
Theme doesn't work :(
What is the expected behaviour?
I expect when I open Discord and enable a theme
then the theme will not work in the most screen (It just work on title bar)
How do you recreate this bug or crash?
- Open Discord
- Install Vencord
- Enable a theme
- and you will see nothing has been changed...
Errors
Replace this text with your crash-log.
Request Agre...
i want to do that first before writing more devdocs
damn you beat me to it by like 3ms
uh
did u unpin the one issue
i pinned and unpinned because i realised the issue was a mess
was thinking about opening a new one that's more descriptive and pinning that
but people were spamming at the time so i wanted to do it later
lmao
got kinda lucky in that not alot broke with CustomRPC
Content
Discord pushed a massive update.
ALL THEMES ARE BROKEN (theme devs need to fix them)
MANY MANY MANY PLUGINS ARE BROKEN
We're working on fixing this. DO NOT OPEN ISSUES
FAQ
- What should I do? - Just wait
- When will it be fixed? - Soon.
- My vencord crashes - Repair with installer
Request Agreement
- [X] I have read the requirements for opening an issue above
yay
real
let's gooo
closing my dms for now im getting so many dms

Read announcements challenge
good call
i got a few dms too
me too
wtf yall are popular
now i need to do it in the popout which is (arguably) the more important part of the plugin
because hoisted at the top
oh true
hehe
welp at least i got CustomRPC fixed so im happy
imagine if you turned this off... other people would probably get dms instead 😭
renamed venbot
YES VENCORD IS BOT
horror
are we merging these fixes into dev branch or straight into main lmao
dev
perfect
cool
I'll do it
wait theres a dev branch?
you saw nothing
hmmm
cause we only have ci run on prs to main
oh lmao
okay, thanks.
I tested that Basic Background is not affected!
REAL
times like this are where i wish vencord was under the vencord org instead of your user 
so i can mute users and stuff
just change it to vencord/vencord and get more server members 
working on sortfriendrequests now
we have it as an alias
make vendicated/vencord the alias for vencord/vencord boom solved (probably doesn't work)
as much as moving it under the org would provide tons of benefits for us that are actually really useful (e.g. merge queues and the aforementioned org members can do mod actions) ven wants to keep it for attribution
you can do that
just move vencord into the org
no
i'm not saying you should, i'm just saying the old link would keep working
we already have both links working
asdfghjk
yes
they said it probably doesn't work
btw im tagging the update fix PRs https://github.com/Vendicated/Vencord/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+label%3A"major+change+bugfix"
might need to fork starlight
because so many PRs its hard to see at a glance which are specifically for fixing this issue 

how come
there's no way of disabling the default css
so unless we want to have <property>: unset everywhere its going to be really awful to theme to the vencord site style
i've got it partly working here but a bunch of the starlight styles conflict with our own
so it creates a lot of issues
could also just use a different framework
doesn't have to be starlight specifically
starlight's coooool tho
:P
we could also just build it from scratch, yes
then serve the documentation from the docs repo
your choices are:
- starlight
that's it
starlight is the only astro docs framework atm
except astro for docs
but we dont talk about that
Well it doesn't have to be astro
you can just use any of the other established frameworks
just. build an ad hoc solution. so easy
id seriously just use either of these
im gonna be honest i really hate every documentation framework in existence
if you implement it from scratch there's so much to do and you need to implement global search, tabs, etc
yeah it does??
it always has 
vue 2 definitely had it
all of my styles leaked
<style scoped>
oh
lmao
i dont like vue that much honestly lol
xd
it always felt off to me
I like v-for and stuff
Werent you hating solidjs 2 days ago
no?
Nvm its megu
Ven was doing trol
all of my apes gone
I noticed that every single plugin had no authors. Additionally, when I tried to use ThemeAttributes, any theme dependent on it would not work.
Might be a similar problem to/caused by #147 and #167.
Might be a similar problem to/caused by #147 and #167.
i forgot how painful building new vitepress themes from scratch was
there's so many components to style
lets move to codeberg
sounds like skill issue
oh, that's neat
i'll add that to the main vencord site later
and by later
i mean now
im so confused though
there's like
little tiny styling differences flicking back and forth
even though it's the same css
i dont know why its like 2px off on the navbar
agh
i cant do this now
i'll push what i have and i'll work on it later
nuked starlight from orbit
specifically what things do you consider working on it
actually porting the theme properly xd
lmao
that's mainly what needs doing
i'll have a play
my very rough and hasty port is a bit shite
it doesn't quite match up properly (for some reason there's like minor differences in pixels, so we need to work out why...) and there's loads of unstyled components
i think the default vitepress markdown has all the components that need styling for md docs
no more webpack soon
then we need to create the components(?) and styling for things like the sidebar, search
stuff like that
AKJHSDFKJHAKFHSJKDF
too much :(
doing it from scratch might've actually been easier cause then we can just iteratively create stuff as we go rather than trying to jank an existing thing into our styles, + it means we can just host it on a subpath rather than a whole subdomain
W

damn
what's the purpose of this
disabling the plugin
so basically every time you find a fix for something it breaks other stuff
lmao

oikay so
number 1 priority is FIXXX NOTRACK
this is spamming discord's sentry lolol
oh no
maybe i should temporarily use electron to block sentry
people will still use an outdated version
9c5a51f fix: ComponentDispatch and GifPaste plugin (#1843) - MeguminSama
btw if u fix these make sure it still works on latest dev
i'm stuck on the stupidest thing
is there a way to enable debug logging or something
for?
patches
what would it log
are you on latest dev branch
i'm on main
patcher is fixed so the patch applies, but this doesn't actually seem to be working? Unless im missing smth
switch to dev
but the other patch worked
main has broken patcher
VEN
fix react devtools crahsing my discorc
cant
@austere talon was ur sleep restful or did you have webpack-fueled nightmares
it was unironically the best sleep i had in a while
i slept like nothing happened
when i woke up this morning it felt surreal that vencord was broken
nothing happened, what are you talking about
You enjoy the deep chaos happening in background
gud
i sleep comfortably knowing of the horrors that happened to vencord

i know why i slept so comfortably
because server lockdown

my dms did not sleep comfortably
tbh wouldve thrown our phone out a window to avoid having to deal with it if we were vee 🔥
the voice channels are hell right now though
can i get "dm me for support" role which pins me to top of channel list
they work you're bad
How did it explode
IT DOESNT
krill issue
GUHHH
It doesnt go OOM
Mem usage maxes at 700megs before crash
oh my god
bill issue
i'm still getting dms
fwiw this didn't appear until i reopened the menu a 2nd time xd
Maybe it fixed itself
but its working fine so manti skill issue
I will try once I get back home
It was working fine on me too but suddenly exploded
honestly it seems like we might be mostly back on track after today
I tried with 1 hour apart
would help but not home 🔥

Whatwve
IT BROKEEE
i wonder how the bd server is going
Ven will forget that he removed reviewdb and merge it cluelessly
is this okay or ew?
wonder how much discord's performance changes from the more modern code
it's because ErrorBoundary forces me to use react props
I Doubt it changed much
but like
But it probably made building faster
think about how much less code there is in async
Lot faster
and i don't wanna just pass in everything 
i doubt this will be a noticeable performance increase tbh
like this
became this
I wonder if my 11 month old pr broke
there's gotta be a perf boost
Should check
i doubt it will be noticeable
WHAT IS THEIR FUCKING BUNDLER DOING
WHY IS THERE A COMMA
USE SEMICOLON BE NBORMALLLL
Idk tbh
hm?
oh getting rid of the class polyfills finally
ye
love
Ven
but async overhead 
NO
My most hatred plugin got fixed
regeneratorRuntime wayyy slower
we need more tracking
i know, its a joke
xd
WTF IS THIS
hm it just occured to me that vencord's patcher is kinda like javassist
Why is there 2
only 1 for me
but good
we are so back
i love you autumn
a LOT
hallo everyone
List
hii nookies
can u fix mine too >~<
I can run reporter and give list if you want
I have 45 more minutes of stupid math lesson
to anyone contributing fixes, make sure to checkout dev branch, as dev has fixed webpack patching
okay wait
ez
ill fix all the apis rn
🧽
poor nookies got the monsters ShowHiddenChannels and FakeNitro to fix
well if hes gonna fix those
i will throw this sponge at you
ye
I got those no worries
I will do typing indicator too
since the other fix didnt work
isn't that just betterdiscord
also idk how it's going but dont let people add themselves to every plugin author for fixes lol
ported to java?
a shit ton of broken patches are just where we match
function (e) {
let a = e.someThing
}
which is now
function (e) {
let { someThing: a } = e
}
checked out to dev but 
who gives a fuck about that patch
well no i just saw the "Fix NoTrack" patch and then saw that it didn't work
thats like voice engine shit or smth i think
o
fix it if u want but its low priority
discord desktop guh
its just some annoyance iircx
like the fucked up stacktraces
i want something to do so if u have any plugins or stuff u want to throw at me
i wonder whats a reliable way to match that
anything helps
woah nice
makes discord code look less awful
and functions like .something=function
finders like that are erroring too
BdApi.Patcher
this isnt that robust cause what if its reordered later T_T
our apis make this so much easier
just have to fix the api and all plugins work again
we got so much work to do
I swear they broke show hidden channels completely
ugh I will do that first
@crude hearth
Thanksss
its so over
is there any better way to do this
Yeah thats really a lot
can we abuse comma opperator
Is there any plugin which survived
a lot
this is such a fucked if statement
Which
how cursed is this
I dont understand whats happening lmao
I will merge Vencord dev into VencordPlus main
GUH
Wth is wpexs
is this minifying several if statements into one
that's horrifying

idk lmao
got damn i need to fix MessageEvents asap
NEED MY CLICKY CLICKY BACK
these are minified if statements
shoving them into 1 if probably has some sort of perf gain or does indeed save a couple of bytes
nvm, use \i
always use \i
sure thing
technically im actually at work
but i have nothing to do right now
lol
funny how everything breaks and immediately every contributor ever appears from the shadows
ven i already said yes :P
done
bought a monster
put on some banger music
locked in and fixing it all
please tell me onboarding hack still works
REAL
oh wait
surely there's a cooler name for this update
its just for tracking lmao
oh yeah i tried that a couple weeks ago
is nice
they don't sell it at my local coop anymore tho
wow these patch changes are so minor https://github.com/Vendicated/Vencord/pull/1855
lmao
@shy veldt autumn fixed experiments u gotta smooch him now
same with disableDMCallIdle
xd
damn
i was gonna fix experiments :<
only didnt bc it wasnt being loaded earlier smh
fix every plugin and add yourself to their authors /j
NO
there's a bunch of plugins i helped write that im not credited in smhhhh
im gonna submit a cease and desist
rn
cheese and dentist
yum
Discord let hell loose today huh
its a good hell though
massive update
you do it
I'd help fixing some patches but I'm stuck at uni for 3 more hours 
tbh plugin dev will be better after this
can't rely on anything
omg lewi has different color epic
i trust u not to do dumb shit with it
what's changing?
code is way more modern and clean
they fixed their shitty budnler config
no more polyfilling ancient shit
yep
nice
now we have proper classes, async funcs, arrow funcs, etc
WAIT
they switched bundler entirely 
ASYNC REGENERATOR IS NO MORE?
its now a rust rewrite of webpack
because we can no longer abuse arguments and also this

rename 'c' to abmin and hoist it
LMAO
i would kill myself broo
is it gone?
yes its gone
pure async
then people will keep saying "pls gib me abmin"
very epic
When discord in haskell
real
sortFriendRequests was also a really small fix
just it got split into two modules instead of being in the same one 
and it was using the old Vencord.Plugins.plugins.pluginName instead of $self lmao
@cunning canyon smooch
has anyone picked up pronoundb?
otherwise i'll do it
dont think so
kk
hm?
it works for me
there's one patch that isn't applying
ohh
onboarding configured, let me show
this one
i am not a big fan of having so much code in the patch. stuff like that is always best made a method on ur plugin (yes this used to be the same way before but might as well fix it while we're at it
Vencord Announcements*
like some trext below the header
yep
NOOOO poor MessageLinkEmbeds
😭
but its crazy how good our ErrorBoundaries are
the console is full with red but no crashes
testament to stability
Most stable discord mod ™️
well we did have crashes but those were mostly unavoidable cause it was such a massive update
and BD also be crashing i think
i plan to have most plugins fixed in ~5h from now
and push to main
NOOOOOOOOOOOOOO
should i tag for the announcement pings @austere talon
just saying they exist now
Is pronoundb even required rn
Since discord has its own implementation
no not yet
alrighty
i want to do an at everyone for both combined
ah, sounds good
the announcement and then also shilling the roles
LOL NoDevtoolsWarning was so easy to fix that I was too lazy to search on GitHub
and it was already fixed
test
nah bd gonna be fixed, they will revert the build themselves 🙏 🙏
#👾-core-development message
lmao
easy starboard
hmmm yes, build pipeline optimisations will be reverted soon™️
-betterdiscord 2023
yes... pushing an update that optimises the whole build pipeline and app is considered a broken update
ofc 💪
AM I STUPID
@lime stone WHY IS MY PATCH NOT DOINGA NTYHING
you
what
LETS GOO MessageEvents fixed
guh
i need to fix this shit next gotdamn
which freaky bastard wrote that shit (me)
I bet devilbro is praying they will revert update or otherwise he needs to read his shitcode again
AUHDUIHAFUIHEIOHUJGFEHIOUJGE I DONT WANNA HAVE TO FIX THAT
@austere talon@austere talon is the patcher broken on the main branch? i have a patch that succeeds in patch helper but doesnt edit anything
you're the bastard
well at least they made datamining easier for me
as all chunks dont make the diff like 300k
and its as much as 300-1k now
use \i instead of \w+, it matches js identifiers
so pretty good update
go ahead
was friend invites ever fixed (is commands api fixed)
done, still used to using \w+ because that's how I did it when I wrote my first plugin ^^
SO true
it's just test in rot13 lmao
rebase/merge on latest dev
does the settings store api work?
am i going insane?
but its literally defined there 😭
so true
i was being stupit
NOOOOO
well done
🙏
epic banana
what did you do
it assigns e.pronouns to f, not e.f to pronouns
i was just misreading it
you're so stupit
:(
the fact that even such a complex patch was such a minor change
im betting oneko doesnt need to be changed
like
big stupit (im more stupid than you)
it doesn't need to be changed
oneko on top
NICE
only plugin that worked 💪
my pr has survived
oneko is unbreakable
🗿
🗿
oh no
Most Vital Feature
so sad
do not the moyai spam
cannot use vencord rn due to it not yet getting updated on the chrome store, and that school (for good reason) doesnt let you add custom extensions
moyai works for me
I see star, I click star
you should nto spam moyai
almost done with apis now
also i not only refactored the oneko code to not use eval, and instead use the o-neko element (so not much had to be edited) and also added a feature that ven didnt know was in oneko
ok so
@limber skiff yo, wanna check out settings stores api?
goddammit
test
you are the chosen one
cool would be neat if u could take care of removing and migrating plugins then (whenever, no rush)
there are like 3 plugins that use it
@turbid hatch are u all done?
onboarding wise yeah
with the onboarding
thanks a lot <3
npnp
nah not really xd it's nice to have in case you arent here but its not a big deal
@ ven is vencord broken? 😔
from what i understand, this update is a padded sword
bad, but good in the long run
you cant close vesktop from console for obvious reasons
why are you trying to close from console anyway
How do i uninstall for the time being? The installer does nothing when i open it.
DiscordNative.app.relaunch() (real)
ctrl+w works
nyabom
ctrl + q also works
unsane
bros stars got deleted
thank uyou
lmao
starboard speedrun
this chat is evil
wtf
naw yall mfs crashed my discord
are there just a lot of whitenames lurking here
test
test
even faster than in the server i'm the most active in
please react to this message if you are lurking
i don't understand 😭
vencord-dev experience
i don't like how this looks
Can we move the non dev stuff to #🌺-regulars
k
nooooooo
leave da toad alone
fakenitro is the most difficult thing to fix i'd assume
what happens if you explode me
im watching the silly coders do silly things
im watching to consume knowledge
that doesn't fit :(
you dont fit 👎
still a draft
- waiting for SettingsStoreAPI fix/replacement for MessageLinkEmbeds
- user tags don't show in chat except for webhooks, the patch works, i do not know what is wrong and i am going insane
nvm got it
this seems to be a common patch now
basically to match
let { prop1: e, lostPermissionTooltipText: a, prop2: c } = e
aka their new way of destructuring props
FakeNitro and PlatformIndicators cause sooo many errors
OK I think i'll try to fix typingtweaks ||if it's not too hard||
waiting for SettingsStoreAPI fix/replacement for MessageLinkEmbeds
you can just findByProps them now @verbal pumice
yeah but its one big ass module which should probably be in commons
- getSettingStoreLazy<boolean>("textAndImages", "messageDisplayCompact")!
+ findByProps("MessageDisplayCompact").MessageDisplayCompact
hmm, now finding individual members is needed
since no more mangling
and you cant destructure lazy finds
maybe some way to lazy find only one export is needed
findSingleExportLazy("MessageDisplayCompact")
Does this let you edit the prop values like changing the string of a channel name or do you need to hunt down the getThing() function?
this would be the same as
findByPropsLazy("MessageDisplayCompact").MessageDisplayCompact
``` except that that obv doesnt work
hm
can you give it in context of what you would use it for to fix a plugin?
just trying to work it out mentally
why did discord think its a good idea to give anyone perms to set vc status
fr
to obv set the channel topic
duh??
why else
love when people star vencord repo in the exact period of time when its broken
guh what
lmao what
ت
true
btw if you fix a specific plugin its best to bring it up here so we don't duplicate work
i will fix PlatformIndicators now
yes that works
still funny
alternatively
patches: [
...[".handleVoiceStatusClick", ".handleClickChait"].map(find => ({
find,
replacement: {...}
})
]
whatever u prefer
relationshipDB
chait






more like could you?

