#๐Ÿ‘พ-core-development

1 messages ยท Page 105 of 1

austere talon
#
const FrecencyUserSettings = find(m => m.ProtoClass?.typeName.endsWith("FrecencyUserSettings"))

// get current favourite gifs
FrecencyUserSettings.getCurrentValue().favoriteGifs.gifs

// add favourite
const data = {
    url: "https://tenor.com/view/wumpus-discord-repost-if-you-repost-gif-20674712",
    src: "https://media.tenor.com/citg5i4shIwAAAPo/wumpus-discord.mp4",
    format: 2,
    height: 640,
    width: 640,
}
FrecencyUserSettings.updateAsync("favoriteGifs", state => {
    state.gifs[data.url] = {
        ...data,
        order: Math.max(...Object.values(state.gifs).map(g => g.order)) + 1
    }
}, 0)
#

idk if this still works

normal chasm
#

oh thats awesome, thank you

#

so it was stored in the user proto, nice

quaint sapphire
austere talon
#

yes

#

but format is different and idk if u just omit src or what

#

just favourite some gif from elsewhere and you'll get the necessary info

quaint sapphire
#

interesting

#

can't think of a way to abuse that feature

#

but it feels abusable

cunning canyon
#

i dont remember i see one here
and i saw one in bd server but iirc it just changes the image position, image still got cropped

normal chasm
#

Is there a limit on the number of gifs you can favourite?

quaint sapphire
normal chasm
#

A new harder drive could be using favourite gifs to store data

#

are the urls validated/is there a max size

quaint sapphire
#

oh god I remember that video

#

storing files on ping packets

#

cursed

quaint sapphire
normal chasm
#

the url is not validated

#

you can just put anything in there

quaint sapphire
#

bruh

#

discord cloud storage plugin using favorite gifs when?

quaint sapphire
austere talon
#

there's probably a limit

#

but i have like 300 favs at least and it works

normal chasm
#

if the url prop is not a valid url it'll render it as an empty panel with no way to remove it

quaint sapphire
#

what if it is a data uri?

#

like a base64 encoded image

normal chasm
#

unless url is undefined in which case it renders as the placeholder image and allows you to remove it
wrong, probably something to do with order.

normal chasm
quaint sapphire
#

right?

normal chasm
#

other way around, url gets used as a key in the favourites object and src is probably just passed to img src={}

#

anddd maybe url is whats sent when u send the gif?

#

idk I've lost interested

austere talon
#

now that I think about it, is there even any reason for us to continue the firefox addon

#

im considering just dropping it entirely from the firerox store

austere talon
#

publishing to the firefox store sucks so much

quaint sapphire
#

from my experience it is the best store when publishing an extension

#

you actually get to talk with the reviewer, unlike google where it tells you that smth is wrong and you gotta resubmit it

#

am I missing some drama?

quaint sapphire
austere talon
#

no they aren't lmao

#

their guidelines are overly strict, their reviewers are incompetent, the review time is way too long

quaint sapphire
#

I haven't updated my extension for the last 3 years, so that may have changed lol

austere talon
#

also they require you to submit source yet THEIR OWN OFFICIAL tool has no option to do so

#

so it means manual work for me

quaint sapphire
quaint sapphire
#

is there even a background script?

austere talon
#

no

austere talon
#

we need to remove csp to load external stylesheets

#

95%+ of themes do that

#

we also need to remove csp to be able to use monaco

#

so that already eliminates themes and quick css on firefox

#

we would need to make monaco a separate extension window and do ipc to get outside of the page csp

#

and that's a lot of wasted effort

quaint sapphire
#

yeah, you would need to refactor almost everything in order to support that system

#

sucks

#

does the userscript have monaco and themes?

austere talon
#

no

#

cause once again csp

#

does GM_addStyle bypass csp

quaint sapphire
#

do inline styles have CSP?

austere talon
#

that question makes no sense

#

csp can allow or forbid inline styles

quaint sapphire
charred monolithBOT
austere talon
#

no but from most sources

#

meaning @import "https://banana.github.io/banana.css" won't work

#

and that's what the huge majority of themes do

quaint sapphire
#

if we parse the styles to handle the imports ourselves, it is possible

#

import statements can only be at the top, so it aint that hard to parse

austere talon
#

yes but you'd need to fetch them via a background worker using csp or using GM_fetch

quaint sapphire
#

as for stuff that uses background: url(...) we could also parse that and use data uris, but that is a lot of effort

quaint sapphire
#

I can work on this (just for themes for now)

lime stone
quaint sapphire
lime stone
#

lol

quaint sapphire
#

@austere talon is it possible for ur to make a userscript that is not minified?

austere talon
#

why

quaint sapphire
#

so I can iterate faster

#

w/o building

austere talon
#

if you build with watch flag

#

but uh

quaint sapphire
#

oh yeah, I could have a local http server and import it using a wrapper userscript

austere talon
#

yeah

#

use sync xhr

#

then eval it

quaint sapphire
austere talon
#

yeah

#

you can use it to fetch it synchronously

#

cause remember we need to run at page start

quaint sapphire
#

thank god, I would have resorted to a mutation observer and just freeze the page until it loads

#

(yes you can do that, mutation observers can have async callbacks, and it waits)

#

yeah can't get from localhost due to CSP, gotta use tampermonkey api

#

so I'll use the mutation observer to block the page

charred monolithBOT
charred monolithBOT
quaint sapphire
#

at last

#

localhost kept failing (tampermonkey @connect only accepts domains, not urls), so I had to use a cloudflare tunnel

#

anyways, time to start working on theme sideloading ig

lime stone
#

MutationObserver catstare

quaint sapphire
#

really useful

#

as it allows you to run async shit while blocking the page

lime stone
#

concern

quaint sapphire
#

what is the concern?

#

this is only used to help me iterate faster on the userscript

lime stone
#

oh

#

why?

quaint sapphire
#

manually re-installing or updating a userscript is a pain

#

having a wrapper that loads a local file is good for debugging shit

#

I fetch Vencord.user.css and Vencord.user.js every time discord loads

#

instead of re-installing the script

charred monolithBOT
lofty helm
#

no, to quote a theme developer

... videos in a mosaic will always open in a popout and images may end up being blurry

lime stone
#

yeah

#

i tried to make a patch but it was pretty hard

#

looking at the build diff is annoying because all of the symbols change

lofty helm
#

someone please make addon

#

i do not want this mobile layout thing

lime stone
#

yeah it's pretty horrible

lofty helm
#

everyone knows that's the case

lime stone
#

even discord?

charred monolithBOT
lofty helm
#

they removed the experiment flag for media mosaic

charred monolithBOT
lime stone
#

where the experiment checks were removed. i think.

lofty helm
#

interesting that seperate links don't mosaic at all

lime stone
#

consistent ux โœจ

shy veldt
lime stone
#

oh

shy veldt
#

and obv the exps got removed

lime stone
#

where does it check for the experiment being enabled

#

or whatever (idk how it works)

shy veldt
#

from the experiments endpoint
(real)

lime stone
#

lol

shy veldt
#

idk if you gonna find your answer here

lime stone
#

i noticed in other places useExperiment is used

#

but they don't seem to be using that

shy veldt
#

they take from ws/exp ep
and just match the treatment

#

if you have the treatment
win

#

if no
skill issue

lime stone
#

so they didn't change any functionality in that build?

#

they just removed the experiment?

#

like i would've thought there'd be a function that's being called to check the treatment

shy veldt
#

yes

lime stone
#

or could you literally just add the experiment back

shy veldt
#

not as shrimple as that

lime stone
#

someone else who knows what they're doing can make this plugin ig trolley

shy veldt
lime stone
#

oh?? you're confusing me

#

so i was right?? ๐Ÿ˜ญ

shy veldt
#

you'll never know.,.,..

lime stone
#

๐Ÿ˜ญ ๐Ÿ˜ญ

#

i might as well try my best

#

if you never do anything without enough knowledge you never learn everything (how do you think people learn to fly planes, drive etc) /s

livid heath
#

trying to build a plugin and i have some patch errors
i am using --watch (which means IS_DEV is true)
but i am not getting the verbose error message when my patch fails

livid heath
#

nvm i was just being dumb and had a logs filter

austere talon
#

mozilla isn't real

#

yeah man im definitely gonna give you my discord login that you won't even be able to use because I'll have to confirm your login

#

i will drop vencord from the mozilla web store this is getting too ridiculous

lime stone
#

yeah

#

it's probably not worth your time lmao

tame escarp
# austere talon DUDE

DASHKJLASDJKUOIHSJDAUHIOADSOUIJHDSAJIODSAKJIODKSLAAHOUIDSOHUIDSOUHIMDIOLAKSJIODASJOIDSAJOIADSJIODJOIP:QWEJOIDKEWIOUJFREWUHOIEFRUIHGIFRUYWIUHFDWIUHFEHUIJOKFEDW

crude hearth
#

it will send notif

tame escarp
#

mozilla is gonna come to your house and kill you at this rate

nimble pendantBOT
charred monolithBOT
quaint sapphire
crude hearth
austere talon
quaint sapphire
#

also, this reminds me, I made an account for nyaa.si back when the registerations where open, so that they can test my extension

austere talon
#

any credentials i provide are my own

quaint sapphire
#

so mozilla people have an account to a website that you cannot register to

#

thx to me

#

lol

austere talon
#

they should make their own account it takes 10 seconds

#

also the guy reviewing definitely has his own account

#

or just not test it bruh

quaint sapphire
woeful sable
lime stone
austere talon
#

anyway idgaf im not gonna argue about this

lime stone
woeful sable
#

it's my fav emoji

austere talon
#

i don't want to have to bother anymore so i will remove the extension from the store

tame escarp
austere talon
#

userscript will be the option for firefox

quaint sapphire
lime stone
#

urgh

crude hearth
#

everyone should use chromium based browser alhamdulillah

lime stone
#

is there no nice way to add extensions outside the store?

crude hearth
#

f*refox so bad

limpid badger
#

I wouldnโ€™t be actually surprised if firefox support got dropped.

lime stone
#

because i'd be happy to manual install

quaint sapphire
austere talon
olive aurora
#

Hello,

Due to issues discovered during the review process, one or more versions of your add-on Vencord Web will be disabled on addons.mozilla.org in 14 day(s). Please see the reviewer's comments below for more information:

This addon didn't pass review because of the following problems:

  1. Please provide us with detailed information about your current location, your identification and billing info. This can be provided in the Whiteboard field, which can be found in the Edit Listing page under the Technical Details section. This information may be shared to third-parties
quaint sapphire
#

unless you do some custom profile shit

#

to load every time

austere talon
#

you can only install unsigned extensions on firefox nightly

tame escarp
#

lets make venfox

lime stone
quaint sapphire
lime stone
#

so it's some kind of build flag??

#

no way to change it

tame escarp
#

but okay i already do

quaint sapphire
crude hearth
#

firefox devs on their way to make worlds worst developer experience ever blobcatcozy

lime stone
#

or firefox came to their senses and it's only available in unreleased versions i wish

quaint sapphire
#

but still not worth it

austere talon
#

the plan is

  • remove vencord from amo
  • add back the firefox csp removal logic and provide extension zips via release
  • people can either use the extension zip on nightly or the userscript
lime stone
#

can you not change something in about:config?

austere talon
#

or they should just use a less shitty browser

quaint sapphire
#

and just use that shell script instead of the shortcut

lime stone
#

dodging the question

tame escarp
#

famous last words

lime stone
#

(deleted message = brain fart)

austere talon
#

it's crazy to me how mozilla pretends to care about freedom and decentralisation

then they turn around and make their extension ecosystem more locked down than fucking ios

limpid badger
#

Welp now this is weird, first people hated chromium now weโ€™re returning to it as Firefox got way worse throughout the years

crude hearth
#

who even hated chromium

limpid badger
austere talon
#

(ungoogled) chromium is the best experience to me

crude hearth
#

I use oper gx

limpid badger
lime stone
#

you're still using a fork though blobcatcozy

crude hearth
#

eitherway isnt chromium more memory efficent and faster than firefox

tame escarp
#

chromium is funny because it does have a monopoly on the browser market excluding firefox and safari derivatives
it is the best choice though ohwell

lime stone
crude hearth
#

well its a browser

lime stone
#

i haven't noticed a big difference

crude hearth
#

the stuff matters are privacy,extension support, user experience

#

which includes memory and speed

lime stone
#

i don't think firefox's difference in speed really has an impact on user experience

crude hearth
#

possible

#

idk

tame escarp
#

fwiw we've literally never noticed any difference between speed of gecko and chromium browsers

lime stone
#

yeah i haven't really

#

i thought firefox was faster at one point lol

#

just be patient dude

#

๐Ÿ˜Ž

charred monolithBOT
graceful hedge
#

Warning doesnt like firefox

tame escarp
#

Warning is wrong

woeful sable
#

where is patch helper i installed from git but its not there

quaint sapphire
lofty helm
#

i use firefox becuase it's not the chromium monopoly

quaint sapphire
#

I used to use firefox

#

But...not so great when developing extensions, so I dropped it

lime stone
#

@crude hearth certified mod abuse

charred monolithBOT
lime stone
#

i removed your mean reaction

crude hearth
#

chromium is open source at the end

lofty helm
#

when media mosaic gone ๐Ÿ˜ญ

crude hearth
#

I dont care about "monopoly"

lofty helm
#

in addition to css

quaint sapphire
crude hearth
#

as long as they do it correctly is something wrong with that

lime stone
#

my brain isn't braining

#
  • the only reason i tried isn't because i'm clever, it's because i'm bored
quaint sapphire
#

I am rooting for Ladybug to become a big contributor to the HTML/JS/CSS specs

lofty helm
#

i don't understand javascript

quaint sapphire
#

Why

lime stone
#

or is there another browser

quaint sapphire
#

Autocomplete got the best of me

lime stone
#

female bug

lime stone
quaint sapphire
lime stone
#

i've tried things

quaint sapphire
#

Compared to PHP it is a godly language

lime stone
#

i tried

{
    find: "().removeAttachmentHoverButton",
    replacement: {
        match: /(?<=mediaLayoutType:\i\.\i\.)MOSAIC/,
        replace: "STATIC"
    }
}
#

that just made it weird

quaint sapphire
#

Making some popcorn, I'll hop on my computer soon to help out

lime stone
#

just do the whole thing blurtroll

quaint sapphire
charred monolithBOT
crude hearth
#

skull

verbal pumice
#

you love insane shitcode

lime stone
#

they've been banned on two accounts from this server

#

they now only have github

quaint sapphire
austere talon
woeful sable
#

oh

austere talon
lime stone
#

.kristian

#

and 0xbob0910

quaint sapphire
#

@lime stone what exactly are you trying to do?

#

to turn this to the old style?

lime stone
#

ye

lime stone
#

like "oh i suddenly don't have any time sorry"

quaint sapphire
#

i legit cant

quaint sapphire
#

is this good enough for you?

charred monolithBOT
lime stone
#

what did you do though?

quaint sapphire
#
{
        find: "twoByTwoGrid:",
        replacement: {
            match: /(?<=\w\.exports=)\{.{1,601}twoByTwoGrid:.*?\}/s,
            replace: m => m.replace(/(\w+):(["']).*?\2/g,
                (_, k, q) => {
                    return `${k}: ${q}${q}`;
                })
        }
    }
lime stone
#

hmm

#

my patch did this lol

quaint sapphire
#

along with ur patch

lime stone
#

which made it super weird

quaint sapphire
charred monolithBOT
quaint sapphire
lime stone
#

hey it's cool that you're banned from github

#

because i can take credit

#

:3

quaint sapphire
#

made my own fork

#

RotCord

lime stone
#

BrainRotCord?

quaint sapphire
#

just RotCord

#

it is where I plan to make my plugins from now on

#

since I can't participate upstream

lime stone
#

whh lol

#

....

quaint sapphire
#

Will try to stay as compatible with upstream Vencord as possible

#

so you can take my plugins if you like

lime stone
#

๐Ÿ’€ ๐Ÿ’€

#

i-i...

quaint sapphire
#

hey, modern problems require modern solutions

lime stone
#

speechless

crude hearth
#

@austere talon I just had a great idea

#

make vencord closed source

lime stone
#

๐Ÿ”ฅ

quaint sapphire
lime stone
#

yes!

quaint sapphire
#

lmao

lime stone
#

๐Ÿ—ฟ ๐Ÿ—ฟ ๐Ÿ—ฟ

nocturne haven
#

message gets filtered by automod
reposts picture & laughing about themselves

quaint sapphire
#

cant even reply ffs

woeful sable
#

why doesn't discord filter pictures that show "This content is blocked by the server"

quaint sapphire
woeful sable
#

you can't insert people with common sense

teal halo
#

4k screenshot

woeful sable
#

@austere talon can you prune this

austere talon
#

nuh uh

woeful sable
#

what's the relevance of it to vencord dev

pseudo gull
#

there i deleted it

pseudo gull
coarse reef
#

#plugin-requests message yo so youre telling me, if i wanna make a plug in i gotta make a PR on github and all of that shit? have it show up on the plugins tab??

#

i am just tryna change the moyai plugin a little bit i dont want to do all of that lol

#

Nevermind i am dumb dev build moment hvdrasDinkDonk

snow mortar
#

Is there a way to create a websocket server inside a plugin? I'm trying to import it with this:

import { WebSocketServer } from "ws";

but I'm getting this error:

โœ˜ [ERROR] Could not resolve "ws"

src/userplugins/obsidianExport/index.tsx:26:32:
      26 โ”‚ import { WebSocketServer } from "ws";
         โ•ต                                 ~~~~

You can mark the path "ws" as external to exclude it from the bundle, which will remove this
error.
#

I assume the ws package isn't a dependency, but I'm not sure how to add that easily

charred monolithBOT
charred monolithBOT
austere talon
#

plugins run in the renderer ( browser process )

#

to run native things like servers you need to add code to the main process and add ipc for interacting with it from your plugin

snow mortar
#

Is there a current plugin that I could use as an example or would I be better off having my plugin connect to an already existing server? I'm trying to get Discord to communicate with an external program that I'm also making a plugin for.

jagged cloak
#

arrpc

snow mortar
#

That one only connects to a websocket server, it doesn't host one itself

#

cookievee mentioned IPC so I was looking for a plugin that used that.

austere talon
#

maybe tell a bit more about
what you're doing

snow mortar
#

Essentially I want to be able to export a user and their public-facing data into a an external program, Obsidian in this case. I figured the longer-running program would be best as the server, which is Discord. So Obsidian, which I also expect to make a plugin for, could come and go without my Discord plugin complaining.

A secondary issue that I'm still looking into is how I extract my user notes and the user's connected accounts, but that's a bit further down the road.

charred monolithBOT
snow mortar
#

I suppose I could also completely forget the websocket idea and just save files

tame escarp
#

(also impossible because renderer doesn't have access to the filesystem and there shouldnt be any pre-existing IPC methods to arbitrarily read/write to it)

austere talon
#

otherwise you'd need to always run discord before obsidian

#

if the socket is inside obsidian, you just lazily connect to it whenever you want to export users - or better yet, you would not even need a websocket, you could just use a plain http server and send normal requests

snow mortar
#

That's fair. The original reason for a websocket was two-way communication, so I could request information from inside Obsidian and it would ask Discord. I'll go for the Obsidian server and see how it goes.

austere talon
#

oh commands broke

shy veldt
#

oopsy

#

(they are reworking something with commands and stuff)

charred monolithBOT
#

Fix the command API, broken by discord removing the /giphy command, which was used to locate the injection point for the CommandAPI _init() function. This fix is only a sketchy temporary fix and i am uncertain whether it should be used over a better, more stable solution.. but it works for now for me ig? I am mostly worried that i have seen some users who still have /giphy.. so this would break the CommandAPI for them..

woeful sable
#

1776

teal halo
#

then and only then itโ€™ll be removed everywhere

marsh spruce
#

I have stable discord

#

and it updated from giphy to gif

charred monolithBOT
austere talon
#

its fairly simple to make the patch work for both groups

lavish cradle
#

does anyone know if you could use the backspace and click plugin to delete messages from search?

charred monolithBOT
limber skiff
#

I wouldnt do a look behind there

#

but thinking more, prob fine in this case

austere talon
#

why not

limber skiff
#

I was thinking an issue when you use quantifiers

marsh spruce
#

Where would I suggest the following?:

Thread checking ie finding threads in a specific threadchannel ie ones I created/own

Emoji downloads as in complete server or any emoji I select
Separating group chat and dms

austere talon
#

also its just an old patch i wrote ages ago

#

look how it even still uses \w instead of \i

limber skiff
#

oh lmao

#

didn't even notice that

austere talon
#

commandsapi

#

one of the first plugins and the patch still hasnt broken until now

#

and the only reason it broke now is cause they removed giphy that the patch includes xd

#

aov_zippeek rip giphy

limber skiff
#

๐Ÿ˜ญ

#

never used it anyways

austere talon
#

i love how there was never even a way to use it other than via the command

limber skiff
#

lmao

frail skyBOT
#
Bad Patches

BetterRoleDot (had no effect):
ID: 461884
Match: /"dot"===\i/

BetterRoleDot (had no effect):
ID: 461884
Match: /"dot"===\i/

MoreUserTags (had no effect):
ID: 609853
Match: /children:\[(?=\i,\(0,\i\.jsx\)\("span",{className:\i\(\)\.botText,children:(\i)}\)\])/

MemberListDecoratorsAPI (had no effect):
ID: 742224
Match: /Fragment,{children:\[(.{30,80})\]/

IgnoreActivities (had no effect):
ID: 238852
Match: /(?<=\(\)\.badgeContainer,children:).{0,50}?name:(\i)\.name.+?null/

MemberListDecoratorsAPI (had no effect):
ID: 879639
Match: /(subText:(.{1,2})\.renderSubtitle\(\).{1,50}decorators):(.{30,100}:null)/

IgnoreActivities (errored):
ID: 238852
Match: /(?<=\(\)\.badgeContainer,children:).{0,50}?name:(\i\.application)\.name.+?null/
Error: Unexpected token ','

IgnoreActivities (had no effect):
ID: 881335
Match: /!(\i)(\)return null;var \i=(\i)\.overlay.+?children:)(\[.{0,70}overlayStatusText.+?\])(?=}\)}\(\))/

CommandsAPI (found no module):
ID: -
Match: "giphy","tenor"

ForceOwnerCrown (found no module):
ID: -
Match: .renderOwner=

MoreUserTags (found no module):
ID: -
Match: .renderBot=function(){

Bad Starts

None

Discord Errors
font-weight: bold;
color: purple;
 [kb store] KeybindStore: Looking for callback action SOUNDBOARD_HOLD but it doesn't exist in this version. Skipping
%c[KeybindsStore] 
font-weight: bold;
color: purple;
 [kb store] KeybindStore: Looking for callback action SAVE_CLIP but it doesn't exist in this version. Skipping
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Unable to process domain list delta: Client revision number is null
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Downloading the full bad domains file ```
austere talon
#

SO MANY

#

WTF

spark cove
#

noo betterroledot

austere talon
#

nah betterroledot is false positive lmao

charred monolithBOT
frail skyBOT
#
Bad Patches

BetterRoleDot (had no effect):
ID: 461884
Match: /"dot"===\i/

BetterRoleDot (had no effect):
ID: 461884
Match: /"dot"===\i/

MoreUserTags (had no effect):
ID: 609853
Match: /children:\[(?=\i,\(0,\i\.jsx\)\("span",{className:\i\(\)\.botText,children:(\i)}\)\])/

MemberListDecoratorsAPI (had no effect):
ID: 742224
Match: /Fragment,{children:\[(.{30,80})\]/

IgnoreActivities (had no effect):
ID: 238852
Match: /(?<=\(\)\.badgeContainer,children:).{0,50}?name:(\i)\.name.+?null/

MemberListDecoratorsAPI (had no effect):
ID: 879639
Match: /(subText:(.{1,2})\.renderSubtitle\(\).{1,50}decorators):(.{30,100}:null)/

IgnoreActivities (errored):
ID: 238852
Match: /(?<=\(\)\.badgeContainer,children:).{0,50}?name:(\i\.application)\.name.+?null/
Error: Unexpected token ','

IgnoreActivities (had no effect):
ID: 881335
Match: /!(\i)(\)return null;var \i=(\i)\.overlay.+?children:)(\[.{0,70}overlayStatusText.+?\])(?=}\)}\(\))/

CommandsAPI (found no module):
ID: -
Match: "giphy","tenor"

ForceOwnerCrown (found no module):
ID: -
Match: .renderOwner=

MoreUserTags (found no module):
ID: -
Match: .renderBot=function(){

Bad Starts

None

Discord Errors
font-weight: bold;
color: purple;
 [kb store] KeybindStore: Looking for callback action SOUNDBOARD_HOLD but it doesn't exist in this version. Skipping
%c[KeybindsStore] 
font-weight: bold;
color: purple;
 [kb store] KeybindStore: Looking for callback action SAVE_CLIP but it doesn't exist in this version. Skipping
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Unable to process domain list delta: Client revision number is null
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Downloading the full bad domains file ```
spark cove
#

howw

#

can u tell

austere talon
#

cause i know

#

its a false positive cause of how the tester works

#

BetterRoleDot has duplicated patches that are gated between mutually exclusively predicates

#

but the patch tester removes all predicates so it tries to apply the same patch twice

#

for obvious reason the second one fails

limber skiff
#

holy shit

austere talon
#

for that reason I added a noWarn property to patches

#

that's only used by patch tester and nothing else

limber skiff
#

I was going to manually push to the patches array somehow

charred monolithBOT
austere talon
#

discord really be rewriting the entire memberlist code

#

i hate when variables are shadowed so you have to do this cursed horror

#

still broken:

  • MoreUserTags member list patch
  • ForceOwnerCrown
  • (IgnoreActivities)
austere talon
#

why doesnt MoreUserTags use the member list decoration api?

austere talon
#

fuck strict mode

charred monolithBOT
austere talon
#

oki

charred monolithBOT
austere talon
austere talon
# charred monolith

also chrome store publish failed because some update is pending apparently

charred monolithBOT
limber skiff
austere talon
#

HORROR

#

nah

#

that changes behaviour and patching every module is meh

limber skiff
austere talon
#

anyway im gonna sleep im so fucking tired

limber skiff
#

cant we load our own script with a function to get args from another which doesnt use strict mode?

#

and then place that on the window obj or something

frail skyBOT
#
Bad Patches

MoreUserTags (had no effect):
ID: 609853
Match: /children:\[(?=\i,\(0,\i\.jsx\)\("span",{className:\i\(\)\.botText,children:(\i)}\)\])/

IgnoreActivities (had no effect):
ID: 238852
Match: /(?<=\(\)\.badgeContainer,children:).{0,50}?name:(\i)\.name.+?null/

IgnoreActivities (errored):
ID: 238852
Match: /(?<=\(\)\.badgeContainer,children:).{0,50}?name:(\i\.application)\.name.+?null/
Error: Unexpected token ','

IgnoreActivities (had no effect):
ID: 881335
Match: /!(\i)(\)return null;var \i=(\i)\.overlay.+?children:)(\[.{0,70}overlayStatusText.+?\])(?=}\)}\(\))/

ForceOwnerCrown (found no module):
ID: -
Match: .renderOwner=

MoreUserTags (found no module):
ID: -
Match: .renderBot=function(){

Bad Starts

None

Discord Errors
font-weight: bold;
color: purple;
 [kb store] KeybindStore: Looking for callback action SOUNDBOARD_HOLD but it doesn't exist in this version. Skipping
%c[KeybindsStore] 
font-weight: bold;
color: purple;
 [kb store] KeybindStore: Looking for callback action SAVE_CLIP but it doesn't exist in this version. Skipping
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Unable to process domain list delta: Client revision number is null
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Downloading the full bad domains file ```
limber skiff
#

maybe use ipc

frail skyBOT
#
Bad Patches

MoreUserTags (had no effect):
ID: 609853
Match: /children:\[(?=\i,\(0,\i\.jsx\)\("span",{className:\i\(\)\.botText,children:(\i)}\)\])/

IgnoreActivities (had no effect):
ID: 238852
Match: /(?<=\(\)\.badgeContainer,children:).{0,50}?name:(\i)\.name.+?null/

IgnoreActivities (errored):
ID: 238852
Match: /(?<=\(\)\.badgeContainer,children:).{0,50}?name:(\i\.application)\.name.+?null/
Error: Unexpected token ','

IgnoreActivities (had no effect):
ID: 881335
Match: /!(\i)(\)return null;var \i=(\i)\.overlay.+?children:)(\[.{0,70}overlayStatusText.+?\])(?=}\)}\(\))/

ForceOwnerCrown (found no module):
ID: -
Match: .renderOwner=

MoreUserTags (found no module):
ID: -
Match: .renderBot=function(){

Bad Starts

None

Discord Errors
font-weight: bold;
color: purple;
 [kb store] KeybindStore: Looking for callback action SOUNDBOARD_HOLD but it doesn't exist in this version. Skipping
%c[KeybindsStore] 
font-weight: bold;
color: purple;
 [kb store] KeybindStore: Looking for callback action SAVE_CLIP but it doesn't exist in this version. Skipping
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Unable to process domain list delta: Client revision number is null
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Downloading the full bad domains file ```
austere talon
#

the target func needs to be non strict

limber skiff
#

ugh

crystal solar
#

I had a concept for a plugin:

Right click a server and you get an additional "move to folder" option. How hard would that be to develop?

austere talon
#

why not just drag and drop

humble fog
#

Hi! I want to help localize Vencord into Russian, is this possible? Thanks for the answer content

cunning canyon
humble fog
#

Thanks :(

mortal fractal
mortal fractal
mortal fractal
#

btw anything that modifies the member list and dm list is broken because they finally made them functional components instead of class based components

charred monolithBOT
mortal fractal
#

(i am just the messenger and do not own a steam deck cope)

crude hearth
#

@placid wave owns

limber skiff
#

did you get it to work?

#

well

#

not a regex problem, thats for sure

charred monolithBOT
limber skiff
#

are you sure you built vencord again and restarted

#

also check if there is anything on console

charred monolithBOT
limber skiff
#

if you search for your patch in the sources is it there?

#

I mean the file for the plugin

#

๐Ÿคจ

#

idk

nimble pendantBOT
#

owo

limber skiff
#

nico...

graceful hedge
nimble pendantBOT
#

owo

limber skiff
#

we are searching for isOwner:e in the sources, however your patch removes that, so it doesnt find the patched version KEKW

#

it is working

#

@vagrant topaz ^^

#

nono

#

in the devtools, to find the code you are searching for ",isOwner:e" right

#

that does show you the untouched code

#

but not the patched one because it removes the e at the end

#

search for isGuildOwner(

#

nono

#

in the devtools

teal halo
#

cant be fired if i aint hired

#

use it

limber skiff
placid wave
charred monolithBOT
austere talon
#

I already fixed

placid wave
#

explo

#

you do

charred monolithBOT
charred monolithBOT
charred monolithBOT
nimble plaza
#

horror

austere talon
#

no

#

(user as any).globalName

lime stone
#

i think it meant (user as any).globalName as string

austere talon
#

that doesn't make any difference

nimble plaza
#

globalName would have any type

#

it needs to be casted to string

austere talon
#

i hid the reply because it's just gonna confuse that person

lime stone
#

๐Ÿ˜ญ

austere talon
#

we should just fix the types anyway

austere talon
lofty helm
#

any updates on the plugin?

charred monolithBOT
lime stone
verbal pumice
#

i am going fucking insane

#

how does a patch work in patch helper but then throw no effect when you actually try it

lime stone
#

what did you do?

verbal pumice
#

nvm im stupid

charred monolithBOT
quaint sapphire
#

Not for the same reason tho

lime stone
#

hmmm

quaint sapphire
#

(not about vencord, it's about work)

charred monolithBOT
charred monolithBOT
charred monolithBOT
lime stone
#

canStreamQuality

#

i can stream quality :3

charred monolithBOT
charred monolithBOT
verbal pumice
#

HORROR

lime stone
#

why don't you just rename to commentdb at this point ๐Ÿ˜ญ
(you are not generally meant to delete reviews and nobody uses it seriously lmao)

lime stone
#

i saw somebody leave reviews on people's profiles just because of an argument lol (as well as edit their profile)

#

where's the reviewdb server source code

lime stone
#

would be funny to have a plugin where you could have (essentially) a discord channel on everyone's profile xd

#

(not cursed)

jagged cloak
#

lets be real reviewdb was not supposed to exist outside of a joke aliucord plugin

austere talon
#

reviewdb stops being funny at the point where people comment unwanted stuff on ur profile

#

its just a silly meme plugin to have fun

#

not trustpilot

lime stone
#

yeah

#

some people are unsane

nimble plaza
#

yayyyyyy

#

๐ŸŽ‰

#

BEGONE

lime stone
#

maybe the backend hasn't been done yet

nimble plaza
#

ah

lime stone
#

i tried to check but i only found stupiditydb which seemed to entirely be done by rgbcube agony

#

petition to allow ducc in reviews ๐Ÿ™

nimble plaza
#

they should whitelist emojis that come from known clientmodding servers

#

so we can have stuff like shiggy and trolley

lime stone
#

well i had an idea on how it could be done but it seems like it would be quite messy

#

i guess you could allow them but users won't be able to see whether they're allowed until they're sent which isn't ideal

austere talon
lime stone
#

it's private :c

#

nvm

#

ty :D

verbal pumice
#

there should at least be something "this user has deleted x reviews from their profiles"

austere talon
#

no

jagged cloak
#

naaa

verbal pumice
#

because there are people who do take it seriously

jagged cloak
#

unnecessary

lime stone
#

nah

jagged cloak
#

tbh

lime stone
verbal pumice
#

eh fuck it not like i care

crude hearth
#

these stuff dont offend people but its at least unique and fun to keep

austere talon
#

no its not

crude hearth
#

we will lose everything that was like that

nimble plaza
#

its not

#

its just annoying

austere talon
#

mantika doesnt understand that people don't like annoying / insulting comments on their profile

verbal pumice
#

bleh

#

if someone's reviews are all clean and happy that's a red flag anyway

lime stone
#

can't stupiditydb be the serious plugin? in fact, what has happened with that?

verbal pumice
#

you'll be able to tell who deletes reviews

jagged cloak
#

the disabled reviews in question:

nimble plaza
#

is @olive barn's reviews a red flag

#

no

#

???????????

lime stone
#

my reviews are all clean and happy lol

nimble plaza
#

mine are and were on my old account

charred monolithBOT
lime stone
#

๐Ÿ˜ญ

nimble plaza
#

REAL

#

(what)

lime stone
#

i just said that i didn't like windows 8+ much ๐Ÿ˜ญ

nimble plaza
#

horror

lime stone
#

didn't everyone think that at one point

jagged cloak
#

ahhhhhhhhhhhhhh

lime stone
#

๐Ÿ˜ญ ๐Ÿ˜ญ

nimble plaza
#

shit like this is hilarious tho you gotta admit

#

lmao

jagged cloak
#

unban me bruh @austere talon @austere talon

lime stone
#

i thought that one went

jagged cloak
#

van

lime stone
#

van

jagged cloak
#

vvan <@&1155651362860843038>

lime stone
#

can you theoretically make it so that the server owner can delete reviews

nimble plaza
#

that would be abused by random people + all big clientmod server owners have reviewdb mod anyway

charred monolithBOT
#

Actually I get a crash with this build -

77cadfdbb8448a8c8452.js:3489 TypeError: Cannot destructure property 'user' of 'undefined' as it is undefined.
    at Object.patchDmList (index.tsx:122:21)
 ---
    patchDmList: ({ user }: UserProps) => {
        if (!settings.store.showVoiceActivityIcons) return null;

        return (
            <ErrorBoundary noop >
                <div className={vaCl("iconContainer")}>
                    <VoiceActivityIcon user={user} />
      ...
nimble plaza
#

clientmod stupidity archive

#

u want invite?

lime stone
#

ah

lime stone
nimble plaza
#

no its fine (i have a gif i wanna send)

lime stone
#

i guess server reviews aren't really personal

#

but i wouldn't want slurs in reviews on my server

#

(ig the report button exists)

nimble plaza
#

most slurs are blocked and ban if you send one iirc

#

(i tried to put the f slur on my profile and vee was the one to review my appeal fear )

lime stone
#

discord isn't rendering anything in that channel atm trolley

nimble plaza
#

horror

jagged cloak
#

wher do u even see server reviews trol

charred monolithBOT
lime stone
charred monolithBOT
charred monolithBOT
charred monolithBOT
nimble plaza
#

can someone check vencord . app's download again

#

someone in support is saying their friends name changed to vencord_blablabla and cant change it

#

i think theyre lying but better safe than sorry

lime stone
#

it's the same

nimble plaza
#

okay

#

tysm

charred monolithBOT
tame escarp
#

havent had vencord starred this whole time

charred monolithBOT
charred monolithBOT
frail skyBOT
#
Bad Patches

MoreUserTags (had no effect):
ID: 609853
Match: /children:\[(?=\i,\(0,\i\.jsx\)\("span",{className:\i\(\)\.botText,children:(\i)}\)\])/

IgnoreActivities (had no effect):
ID: 238852
Match: /(?<=\(\)\.badgeContainer,children:).{0,50}?name:(\i)\.name.+?null/

IgnoreActivities (errored):
ID: 238852
Match: /(?<=\(\)\.badgeContainer,children:).{0,50}?name:(\i\.application)\.name.+?null/
Error: Unexpected token ','

IgnoreActivities (had no effect):
ID: 881335
Match: /!(\i)(\)return null;var \i=(\i)\.overlay.+?children:)(\[.{0,70}overlayStatusText.+?\])(?=}\)}\(\))/

ForceOwnerCrown (found no module):
ID: -
Match: .renderOwner=

MoreUserTags (found no module):
ID: -
Match: .renderBot=function(){

Bad Starts

None

Discord Errors
font-weight: bold;
color: purple;
 [kb store] KeybindStore: Looking for callback action SOUNDBOARD_HOLD but it doesn't exist in this version. Skipping
%c[KeybindsStore] 
font-weight: bold;
color: purple;
 [kb store] KeybindStore: Looking for callback action SAVE_CLIP but it doesn't exist in this version. Skipping
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Unable to process domain list delta: Client revision number is null
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Downloading the full bad domains file ```
#
Bad Patches

MoreUserTags (had no effect):
ID: 609853
Match: /children:\[(?=\i,\(0,\i\.jsx\)\("span",{className:\i\(\)\.botText,children:(\i)}\)\])/

IgnoreActivities (had no effect):
ID: 238852
Match: /(?<=\(\)\.badgeContainer,children:).{0,50}?name:(\i)\.name.+?null/

IgnoreActivities (errored):
ID: 238852
Match: /(?<=\(\)\.badgeContainer,children:).{0,50}?name:(\i\.application)\.name.+?null/
Error: Unexpected token ','

IgnoreActivities (had no effect):
ID: 881335
Match: /!(\i)(\)return null;var \i=(\i)\.overlay.+?children:)(\[.{0,70}overlayStatusText.+?\])(?=}\)}\(\))/

ForceOwnerCrown (found no module):
ID: -
Match: .renderOwner=

MoreUserTags (found no module):
ID: -
Match: .renderBot=function(){

Bad Starts

None

Discord Errors
font-weight: bold;
color: purple;
 resetSocketOnError Cannot access 'Zye' before initialization
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Unable to process domain list delta: Client revision number is null
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Downloading the full bad domains file ```
charred monolithBOT
charred monolithBOT
#

Often search history is useful, but Vencord hides it and I can't use it.
I tried uninstalling Vencord, and history was back with queries I've run while Vencord was installed. I installed it back and search history was hidden again.
Disabling QuickCSS doesn't fix this, so it's not an issue with my css.

Stable 235476 (a7cb1d5)
Vencord 9e63da6 (Standalone)
Electron 22.3.25
Chromium 108.0.5359.215
Host 1.0.9019 x86 (38122)
Windows 10 64-Bit (10.0.22621)
Installer Version: v1.3.1 (...
charred monolithBOT
charred monolithBOT
torn knot
#

why would someone try to use a plugin made specifically for one app, with a different app just because they seem to be doing the same thing?

#

I would expect that discord has some apis to control these memory leaks or smth

livid heath
#

im sorry but how do you control memory leaks over a websocket connection

past sequoia
#

Weird one: Is there an official docker image on dockerhub for Vencloud? And is it public?

torn knot
quaint sapphire
past sequoia
quaint sapphire
#

You can't clone the repo?

past sequoia
stark axle
#

make a plugin to remove this stupid shop ๐Ÿ˜ญ ๐Ÿ˜‚

cunning canyon
lofty helm
#

day 3 of waiting for a plugin that reverses media mosaic

versed dragon
#

Please add free Microtransactions feature !

cunning canyon
livid heath
#

do i have to post demo screenshots/gifs for my plugin pr

charred monolithBOT
#

very bugged on acc switcher, will not let me add or remove bookmarks, says Loading Bookmarks forever

are you sure you're on the latest version of the plugin? (enabling Bookmark Notification Dot should give a Mark as Read context menu on bookmarks, if it's not there please update).

if you are, can you look for any errors (open devtools with ctrl+shift+i or cmd+opt+i for mac -> console tab) and ping me on discord (@verbal pumice) with a screenshot of them?

not happ...

charred monolithBOT
torn knot
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
verbal pumice
#

who has official in their github name ๐Ÿ˜ญ

charred monolithBOT
median rapids
austere talon
#

24k people apparently

quaint sapphire
#

stockfish is made by "Official Stockfish"

austere talon
topaz thistle
#

@austere talon From the Vencord-POV, what information do you actually get on the application that the user want's to screenshare?

austere talon
#

not that much

topaz thistle
#

Would you like to stick to names or are ids also appicable?

#

(regarding the virt-mic)

austere talon
#
{
  name: 'Screen 1',
  id: 'screen:406:0',
  thumbnail: NativeImage {
    toPNG: [Function: toPNG],
    toJPEG: [Function: toJPEG],
    toBitmap: [Function: toBitmap],
    getBitmap: [Function: getBitmap],
    getScaleFactors: [Function: getScaleFactors],
    getNativeHandle: [Function: getNativeHandle],
    toDataURL: [Function: toDataURL],
    isEmpty: [Function: isEmpty],
    getSize: [Function: getSize],
    setTemplateImage: [Function: setTemplateImage],
    isTemplateImage: [Function: isTemplateImage],
    isMacTemplateImage: [Getter/Setter],
    resize: [Function: resize],
    crop: [Function: crop],
    getAspectRatio: [Function: getAspectRatio],
    addRepresentation: [Function: addRepresentation]
  },
  display_id: '1731638613',
  appIcon: null
}
{
  name: 'screenShare.ts - Vesktop - Visual Studio Code',
  id: 'window:62914563:0',
  thumbnail: NativeImage {
    toPNG: [Function: toPNG],
    toJPEG: [Function: toJPEG],
    toBitmap: [Function: toBitmap],
    getBitmap: [Function: getBitmap],
    getScaleFactors: [Function: getScaleFactors],
    getNativeHandle: [Function: getNativeHandle],
    toDataURL: [Function: toDataURL],
    isEmpty: [Function: isEmpty],
    getSize: [Function: getSize],
    setTemplateImage: [Function: setTemplateImage],
    isTemplateImage: [Function: isTemplateImage],
    isMacTemplateImage: [Getter/Setter],
    resize: [Function: resize],
    crop: [Function: crop],
    getAspectRatio: [Function: getAspectRatio],
    addRepresentation: [Function: addRepresentation]
  },
  display_id: '',
  appIcon: null
}
#

this is what we're working with

#

1st is entire screen, 2nd is specific window

topaz thistle
#

62914563 is this id actually related to something?

austere talon
#

idk

topaz thistle
#

process id maybe?

#

Can you run pw-dump | grep 62914563?

austere talon
#

nothing

#

idk what that id stands for

austere talon
#

hold on

#

yeah still nothing

topaz thistle
#

hmm

austere talon
#

id string - The identifier of a window or screen that can be used as a chromeMediaSourceId constraint when calling navigator.getUserMedia. The format of the identifier will be window:XX:YY or screen:ZZ:0. XX is the windowID/handle. YY is 1 for the current process, and 0 for all others. ZZ is a sequential number that represents the screen, and it does not equal to the index in the source's name.

#

this is the main reason i added manual sound source picking since i have no clue how to work out the app from the info electron provides

#

since name is just the window title, which does not even have to contain the app name

swift fjord
#

and is not unique

topaz thistle
#

XX is the windowID/handle

Hm actually sounds like something that could somehow be of use

topaz thistle
topaz thistle
#

Alright I'll use Node-IDs but also expose the process name

topaz thistle
austere talon
topaz thistle
#

So yes

austere talon
#

and log out the source object

#

it'll be in ur terminal window, not the browser console

topaz thistle
#

Some way I could quickly get it in the discord browser console?

austere talon
#

yes

#

actually

#

are u using normal vesktop or the linux audio branch

topaz thistle
#

normal

austere talon
#

x11 or wayland

topaz thistle
#

x11

austere talon
#

then yeah

#

sec

#

in devtools, ctrl shift f for What you're streaming

#

put a breakpoint at the VCDRenderer result

#

then start screenshare and it'll trigger the breakpoint

#

and you can look at the source in the debugger

median rapids
austere talon
#

on an unrelated note, both linux and mac now use gay vesktop icon

#

should windows follow?

#

or are windows users homophobic

blazing dome
#

you need to make a fork of winget-pkgs in the bot

verbal pumice
limpid badger
blazing dome
#

yes

#

LOL

stark flint
austere talon
#

@turbid hatch is winget guy

topaz thistle
#

Ok so we could get the Process Id from Chromes WindowID but I'm not sure if that would work on wayland

austere talon
#

do u not have wayland

topaz thistle
#

No

austere talon
#

what do u use

topaz thistle
#

Xorg

austere talon
#

no i mean like what DE/WM

topaz thistle
#

KDE

austere talon
#

does kde not have a switch?

#

gnome does

charred monolithBOT
topaz thistle
#

Yeah I could switch but for me the desktop is absolutely fucked with Wayland, I'll do a basic implementation now and then look into wayland

austere talon
#

ah i see

#

wayland works really well for me

turbid hatch
#

i thought i configured it to use the org to clone to

#

but also that looks like it's not actually

#

forking the repo

#

even if its meant to be

#

wtf

#

wait there is a fork here

#

it already exists

#

okay what's wrong with this

limpid badger
#

welp we should update them to 0.3.3

turbid hatch
#

yes i know

lime stone
topaz thistle
#

Does discord screenshare support stereo audio? Or is it all mono?

austere talon
#

screenshare is probably stereo

#

why?

#

i dont think they validate it much if thats your concern

topaz thistle
#

Well implementing the stereo stuff would be a little mor effort so if it were mono anyways I could skip that ^^

#

But if stereo is supported we should support it as well

lime stone
charred monolithBOT
turbid hatch
#

@austere talon i'm gonna test some stuff with this so im probs gonna need write access, mainly want to work out if this was a one time failure or if it's fully busted

austere talon
#

why not test in a fork or smth

turbid hatch
#

fork wont run actions that have secrets in them? :P

#

and also i cant trigger it as a dry run, it would PR it straight to MS, so it's not a great idea

turbid hatch
#

much luv

#

hm

#

its doing the same thing again

#

oh fuck me

charred monolithBOT
#
[Vencord/Vesktop] New branch created: lewisakura-patch-1
turbid hatch
#

it's trying to read vencord/winget-pkgs but then creates a fork to shiggybot/winget-pkgs and there doesnt seem to be a way of fixing that

charred monolithBOT
#
[Vencord/Vesktop] branch deleted: lewisakura-patch-1
turbid hatch
#

so i'll just force the fork to be that one

quaint sapphire
turbid hatch
#

fixed

limpid badger
#

let's go

turbid hatch
#

ironically the CI failed but it seems to be a bug with node

#

lol

#

no idea where this comes from

quaint sapphire
#

Obv from a .json() call

turbid hatch
#

well no shit but in the action itself

austere talon
#

not a node error is it

turbid hatch
#

it was the lack of trace that confused me

austere talon
#

just fetch(...).json()

turbid hatch
#

but then i realised anonymous was there

austere talon
#

and the response is "A server error has occurred"

turbid hatch
#

github sided issue then

#

:^)

#

lets go shiggy is now a microsoft CLA certified contributor

austere talon
#

the overflow lmao

turbid hatch
#

lmfao

austere talon
#

nice

#

do we need to do anything or will the bot do everything on its own

turbid hatch
#

should no longer require babysitting

austere talon
#

also how do we notice if they reply with anything

turbid hatch
#

they wont

#

because the initial package was approved they have a list of exceptions for it

#

although we could just check the email every now and then

austere talon
#

do they still manually approve the updates or is it automated

turbid hatch
#

or the pr

#

manual

#

moderator approval

austere talon
#

do they even check

turbid hatch
#

yes

austere talon
#

or do they just skim that the manifest is correct and merge

turbid hatch
#

no

#

they actually check if the software works

#

pipelines validates if it works, but it also gets run in a sandbox from what i've seen

austere talon
#

automated or manual?

#

ah sandbox

turbid hatch
#

manual, presumably

austere talon
#

and hopefully malware check

turbid hatch
#

yep

#

but if we go back to when .3 was submitted

#

they sent this off

#

which i told them was due to the sandbox being stupid

#

and you can see in the background that they have malware checks

austere talon
#

i love "is this expected"

#

yeah guys our software is just a white rectangle

turbid hatch
#

i mean hey! maybe our application is just a white re

#

LOL

austere talon
#

should have said that

turbid hatch
#

but yeah the azxure pipeline

#

takes

#

a very

#

very

#

very

#

very long time

austere talon
#

is it like deep scanning that shit

turbid hatch
#

i dont know

#

you can watch it work here

#

but there are four pipelines that need to run

#

well

#

four jobs

#

but this can take like

#

an hour and a half

#

i dont know actually what its doing

limpid badger
#

6 minutes since when installer thingy started

turbid hatch
#

yeah their pipeline description doesnt explain what its doing either

#

its going to arbitrary azure functions calls

#

assume its doing good things

austere talon
#

its doiong BAD BAD BAD things

turbid hatch
austere talon
#

just a bunch of bots talking to each other

turbid hatch
#

there'll be a human

#

usually steven

#

who will just approve

#

and then more bots will talk

#

also i find it REALLY confusing

#

how they have a bot that forces azure pipelines to do a run

#

like

#

AP can use webhooks to do this

#

ms magic i guess

austere talon
#

was this ur or automated

turbid hatch
#

me

#

the bot has to accept the CLA

austere talon
#

lmao

turbid hatch
#

otherwise the MS reviewers LITERALLY cannot accept the PR

#

(required check)

austere talon
#

yeah but i didnt know if the workflow did that too

turbid hatch
#

nah

#

it might've been able to in the past but i imagine they got a bit pissed off

#

with that

#

because there are actual good notes in that agreement

olive aurora
austere talon
#

gonna approve it

turbid hatch
#

ah yes

austere talon
#

LGTM

limpid badger
#

that isn't going to work?

austere talon
#

๐Ÿ™

turbid hatch
verbal pumice
turbid hatch
#

oh yeah @austere talon

#

it used to be they had automated acceptance

#

like this

#

but people demanded they were human moderated

#

because i think something malicious got through

#

or whatevs

#

i think im gonna write a "better pr submitter" for this

#

cause that was really painful to get working and idk why

#

and also komac is uh

#

unreadable, in terms of code