i have to like make it persistent
#👾-core-development
spark cove
rain axle
@austere talon how do i work the fake crown thing?
jagged cloak
the what
charred monolithBOT
jagged cloak
holy shit daniels gaming 20
spark cove
@austere talon im adding ai noise cancellation to vesktop but like it also will work on web
spark cove
open source recurrent neural network based noise cancellation
austere talon
did u already got a working prototype or
spark cove
my friend was like yea no ur mic cannot
well the code is very straight forward and one of the devs of Vite already wrote an easy api for connecting it to Web Audio nodes
i was pinging to ask
how do i target web and vesktop
austere talon
how do i target web and vesktop
just .web works
spark cove
i was thinking about it im not sure how i wanna go about it
the code will live in renderer frame
i was originally gonna put it in vesktop but idk if thats better than putting it in a plugin
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/scripts/build/common.mjs#L87-L91
**common.mjs: **Lines 87-91
if (mod === "dev" && !watch) continue;
if (mod === "web" && kind === "discordDesktop") continue;
if (mod === "desktop" && kind === "web") continue;
if (mod === "discordDesktop" && kind !== "discordDesktop") continue;
if (mod === "vencordDesktop" && kind !== "vencordDesktop") continue;
spark cove
but large because the npm module
austere talon
large plugin
that's fine
but I think it would be messy if we had the code in vencord
since now you need to monkey patch vesktop / browser api
Well maybe u have to do that anyway in vesktop idk
austere talon
what goes people's heads to see previous bumps get marked as spam and still leave their own
austere talon
you can always lazy import it but that might be a bit hard to do
spark cove
i cant easily do this on web
austere talon
why not
austere talon
what's the matter with that
spark cove
so does shiki
spark cove
i was thinking cors
austere talon
which happens occasionally on web
spark cove
cors/csp ya
hm so do u think i should put this in a plugin
if i should put it in vesktop where would i put it
austere talon
csp not cors
cors is different thing
but it's easy to confuse the too I do it too like u just saw
spark cove
the difference btw
austere talon
cors is other websites deciding whether they want to let discord.com load their resources or not
csp is discord deciding whether they want to allow loading a specific resource inside discord.com
spark cove
yea true
austere talon
if i should put it in vesktop where would i put it
idk
there's a patches folder which has patches for some things
possibly there but not necessarily
spark cove
im gonna just make a working prototype and see how messy it is
one thing i do wanna pr into vesktop is an optional game auto detection
spark cove
idk i thought it was just rpc handler
like when u open minecraft it detects that its open and shows ur playing it does arrpc do that
spark cove
oh wth
spark cove
thats prob why i thought it didnt wrok
doesnt look like it does that hm
oh it does it just isnt working for me
i'll have to find out why later
@austere talon does the arrpc server run on vesktop
austere talon
yep
austere talon
it's actually split half and half
the renderer side is handled in vencord
the native part and invite launcher is run in vesktop
spark cove
so fire
austere talon
I hate that it's split like that lmao but that was the easiest
austere talon
no
and not planned I think
it doesn't seem very useful
I've never seen anyone even use it
spark cove
i was thinking that firefox didnt allow connections to localhost
but maybe thats safari im thinking of
spark cove
@austere talon what happened to patch helper
is the process to having it show up different now
spark cove
WebAssembly.validate(new Uint8Array([0,97,115,109,1,0,0,0,1,5,1,96,0,1,123,3,2,1,0,10,10,1,8,0,65,0,253,15,253,98,11]))
spark cove
@austere talon can u vc
spark cove
ok bet
spark cove
to test if it actually works in case
it works in the preview
but idk if it still works in call
spark cove
also in your opinion, should the plugin itself be the on/off switch
austere talon
I just used my alt to test voice chat
spark cove
or should the plugin just add one in the voice options
austere talon
I love talking to myself
austere talon
or should the plugin just add one in the voice options
Well
is this gonna be vesktop only or web too
I think it'd be better to just have it vesktop only for now
spark cove
um probably vesktop only cus it requires an external audio worklet script
austere talon
if it's vesktop it should add a switch to the picker screen
spark cove
picker screen?
spark cove
ohh
austere talon
soon
spark cove
yea
austere talon
I've not been feeling like doing anything lately
spark cove
but should i also make it like
in the voice options too then
also u mean this right
long heart
is there a utility function to read the electron preferences file
if not, how can i find the current release channel of the discord app in the native process
long heart
the current code i have from nutty is ```ts
// Get storage path depending on platform
let discordStoragePath;
switch (process.platform) {
case "win32":
discordStoragePath = join(process.env.APPDATA!, "discordptb");
break;
case "linux":
discordStoragePath = join(process.env.HOME!, ".config", "discordptb");
break;
case "darwin":
discordStoragePath = join(process.env.HOME!, "Library", "Application Support", "discordptb");
break;
default:
discordStoragePath = process.env.DISCORD_STORAGE_PATH;
break;
}
// Load snippets into from preferences file
const prefs = JSON.parse(readFileSync(join(discordStoragePath, "Preferences"), "utf-8"));
but that hardcodes the release channel and it seems like vencord would already have a func for italso it hard crashes if discord is located somewhere else
😃
long heart
if not, how can i find the current release channel of the discord app in the nat...
i know there's window.GLOBAL_ENV in the app process but im working native here
austere talon
if not, how can i find the current release channel of the discord app in the nat...
what specifically do you want?
what are u trying to do
long heart
the current code i have from nutty is ```ts
// Get storage path depending on pla...
this but make it support canary & stable
so i want to find the release channel and use that instead of hardcoding discordptb
austere talon
yes but what is your endgoal
what exactly do you need / want to achieve
this seems very much like X/Y problem to me, that's why im asking
long heart
ah okay
load snippets from the storage file .electron.devtools.preferences.scriptSnippets and run them automatically based on a boot snippet
austere talon
i see, so basically these?
long heart
yeah
austere talon
okay i see
and where do you want to do this? in what context?
in a client mod or as a separate script
long heart
inside vencord ideally
since the current version by big nutty needs to be injected but so does vencord i decided to try to combine them
i have a kinda working version in my fork but its not ideal
austere talon
import { join } from "path";
import { app } from "electron";
import { readFileSync } from "fs";
const prefsPath = join(app.getPath("userData"), "Preferences");
console.log(JSON.parse(readFileSync(presPath, "utf-8")));
ah ty thats what i was looking for
long heart
yop
somber kiln
who has a server hider plugin CSS i can have
long heart
🙏
austere talon
who has a server hider plugin CSS i can have
[data-list-id=guildsnav] .listItem-3SmSlK:has([data-list-item-id="guildsnav___GUILD_ID_HERE"]) {
display: none;
}
for example, this hides the vencord server
[data-list-id=guildsnav] .listItem-3SmSlK:has([data-list-item-id="guildsnav___1015060230222131221"]) {
display: none;
}
why do you want to hide all servers
somber kiln
well i put everything in a folder except my favorites
but i kinda want to hide this folder
austere talon
then just hide that folder
somber kiln
how?
long heart
name your folder something and ```css
.wrapper-38slSD:has(+ .listItem-3SmSlK [data-dnd-name="the name"]) {
display: none
}
so i type this and what
long heart
should work
somber kiln
.wrapper-38slSD:has(+ .listItem-3SmSlK [data-dnd-name="my mom and left me"]) {
display: none
}
alr ty
somber kiln
how do i put this code in btw
long heart
.wrapper-38slSD:has( .listItem-3SmSlK [data-dnd-name="my mom and dad left me"]) {
display: none
}
dude tysm lol
long heart
hm i get "cannot read getPath of undefined" am i in the app context somehow
okay
i just did this
🥰
charred monolithBOT
verbal pumice
okay i get babysitting the user but that's too far
lime stone
austere talon
okay i get babysitting the user but that's too far
yeahh lmao
wise cedar
awh my gawd that theme is wild
long heart
how would I import a setting from @api/Settings in the native context
austere talon
awh my gawd that theme is wild
oak hull
is it possible to make the quickcss button appear in the right click
long heart
what for
im trying to make it a setting instead of automatically running the snippet
or i could just do it by default and only run vencord_boot instead of boot
fleet depot
is it possible to make the quickcss button appear in the right click
arguably you could also enable vencord toolbox
oak hull
i forgot that existed
fleet depot
i want to make it better but i haven't had any time to sit down and code
spark cove
what is vencord toolbox
fleet depot
pain
fleet depot
what is vencord toolbox
will soon™ allow people to access plugin settings from toolbox
and updater tab
best plugin 
spark cove
same\
fleet depot
huhh
ignore lag, it's just slow because i was recording
((also because the code is bad))
but yeah you can add certain plugin settings to be in the drop down to easily get to
textreplace is the main one. also customrpc
but people will want a variety of plugins pinned
worn rivet
spark cove
would be easier if there was a multipass system for finding function names and then using those in patches
austere talon
you can
austere talon
nookies did something like that for the old context menu patcher
that autopatched dozens of modules
spark cove
explain it to me water
austere talon
it used a proxy in patches
spark cove
oh
spark cove
ADD LISTENER
brave geyser
So insane
austere talon
ADD LISTENER
it dynamically generated a patch lmao
cause it first had to find out the export name
like
austere talon
idk it was really deranged but worked wonderfully
worn rivet
"If it works, don't touch it."
austere talon
yes u wont need this here i think
spark cove
how does it do that if it
it happens before patches
how does it get access to instantiated exports
worn rivet
Dark arcane rituals from the days of yore.
austere talon
https://github.com/Vendicated/Vencord/blob/0fb79b763d797d70d2eb6d847b0bf711c9927...
basically:
- add webpack listener that searches for the context menu api code and finds the export name of the openContextMenu method and the id of the module
- now add a patch that searches for require(id) to match all modules that import context menu api
- the patch uses a proxy that captures the local name of the context menu and saves as state, then once the replacement is accessed it returns a matcher for
localName.exportKey,{
very cursed but it worked nicely
spark cove
i dont understand im crying
limber skiff
😮
spark cove
oph i get it
its able to apply the patch because it effects modules that import it only?
but modules only get loaded when theyre imported
so wouldnt that imply that it doesnt work on 1 of the modules
spark cove
what u tryna do vappp
so
theres two react function components
in a module that arent exported
its the two svgs u want me to use
spark cove
but they're nearly unmatchable
spark cove
ah ok okok
@austere talon am i doing the targeting naming right
plugin.vencordDesktop/index.tsx
spark cove
ok i thin just bug
austere talon
should rename to vesktop
spark cove
yes
austere talon
vencordDesktop söpö bloat
spark cove
should i do that in this pr
tame escarp
söpö
spark cove
cus i have to fix targeting bug
spark cove
finnish reference
austere talon
it means cute
spark cove
vencordDesktop -> vesktop
discordDesktop -> desktop
austere talon
it means cute
olet söpö <3 @spark cove
spark cove
:3
austere talon
vencordDesktop -> vesktop
discordDesktop -> desktop
I think
rancid dragon
ok but where does laptop come from
austere talon
horror
austere talon
vencordDesktop -> vesktop
discordDesktop -> desktop
truee what will happen to laptop users
austere talon
how so
fervent wren
spark cove
this comment will be dmcad
LOL
spark cove
how so
it exists in generatePluginList and also in build/common.mjs
and it doesnt work with folders
if u wanna fix that would be epic cus im going to the mall
jagged cloak
vencordDesktop -> vesktop
discordDesktop -> desktop
its still kinda confusing
i thought
desktop = vesktop and discord desktop
discordDesktop = only discord desktop
web = only web and vencord desktop
idk
it works
jagged cloak
maybe vesktop desktop and web
and just add multiple extentions (kinda insane) 
idk why you would need to tho
just expode if it doesnt work on that
spark cove
Vesktop and web makes sense
austere talon
and it doesnt work with folders
it does no?
jagged cloak
is this for linux or did they just explode krisp
jagged cloak
the pics in the pr
or did you go insane and patch the menus
vap crazy once
ok vap did go insane
tbf i should have known discord wouldnt be that nice
woeful sable
I love the part when vap said it's vapping time and vapped all over the place
austere talon
@spark cove voice-messages integration when 🔥
spark cove
<@454072114492866560> voice-messages integration when 🔥
True true
I must think of a clean way to do
spark cove
did u see the pr workflow
austere talon
oh i was replying to animal
spark cove
o
spark cove
nah it was bugging for me a sec ago
spark cove
idk but i will debug
oh im silly
i didnt restart main
i did this the first time i made the branch too lol
ok its fine nvm yea its ready actually wait
spark cove
the it was just that the main frame didnt have the ipc handler for recording
cus i only did ctrl + r
ok nromalize
u can merg
grave mangoBOT
https://github.com/Vap0r1ze/Vencord/blob/voice-messages-local/src/plugins/voiceM...
**index.tsx: **Lines 149-152
// Normalize bins with easing
const maxBin = Math.max(...bins);
const ratio = 1 + (0xFF / maxBin - 1) * Math.min(1, 100 * (maxBin / 0xFF) ** 3);
for (let i = 0; i < bins.length; i++) bins[i] = Math.min(0xFF, ~~(bins[i] * ratio));
epic
spark cove
wdym
they're prob fine
they're higher resolution under the hood (10 lines per second) but the react components for it downscales the wave when it renders
spark cove
i fixed the target stuff @austere talon https://github.com/Vendicated/Vencord/pull/1477/commits/41f1fb038f2223527a02f34e633e7a3d28060b6f
spark cove
did u look at the workflow
austere talon
it does readdir on /plugins
spark cove
It thinks the target is vencordDesktop/index
this
austere talon
uh
thats generatePluginList skill issue or smth
i think the actual build script should work fine
spark cove
the build script did the same
it just is silent cus the fail case is just not bundling
cus all it did was .split('.').at(-2)
which with "plugin.vencordDesktop/index.tsx"
is gonna be vencordDesktop/index
spark cove
it just is silent cus the fail case is just not bundling
actually the fail case is bundling with all targets
my b
austere talon
no
oh i see the error
this if is wrong
it is always false for dirs
it should just have like
if (fileBits.length > 2) {
const idx = isDir(file) ? -1 : -2;
...
}
then it will work right
austere talon
why
spark cove
explain with code
austere talon
i would just
spark cove
its ok the fix works for both 👼
austere talon
const files = await readdir("./src/${dir}", { withFileTypes: true });
for (const file of files) {
...
if (fileBits.length > 2) {
const idx = file.isDirectory() ? -1 : -2;
...
}
}
should work
spark cove
its too late
austere talon
idk buildscript so dirty
spark cove
ive made a crater
irreversable
it will soon melt a hole on the other side of vencord
visual valley
fleet depot
vns
nimble pendantBOT
ebon parcel
🗿
fleet depot
i want to make it better but i haven't had any time to sit down and code
yay i did it!
all in one for loop
now i gotta fix settings up
stark flint
@crude lake #1032200195582197831 message, you can read that channel's pins for instructions on how to manually install Vencord for adding plugins
stark flint
It's already a plugin, just not built-in
crude lake
sorry about the request then lmao
stark flint
Still better than the people who spam the same generic BD plugin request or bump closed threads
woeful sable
vns
nimble pendantBOT
woeful sable
vns
nimble pendantBOT
charred monolithBOT
torn knot
verbal pumice
bluecord rn when
austere talon
Ⓜ️
austere talon
shouldn't this rather be in the toolbox code
stark flint
🙏🙏🙏
austere talon
hot
cunning canyon
spark cove
lets make a vencord opencollective where we can put bounties on PRs for ven to collect when reviewed and merged
austere talon
😭
spark cove
hehe
grave mangoBOT
https://github.com/ShareX/ShareX_Chrome/blob/master/Chrome/eventPage.js
**eventPage.js: **
chrome.contextMenus.create({
"id": "ShareX",
"title": "Upload with ShareX",
"contexts": ["selection", "image", "video", "audio"]
});
chrome.contextMenus.onClicked.addListener(onClicked);
function onClicked(info, tab) {
chrome.runtime.sendNativeMessage("com.getsharex.sharex", {
URL: info.srcUrl,
Text: info.selectionText
});
}
how does this native message work
I can't find what's handling it
ah that's native manifest
nocturne haven
Can't addons declare a native binding?
nocturne haven
Cope as Apple products user
austere talon
**eventPage.js: **
```js
chrome.contextMenus.create({
"id": "ShareX",
"t...
googled a bit and this should actually be trivial
spark cove
ez
spark cove
@languid terrace is this ur issue https://github.com/Vencord/Vesktop/issues/65
languid terrace
Maybe
languid terrace
No like, games that use the rpc API work fine
The ones with actual Discord integration
spark cove
yea i know but it already has game detection
languid terrace
More like the programs that don't have it don't show up
spark cove
name them please
cus basically
arRPC's server handles that, which already runs with vencord
patent minnow
spark cove
but theres a bug where it doesnt detect games that run as admin
spark cove
ok sick also dont open issues if u hate elaborating
languid terrace
I'm in vens country
patent minnow
Germany?
woeful sable
bro get out of my hamburger
languid terrace
No 
woeful sable
okii
austere talon
@spark cove what are u brewing
austere talon
ohh fire
spark cove
real
spark cove
real real
tawny cipher
bereal
dusk whale
Does vencord cloud get your password
verbal pumice
no
verbal pumice
sorry
verbal pumice
only way to get it back is through discord support
(aka youre not getting it back)
dusk whale
only way to get it back is through discord support
I contacted them its been a day
dusk whale
(they will not respond)
i hate to say it but ur right
my phone is still attached to it tho
and my 2FA app
Hopefully they let me verify via sms?
jagged cloak
is ur phone logged in lol
jagged cloak
skul issue then
dusk whale
skul issue then
fuck
verbal pumice
if you still have 2fa you might be able to get a password reset email
cause i believe they require verifying your current email to change it
dusk whale
if you still have 2fa you might be able to get a password reset email
cause i be...
i cant
spark cove
they might not if they disabled 2fa
dusk whale
they got the current email verified
dusk whale
they might not if they disabled 2fa
They didnt but my authy is still connected
jagged cloak
then they have your email which means you have much bigger problems
dusk whale
then they have your email which means you have much bigger problems
i changed the password
- i got 2fa
thay seem to just have gotten my discord
nocturne haven
Did you make sure to find the cause for the attack?
dusk whale
cuz they r stupid
dusk whale
Did you make sure to find the cause for the attack?
yes i downloaded a new "game" from a friend
who was also hacked
spark cove
a classic
nocturne haven
I would highly recommend wiping your pc
spark cove
those are scary cus they can stay
dusk whale
I would highly recommend wiping your pc
dw tho i got malwarebytes i think it caught it
dectected like 3 things
Its set to scan daily
nocturne haven
It probably installed some random Software injecting into your apps
dusk whale
And im hella scaried to sign into anything
nocturne haven
dw tho i got malwarebytes i think it caught it
I doubt it will detect this stuff
dusk whale
I doubt it will detect this stuff
IT DID
spark cove
^
spark cove
how did u verify the things it detected were the malware or that it was malware at all
dusk whale
im pretty sure that was all the shit the game installed
dusk whale
how did u verify the things it detected were the malware or that it was malware ...
nuh uh
well a little
nocturne haven
I highly doubt it. If it just modified a simple JS file and inserted some rce, it won't find it
dusk whale
I highly doubt it. If it just modified a simple JS file and inserted some rce, i...
wdym
spark cove
i have a copy of it on my computer
dusk whale
i have a copy of it on my computer
you do?
nocturne haven
That there's no detection if something uncommon has injected into an application
austere talon
nimble pendantBOT
spark cove
lol true
jagged cloak
wtf
nocturne haven
Riiight, thought I was there already
jagged cloak
vap virus crashed explorer
lool why cant windows explorer handle renaming ogg files
dumbass
literally just ogg files 
wheres windows moment emoji
stark flint
Using the wrong channel
jagged cloak
yop
jagged cloak
lool why cant windows explorer handle renaming ogg files
lmao silly ah
austere talon
windows explorer is just dogshit
jagged cloak
it is
austere talon
every time it opens save modal in downloads folder it legit freezes for 30 seconds
and my Downloads folder isn't even big
limber sparrow
mine doesnt freeze up
jagged cloak
not to mention indexing is just slow and annoying
spark cove
worst part is that indexing is synchronous
jagged cloak
does w11 still search fucking bing for stuff on your computer lol
spark cove
opening a folder that has majority audio files with make it synchronously read the metadata for every file
so bad
charred monolithBOT
spark cove
real
charred monolithBOT
YouTube Music users could really benefit from having a control/share plugin similar to Spotify's. The youtube client is here: https://github.com/th-ch/youtube-music
spark cove
i dont think youtube has a player api
charred monolithBOT
austere talon
i dont think youtube has a player api
virus
spark cove
what is THIS
spark cove
what am i looking am
austere talon
im so smart
spark cove
real
spark cove
idk what file that is
austere talon
testing ur voice message pr
austere talon
i apparently edited some file
spark cove
o o oooooooooooooooo
austere talon
vban vap spam
nimble pendantBOT
vban vap spam
Gimme some users silly
spark cove
ooooooooooooooooooooooooooooooooooooooooooo
tame escarp
ven? testing a vencord PR? more likely than you'd think
spark cove
voice message
charred monolithBOT
spark cove
uhh
is that for desktop
if so its cus noiseSuppression is krisp but it doesnt work with that method
or
maybe its the webrtc one and i removed it cus it does nothigng
austere talon
desktop
austere talon
if so its cus noiseSuppression is krisp but it doesnt work with that method
okay understood
spark cove
yayaya
austere talon
thank you vap
austere talon
krisp sounds so hot here tho
where tf does this one come from
is that a discord component too
or urs
oh yours
so fire
looks hot 🔥
analog ibex
damn that's hot
spark cove
based
spark cove
i get it thjoi i do that sometimes on porupise
austere talon
this is soOoooOooooOooo important tho
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/plugins/callTimer.tsx#L88-L9...
**callTimer.tsx: **Lines 88-97
const [time, setTime] = React.useState(0);
const startTime = React.useMemo(() => Date.now(), [channelId]);
React.useEffect(() => {
const interval = setInterval(() => setTime(Date.now() - startTime), 1000);
return () => {
clearInterval(interval);
setTime(0);
};
}, [channelId]);
useTimer() when
spark cove
well
charred monolithBOT
austere talon
lodash DOES exist
yop
austere talon
testing
spark cove
this was almost so sad
tame escarp
this is so jumpscare
simply add lodash as vencord dependency 👍
spark cove
i must window._
austere talon
._.
spark cove
._.
austere talon
ExperimentalWarning: Import assertions are not a stable feature of the JavaScript language. Avoid relying on their current behavior and syntax as those might change in a future version of Node.js.
austere talon
i changed timer font to monospace @spark cove
otherwise the ui shifts when a digit changes lolol
cause 0:00 has different witdth than 0:01
spark cove
TRUE
austere talon
calltimer has same problem
i will fix
i didnt even read this
too scary
bet itzs cery good code
austere talon
prettzy quick
austere talon
spark cove
NICE
austere talon
could be better but this is fine
austere talon
yea i wanted to make a button version
wdym
charred monolithBOT
spark cove
like how it is on mobile
hold to record, release to send
but in the chatbar like next to the gif icon
austere talon
oh
spark cove
might pr later
austere talon
https://github.com/Vendicated/Vencord/issues/1488 is approaching oh no
spark cove
what is that number
spark cove
whats the relation
austere talon
14 stands for the 14 words (just google it its a racist saying)
88 should be obv
spark cove
wdym
austere talon
WDYM vap 😭
charred monolithBOT
ocean estuary
yo guys quick question how can i start a timer in customrpc plugin
charred monolithBOT
turbid hatch
MIDI IS A """SUPPORTED""" FILE FORMAT
olive aurora
em
turbid hatch
BUT IF I TRY TO SEND IT AS A VOICE NOTE IT CRASHES!
austere talon
we just use audio/* mime type
spark cove
why is midi audio/
turbid hatch
because its
austere talon
BUT IF I TRY TO SEND IT AS A VOICE NOTE IT CRASHES!
oh browser no support
turbid hatch
an audio format
spark cove
not really
turbid hatch
oh browser no support
no like
olive aurora
vns
nimble pendantBOT
olive aurora
Shaking My Head
spark cove
whoever decioded that should eXPLODE
olive aurora
simply add midi support
spark cove
yea
turbid hatch
mp3s work fine though
spark cove
i'd assume its the
turbid hatch
spark cove
audioContext.decodeAudio(blob)
i will add a midi to pcm
easy
iw anna do that now
hold on
olive aurora
wth baseaudiocontext is cracked
spark cove
true
olive aurora
audio effects
spark cove
yea im not a fan of the node system because its not very obvious to me how it works from the naming
i havent found a good visual of it yet
but i htink i know how it work in a basic way
ooo that gives me a great idea
charred monolithBOT
spark cove
ooooo
charred monolithBOT
spark cove
i know what im doing for the next 5 hours
modular audio plugin toolkit for mic and user output
austere talon
FINALLY
turbid hatch
(it is)
(thats from refined github, it stalls the PR accept until the checks pass)
(its not github)
austere talon
not true
turbid hatch
(you should try PR queue it does this for you now)
austere talon
HOLY FUCK THIS RIFF
austere talon
uh idk
spark cove
what is pr queue
austere talon
not now
austere talon
what is pr queue
idk but sounds hot
austere talon
maybe will make dev branch obsolete
turbid hatch
and then merges them
spark cove
oh
austere talon
i only use dev branch so i can merge multiple prs at once
spark cove
ohh
turbid hatch
and tests them and merges them all at once
turbid hatch
its faster and means that if a PR breaks you can narrow it down relatively easily
github does something similar except automatically
and if a PR in the queue fails it doesnt break your codebase
and the rest of the PRs can carry on
Merge queue automates this process by ensuring each pull request queued for merging is built with the pull requests ahead of it in the queue.
The queue then creates a temporary branch that contains the latest changes from the base branch, the changes from other pull requests already in the queue, and the changes from your pull request. CI then starts, with the expectation that all required status checks must pass before the branch (and the pull requests it represents) are merged.
If a queued pull request has merge conflicts or fails any required status check, it is automatically removed from the queue when it reaches the front, and a notification is sent. Once the problem is resolved, it can be added back to the queue.
basically how rust rollups work
very useful because you can just batch queue a bunch of PRs and not have to worry about your software being broken
spark cove
charred monolithBOT
spark cove
i must read this page later
austere talon
im not reading allat sorry lewi
if u want it fixed feel free to pr to voice messages or smth idk
austere talon
oh was that about pr queue
turbid hatch
ye
austere talon
i thought midi stuff
austere talon
maybe i read then