maybe that's what you're thinking of
#👾-core-development
austere talon
limber skiff
yeah but they use a different endpoint
austere talon
yes, the old one is just normal message
limber skiff
that's why it doesnt have ratelimit
limber skiff
austere talon
it only lets u wave like 3 times before u explode
the message send has hardly any rate limit so u can send dozens of waves
there's a snippet in general pins that I wrote ages ago when I played around with it
it let's u send up to 3 welcome stickers in one message
and u can spam that shit
and use it without nitro
it's funny
limber skiff
idk It's been ages since I did the thing with the bot
I just remember I spammed a bunch of welcome stickers
each were replying to the last sent message
austere talon
the normal message sends I mentioned only work in reply to welcome messages iirc
limber skiff
oh yeah no the method I was using could reply to non welcome messages
it was a chain
austere talon
https://discord.com/channels/1015060230222131221/1015060231060983891/10288662007...
try this tho
it still works I tried it earlier
triple wave is hilarious
noone sees it coming
limber skiff
the rate limit is different for each message
austere talon
is that just greet
limber skiff
yes
austere talon
the rate limit is different for each message
yes
limber skiff
austere talon
I think they only did it to stop greet spam
limber skiff
so you can chain it and spam greets
austere talon
I'm more so surprised they allow you to greet non welcome messages considering it would be trivial to check
limber skiff
you just need to change the message reference
austere talon
Was this using greeter?
like I said it only lets u use them in reply to a welcome message
try one of the welcome messages in #moderator-only
limber skiff
Was this using greeter?
ye
austere talon
not sure if the setting needs to be on
the greet one
wait it sent distok?
that might just be an incompatibility between nitro spoof and greeter lol
try disabling fake nitro
limber skiff
a bit
limber skiff
yop
austere talon
that's like the legacy way of greeting
I assume that's why they have so strict checks on it
limber skiff
both ways are cursed
austere talon
yes
austere talon
yes
it's the same concept as greeter
u can send up to 3 stickers per message
discord just doesn't let u do it in the client
charred monolithBOT
austere talon
insane how no one finished sound changer
the old code was really deranged
too hacky for my liking
and I do like myself some hacky code from time to time
austere talon
it makes errors not have discord voice as location
for some reason discord voice monkey patches console
So all the errors originate from discord voice even if they're not from there
just weird
cunning canyon
i cant even enable it when i try to install
limber skiff
I never noticed
cunning canyon
desktop
austere talon
what do u use it for
limber skiff
mute
limber skiff
I have it on my mouse
austere talon
I used to but I moved to number keys
cunning canyon
horror
austere talon
I use 4 to toggle mute
limber skiff
I use the button to go forward on navigatioh
austere talon
yes
limber skiff
😔
austere talon
fixing vc should be easy
limber skiff
I vc a lot
austere talon
streaming slightly harder
austere talon
do u Windows or Linux
limber skiff
windows
austere talon
screen sharing with audio on Linux virtually impossible
cause electron sucks
do u care about Audio
limber skiff
armcord had working stream but sound didnt work
austere talon
idk how hard it is on Windows
austere talon
PR
limber skiff
no idea how
austere talon
limber skiff
literally dont know where to start
austere talon
it seems to be easy
limber skiff
wait
austere talon
austere talon
oh
limber skiff
https://www.electronjs.org/docs/latest/api/desktop-capturer
I honestly dont know how discord doesnt support sharing your whole desktop audio yet
even skype did it
austere talon
I honestly dont know how discord doesnt support sharing your whole desktop audio...
electron only does the opposite
limber skiff
like 8 years ago
austere talon
you can share audio only if sharing whole screen
not if sharing window
just read that doc I sent
it's pretty straight forward
limber skiff
ew
but interesting
OHHH
THATS WHY ARMCORD AUDIO DIDNT WORK
you needed to share the whole screen??
austere talon
I think armcord just doesn't support it
limber skiff
austere talon
https://www.electronjs.org/docs/latest/api/desktop-capturer
this mentions that sharing Audio on Mac isn't possible but doesn't mention Linux
limber skiff
tbh I stopped using armcord cuz lf it
austere talon
does that mean it's somehow possible on Linux??
limber skiff
I had to change between discord clients to screenshare
are you using vencord desktop as main client already?
limber skiff
dang
austere talon
try running this in vencord desktop navigator.mediaDevices.getUserMedia({ audio: { mandatory: { chromeMediaSource: 'desktop' } }, video: { mandatory: { chromeMediaSource: 'desktop' } } })
austere talon
oh I'm on mobile
I'll try another time then
limber skiff
and put it in a video tag or smth and see if it has audio
whats a video tag
austere talon
html
limber skiff
ah
austere talon
const video = document.querySelector('video')
video.srcObject = stream
video.onloadedmetadata = (e) => video.play()
woeful sable
I will get upp
golden gulch
i have vague memories of no audio on linux being because of not being able to stop people from streaming music or other copyrighted stuff as easily as it is on windows/mac but I have no actual source for that
my brain could have just made it up
woeful sable
I will get upp
sike it's 6 am
limber skiff
do you have school?
limber skiff
same
woeful sable
my cat is sleeping on my arm I'm not legally allowed to get up
cedar leaf
this mentions that sharing Audio on Mac isn't possible but doesn't mention Linux
not possible natively but u can install a kernel module which creates a local loopback of the internal audio
i don't recall the name of the module but i think discord supports it natively now
charred monolithBOT
charred monolithBOT
Gives Discord a better spellcheck which helps me a lot because the normal spellcheck on Discord just frankly isn't that great in my opinion.
Here is the BetterDiscord plugin version of it: https://betterdiscord.app/plugin/SpellCheck
Pops out the connections when clicking on a profile for easy access.
BetterDiscord plugin:
https://betterdiscord.app/plugin/ShowConnections
Improves the readability of names if their color is or almost exactly the same as the background, changing the color locally.
Raw Link to the BetterDiscord plugin: https://tharki-god.github.io/BetterDiscordPlugins/ShowNames.plugin.js
charred monolithBOT
charred monolithBOT
woeful sable
virus
turbid hatch
it was a surprisingly small thing to fix
they were complaining about the installer more than the software lmfao
woeful sable
what.
turbid hatch
this is how installer development works!
sometimes you cant remove your installation folders for one reason or another
woeful sable
NO ITS NOT
turbid hatch
you have to manually specify it in NSIS because if it fails then it crashes the uninstall procedure
or it shows an ugly messagebox saying that it cant remove its files
turbid hatch
the thing is
the other policy violation is a smartscreen error
i cant fix that lol
OH FINALLY
I GOT IT TO SHOW THE ERROR
OKAY
i had to run it in windows sandbox
this is so dumb
woeful sable
windows sandbox more like litterbox !!!
brazen phoenix
ah
cunning canyon
wut
brazen phoenix
screen recorder not working guh
well it's just like that when the profile popout doesn't fit the window's height
is it a discord issue
cunning canyon
looks like my css issue
cunning canyon
😭
cunning canyon
how about force them become nitro profile like fakeprofiletheme
charred monolithBOT
somber ginkgo
@lean elm @dawn coyote latest UserVoiceShow css fixes appearance in popouts, but breaks full profile view
(yes, i tried with no custom css/themes)
dawn coyote
doesn’t really@look broken to me
dawn coyote
tbh didn’t even know it shows on the profile there too
will try to fix it when i’m home if none else does before me
somber ginkgo
lol
lean elm
<@319460781567639554> <@821472922140803112> latest UserVoiceShow css fixes appea...
Yea guy who submitted that weird fix is a moron, I PR'd a proper fix
somber ginkgo
Yea guy who submitted that weird fix is a moron, I PR'd a proper fix
@dawn coyote you gonna take that? 
lean elm
@dawn coyote no front xd
dawn coyote
I only used vsc search to find the plug-in and added the margin, it looked fine to me so I put it on github 
oh it was in a folder, that why I wasn’t able to find the ts file lmfao
lean elm
Omg
lean elm
<@821472922140803112> no front xd
I'll take that back xd
dawn coyote
lmao
It was like 11pm and randomly saw it while in vc
didn’t bother too much to look in how the plug-in works
for protest, I’ll keep my version on local
lean elm
Yea tho in the beginning I also didn't check if the styling was right when I click my own profile
lean elm
for protest, I’ll keep my version on local
Wym
cold patio
Does anyone know how I can add my built version of Vencord to my browser as an extension? I tried adding the browser folder to my extensions and it failed and said something was wrong with the version so I fixed that and it loaded but it doesn't change anything in discord. I tried it in chrome and edge.
austere talon
you need to build it
pnpm buildWeb
then there's extension.zip and extension-unpacked in dist
austere talon
why not add it on every os?
same goes for the other default menus, could add them all
cold patio
pnpm buildWeb
Thank you 🙂
austere talon
Note: The default menu will be created automatically if the app does not set one. It contains standard items such as File, Edit, View, Window and Help.
are any other of these relevant?
could add them too
charred monolithBOT
turbid hatch
oh well i thought that come second review they might get a bit upsetti
because the tool is called installer
but im installing it as patcher
and it seems like they changed the policy cuz i looked and there's loads of "installer"s
austere talon
I didn't know it was this simple to add the entire menu row back
but if it is then by all means go ahead
austere talon
ah but u need to make a new release right
turbid hatch
i can update the existing bundle
austere talon
virus
turbid hatch
just have to wait for it to build in actions
austere talon
why not build it urself
lime stone
yummy
austere talon
don't edit the zoom menu
the default one doesn't work on qwertz and some other layouts
see the second one that has a comment on top
you removed the custom accelerator
that won't work
oh
the git diff is being weird
tight vapor
GitHub in Discord plugin when
somber ginkgo
imagine a place™ where permissionsviewer and joinvoicesettings were available
fleet depot
impossible
cold patio
Is there a way to specify in a plugin that it isn't browser compatible?
verbal pumice
Is there a way to specify in a plugin that it isn't browser compatible?
end the filename with .desktop.ts(x)
cold patio
Should I only name the index file like this or all files? And what does the x mean?
verbal pumice
Should I only name the index file like this or all files? And what does the x me...
not sure actually
and (x) as in .ts|.tsx
cold patio
Ahhh. Thanks for the help 🙂
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/scripts/build/common.mjs#L78-L82
**common.mjs: **Lines 78-82
if (mod === "dev" && !watch) continue;
if (mod === "web" && kind === "discordDesktop") continue;
if (mod === "desktop" && kind === "web") continue;
if (mod === "discordDesktop" && kind !== "discordDesktop") continue;
if (mod === "vencordDesktop" && kind !== "vencordDesktop") continue;
That's weird if I rename my index file from index.tsx -> index.desktop.tsx I get
Build failed
Build failed with 1 error:
import-plugins:~plugins:20:16: ERROR: Could not resolve "./plugins/betterScreenshare"
Did I miss something?
austere talon
ah
yeah that makes sense
what do you prefer
plugins/BetterScreenshare/index.desktop.ts
plugins/BetterScreenshare.desktop/index.ts
cold patio
The first one
But I think the second one is better because you will see it immediately in the plugins folder instead of having to open it first.
turbid hatch
what do you prefer
plugins/BetterScreenshare/index.desktop.ts
plugins/BetterScr...
the second one brings consistency to the plugins folder structure and logically would be the one i pick, the first one makes sense semantically but might be confusing to those who dont quite understand how it works, + the aforementioned issue
upbeat spindle
what do you prefer
plugins/BetterScreenshare/index.desktop.ts
plugins/BetterScr...
the second one,. it should be the suffix filename
verbal pumice
2nd one
austere talon
lmao why did u delete ur triple greet @limber skiff
are u worried about getting banned
you won't
limber skiff
lmao why did u delete ur triple greet <@235834946571337729>
ya
azure jay
what do you prefer
plugins/BetterScreenshare/index.desktop.ts
plugins/BetterScr...
plugins/BetterScreenshare/index.ts
limber skiff
@jagged cloak what did you ping me for lol
jagged cloak
distok
limber skiff
oh
somber ginkgo
@limber skiff
limber skiff
me
limber skiff
try running this in vencord desktop ```navigator.mediaDevices.getUserMedia({
a...
this worked
austere talon
fire
limber skiff
I got jumpscared with audio loop
charred monolithBOT
gloomy heart
btw the Fake nitro emojis are broken again, it dont hide links, and shows as normal picture...
jagged cloak
nooooppp you are literally devilbro
woeful sable
😭
jagged cloak
looks fine from glancing at this giant ass pr
this begins the era of vencord plugin libraries 
jagged cloak
idk lol #notmyjob
lament nimbus
If I setup a selfhosted backend is it possible to limit who can use it
I don't see an env var but can you do that through discord dev portal or something
austere talon
i think u can make the app private or smth
other than that ucould pr that as a feature
lament nimbus
idk go
I'm sure I could figure out how to add an if block though, not sure how go tooling works though
austere talon
i think u can make the app private or smth
ah u cant
austere talon
idk go
I'm sure I could figure out how to add an if block though, not sure how g...
its pretty simple
lament nimbus
also I assume size limit is in bytes?
austere talon
also I assume size limit is in bytes?
probably
lament nimbus
me omw to sync the original doom game
guess ill pr
actually I shouldn't really need to use tooling at all because docker lol
cunning canyon
well it's just like that when the profile popout doesn't fit the window's height
min-height seems fixed the issue
https://cdn.discordapp.com/emojis/981721528917983242.webp?size=48&name=FuyuStarePat&quality=lossless
frail skyBOT
honest geyser
oh no
charred monolithBOT
frail skyBOT
woeful sable
shouldnt disabledmcallidle be yoinked
austere talon
ye gonna delete
austere talon
@limber skiff
u know how ctx menu api forces u to check children so u dont add duplicates?
we can just do this instead
austere talon
adding this btw
limber skiff
tbh I dont like both ways
austere talon
lol it doesnt use context menu api
limber skiff
2 elements shouldnt have the same id
austere talon
I think we should not let the duplicates
wdym
limber skiff
so we can just filter it
limber skiff
hmmm
charred monolithBOT
limber skiff
niceee
charred monolithBOT
limber skiff
ahhh
knotty horizon
honest geyser
yes
jagged cloak
yepp
lament nimbus
is there really no standard way to check if a []string contains a string in go
wtf
woeful sable
we will rewrite the backend in rust inshallah
woeful sable
hop off docker
lament nimbus
docker is great
lament nimbus
well whoever made this is bad at docker then
oh I guess the readme says to change it
but why isn't it redis:6379 by default
thats dumb
lament nimbus
Also, as a side question, is the discord client the one making the request to /v1/oauth/callback?
thanks sans
charred monolithBOT
charred monolithBOT
austere talon
is there really no standard way to check if a `[]string` contains a `string` in ...
the reason is because go only recently introduced generics
but im pretty sure they added that method along with generics
slices.Contains()
oh u found it
charred monolithBOT
charred monolithBOT
austere talon
?
lime stone
oh, is that a good idea?
what if discord has a vulnerability?
seems i can't do fetch("https://raw.githubusercontent.com/") on a local server which has no csp header
nvm, i'm dumb
it's removing the header from github's response
or any response (it seems)
is this relevant?
lament nimbus
@turbid hatch why did you merge so weird
You had permissions to add commits to my fork
turbid hatch
because i tried pushing to your fork and it refused to let me
so i just did it myself
it rejected my push when i tried doing so
dont know why
lament nimbus
The entire commits name is now "optimize slightly"
austere talon
huh
turbid hatch
The entire commits name is now "optimize slightly"
yes because i cherrypicked it off of the PR fork because it fucked up
lament nimbus
Could you at least add me as a co-author to the commit if you can
austere talon
Backend
turbid hatch
is it?
lament nimbus
Probably TymanWasTaken tbeckman530@gmail.com
austere talon
blackman530
turbid hatch
what the fuck is git on
i edit 5899743
and it creates a NEW commit
i literally told it to amend the message
okay
im done im too tired for this lol
austere talon
lol
turbid hatch
git is pissing me off
austere talon
want me to fix it up
turbid hatch
🙏
austere talon
okay in a bit
turbid hatch
ty
lament nimbus
blackman530
No
austere talon
oh wait
I read it completely wrong
tbeckman530
I think it's cause tbeck isn't a word so my brain just "fixed" it to the nearest word
woeful sable
how is this even being found
mobile + api errors
charred monolithBOT
lime stone
just a bit verified
austere talon
charred monolithBOT
charred monolithBOT
lime stone
somehow i forgot about breakpoints
lime stone
use breakpoints!
lime stone
ok, kind of managed to get viewicons to work with webhooks!
can't find a good way that doesn't break with name changes
the distance between a possible name capture and the actual target is very far
is there a good solution other than writing all of the code in-between?
verbal pumice
small nitpick about FakeNitro but if you switch to a light client theme from dark stock then discord won't save that you switched to a light theme on other devices
lime stone
kind of makes sense i guess
limber skiff
small nitpick about FakeNitro but if you switch to a light client theme from dar...
seems right
lime stone
small nitpick about FakeNitro but if you switch to a light client theme from dar...
discord itself kind of shows this bug
hmm, maybe not a bug, i just realised why this is a feature!
but you can bypass it
charred monolithBOT
verbal pumice
great plugin
lime stone
can you rearrange them?
limber skiff
pogggg
austere talon
can you rearrange them?
nuh uh
but wouldnt be hard to do
i don't think i will add categories
kinda useless imo
lime stone
can you explain a bit better
i need a way to capture "W" for openImage without hardcoding
limber skiff
ya
limber skiff
i need a way to capture "W" for openImage without hardcoding
send me your find
lime stone
send me your `find`
fnd.
verbal pumice
fnd
austere talon
should i add a setting to also show the dms in the normal list?
i think thatd be kinda useless
why would someone want duplicate entries
but would be easy peasy to do
i might as well ig
verbal pumice
muscle memory ig?
lime stone
{
find: "().avatarWrapperNonUserBot",
replacement: {
match: /(onClick:)(\i\|\|\i)\?(void 0)/,
replace: "style:($2)?{cursor:\"pointer\"}:{},$1$2?()=>{$self.openImage(W)}"
}
}
this?
austere talon
\i=(\i).avatarSrc,
lime stone
i need to capture it in the same patch though
unless... i guess i could store it in a variable? (using lambda)
is there a better way though?
lime stone
i have used that site likely more times than i've eaten
i have used discord in my entire life more time than i've spent photographing sushi!
i don't know whether this should worry me
lime stone
:O
charred monolithBOT
limber skiff
{
find: "().avatarWrapperNonUserBot",
replacement: {
match: /(avatarPositionPanel.+?)onClick:(\i\|\|\i)\?void 0(?<=,(\i)=\i\.avatarSrc.+?))/,
replace: '$1style:($2)?{cursor:"pointer"}:{},onClick:$2?()=>{$self.openImage($3)}'
}
}
try this @lime stone
lime stone
i will surely break it :3
lime stone
the code is so hacky cause discord's dm code is mega deranged
very no surprise me
austere talon
i had to monkey patch the return type and walk the react tree
limber skiff
monkey patch 🤨
austere talon
lime stone
return type??
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/pinDms/src/plugins/pinDms/index.tsx#L...
**index.tsx: **Lines 73-100
Wrapper: ErrorBoundary.wrap((props: { originalComponent: React.ComponentType<any>; selectedChannelId: string; }) => {
const original = <props.originalComponent {...props} />;
const originalRender = original.type.render;
original.type.render = (...args: any[]) => {
const res = originalRender(...args);
try {
if (seen.has(res)) return res;
seen.add(res);
const container = findInReactTree(res, node => node?.props?.containerRef);
const idx = container.props.children.findIndex(n => n?.props?.className?.startsWith("privateChannelsHeaderContainer"));
if (idx !== -1)
container.props.children.splice(
idx - 1,
0,
<PinnedDmsComponent />
);
} catch (e) {
new Logger("PinDMs").error("Failed to patch DM list", e);
}
return res;
};
return original;
})
lime stone
javascript has no return types, right??
austere talon
**index.tsx: **Lines 73-100
```tsx
Wrapper: ErrorBoundary.wrap((props: { origina...
i dont think there's a better way to do it
lime stone
that's what makes so great! 🌈🗑️ /s
limber skiff
ven insane
austere talon
because discord uses their abstract List component
verbal pumice
**index.tsx: **Lines 73-100
```tsx
Wrapper: ErrorBoundary.wrap((props: { origina...
what discord code does to a mf
lime stone
oh i see
lime stone
try this <@706152404072267788>
i was trying to avoid repeated wildcards
limber skiff
I can try making it use regex patch later if you want
limber skiff
i was trying to avoid repeated wildcards
huh?
limber skiff
it's fine on that case
lime stone
most frequently .+ and .*
limber skiff
you will also have better performance likely
lime stone
huh?
i feel like using a wildcard would slow down startup
(maybe not noticeable though :p)
let's see what the rest of vencord is doing
limber skiff
(avatarPositionPanel.+?)onClick:(\i\|\|\i)\?void 0(?<=,(\i)=\i\.avatarSrc.+?))
^ match avatarPositionPanel ^ match predicate ^ look behind to capture the var name
and walk til find onClick and rest of things
lime stone
oh, you can look behind?
limber skiff
avatarPositionPanel is wayyy less common than onClick
that gives you better performance
lime stone
i thought that was only supported on Google Chrome v. 28519258912589582959
or something
austere talon
.+ is fine but you should always make them lazy, never ever nest them (ReDOS) and try to avoid using them in lookarounds
lime stone
lol outdated stackoverflow posts my beloved
maybe it's most efficient to capture into a var using a lambda though?
limber skiff
austere talon
<:trolley:1024751352028602449>
In this case it's fine
limber skiff
ye
lime stone
ven approved™
austere talon
i thought that was only supported on Google Chrome v. 28519258912589582959
no, lookarounds have good support in js
but lookarounds and other extensions mean ur engine is more vulnerable
lime stone
outdated stackoverflow probably :p
limber skiff
lookarounds in js so good cuz they support non fixed lengths matches
austere talon
Javascript regular expressions have the potential to take hours to complete
lime stone
doesn't seem to work though
lime stone
Javascript regular expressions have the potential to take hours to complete
oh, sounds nice to watch! /s
limber skiff
doesn't seem to work though
really?
austere talon
that's what i mentioned just now, ReDoS (regex denial of service)
limber skiff
send me the regex that your console prints
lime stone
ah, unmatched parens
austere talon
it's caused by exponential runtime when nesting quantifiers
limber skiff
oh
lime stone
it's OK now
limber skiff
wait huh
austere talon
like (a+)+b will take hours on an input string of many a not followed by b (because it will not match so the js regex engine will try every single path of possibly matching)
limber skiff
where?
austere talon
silly js
lime stone
at the end
lime stone
anyway thanks for this! you are one of the most regex god/goddess/[insert] of all time!
fleet depot
Deity
turbid hatch
this is why @umbral hill has a regex implementation that isnt in javascript
despite the rest of the bot being js
fleet depot
What's the regex implemented in
fleet depot
Oo
austere talon
Its syntax is similar to Perl-style regular expressions, but lacks a few features like look around and backreferences. In exchange, all searches execute in linear time with respect to the size of the regular expression and search text.
js regex doesn't guarantee that so worst case is exponential time growth in regard to input length
turbid hatch
aka sacrifice a few features that people dont generally use to protect against ReDoS
turbid hatch
explode
austere talon
probably also for simplicity :P
turbid hatch
probably also for simplicity :P
probably! although i dont believe its possible to implement those features without breaking the linear time guarantee
lime stone
hmm, maybe port discord to java and then we can use a nice patching lib like https://github.com/SpongePowered/Mixin
(joke)
well, i guess there was a java version of discord?
austere talon
probably! although i dont believe its possible to implement those features witho...
Well yeah that engine uses finite automata but finite automata only support regular grammars and lookarounds and back references aren't regular so I think supporting those wouldn't be trivial
lime stone
@limber skiff should i co-author?
limber skiff
nah it's fine
lime stone
assuming that's indifference rather than total repulsion i will anyway :3
turbid hatch
Well yeah that engine uses finite automata but finite automata only support regu...
yep
well
not even trivial
just impossible with finite automata
as far as im aware, im only partially fluent in the theory of it
austere talon
with pure fininite automata yeah but yo could combine them with other logic perhaps
lime stone
don't mind me, just stealing your email address
austere talon
idk
limber skiff
don't mind me, just stealing your email address
leaked
limber skiff
🤮
austere talon
wdym
lime stone
resend them under a webhook
generally how you make people say things they didn't here on discord :3
austere talon
lmao
jagged cloak
lol
austere talon
I love smiley dealer
jagged cloak
lore pog
lime stone
I love smiley dealer
me 2
austere talon
lore pog
jagged cloak
slow smiley as usual smh
austere talon
it's okay it doesn't get paid so it's a bit slow
lament nimbus
blocked :3
ok now that my pr was (jankily) merged time to selfhost vencord backend
jagged cloak
lore jumpscare
lime stone
pog
lament nimbus
ok now that my pr was (jankily) merged time to selfhost vencord backend
add it to my collection
charred monolithBOT
austere talon
by fix default avatars you mean fix the fact that the format setting will make them use not png?
oh i see what u mean
lime stone
it causes an error in the console
austere talon
let { format } = settings.store;
if (url.startsWith("/")) {
url = window.location.protocol + "//" + window.location.host + url;
format = "png";
}
const u = new URL(url);
const format = url.startsWith("/") ? "png" : settings.store.format;
const u = new URL(url, location);
this does the same
austere talon
you should always aspire to make your code redeclare as little variables as possible imo
makes it more readable
lime stone
i thought that was sarcastic lol
lime stone
toot
wouldn't you have to duplicate the check to modify the url to be correct?
this one
austere talon
what
austere talon
```js
const format = url.startsWith("/") ? "png" : settings.store.format;
const ...
this works fine
look at the screenshot i sent
austere talon
you're using it in ur own code as not a string
lime stone
i guess just add toString()?
austere talon
no
lime stone
or href?
austere talon
actually toString() works
lament nimbus
typescript is stupid
well it's doing its job
nocturne haven
the types for it are wrong
lament nimbus
yeah
nocturne haven
I had the same happening with other global apis, it's really annoying
lament nimbus
which if the types are default JS types it is the problem of the TS devs but whatever
its not the language itself, it is doing what is asked of it (checking if location is a string or url, which it is not)
lime stone
well i assume it compiles but vscode will bully me :'(
austere talon
just use location.href ye
nocturne haven
//@ts-expect-error or what ven said
lament nimbus
ts expect error is a bad idea
nocturne haven
ts bug you can't account for 🤷♂️
lime stone
sign it if you care that much :p
austere talon
i think passing location is actually not correct and the reason it works is because the URL constructor like many other js apis just implicitly converts the input to a string
lime stone
lime stone
i think passing location is actually not correct and the reason it works is beca...
is this js or c++ any more?
austere talon
i think passing location is actually not correct and the reason it works is beca...
which makes it technically okay to pass an URL but it's not the intended type
nocturne haven
ah, yeah it's not a TS bug
nocturne haven
the actual spec says URL(url: string, base: string)
turbid hatch
you're correct ven
it's implicitly tostringing it
its technically wrong so typescript is right in this regard
austere talon
I'm more surprised that location.origin does not derive from URL
lime stone
easiest solution
hey, that was my idea
austere talon
I'm more surprised that location.origin does not derive from URL
it's so close but missing a few members
lament nimbus
hey, that was my idea
I believe ven did actually try and load swc via webassembly once
austere talon
yeah but its hella slow cause serialisation & ipc is slow
lime stone
I believe ven did actually try and load swc via webassembly once
swc?
austere talon
speedy web compiler
austere talon
is that actually what it stands for
lament nimbus
it has a JS AST
austere talon
but yeah it's super slow because serialisation
turbid hatch
Slower Web Compiler
austere talon
swc took ~1s to parse a 1.2mb module, acorn was nearly instant
lime stone
lament nimbus
but yeah it's super slow because serialisation
epic rap battles of history: discord's shitcode vs SWC
austere talon
naaah its not swcs fault
nocturne haven
is that actually what it stands for
that's interesting
lament nimbus
swc took ~1s to parse a 1.2mb module, acorn was nearly instant
whats acorn?
austere talon
pure js js parser
lament nimbus
did you actually end up using it
lime stone
epic rap battles of history: discord's shitcode vs SWC
is shitcode a noun now?
i see it a lot!
austere talon
the reason SWC was so slow is because you have to run wasm in a separate thread. To communicate with it, you need to first serialise the input string and send it over, then later serialise the return object
nocturne haven
yeah but its hella slow cause serialisation & ipc is slow
yeah, the main issue with wasm in general
austere talon
that's the slow part
austere talon
yeah, the main issue with wasm in general
yeah true, wasm is almost never worth it
tbh even for binary manipulation, TypedArrays are incredibly fast so it's usually not worth it to use wasm
lament nimbus
is shitcode a noun now?
idk I just combined the adjective "shit" and the noun "code" in order to make a more fun word
jagged cloak
shitcode is programmer slang
lime stone
yea
lament nimbus
yop
nocturne haven
tbh even for binary manipulation, TypedArrays are incredibly fast so it's usuall...
yeah, well the slow part iirc was wasm having to write into the memory blob of it self, sending me a pointer and us having to read this pointer. the fun part is it doesn't even have access to write into it's own memory
it feels like manually passing sparks in your CPU, not really the concept JS was made for
turbid hatch
wasm is only good if you're doing most of your stuff in wasm and the js bit is just a thin wrapper
if you're constantly passing data then its not worth it
lime stone
pins always seem to go to the bottom
if you can't reorder them that's annoying :(
anyway i wasn't sure whether you were saying my idea was pointless or another one
kind of obvious but pins also don't work for "buried" dms
well, not even buried
just any dm that's not on the list any more
nocturne haven
open it again then
austere talon
jagged cloak
so true
lime stone
like with channels
nocturne haven
I've done such plugin before too, only issue I was facing was that the dms list is lazy scrolled and you'd have to patch it
austere talon
wdym
nocturne haven
typo, edited
austere talon
i don't touch any of the original ui
nocturne haven
well, the dms list of people is a lazy scroller, meaning it'll only render as much as screen height allows
austere talon
i just patched the DMChannel component to render null if it's pinned and not rendered by me and then just render each pinned channel myself
nocturne haven
that'll cause issues with the scroller, I can tell from experience
this is what you need to patch
you essentially patch the parent to modify sections
austere talon
oh i see what u mean
wow discord's code for that is even more terrible than i thought
jagged cloak
holy shit horror
austere talon
discord carefully writing the worst react code you've ever seen
question is whether i care
just dont pin that many channels
nocturne haven
I mean, there could be better implementations of lazy scrolling honest
austere talon
if u pin that many channels u might as well just not use the plugin
nocturne haven
I wouldn't go that route
lime stone
haha
woeful sable
.
lime stone
i think it's best to make a feature work :P
jagged cloak
yeah
lime stone
ohh
jagged cloak
ig they were lame when they joined then changed name
austere talon
read the rules dumbass
jagged cloak
have fun
nocturne haven
pretty stupid
no u
jagged cloak
lmao
lime stone
ig they were lame when they joined then changed name
nvm, i think the R is another character
cyrillic possibly?
red rock
https://tenor.com/view/choi-hoes-mad-dancing-cheerful-anime-gif-16411327
anime gif :D
red rock
anime gif :D
lime stone
russian name
ye
lime stone
i think it's related in some way
i just sound smarter using that term :)
even though it could be totally wrong
sudden pilot
literally a name smh
austere talon
@nocturne haven i assume sections stands for how many items each section has. So to render 3 pinnes dms I would need to change Sections from 5, 184 to 3, 5, 181 and then patch renderSection and renderRow to add my own handling?
lime stone
but possibly both sounds very smart and also makes you sound less stupid if you were wrong
sudden pilot
y'all should transliterate it instead of just lame face
austere talon
no
sudden pilot
yes
sudden pilot
ya
lime stone
vencord logic though, won't argue
sudden pilot
husk
lime stone
we're on the server that created <@&1073655264923881602>
sudden pilot
<@&1073655264923881602> explod
red rock
explod
nocturne haven
<@415849376598982656> i assume sections stands for how many items each section h...
Not exactly, imagine section as category, so let's imagine you have those categories:
-- Cat 1 --
item
item
-- Cat 2 --
item
item
item
-- Cat 3 --
item
would be now [2, 3, 1]
austere talon
isnt that exactly what i said
nocturne haven
I might be confusing it I guess
nocturne haven
It's a library, back when discord was made this was best software
lime stone
hm, does viewicons work on the sidebar card for users?
austere talon
does that library ignore 0 sections
nocturne haven
reading your message again makes sense now, my bad 
nocturne haven
does that library ignore 0 sections
no clue, I don't think so though
shut socket
For creating new UI component do I patch the parent component?
austere talon
ew wtf is preRenderedChildren
is that cached children or what
seems to only be the non dms
nocturne haven
it's just a number it seems
austere talon
yeah
nocturne haven
weird name though
austere talon
its always 5