:worksonmymachine:
#👾-core-development
iron elm
jagged cloak
nop stable is bork
lime stone
epic A/B testing
from the users' perspective, how many pixels are changed? xD
austere talon
austere talon
what
heavy widget
same
austere talon
???? github
woeful sable
so real
austere talon
someone test if this pr works for u
woeful sable
ok
woeful sable
someone test if this pr works for u
realest badges
austere talon
So works
woeful sable
yes
woeful sable
do all of them work
yeah
austere talon
Nice
this is classic discord code
they have the same code twice
I just had to make the regexes global so they patch both places
verbal pumice
nice
cunning bobcat
does gh pr create need you to fork the repo or can i do it from a local commit instead
austere talon
u need to fork
cunning bobcat
damn
cunning bobcat
time for branch hell again
cunning bobcat
quick ibex
Lol
cunning bobcat
how are they both on the same commit what
520 git commit -am "Add debugging info to CustomRPC, and a link to the docs."
535 git remote
556 git branch
558 git checkout -b customrpc-debug-and-docs
ah.
cunning bobcat
cc @ ven here's that PR you-
anger
why do you lint it twice
cc @austere talon ready for review
jagged cloak
someone test if this pr works for u
ye i was using it for the fakenitro thing lol
baller
austere talon
why do you lint it twice
?
austere talon
ye i was using it for the fakenitro thing lol
what
cunning bobcat
lint & check if desktop compiles
lint & check if web compiles
austere talon
lint & check if desktop compiles
lint & check if web compiles
doesn't matter :P
cunning bobcat
true :3
marsh cave
yeah it kinda is tbh
austere talon
there's no real difference between the different functions
it's best practice to always use querySelector for consistency
and better maintainability because u can easily add more stuff
marsh cave
eh, there is a difference, but sure
austere talon
and better maintainability because u can easily add more stuff
Also getElementByClassName and friends have weird caveats @marsh cave
did you know that getElementByClassName returns a live html collection instead of a snapshot
the list will be updated live when an element gets removed or added
I didn't know that but just found out now
lime stone
i've had issues with it in the past...
marsh cave
did you know that getElementByClassName returns a live html collection instead o...
yeah, but i didn't think much of it because it didn't matter for the current plugins
woeful sable
silly man had to fix everything for me 
woeful sable
smol
austere talon
But i decided to refactor plugin while I was at it
code u didnt even write :P
the only issue ur code had was some small lint failures (single quotes instead of double quotes for example) and that ur find for their uuid module wasn't unique
everything else was fine 
thank u
imagine it randomly using the third as id
would be funny
woeful sable
imagine it randomly using the third as id
but ofc
woeful sable
the only issue ur code had was some small lint failures (single quotes instead o...
my coding skills are equal to zero 💪
austere talon
@rustic nova
when you zoom with scroll
it's not persisted
is that intended?
as in
- hold for lens
- zoom in or out
- let go of lens
- hold again
Expected (?) behaviour: Zoom is exactly like it was before letting go of lens
Actual behaviour: Zoom is reset to whatever it was initially before you did these steps
seems like they are only persisted when you close the image modal
not when you stop zooming
Start zooming
scroll in
Stop & Start zooming
Not persisted
Start zooming
scroll in
Stop zooming
close image
persisted
austere talon
@limber skiff this tooltip sucks
it should say Enable Game Activity / Disable Game Activity ( based on current state )
woeful sable
silent message has the same kind of tooltip btw
red rock
you bully my tooltip
I like your tooltip :3
limber skiff
I like your tooltip :3
thanks
rustic nova
it's not persisted
oh yeah i forgot. i did save it but only after you close the modal but it should be fixed now
austere talon
okay thank you I will try again
other than that it seems to work fine
I fixed your code for the new discord update, u probably saw
rustic nova
I fixed your code for the new discord update, u probably saw
thanks :D
charred monolithBOT
About:
A recreation of the original client theme discord experiment, before they ruined it with gradient overlays.
Demos:
https://user-images.githubusercontent.com/37855219/230238798-2284cb50-3409-45e3-9c4a-17e6f5...
frail sky
austere talon
hardest image ever btw @rustic nova
WHY IS IT ROUND
cursed
thanks for the quick fix aria
🙏
rustic nova
hardest image ever btw <@549244932213309442>
🫡
rustic nova
thanks for the quick fix aria
:D no problem
rustic nova
YEAH ong
austere talon
pnpm v8 jumpscare
lol @rustic nova i already found a bug with zoom i think
go to this and try zooming
rustic nova
oh no
austere talon
wait no its just fully broken?
hmmm
lemme see
might just be me
im sorry false alarm :3
seemed to have been some bug idk why
gonna have to see if it happens again
rustic nova
phew
austere talon
no i think just round spotify cover
spark cove
did they remove this option from mobile
austere talon
nuhuh
austere talon
OH
fleet depot
@austere talon i know no reply mention exists! I have it enabled.
austere talon
okay sorry i misunderstood drastically
fleet depot
iz okie
charred monolithBOT
austere talon
im so sorry i thought it was just another one of those stupid requests of people not reading anything
i updated the issue title
fleet depot
all g
austere talon
ITS WORKING
charred monolithBOT
jagged cloak
moretags plugin added staff tags n stuff 
jumpscare
its fine i turned it to profiles only
austere talon
ohhhh
yeah moretags jumpscare lmao
I finally merged
maybe we shouldn't have migrated plugin settings
because its kinda different plugin now
jagged cloak
trolley
charred monolithBOT
turbid hatch
wait no we should make gdpr policy first
hnnnnnnnng
review it in the meantime, ill write the gdpr stuff
tight vapor
Is there a way to get around CORS preflight thing
I tried to make a plugin that would get the lyrics for a song with genius
And I was using the genius API to get information ab the song
And for the search too
But it kept giving me an error ab preflight or something
I tried the axios library and that also kept erroring
I asked ChatGPT and it said I need to use a proxy server
Should I just use deno deploy to make the genius API request for me
cold patio
Hey I just wanted to ask how should I go about adding a library to Vencord? I have already developed a plugin and now I want to create more plugins but they all use a lot of the same code. Should I add a plugin that does nothing but act like a library?
turbid hatch
what is this library
cold patio
I would add react components, types, utility classes and maybe some other things. Of course only if they are used in multiple plugins.
turbid hatch
this seems like stuff that should be part of vencord's stdlib
not a separate plugin or library
if they're going to be used by multiple plugins and may be useful in the future then i'd just add it there
cold patio
Yes, that might be true for some code, but maybe not for some. An example would be a react component that gets passed a connection object from the mediaEngine and sets some audio settings for the screenshare. This could be used multiple times in my case for my Better Screenshare Plugin and a BetterMic Plugin which I'm working on. Would it be okay to add such a component? Because this is probably the only use case.
turbid hatch
it varies i suppose
im not sure where that would be appropriate, this is a question for @austere talon
lucid lynx
what would this issue be caused by? i think it's an issue with discord updating to electron 22
but i want to know if this is an easy fix in css or something
(you might have to fullscreen the video to see what i mean)
austere talon
what issue
austere talon
discord issue
cold patio
im not sure where that would be appropriate, this is a question for <@3433835728...
Okay. @austere talon so what do you think?
austere talon
wait that's you
I didn't even notice
optimally it should use the upcoming array settings type
but that's still gonna take 5 million years probably
working on it
quick ibex
e
fleet depot
Wait I think this may be a duplicate
Oh yours is a pull request right right
I didn't read that
Mb
charred monolithBOT
umbral hedge
what an amazing comment
truly a [vc]: #dDN0nqQYJXSieMVnGgmnuwsB6xUQ+oeWVtMNpNF9HBo=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ2ZW5jb3JkLXdlYnNpdGUiLCJyb290RGlyZWN0b3J5IjpudWxsLCJsaXZlRmVlZGJhY2siOnsicmVzb2x2ZWQiOjAsInVucmVzb2x2ZWQiOjAsInRvdGFsIjowLCJsaW5rIjoiIn0sImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS92ZW5kaWNhdGVkL3ZlbmNvcmQtd2Vic2l0ZS80RW5ob3Rkb0JYUlpabnd1NnFERVVTZ0ZYbVgzIiwibmV4dENvbW1pdFN0YXR1cyI6IlBFTkRJTkcifV19
The latest updates on your projects. Learn more about [Vercel fo... moment
austere talon
yes
i think the gdrp one should be prominently displayed at the top @turbid hatch
like in the introduction
turbid hatch
oki
turbid hatch
i think the gdrp one should be prominently displayed at the top <@96269247411400...
done
austere talon
hot
austere talon
i feel like this might seem like its vencord source code
charred monolithBOT
turbid hatch
i can finally hop off mr vencord updater's wild ride
turbid hatch
i feel like this might seem like its vencord source code
hm
its cause we have the github icon in the bottom right and that
austere talon
where r u hosting the backend now? On my vps? or ur own
turbid hatch
vendymachine
austere talon
i have a nice idea for notifications
essentially we could add a new property "doNotShowAgainId"
showNotification({
title: "Cloud Settings",
body: "Your settings have been updated! Click here to restart to fully apply changes!",
color: "var(--green-360)",
onClick: () => window.DiscordNative.app.relaunch(),
doNotShowAgainId: "cloud-settings-sync"
})
whenever that id is set, it would add a button "Do not show again"
and then future notifications with the same id won't show again
could use that for update notifs, cloud sync notifs, maybe more in the future
turbid hatch
hm
needs better wording though i think
mutex maybe?
mm
no
why cant i think of the name for this lol
austere talon
why cant i think of the name for this lol
my name is fine i think
it doesnt matter that much xd
turbid hatch
there is a proper name for it but yeah it'll work xd
austere talon
id rather it's easy to understand than pretty
turbid hatch
does this actually work with the proxies @austere talon ?
austere talon
ye
austere talon
but u can at least
const { cloud } = useSettings()
hm
okay i'll do that
there ye go
whoops
stray eslint comment
sec
https://x.lewisakura.moe/23/04/Code_-_Insiders_2023-04-06_16-32-21.png i wanna get off mr updater's wild ride
jagged cloak
why cant i think of the name for this lol
uuid? lol
turbid hatch
no
jagged cloak
but the other name is fine
turbid hatch
its a single id representing the notification specifically for the purpose of being able to hide it later
not a unique id for that notif
so uuid isnt fitting
jagged cloak
mm
austere talon
okay gotta do some more checks and I think you using fflates strtou8 might bloat bundle unnecessarily
then I'll merge
austere talon
its a single id representing the notification specifically for the purpose of be...
the idea is to put it on common identical notifications that may annoy users like "Vencord has just been updated" or "Cloud settings synced successfully"
So you can choose to hide those notifications without us having to add 3 million settings toggles
turbid hatch
okay gotta do some more checks and I think you using fflates strtou8 might bloat...
im pretty sure its bundled anyway
because fflate uses it internally
austere talon
might
but I will check
cause it just does the same as new TextEncoder().encode()
but also has a fallback
you can easily test yourself
if you just pnpm build it will tell u bundle size
then remove those imports and use TextEncoder and Decoder instead, rebuild and see if it shrinks
turbid hatch
-2kb
austere talon
I'm so smart
2kb is nothing but the fact that changing one line makes us save 2kb is worth imo
I think it's because you only use deflate (?)
turbid hatch
and deflate
austere talon
other way round, only deflate
I think u shouldn't need to use inflate
if u set the correct content encoding header the browser should automatically inflate for u
turbid hatch
lets see
turbid hatch
if u set the correct content encoding header the browser should automatically in...
oh wait
hold on
if we end up doing encryption we cant do this
so its probably best we avoid getting the browser to do it
austere talon
Why's that?
turbid hatch
if we're encrypting i'd probably encrypt the compressed bytes rather than the string mainly out of convenience
and also its almost impossible to compress encrypted bytes
Compress first. Once you encrypt the file you will generate a stream of seemingly random data, which will be not be compressible. The compression process depends on finding compressible patterns in the data.
https://stackoverflow.com/a/4676108
@austere talon y/n?
turbid hatch
because these are technically global vars and i dont particularly want instances of these around if people arent using this feature set
austere talon
or just inline the new TextEncoder()
austere talon
because these are technically global vars and i dont particularly want instances...
do u know how optimised making instances of classes is
(very)
:P
turbid hatch
is it
austere talon
just inline them in any case
turbid hatch
alr
austere talon
is it
Discord has thousands of instances
do u really think 2 more instances will hurt 
turbid hatch
idk why im so concerned with memory optimization today
rustpilled
its only 1kb now for some reason
but i guess its a saving nonetheless
austere talon
okay so
it looks like u have a lot of duplicated code for some reason
like
SettingsSyncSection & CloudTab
why are those almost the same
im confus
woeful sable
how to report bug
stiff cove
github
woeful sable
ok send link or i kiss u
stiff cove
huh???
verbal pumice
how to report bug
verbal pumice
gh issues is only for when youre sure its a proper vencord issue
woeful sable
probably is
verbal pumice
if its just the user being stupid you wasted your time
woeful sable
i cant see emoji reactions
turbid hatch
SettingsSyncSection & CloudTab
que
woeful sable
and cant put emoji reactions
turbid hatch
its got the same general layout but the actual content is different
woeful sable
ok
turbid hatch
if we end up extending this then i dont really want to be shoving tons of sections into one massive function, so i split it up
austere talon
can u not post dumb garbage in dev channels thank you
turbid hatch
its got the same general layout but the actual content is different
i could reduce this a bit by making a function to do the sections for me
but it seems like a waste
austere talon
nah itsp robably fine
i was just confused
but also one of them has confirm the other doesnt
kinda weird
turbid hatch
erasing all your data is a big deal vs erasing the settings stored in the cloud since you can just click the other button to upload them again
erasing all your data means your secret is invalid across all platforms alongside any data in the future that gets stored
so one has a tooltip and one has a scary alert
that was my justification :P
austere talon
oh i see
okay
i just skimmed tbf
i didnt realise it was actually diff stuff
i just assumed it was the same thats why i also said dupliocated code
turbid hatch
ah nah
the one in CloudTab is the overall layout for the tab
but its code includes the header bit where it lets you configure
turbid hatch
SettingsSyncSection is specifically just the settings sync section of the tab
so i split it off to have separate logic
it also means that it wont rerender the whole fuckin thing every time
austere talon
guh ill have to use normal discord again
umbral hedge
if i checkout the PR will it just work TM or will I have to do anything weird
austere talon
guh ill have to use normal discord again
he was forced to use discord desktop app
turbid hatch
if i checkout the PR will it just work TM or will I have to do anything weird
should just work
austere talon
i must add vencord dev support to vencord desktop immediately
umbral hedge
add krisp to vencord desktop
oh right i need to finish working on my krisp patcher
it checks the app signature so can't run behind armcord, etc. but it's pretty easy to patch out the check but I want to automate it so I'm not releasing binaries
arctic monkeys reference?
austere talon
maybe mention in the "you can even selfhost it" that it's free/libre/foss/whatever
turbid hatch
stallman approved
austere talon
YES
umbral hedge
real
turbid hatch
got it
austere talon
It respects your privacy, you can selfhost it and it's even stallman approved!!
lime stone
[richard stallman] i aprove this
austere talon
maybe mention in the "you can even selfhost it" that it's free/libre/foss/whatev...
"free software" is a really bad term but "open source" is even worse
lime stone
what's the best term then?
austere talon
what's the best term then?
free/libre is the least bad term
umbral hedge
"Cloud" on its own at the bottom looks weird
can you move it up or rename it something like "Cloud Sync" or "Cloud Settings" or smth 
lime stone
maybe just below updater?
umbral hedge
either move it up one or cloud settings/sync im happy with
austere talon
wtf are these memes lmao
umbral hedge
if you disable cloud integration you can't delete your data lol
stiff cove
turbid hatch
if you disable cloud integration you can't delete your data lol
well yes because it doesnt know which backend you're running and it needs your secret to do that
:P
deleting will disable it for you right after
austere talon
"free software" is a really bad term but "open source" is even worse
the reason is that the term open source implies that just access to the source code already makes it free software which is simply not factual and is heavily abused by big corpo, with companies like Cloudflare calling Wildebeest open-source, or google calling actual source-available code "open source"
there are so many more aspects to proper free software than just the source being open
umbral hedge
theme links not synced? I saved, added a theme link, and pulled from cloud, and the link didnt disappear
or is it synced but just append-only/non-destructive?
oops im tired mistype
austere talon
theme links are not synced in general even with backup& restore (because i forgot to update backup & restore). Should probably be fixed but also if we do move to letting users load arbitrary files we wouldn't want to sync those
umbral hedge
im so dizzy today idk whats wrong with mne
yeah i need to hurry up and finish themes pr
i might do today if my dizziness doesn't get in the way
honest geyser
the reason is that the term open source implies that just access to the source c...
yeah I hate that my school uses "free software" that doesn't use anything like git and releases tarball every now and then of the source code like wtf how am I supposed to contribute
umbral hedge
oh yeah
turbid hatch
theme links are not synced in general even with backup& restore (because i forgo...
when you make the changes to backup and restore it'll apply to settings sync too
umbral hedge
theme links are not synced in general even with backup& restore (because i forgo...
if that's the case, are we getting rid of theme links entirely once local themes are merged?
austere talon
yeah I hate that my school uses "free software" that doesn't use anything like g...
you usually contribute by sending patches via email
turbid hatch
im so dizzy today idk whats wrong with mne
can you get a doctor's appt?
honest geyser
well that's stupid
austere talon
why do u think people moved to git hosts
but email was the original way to contribute via git
honest geyser
how can you call the intended way stupid
just use git smh
turbid hatch
thats it
austere talon
forks are a fake concept invented by git providers
turbid hatch
vencord is now mailing list only
umbral hedge
can you get a doctor's appt?
i mean i know its dehydration but i havent figured out why yet
austere talon
just use git smh
it does use git
umbral hedge
ive drunk so much
honest geyser
no
austere talon
yes
umbral hedge
rehydration tablets and everything
honest geyser
it doesn't use git
turbid hatch
ive drunk so much
yeah this is why i say go and call a doctor
like
sooner rather than later
austere talon
git is a version manager, git hosts like github are not related to git anyway, it's just a more convenient way to contribute
honest geyser
git is a version manager, git hosts like github are not related to git anyway, i...
ik, but the software my school use doesn't uses git for vc
austere talon
what kind of software
umbral hedge
my local gp does same-day appts so if it persists i can send in an appt req on sunday and get seen on monday
austere talon
what do they use 
honest geyser
dosn't use vc at all
austere talon
(also not accepting contributions is part of the freedom granted via free software, you can just edit the source code and distribute modified copies urself)
honest geyser
what kind of software
for assignement and ressources
umbral hedge
epic
austere talon
REAL
umbral hedge
good 'nuff
austere talon
LOL why did u actually say stallman approved ahahha
umbral hedge
I still prefer cloud sync but 
austere talon
stallman will sue us lewi...
turbid hatch
LOL why did u actually say stallman approved ahahha
:^)
turbid hatch
stallman will sue us lewi...
shh
we're using his license
its fine
WAIT
I CAN SUPER REACT
austere talon
maybe i restart discord
umbral hedge
oh yeah bit unrelated but i notice now doing pnpm build builds vencordDesktop stuff
why not a separate thing like we have for web
turbid hatch
maybe
austere talon
AYO
austere talon
oh yeah bit unrelated but i notice now doing pnpm build builds vencordDesktop st...
why?
that would be way more effort
umbral hedge
idk whats the distinction between vencordweb and vencorddesktop lol
austere talon
VencordDesktop is just desktop build
but without the patching aspect and without DiscordNative
the reason web is in a different file is because it uses a very different configuration
umbral hedge
hmm
austere talon
but VencordDesktop & DiscordDesktop are pretty similar, the only difference are their defines
austere talon
vencord desktop builds with IS_VENCORD_DESKTOP=true and discord desktop with IS_DISCORD_DESKTOP=true
thats the only diff :P
but yeah vencord desktop works so well
umbral hedge
just lots of spam when building
umbral hedge
I just use armcord unless i need to use vc
austere talon
umbral hedge
because krisp
austere talon
I just use armcord unless i need to use vc
the idea of vencord desktop is that it also runs our Desktop bundle
which enables many more features
and our own updater
austere talon
desktop bundle
umbral hedge
oh
austere talon
i love wasting my superreactions
severe aspen
but without the patching aspect and without DiscordNative
what if I'll implement a subset of it just to have voice properly working
austere talon
~~what if I'll implement a subset of it just to have voice properly working~~
you can't
umbral hedge
1984
austere talon
if you define window.DiscordNative the entirety of discords code base will start thinking it's running in desktop mode
so you have to implement everything
unless you add patches to change the code :P
umbral hedge
yeah it'll just crash if you don't stub everything
severe aspen
severe aspen
but I probably could just have it in scope of voice module?
red rock
Vendicated is cute
umbral hedge
though in my previous experience, just running discord in electron without changes was enough for it to crash
austere talon
im not sure how we should handle vencord desktop specific plugins
in which repo should they be?
im almost tempted to migrate to monorepo because sharing code is so inconvenient rn
austere talon
monorepos have so many benefits
austere talon
Vendicated is cute
no u
umbral hedge
if we (re)make vencord types lib we can just define the plugins in vencord desktop
austere talon
monorepos have so many benefits
monorepos are amazing if appropriate and done right, horrid if done poorly
austere talon
if we (re)make vencord types lib we can just define the plugins in vencord deskt...
but how would we do that, just auto publish vencord types to npm?
austere talon
or maybe just add submodule
umbral hedge
austere talon
yeah i did that for aliucord
its pretty simple but also horrid
and u gotta bump dependency so often lmao
umbral hedge
I made a @vencord/types thing that worked
austere talon
ig u can do
"dependencies": {
"vencord": "*"
}
but ofc never got around to adding plugin-dir loading
austere talon
and it will always just install latest
umbral hedge
ye
turbid hatch
o yea
austere talon
but ofc never got around to adding plugin-dir loading
i was working on prototype for plugin template
turbid hatch
did you want me to just change it to "it's even GPL licensed!" rather than stallman approved
austere talon
if u make vencord types package i can finish plugin template
austere talon
did you want me to just change it to "it's even GPL licensed!" rather than stall...
maybe say smth like
It respects your privacy and its source code is available under the AGPL-3.0 license so you can easily selfhost it
umbral hedge
oh looks like i might still ahve the code on a branch
nice
i thought i deleted it
austere talon
(& relicense backend from GPL to AGPL)
austere talon
basically
for any clouds you should always use AGPL
GPL source code right only applies to software u can download directly
turbid hatch
oooo i see
austere talon
so if you just consume the api you have no right to source code
someone could make a proprietary fork and host it and not have to make its source available
austere talon
AGPL is same as GPL + network use is covered
turbid hatch
i like my funny text though so
[...] It respects your privacy, you can selfhost it, and it's even AGPL 3.0 licensed! How's that for a deal?!
umbral hedge
I'm not a fan of the funny text
turbid hatch
aw
ill change it then
// Vencord Cloud - the API for the Vencord client mod.
// Copyright (C) 2023 Vendicated and contributors
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// This program is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Affero General Public License for more details.
//
// You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <https://www.gnu.org/licenses/>.
in the meantime is this header correct
austere talon
i think yes but maybe use /*
austere talon
// kinda deranged
grave mangoBOT
horrid https://github.com/elastic/go-licenser/blob/main/error.go#L1-L17
**error.go: **Lines 1-17
// Licensed to Elasticsearch B.V. under one or more contributor
// license agreements. See the NOTICE file distributed with
// this work for additional information regarding copyright
// ownership. Elasticsearch B.V. licenses this file to you under
// the Apache License, Version 2.0 (the "License"); you may
// not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
found the bare minimum for DiscordNative to get into app
severe aspen
write a plugin that patches the respective places
this legit sounds like a nightmare to fully fix
austere talon
how so?
it's fairly simple you'd just need to patch out a few checks and make it use your own global instead
I already did that in a very simple plugin that enables copy link and open link on web
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/plugins/webContextMenus.web....
**webContextMenus.web.ts: **Lines 28-45
patches: [{
// There is literally no reason for Discord to make this Desktop only.
// The only thing broken is copy, but they already have a different copy function
// with web support????
find: "open-native-link",
replacement: [
{
// if (isNative || null ==
match: /if\(!\w\..{1,3}\|\|null==/,
replace: "if(null=="
},
// Fix silly Discord calling the non web support copy
{
match: /\w\.default\.copy/,
replace: "Vencord.Webpack.Common.Clipboard.copy"
}
]
}]
Can someone explain me how I can use lodash?
cold patio
No that's not what I meant haha. I meant how to import it sorry.
umbral hedge
window._
turbid hatch
i will stop touching cloud settings sync pr now
cold patio
Yes it works thanks
turbid hatch
i think its okay
umbral hedge
np
turbid hatch
unless anyone finds anything more to recommend
umbral hedge
ok kinda fixed it up
using my old plugin template
@austere talon have you pushed your current plugin template anywhere?
austere talon
nuh uh
austere talon
ok kinda fixed it up
does that already work? the imports & building
austere talon
ok kinda fixed it up
this looks like it's intended for one single plugin
I think a monorepo would be much more logical
but that shouldn't be too hard to change 
umbral hedge
does that already work? the imports & building
my build script is scuffed
umbral hedge
this looks like it's intended for one single plugin
?
im importing a types lib in this plugin
xd
this is just a demo of importing the types lib into a plugin
i use it to test the types lib
deciding between vencord-types and @vencord/types as a package name
austere talon
namespace imo
umbral hedge
yeah
atm there's just a vencord-types folder in the main repo with an index.d.ts stub
and you just pnpm typegen which creates that child vencord folder with the types
idk how version bumping would work
ashen pumice
@austere talon All network errors are fixed. https://github.com/Vendicated/Vencord/pull/792
woeful sable
what the actual shit happened 💀
woeful sable
defo my themem
but on another note
You know the spotify controls thing.
every other button is sycned well, but the bar is not, the bar on discord is like 3:20 and on actual spotify it's 3:50
How do I link it?
I doubt it's my theme this time
woeful sable
Oh right
lament nimbus
jagged cloak
no its firefox moment
turbid hatch
@austere talon its not on automerge btw :P
this was before automerge was enabled iirc
austere talon
should we change this logo?
turbid hatch
are you talking about the authorization: one?
thats the secret it generates
check your localstorage
austere talon
it looks a lot like a Discord token ngl
austere talon
i feel like a lot of users will be jumpscared if they check
it starts with my userid doesnt it
yes
austere talon
yes
turbid hatch
hm
austere talon
maybe change that
just so it doesn't look like ur actual token
that jumpscared me cause i recognise my token from a mile away
turbid hatch
NotYourDiscordToken.OTYyNj.....
austere talon
so i was like waaaait what
turbid hatch
yeah sorry i just introduced a token logger
dont mind me
what should the format be
secret first then user id?
austere talon
uh
ig
just not the userid first haha
didnt u wanna move cloud up?
or rename it
turbid hatch
i did move it up
or
i thought i did
yea i did
there you go @austere talon that should look less scary
austere talon
what is it now
austere talon
didnt u wanna move cloud up?
i didnt pull
turbid hatch
xd
austere talon
:3
austere talon
lmao i cant delete my data anymore
austere talon
okay but
when do u sync to cloud
u dont do it on settings change
only manually from the looks of it
turbid hatch
yeah cause i didnt want to send on every change
austere talon
why not do it on settings change?
turbid hatch
if you go tick tick tick on a bunch of plugins it sends a request for each of them
austere talon
you can debounce settings changes for a minute
austere talon
just debounce it
austere talon
const saveSettingsOnFrequentAction = debounce(saveSettings, 60_000)
is that an actual method we have
austere talon
yes
turbid hatch
til
turbid hatch
yes
austere talon
maybe also do it pre reloads
wait no
uh
optimally we want to sync when someone edits changes then immediately restarts
austere talon
uh
turbid hatch
settingsSync needs the settings api, settings api needs settingsSync
austere talon
window.onbeforeunload = function() {
return "you have unsaved settings. Consider syncing to become baller"
}
will that actually work xd
turbid hatch
it just stops me from reloading
austere talon
no
onbeforeunload is very limited
so u cant abuse it
According to the specification, to show the confirmation dialog an event handler should call preventDefault() on the event.
oh wait
nah doesnt work either
turbid hatch
window.onbeforeunload = function() {
window.onbeforeunload = undefined;
// show the alert here, dismissing resets the handler, accepting triggers the reload, pressing ctrl+r again also triggers it because of removing the event handler above
}
no
u cant im p sure
try it
we could just check on start whether settings are newer? if they are then sync
do that + debounce settings save to 1min
turbid hatch
it sorta works
austere talon
not on web
turbid hatch
if i setImmediate the reset of the handler it works on desktop
ah of course
web
my mortal enemy
austere talon
i would just check whether we're newer on startup and if so sync, and also do the debounced save on every settings change
turbid hatch
havent tried i just wanted to avoid it
austere talon
they just cause massive headache sometimes
turbid hatch
m, lets see
austere talon
but u cant always avoid them
austere talon
settingsSync needs the settings api, settings api needs settingsSync
could use events for this lol
:P
but circular dep is fine too
turbid hatch
it seems to.. not be upset
austere talon
like i said circular deps are fine usually
it only becomes an issue once you use stuff on the top level
turbid hatch
now we wait a minute
austere talon
thats why using Settings on top level of plugin explodes
but if u use them in any function it works
austere talon
hot
austere talon
ig
maybe make it more obvious which one was done
Synced to cloud or synced from cloud
austere talon
yes so that it saves if u enable plugins then immediately restart
turbid hatch
window.onbeforeunload = function() {
putCloudSettings().then(() => {
window.onbeforeunload = undefined;
window.reload();
});
}
so that wouldnt work?
austere talon
no