#๐Ÿ‘พ-core-development

1 messages ยท Page 31 of 1

limber skiff
#

yeah I did

austere talon
#

browser doesn't reach Updater code

#

so if u only use it there no need

limber skiff
#

hmhm

#

actually I'm using it here

austere talon
#

IS_STANDALONE && !IS_WEB ? gitTag

limber skiff
#

that works lol

austere talon
#

just make sure pnpm buildWeb and pnpm buildWeb --standalone still compiles

limber skiff
#

aight

#

I'm using all my brain for this

austere talon
#

but u didn't so all good

limber skiff
#

ok I have no idea if I did this right

#

please review my latest commit carefully

umbral hedge
#

real

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
unborn garnet
#

@austere talon merge

#

i like my plugins functional

limber skiff
#

I just realized we will not need the git-tag

austere talon
#

ye

charred monolithBOT
austere talon
#

There are 1 update

limber skiff
#

lol

#

There are 1 Updates*

limber skiff
#

dumb prettier is formatting the file

charred monolithBOT
austere talon
#

yeah but

#

why variable

limber skiff
#

how else can I do it

austere talon
#
- shcEmojiComponentExport=($self.setEmojiComponent($<component>),void 0)
+ $self.setEmojiComponent($<component>)
#

?

#

im confused what thats supposed to do

limber skiff
#

its like this

var a = function() {}
, shcEmojiComponentExport = (bla(a),void 0)
, c = "asdas"
#

it's just to execute that function when declaring the var

austere talon
#

why not just change it to

var a = $self.setEmojiComponent(function() {})
#

and make the setter return the value

limber skiff
#

not really friendly if any other plugin wants to touch that

limber skiff
#

plus garbage collector would throw that variable away anyways

austere talon
#

hmm fair

charred monolithBOT
charred monolithBOT
unborn garnet
austere talon
#

owned

quick ibex
#

Vendy just blue balling Sammy

#

Casually

#

With no remorse

frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors

#
Bad Patches

None

Bad Starts

None

Discord Errors

quick ibex
#

Is this real life wtf

cunning bobcat
#

not when keywordAlerts is merged

limber skiff
#

the fuck

#

shc fixed itself

cunning bobcat
#

wheeze

woeful sable
#

Discord Errors
1

honest geyser
#

discord โ˜•

austere talon
#

didnt i merge ur fixes pr

limber skiff
#

yeah but I didnt fix it on my pr

#

forgot about it lol

austere talon
#

LOL

#

discord amazing

woeful sable
#

there are discord employees here and they use vencord

limber skiff
#

it was the quantifier wrong

honest geyser
limber skiff
#

nah

#

it was a simple thing that was broken

honest geyser
#

no I mean that discord emlpoyees uses discord

woeful sable
#

discord employees sure use discord

honest geyser
#

I'm tired lol

#

I meant venchord

woeful sable
honest geyser
#

discord employees may use venchord

charred monolithBOT
#

Discord Account

Koxx12 is bad#0001

What happens when the bug or crash occurs?

when clicking on any channel mention not just voice channel mentions you have to click twice, disabling VoiceChatDoubleClick fixes it.

What is the expected behaviour?

only have to double click for voice channel mentions

How do you recreate this bug or crash?

  1. enable VoiceChatDoubleClick
  2. try and click any non voice channel mention once
  3. double click twice for it to work

Errors

_N...

limber skiff
#

yikes

cunning bobcat
#

SO THAT'S WHY I WAS HAVING ISSUES WITH CHANNEL MENTIONS

lament nimbus
dusky laurel
austere talon
#

someone fix

limber skiff
#

okie

limber skiff
#

very descriptive title

charred monolithBOT
limber skiff
#

why the heck does regex engine start at the lookbehind

#

why not do the match and then check the look behind ๐Ÿ˜ญ

quaint sapphire
#

You can always make your own regex engine and realize how fucking hard it is to make it efficient and in the way you want.

limber skiff
#

thanks for the useless comment

woeful sable
#

why ur being passive aggressive for no reason

quaint sapphire
#

I wasn't

#

(for no reason)

limber skiff
#

ohhhhhhh

#

I found my issue

#

it does it if you use it correctly (I wasn't)

quaint sapphire
#

Coping is the only true answer when regex doesn't work due to engine limitations

limber skiff
#

I love

quaint sapphire
#

Now make ur own engine optimized for your specific regex to bring that time down to 0.1 ms

woeful sable
#

what

quaint sapphire
#

You love

#

No joke tho, making a regex engine is a nice learning experience

#

Full with mental and physical pain

limber skiff
#

just rewrote all shc patches for better performance ๐Ÿ˜Š

charred monolithBOT
charred monolithBOT
charred monolithBOT
#

Discord Account

Or#4429

What happens when the bug or crash occurs?

Logs that the message logger has saved are not showing up.

What is the expected behaviour?

for the logs to show up after a restart

How do you recreate this bug or crash?

1.Message someone and delete the messages
2. Force quit discord (restart your pc or alt f4)
3. Go back to that dm

Note: the bug happens some time and not always

Errors

None

Request Agreement

  • [X] I am using Discord St...
quick ibex
#

@umbral hedge can you close #573 as won't be resolved?

umbral hedge
#

indeed

#

apparently ven removed my repo perms

#

so no

#

I can't

quick ibex
#

Tf

#

What why

umbral hedge
#

ยฏ_(ใƒ„)_/ยฏ

quick ibex
#

Whatever

umbral hedge
#

rip me

#

still admin in the org

#

bit random

quick ibex
#

Mfw org isn't owned by ven iirc

umbral hedge
#

bit of an owie moment tho

quick ibex
#

Hih

#

No clie

#

My u key not working on mobile tf

umbral hedge
#

well i suck anyways so shiggy

umbral hedge
quick ibex
charred monolithBOT
austere talon
austere talon
# umbral hedge apparently ven removed my repo perms

I removed it when you merged a pr I specifically said should be included in a different commit

and like you really only ever used it to make a pr then immediately merge it so it was kind of pointless anyway

umbral hedge
#

removed for merging a docs change shiggy so epic

also what you said at the time didn't really make any sense since it was a commit. you meant a different PR.

somber ginkgo
#

bye megu

charred monolithBOT
charred monolithBOT
#

Discord Account

pointy#0001

What is it that you'd like to see?

Hey there,

I think the Experiments tab would benefit from the following additions to the plugin:

  • Filtering for (non-)overridden experiments and experiments that you are(n't) part of the population for, similar to the filtering used in the plugins tab
  • Ability to see what treatment bucket is currently being used, even if not overridden (possibly as a replacement for the "Select" placeholder text in the override d...
austere talon
charred monolithBOT
charred monolithBOT
crude hearth
#

actually

#

or whatever

charred monolithBOT
austere talon
#

btw I invited you too @limber skiff

limber skiff
#

omg

charred monolithBOT
jagged cloak
#

balls gaming

tidal cloud
#

cookies

turbid hatch
#

๐Ÿ˜ญ

austere talon
#

wha

turbid hatch
#

oh i meant that in response to tasky

#

i want cookies now

#

wait i can get them from greggs

#

score

tidal cloud
#

I'll make you some cookies

turbid hatch
#

oh yes

#

i feel like im saying cloud integrations too much

#

i could change the second one to "if you have not yet set them up"

#

which will be semantically the same but with less repetition

#

does that sound good?

jagged cloak
#

Vencord powered by ai

charred monolithBOT
somber ginkgo
#

i cant wait to get made fun of

austere talon
#

why

#

it's fine there's just some things missing

charred monolithBOT
austere talon
#

that extension won't work on Firefox because it's not signed, it's a zip not a crx which chrome might dislike, you include the update url unconditionally which might break submission to stores

#

but most importantly the extension won't be updated unless version is bumped

#

which will be in sync with chrome and Firefox store updates

somber ginkgo
#

and i have no experience with this build process so i would appreciate some help pspDespair

charred monolithBOT
austere talon
#

lol no need to accuse people of lying

#

that person probably just assumed it would store permanently

#

because the BD one does

quick ibex
#

yea

#

@austere talon can you run that thing to check the patches??

#

Discord crashes when I join vc

#

Can't figure out source of problem

#

nvm

#

all i had to fucking do was restart my pc

austere talon
#

if a patch breaks it won't crash

#

it'll just crash when a patch still applies but smth goes wrong

charred monolithBOT
#

I used to use BetterDiscord, but due to recent bugs, I switched to vancord While Vancord feels better than BetterDiscord, the plugin I used in BetterDiscord called "readAllNotifications" does have the same funtionalities on vancord. Although I found a similar plugin in Vancord, it doesn't have the option to blacklist a server, meaning that notifications are read from all the servers but i'd like to bring that feature where u are able to black list a server and it wouldn't read the notificatio...

quick ibex
#

Idk

#

But I guess it's fixed

turbid hatch
#

vancord

austere talon
#

Vancord

#

that man gotta breathe for a second

#

loong sentence with no periods blbctscrd

charred monolithBOT
charred monolithBOT
austere talon
#

please do not use DevilBro plugins as inspiration blbctscrd

crude hearth
#

devilbro inspired me to become programmer

#

DevilBro is my light

somber ginkgo
#

when are we getting a memory leak plugin for people with betterdiscord withdrawal

limber skiff
#

you can use his plugins as inspiration

#

just dont use any of its code

quick ibex
#

but it didnt get merged

#

dunno why ...

austere talon
#

true

#

Best plugin rejected

somber ginkgo
#

@austere talon feel free to reject 578, unless you have future plans for it

#

because i am extremely Clueless

cunning bobcat
#

oh yeah I'm clueless about svgs & shit for keywordAlerts, so if anyone has any pointers or even a good built in svg i would appreciate a comment on the pr

austere talon
#

pretty sure we could just make a second extension listing for nightlies

#

@umbral hedge im confused, why did you always pr into merge instead of just directly pushing

#

the require pr is off so technically you should have been able to just push? MahiroThink

#

(and I can push fine without pr)

somber ginkgo
cunning bobcat
#

I'm asking my past self the same question

somber ginkgo
#

this would make me hpapy

#

hpapy

#

yep

umbral hedge
#

it has a "must pass tests" requirement

#

so only owners can bypass that

austere talon
#

isn't that only for pr

#

github be a little silly me thinks

umbral hedge
#

no

#

i cant commit to main at all

austere talon
#

that's really strange

#

github bad

limber skiff
#

github dumb

#

failed the workflow

#

oh

#

I can re-run it

austere talon
#

500?

#

amazing

limber skiff
austere talon
#

happens so much

#

idk what they cooking

#

wait

#

we could make the workflow restart itself if it's a 500 maybe

#

might be related

frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors

#
Bad Patches

None

Bad Starts

None

Discord Errors

charred monolithBOT
turbid hatch
charred monolithBOT
#

we need to change select component into the one that supports typing with autocomplete.

now possible due to #518, shouldn't be too difficult to convert.

We also need to make it fetch timezone strings from somewhere instead of hardcoding json

Intl.supportedValuesOf('timeZone'); for electron 17, but until stable reaches that version I have a copy of what it returns [hosted on a gist](https://gist.githubusercontent.com/lewisakura/529bb0236f375ab0b5890de02a8c007a/raw/ff5930de4d8b6a...

austere talon
#

nookies addicted to refactors

crude hearth
#

@austere talon Type '{ placeholder: string; options: { label: "EST" | "Etc/GMT" | "Etc/GMT+1" | "Etc/GMT+10" | "Etc/GMT+11" | "Etc/GMT+12" | "Etc/GMT+2" | "Etc/GMT+3" | "Etc/GMT+4" | "Etc/GMT+5" | "Etc/GMT+6" | ... 367 more ... | "Pacific/Wallis"; value: "EST" | ... 377 more ... | "Pacific/Wallis"; }[]; isSelected: (tz: any) => boolean;...' is not assignable to type 'IntrinsicAttributes & { placeholder?: string | undefined; options: readonly SelectOption[]; value?: SelectOption | undefined; look?: 0 | 1 | undefined; ... 23 more ...; "aria-labelledby"?: boolean | undefined; } & { ...; }'.

limber skiff
turbid hatch
#

some have different names or dont exist at all

crude hearth
turbid hatch
#

yeah that sounds about right

#

they changed the names of props for implementing the new select component

#

which i assume you're using now

crude hearth
#

now the thing is

#

I do not wanna fetch timezones all the time

#

like I should cache

austere talon
#

didn't we already go over this just don't provide timezone autocomplete on old electron trolley

turbid hatch
crude hearth
#

guhhhh 95% of users are in old electron

turbid hatch
#

you could cache the array in indexeddb if you really wanted

crude hearth
#

explosion

#

even I am in old electron

austere talon
#

explain use case for timezone picker

turbid hatch
#

here we go again

austere talon
#

when would I need to pick a timezone ever with the plugin

crude hearth
#

example: other person you know doesnt use tzdb

austere talon
#

why wouldn't those other people just use the plugin

crude hearth
#

but you know what his timezone is

austere talon
#

and register

crude hearth
#

YOU CAN CHOOSE

#

VERY GOOD

austere talon
#

wha

crude hearth
#

but autocomplete select works good

#

I just need to fetch timezones when bencord opens and cache them

#

@austere talon @tame escarp write code for m

turbid hatch
#

i gave you an implementation already

crude hearth
#

fetch is easy part

austere talon
crude hearth
#

actually

turbid hatch
#

its like

crude hearth
#

you know what

turbid hatch
#

two lines of code

crude hearth
#

it will fetch everytime vencord is open

turbid hatch
#

no

crude hearth
#

yes

tame escarp
turbid hatch
#

no thats dumb

#

we have a whole datastore api for you to use

#

to cache

crude hearth
#

idk how 2 use datastore or indexeddb

#

teach

turbid hatch
#

start at line 57

quaint sapphire
#

Manti is so lazy

tame escarp
#

when are we making rust wasm bindings to the vencord api tbh

austere talon
#

I still feel like you're working on a non existent use case

like you can just get the current users current timezone and give it to them if needed, but that should just automatically be handled by the plugin. You wouldn't need to pick timezone for other users cause they just use the plugin (or if they don't use it they would know their timezone, or if they don't then the picker wouldn't help you much)

turbid hatch
#

you dont need to worry about indexeddb, datastore api abstracts it away for you

austere talon
#

like im just trying to understand the use case, it doesn't seem real to me

turbid hatch
#

the tsdocs that are there should be able to help you understand how to use it

turbid hatch
#

'no'

solemn spoke
#

sorry went too late

crude hearth
#

not all people wanna go to timezonedb website and register

solemn spoke
#

whats going up

quaint sapphire
#

The problem is that manti is too lazy

austere talon
crude hearth
#

I wouldnt wanna ask anyone to register into t imezonedb

quaint sapphire
solemn spoke
austere talon
turbid hatch
#

if i was given a nudge saying "hey! go to timezonedb to register yourself" i would probably do it

austere talon
quaint sapphire
#

I know a lot of people that don't give a shit about stuff like this

crude hearth
#

for them it makes it easier

#

for people who dont you can enter manually

austere talon
#

you're saying you don't want to ask people to use the api though

tame escarp
unborn garnet
#

when chat bar icon api

turbid hatch
#

this feels like you're creating a problem by not wanting to implement a solution

solemn spoke
crude hearth
#

I know very lazy people

austere talon
solemn spoke
#

honestly

turbid hatch
#

i cant believe a fucking timezones plugin has had the most development drama on this project

quaint sapphire
#

Why should I ask someone else to register to smth that will only be useful for me?

What will that other person gain?
That other person might not wanna make their timezone public as well

crude hearth
unborn garnet
austere talon
#

lie

crude hearth
#

you live in germany

crude hearth
#

gmt +1

turbid hatch
#

okay

#

you know what

#

fuck it

#

just let people input a fucking offset

#

there

#

no need to faff with timezones

crude hearth
austere talon
#

husk no

crude hearth
#

IT WILL SHIT ITSELF

turbid hatch
#

THEN YOU CAN CRY!

solemn spoke
# solemn spoke honestly

i tried to implement my own time db into the first timezone plugin done. it was a horrible implementation since i would need to check if the user is registered on timezonedb and if not check on the local db

turbid hatch
#

DECIDE HOW YOU WANT TO RESOLVE THIS!!!

quaint sapphire
#

Why are you even having this convo?

crude hearth
solemn spoke
quaint sapphire
crude hearth
#

TIMEZONE STRINGS

#

ONLY WAY

solemn spoke
#

okay whats the solution

#

whats going on

#

whats the issue

crude hearth
#

I dont know

quaint sapphire
solemn spoke
#

dont care

#

whats the issue

quaint sapphire
#

There is no issue

crude hearth
quaint sapphire
#

Manti is just lazy

crude hearth
#

I AM NOT

#

maybe a little bit

#

I was literally gonna fix now

quaint sapphire
austere talon
crude hearth
solemn spoke
austere talon
#

I think if you really think it will be a common use case to add other people's timezones, then you should just make a website people can open and it tells them their timezone

turbid hatch
#

okay, lets see the options:

  • ship a fetch request to a list (with cache or it probably won't ever get an approval)
    • making sure you have the native method in so the fetch isnt used if its not needed
  • make everyone sign up to timezonedb
  • make everyone go somewhere else so the list isnt necessary
  • offsets

these seem like the most plausible solutions, if anyone has anything else do let me know

quaint sapphire
#

Ok manti, can you shut the fuck up?

I'll keep updating the plugin ffs, you won't do shit

austere talon
#

what's that timezone standard called again

crude hearth
#

utc?

quaint sapphire
#

Etc?

turbid hatch
#

it's just called tz database name

#

if you mean the timezone strings

crude hearth
#

@quaint sapphire you see

#

I am working

solemn spoke
quaint sapphire
turbid hatch
#

why would you need the local list and* the website

crude hearth
quaint sapphire
solemn spoke
#

that's ehy

quaint sapphire
#

If electron is old then we fetch

crude hearth
austere talon
#

this is way more robust than making people ask idiots what their timezone is

turbid hatch
#

if you're really going that method then you need to implement the native method as priority

quaint sapphire
austere talon
#

literally just make super simple site whatismytimezone.mantika.dev that shows timezone and copy button

crude hearth
#

how would that website work

#

even

turbid hatch
#

wait

austere talon
crude hearth
#

oh

#

it will tell you your own timezone

austere talon
#

all im saying is that adding hardcoded auto complete is stupid

quaint sapphire
austere talon
#

because it will be incomplete or have options your client doesn't actually support

turbid hatch
crude hearth
#

thats why it exists

solemn spoke
turbid hatch
#

i think that works in stable btw

crude hearth
#

if city is not in the list

quaint sapphire
#

This plugin should not expect or assume that any other person in the world is willing to give you the timezone string as is

crude hearth
#

theres nothing we can do

turbid hatch
austere talon
#

Auto complete is bad if you hardcode it because incomplete or invalid options and it's not user friendly because noone will know their timezone properly or if they do you won't need autocomplete cause you just copy paste it in

simple solution is to only have auto complete if you have actual Intl data and make the simple what is my timezone website like I said that lets anyone get their timezone easily

turbid hatch
#

so the website isnt necessary

solemn spoke
quaint sapphire
solemn spoke
#

yeah ig random ass website with complicated idea is the best

turbid hatch
#

or

#

just

#

not have the website at all

austere talon
#

the idea is that other people can give you their timezone

turbid hatch
#

just make a /command or something

austere talon
#

like your normie friend who doesn't use mods

quaint sapphire
#

That ain't the idea tho

crude hearth
#

hmm

#

then cant we use timezonedb s website

quaint sapphire
#

Both me and manti did not envision that

austere talon
#

but your normie friend who doesn't use mods will not be able to give you a proper timezone because they're stupid so it's easiest to send them a link they click and immediately get the correct timezone

crude hearth
#

doesnt it get timezone of users automaticly

turbid hatch
#

oh thats true

#

fair enough

crude hearth
#

rusher will add nonlogin option to timezonedb website

turbid hatch
#

link makes sense

crude hearth
#

we use it

quaint sapphire
austere talon
turbid hatch
#

although having it in client is better too

crude hearth
#

@fiery jungle RUSHERRRRRR

austere talon
#

not everyone lives in the capital city

solemn spoke
#

fetch random ass api to find the nearby cities near you lnfao

austere talon
#

if you ever ask a human for their timezone you're doing it wrong

#

make a website that tells you your timezone like I said or something similar

quaint sapphire
solemn spoke
#

i mean, making them to open a website is also weird

crude hearth
#

timezonedb plugin will get other persons ip adress and get timezone string from that

quaint sapphire
#

I doubt people want to dox their location

austere talon
#

oh my god this discussion is stupid just implement whatever and if its shit we change it and if its good we keep it

#

I think what I suggested is a decent idea

crude hearth
#

yes rusher does most of the work

solemn spoke
#

tho very complicated

crude hearth
#

sounds good to me

quaint sapphire
#

Why are you suggesting stuff when manti has not fixed the original issues?

austere talon
#

but if you have a better idea (that isn't hardcoding a timezone list and making stupid users figure out timezones) then go for it

crude hearth
#

also even tho we are probably gonna use website to get timezones

#

I think it would be better to keep autocompleteselect

#

because copy paste would work on that

#

also

quaint sapphire
crude hearth
quaint sapphire
solemn spoke
#

wait, is that a general IANA rule or smth?

turbid hatch
#

that's the offsets thing we talked about that's a bad idea

#

for DST

quaint sapphire
#

Who cares about summer?

turbid hatch
#

also, its not really overengineered

solemn spoke
#

if you put the IANA timezone as UTC+3 for example, it is valid

turbid hatch
#

it's a single line of js

solemn spoke
#

o

#

that

crude hearth
#

I am started to think ven is right

#

we should just force other users to authorize

solemn spoke
# turbid hatch https://gh.lewisakura.moe/timezone/

i thought the website would literally send back the timezone back to the one that sent the link. as like:
*user opens website that his friend gave*
*website sends the tz to the friend*
*the plugin would add to the list*

turbid hatch
#

jesus no

#

that's overcomplicated as shit

austere talon
# turbid hatch https://discord.coffee/ABXdTfR.png yeah it does

it's this simple to get the users current timezone. Literally slap this on a site and tell anyone whose timezone you need to go there, super simple and they don't need to use brain

<h1>Timezone</h1>
<p id="balls"></p>
<button onclick="copyTz()">Copy Timezone</button>

<script>
const tz = Intl.DateTimeFormat().resolvedOptions().timeZone;
balls.textContent = "Your timezone is " + tz;

function copyTz() {
    navigator.clipboard.writeText(tz);
}
</script>
#

oh lewi was faster based

quaint sapphire
turbid hatch
#

:P

#

i can add the copy thing though

#

not a bad idea

austere talon
#

it be working

turbid hatch
#

yis

quaint sapphire
#

Maybe the plugin could send a DM with the timezone?

turbid hatch
#

ill make it look pretty now

solemn spoke
#

okay the solution: literally don't solve it and make the user to manually add it, assuming the friend knows their IANA timezone, but if they don't, then the plugin would suggest a website where their friends could check which IANA tz they use

turbid hatch
#

cause im quite fond of it

austere talon
#

lewi doesn't know that any dom element with an id automatically becomes a js variable

turbid hatch
#

why does the plugin need to send a dm

austere talon
turbid hatch
#

oh shit

#

so it does

solemn spoke
austere talon
#

<p id="lol"></p>

<script>
   lol.textContent = "lol. lmao even"
</script>```
#

so silly

turbid hatch
#

i dont like it though xd

#

i prefer getElementById

austere talon
quaint sapphire
#

I've been programming in JavaScript for years now, I know a lot of things about JavaScript, but I never expected that nodes with IDs have auto variables

austere talon
#

ye it's more explicit and more typescript compatible

solemn spoke
austere talon
#

but I like abusing obscure behaviour

crude hearth
#

this is getting insane

austere talon
#

??

turbid hatch
#

what

#

the flow is so simple

quaint sapphire
austere talon
#

you think asking a clueless person for their iana compliant timezone is less of a bother than making them click a website

turbid hatch
#

Hi Ven!

#

What's your tz database timezone name?

austere talon
solemn spoke
turbid hatch
#

if you're asking someone for a timezone

#

you're probably already on a decent enough level with them

austere talon
#

the dom spec says only one element may have the same id so technically any browser may choose to optimise for that case and for instance make query selector all for id only return the first match (but I don't think any browser does that, they all work fine with duplicate ids)

quaint sapphire
turbid hatch
#

and either way the timezone is still quite generic, london is very far from where i live

solemn spoke
austere talon
turbid hatch
crude hearth
#

ok so I got another idea

solemn spoke
#

go ahead

quaint sapphire
#

Also it is weird that GMT+2 is Etc/GMT-2

like, what weed was iana smoking?

crude hearth
# crude hearth ok so I got another idea

so instead of forcing user to enter a website we ask them whats the time for them, then when they send timezone we will add their timezone via slash command which will figure out the utc timezone itself

#

but the problem with this is winter time

#

again

austere talon
#

not possible

crude hearth
turbid hatch
#

you are dealing with time

crude hearth
#

like I asked you, you answered 2:42

austere talon
#

just make Website there is no better user friendlier way

crude hearth
turbid hatch
#

right i can make this website attractive as fuck

turbid hatch
quaint sapphire
#

I'd like a clock and you pick the time of the other person and it shows possible timezones to pick from that are currently at that time

austere talon
turbid hatch
#

you're now back to the issue we had before that you complained about

austere talon
crude hearth
#

you only know offset

solemn spoke
#

i mean

#

cant we just

#

ignore the issue

#

like

turbid hatch
#

just give them the god damn website and ask them

austere talon
#

yall rn are like "I don't like this super simple solution you already implemented, here's [overcomplicated less user friendly solution]"

just stop and use the website lewi made, maybe put it on timezonedb domain

quaint sapphire
austere talon
#

you could also wait for them to send a screenshot that contains their time then guess it based on that

#

now you don't even need to ask them!!

tame escarp
#

why dont yall just not make the plugin because this argument has been going on forever

crude hearth
#

okay so I am thinking

austere talon
#

wonderful idea (not), just use the website german

crude hearth
#

if we are gonna go with website way, we should add a slash command that will send website link, and instructions about what to do

solemn spoke
# solemn spoke like

cant we literally just not deal with it and just give a warning that it is better to use a IANA timezone offset if they use a UTC offset?

crude hearth
turbid hatch
quaint sapphire
#

Or even an hour:minute offset from the local time

austere talon
#

oh my god you all need to shut up now this is going nowhere

you already have a finished solution thanks to lewi, either use that or implement your own better solution but shush now

solemn spoke
#

i had an idea

#

a good one

austere talon
#

it'll show up in any build as long as you have source maps enabled

spark cove
#

how would you enable sourcemaps in a prod build as a user

austere talon
#

I don't understand that question

#

source maps are part of the release and downloaded by the installer & updater

#

enable source maps in devtools and they'll work

spark cove
#

makes sense then

austere talon
#

all the files in releases are used

spark cove
#

no way ur downloading the extension/userscript in a desktop installation

austere talon
#

Well ig browser and userscript LEGAL.txt are essentially useless

#

but I kept them there for blah blah legal reasons

spark cove
#

yea i figured that wasnt true

#

i realize u meant that they're used somewhere and u can pretty much deduce where they're used

austere talon
#

desktop downloads renderer, preload and patcher js, js.map and LEGAL.txt, browser.js and css are used exclusively by armcord afaik but technically anyone can use them they just need to be ran in the renderer

#

user.js is well the userscript

spark cove
#

yop

austere talon
austere talon
#

I meant all of them are used in some way or another

spark cove
#

xdxdxd my brain is fake

#

words ๐Ÿ™…โ€โ™€๏ธ

fiery jungle
crude hearth
fiery jungle
#

no

crude hearth
#

you will regret

fiery jungle
#

yeah

quaint sapphire
#

No offense to manti

maiden fog
#

might be horror for privacy guh

cunning bobcat
#

hi manti

#

wait you're not manti

#

fucking hell

rare shale
#

im your husband

cunning bobcat
#

lies

rare shale
#

we had hot gay sex

cunning bobcat
#

False

charred monolithBOT
woeful sable
charred monolithBOT
crude hearth
#

Guys civilization

#

Be civil

#

Dont go to bottom of human evolution tree

cunning bobcat
#

this message is offensive to any manti in the area

crude hearth
#

@austere talon I will ask you one question

#

now you are aganist autocomplete and say people should just copy paste timezones

#

but in your situation if people use the web browser which has (maybe) newer version and gives some different string

#

how would discord client on old version work

turbid hatch
#

@crude hearth it uses the system timezones

#

they're not version specific

crude hearth
#

I thought they were hardcoded

turbid hatch
#

nop

#

it pulls the available timezones from your OS' tzdb

#

so its the same regardless of version

#

also i saw your Etc/ request, those arent part of the tzdb

#

hence why they werent in the original gist

#

i could add them but mileage may vary

crude hearth
crude hearth
#

people will use this for local timezones

#

also ven is aganist getting hardcoded timezones

turbid hatch
#

shrug

crude hearth
#

horror

charred monolithBOT
crude hearth
#

moment also has method to get all timezones

#

but it requires moment-timezones lib trolldayruined

#

I dont think discord has

#

oh god this is making me insane

#

we hate Intl for not having this option in old chromium

#

because I wanna add autocomplete I thought maybe it would make sense to get list of timezones from somewhere updated

#

BUT I DONT KNOW ANYMORE

charred monolithBOT
solemn spoke
charred monolithBOT
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors

#
Bad Patches

None

Bad Starts

None

Discord Errors

umbral hedge
#

Bad Apples
One

charred monolithBOT
austere talon
#

oh yeah you asked whether you can merge

#

I didn't look but if it's all good then yeah probably

#

what's staging banner

limber skiff
limber skiff
austere talon
#

why did you rewrite so many SHC patches

austere talon
austere talon
limber skiff
#

nothing. just visual

limber skiff
austere talon
#

I feel like this is a feature less intelligent people will enable then ask for support with hiding the banner

austere talon
austere talon
limber skiff
#

lets say I have this regex

/(?<=function (?<func>\i){.{0,900}.MESSAGES.BLABLA.+?}});/

this regex would first match the lookbehind, so it would try to match every function \i and look for .MESSAGES.BLABLA, which is not good

#

now I made it like this

/.MESSAGES.BLABLA.+?}};(?<=function (?<func>\i).+?)/

It's gonna match .MESSAGES.BLABLA first, which is not common, and then lookbehind for the first function \i to get the name and save to a group

limber skiff
limber skiff
limber skiff
#

actually

#

I will make pronouns db not enable the experiment but still show the component

#

then I will merge

charred monolithBOT
charred monolithBOT
charred monolithBOT
turbid hatch
#

cause if its not a lot you've just made loads of patches massively unreadable for no reason xd

#

also you seem to have a misunderstanding of how those operators work so i hope you didnt merge it

limber skiff
#

how so

turbid hatch
#

well every example ive seen has shown the lookbehind come before

#

never after

#

and i can't get it to work in regex101

#

so i have no idea what your patches are matching

#

your own example doesnt compile either ๐Ÿฅด

#

im just trying to understand how this actually is meant to work and if its speeding up anything or if its just making the regexes harder to maintain, or if its even working at all

#

but the more i look into it and the more i test, the more confused i get

charred monolithBOT
limber skiff
turbid hatch
#

yes

#

i tried going through your explanation and even tried one of your patches in regex101 but it didnt match anything lol

limber skiff
#

select the ecma script flavor

turbid hatch
#

i did

#

eh whatever

#

if it works it works i guess

sour drum
cunning bobcat
#

wtf is a look behind

sour drum
sour drum
charred monolithBOT
#

Discord Account

No response

What happens when the bug or crash occurs?

keybinds not supported
no window control buttons
every other browser thing

What is the expected behaviour?

normal discord windows client behaviour

How do you recreate this bug or crash?

patch discord version 5341902 with installer 253183a
open discord

Errors

VM75 renderer_init.js:93 Unable to load preload script: C:\Users\mattis\AppData\Roaming\Vencord\dist\preload.js
(anonymous) @ V...
charred monolithBOT
cunning bobcat
#

YOOO A ONESHOT PLAYER

charred monolithBOT
austere talon
charred monolithBOT
cunning bobcat
#

mfw github weebhooks bad

turbid hatch
#

hm

#

thats still really confusing xd

charred monolithBOT
undone delta
#

Yay

charred monolithBOT
quick ibex
#

Image for any discordian lurkers

austere talon
#

how do u use that @limber skiff

limber skiff
#

click to toggle

#

send message

#

it resets to disabled

#

simple as that

austere talon
#

what

#

show

limber skiff
#

e

austere talon
#

ah

#

i got confused cause you also edited context menu api

#

so i thought it used context menu

#

and was confused

limber skiff
#

I fixed it lol

charred monolithBOT
limber skiff
#

jeez I completely forgot about startsWith

austere talon
#

lol

#

i thought for like 10 seconds "is there any specific reason they might have done slice instead of startsWith??"

#

i think startsWith might just do a slice (without creating a new string) and comparison

limber skiff
#

no lol I just forgot about it

#

I was like include wouldnt do what I want...

#

slice then.

austere talon
#

how did that even happen

#

do u always copy paste the boilerplate from some other plugin or template or

limber skiff
#

what happened

austere talon
#

2022

limber skiff
#

yeah

#

wait no

#

nvm I did

#

I copied from silent typing

#

lol

charred monolithBOT
limber skiff
#

It is needed

#

enabled doesnt update without it

#

idk kinda strange but it worked with it lol

charred monolithBOT
turbid hatch
#

wouldnt it be more reliable to set the flags on the message rather than appending <@&1073655264923881602> to the content? or is it fine in this case

limber skiff
#

can't

charred monolithBOT
limber skiff
#

it's too early lol

turbid hatch
#

mkay

austere talon
limber skiff
#

eh

#

I think it's fine using useState there for now

#

we do it like that everywhere else

austere talon
#
function useBoolean(initialValue: boolean) {
  return React.useReducer(x => !x, initialValue);
}

// usage
const [value, toggle] = useBoolean(false);
<Switch value={value} onChange={toggle} />
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors

#
Bad Patches

None

Bad Starts

None

Discord Errors

limber skiff
#

yop

austere talon
#

wtf is SettingsStore

limber skiff
#

I didn't know how to call it lol

austere talon
#

i feel like that should be a webpack method instead

limber skiff
#

it requires patches to work with it

#

discord has basically this

#

each is an object which contains functions to manipulate that setting

#

get its value, update it, etc

#

to find it I need to patch to add additional information to the object

#

else they are all the same

#

should I update these

austere talon
#

no

#

updating years in license headers is meaningless and ruins git history and is also misleading if you don't change anything else

#

but new files should use 2023

woeful sable
#

we will remove years from license headers

austere talon
#

years are fine if they just correspond to the year the file was created

charred monolithBOT
#

Discord Account

OhHim!#0777

What happens when the bug or crash occurs?

The bug in question is when vencord is enabled discord loses its ability to snap to sides of the screen or be used by fancy zones.

https://user-images.githubusercontent.com/42637159/223917723-650e2cf6-79a6-4b1d-8091-f4dcf346e270.mp4

https://user-images.githubusercontent.com/42637159/223918150-417605a6-9ad1-4487-b1fb-695b56c7b729.mp4

What is the expected behaviour?

The expected behavior is that ...

charred monolithBOT
quick ibex
#

You love 33 open prs

austere talon
#

ye

#

like half of them aren't even done / mergable

#

the other half I already reviewed mostly, gotta check again whether feedback was addressed

#

btw on the topic of feedback if I left some on ur pr and you fixed everything feel free to ping me for rereview

#

cause its not easy to keep track

quick ibex
#

Can you review my pr? Or is it too messy

turbid hatch
#

ill review it

#
await fetch(`https://en.wikipedia.org/w/api.php?action=query&format=json&prop=info%7Cdescription%7Cimages%7Cimageinfo%7Cpageimages&list=&meta=&indexpageids=1&pageids=${firstres.pageid}&formatversion=2&origin=*`)
    .then(data => data.json())
    .then(data => alt_data = data.query.pages[0] || null);
#

thank you dedent

charred monolithBOT
quick ibex
#

@turbid hatch thank you, been a while since I coded so I forgor any and all kind of error handling

turbid hatch
#

^^

quick ibex
#

@turbid hatch I did the yoinky sploinky and resolved convos

#

๐Ÿ˜‡

charred monolithBOT
quick ibex
#

and also did some cleaning up

charred monolithBOT
austere talon
#

cause they used a workaround

grave mangoBOT
limber skiff
#

oh

#

that's what the div was for

#

I somehow completely ignored that comment

charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors

#
Bad Patches

None

Bad Starts

None

Discord Errors

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
lime stone
#

huhh

#

hi

#

๐Ÿ‘‹

#

i see

verbal pumice
#

:ablobwave:

lime stone
#

arhghh

charred monolithBOT
solemn spoke
#

:blobcatcozy:

#

okay discord wtf is happening

#

:husk:

#

what???

charred monolithBOT
charred monolithBOT
charred monolithBOT