having a life doesn't prevent you from checking a PR for 25 mins a day
#👾-core-development
quaint sapphire
woeful sable
y'all are so mean it's literally holidays
umbral hedge
yop
jagged cloak
me when my completely unneeded addition isn't looked at and merged in 2 picoseconds!
🤯
long heart
woeful sable
ven will give me write access so i can deny PRs
austere talon
soon
robust basin
i will soon take over ven's vessel
charred monolithBOT
austere talon
ayo
solemn spoke
WOOOOOO
quick ibex
ayo
Did I ever tell you what the definition of insanity is? Insanity is doing the exact... same fucking thing... over and over again expecting... shit to change... That. Is. Crazy. The first time somebody told me that, I dunno, I thought they were bullshitting me, so, boom...I shot him! The thing is... He was right. And then I started seeing, everywhere I looked, everywhere I looked all these fucking pricks, everywhere I looked, doing the exact same fucking thing... over and over and over and over again thinking, 'This time is gonna be different, no, no, no please... This time is gonna be different'.
solemn spoke
:p you could have told me and i would fix it
austere talon
there's so much still inline
solemn spoke
hm
but well, you could have told me which parts i forgot and i would do it
unless you was pressured to merge, in that case my problem is with lack of activity, so yea, i would be still happy to fix anything more
solemn spoke
i forgor
solemn spoke
there's many places
i mean, you could still say in the pr that there were more places
like, what made you to merge a PR that you knew there were points missing
austere talon
cause it doesn't matter
solemn spoke
hah, interesting
and my second question, if you saw those missing parts, why didn't you told me before merging? i could have fixed instead of another person having to fix by me
austere talon
that's the same question as before
charred monolithBOT
woeful sable
guh
quaint sapphire
Did I ever tell you what the definition of insanity is? Insanity is doing the ex...
if your code sets the random seed as the unix time, rerunning it might change stuff
(well, if you also use random numbers, not just set the seed)
arctic granite
unborn garnet
what
spark cove
how does this group of people have customs that i dont
somber ginkgo
@austere talon hit button
long heart
githu
placid wave
make threwad on this
umbral hedge
maybe after a message is too old?
or depends on client?
umbral hedge
a.
austere talon
what
austere talon
discord moment
umbral hedge
h
charred monolithBOT
placid wave
@austere talon lol
austere talon
webhook insane
umbral hedge
ven insane
swift fjord
now move vencord repo to vencord org
spark cove
uh yea it works
umbral hedge
wtf
spark cove
100kb link is not real it doesnt exist
brave geyser
Insane
swift fjord
virus link ⚠️
charred monolithBOT
placid wave
husk what
elfin dew
charred monolithBOT
spark cove
<:husk:1026532993923293184>
i just wanted to see if it was possible
so i can put build analyzer links in releases
charred monolithBOT
azure jay
when will ven merge
unborn garnet
never
ive been waiting for like 3 weeks too
@austere talon VEN ITS BEEN 3 WEEKS
its not that complex of a plugin 
it doesnt take a month to test
charred monolithBOT
charred monolithBOT
unborn garnet
@umbral hedge you will be the merger
umbral hedge
unborn garnet
fathom herald
its not that complex of a plugin <:husk:859796756111294474>
wait uh is it not making a circular dependency
// components/DecryptionModal.tsx
import { decrypt } from "../index";
``````jsx
// components/EncryptionModal.tsx
import { encrypt } from "../index";
``````jsx
// index.tsx
import { buildDecModal } from "./components/DecryptionModal";
import { buildEncModal } from "./components/EncryptionModal";
wtf did they do
().foo is now just .foo
fixing should be easy af
Z().foo -> Z.foo
umbral hedge
tidal cloud
insane
charred monolithBOT
charred monolithBOT
woeful sable
u fixed it by simply not running the test at all for it
austere talon
yea
austere talon
🔥
charred monolithBOT
austere talon
^ why you should always make wildcards in regex lazy
- .+
+ .+?```.+ = match as much as possible, aka it will prefer matching 3000000 characters over matching 3 if possible
.+? = match as little as possible, after the first match it will stop searching
austere talon
anyway I will look at prs tmrw 
sorry for taking a bit I was busy over the holidays and then had no motivation to look at them
austere talon
figure it out
maybe css classes renamed
const getStatusColor = findByCodeLazy("STATUS_YELLOW", "TWITCH", "STATUS_GREY");
see if this is the right method
it should return css colours
if you pass in "online" it should return "var(--status-green)" or smth like that
scenic pendant
verbal pumice
u will pr fix
actually should i just go over every plugin to make them use \i and $self
umbral hedge
verbal pumice
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/plugins/messageLinkEmbeds.ts...
**messageLinkEmbeds.tsx: **Line 155
replace: "function $1($2){var $3=$2.message,$4=$2.channel$5().embedCard$6})}\
().embedCard
need to be removed
should be just that, shouldn't it?
@verbal pumice
austere talon
not on my pc rn or I'd do it
verbal pumice
yeah i'll open a pr to fix everything
verbal pumice
actually should i just go over every plugin to make them use `\i` and `$self`
and this
austere talon
no need imo
verbal pumice
ok then
charred monolithBOT
austere talon
ayo forged commit??
umbral hedge
lmfao
austere talon
did u even test ur plugin @unborn garnet
unborn garnet
What do you mean
unborn garnet
LOL
austere talon
(ill fix it no need to)
unborn garnet
Alright
austere talon
read to explode
unborn garnet
austere talon
works
unborn garnet
Ya, did test the plugin
unborn garnet
Just not that feature since it was very last minute
austere talon
fair
unborn garnet
Yop
umbral hedge
youre inserting the function's code into the input box lmao
LOL
unborn garnet
Message Indicator isn't supposed to have one
austere talon
unborn garnet
Oh
austere talon
i will make it be the same as the other buttons there
austere talon
testing the test
okay so
you just modify the content here right
i see that you push to an array
is it an array of html elements?
as in, can I push a span?
oh wait totally
what am I saying
i will add tooltip to that as well
austere talon
yop
unborn garnet
fear
austere talon
otherwise people will be confused
why they have weird locks
without the tooltip i mean
i also added some padding
so its not hugging the message content
charred monolithBOT
unborn garnet
ya
unborn garnet
charred monolithBOT
unborn garnet
ikr
brave geyser
Horror
austere talon
discord broke some part of ignore activities
fix
limber skiff
I am
solemn spoke
what a day. so much prs closed
charred monolithBOT
charred monolithBOT
woeful sable
ven loves windows users
charred monolithBOT
Allow you to view users, roles and channels permissions.
here are some screenshots from how the betterdiscord pluggin does it:
It has also been very well implemented with the showhiddenchannels plugin, here...
solemn spoke
but rly, why was that added? does this make discord to fully exit?
o yea it looks like. but still, why making this shortcut windows specific
tribal fjord
unless I'm stupid and missing something I did it on my fedora xd 
solemn spoke
what
umbral hedge
i just alt+f4 like I would in any other program
making it global was probably a mistake
but it should at least be toggleable
austere talon
o yea it looks like. but still, why making this shortcut windows specific
because discord has it on Mac and Linux out of the box
and many other apps have it on Windows
I didn't mean to make it work outside of windows
umbral hedge
I've never used CTRL+Q to close an app on windows xd
solemn spoke
me too
golden gulch
i would very much like to disable the shortcut on Linux i press it on accident way too often xd
austere talon
how
golden gulch
global keyboard shortcuts for my DE and hitting ctrl instead of win key
also I'm just bad at typing
austere talon
that's why I ported it
I didn't mean to make it work in other apps that's my bad
austere talon
unborn garnet
i cant believe he copied my plugin 😔
charred monolithBOT
azure jay
ok
frail skyBOT
austere talon
can u show a screenshot? @agile laurel
frail skyBOT
agile laurel
oh shit yeah i meant to run the changes by u first i am just out of it today
@austere talon
agile laurel
less flat
i made it have a darker background color and deeper backdrop shadow on hover
also made the settings cog lighter when you hover over it so it actually looks responsive
before it hardly changed
i think ui should be responsive to everything you do at least subtly
agile laurel
i have a lot more ideas for the ui but im struggling a lot with motivation atm so cba
glass cedar
i made it have a darker background color and deeper backdrop shadow on hover
The hover one doesn't look great imo
It might be better to have the same BG for both
agile laurel
It might be better to have the same BG for both
i just copied discords server cards
golden gulch
change in appearance on hover doesn't make much sense when there's no interactivity with what you're hovering over
if I hover over the card and it changes, I usually expect that to mean that I can click on it and something will happen - that's not the case with the plugin cards (unless you click on the title, which in turn toggles the plugin)
agile laurel
its less misleading than it is right now lol
theres a random cursor: pointer on the whole card selector in the css
for no reason
if yall do anything please change that lol
agile laurel
if I hover over the card and it changes, I usually expect that to mean that I ca...
but this is fair i can get behind this
golden gulch
yeah I was going to mention the cursor being wonky but it wasn't something you did so I didn't
umbral hedge
theres a random cursor: pointer on the whole card selector in the css
clicking the card was supposed to open the settings/info
someone changed it at some point and never changed the css
austere talon
yeah clicking any of the card used to open the card
idk why that was changed at some point, maybe an accident
charred monolithBOT
agile laurel
of course you could just make clicking the card toggle the plugin
thereby making all my changes valid 😎
umbral hedge
bad
woeful sable
bad change
austere talon
I agree tbh but there were many people requesting this and the BD plugin has it that way
but yeah option would be cool
woeful sable
I just realised inputType: ApplicationCommandInputType.BUILT_IN, is probably not what I want
austere talon
BUILT_IN = no automatic response, but u can still manually respond
BUILT_IN_TEXT = automatic response with what you return, if you return nothing it bugs out and sends your command as text. Meant to make this cancellable but it was such a pain I have up
avoid the rest
woeful sable
oh I thought it changed the input box and that's why it opens text input for boolean
austere talon
for boolean it should just make u type true or false I think
woeful sable
that should be documented I think cuz I couldn't tell at all
yeah that's what it's doing right now
slash commands so bad
I enabled invisible chat and I don't see the chat button mm
didn't fail to patch though
golden gulch
I just enabled invisible chat and reloaded and the button shows up
woeful sable
it got display: none'd by removing nitro ads css
golden gulch
frail skyBOT
frail skyBOT
woeful sable
JSHandle@error
umbral hedge
JSHandle@error
unborn garnet
JSHandle@error
unborn garnet
I just enabled invisible chat and reloaded and the button shows up
invisible
charred monolithBOT
jagged cloak
JSHandle@error
austere talon
you love
jagged cloak
ye
grave mangoBOT
<https://github.com/Vendicated/Vencord/blob/main/test/generateReport.ts#L44-L47>
**generateReport.ts: **Lines 44-47
function maybeGetError(handle: JSHandle) {
return (handle as JSHandle<Error>)?.getProperty("message")
.then(m => m.jsonValue());
}
prime jewel
404 because it never happened 
solemn spoke
🤯
charred monolithBOT
charred monolithBOT
frail skyBOT
frail skyBOT
woeful sable
It's jover
austere talon
It's jover
discord internal server errors be like
limber skiff
it has 3 patches what do you mean 😭
I changed it remember
grrrr I gotta make this patch better discord keeps breaking it
woeful sable
austere talon
oh, big
limber skiff
kek they just completely removed renderLastPlayed and renderOverlayToggle
austere talon
BRUH
lament wren
charred monolithBOT
frail skyBOT
frail skyBOT
woeful sable
can u commit this I won't get back home in hours
austere talon
IT IS TOGGLEABLE
rigid venture
man don't look at me like i'm gonna read the code
rigid venture
it's gonna get wicked
woeful sable
can u commit this I won't get back home in hours
mober data got real
umbral hedge
lol
charred monolithBOT
charred monolithBOT
charred monolithBOT
? why, this already exists in the client
The plugin is to hide spoilers by default, but then reveal all in a message or in the chat when needed (like when there's multiple spoilers).
austere talon
you will review
dapper tiger
@austere talon merge #400 and #401 NOW
austere talon
suggestion
dapper tiger
@austere talon MERGE
robust basin
how
limber skiff
how what
limber skiff
I'm talking about this
slate solar
Why not 4.26? 
azure jay
omg token logger hidden in vendicated/random-files
austere talon
Thought this was a keysmash for a second
you love stupit dev adding good first issue label instead of fixing it
lazy
charred monolithBOT
woeful sable
Add files via upload
umbral hedge
tokenlogger
austere talon
some considerations:
- the reason I named options options and not settings was because I wanted to keep the possibility open to later have this.settings refer to the actual settings object. I guess this is kind of obsolete now so it's okay to rename it though
- I don't like there being both options and settings now, we should try to migrate the old code to not be confusing and have less deprecated code
- the settings update filter path is flawed, what if your setting contains a period? that issue already existed before the pr but I realised that just now and we should probably fix it
austere talon
vapo is the anti jsdoc
umbral hedge
some considerations:
- the reason I named options options and not settings was b...
tbh yeah we could migrate everything
I thought that maybe we should do it in a different PR tho which is why I didn't mention it
spark cove
some considerations:
- the reason I named options options and not settings was b...
- this actually makes sense yea
- yea i agree thats why i added
@deprecatedso our ides would cross it out as a reminder - thats true we probably should fix that, i'll add a TODO
austere talon
TRUE
umbral hedge
the
austere talon
TODO comment is my favourite fix
spark cove
TODO:
austere talon
now you can TODO like a master
woeful sable
make eslint error on TODO comments
umbral hedge
i use this
woeful sable
@austere talon what were you thinking
umbral hedge
thinking about the letter j
spark cove
j
austere talon
what was I thinking indeed
idk why I added my name there
I think cause I said "I"
umbral hedge
I put my name in work code TODOs
spark cove
same
austere talon
gotta assert dominance and claim your territory
umbral hedge
yop
spark cove
TODO(vap): hi
fixme
// FIXME(vap): this code works fine, someone please fix me i needf hlep```you will add other name in todo comment and git blame-someone-else
umbral hedge
discord has more TODOs than files
austere talon
you will add other name in todo comment and git blame-someone-else
TRUE
umbral hedge
STAN
austere talon
adding other people's names in todos is probably the most passive aggressive thing you could do
umbral hedge
ven will replace all // TODO with // TODO(megu)
spark cove
todo: stan
spark cove
i will espionage
umbral hedge
// TODO: Add token lagger
woeful sable
dzshn:git/ % rg TODO | wc -l
917
west plinth
// TODO: Add token lagger
spark cove
added the TODO
west plinth
Add the ability to bypass the upload limit, by automatically partitioning the data and then automatically putting it back-together on the other client as 1 file to download sorta. Wouldn't be that useful, just a cool idea.
solemn spoke
discord has more TODOs than files
where did you got all of those comments?
umbral hedge
discord
solemn spoke
didn't that got removed after compilation?
austere talon
megu is discord employee
umbral hedge
yop
umbral hedge
discord is doing internships now
solemn spoke
discord is doing internships now
wait fr?
umbral hedge
is this one of those america moments
spark cove
probably
solemn spoke
that's kinda pog ig
modest venture
Discord pays $67/hr for the internship
it all comes from nitro money
austere talon
Discord pays $67/hr for the internship
wtf
austere talon
discord will add non US jobs immediately
spark cove
@umbral hedge are u in america
spark cove
thought so
woeful sable
austere talon
pog
so
since you reuse a lot of stuff from petpet
why not
- extract them to webpack commons
- add an upload function to utils/discord that wraps promptToUpload
@slate solar
would be cool
slate solar
why not
1) extract them to webpack commons
2) add an upload function to utils/di...
Hmm, good idea, you're smarter than me 
charred monolithBOT
woeful sable
yop
cunning bobcat
jfc why does my heartbeat quicken when i hover over "Create pull request"
charred monolithBOT
cunning bobcat
oh screw it im just gonna do it
charred monolithBOT
This pull request adds a plugin to add a custom rich presence.
Here's an example of a rich presence made by this plugin:
Please do let me know if anything is missing, broken, or if you just want something changed.
woeful sable
do
charred monolithBOT
woeful sable
1984
cunning bobcat
GODAMMIT I SAVED THE PAGE BECAUSE I THOUGHT YOU WERE GONNA DELETE IT
woeful sable
NOOO
woeful sable
GODAMMIT I SAVED THE PAGE BECAUSE I THOUGHT YOU WERE GONNA DELETE IT <:husk:1026...
bro fr 💀
cunning bobcat
which one is preferred?
umbral hedge
merge better for canonical commit history
austere talon
merge commit
umbral hedge
oh god please don't tell me commits have to be signed
no lol
austere talon
you dont have to sign but you really should
umbral hedge
you should, but don't have to
cunning bobcat
lemme add it onto my infinite TODO list
austere talon
give me one sec and i will tell you a compelling reason to sign your commits
cunning bobcat
ok
austere talon
theres no way to tell that it's not actually by you
if you used signing it would say Unverified
austere talon
committing in someone elses name is really simple
git --config user.email theiremail
git --config user.name theirname
cunning bobcat
i remember when I tried it once with a friend
it failed somehow
(proof i suck at github)
what the fuck is this suppsoed to be
austere talon
DONT
charred monolithBOT
Also an idea for this PR to get a more natural voice on Linux: Use Google Translate for TTS, like https://translate.google.com/translate_tts?ie=UTF-8&tl=en-US&client=tw-ob&q=joined general
charred monolithBOT
austere talon
THERE WE GO
real
spark cove
SHUT UP
austere talon
BE NICE
charred monolithBOT
spark cove
so bad
austere talon
??
charred monolithBOT
spark cove
??
Failed to load resource: the server responded with a status of 404 ()
Failed to load resource: the server responded with a status of 429 ()
Failed to load resource: the server responded with a status of 404 ()
austere talon
Failed to load resource: the server responded with a status of 404 ()
Failed to...
oh i thought so bad was in response to that comit
spark cove
xdxd'
umbral hedge
Failed to load resource: the server responded with a status of 404 ()
Failed to load resource: the server responded with a status of 429 ()
Failed to load resource: the server responded with a status of 404 ()
tribal fjord
what the fuck was the
fuckin flag
HUSk
i cant find it
The actual flag is --enable-speech-dispatcher.
i found
rare shale
bruh
charred monolithBOT
austere talon
it is exposed
hot pecan
it is exposed
oh, wow then that pr really is completely pointless
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/api/Commands/types.ts#L27-L3...
**types.ts: **Lines 27-39
export enum ApplicationCommandOptionType {
SUB_COMMAND = 1,
SUB_COMMAND_GROUP = 2,
STRING = 3,
INTEGER = 4,
BOOLEAN = 5,
USER = 6,
CHANNEL = 7,
ROLE = 8,
MENTIONABLE = 9,
NUMBER = 10,
ATTACHMENT = 11,
}
long name
hot pecan
nah its the same thing as in api docs
rare shale
hot pecan
i just knew that echo struggled with defining that type last time which inspired that pr
rare shale
i just knew that echo struggled with defining that type last time which inspired...
yup
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/api/Commands/types.ts#L41-L4...
**types.ts: **Lines 41-47
export enum ApplicationCommandInputType {
BUILT_IN = 0,
BUILT_IN_TEXT = 1,
BUILT_IN_INTEGRATION = 2,
BOT = 3,
PLACEHOLDER = 4,
}
why do some of their enums start with 0
while others start with 1
so infuriating
woeful sable
discord so sane
rare shale
why do some of their enums start with 0
new Date().getMonth() moment
austere talon
fun fact Javascript Date api is a copy of Javas Date api (https://twitter.com/BrendanEich/status/481939099138654209) which deprecated half its methods due to being terribly designed and was replaced by the Calendar api
Twitter
Java fixed their shitty date apis but in js world we're still stuck in stone age
woeful sable
I want to kill brendan
austere talon
he had to apparently
in his defense
he had 10 days to make js and was told to make it look like java
woeful sable
I want to kill brendan and whoever thought of making him do that
austere talon
can't wait https://github.com/tc39/proposal-temporal
hot pecan
Java fixed their shitty date apis but in js world we're still stuck in stone age
cant wait for tc39 to steal Instant, LocalDateTime, OffsetDateTime, ChronoUnit and all that as well
and i mean i cannot wait, like that would actually be dope, the modern java time apis are really nice
hot pecan
can't wait https://github.com/tc39/proposal-temporal
:(
woeful sable
good
hot pecan
i love leap seconds
woeful sable
they'll be gone soon
The year 2035 for eliminating leap seconds was chosen considering Russia's request to extend the timeline, since, unlike the United States's global navigation satellite system, GPS, which does not adjust its time with leap seconds, Russia's system, GLONASS, does adjust its time with leap seconds.
charred monolithBOT
cunning bobcat
clever
austere talon
what's a gui switcher
solemn spoke
what's a gui switcher
me not having a better name to doing smth like ./VencordInstaller --uninstall --path "path/to/asar"
austere talon
why would it do that
I can add a cli interface but are you really too lazy to click one button
umbral hedge
^
austere talon
and there's no way of knowing which install u wanna patch anyway
if u have multiple
umbral hedge
my only dislike of the installer was the envvar thing, but because the PR makes it add the envvar automatically, my complaints are resolved
I'm happy to click an install button
cunning bobcat
I cant wait for #407 to be merged. I had to go to hell and back to patch discord with a dev install
woeful sable
pnpm buildWeb
solemn spoke
I cant wait for #407 to be merged. I had to go to hell and back to patch discord...
why's that?
woeful sable
explode
umbral hedge
[Vendicated/Vencord] New star added
umbral hedge
woa
charred monolithBOT
umbral hedge
pog
woeful sable
real
umbral hedge
trolled
austere talon
L
umbral hedge
usage: link [options] main.o
charred monolithBOT
umbral hedge
TROLLED
verbal pumice
mac users do not exist
umbral hedge
linux users do not exist
woeful sable
windows users do not exist
umbral hedge
soon
verbal pumice
everyone uses templeos now
umbral hedge
windowd builds take ages apparently
umbral hedge
so true
umbral hedge
ah
umbral hedge
TROLLED
austere talon
thats the old one
umbral hedge
yeah i figured xd