oh, it aint even part of the standard library
#👾-core-development
quaint sapphire
hmm, nodejs has a crypto built-in lib
that could be used, but it is way overkill at this point
what about base64? we do have atob("...")
woeful sable
I guess ideally the installer should only use root perms when it needs to, but that's probably out of scope here
spark cove
good morning github
austere talon
I guess ideally the installer should only use root perms when it needs to, but t...
I want that but how do i integrate sudo/doas into the gui
password prompt and stuff
i think i could prompt the user for password but i don't really want to do that
woeful sable
probably requires messing with pam
austere talon
I'd rather use some framework like PAM
but not everyone will have that
not all systems have pam
woeful sable
ye I'm not sure if there's a portable and safe way to do it
austere talon
ye I'm not sure if there's a portable and safe way to do it
i think the only portable way is prompting the password from the user in ur app then making sudo read the password from stdin
but i dont think doas can read password from stdin
oh my god why do you do this doas
woeful sable
man doas
quaint sapphire
uh, what if you run it w/o args?
woeful sable
but ye i hate when clis do that
woeful sable
meanwhile gnu coreutils only support --help and not -h
austere talon
oh my god why do you do this doas
"no help for u read man or gtfo"
xd
well doas doesnt have a way to read password from stdin
umbral hedge
oh my god why do you do this doas
honestly i'd never even heard of doas until the other day lmao
sounds like a pain
austere talon
it is
umbral hedge
why do people use it
austere talon
so limited
austere talon
why do people use it
"security"
umbral hedge
austere talon
sudo is very bloated and had a bunch of bad cves in the past
woeful sable
sorry i ont have the mental capacity to use sudo
umbral hedge
as if such an important thing doesn't get scrutinised constantly by security researchers tho
rewrite sudo in rust 
blazing fast
austere talon
i tried using doas but
- it prompts for password every time (i know i can change it with config but why would i mess with its config if sudo does what i want ouf of the box)
- it has no support for environent variables:
doas VARIABLE=hi sh -c 'echo $VARIABLE' - just generally very limited
austere talon
i use 2 a bunch
austere talon
woeful sable
i tried using doas but
1) it prompts for password every time (i know i can chang...
permit persist :wheel in /etc/doas.conf
austere talon
from opendoas readme
austere talon
`permit persist :wheel` in `/etc/doas.conf`
!!
woeful sable
u also have to configure sudo to do that but you probably forgot
austere talon
funny config
i bet one of those NOPASSWD ones is somehow abusable to spawn a root shell
but idc
umbral hedge
xdd
woeful sable
security through obscurity is very real and safe didnt u know /s
maiden fog
funny config
reckless 😔
austere talon
how
all of those are there cause i automated them with scripts
so i cant really enter my password
wtf is ceserver i dont remember
woeful sable
it's my backdoor i forgot in your system mb
austere talon
LOL
umbral hedge
lmfao
maiden fog
how
oh you probably use those cmds a lot and entering password must be annoying each time and are generally safe
austere talon
all of those are there cause i automated them with scripts
.
austere talon
LOL
oh yeah i was using cheatengine to do cursed shit in plants vs zombies with wine
maiden fog
Bloons*
austere talon
oh yeah i was using cheatengine to do cursed shit in plants vs zombies with wine
tldr: getting cheat engine to work in wine is absolutely cursed
umbral hedge
I never actually use sudoedit
umbral hedge
owo
austere talon
it runs the editor as your own user instead of root
umbral hedge
sudo ven --hug
austere talon
it runs the editor as your own user instead of root
more secure and has the great benefit that it uses your own config of whatever editor youre using instead of the root user's config
umbral hedge
owo
woeful sable
nope i will su -c "echo 'key1=value1\nkey2=value2' > /etc/veryimportantconfig"
umbral hedge
husk
woeful sable
rm /root/.config -rf && ln -s /home/username/.config /root/.config
austere talon
NOOOOO
thats such a terrible idea for security lmao
might as well just run everything as root then xd
austere talon
more secure and has the great benefit that it uses your own config of whatever e...
but its also kinda annoying cause it doesnt allow editing files that are symlinks and doesnt alow editing files in non root owned directories
idk why
austere talon
explode
umbral hedge
explo
remote spindle
explod
woeful sable
might as well just run everything as root then xd
wayland wont let me
austere talon
basically you can create symlinks to anywhere so you could bypass sudoedit restrictions by symlinking arbitrary files to ur home director
makes a lot of sense :w
woeful sable
you're using vim commands in discord
umbral hedge
vim /home/megu/ven
austere talon
:: packages not in the AUR: catppuccin-gtk-theme
:: marked out of date: android-apktool citra-qt-canary-bin klogg-bin riseup-vpn spotify ttf-twemoji-color
:: orphans: xf86-input-joystick
umbral hedge
austere talon
whats more unsafe:
- symlinking your .config to /root/.config
- installing flutter
(its the latter)
umbral hedge
lmfao
austere talon
every time i install flutter i feel like im installing 3 viruses to my system
umbral hedge
im a virus
austere talon
so your pr in install script works for running as root on wayland ? @woeful sable
woeful sable
yea
austere talon
mm okay
i would much rather just not run as root and instead only escalate the actual commands
but shrug
umbral hedge
charred monolithBOT
umbral hedge
apfel
spark cove
who is the ajrx person
austere talon
who is the ajrx person
@quaint sapphire
spark cove
ah
quaint sapphire
spark cove
teal did u ever get this cleared up cus i can explain it to you
spark cove
yea
kinda
i think u misunderstand functional components
and what rerendering means with them
quaint sapphire
uhh, you might have misunderstood what i meant by using that word
spark cove
a rerender of a FC doesnt mean a new lifetime / instance
quaint sapphire
i meant that the component would be discarded and recreated if the text was to change
spark cove
that would be a remount
quaint sapphire
it wouldnt be updated
spark cove
thats not true
quaint sapphire
cause the text is not stateful
quaint sapphire
the tokens wont change if the source code is not stateful
spark cove
the tokens will change if the theme changes
quaint sapphire
thats an oversight from me ig
charred monolithBOT
spark cove
also im pretty sure that props are part of the components "state"
which is why fibers keep track of memoized props
not entirely certain about that because i havent read the source code for that but i think its true
quaint sapphire
also im pretty sure that props are part of the components "state"
uhh, iirc only if the props passed, themselves, are also stateful
quaint sapphire
the tokens will change if the theme changes
from what I see, the tokens are not stateful
they just get regenerated when the theme changes bc the component is called again
anyways this is a pointless convo
and i aint a react expert
charred monolithBOT
spark cove
from what I see, the tokens are not stateful
they just get regenerated when the ...
what do u think state is
because thats all that state does with FCs
spark cove
thats ok
quaint sapphire
I'm just a brainless user of the lib
spark cove
thats okay lol, idk if u like knowing things but if u did a convo would help
anyways time to address code review
quaint sapphire
I like knowing things
I just don't control what they are
My brain works at random
spark cove
@austere talon is it necessary that signal is a state
in useAwaiter
oh i didnt see pending
my b
austere talon
discord uses dangerouslySetInnerHTML too right?
austere talon
<@343383572805058560> is it necessary that signal is a state
signal?
i think setSignal was just for forceUpdate
it's a very dirty hack
just remove it and replace with dependency array
spark cove
oh i thought it was for cancel
austere talon
the signal was for
const [res, err, pending, refetch] = useAwaiter(() => fetch(...));
// on demand
refetch()
feel free to change it as necessary
spark cove
so taht if deps change pending will go back to true
austere talon
just make sure it still works the same as before
spark cove
death
austere talon
so taht if deps change pending will go back to true
oh yeah that should definitely be done
spark cove
i'll change it and save the testing for later
austere talon
that was an oversight by me
spark cove
but r.jsx() my hatred 💔
what is this
austere talon
React.createElement replacement
austere talon
it is react createElement with slight changes
basically because createElement has some performance bottlenecks
and they didnt want to do breaking change
they made a new api
spark cove
nooo not a breaking change in a major release
austere talon
the difference is that children are now an array in props instead of being passed as varargs and the key is now passed as third argument
spark cove
did they deprecate
umbral hedge
breaking changes are a pain to work with
spark cove
that makes sense
austere talon
whenever you return an array it uses jsxs if i understood correctly
in dev it shows the key warning
in prod jsx = jsxs
spark cove
ah
austere talon
did they deprecate
no
spark cove
interesting?
austere talon
React.createElement is still what you should use
jsx is only to be used by the compiler
but jsx() is way more painful to regex match than createElement
😔
spark cove
f
austere talon
cause children are so cursed
spark cove
what compiler uses .jsx format
austere talon
wdym
spark cove
or supports
austere talon
like jsx in general or do you mean the function
austere talon
babel, swc and esbuild i think?
spark cove
makes sense
austere talon
spark cove
is ref still in props
spark cove
wha
austere talon
before you had to have React in scope
to use jsx
so you had to import React in every jsx file
spark cove
yea
austere talon
see that article i linked
charred monolithBOT
spark cove
@austere talon where should i put useIntersection
austere talon
also no worries
spark cove
kk
spark cove
util/react.ts?
should i move useAwaiter there too
austere talon
yeah
i should clean up utils
xd
actually probably dont move useAwaiter
cause it might conflict with other prs
spark cove
oh true ok
i'll leave that for u
well
im already updating useAwaiter that breaks people using refetch
or onError
austere talon
what did u change
austere talon
maybe use an object instead
spark cove
sounds good
austere talon
useAwaiter(
() => fetch(),
{
onError: e => ...,
deps: []
}
)```so its easier to add new stuff in the future
spark cove
fallbackValue as well
austere talon
and not pain to use if you only want onError
spark cove
yea
spark cove
i did ya
i made a dirtyRefetch for reviewdb inside the plugin
that u can change later
austere talon
refs are so weird
how do i set the initial value of a ref
const ref = useRef()
return <input ref={ref} />
how do i set the initial input???
frail skyBOT
charred monolithBOT
woeful sable
dzshn:nya/ % z v
dzshn:is-even/ (main) % z ven
dzshn:is-even/ (main) % z venc
dzshn:vencord/ (main) %
fastest cd'ing
woeful sable
idk sounds fishy
muted mural
no
spark cove
@austere talon when u said named functions over arrow functions
did u mean like named rather than anonymous
or using the function keyword for named functions
i hope ven didnt go to sleep
remote spindle
he sleeped
spark cove
liar
charred monolithBOT
austere talon
<@343383572805058560> when u said named functions over arrow functions
- const foo = () => {
+ function foo() {
austere talon
austere talon
you decide
I usually still use function inside closures
but doesn't really matter 
spark cove
you decide
unfortunately read this in the ERB voice
muted mural
@austere talon merge or die
muted mural
very beautiful
austere talon
show
muted mural
because raw
spark cove
does that make a fiber for each svg path
austere talon
did you just copy that patch from hide attachments lmao
muted mural
Yes 🤫
austere talon
MiniPopover api would be useful
spark cove
u should just
muted mural
wait i do need to check if they're compatible lol
spark cove
use the input context menu
austere talon
wait i do need to check if they're compatible lol
yeah
spark cove
theres already the send message button toggle
austere talon
does that makeItem support onContextMenu?
austere talon
i enabled it but I don't see the button
error in console?
muted mural
i'm not sure
austere talon
Also hide attachments only shows up on messages with images
muted mural
oh
austere talon
austere talon
check console then
muted mural
nothign
austere talon
does that makeItem support onContextMenu?
Also ^
muted mural
not sure
austere talon
I mean assuming makeItem supports context menu it'll be a piece of cake
muted mural
wait quickmention also uses that patch
muted mural
i'm looking at the regex, it should be compatible
now i refreshed again and hideattachments is shown
really make a api
austere talon
both work?
spark cove
lmk when ur done reviewing so i can push
brave geyser
Make context menu api smh
muted mural
ugh
brave geyser
muted mural
i love how you both are talking in github
austere talon
oh yeah the old code also uses unknown
I think someone else added that code
I would never use unknown
unknown is like very pain
const text = err?.message || String(err)```if it's any this works, if unknown you gotta cast 
muted mural
i don't even wanna know how you're making shiki with plaintext patching
austere talon
it's just one single patch
just replace discords codeblock react method
and return ur own component
spark cove
yea the old plugin was functionally an instead patch too i think
spark cove
unknown is like very pain
unknown is nice as an input since its typesafe
i guess thats if ur trying to write type safety in a verbose way
austere talon
yes but type safety should be optional, not forced
austere talon
```js
const text = err?.message || String(err)```
this code is perfectly safe (unless message is a cursed getter but then cast won't save you either)
casting to Error is obsolete
so having err as any is nicer (imo)
spark cove
yes but type safety should be optional, not forced
i would agree if we werent using strict mode
also i wouldnt say thats perfectly safe since err.message could be a non string
const text = err instanceof Error ? err.message : String(err) is not much more lengthy imo
although not a perfect solution if u care about err.message being empty
muted mural
brave problems
charred monolithBOT
woeful sable
horror
austere talon
also i wouldnt say thats *perfectly* safe since err.message could be a non strin...
that's true ig but I trust myself not to throw some random object with a non string message
spark cove
that's true ig but I trust myself not to throw some random object with a non str...
real
austere talon
I think instead of Use shiki instead of, it would make more sense to say Prefer shiki over
cause otherwise it sounds like it's using either or
spark cove
instead of sounds like either or to me lol
maybe like "Use HLJS with Shiki as a fallback"
austere talon
yeah that's why I'm saying change it to Prefer
austere talon
maybe like "Use HLJS with Shiki as a fallback"
yeah that's good as well
muted mural
my god
austere talon
lmao
muted mural
vendicatedddmachineee what do i do #🧩-plugin-development
austere talon
looks good now I think but I'm too tired to think
gonna check it out tmrw and probably merge then
thanks for fixes!!
muted mural
too tired to think but thinks that it looks good now
austere talon
also arrpc bug lol
looks like it just needs update for the get asset finding
not sure
spark cove
looks like it just needs update for the get asset finding
i think its because it runs on dom load
and the those modules are in lazy loaded chunks
so if the websocket readys quick enough
it wont find them
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/plugins/arRPC.tsx#L33
**arRPC.tsx: **Line 33
const rpcManager = findByCodeLazy(".APPLICATION_RPC(");
this seems to find the wrong module
austere talon
**arRPC.tsx: **Line 33
```tsx
const rpcManager = findByCodeLazy(".APPLICATION_RP...
try this filter with a findAll in the console, I bet it'll find multiple
spark cove
i figured it was async transpilation stuff hehe
austere talon
probably just needs a more precise filter and it'll work again
austere talon
- create file in src/api that exports methods to interact with it
- create complementary api plugin if needed that does patches
spark cove
maybe get them to run it
austere talon
they're plugins for simplicity
austere talon
maybe get them to run it
hmm
muted mural
exactly what pc- was
austere talon
but does it have a lookupApp method
muted mural
cmon
austere talon
exactly what pc- was
I guess but at least this time we aren't cluttering people's plugin folders
the idea is to hide api plugins from plugins page soon
idk why I even showed them in the first place lol
spark cove
yea my thoughts
austere talon
I wish they weren't plugins but then I'd have to reimplement all the life cycle logic and so on
spark cove
reusing the api is much better imo and u even had a required field
but from my perspective showing them is like showing all the utils and other api things
austere talon
I think I will introduce a "hidden" flag on the plugins object that hides plugins from settings (moves them in its own "hidden" category)
or well we could just make that flag push them to the very bottom
so they still show up but all the way down 👇 👇 👇
like in a different category like the required ones
spark cove
use case?
muted mural
i'm confused what does this do
spark cove
toggleable apis?
spark cove
ah was just gonna ask if theres deps
austere talon
but some users may still want to enable some apis without enabling plugins
spark cove
that makes sense then
austere talon
but some users may still want to enable some apis without enabling plugins
to for example use them in the console
spark cove
ya
austere talon
i'm confused what does this do
just inserts Element into the array
Also some apis may have their own settings (potentially)
austere talon
Also some apis may have their own settings (potentially)
for example I want to make a keybind api at some point where plugins can register their own keybinds and then users can customise those
austere talon
ah was just gonna ask if theres deps
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/plugins/viewIcons.tsx#L38
**viewIcons.tsx: **Line 38
dependencies = ["MenuItemDeobfuscatorAPI"];
omfg
lament nimbus
Classes good
lament nimbus
What's wrong with them
austere talon
interface IFoo {
bar: SomeComplexType;
}
class Foo implements IFoo {
bar = {} // WHERE INTELLISENSE TYPESCRIPT
}```you literally have to type twice with classes
the definePlugin function on the other hand gives you full intellisense
muted mural
wtf how does this function work
lament nimbus
the definePlugin function on the other hand gives you full intellisense
Doesn't seem like a deal breaker to me but whatever
austere talon
it is
lament nimbus
Also is it different with abstract classes
austere talon
no
austere talon
Doesn't seem like a deal breaker to me but whatever
you lose all intellisense for commands, patches, etc unless
- we use terrible builder patterns like discord.js which is ugly
- we use a defineCommands and definePatches function which is ugly
- you type them manually which is ugly
another option would be specifying the entire data in the constructor super call but like now it's basically the same as the old definePlugin
karmic gazelle
vs code or jetbrains?
austere talon
the only benefit of using class is better this in nested objects but you can just work around that by just storing your plugin in a variable instead of directly exporting it
so I'm still against classes
you can use classes in ur plugins if u want tho lol
VuewIcons shows its possible
muted mural
@austere talon just checked, contextmenu does work
austere talon
neat
muted mural
api plugins aren't on by default
i mean you do have the required flag
austere talon
ye but only settings and NoTrack and notices api are required
austere talon
but does it always insert in that exact position or can you choose position
both are fine imo but the latter would be cooler
muted mural
too lazy
austere talon
muted mural
it isn't changing the icon or text tho
https://github.com/Vendicated/Vencord/pull/275 @austere talon api there, gotta fix that bug tho
golden sand
copyraw plugin done?
charred monolithBOT
solemn spoke
😐 i wonder why ppl hit the fork button instead of the star button
honest cypress
They're about to make a token logger and submit it as a pull request /s
solemn spoke
interesting that there is 17 PRs to be merged
umbral hedge
open PRs does not mean they're ready to be merged
solemn spoke
lmfao
as i see, some, or most of them are waiting to be approved mostly
after they did all the requests
muted mural
copyraw plugin done?
basically
austere talon
did you add modal?
solemn spoke
@austere talon VEN PLS REVIEW MY CHANGES AAAAAAAA
solemn spoke
(yes i have anxiety for my prs to be merged)
austere talon
just steal from juby
muted mural
Lazy
muted mural
Pr
austere talon
just wait for merge soon
austere talon
Lazy
it shouldn't be hard cause we already export all Modal Components from utils/modals
for parsing codeblock it's just Parser.parse(String) from commons
austere talon
I mean i can also help with modal later
but it shouldn't take longer than 5 minutes
muted mural
Lazy
muted mural
sorry i don't understand what Pr is
Pull request
golden sand
Pull request
oh okay 🙂
quick ibex
which is absolutely massive
@austere talon stop talking about my mother
charred monolithBOT
charred monolithBOT
it works as expected for me, even with the experiment. the dono and button cards are themed correctly and the plugin cards while being ugly are themed the same as the highlight which is the expected behaviour
Not for me 🤷
austere talon
https://github.com/fregante/chrome-webstore-upload-cli
spark cove
zsxddcfghjkl;'
austere talon
yes
charred monolithBOT
austere talon
NO
umbral hedge
this plugin should list MessagePopoverAPI as dependency
this plugin should list MessagePopoverAPI as dependency
charred monolithBOT
obsidian flame
the quickMention plugin could also use this api right?
muted mural
I did required: true @austere talon in the api plugin
austere talon
dont
muted mural
quick mention could
austere talon
just add to dependencies of the plugins using it
austere talon
the popover api isn't required unless a plugin actually uses it so should be made dependency instead!!
@spark cove testing shiki rn
can we maybe add catppuccin to the default themes?
awesome theme
any reason you made this stick to the markers?
are values inbetween not supported?
muted mural
Because he wants to torture people like discord slowmode does
charred monolithBOT
austere talon
charred monolithBOT
Apparently no. I wonder what talk-name
If I could take a wild guess it would be org.freedesktop.portal.Flatpak
Nope
golden gulch
that was vencord itself as soon as it got an auto updater 
solemn spoke
@austere talon ven pwwease check mah new pushes 👉👈
muted mural
RCE plugin - execute random code on another vencord person's client
UGEHGWUGHEWE THIS NEW FONT SUCKS WTF
wgeFEWH
FUCK
austere talon
muted mural
I used #1000955971650195588
brave geyser
muted mural
3
2
1
pushed
some stuff
on copy raw
@austere talon ^^
also rce I still wanted to color other things
rigid venture
color them
spark cove
<@454072114492866560> testing shiki rn
Yea ber
Bet
Also what code did
Did you use
Tsesr
austere talon
wha
I opened #🎨-css-snippets
just see what timestamp I commented that at to figure out what the latest message was
it was consistent crashing
One dark theme
other settings unchanged
I can debug it for you if you can't reproduce it, but tomorrow not now, I'm gonna sleep
armcord btw
spark cove
any reason you made this stick to the markers?
oh i thought stick was like nearby snap
ye not intended
austere talon
nah it means you can only select the markers and not area between
austere talon
ill debug, fix, add error boundary, and theme
can u repro?
austere talon
oh wait is it armcord problem
spark cove
idk haavenrt tested
austere talon
hmm im not sure if I have the very latest version that had ur csp change
maybe it's that
that it can't load worker?
spark cove
uh
austere talon
but that doesn't make any sense, why would there be null tokens, so doubt
spark cove
it would stop at init
austere talon
yeah that's what I thought
austere talon
lol what
spark cove
my nails
frail skyBOT
spark cove
404
austere talon
arrpc
spark cove
@austere talon ah i wasnt destructuring useAwaiter properly
was
tokens = [tokens: null, error: null, pending: false]
should have been
[tokens] = [tokens: null, error: null, pending: false]
i really wanna find out why typescript didnt catch that
austere talon
oh lol
tokens is supposed to be null or an array?
if so, both are valid values for it
hot pecan
RCE plugin - execute random code on another vencord person's client
but since its random code you dont know which user you are targeting
muted mural
Yes
charred monolithBOT
lament nimbus
but since its random code you dont know which user you are targeting
token roulette
is it some random's token or is it ven's token that you got
spark cove
can we maybe add catppuccin to the default themes?
they dont exist as just json files in their repo they are built, so i might have to either add vsix support later or just suggest people extract jsons from themes like this into a gist
vsix support would be cringe unless discord has some sort of zip file reader library already
lament nimbus
in b4 fflate simping
quaint sapphire
vsix support would be cringe unless discord has some sort of zip file reader lib...
It has a zlib implementation bundled
It is used for the gateway websocket
charred monolithBOT
rare shale
@austere talon https://github.com/Vendicated/Vencord/pull/238 is there a problem with this pr? im willing to not depend on the other pr if thats the problem. please answer
austere talon
<@343383572805058560> https://github.com/Vendicated/Vencord/pull/238 is there a ...
oh i forgot to comment on it MB
it's mainly that there's basically no point in doing that since the use of userplugins is extremly niche and not really comfortable rn. I want to remove it eventually in favour of basic plugin support without having to build from source
hot pecan
i wanted to that as well
by introducing async loading of plugins
so you can load them from localstorage
solemn spoke
@austere talon meow what do you think of the changes on my pr
placid wave
so you can load them from localstorage
SKULL
imo indexeddb would be way better for this
austere talon
you can bundle zip in like ~8kb bundle size but no need just don't load extensions
we already bundle a zip lib but it's in main
you could use ipc to unzip stuff if you really wanted
but eh no need imo
spark cove
you can bundle zip in like ~8kb bundle size but no need just don't load extensio...
i'd just need inflate so 3kb actualy
also last night debugging that shit was so hard
the source maps actually made it harder
devtools was breaking hard
anyways i pushed the stuff
austere talon
devtools was breaking hard
lol what
hot pecan
localStorage is synchronous
wait localstorage is sync
austere talon
yes
hot pecan
well that makes that user plugins installing trivial
spark cove
nothing would show except for the innermost block vars
same with the vars panel on the right
hot pecan
i guess ill do a pr for that
spark cove
but non source mapped debugger was working
austere talon
localStorage = synchronous, ~4mb limit (or lower)
indexeddb = asynchronous, infinite limit but at 50mb the user gets a Popup "do you want to allow example.com to write large data" or something like that and if they choose no that's where it ends
hot pecan
oh yeah i meant indexeddb
austere talon
I put a 4gb blob in indexeddb once to test and it works
lmao
it just explodes the discord folder's size
spark cove
like the cache doesnt already do that enough!!!
hot pecan
i dont do a lot of javascript, im usually hired for backend qa or devops
spark cove
true it has some pitfalls i think though
hot pecan
ill be fine with indexeddb, i think
spark cove
none really apply if ur using it as a keyval tho
spark cove
now
sorry
not now
i think i want to use indexdb in the next plugin
and take advantage of structured data
if i make a util it would be funny
austere talon
there's a few plugins already using idb
austere talon
namespacing
custom stores would be better honestly (but also maybe not worth it because usually a plugin will only write a single row)
Well it's just idb-keyval which has support for custom stores on all methods
charred monolithBOT
spark cove
custom stores would be better honestly (but also maybe not worth it because usua...
uh mine will definitely write many many rows
austere talon
what are u gonna do
spark cove
but honestly it could just not
spark cove
what are u gonna do <:blobcatfearful:1033854064758362252>
the impl in my head was dumb
a cache for spotify tracks albums etc
no need for a row per entity
austere talon
oh you wanna do custom embeds
austere talon
why do u even wanna cache those, shouldn't chromium by default cache most of it?
assuming Spotify sets the right cache headers which I assume they do
spark cove
ye
austere talon
oh maye i shouldnt share device id
austere talon
7200seconds
spark cove
the device id
austere talon
2 hours
spark cove
2 hours is ok i guess
austere talon
caching is hard because have fun with cache invalidation xd
spark cove
i was
i was gonna have fun
but now its simple
simple is good though so lets go
still need to make sure im bucketing requests
praise lodash debounce
actually theres a better one for that
austere talon
lodash my hatred 💔
i made my own debounce
cause we load before lodash is a thing
austere talon
cause we load before lodash is a thing
oh also cause i use it in all electron contexts
inb4 discord also bundles lodash in node
spark cove
check those node_modules u might be surprised
austere talon
oh also cause i use it in all electron contexts
that's also why it's in its own file btw
it was originally in misc but misc has react stuff and for that it imports react from webpack commons and webpack commons has side effects (calling a lot of finds())
so esbuild was bundling like the whole webpack code into the main bundle xd
oopsie
spark cove
lolololol
austere talon
did u fix shiki pr now?
austere talon
sad
*good
how did that crash even slip past you
only happens under certain circumstances?
spark cove
plaintext
what
ignore that message i didnt send that
anyways it was because i didnt test
and i forgot to write that i was waiting to test
but u did it for me that was so cool
why does discord's node_modules include tslib
austere talon
and i forgot to write that i was waiting to test
LOL
austere talon
why does discord's node_modules include tslib
some packages depend on it
spark cove
..>
austere talon
it's like shared ts runtime right
i think the purpose is so that if there's multiple packages use it it isn't duplicated
austere talon
yeah it's to avoid having the same typescript helpers in every module
swc has the same
spark cove
yea that makes sense
austere talon
spark cove
its just
so funny to see all these
es5 targeting node packages
in a node 16 electron app
austere talon
vencord has a bunch of those helpers too
spark cove
we will never surpass the cjs/esm ones
austere talon
uses es6 features
polyfills lots of es6 features with bloated worse performing polyfills
I LOVE REGENERATORRUNTIME
this is my favourite module
austere talon
this is my favourite module
it reduced bundle size by like 20kb
spark cove
that produces discord bundles
umbral hedge
you love how they actually use async/await in some places
spark cove
with no polyfills
austere talon
do it
spark cove
i will try one day i found the part of swc that generates them so i think generating signatures will be easy
austere talon
honestly
in my modding time i have found so much deranged code in discords bundle
they use this for printing the banner https://github.com/sindresorhus/devtools-detect
and it is so terrible
it runs an interval that checks for devtools stuff every 500ms
spark cove
oh my god
hot pecan
is that the one that uses screensize
spark cove
me using detatched devtools
spark cove
hold up!
austere talon
discord when they worsen everyone's performance by checking if devtools are open every 500ms just to spam some stupid banner
umbral hedge
i love
crude hearth
they use this for printing the banner https://github.com/sindresorhus/devtools-d...
https://github.com/sindresorhus?page=2&tab=repositories horror who the hell is this guy
he has 1.1k repos
and most of them have at least 500 stars
maiden elk
discord when they worsen everyone's performance by checking if devtools are open...
so if you enable the plugin, does it make perf better?
crude hearth
(I only looked first pages)
austere talon
https://github.com/sindresorhus?page=2&tab=repositories horror who the hell is t...
he is responsible for npm packages being so bloated
austere talon
yes
spark cove
i love when my dns dies
hot pecan
thats just standard javascript, making a whole ass package for one function
spark cove
but i still get gateway events
austere talon
he has three million npm packages and all of them depend on 10 of his other packages
maiden elk
the npmbro
austere talon
so you install camelcase and get 40 packages you didnt ask for
crude hearth
this guy is insane
austere talon
he's the devilbro of npm
crude hearth
he is one of the reasons npm sucks
maiden elk
the npmbro