#MoP DK
1 messages Ā· Page 4 of 1
if diseases will fall off soon it should have a timer on plague strike
if you have nothing else to press
that there isnt a scenario you need to blood tap
though it should be recommending like erw or something
So here for example it recommend me plague strike bcs I have nothing else to do, but also blood tap coz it would make me press something else better if I use it?
Thatās my understanding as well
but here?
Here I understand better sending PS since you canāt send any other stuff since all the runes are on CD
And BT at 9 charges
can't I just BT and hb ?
9 charges itās not the āidealā moment to press BT
Yes
But I think the logic does not shows up BT at 9 charges?
giving me then enough for FS
ugh PS shouldnt be showing i messed something up
your dot is over 5s
stupid apl
theres nothign wrong with what i wrote
wtf
oh
there is a PS entry
that i thought was deleted
i have to do some cleanup one sec
this is normal
youre saving it for when you need it situationally and have to make your own judgement call
as for the sim its a DPS increase to hold as well, and you use it during Pillar windows
these are the only situations blood tap should appear
So sometimes you just have to hold for like 2-3 secs?
Alright
I'll raid so I'll try this lol and if there's issue I'll just tell you afterwards and just swap back to the basic rotation since I do things manually with it
I would love to be able to remove gloves and racial tho
its weird cause i dont have that
how can I make it stop getting back to masterfrog ?
reword that
i dont understand
I think when he load the custom rotation and he reloads, it switches back the the masterfrog rotation
or entering a new instance
ya i have to take a look at the change made other day, it doing something weird i thinking. might just wanna revert to a old release. prob if it that messed need to remove it š
think that change was to 'fix' a diff issue, but seems to have created more isues that it was trying to solve?
Not usable atm then guys?
Yeah I mean for the auto-selection of the default rotation
How can I solve that?
tested several times in dummy
it feels good
I was also paying attention to the PS calls and BT
now I need to test in AoE
to see if BT and PL are suggested different to optimize HB
for me, I dont see gloves and racials
and I just did paste the rotation
If I enable gloves and belt check boxes, then it shows up
otherwise not
I think this is how it was intended, right frog?
yes
is this for any particular version? getting this while importing on this version
requires the latest beta
okay he is right Frog
its showing like he told us
I imported twice so I dont know which one is the right one LOL
this one doesnt seem like it has AoE
I dont know its weird and confusing LOOOL
the default one does recognize nameplates
and it suggest DnD
as im mobing towards dummies
the custom one from the file does not
as well as having berserking as pre-set
andd we cannot get rid off showing gloves
racial yes
if you get rid of the racial showing
what happens
also racial shouldnt be in center
its set up in pre-set by default
I moved to the left and all good
so its fixed?
even with the box
no matter what I do/change
yes, the box does nothing
as long as its not center
yes that minor thing
but did you see it does not detect more nameplates?
DnD was not appearing as suggestion
as it does the default one
thats because the racial was blocking it i think?
no
I removed racial and still not DnD on the left
I believe this version misses something
I mean is just a feeling
compared to the default one
the custom one also suggests full DnD
in pre-set
even in single target
okay thats clear then
however I set there already
Then I donāt know
thats why I said it seems it does not detect the AoE (nameplates?)
which is so very strange
I mean thats not the default one
I was testing this one
demo with the masterfrog defaulted one
Is there a way to add the missing stuff/improvements to the default one and push?
can u make a tldr of what your issue ?
Same as you faced about the icons (racial + gloves)
Racial can be set as ignore and it does no longer shown but not the gloves
AoE is not working properly. Basically seems like is not even implemented
Which is not true Dark confirmed
There are sometimes split icons HB/FS even being in melee
The range seems to be working done
Fine
But I donāt know how the icons are split in middle with 2 core abilities
In summary, the default rotation (masterfrog) feels quite a lot smoother
But as per Darkās comments, there some stuff missing
PL/BT calls, AoE, ERW etc etc
Do you also have the swaps when relog/new instance or w:e?
between masterfrog and the one he sent us
Yes I do
<@&1075064309534691469> the most recent **beta **version has the most recent APL changes by darkfrog:
it has several bug fixes too, so please try this version out
https://www.curseforge.com/wow/addons/nag/files/all?page=1&pageSize=20
just installed
Potentially quick question (but probs not):
With BDK, what are the requirements for the NAG to suggest Death Siphon? As I've had it suggested at times when I have Death Runes but near no vengeance.
Unsure if it's getting stuck or something else is happening?
thats expected, it tells you to AOE because it adds your distance to the target to the count if no mobs around you.
first check: mobs around you in a 7yd radius (i believe it was 7)
second check: if no mobs around you, add to the 7yd the distance from you to your target.
its prompting you AOE because its counting the mobs to the side as well.
yes there are. blood is the most polished product we ever had
there are built in weapon damage and atk power calcs
correct
death siphon has itw own AP calculation
based on that, its suggested or not
if you want to see it more, go blood DW, then
wont me as powerful
hahahaha yeah
never heatd this before!!!
once you get super high level os atk power, dw is actually better
i mean, a bird told me
just small feedback and not important
racial is set as pre-set by default
I think it might be in the left
again, thats shit u know
I just changed to left
pre-set is whatever the person who made the initial locations wanted it to be
prob left
yeah
I think is a matter of personal likes
depends on how the ppl uses the NAG
I just relooked at my AP & the breakpoints on Wowhead and I was just being an idiot apparently. š¤£š
Also, DW Blood you say? š¤
the theory is that when youre super high in vengence, weapon damage is just a very small part of the equations and the weapons youre using is just a stat stick
give bloodrippa some time to theoricraft about it hah
im just repeating what i heard from him
another thing guys Im noticing
I think the range need to be another polishment
there are several cases where PS and FS are in the midle together with HB while in range
like PS/FS in midddle with HB
what spec?
frost
My understanding is, either FS or PS should be popping up in the midle in melee but not in range
yes
in range it should show HB as AOE / optitional
it shows HB on the middle-right in range yes
so in range it shows oblit | HB
or FS | HB
or PS | HB
but always HB in the middle-right
Try a reload?
If HB is never in the center
I didnāt mean never
But in some cases
Iāll try to make another recording while doing some dailies
Well HB always shows at range, so that parts normal
The split between FS and PS is odd
Unless you moved PS to a different location
Thatās my understanding as well
HB in range of course
But middle split into FS/Oblig/PS | HB ?
Yea shouldn't do that
Exactly
The new rotation is on baseline now? with beta 6
Yes, it is
Works well?
Overall yes
But I think something happens with the HB split with oblit, PS or FS while in range
Iām gonna record a video now
here we can clearly see was I was meant
I think this is wrong
@solemn halo @slow escarp
It should!
Its calculating if the add will reach 35% in 5 seconds
Yup it does that's nice
Im at work I haven't even looked
No pain no gain
New to DK and NAG, but raiding tonight and noticed my nag had moments where nothing is populated for spell usage. Is this a rune problem?
tried to /nag reset all and put your key again / reload ?
I have, i suspect it has to be a rune related thing. becuause it doesnt even tell me to use tap even tho they are available.
You just have low haste its normal but it should be suggesting HB with a timer
Occassionally its nothing, but haste could be an issue i guess. (also its for UH)
Ive reset it and made sure the current rotation is selected correctly. just something i noticed so figured i would ask and see if anyone's had any experience similar.
oh, dont think UH has any look ahead stuff yet
but yea downtime is normal
ill have to clip it for a proper example
i know what you mean
Big grats man
Died on elegon, stone guard is normalized and sucks
Had a cranker elegon too tho
(But its also normalized, so mightve sucked)
Yeah, stone guard is prob my least fav boss now lol
Any workaround for this guys? I can test in raid this evening
no problem
yes, im using this one
I lost some keybinds
I will pay attention to this because I havenāt noticed this from my aide
can pls someone explain me how suddenly DnD goes into the mid of the nag suggest as it should be used on single target ?
Because if you have no resources except an unholy rune its good to press
Though howling blast should be in the center here
never had that before through whole mop
Depends when you updated
This is not happening to me. Iām in the latest beta
You should be getting dnd sometimes, at least I do
i do update nag every day through curseforge did the whole day without this suddenly I log back and it started to feel odd
This used to happen in previous release/s
Its not a bug its the intended behaviour
like HB never pulling center
okay
BTW sorry ramicie still didnt look at ur thing I was grinding pvp and dungeons
Okay im looking now you have PS and HB in aoe slot
Thats correct behaviour
@lament bluff
shouldnt it be that u spend your unholy rune to do a oblit and or to refresh blood plague through Plague strike ?
If you have no other runes and blood plague is active on the target
Then dnd is your choice
never getting into those situations either having a left out frost rune/death rune alone or with a plague rune together or no runes at all interesting
I dont think I am doing rotationally something bad but might not realize it
Its a rare occurrence
No problem at all
Sorry that explains the HB split in the middle)
Yea its just if youre in range then it will show
As an option to press something
But youre goal is to run to melee and do the left option
Make sense
But why it shows PS/FS/Oblit in range?
So that you know what to do when you get to melee
Okay do left side is what to do in melee rather than HB?
In my view Dark, if you are in range u shouldnāt see any melee action suggestion. If you are in range and start pressing HB, the melee action is no longer valid so when you are finally in melee, the action/s from the left are no longer relevant so the NAG has to re adapt anyways
Because u are consuming runes while pressing HB in melee?
Idk I personally prefer it this way, so I know HB isnt the most optimal thing to press right now but im doing it because I have no choice since im in range
Otherwise you wouldn't know maybe you should really be in melee
If you dislike it you would have to delete a little bit of the rotation code though
You wouldnāt differentiate melee/range actions
I get what u mean
Well yea but what if you step too far back and it suggest HB full but you have no idea it only did that because youre too far
Nah nah nah
Idk this is better for my brain š§
Yes I understand the rationale behind
If you had a better solution lmk but its nice knowing what's coming up when youre in melee
The only thing man is, seems not to react quickly once you are in melee
Do you know what I mean?
Yes agree
Yes
Apart from what we are talking aboutā¦I dont see any other thing
Of course there might be something to improve but Iām not that good player in order to notice maybe
There is for sure stuff to improve... Just need time
Will add a pestilence suggestion in the future....
You notice the BT in AoE working good?
Yea just pestilence i think I wanna add
today my lucky day 0 bugs with dk until today sudendly everything goes to hell
Hmmmm yes??? Let me know where to pay attention to evaluate the BT suggestions in AoE pls
The main goal is to send more HB I believe?
Just will suggest BT in aoe when out of runes
But we need more FS to send more BT
What do you mean
Okay Iāll test this as well
But overall fella good man
yup, think i got many of the other issues resolved. mostly seems to be related to the db and making changes currently. so working on this atm just trying to catch up with the forums and what else going on here. thx all for patience
Did a raid again on my UH dk, on feng, garajal and elegon soul reaper wasnt showing below 35% health (NAG version 5.5.1 ). Next ID i'll try with an older version
Quick question, how does the ST and AOE rotation works ? I tried to select manually the AOE but I couldnāt. Is the switch automatic?
If you are blood, it selects automatically based on number of mobs within 8 yards. 1-3 is DPS and more Single target with light cleave and dot management on adds , and 4+ it switches to AOE. Once mobs get killed off an it drops down to 3 mobs in range it auto switches mid combat.
thanks for the info. I'm UDK but maybe the logic is the same then.
It is yes
Soul reaper doesn't seem to work with last beta release of nag
(trying it in celestial dungeon, NAG never tells me to soul reaper below 35% hp)
(Single target rotation)
seeing same thing
reverted back to 5.5.4-beta2 from august 7 which seems to be the more stable one, it has keybind and soul reaper working (For UH)
Does it work for beta 1?
i have the latest update
What do u mean?
whatever this one is
updating to beta 8 now and checking
that waas beta 6
beta 8 appears good
well my class tab is just gone tho
relogging lmao
any particular reason soul reaper doesn't show a GCD swipe?
š
@solemn halo @viral hedge What happened to SR recommendations? They're missing all together.
N/M I see your rotation import a few posts up and imported that one to check out
https://www.wowhead.com/mop-classic/guide/classes/death-knight/frost/dps-best-gear-bis-pre-raid this still out BiS list for master frost?
and is the rotation master frost or oblit?
See pins in the #šµļ½frost-not-retail channel for all my info
Anyone a good UH ST and AOE import. I loose May after update
^ interested. For some reason the NAG for unholy doesnāt recognize when Iām surrounded by 4+ mobs. I canāt tell if Iām supposed to strictly blood boil for aoe or not lol
Its being fixed soon
newsest beta should have it
aoe recently implemented, please try it out
Has something changed with BDK recently?
Whenever I DRW it wants me to AMS as well. The AMS icon is in the main spot (despite being set as above in the spell locations), and only goes away when I either AMS or when DRW ends.
So I reset a few times and it seems to have maybe resolved. Maybe. Still doing it.
It must be a bug with spell location with the build you are using. If itās up to date then roll back to a version it was working on. Iām personally still using 7-28 beta9.
Is it just me or is NAG still not recommending SR? @slow escarp @solemn halo @viral hedge
Pretty sure I'm using the most up to date release version.
Will double check, maybe try a reinstall or a older version as well.
ive been getting SR
but I was getting death coil suggestions as blood on galleon
that was weird as I was still in range of the boss
I'm definitely not getting SR suggestions
im on beta 17
let me log in and check....
oh, for SR?
yes
thats a much old version
Were newer versions not pushed to Curse? It says up to date
might need to select the beta channel rav
So this one?
ya, that's latest rc/beta
Done, I'll see how it goes from there
will bump to release if no major issues there
it's i believe def more stable than the 3 beta1 or the beta2
I can't think of a way to test on dummies since they never get low enough
that most have stuck with
dummies should simulate low death
yeah? hmm okay
some of the dummies in shrine are in execute
i mean may not be able to use it, but the nag will tell ya to once ya get the 20% or w/e mark
you can use it w/e
ahh k
just is useful after the execute
Okay, yeah, that version works
ya that's got tons of fixes rav
or the beta
def most stable we had in a while
right on, yeah I normally just update whatever curse tosses out
i've fixed tons of long standing bugs etc
the spell manager works now
oh btw I can't find the resize button anywhere anymore
it takes the id from an apl, converts it to a name looks tht name up in your spellbook and gets the id you actually have
so should resolve all the oddities with wow id's needing to be mapped/chaned
long as the name matches(so for the earth wind fire with a comma that wouldn't)
but it should not for IsKnownSpell etc all use the mapping and should in theory be correct
and can remnove all those damn hard mapped id's š
oh i found the resize, its in legacy???
whats the new resizer
legacy = current
lmaooo
resizer?
scroll wheel no scale while it unlocked?
oh idk i didnt know it did that
That works
lmao it doesnt say it in there so I dont instinctively know that
gotta use that intuition man
well you move things around im used to hahaha
lol, ya
that been there ever since i fixed the unlock long ago though but ya stuff changes so fast š
So I had a consistent problem with NAG disappearing on me randomly - in dungeons, raids, out questing, etc. I had "Show Always" toggled off because I didn't want it appearing unless I was in combat - a setting I've opted for for over three years. Well, I finally just set it to Show Always regardless and now it's no longer disappearing on me. No idea this is relevant info, or if I just got lucky for two hours straight, but hey, thought I'd mention it in case others are having their NAG just disappear on them and also have "Show Always" toggled off.
That is good info, best place to put that would be #1028578761572110356
Makes sense why it wasn't actually a key issue
Went though a bunch of versions and the change occurs between V5.1.0-alpha5 & 6.
Alpha5 works fine, alpha6 has AMS in the main spot as long as it's off CD & DRW is active.
Just an oddity I found.
Will post it in bugs now as well.
thanx, i'll take a look and see if i can see what happened there. appreciate the diagnostic assistance! š @jade phoenix
@deft vault thanks a bunch!
could you plz try this #1347562002306043977 message
see if thats a fix
Only just saw this (love discord not notifying me earlier), I've set myself a reminder to check when I'm next back on my PC. Will let you know.
Just checked with the most recent ver on Curseforge (5.5.4-beta27) and it works like it should.
hell yeah!
ty
@solemn halo is an AoE rotation being worked on I thought?
for unholy?
or frost
or what
Frost
yea I have plans for it but I got a lot of stuff on my plate lol
making a heart of fear bis list for example
All good man. Appreciate all the work you're putting in man
@solemn halo @viral hedge NAG seems to be calling for SR before 35% health on some mobs. Is it trying to predict how quickly hte mob is going to die maybe?
did you happen to have the 'monitor' open? or just normal
I'm not sure what you mean by monitor. I just let it do its thing
Ya good then haha. Was a bug in the test thing that was causing that so wanted to make sure you weren't using it. I'd ya don't know ya good prob haha
I get that it's trying to predict maybe, but it doesn't feel right to see it pop up at 70% mob health and even sometimes even be on CD as a suggestion if runes aren't available for it.
I mean you could always modify the apl if you āfeelā that theres a better way to pop things, in theory is suggesting what its optimal. If the target is X hp but based on dmg is about to reach the 35% under the SR time for the dmg it seems thats the way to go.
Again its just a tool and you need to actually know the class/spec and fights
Yea tbh I dont like using SR on low HP mobs so thats something I want to fix
And in aoe its still suggesting SR
Which im positive HB is better
Is it possible to tweak the APL/Rotation to be more "healing focused"? Currently I am AOE leveling with a Blood DK and It only suggests Death Strike when Im low, not sure if its 30% HP or something and it suggest blood boil alot more which probably is better for dmg but Id rather use a bit more self sustain in this case, when mobs get easier I can swap back. IF possible ofc
You can toggle off auto change rotation in the rotation manager. That will keep you topped up more than the AOE rotation. The AOE will send every blood and death rune as blood boils if you have four or more targets and wonāt deathstike unless below 40%. Itās a DPS rotation. The non AOE rotation will prio death strikes or death siphons with death runes and still keep light AOE, dnd down, proper use of blood boils with disease management on mobs, and increase snap shot of disease with scaling vengeance.
With that being said , you can for sure use the rotation manager to copy the rotation and tweak it to your play style and use case.
I also found unless you are pulling huge packs you stayed alive pretty ok
Should i still use the Blood AOE rotation or Blood DPS in Rotation Manager?
If you plan on doing the tweaks to the rotation. You would want to replace the 2nd line down that calls to switch to a rotation. Renaming that line with the AOE rotation name you make your custom rotation. Then you would want to go into a AOE rotation and make sure its calling back to the other DPS more Single Target rotation name.
If you toggle off the Auto Change Rotation. Stick to the Blood DPS rotation and have it selected.
Is there a way with current rotation as UH to disable the AOE part of rotation for one fight ? Like on amber shapper its not that great to go full aoe when boss is on P3 (and nag is suggesting AOE rotation, which is a big loss in term of dps on this phase )
Yes, its in the /nag menu under CLASS , just uncheck the "Automatic Rotation Switching"
did that, it was still suggesting aoe °°
will search about it more tomorrow
(and on latest nag release, aoe and ST are in the same rotation if i'm not mistaken, the only one there is for UH)
(so duno how this option work with just one rotation)
Anyone else with UH sometimes see the nag say to death coil despite not having enough rp?
Ahh okay, i see now. It looks like the AOE is baked into the default rotation. It doesnt actually have a separate AOE rotation based on Number of targets that it automatically switches to during combat. So there wouldnt be a way to toggle off AOE..
If ur at 31 rp, I believe itās a blizz issue with rounding. If not, then if itās possible for u to record a moment of that happening, would be helpful š
I think its exactly 31rp actually yep
Ill try and make note of when
Great Tyty
@solemn halo jus realize berserking is not part of the spell location for the 2H rota mate
yeah it isnt too
whats that?
Theres an AutocastOtherCooldowns call in the APL that SHOULD catch it but its not lol
Which I get why or we have to hardcode every cooldown a spec knows I guess
yeah I see
@night urchin kept an eye out today and it is 100% the 31 rp thing
Might be bias because in looking for it but felt like it happened a lot
Ye Fonsasnhas talked about this in the past just nothing he can do about it afaik, sucks though š
I dont think much would be lost if nag just required one more RP to coil, no? A req for 33 rp to suggest coil?
Might be missing something but probably a smaller loss then the confusion š
@slow escarp curious on your opinion here
thats blizzard! what we could do is put a RP check in the APL
think that could solve already
Hello guys. Im not sure if this discord is only for MoP?
But if no. Heres my newly dinged frost DK that im trying to gear.
Not sure if i should go upgrade weapon and live with 710 for a while, then craft 2 off pieces in 720. Or just craft weapon. What u think?
It is only for classic yes
On latest beta (with the rotation changes) after a /reset all. its this HB location intended?
No its not do a /reload
Happens sometimes
@solemn halo Did I read that you found time to update the AoE rotation?
Appears not to actually
atm no, its not worth it unless you have super weak weapon.
what we are working on is fixing the snapshot math so that the NAG naturally holds festerblight if the math is right
makes sense?
It would be nice if there were another option instead of soul reaper on short-lived mobs
Maybe stack it with HB or FS because it gets stuck on SR
Especially for AoE. Recommending SR for that seems kewk
It shouldnt suggest if less than 5s but idk that part not working
I just send a HB and ignore
SR on something that dies for the 50% haste aint half bad
Ye but cant rly sim so I have no idea the real impact
Nah thats true but atleast imo its very noticeable
Whether it does more than a SR hit i doubt but its not entirely lost
How do you register trinkets in the addon?
AoE rotation yet? doesn't seem like it
Idk what sort of aoe improvements youre looking for but its all implemented
I guess I think it was going to be a lot of HB>HB>HB and some FSs to reset rune back to HBs
All of this is already in the rotation i believe
I play with the aoe override and just. Manually decide when you aoe admittedly
Nah current weaving is optimal, the nag doesnt really take into account the HP for that to do a HB if they're about to die, thats just a personal judgment call
/generate key
not fixed even after /reload
just updated to the 5.5.6 beta 7
and this rotation is the one set up by default. i think dark confirmed this is not the right one but the AOE
seems like the distance to target is making conflict here
@viral hedge alse here FYI mate
ā¤ļø
lol arg... always trying to overengineer shit haha. fme gimme a few š
As a quick summary, Howling Blast should never show on the left but only in middle
This has been fixed after /reload in other versions but seems here it does not fix the problem. Seems like it moves to left as soon as we are approaching to the target
So thatās why I thought is still a problem with the distance to target as we saw in the shaman?
lol that better
hrm, @lament bluff ya that's kinda i think a problem with the override positions logic they have in
sorry, cops at door again
my damn cameras didn't pick up shit š
lol
ok lemme try get back to this, my brain bit frazzled now lol
exactly
in my case, if nothing targeted and in melee or far away it shows in middle. If I target in melee it shows up on left
Something weird with the distance to target for howling blast lol
Guys, this is still happening in the latest beta. I just went back to 5.5.4 beta 30
i gotta run an error but i'll take another look when i get home
ok home finally. lemme take a look
@lament bluff afaik, @solemn halo has that coded like that specifically unless i'm misunderstanding the problem?
There are places in the frost apl that it's set to go to the AOE spot. Is this something different i'm not grokking? š
Hey!! Yes, I thinks itās coded like that but HB should never be shown on the left iirc
99,99% sure about that
ya i mentioned that and @solemn halo said it's intended. it's hardcoded in the APL with a AOE
@solemn halo can confirm better than me
hardcoded to AOE
so ya, lets get dark feedback but i know i asked about that a month or so ago and he said it's supposed to be like that
I think the AOE part of HB has been always intended to be shown in middle
like split icon yes but never on the left
I think that has been reported sometimes by other people and the fix was to /reload
but now this does not work
so whats the problem sorry.... in AOE situations it's going left... or not going left sorry
ah ok
lemme check those funcs then see if i can see whats up... mine here is never left
i can't reproduce that yet
@lament bluff do you happen to have custom position overrides, or that happen on a full /nag reset all too?
wonder if there something odd in the wtf file doing it leftover? I know @slow escarp has mentioned he'd seen ppl with issues where even a reset all didn't fix and the wtf file itself needed to be wiped?
I tried every thing
deleted WTF etc etc
all works fine in 5.5.4 beta 30
I think that was the first release before starting sending new betas/alphas again
ok appreciate all that... I'll try to get back on 4-beta30 and see if i can see what the difference is between 2
Yeah maybe this might be helpful? I donāt know mate u are the boss here
i trying boss!
š lol
just trying to finish up this schema modification crap atm
š FIELD COUNT ANALYSIS SUMMARY
============================================================
Total APL message types analyzed: 103
Same field count: 94
Extra parameters in handlers: 1
Missing parameters in handlers: 2
Types with schema modifications: 8
Fixed by modifications: 6
High priority differences: 0
Medium priority differences: 3
š“ HIGH PRIORITY (need immediate review):
š” MEDIUM PRIORITY (review recommended):
APLActionCastFriendlySpell: 2 ā 1 (-1)
APLActionCastSpell: 2 ā 3 (+1)
APLActionChannelSpell: 4 ā 3 (-1)
š§ TYPES WITH MODIFICATIONS:
APLActionAutocastOtherCooldowns: 5 fields (FIXED)
APLActionCastAllStatBuffCooldowns: 1 fields (PARTIAL)
APLActionMultidot: 2 fields (FIXED)
APLActionStrictMultidot: 2 fields (FIXED)
APLValueAnyStatBuffCooldownsActive: 1 fields (PARTIAL)
APLValueNumberTargets: 2 fields (FIXED)
APLValueSpellCanCast: 1 fields (FIXED)
APLValueUnitDistance: 1 fields (FIXED)
ā
Analysis complete! Check field_count_analysis.csv for detailed results.
(venv) rakizi@patchwerk:~/project/NextActionGuide$ ```
lookin good š
that had a TON before š lol
What is that???
python validation code lol
for wowsim->our handlers etc since we have overrides and diff values sometimes. this'll let validator/apleditor eventually etc use same set of code which'll get updated based on the proto files being updated which is what they use to generate their code
reason shit takes me forever, i don't do shit the easy way 𤣠spend all day every day to simplify something so i don't gotta spend a few days doing it manually š¤£
ya, i got systems in place now to modify the schema, use schema for validation. the apleditor is using those fields. got function overrides now, think things are looking pretty good really
Is there a way to make a comparison between versions?
For the cases like āthis was working in version XYZā
not really easily with the amount of changes i've been making to standardize and shit... between then and now like 20-30-40k lines prob changed along with many many many files getting deleted and recreated which will cause a problem with diffs
normally yes once things in the proper place
Ah I see
but all this moving around to get things 'right' makes that a little harder
Thatās the aim then!
ya
I understand
our filenames mapto the categories now
before it was just shit everywhere
numerous duplicates
etc
but ya, the 'system' can pull all the actual fields from the wowsim web thingy for rotation editor, gets the fields used, validates this against ours, we can add fields or override as needed etc
so in our editor i hope eventually... all the tooltips are already there etc no need to manually enter it all
but yes, standard patterns, standard usage, similar calls. standard locations etc is what i've been driving for... this mop push kinda caused me a few months of pain with cleaning up stuff š
You are doing great Rak!
iu trying, i prob overengineer shit.. but i think that's what makes it fun... if i was just data monkeying shit wtf fun is that
i get that quest solving/raid boss #1 world kill feeling when i can fix some of the big problems/bugs š
like keybinds... holy fuck that's a world boss and a half š¤£
š¢
those keep me up at night, feel like shit those are a mess still
Still HB on the left in beta 17 guys @viral hedge @slow escarp
ya just posted in the thread there
.
.
And here
@lament bluff #šļ½nag-updates
believe that what ya were seeing fixed... my ptr dk had a 2h equipped forever, so was never hitting that apl to see it
Cool buddy. Iāll check this out soon!
Thank you
ya, was just the default return value for UnitDistance. returned 999 when no target so that of course is greater than 1 so was trying to send the hb that way with no target or something
Makes sense ye
So what happened then when you target?
I mean, the 999 is an expected value?
it was.. but probably didn't account for that lol. prob coulda handled diff... but i think how we use unitdistance that should be sufficient/work
could just fix in apl with another check... but then that means changing bot to update apl's etc and rather mimic the behavior 'properly' or at least w/e i think is properly lol
@viral hedge cheers, seems to be fixe
great
however I have one doubt
hahaha
nI think is just a concept
whats the doubt ya see hehe
@solemn halo can help here
let me record a video
maybe im misunderstanding the way its coded
kk i'll look at icons that just make my brain go boom
š¤£
darkfrog can explain to me like the 4yo
š¤£
if this causes issues, we can just do what fonsas had suggested at first and just code in the apl so it ignores the 999 but i just rather not hardcode is all if we can š
So ya, lemme know if other things seem off too
there u go
wouldnt make more sense the other way around?
if im not in melee range, only HB but at the moment im in melee range, it makes more sense to me the split middle icon PS | HB
even oblit though
on the other hand, the default rotation should be "Masterfrog AOE" and not "Masterfrog ST"
since Masterfrog AOE has the ST included
And follow the same convention as the 2h with ST/AOE in the name imo
agree
Why split in melee, hb is split at range due to just showing you can hb right now since you cant plague strike, but optimally youd plague strike if you could run forward
Then it might be only showing plague strike if Iām in melee since itās the optimal cast (meaning that Iām good to cast it?) and PS|HB in range, following your explanation
yeah cool mate. However in the recording we can see that only HB is in middle even though we are good to cast PS right?
I didnt watch the recording Im just saying what's supposed to happen š
ahhhh
LOL
lol it does happen that, havent noticed it before. Also its not a new thing cuz im rocking an older version
The half icon at range tho ya?
Its been a while since I added it yes
yeah
based on the screenshot from the left, only HB should be shown and only PS or PS|HB from the right screenshot
As UH, there is issues with plague leech and DoT snapshoting in general
When you plague leech, NAG never tell to reaply disease just after
And for snapshotting in general, duno why but nag keeps telling to spam outbreak sometimes (when there's no new proc to snapshot)
Are you on the newest version?
#šļ½nag-updates message
will try whats left of my raid with latest one (i did update last night, but yeah there's new versions since)
(and just wanted to report while I'm doing my raid and thinking of it xD )
nope doesn't change anything
now it doesnt tell to plague strike to apply DoT when engaging fight / switching
(and still doesnt tell to reaply dot after plague leech)
will test on what's left of my raid to tell exactly what doesnt work
on protector, it never tells to put dot on pull / when you switch back to them
but it does tell to plague strike when switching on adds
thats weird
Ok thank you for reporting this and appreciate the testing hopefully we can get this figured out soon
Oh yeah I just saw that sometimes nag doesnt tell on left side that gargoyle / unholy frenzy came off cd
If the fight is projected to last less than 3 mins longer, it should be saving them for exe phase
So that would be normal depending on fight length
yeah i saw that on some boss they were showing when off cd, so I guess nag is keeping them for exec
ya use tebex or patreon?
tebex
it work in town?
/claim for now see if that works
while i go take a look
ya good now
just told tebex to resend
/generate_key
ya purple now lol
ya one of us now š
nice
im good i think
Any news / update about those issues ? š
No im sorry, not at this point š
@median wigeon can you please record?
I need help replicating so I can understand the exact conditions
just updated on latest release, I'm not seeing those bugs anymore on target dummy
Gonna try in dungeon to see if everything is working
ok yeah there is still an issue with plague leech, got it on video
just trying to see how to compress cuz its 500mb lulz
here you can see that when nag is suggesting plague leech, I'm pressing it and then NAG doesn't tell to reaply dot directly
(first 20 seconds of video, rest is just me trying to switch on dog to see if nag is telling to apply dot, but runes where on cd and i took a stun so couldn't see shit, but i think that the switch / pull dot suggestion is good now)
if you need more footage feel free to ask
btw on target dummy it seems to work fine, no idea why on "real" encounter plague leech & dot reaply doesn't rly work
Do you not have an active sub Elwers? It requires an active sub to work properly anywhere except target dummies, which would explain why ur having issues š
i had a sub whe i recorded, it just dropped an hour ago and i'm not home right now to reactivate it kek
Guessing its not a time-to-kill issue since target should not be expected to die that fast, not sure what the threshhold is set to if any
Top prio in rotation should probably be and probably is already to plaguestrike if no dots present so i'd assume its not a rotation thing but an addon thing, no?
I cant say i've seen this myself though
You think the issue could be caused by my nag installation ? Can try to do a full clean one with deleted nag wtf folder maybe ?_?
Youāre still not showing up in discord as subbed to the NAG, Iām assuming thatās why ur having issues when in instances but not when on dummy
Can try to ping uh
Someone and get help if ur having issue with Tebex sub, wanna say Rakizi or Liv
It's not the case, I just didn't resub today...
to prove you that when i reported the bug and when i did my video footage I was subbed on nag
Ok, I only say that given youāre saying you werenāt having these issues on dummies right? Putting up dots should always be the top prio basically ye
Yes and that's why I find this bug particularly weird
There might be something weird with the newer version though, hoping thatās not the case but
Maybe with a clean install it should fix the problem, will give it a try tomorrow when i get time
Do you know the version you had last been using before this one by chance?
on video footage, v5.5.6 beta 36
On my raid test and issues from last week, 5.5.6 beta 20
So youāve had the same issues since at least beta 20?
Did beta 20 work for you for a bit and then break or didnāt work once you installed it? And do you know what version you were using before beta 20? I know thatās probably far back but just trying to get as much info as possible for debugging
din't work when I installed it, I was on a previous version that didn't worked too (something like beta 15-16 maybe, can't say which one because I have bought a new computer and I don't have my last downloaded files from previous computer on it to track which version I was on before going to 20)
But I can remember previous versions that were working very well before that
Might just be my nag addon thats corrupted with all the versions change / things I had to do to fix other problems (like with enhance sham nag a month ago) which may have made my NAG unstable
Will try a clean one tomorrow
If no one else is having issues with UH nag its coming from me
I can tell you which version im on later which works perfectly for me, i havent updated since the /nag aoe got added iirc
@median wigeon @left ridge @night urchin this should fix DK snapshots
plz try again, see if everything else falls into place
is this based on latest nag update ? (asking because latest nag fixed issues for enh cham logic, just to know if I have to switch nag versions if I wanna play my sham (if the version you linked fix my problem)
This was built on whatever was most updated! It should have all shaman fixes there
Ok, trying it in dungeon right now, Dot / plague leech seems to be fixed yes !
Can confirm after testing it, it's working ! Issues are gone ! Thank you
Yey!! Thanks!!
Remember to thank yourself aswell, contribution and even taking the time to record evidence / debug material, Kudos to you šŖ
amen
š¤£
trying to look at an icon, determine wtf that icon is, if it should be active etc etc when i got no clue what rotations hsould be makes it quite a pita for me š¤£
Is HB supposed to show as a half icon in melee and full icon at ranged? I assume its supposed to be the opposite? lol
It is the opposite yes
I havent updated to the latest version so I havent even seen this
Suspect my versions old already
Is it just that function misbehaving @novel egret ?
Yeah pretty much.
What version of NAG are you using btw?
I have not noticed anything else.
probs 5.5.4
@viral hedge seems the checking for range check is backwards in the latest version?
Yeah latest stable release is fine. So no big deal.
Guys plague leech is F again? Iām in beta 38
Frost spec
Yeah is completely fucked haha
It shows up on top but no usage
It does never work
Tried already
Seems like something got wrong while trying to fix another DK stuff
PL is showing up when the conditions are not met
Iāll send a recording in some time
Okay the issue is with PS suggestions
Not suggested at all
It doesnāt tell to cast nor re-apply
in dummy it works fine but it didnt work in raid. The issue is with PS, not the PL calls (those are correct)
may be this possible? I mean, could that make sense ?
this has been always working ok except for today so thats why I was wondering if this may have been impacted after the snapshot workarounds recently made
Itās exactly this
Eeeeexactly this
No PS suggestion after PL but all working fine in dummy
Iām in the latest beta 38
Did you try the link Fonsas dropped yesterday in here? That fixed the issue for Elwers
Well, no
Because of this reply from him
So I assume this fix was part already of the latest beta
And I updated to beta 38 this morning
Well plague strike on frost is only pressed when you have a non death unholy rune
If you had one of those and weren't full on other runes to prio howling blast or full on RP then it should show
Its kinda low on the prio
You do not need to keep up blood plague all the time
Yeah right but has been always suggested after PL right
Not for me at least
It shouldnt be immediately
Unless the situation of your resources called for it
So this replaces the existing beta 38?
Idk it wasn't really a recent change
Not immediately
If it never asks then thats an issue ya
Sometimes yes
Yes
Is never suggested but in dummy is working perfect
So I should try the file from Fonsas
I also didn't make any changes
This should fix it as per Elwerās feedback
Maybe he tied something to plague strike globally on accident
Ya maybe
Should fix then ya
The fix fonsas gave here yesterday is in the beta 38 if I'm correct
but maybe fixing UH issues created frost issues ? weird °___°
thats the one im using yes
but facing exactly the same issue you faced yesterday @median wigeon
i thought this was fixed?
Strange it was fixed here but not in beta 38 LOL
that's weird lol
Indeed!
#1347561798009753621 message
Seems like beta 38 snapshot isn't working for frost spec, but the version you linked to us is working lol
Tho I didn't test myself beta 38 on UH yet, I assumed it was working °°
it might be the rotation selector fro frost not automatically switching between the 4 rotations it has
how this should work ? enabling auto-swap rotations option so we have 1 rota for ST and 1 rota for AOE. However, @solemn halo confirmed the AOE one has the ST as well
it should auto swap between the 2, and also between the 2h and dw options
its not something you notice, it happens automatically
I think it checks the equipped weapon right?
yes
And whatās the purpose of having those 2 rotations if one of them has everything inside mate?
but that isnt working atm
thats with darkfrog, but i bet some ppl just wanted to have it ST and thats it
Yeah most likely
I unchecked the autoswap rotations, tested with both ST and AOE and im getting the same result on anything else but dummies that work as intended. Its not showing PS after Leech and it keeps suggesting leech when is not usable
@solemn halo hey sir. Does "Automatic Rotation Switching" make sense for frost DW? what was the argument on having 2x frost rotations ST an AOE if you said that the AOE one has everything? Im trying to fix the problem with the PS. It works ok generally but Fonsas is right on the rotation selector on not working as expected so I was wondering what if I switch the auto rotation selector off and I just set up the AOE rotation as default and that's it
ok so is completely obsolete then...
then @slow escarp , can we remove "Masterfrog ST by darkfrog" from the available rotations and make "Masterfrog AOE by darkfrog" default?
@solemn halo am I correct mr?
Yea oblit can do the same
wait wym by āit works ok generallyā? I cant make it work as intended at all but dummies, which version are u on cuz i might be on a another one lol
beta 38
I think the problem is the auto rotation
How so? I did comment the ST one leaving just the AOE by default and still happened to me aand leaving the checkbox for autoswapping rotation unmarked. PL suggested while no disease and never suggested PS. but tbf I dont even know if thats the right way of doing that
just tested again in random dung. U are right. Not always PS is suggested after PL. However, PL is still suggested even though PS is not on the target
but sometimes I see PS suggested right after PL
hard to find here the pattern...
maybe the auto rotation switch does not work smooth anyway? maybe unchecking the auto rotation does nothing?
Yeah but my idea was that if i dont have others rotations for the autorotation to mess with it shouldnt matter and work as intended right?
maybe something with the target count?
I think thats the idea yes
So i even commented both 2h rotation so i just have the AOE for frost and it keeps happening. Reading the APL im seeing this (that i think i get it right) so the fact that is suggesting when no blood plague is up might be the cause? idk
That specifically checks that both diseases r up
So wouldnāt be that entry
now just done Stormstout Brewery and it worked absolutely fine in every boss encounter
but not in scarlet
oof, i havent had a single time that its showing me as intended besides dummies š
I faced the same yesterday in TOES
then I double checked in dummies and yeah
that was the same issue Elwers was facing the other day
then Fonsas sent a file that fixed the problem for him
but he confirmed this fix was part of the beta 38
Yeah but does not the other line that suggest plague leech also checks for that same thing?
they have the exact same check, so if anything is wrong with it it would be wrong with both entries
Unholy one is pretty nuts on this version, havent updated since
yeah thats why im asking, is that stupid to think that is not considering only the dot applied by us and that being the issue? I had no PS suggestion but a plague leech instead on dungeons with dks on the group and the disease applied to the target not being mine
No this might be what it is ty good catch
@viral hedge plz read Kimeās message if you would, I remember Headrippa saying he was having the same issue so might be whatās happening here
Reading the unitDebuffUnified function is just filtering by "HARMFUL" and not "PLAYER|HARMFUL" but idk if thats something we wanna have for all scenarios
ill change that and test it out
You wouldnāt ever rly care about other debuffs since NAG isnt like applying dots to cover raid debuffs
maybe for buffs? like to not override buffs that does the same? like HoW or something
well now i dont have an extra dk to test it on dungeons lol
that seems to be the issue and the fix for it (again, dont m have a second dk to help me out rn to test it lol) but at least is now consistently working on dungeons
Ya, sorry i had a rough day today. felt like shit. lemme try to catch up to whatever was here
I can 100% confirm thats the issue
just done a dung with another dk and PS is not suggested at all. Previous dungeon, there were no other dks so PS was working as expected
hell yeah im fixing this atm
@viral hedge i might have a solution for this in place. testing now, will push soon
This also explains why ive never seen the issue, as i play 10m with no other dksn
Good catch indeed
@naive portal ! šŖ
Yeah really good
Huuuge, I didnt have a single dk last night to test it right away but Ill be testing it in tnās 25m
Did i forgot to turn off something? lmao
i dont think its fixed @slow escarp š
https://youtu.be/GL3qDWOd2Ms?si=IGzHlzCF3f8685-Y video proof š
no. fonsas is just sending stuff out he shouldn't š bad @slow escarp š¤£
that sposed to be stripped in the release process, why those are .3mb bigger than the regular releases
safe to ignore it though, the regular wago/nag update releases won't have that, just the test versions he sends out. no biggie though
Yepā¦seems not to be fixed
I tried with the version fonsas sent (prev img sent) and also i did the change on the function i was thinking was the guilty one but after a nag reset it happened again (video)
So that change does not fix it right
i dont think so, im looking for a dk to hit a dummy with plague strike to see if doin /dump NAG:DotIsActive(55078) its returning true or false after that change
Smart
Its incredible how when i need a second dk is literally not a single one lol
well i just grabbed the black arrow dot and its showing as active so its not that function (added a print too to see if it was called) . So i did find which was the actual function that was being called and its working with a quick change. Adding 'PLAYER|' to the default UnitAura does the trick, that or by just passing to the DotIsActive the filter "PLAYER|HARMFUL" instead of just NAG:UnitDebuff(targetUnit, spellId) @slow escarp @viral hedge
The quick test was, first the addon without the change and /dump NAG:DotIsActive(whatever dot spellId u find someone else is applying to the dummy) then adding that extra filter + /reload and run the same /dump .... it should now return false instead of true
https://youtu.be/B5KqRlUvUW0?si=wrxynsR4L0r0_yCN with the change
