#NAG 4.0.0-rc.6 - Ret Pally Feedback

1 messages · Page 1 of 1 (latest)

quartz plaza
#

NAG is not recommending Templar's Verdict when you have 3 Holy Power or when you have a Divine Protection Proc and CS and Judgement are in CD. It is even recommending Consecration and Exo when you should either TV or CS. @stark flower @full tiger @rose kestrel

stark flower
#

dang seems 4.0 introduced a lot more bugs

#

ripperino

#

APL hasnt changed

#

sounds like its back to the mines for us

#

was really hoping this APL would just already work for t13 and that it was future proofed already with the work i put in to do that

#

i really dont think its an APL issue causing any of these bugs

#

but once i finish updating wowhead ill triple check it

rose kestrel
full tiger
#

No, def not the apl I take a look. Mom visiting today, so to ight/tmw I look

stark flower
#

no worries no worries

#

you work hard af no rush

full tiger
#

@quartz plaza I assume ya got the 4 piece right?

quartz plaza
#

yes

full tiger
#

Hrm, ill have to figure out wtf the issue with going back to old version is so i don't feel like such an ass when it don't work or to test 🤣

#

I took off the t12 4p and i was getting tv's as i thin it should be i still have hard time following rotations in real time lol

#

@quartz plaza @stark flower

#

surv you tested it with the t12 too ya?

#

or is that technically untested since the t12 checks in pre 4.0 didn't work?

#

correctly i think at least?

#

@stark flower try with the t12 set equipped when ya get a chance and see if it effects your tv's

stark flower
#

just the last version ive been using for like a month

#

with no issues

stark flower
stark flower
#

We have a fix coming for all of this stuff I think

#

I'm testing a new version that is currently working so far

#

on the lookout for anything being prio'd over TV when it shouldnt

#

but TV seems to be working good again

shadow cave
#

Will be also applied the adapted prio as per the wow head guide for DS?

stark flower
#

Yep

#

T13, and all the known issues ATM are being worked on

#

I'll post updates asap

#

My apologies I was expecting t13 to work out of the box

#

With the APL I set up

shadow cave
stark flower
#

I will be testing on the PTR more shortly.

I investigated the APL and in rare situations exorcism and t13 judgement can be prioritized over TV when the conditions for the main TV action are not met -but this is also what the wowsims auto rotation does, which the NAG rotation uses as our foundation, and it indeed sims the highest interestingly enough.

It only happens when the main code for TV conditions are not met, as there is a 2nd TV priority below T13 judge and Exorcism. I'm still in the process of talking to sim developer about why this sims better, as I don't fully understand it, but it's only under very specific circumstances, and only when there is adequate time before CS is ready.

So it's actually not a bug in the APL or the addon like I initially thought, it's just the foundation of the wowsims auto rotation that our NAG rotation is built on, and it performs a few hundred DPS better on the sim.

It shouldn't happen very often, if your exo / t13 judge is being recommended over TV very often, or always, then there's a different problem going on, and you should let me know.

As far as I can see, the new release of NAG and the default AoK rotation it uses are working properly so far with every combination of T12 and T13 and does accurately handle T13 judgement. But I will continue testing on the PTR.

quartz plaza
# stark flower I will be testing on the PTR more shortly. I investigated the APL and in rare ...

I’ll check the newest version over the weekend but if nothing was changed from version 4.0.0-rc.6 you can see in the video I posted a few issues:

  • at 0:20 nag recommends Holy Wrath instead of TV while I had a DP proc.
  • at 0:25 it recommended judgement while I had a DP proc and 3 HP
  • at 0:30 it recommended CS while I had 3HP already and since CS doesn’t proc DP, then the prio should be TV
stark flower
#

Yeah I could not replicate any of these issues in the new version

#

I think that stuff has all been fixed because Rakizi fixed a bunch of the conditions we use in the APL

#

Wait this video is from 4.0? Wtf

#

The video up there from 2/21? At the top of this thread?

#

I even did the exact same opener you did there and it gave me TV instead of holy wrath

stark flower
#

All three of those things you listed there are impossible with the APL logic as far as I can tell. So it likely got ironed out with the conditions Rakizi fixed

#

If somehow you're still having issues on the newest version, def let me know, and on top of that - make sure to run a clean install, reimport the weakaura, and use the button to Reset All too - should be on AoK rotation in the drop-down it's default

I tested myself on the PTR with t12 and with t13 and it has been working perfectly but I'll do even more testing just to be sure

#

We're up to 4.0.0-rc.25 now

quartz plaza
shadow cave
stark flower
shadow cave
# stark flower Yeah

All good man. I notices when zealotry is up, and I use CS, it is suggesting always exo and then it changes to TV at the very last 0.1 seconds

stark flower
#

That means it's taking a while to register that you have 3 holy power, mine is usually much quicker, like it only takes a split second or so to update to TV.

Is there a setting somewhere for update speed? Seems like yours might be on the low side

shadow cave
stark flower
#

Of the addon checking to see if conditions are met

#

@full tiger is there an update speed setting somewhere or is it fixed for everyone

full tiger
stark flower
#

Could latency affect it

#

And ramicie is your ping high

#

Cause if you have like 250ms ping, and it has to get info about if conditions are met from the server, which then has to report back .. that means it would take 250ms + 250ms + 70ms server latency or so, to get a response. Assuming it processed instantly, that would be an easy 570ms delay after using a spell before it would update that you now have 3 holy power etc

#

But other than that yeah idk what else would cause some people to get their updates slower

#

My ping is rather fast. Like 40ms

#

And yeah it takes usually around 100-200ms or so for mine to update after a new condition is met

#

Though sometimes it is just already correct

#

And doesn't need to update

full tiger
#

i'll take a poke around and see if i can get it 'faster' for ya, i ping ya to get tested

stark flower
#

But that is probably due to some guardrails I added

stark flower
#

For like, holy power for example

full tiger
#

i mean it uses the wow api's for most part

stark flower
#

Gotcha

full tiger
#

which i think is client side

stark flower
#

Yeah the game definitely has client side resource tracking

full tiger
#

not sure exactly how those updates work though, as the db for some things like some of your guys hp abilities and some rogue ones the internal db says they free

stark flower
#

Like your client tracks your holy power etc

full tiger
#

so much be some disconnect somewhere

shadow cave
quartz plaza
#

The new version feels more smooth and a lot better @full tiger

#

Great job guys