[Bug] tc_custom_communities_url

[wheat zinc]

https://github.com/TaterClient/TClient/issues/199

[north rivet]

hi, too lazy to reply on github
the line you added has syntax issues and that's the reason why it isn't working

see default value here https://github.com/TaterClient/TClient/blob/4e4269396b97d06879c11ae3b9696c3dc1a06084/src/engine/shared/config_variables_tclient.h#L268

to clarify it's your silly quotation marks

[wheat zinc]

then why could there be problems with SollyBunny too?

[north rivet]

there isn't

[wheat zinc]

When my link fails, I change it back to SollyBunny through the config, but the game won't launch until I completely delete the command from the config.

[north rivet]

it is your quotation marks if you delete it it will be set to the default you can see in the link below

[wheat zinc]

then I dont understand where my problem is in .json? or should i contact SollyBunny

[north rivet]

your wrong syntax “https://raw.githubusercontent.com/SollyBunny/ddnet-custom-communities/refs/heads/main/custom-communities-ddnet-info.json”
correct syntax "https://raw.githubusercontent.com/SollyBunny/ddnet-custom-communities/refs/heads/main/custom-communities-ddnet-info.json"

[north rivet]

use the right quotation marks here: "

[wheat zinc]

I used these "

or ' + ' need?

[north rivet]

you did not

[wheat zinc]

Do you mean in the game when entering a command or in the code?

[north rivet]

look at the example I sent above

[north rivet]

here you see the difference?

[wheat zinc]

If you mean using the command in the game console, then I wrote <tc_custom_communities_url "link">

[wheat zinc]

about “” its just that GitHub changed the quotation marks in the text

[north rivet]

tc_custom_communities_url "https://raw.githubusercontent.com/SollyBunny/ddnet-custom-communities/refs/heads/main/custom-communities-ddnet-info.json"

[wheat zinc]

yes

[north rivet]

try this in f1 and report back

[wheat zinc]

SollyBunny works if left at default, but I'm more interested in whether the problem is in my community code (in my repository) or the client doesn't allow me to change custom communities.

[north rivet]

well you claimed it doesn't work if left at default either

[wheat zinc]

If I post my link and it doesn't work and close the game, then after I try to launch the game a second time, it won't open. Then I tried to return Sollybunny in the configuration, and the game wouldn't start until I completely removed the command from the configuration.

[kind hearth]

i dont see the issue you are trying to solve

nor the problem you are facing

why are you modfying that link, why do you want to modify custom communities?

[wheat zinc]

I want to know if the problem is something I did wrong in my own code or if the client is preventing me from changing the link.

[kind hearth]

what problem, and what are you doing

[wheat zinc]

I plan to submit a PL to your repository later, but I ran into a problem adding a community.

[kind hearth]

the client may crash if the data inside is invalid

try using the checkers

JSON not formatted as standard JSON (fixed)
file:///home/solly/Code/a/ddnet-custom-communities/scripts/format.mjs:141
            const oldPath = path.join(dir, file);
                                     ^

ReferenceError: dir is not defined
    at iconsToLowerCase (file:///home/solly/Code/a/ddnet-custom-communities/scripts/format.mjs:141:30)
    at async file:///home/solly/Code/a/ddnet-custom-communities/scripts/format.mjs:147:1

thats a problem in my CI code, but if the config is correct it shouldnt error
ive now fixed it upstream

the icon is uppercase is why its failing

and the png is formatted weirdly and is wrong size (not 128x64)

Can't read icon meta: ./icons/ego.png

[north rivet]

I'm too lazy to go through all the commits but the first commit already has a syntax error

[kind hearth]

file icons/ego.png 
icons/ego.png: RIFF (little-endian) data, Web/P image, with alpha, 80x80 

[wheat zinc]

@kind hearth@north rivet Thank you for help!

i can fix

The truth is, the Tater Client still doesn't work after I changed the custom community link; it doesn't launch a second time, but the community works.
@kind hearth :(

[kind hearth]

u need to make it a png

and the correct size

[wheat zinc]

i fixed it

u can check

[kind hearth]

Icon is 1536x1024 not 128x64: ./icons/ego.png

run node ./scripts/format.mjs

or check the CI on github

https://github.com/OffMoluc/ddnet-custom-communities/actions/workflows/format.yml

u need to enable them tho

thats the last of the problems it reports tho

[wheat zinc]

@kind hearth i have problem with Tater Client

i fix my icon

[kind hearth]

there may be an actual issue setting the config

i am busy the rest of the day unfortunatley

till like tuesday late afternoon

[wheat zinc]

ok 🙂

I'll send a pull request to your repository