#bug with the spear
1 messages · Page 1 of 1 (latest)
@atomic magnet
Yes, as soon as possible, I don't have my PC.
GitHub
Summary
Spear attacks (stab + lunge) were silently ignored when the player was mounted because the speed check read player.getMovementSpeed() (always ~0 on a mount) instead of the mount's ...
We dont merge into master rn til migration is merged.
changed
@whole hound Would you review?
also this one
https://github.com/PowerNukkitX/PowerNukkitX/pull/2586
also this one:
https://github.com/PowerNukkitX/PowerNukkitX/pull/2587
Yeah sure
But as you said we can't till migration is merged
He PR'd into migration
oh okay
I mean there are no merge rules for that, but still, You know the most about that code
I've posted 6 pulls 😉
Will look into them when I have time. Rn I port our public plugins to api 3.0.0
https://github.com/PowerNukkitX/PowerNukkitX/blob/master/CONTRIBUTING.md#-ai-tool-usage
If you use AI, please check the guidelines.
yes to post
AI PR descriptions are against the policy. We want to hear it from the developer so we know he understands his code