Frankendraz overdraft can't add two of the same type of unit

[meager temple]

For frankendraz overdraft, we need to combine the abilities from 2 FS and 2 mechs. This used to work, sending a warning as part of the command response but still allowing it. But now the last unit of the type listed is the only one set.

For example:
/franken unit_add unit_id: cabal_flagship unit_id_1: kjalengard_flagship

Will just result in kjalengard FS being added.

Example of it working (09/10/2024): #1282877052151926785 message

Example of it not working (10/29/2024): #1300518524044968009 message

[small hearth]

Suspect this change: https://github.com/AsyncTI4/TI4_map_generator_bot/commit/fe9ea41f6ce02d5c1f89224920d6eb195af66ccd

[reef flicker]

Can we keep this as the default, but maybe add a Boolean parameter like "don't remove extra" or similar

[small hearth]

Yeah, that was my plan

[reef flicker]

Tight, because I do think the convenience of auto removing extras is nice

[zealous lodge]

Did this get carried out?

[small hearth]

No, not yet

[zealous lodge]

That would make sense! Thanks!

[woven plover]

Any plans to address? Would be nice.

[reef flicker]

I know P1 has been on a bit of a break, I'm kinda on a break now myself but maybe I can find some time

[woven plover]

Understandable. Yall donate a ton of time to the community. Just wanted bring it back into focus. Thank for all you and all the other contributors do!

[amber wedge]

I can do this

[amber wedge]

Ok done. /franken unit_addhas now a flag allow_duplicates:which prevents removal of duplicate unit types.

[meager temple]

Praise be!

[woven plover]

This is awesome! Now that the bot supports it, is there a way to visualize it on the map? Maybe show both unit 'cards' when hovering over the flagship/mech?

[reef flicker]

Oh for the hovers?? That would take a little effort I think

[woven plover]

It would lay the ground work for dual sided units like nra mech

[amber wedge]

But what about games that have 3 units? Or 4? Or.... 🫠

[woven plover]

Obviously you are aware that the community is going to do such absurdities, lol

Wait i can have 4 flagships now?!?

[reef flicker]

@mortal kraken what do you think? 🤔

Basically supporting overlapping hover regions

Seems like it should be easy enough right?

[mortal kraken]

like displaying two cards on the same hover region?

[reef flicker]

Yeah

See the post I had replied to for example

On the Java side I'm imagining just having the exact same hover region but with multiple cards defined

[meager temple]

For our standard flexi and overdraft games, we only need two. I'm not sure if there's anyone who's trying to do more

[reef flicker]

I figure it's just as easy to do 10 as it is to do 2, so I'm just requesting the generic version

[reef flicker]

2 is fine, 10 is cooler 😉

I'm not sure if you would want 5 separate regions that all overlap but with separate data, or if you'd want to make the data section an array instead of single

Obviously there's benefits to both

-# Or just defer this until web 2.0 is ready

[mortal kraken]

the only one that would work is array data

overlapping regions if rendered wouldn't work html wise

only one would trigger

[reef flicker]

Gotcha