so hey kinda new to minecraft datapack and not sure how the potion id works

[grizzled maple]

so I am trying to give a achievement for each potion that is in game but i can seem to get it to work if anyone know the fix i would love the help

{
"parent": "collectlog:production/alchemy/root",
"display": {
"icon": {
"id": "potion[potion_contents=water]",
"components": {
"minecraft:enchantment_glint_override": false
}
},
"title": "Water bottle",
"description": "Collect a water bottle.",
"background": "minecraft:block/oak_log",
"frame": "task",
"show_toast": false,
"announce_to_chat": false
},
"rewards": {
"function": "collectlog:advancement/cooking/check"
},
"criteria": {
"collected": {
"trigger": "minecraft:inventory_changed",
"conditions": {
"items": [
{
"items": "potion[potion_contents=water]",
"count": {
"min": 1,
"max": 64
}
}
]
}
}
}
}a

[light turret]

You're trying to check components in the way commands check them, but this is a predicate. the item ID needs to just be the item ID, and then you need to check/add components with the components or predicates fields

Make sure you're using Misode

[grizzled maple]

thank you that helped i did not know that i need to do it that way it works now ^^