#custom music disc in 1.21.5
1 messages · Page 1 of 1 (latest)
<@&1201956957406109788>
💬 While you wait, take this time to provide more context and details.
🙇 If nobody has answered you by <t:1746126317:t>, feel free to use the Summon Helpers button to ping our helper team.
✅ Once your question has been resolved (or you no longer need it), please click Resolve Question or run /resolve
my thinking is its me fillin in the jukebox_playable wrong
this is my current attempt
minecraft:justin_bieber_baby
that is not a recipe or a song defenition?
?
you didn't give us the jukebox_playable song file contents nor the recipe
are u asking for it?
yea we need that inorder to point out where you made a mistake
we don't know without more context
i understand that
u could like politely ask for more info then mabe
{
"type": "minecraft:crafting_shapeless",
"category": "misc",
"ingredients": [
[
"minecraft:pink_dye"
],
[
"minecraft:music_disc_5"
],
[
"minecraft:amethyst_shard"
]
],
"result": {
"id": "music_disc_5",
"components": {
"minecraft:custom_name": "bieber",
"minecraft:jukebox_playable": "minecraft:\"justin_bieber_baby\""
},
"count": 1
}
}
well srry that might have come over a bit harsh but it wasn't meant to be I was just a little confused
very true
Just saying custom music can only be played if its in a custom resource pack.
Then set jukebox_playable to your custom music file inside your resource pack and I'm pretty sure it should work.
you have to use "minecraft:jukebox_playable":"minecraft:justin_bieber_baby" instead
trying it
ur right i got a resourcepack set up for it
im still not getting anything
take a look at your logs
When making or debugging Minecraft datapacks, it is useful to have the Minecraft logs open in order to view errors quickly.
To open the logs:
- Enable the logs in the Minecraft Launcher (see image)
- Start Minecraft
The logs should open in a separate window. Datapack errors are shown in the when you /reload and are almost always in red text or yellow text.
gives an error here
[21:02:16] [Worker-Main-202/ERROR]: Couldn't parse data file 'new_music:custom/justin_bieber_disc' from 'new_music:recipe/custom/justin_bieber_disc.json': DataResult.Error['Failed to parse either. First: Failed to get element minecraft:justin_bieber_baby; Second: Cannot parse as key without registry missed input: {"minecraft:jukebox_playable":"minecraft:justin_bieber_baby"}': net.minecraft.class_1867@7046dd96]
ill upload the whole thing
man all i find is for 1.21.4 and evrey1 seems to use the old advancement way
can you give me a quick summary of the current state of the problem?
the main issue is not being able to craft my custom recipe
im trying to make a custom music disc
not part of the main problem but I suggest using the "stream": true option in the sounds file
like that
and the reason why it doesn't work for you is bcause you only added the sound and a recipe for the music disc but not the jukebox song (that's its own thing)
the file needs to be here: namespace:jukebox_song/<filename>.json
and it has to look something like this:
(description is the text that gets displayed when you put the disc in the jukebox)
where does this file go?
in the datapack or resourcepack
datapack
its this file i made right
{
"comparator_output": 1,
"description": "Justin Bieber - Baby",
"length_in_seconds": 219.0,
"sound_event": {
"sound_id": "minecraft:justin_bieber_baby"
}
}
its in data > new_music > jukebox_song
is it cause the description is different?
in the jukebox component of the recipe you have to use the id of that file and not the sound file
so change minecraft:justin_bieber_baby to new_music:justin_bieber_baby
in the recipe
alright
ive seen there could be an error with the generator i use in the name of the item
if i want spaces in the name how would i write that
does this work?
"[{'text':'Justin Bieber - Baby','color':'dark_purple'}]"
idk how strict mc is with the ' and " but i know that it works with them reversed.
although the keys (text, color) are not in quotes since 1.21.5
its kinda hard to tell where to place this from this screenshot
songs.json
right its in songs.json but im not sure where to place it in text
could u show me the whole file
that won't make any sense, it's the same over and over again. Just put "stream":true where I put it in my file.
i get that if u have multiple songs there are multiple of these
the structure is the same
my issue is that its diffecult to know where exactly to put it cause evrething else is cropped out of the photo
let me try
{
"comparator_output": 1,
"description": "Justin Bieber - Baby",
"length_in_seconds": 219.0,
"sound_event": {
"sound_id": "minecraft:justin_bieber_baby"
},
"music_disc.lore": {
"sounds": [
{
"name": "new_music:justin_bieber_baby",
"stream": true
}
]
}
What?
We already established that the jukebox file goes in the DATApack
and I told you the path too
and it is it's own file
ok ty
you already had the songs.json file and the olny thing you had to do was add this single line => "stream": true
so if this is the contence of the file i have here i need to replace it with wat u wrote?
no, that is all that you need in the jukebox file. nothing else. also don't overwrite anything with that.
if you have that, you need to change the id in the recipe file to that of the jukebox file.
change it like this
thats the recipe file yes
and i have changed it according to instrusctions
{
"type": "minecraft:crafting_shapeless",
"category": "misc",
"ingredients": [
[
"minecraft:pink_dye"
],
[
"minecraft:music_disc_5"
],
[
"minecraft:amethyst_shard"
]
],
"result": {
"id": "music_disc_5",
"components": {
"minecraft:lore": "[{text:'Justin Bieber - Baby'}]",
"minecraft:jukebox_playable": "new_music:justin_bieber_baby"
},
"count": 1
}
}
as u can see
"minecraft:jukebox_playable": "new_music:justin_bieber_baby"
should work now
not getting an output on the right ingreidince
oh u meant the sounds file
for the stream addtion
{
"music_disc.justin_bieber_baby": {
"sounds": [
{
"name": "records/justin_bieber_baby",
"stream": true
}
]
}
}
my new sounds.json
hm
still no cigar
cya tommorow
does the current example pack have a recipe with components?