limpid ginkgo
is there a way to stop a skeleton from shooting temporarily (for like a few seconds) without removing its ai or its bow?
I don't want to remove it's ai because that disables gravity for the mob, and I don't want to remove the bow because it will look jank.
I'm trying to add a cool down to how fast skeletons can shoot arrows, and this would make it incredibly easy if it's possible.
lucid flickerBOT
is there a way to stop a skeleton from shooting temporarily (for like a few seco...
<@&1201956957406109788>
wind knot
There is no real way to achieve this (other than what you mentioned) so it will always come with some jank
You could use teams with friendly fire turned off, then skeletons are passive to players in the same team
But entities can only be In one team at a time, so teams are always bad for comparability
You can also try setting its follow distance to 0 but iirc that won’t stop skeletons who are already locked onto you
limpid ginkgo
You can also try setting its follow distance to 0 but iirc that won’t stop skele...
oh crap that might actually work. I forgot you can do that. aggro range and follow range were merged so I think follow range of 0 could deaggro
I'll have to check it when I get home
supple fox
maybe changing the bow to a different item with the item_model of a bow?
limpid ginkgo
maybe changing the bow to a different item with the item_model of a bow?
would that require a resource pack?
supple fox
maybe changing the bow to a different item with the item_model of a bow?
but the skeleton will start running after you cause it switches to melee so you prob want to slow it down some way aswell or something
wind knot
would that require a resource pack?
Not anymore in the newer versions, no
Should work in 1.21.3+ iirc
timid bramble
I never tried, but would a skeleton use it's bow if you move it to it's off hand
I know some skeletons can be left handed, but in this case I think their left hand counts as their main hand
Test it if you want, if it works then you can move the bow to the skeletons off hand
oh i just read what you want
well removing the bow or even disabling it will cause the skeleton to charge at you like a zombie, im not sure that's what you are aiming for
Try and test what happens if you take the bow out of the skeleton's hand and return it quickly when it's trying to shoot
jaunty folio
Give it a different item that uses the bow's item_model
timid bramble
sadly they're on 1.21.1
mental bluff
maybe switch the skeleton's main hand to force it into melee mode?
limpid ginkgo
i got around to trying some of this stuff
follow range: setting follow range to 0 works, but causes glitchy behavior and the skeleton will constantly raise and lower its bow while chasing the player
item model: doesn't work on 1.21.1
switching the skeleton's main hand: interrupts firing, but only for a tiny fraction of a second. the bow switches to the new main hand and the skeleton continues shooting. i'm not 100% sure if there is a way to manually switch the bow from one hand to the other at the same time, while keeping all of the bow's enchants and other properties in-tact.
it seems that if i disable and reenable the skeleton's ai on every tick, he act like friend and keeps his gravity
it would be cool if it would let the skeleton keep its bow raised for this though
im not sure if that would be possible with any solution though, i think making the skeleton non-aggroed always makes it lower the bow
limpid ginkgo
it seems that if i disable and reenable the skeleton's ai on every tick, he act ...
one thing that does concern me though, is im not 100% sure what this is doing
if im disabling and re-enabling the skeleton's ai all on the same tick, every tick, is the skeleton ai doing a bunch of unnecessary calculations? like what if it creates a new path to the target player every time this happens (pathfinding can be expensive)?
jaunty folio
It is expensive but mostly because you're modifying NBT, which isn't very performant. That's also the reason for the behavior, when you modify an entity's NBT repeatedly they kinda stop behaving
In lieu of changing the item model, just give them a new item with custom model data to make it look like a bow
jaunty folio
Custom model data does
limpid ginkgo
oh wait
when you spawn an item with a unique number that a texture pack recognizes and replaces the texture of the item?
jaunty folio
That is an accurate description of the behavior of custom model data
limpid ginkgo
i was planning to make this a standalone datapack, this would be the one and only feature to require any kind of resource pack
jaunty folio
Then you need to deal with the other jankier solutions offered
limpid ginkgo
i suppose first i should just see what the performance impact is of disabling and enabling the ai
limpid ginkgo
the impact is that the datapack takes 3.5% of each tick on average instead of the original 2%
im not sure, but it doesn't sound that bad
wind knot
i got around to trying some of this stuff
**follow range:** setting follow rang...
Switching the bow to the other hand is very easy actually
You can use item replace … from … to copy the bow from its mainhand to its offhand and then you can use item replace … with air to delete the bow in its mainhand.
And ofc the other way around when switching back.
This solution will very likely be a lot better in terms of performance compared to modifying its nbt every tick (if that’s what you are doing instead).
limpid ginkgo
ooohhh
i did not know about that command
thank you i bet this will work :]
will try it now
is there any place i can store an item in limbo temporarily?
i would ideally want to keep whatever item might be in the offhand
wind knot
That’s more difficult
You can either have an item display somewhere and store the item there
Or you can use a macro to swap the items in place
But if you are not sure if the bow has custom components at all, that would be an extra check and a macro, probably still better than an extra entity
limpid ginkgo
do macros exist on 1.21.1?
wind knot
function ~/swap_hands_macro:
item replace entity @s weapon.offhand from entity @s weapon.mainhand
$loot replace entity @s weapon.mainhand loot {"pools":[{"rolls":1,"entries":[{"type":"minecraft:item","name":"$(id)","functions":[{"function":"minecraft:set_count","count":$(count)},{"function":"minecraft:set_components","components":$(components)}]}]}]}
# and then you can use this as the skeleton to swap items
function ~/swap_hands_macro with entity @s HandItems[1]
This is using an inline loot table that is filled with the id, count and components of the item stack the skeleton is holding in the offhand
This would fail if the offhand item has no components
So you'd need to check that first, and run the same function without the "components" part in the loot table instead
There may be some small errors in the code I sent, I’m on phone lol
limpid ginkgo
so if the first line replaces the offhand with the mainhand, how does it remember what the mainhand used to be?
is it storing that somewhere? there's not really any commands above that
wind knot
All the macro variables ($(variable_name)) get replaced when the function is called
So it doesn’t matter if the source of these variables is replaced inside of the macro function
So - Yesn’t, they are not stored but when the function is called they are placed in the commands and not loaded again
limpid ginkgo
ahhh ok
limpid ginkgo
item replace entity @s weapon.offhand from entity @s weapon.mainhand
execute unless items entity @s weapon.mainhand * run return fail
$loot replace entity @s weapon.mainhand loot {"pools":[{"rolls":1,"entries":[{"type":"minecraft:item","name":"$(id)","functions":[{"function":"minecraft:set_count","count":$(count)},{"function":"minecraft:set_components","components":$(components)}]}]}]}
so far i have this
it doesn't seem to work though, sometimes items exist but don't have components somehow...?
well, also it says HandItems is not an element
i'm confused though, because it should exist
oh bruh ive been testing this on 1.21.5, i thought i was on 1.21.1 rn 😭
i am trying to support all current versions along with 1.21.5 though
so ideally i get it working for both
wind knot
well, also it says HandItems is not an element
You can check using data get entity <SKELETON> … how HandItems looks.
Id do the checks beforehand, so in pseudo code:
if offhand has components -> return run swap with components
if offhand has no components -> return run swap without components
And then have 2 macro functions, one with the whole components block and one without, so a really small loot table or even an item replace, since you only need the id and count
wind knot
i am trying to support all current versions along with 1.21.5 though
I would advise against that, minecraft is changing so much in minor versions since they changed how they approach versions
If you still want to support multiple, you may use overlays, these are files that are loaded if the client is using a specified version of minecraft
limpid ginkgo
I would advise against that, minecraft is changing so much in minor versions sin...
it's been annoying, but no massive breaking changes so far. main thing i had to change was using generic.attack_damage instead of attack_damage etc.
ive been using overlays for it
hm
it seems there have been some big changes to held item nbt though
wind knot
Not really, it’s just all in equipment.<slot> instead of HandItems and ArmorItems
limpid ginkgo
equipment: {mainhand: {id "minecraft:bow", count:1 }}
i think this also means i have to send different info into the macro function ...?
im still not fully understanding how they work, ive read the documentation but its kind of hard to understand
wind knot
Yeah, the macro functions themselves (if you do the checks outside of them) should be the same but how you check the nbt and how you give the nbt into them is different since the path changed
limpid ginkgo
i would expect to be able to write something like this:
item replace entity @s weapon.offhand from entity @s weapon.mainhand
execute if data entity @s equipment.mainhand.components run return run $loot replace entity @s weapon.mainhand loot {"pools":[{"rolls":1,"entries":[{"type":"minecraft:item","name":"$(id)","functions":[{"function":"minecraft:set_count","count":$(count)},{"function":"minecraft:set_components","components":$(components)}]}]}]}
$loot replace entity @s weapon.mainhand loot {"pools":[{"rolls":1,"entries":[{"type":"minecraft:item","name":"$(id)","functions":[{"function":"minecraft:set_count","count":$(count)}]}]}]}
but it doesn't like when i move $loot to a different place
im not sure why
it stops the function from being validated so i cant run it
limpid ginkgo
oh
wind knot
Also - it’s generally better to have smaller macro commands and function since all macro commands need to be parsed at runtime
limpid ginkgo
i had a fundamental misunderstanding, i thought that was just how you chose a variable name 😭
wind knot
Also - it’s generally better to have smaller macro commands and function since a...
But that may be a point to worry about later
wind knot
i had a fundamental misunderstanding, i thought that was just how you chose a va...
Both ^^
$ at the start to indicate a macro command and $() to indicate a variable
limpid ginkgo
ahh
wind knot
$say THIS IS A MACRO COMMAND, THIS WHOLE THING, BUT A VARIABLE IS $(this)
limpid ginkgo
so this is my swap handitems file (no components version)
$loot replace entity @s weapon.mainhand loot {"pools":[{"rolls":1,"entries":[{"type":"minecraft:item","name":"$(id)","functions":[{"function":"minecraft:set_count","count":$(count)}]}]}]}```
and this is my toggle bow file:
function betta_balance:swap_handedness
execute if data entity @s equipment.mainhand.components run return run function betta_balance:swap_handitems_with_components with entity @s equipment.mainhand
function betta_balance:swap_handitems with entity @s equipment.mainhand
there are no errors, but nothing happens
wind knot
Hm, that looks pretty correct on first glance
teal totemBOT
wind knot
The logs are probably quickest to spot errors
Though watch out, all errors are printed when loading the pack but macro errors are printed on execution
Also, you can try running the swap command through chat
To see the error in chat directly
limpid ginkgo
oh i meant in logs
there arent any errors
none when i run the commands manually either
wind knot
Hm, maybe try adding say commands to see if the correct stuff executes
And also to give out macro variables
limpid ginkgo
so as far as i can tell, literally everything is functional, and the macros have the right values, it's just this line specifically that doesn't do what it's supposed to: $loot replace entity @s weapon.offhand loot {"pools":[{"rolls":1,"entries":[{"type":"minecraft:item","name":"$(id)","functions":[{"function":"minecraft:set_count","count":$(count)},{"function":"minecraft:set_components","components":$(components)}]}]}]}
it's weird, because when i run the command with the same formatting on a specific skeleton, just without the macroed loot table, i can give skeletons acacia logs, swords, etc in their offhand
it just doesn't seem to work with the in-line loot table
maybe loot replace doesnt work for air?
yeah ok, that seems to be the case...
i tried it out manually
it says 0 item dropped, which i guess makes sense
so it didnt replace anything
wind knot
Mhm, you can probably solve this using a item replace with air before calling the loot table
That way the item gets deleted if the macro fails/drops nothing
limpid ginkgo
ahh ok
wind knot
assuming that is the intended behavior
limpid ginkgo
oh
so its working now
and i feel like ive learned a lot
but i guess i should have checked first if putting bow in offhand and making the skeleton other handed actually disabled the bow 😭
it does not
the skeleton uses the bow like usual, with the only change being that it uses the old skeleton bow holding animation instead of the new one
although... that is pretty neat and fits with the vibe of my datapack
so at this point, as far as im aware, my only real option is to constantly disable/reenable the skeleton's ai, or put the skeleton and the player on the same team (but this seems messy, could have bad compatibility, and also would make the skeleton visibly lose interest in the player for a brief period of time)
or maybe i can combine other-handedness with a follow range of 0? the only glitchy thing about the 0 follow range was the glitched animations, but maybe this fixes that...
wind knot
but i guess i should have checked first if putting bow in offhand and making the...
Oh nyo 😭 atleast you know how to swap hands with a macro now ^^
wind knot
That’s sad
limpid ginkgo
Oh nyo 😭 atleast you know how to swap hands with a macro now ^^
macros in general seem really useful, so i dont entirely regret learning about them
i think i now know how to use them for other things
so i guess maybe i should try to find the minimum delay with which a skeleton can pull back a bow and shoot an arrow, and at that exact interval i should disable and re-enable the skeleton's ai
i assume they can't shoot in the same tick after getting their ai back
limpid ginkgo
if i swap handedness and the items 1 tick after a skeleton spawns, i can make its nbt tags say that nothing is in its mainhand, meanwhile it is holding bows in both hands and using the mainhand bow on me
not sure why that is
it works if i wait for a while after the skeleton spawned
limpid ginkgo
so i guess maybe i should try to find the minimum delay with which a skeleton ca...
nvm actually, i dont think you can keep context when scheduling a function...
wind knot
nvm actually, i dont think you can keep context when scheduling a function...
No you don’t but you can "fake" it.
# right_now
execute store result score @s scheduled_as_entity run schedule function #3_seconds_after 3s
# 3_seconds_after
execute store result score .gametime scheduled_as_entity run time query gametime
execute as @e if score @s scheduled_as_entity = .gametime scheduled_as_entity run say I SCHEDULED THIS 3 SECONDS AGO
If you schedule a function, it returns the gametime at which it will run
This should be further optimized using predicates and tags but this should server as an explanation of the tech