Help! my function isnt running when it is supposed to | Datapack Hub | Page 1

eager parcel Feb 1, 2025, 5:19 AM

#

Basically, this is being run every tick:

scoreboard players add @a[tag=travelling,tag=teleported] grounded_for 1
execute as @a[tag=travelling,tag=teleported] if score @s grounded_for >= .const groundedconst run function testing:priv/teleport/landed```

this checks for how long the player has been grounded for. once this score reached above "groundedconst"  which is an arbitrary value, it is meant to run the function "landed"

title @a title "GROUNDED"
$title @a[tag=travelling,tag=teleported] title ["",{"text":"$(title)","color":"dark_red"}]

scoreboard players set @a[tag=travelling,tag=teleported] grounded_for 0
tag @a[tag=travelling,tag=teleported] remove teleported
tag @a[tag=travelling] remove travelling```

which looks like this. however, the function landed is never run, why is this?

odd auroraBOT Feb 1, 2025, 5:19 AM

#

eager parcel Basically, this is being run every tick: ``` scoreboard players add @a[tag=trave...

#

<@&1201956957406109788>

Someone will come and help soon!

💬 While you wait, take this time to provide more context and details.

🙇 If nobody has answered you by <t:1738388979:t>, feel free to use the Summon Helpers button to ping our helper team.

✅ Once your question has been resolved (or you no longer need it), please click Resolve Question or run /resolve

vestal storm Feb 1, 2025, 5:20 AM

#

Can you use code blocks please? ``` before and after

eager parcel Feb 1, 2025, 5:21 AM

#

vestal storm Can you use code blocks please? \`\`\` before and after

there you go

#

the score increases but it doesn't actually run the function

vestal storm Feb 1, 2025, 5:22 AM

#

I'm not super experienced with macros, but I'm assuming it's not running because you have a macro line, but aren't running the function with any additional data for the macro to use

eager parcel Feb 1, 2025, 5:23 AM

#

the macro is inherited from a previous function where I set that data

vestal storm Feb 1, 2025, 5:23 AM

#

I don't think that's how macros work

#

But you can check the logs when you load the data pack and see if you get any errors

eager parcel Feb 1, 2025, 5:23 AM

#

well I set my macro values in one function and use their values in multiple other functions and it's fine

eager parcel Feb 1, 2025, 5:23 AM

#

vestal storm But you can check the logs when you load the data pack and see if you get any er...

where do i see the logs

jovial tigerBOT Feb 1, 2025, 5:23 AM

#

Logs

When making or debugging Minecraft datapacks, it is useful to have the Minecraft logs open in order to view errors quickly.

To open the logs:

Enable the logs in the Minecraft Launcher (see image)
Start Minecraft

The logs should open in a separate window. Datapack errors are shown in the when you /reload and are almost always in red text or yellow text.

eager parcel Feb 1, 2025, 5:26 AM

#

ok so it was the macro line

#

but why, I have another function in the same folder that says this:

$tellraw @p[tag=this] {"text":"[$(title)]\n$(description)"}

and uses the title macro seperate from where it's value was set

queen agate Feb 1, 2025, 5:29 AM

#

the macro function always needs to be called either as function ... with ... or as function ... {foo:bar} in order to have its value keys set. so how are you calling the function in that case?

eager parcel Feb 1, 2025, 5:30 AM

#

the values are set here:

$summon interaction ~ ~ ~ {Tags:["travel"],Passengers:[{id:marker,data:{x:$(x),y:$(y),z:$(z),time:$(time),title:"$(title)",description:"$(description)",display:$(display),custom_model_data:$(custom_model_data)}}]}
$summon minecraft:item_display ~ ~.75 ~ {item:{id:"minecraft:$(display)",count:1,components:{"minecraft:custom_model_data":{strings:['$(custom_model_data)']}}},Tags:["travel_display"]}

this is all that is in this function

#

execute as @a[tag=travelling] at @s if predicate testing:looking_at run return run function testing:priv/look/who_look

# Reset timer if player is not looking
scoreboard players reset @a tp_timer
execute positioned as @e[tag=travel,limit=1] run effect clear @p[tag=travelling] minecraft:slowness
execute positioned as @e[tag=travel,limit=1] run effect clear @e[type=item_display,tag=travel_display] glowing
tellraw @p[tag=travelling] {"text":"    \n    \n    \n    \n    \n    \n    \n    \n    \n    "}
execute as @a[tag=travelling,tag=teleported] at @s if predicate testing:is_falling run effect give @s resistance 3 255 true
execute as @a[tag=travelling,tag=teleported] at @s if predicate testing:is_grounded if score @s grounded_for < .const groundedconst2 run function testing:priv/teleport/landed_detection

this function runs constantly

#

if im looking at the entity, then it calls the

$tellraw @p[tag=this] {"text":"[$(title)]\n$(description)"}

#

so it's not like the setter function calls the tellraw command

#

OH

#

you said use "with:

#

i didnt do that, my bad

#

well it still wont run that line

#

im not sure

#

in the case here:

execute unless score @p[tag=this] tp_timer matches 1.. on passengers \
    run function testing:priv/teleport/description_macro with entity @s data
``` @s refers to the interact entity carrying the data

eager parcel Feb 1, 2025, 5:48 AM

#

queen agate the macro function always needs to be called either as `function ... with ...` o...

I attempted this and it did not work

#

scoreboard players add @a[tag=travelling,tag=teleported] grounded_for 1
execute if score @a[tag=travelling,tag=teleported,limit=1,sort=arbitrary] grounded_for >= .const groundedconst on passengers \
    run function testing:priv/teleport/landed with entity @e[type=interaction,tag=filter,limit=1,sort=arbitrary] data

I attempted to retrieve the data from the entity

#

and there is still an issue

queen agate Feb 1, 2025, 5:51 AM

#

well that one won't work because interaction entities don't have a data field. the entity with your data is a marker

eager parcel Feb 1, 2025, 5:51 AM

#

oh right, i see

eager parcel Feb 1, 2025, 6:00 AM

#

queen agate well that one won't work because interaction entities don't have a `data` field....

scoreboard players add @a[tag=travelling,tag=teleported] grounded_for 1
execute positioned as @e[type=interaction,tag=filter] if score @a[tag=travelling,tag=teleported,limit=1,sort=arbitrary] grounded_for >= .const groundedconst on passengers \
    run function testing:priv/teleport/landed with entity @e[type=marker,limit=1,sort=nearest] data

this is what I am trying to use now

#

execute positioned as the interaction object the player is looking at with the data from the closest market which should be the marker with the correct data

#

it doesn't work still however

queen agate Feb 1, 2025, 6:03 AM

#

i'd recommend trying that function command directly in chat to see if it returns any errors

eager parcel Feb 1, 2025, 6:06 AM

#

im using a modrinth profile and cant seem to find how to enable logs for datapacks

queen agate Feb 1, 2025, 6:10 AM

#

when you click on your instancce profile there should be a pair of tabs right at the top

eager parcel Feb 1, 2025, 6:11 AM

#

then there are no errors

queen agate Feb 1, 2025, 6:11 AM

#

my recommendation would just send an error in chat, however.

eager parcel Feb 1, 2025, 6:11 AM

#

I was looking at those logs

queen agate Feb 1, 2025, 6:12 AM

#

if you run just /function testing:priv/teleport/landed with entity @e[type=marker,limit=1,sort=nearest] data from chat what happens (getting close to the marker, obviously)

eager parcel Feb 1, 2025, 6:13 AM

#

let me try

#

I get nothing

#

if I run data get, the market has the data there

#

$title @a[tag=travelling,tag=teleported] title ["",{"text":"$(title)","color":"dark_red"}]
am I just calling the title command wrong?

#

I cant be because when I run it seperately it is fine

queen agate Feb 1, 2025, 6:20 AM

#

the title command itself should be fine. i'd say verify the tags in the selector but i can't see how that could be the issue either.

eager parcel Feb 1, 2025, 6:20 AM

#

the marker has the required data when i check

#

so that shouldnt be a concern

#

I think it is an issue with the title command because I replaced it with tellraw and it works fine

#

ok i just uncommented the original title command, ZERO CHANGES

#

and suddenly it is working

queen agate Feb 1, 2025, 6:26 AM

#

well, you'll have that sometimes. but if it's working now then that's the important part

eager parcel Feb 1, 2025, 6:27 AM

#

thanks foir your helkp, sorry that was difficult, so confused haha

#Help! my function isnt running when it is supposed to