I am trying to write an advancement in a datapack which detects when a player dies to anything (entity, fall, anvil etc) but I cannot see how to do it
#Advancement death to anything detection
silent bobcat
"criteria": {
"requirement": {
"trigger": "minecraft:entity_killed_player"
}
},
"rewards": {
"function": "trimeffect:death"
}
}```ok right yep sounds good thanks
silent bobcat
The criteria is `deathCount`
wait so can I integrate that scoreboard into the advancement or no?
old jasper
No, you would have to check the scoreboard value in your tick function
tropic cosmos
You can maybe use an entity_hurt_player advancement and check if their health is 0
entity_hurt_players triggers for all damage
silent bobcat
yeah thanks
silent bobcat
You should use a scoreboard for this
Now I am having a problem with giving myself a potion and trying to clear the glass bottle at the same time can you help?
old jasper
What do you mean by that?
silent bobcat
basically i want the player to be able to drink a potion which they can craft and then it changes a scoreboard value, which I did, and then you can a potion to remove a scoreboard value (differnet data) but the issue I am having is that I cannot clear the bottle from the players inventory in time after the potion has been drank so you can effectively dupe bottles
scoreboard players remove @s trimeffect.life 1
give @s minecraft:potion[potion_contents={potion:"minecraft:water",custom_color:13046290},custom_name='["",{"text":"Bottled Life","italic":false}]',custom_data={bottled:1}] 1
clear @s minecraft:glass_bottle 1```https://medal.tv/games/minecraft/clips/iicz52JSb4V9z9gAs/d1337dHT5pEs?invite=cr-MSxtN3AsMjY3NDk4MzUs Heres an example of the issue
I am giving a bottle to make it easier but it doesnt get rid of the bottle from the other potion if you see what i mea
old jasper
The bottle may not actually appear in your inventory until the next tick
You might need to wait one tick to clear it
silent bobcat
You might need to wait one tick to clear it
how can i do that?
old jasper
I guess give yourself a tag, like has_glass_bottle, and then check for that in the tick function, and clear it
silent bobcat
righ tok
silent bobcat
I guess give yourself a tag, like `has_glass_bottle`, and then check for that in...
how can I modify this recipe to make the redstone require the custom data {life:1}?
"type": "minecraft:crafting_shaped",
"pattern": [
"#P#",
" G "
],
"key": {
"#": {
"item": "minecraft:redstone"
},
"P": {
"item": "minecraft:potion"
},
"G": {
"item": "minecraft:glowstone_dust"
}
},
"result": {
"id": "minecraft:potion",
"components": {
"custom_name": "[\"\",{\"text\":\"Empty Life Bottle\",\"italic\":false}]",
"custom_data": "{bottled:0}",
"minecraft:potion_contents": {
"potion": "minecraft:water",
"custom_color": 1835113
}
}
}
}```You can't. Checking components in recipe inputs isn't supported
silent bobcat
ah ok thanks
silent bobcat
You can't. Checking components in recipe inputs isn't supported
Do you know what I've done wrong here with this command, its not working
Its meant to say hello if I have a glass bottle in my hand
/execute if data entity Adcock SelectedItem[{id:"minecraft:glass_bottle"}] as @a run say hello
silent bobcat
ah thank you
silent bobcat
`SelectedItem` is not an array
What have i done here?
"type": "minecraft:crafting_shaped",
"pattern": [
"#T#",
"SJP",
"#A#"
],
"key": {
"#": {
"item": "minecraft:end_crystal"
},
"T": {
"item": "minecraft:trident"
},
"S": {
"item": "minecraft:shaper_armor_trim_smithing_template"
},
"J": {
"item": "minecraft:totem_of_undying"
},
"P": {
"item": "minecraft:sentry_armor_trim_smithing_template"
},
"A": {
"item": "minecraft:turtle_helmet"
}
},
"result": {
"id": "minecraft:potion",
"components": {
"custom_name": "Life bottle",
"custom_data": "{life:1}",
"minecraft:potion_contents": {
"custom_color": 1835113
}
}
}
}```Custom name is wrong
It takes a json text component, so it needs to be "\"Life bottle\""
silent bobcat
ah thanks
hollow pawnBOT