The knowledge book is generally used for custom items, since you can't generate non-vanilla items using recipes. What are you trying to do and what are the recipe json file contents?
#when i make the recipe it gives me knoeleg book and dont give my the item
thorn axle
mellow stag
Make sure the advancement is revoked by doing /advancement revoke @s only ... in chat
thorn axle
There's a warning in give_item1 code (I'm assuming that is the first image), specifically on the second line, on the advancement revoke name. Usually this happens when you type the advancement name and path wrong, or the advancement is not in the right folder
Other than that, I'd try removing all the code in the give_item1 function and replace it with something like say item1 advancement granted , just to see if it runs at all
Just remember to revoke the advancement beforehand by typing it in the chat
sick pelican
which version are you on?
sick pelican
Okay, show the path to your achievement
thorn axle
Where the file is located inside the datapack folder. So like datapack_name/data/advancements/item1.json
thorn axle
Then the name if your advancement is item1advancement, not item1adv . That line should be advancement revoke @s only item:item1advancement
sick pelican
in this function you have the name item1adv written, but the achievement itself is called item1advancrmet. rename both just to item1
take another screenshot of the entire VS Code
ah, achievements should be in the "advancements" folder, you are missing the "s"
plural
thorn axle
Also in the achievement file: I've never seen "unlocked" inside a condition. That should definitely be "requirement"
sick pelican
Also in the achievement file: I've never seen "unlocked" inside a condition. Tha...
false
sick pelican
Is this legacy stuff?
you can have any name there
thorn axle
you can have any name there
Oh you're right, it's the criteria name. Confused with the "requirements"
crisp oasis
can you take a screeshot of your recipes?
sick pelican
where did you get these item IDs? there is no fireworks item in minecraft
what kind of website generator did you use
mellow stag
Use the right item identifiers and everything should work fine
obtuse mulch
You could go ingame, press F3 and H, then open your inventory and hover over an item
underneath the regular name should be the id
The id is in the form of minecraft:something
thorn axle
VScode should also suggest you all valid possibilities while you are typing
obtuse mulch
No, hover over the ingredients, the id of a stick is minecraft:stick as you can see