#Paintings as items

1 messages · Page 1 of 1 (latest)

echo willow
#

Vanilla boom adds painting items in newer versions and is GPL licensed. What I am proposing is that the painting item feature be backported with the other stuff stripped from the mod. Json paintings (non vanilla paintings at least), villager trade tables and loot table support required. i.e format: mod:itemid + nbt data. Json paintings painting items cant be easily used in trades or loot which is why this request is being made

Starting price $30

#

Vanilla boom feature port

#

@rain goblet

golden nebula
#

if it helps this is the earliest version that had them

rain goblet
#

@echo willow So what exactly is wanted for this port, paintings alone? Should it be a fork or an own mod?

echo willow
#

i.e I want to be able to add individual custom and vanilla paintings to loot and villager trades.

#

I dont need anything else from that mod

#

So functionally it is its own mod

#

Json paintings adds painting items too but the problem is that it does so in a way that doesnt differentiate them via nbt or the mod:item id so it is virtually impossible to add them to trades or loot

#

Jbredwards said it uses forge capabilities and it isnt clear how to add those items to loot or trades

rain goblet
#

Understood! Can cook something up. merlinmolethimcook

echo willow
#

Thanks

frigid night
#

Oh, found the thread. So yeah, I would probably still use JSONpaintings over this because of the way it works.

  • It uses the painting selection GUI
  • You can define which ones are accessible and which have to be obtained
  • They have compatibility with events for doing some crazy things
  • Can define the side and background textures individually
  • Flexible naming convention
  • Probably other things I'm forgetting
echo willow
#

The intent is to support custom paintings not require the use of any specific mod to add paintings

#

Paintings as items

#

I regret mentioning that mod lol

golden nebula
#

yeah if i have to be honest i was kind of confused by that part because its like 1 of 20 features

rain goblet
#

If JSON Paintings is using vanilla's painting enum, this should work for both vanilla and JSON Paintings added paintings. peek

echo willow
#

Guess well have to test it but good to hear

frigid night
#

That sounds great if it works for everything. Stuff like Recurrent Complex's loot "tokens" can capture the paintings, but being able to use them simply with NBT, as well as pre-visualizing them would be really useful. I would like to have this too.

echo willow
#

Yep

rain goblet
#

@echo willow Alright, the mod is like 90% done. Only one item is registered and the distinguishing logic is handled via NBT. Also works with JSON Paintings if installed, tested with RotN's large painting set.

Repository is available here, along with an up-to-date test build here.

Last major step would be rendering the paintings as their actual motives which is (too) hard, I'm afraid.

echo willow
rain goblet
echo willow
echo willow
rain goblet
#

It is, shame! DinkDonk

echo willow
#

Well nice to know Im not crazy lol

rain goblet
#

Yeah, working on it. 😉

echo willow
#

I like how these are just automatically generated. No messing with config, it just works in that way

#

Easy to hide the vanilla painting item too.

rain goblet
#

Yeah, it's meant to be used out of the box!

echo willow
#

No wonder youre most peoples go to lol

rain goblet
#

@echo willow New build is available, happy testing! jinjaHypu2

echo willow
#

After lunch ill try it

rain goblet
echo willow
rain goblet
echo willow
rain goblet
#
  • tips of course GuraLaSmug
#

It's fine. 😉

echo willow
#

Oh yeah you use euros, 30 euros it is

rain goblet
#

Arrived! 🙏

golden nebula
#

i thought id also tip, there is definitely no other reason behind it related to universal tweaks

#

(im kidding, i really am just happy to tip you)

echo willow
#

Do you have any idea how cool this is?

#

We can finally replace vanilla's randomness with stuff that makes trading and exploration more worth doing

echo willow
#

@rain goblet looks like pickblock is giving the vanilla painting- any possibility of making that give the painting itself instead?

rain goblet
echo willow
#

Thanks

rain goblet
echo willow
#

Excellent

#

Thats all I wanted out of the mod

frigid night
#

There's one thing I haven't tested and I was curious about; is there a way to turn a specific painting back into a generic painting? As in, if I have the Mona Lisa item, can I turn it into vanilla random/PaintingGUI selecting?

rain goblet
frigid night
#

How would you implement it? Do you have an idea to make it work seamless?

#

The way I see it, JSONpaintings should've had something were "creative" paintings always drop as the item, but generic paintings are generic and drop as such, since it's so easy to place them again with the Painting Selection GUI mod.
I don't know what the best middle ground would be for this mod as a standalone tbh

rain goblet
#

Packmakers could then decide if they want to keep paintings exclusive or vanilla-styled with benefits for the ease of use.

frigid night
#

You mean like transforming each item painting back into "generic non-creative painting" by placing them in the grid?

#

That would work I guess

rain goblet
#

Right!

echo willow
#

Easiest crafting recipe to make lol

rain goblet
#

Thing is, do I even need to add this natively? Since this is for modpack authors either way, this should be no big deal for them.

echo willow
#

I dont think so

#

Tbh I think the mod's done. Im gonna close it and just wait for curse to approve

rain goblet
#

Alright, cool! SeemsGood

rain goblet
#

Now under review on both CurseForge and Modrinth!