Downloading custom github nodes onto Docker

[soft pawn]

To help others find answers, you can mark your question as solved via Right click solution message -> Apps -> ✅ Mark Solution

[smoky grove]

TLDR:

I have a github repos: https://github.com/user/NameOfTheCustomNodes.git

This format installs properly when a node is present on comfy Registry : RUN comfy node install --exit-on-fail [email protected]

What to do if they are not on comfy Registry?

[crude stag]

I think comfy node install takes a url, but let me check.

It looks like it supports anything pip supports, so try git+https://github.com...

[smoky grove]

yup that's the kicker, i did try it , it "downloaded the nodes" but seemed to not download the (requirements.txt) rendering the nodes completely useless and giving out " Input not found model.safetensors" even though the model was installed correctly

i spent like 4 hours debugging just to come out to this conclusion

[crude stag]

I just had the thing open, it should be doing both

One moment

This repo is super confusing btw im shocked this thing works

(any of comfy-cli)

[smoky grove]

RUN comfy node install --exit-on-fail git+https://github.com/Author/reponame.git

This is what i was running

maybe its a wrong command

The nodes are 100% usable and working on a normal pod install with gitclone + pip install req.txt

[crude stag]

I think somewhere along the line because you're giving it an argument it's ignoring requirements.txt

You should be able to do comfy node install then comfy node install git+...

[smoky grove]

this is my whole docker

its pretty crystal clear if you ask me

request is a simple input,workflow (apiworkflow)

[crude stag]

I can't tell why it's being obliterated, it's not your fault I know that

I think if you just pip install -r requirements.txt at the end it should be happy again?

[smoky grove]

This is just an educated guess on what's happening tho

[crude stag]

I've been combing through the comfy-cli repo it's not a very "intelligent" installation process haha

But also comfy node install takes multiple arguments

comfy node install --exit-on-fail name name name name

[smoky grove]

IF pip install was the problem then -

cd /workspace/ComfyUI/custom_nodes/NameOfTheNode pip install -r requirements.txt
and then over over over...

because then docker wouldn't know which requirements.txt to install right? It wouldn't find the files on its own i guess?

Truth is im completely clueless so try to make ur own conlusion because i could be 100% wrong🤣

@lofty plover Maybe you could help us figure out what's going on

[smoky grove]

So what you think i should try?

[crude stag]

I'm a little out of my element with the internals of Comfy, let me see if I can track it down in their Discord or on GitHub. Just give me a little time...

Without the build logs I can really only guess, but comfy-cli should always be installing the deps of each node it installs.

It'll log something like:
Start downloading the node...
Start extracting the node...

Then (for some reason) it opens the requirements.txt file and installs each dependency lime by line. If that doesn't exist, it tries to run install.py at the top of the repo.