The text for the dialogue doubles after the first interaction

[charred spade]

I dont know why it does this but i need help 😭 the first time you talk to him its normal but the second time it breaks

[neon spruce]

can you send the code

for the module

[charred spade]

ok

there

[neon spruce]

whats open doing

[charred spade]

Sorry for the late response @neon spruce

[neon spruce]

i dont see anything immediately wrong in your code

the only thing i can think of is the button.mousebuttton1click event is being called twice

so every time the dialogue is activated its being duplicated

so there is 1 connection

then 2 connections

then 3

etc

[lilac mulch]

try using string.sub

or MaxVisibleGraphemes

[neon spruce]

i dont think his code goes wrong in the letter typing part

hes doing ..= letter

which should work the same

[lilac mulch]

ye but maybe hes doing smt wrong with string.split or smt else

local TypeWriter = {}

TypeWriter.Type = function(textLabel: TextLabel, text: string, yieldTime: number, sound: Instance?)
    textLabel.MaxVisibleGraphemes = 0
    textLabel.Text = text

    for i = 1, utf8.len(text) do
        if sound and sound:IsA("Sound") then sound:Play() end
        textLabel.MaxVisibleGraphemes += 1
        task.wait(yieldTime)
    end
end

return table.freeze(TypeWriter)``` this module i use it for my current project and it works fine

[neon spruce]

maybe, but from the looks of it i think his mousebutton1click is just being connected twice

because i think hes connecting it every time the dialogue starts

instead of just having it connected once

or connecting it then disconnecting it after the dialogue is over

[lilac mulch]

ooooooh i just read that part above the images im blind lmao

yea maybe he is connecting the connection twice

or clicking the button twice or smt

[neon spruce]

it gets connected once evry time the dialogue begins so first time it gets connected once, then a second time, then a third, etc

[lilac mulch]

yea ik

its causing a memory leak too

its better to use :Once

[charred spade]

i know im a bit late but "utf8.len(text)" doesnt work as it needs a string instead of a number

[lilac mulch]

wdym it doesnt work

it works fine for me

[charred spade]

It needs a number for the .len()

I'm using a string

[lilac mulch]

no?

u just pass the string and done

https://create.roblox.com/docs/es-es/reference/engine/libraries/utf8#len

[charred spade]

I'll try it but it says there's an error

[lilac mulch]

huh send a screenshot

[charred spade]

its a bit different but basically the same

[lilac mulch]

huh

[charred spade]

nvm

it says theres an error

but it still works

[lilac mulch]

but what the error says?

[charred spade]

on the script it says this

[lilac mulch]

r u using strict mode?

[charred spade]

wym.. 😭

[lilac mulch]

i mean --!strict

[charred spade]

uhh

[lilac mulch]

i dont see any problem

[charred spade]

yeah but why is it underlined as an error 😭

[lilac mulch]

huh idk

anyways if it works

[charred spade]

yeah it does

[empty turret]

what does the error say

[charred spade]

"it does"

anyway what i just loaded in and my character didnt load

oh well

[lilac mulch]

maybe is deprecated

but the documentation doesnt say anything about it

and on my module it doesnt show that error

[empty turret]

its possible it doesnt like utf8.len potentially returning 2 values when you only want to use one of them

[charred spade]

it wouldn't work then but ok

[lilac mulch]

no bc utf8.len its like doing #text but works a little bit differnet

[empty turret]

or the fact that the values are nullable

[charred spade]

btw the text doesnt "double" now

[empty turret]

yep its cause the return values are nullable

if you want to fix it you can just put or 0 after utf8.len(text)

so it defaults to 0 if it returned nil

[lilac mulch]

or just remove the --!strict

[empty turret]

or that