slow sparrow
Normal vec.insert shifts all elements to the right when inserting at an index
https://doc.rust-lang.org/src/alloc/vec/mod.rs.html#1441
Soroban vec.insert does not do this
https://docs.rs/soroban-sdk/latest/src/soroban_sdk/vec.rs.html#638-641
This is confusing and makes it quite difficult to build a sorted Vector thus making binary_search a less obvious choice.
As is it would appear insert is just a clone for set and that updates vs inserts at index
https://github.com/stellar/rs-soroban-env/blob/main/soroban-env-host/src/host.rs#L1505
https://github.com/stellar/rs-soroban-env/blob/main/soroban-env-common/env.json#L476
plush crypt
It might be an oversight. I don't see any reason why the vec.insert calls env::vec_put rather than env::vec_insert. @deft cove Do you remember if there is any?
deft cove
This looks like a bug to me.
plush crypt
Ok I will fix it.
plush crypt
@slow sparrow The fix has been merged. https://github.com/stellar/rs-soroban-sdk/pull/827
copper root
Markus noticed another one, see -> https://github.com/stellar/rs-soroban-sdk/pull/830
thorn wigeon
@plush crypt maybe open a few issues about "we need more tests"? I don't know if there is a good way for people to know how they can help (we can use the flag "help wanted" to signal those kind of easy task that anybody can pick up)
deft cove
<@397251438147010572> maybe open a few issues about "we need more tests"? I don'...
I think we'd benefit from a code coverage exercise. I'm not sure what Rust has support for in IDEs, but I'm thinking something like Go's VSCode code coverage where you see red lines for anything not tested. Maybe we set aside some "write tests" half-days, where everyone spends half a day picking an area and looking for tests they can write?
thorn wigeon
yes that as well. code coverage will not tell you if you have logic that is completely wrong like the bug above though