Husky preventing commits | Novu | Page 1

frail pivot Oct 2, 2022, 7:30 PM

#

I am trying to make a contribution to the hacksquad website but I cannot get past husky. I am using a conventional commit but getting the following error and would appreciate if someone knows how to interpret what is wrong: ```
Oops! Something went wrong! :(

ESLint: 8.23.0

Error: Cannot read config file: C:\Users\squig\Documents\Hacktober\2022\hacksquad-website\node_modules\eslint-config-airbnb\whitespace.js
Error: Command failed: C:\Users\squig\Documents\Hacktober\2022\hacksquad-website\node_modules\eslint-config-airbnb\whitespace-async.js
Referenced from: C:\Users\squig\Documents\Hacktober\2022\hacksquad-website.eslintrc.js
at checkExecSyncError (node:child_process:828:11)
at execSync (node:child_process:899:15)
at Object.<anonymous> (C:\Users\squig\Documents\Hacktober\2022\hacksquad-website\node_modules\eslint-config-airbnb\whitespace.js:54:38)
at Module._compile (node:internal/modules/cjs/loader:1105:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
at Module.load (node:internal/modules/cjs/loader:981:32)
at Function.Module._load (node:internal/modules/cjs/loader:822:12)
at Module.require (node:internal/modules/cjs/loader:1005:19)
at Object.module.exports [as default] (C:\Users\squig\Documents\Hacktober\2022\hacksquad-website\node_modules\import-fresh\index.js:32:59)
husky - pre-commit hook exited with code 1 (error) ```

dense iron Oct 2, 2022, 8:35 PM

#

@tacit turret <@&986960430528331776> <@&949961460384157746> Could one of you help here?

strong wyvern Oct 2, 2022, 9:02 PM

#

frail pivot I am trying to make a contribution to the hacksquad website but I cannot get pas...

Could you check that eslint-config-airbnb is installed (in node_modules)?

pallid girder Oct 3, 2022, 12:44 AM

#

I too came across the same issue.

frail pivot Oct 3, 2022, 7:42 AM

#

strong wyvern Could you check that eslint-config-airbnb is installed (in node_modules)?

Yes, the files are there

frail pivot Oct 3, 2022, 7:42 AM

#

pallid girder I too came across the same issue.

Did you find a solution?

pallid girder Oct 3, 2022, 8:34 AM

#

frail pivot Did you find a solution?

I am on windows. ALong with that error it throws Microsoft Jscript compilation error.
Tried everything found on internet .. nothing worked

waxen jungleBOT Oct 3, 2022, 8:34 AM

#

@pallid girder, you just advanced to level 1!

tacit turret Oct 3, 2022, 9:03 AM

#

@cosmic hatch @hollow holly @warm oak

cosmic hatch Oct 3, 2022, 9:04 AM

#

What node version are you using?

frail pivot Oct 3, 2022, 9:34 AM

#

cosmic hatch What node version are you using?

I’m running node 16.15.0 and npm 8.11.0

pallid girder Oct 3, 2022, 9:50 AM

#

frail pivot Did you find a solution?

by the way.. there is one hack .. just delete the .husky folder and commit and restore it again 😄

frail pivot Oct 3, 2022, 4:21 PM

#

pallid girder by the way.. there is one hack .. just delete the .husky folder and commit and r...

Well I guess so but that feels like cheating and doesn’t help the next person that has the same issue.

cosmic hatch Oct 3, 2022, 4:21 PM

#

Hm @frail pivot that should work I think

pallid girder Oct 3, 2022, 4:22 PM

#

frail pivot Well I guess so but that feels like cheating and doesn’t help the next person th...

I tried running on Ubuntu via WSL .. still got the same issue with ESLINT .. so that's the only solution I have found ... Please let me know if you find any other solution

cosmic hatch Oct 3, 2022, 4:29 PM

#

@frail pivot could you try to bump the versions of the eslint packages and see if that helps? If you need help to try that just tell me and we can look at it togther

frail pivot Oct 3, 2022, 5:04 PM

#

They already seem to be on the latest versions

cosmic hatch Oct 3, 2022, 5:04 PM

#

oh okay

frail pivot Oct 3, 2022, 5:08 PM

#

Ok, I've googled and googled and can't find anything. I will use Diwash's hack for now and if there's something wrong with the PR maybe we can work it out from there.

waxen jungleBOT Oct 3, 2022, 5:08 PM

#

@frail pivot, you just advanced to level 1!

cosmic hatch Oct 3, 2022, 5:09 PM

#

@frail pivot are you on Windows as well?

#

anyway please create an issues for us so some awesome contributor could help us solve this 🙂

#

!issue

waxen jungleBOT Oct 3, 2022, 5:09 PM

#

Want to report a bug or request a feature?
Let's open an issue. Just click here 👇
https://github.com/novuhq/novu/issues/new/choose

frail pivot Oct 3, 2022, 5:12 PM

#

cosmic hatch <@447145382322110475> are you on Windows as well?

Yes, I'm on windows. It gives me a script error first then husky won't commit

cosmic hatch Oct 3, 2022, 5:13 PM

#

Yeah I understand the problem, not sure how to solve it on windows 😦

frail pivot Oct 3, 2022, 5:13 PM

#

Now I just tried to merge main into my branch and husky flipped out again .husky/commit-msg: line 2: .husky/_/husky.sh: No such file or directory

#

So something somewhere is going wrong

cosmic hatch Oct 3, 2022, 5:13 PM

#

yeah thanks for reporting it 🙂

frail pivot Oct 3, 2022, 5:21 PM

#

I just made an issue. Hopefully someone can find out what's going on but for now I can't make my original PR.

cosmic hatch Oct 3, 2022, 5:22 PM

#

thanks @frail pivot, not even with the work around?

frail pivot Oct 3, 2022, 5:22 PM

#

No, it won't let me merge main into my branch 🤦🏻‍♀️

cosmic hatch Oct 3, 2022, 5:23 PM

#

ah okay 😦 <@&943775970421264404> or <@&949961460384157746> any ideas here?

pallid girder Oct 3, 2022, 5:36 PM

#

frail pivot No, it won't let me merge main into my branch 🤦🏻‍♀️

delete .husky
git commit -m "<msg>"
git push
git reset --hard
🥳

pallid girder Oct 3, 2022, 5:41 PM

#

frail pivot No, it won't let me merge main into my branch 🤦🏻‍♀️

for merging main:

delete .husky
git commit -m "<msg>"
git pull origin main
git push
git reset --hard
git pull origin <my_branch>

west blade Oct 3, 2022, 8:50 PM

#

frail pivot No, it won't let me merge main into my branch 🤦🏻‍♀️

As a workaround you can commit with git commit -m “message here” —no-verify

#

@tacit turret maybe worth removing husky as seems a lot of people having a problem with on the hacksquad website

pallid girder Oct 4, 2022, 12:59 AM

#

west blade <@712256006956253197> maybe worth removing husky as seems a lot of people having...

On both Novu and hacksquad website

amber sparrow Oct 4, 2022, 8:25 AM

#

frail pivot I’m running node 16.15.0 and npm 8.11.0

it's probably naive question but
do you by any chance has nvm to install both node and npm?

frail pivot Oct 4, 2022, 1:41 PM

#

west blade As a workaround you can commit with git commit -m “message here” —no-verify

Thanks, this seemed to work 👍

frail pivot Oct 4, 2022, 1:42 PM

#

amber sparrow it's probably naive question but do you by any chance has nvm to install both no...

I don't have nvm on my windows laptop

amber sparrow Oct 5, 2022, 12:18 PM

#

frail pivot I don't have nvm on my windows laptop

In the docs https://docs.npmjs.com/downloading-and-installing-node-js-and-npm they said

We strongly recommend using a Node version manager like nvm to install Node.js and npm. We do not recommend using a Node installer, since the Node installation process installs npm in a directory with local permissions and can cause permissions errors when you run npm packages globally.

I might be wrong but since husky is installed by npm it might be related to some point in your error.
Sorry, if it's not answering your question

frail pivot Oct 5, 2022, 12:21 PM

#

but nvm isn’t available on windows 🤔 and I’ve not had problems on other projects using husky

waxen jungleBOT Oct 5, 2022, 12:21 PM

#

@frail pivot, you just advanced to level 2!

#Husky preventing commits