Python randomly changing values [bug?] | Pycord | Page 1

hollow kayak May 5, 2022, 5:58 PM

#

Python randomly changing values [bug?]

distant prawn May 5, 2022, 5:59 PM

#

you may be dealing with race conditions

hollow kayak May 5, 2022, 5:59 PM

#

distant prawn you may be dealing with race conditions

Elaborate. Please review code before giving an answer.

#

I don't wanna deal with assumptions.

distant prawn May 5, 2022, 5:59 PM

#

https://docs.microsoft.com/en-us/troubleshoot/developer/visualstudio/visual-basic/language-compilers/race-conditions-deadlocks#:~:text=A race condition occurs when,same value from the variable.

Race conditions and deadlocks - Visual Basic

This article describes that Visual Basic offers the ability to use threads in Visual Basic applications for the first time. Threads introduce debugging issues such as race conditions and deadlocks.

#

is your bot used often?

hollow kayak May 5, 2022, 6:00 PM

#

My bot is only used in one Discord Server and used by 2-3 people at a time.

#

The games tend to work fine but then randomly the bug happens as mentioned above and shown in the screenshot.s

#

I've read all through my code and I don't see how it's possible for Python to be messing this up as mathmatically it isn't possible.

#

I have no idea where it's getting the numbers from or anything.

copper sinew May 5, 2022, 6:04 PM

#

tbf, does look like race conditions. Doesn't really depend how many users they have. If they are handled at the same time, same variable or so, it could occur

#

always need to make it threadsafe in this case

#

(eg. using locks)

hollow kayak May 5, 2022, 6:05 PM

#

I'm not understanding?

#

Can you look at my code and tell me if it's anything in there? I don't think it is cause the code doesn't seem like it'd be able to do that.

#

Also I don't know what you mean by race conditions.

#

Nor how to prevent it.

crude lichen May 5, 2022, 6:07 PM

#

did you verify the contents of the json file are right?

hollow kayak May 5, 2022, 6:07 PM

#

crude lichen did you verify the contents of the json file are right?

Wdum?

#

The Json Database is fine no issues with it.

distant prawn May 5, 2022, 6:09 PM

#

hollow kayak Also I don't know what you mean by race conditions.

i literally sent a link to the definition

#

also your push function has a little error

#

it changes the balance of the player

hollow kayak May 5, 2022, 6:10 PM

#

distant prawn it changes the balance of the player

Uh wdum

hollow kayak May 5, 2022, 6:10 PM

#

distant prawn i literally sent a link to the definition

But that doesn't really makesense to me.

#

Push isn't an issue push works fine.

distant prawn May 5, 2022, 6:10 PM

#

async def push(self, bust = False):       
        cas = self.cas
        money = "{:,}".format(cas["money"]) #on push they don't win nor lose anything
        embed = discord.Embed(title="You Pushed [Blackjack]",description=f"**Game ID**: `{self.id_value}`\n*Use `/lookup` to view this game.*",color=p84clr)
        embed.add_field(name=f"Player [{self.player.value()}]",value=f"{self.player}")
        embed.add_field(name=f"Dealer [{self.dealer.value()}]",value=f"{self.dealer}")
        embed.add_field(name="Profit",value=f"`$0`", inline=False)
        embed.add_field(name="Balance",value=f"`${money}`")
        if self.message:
            await self.message.edit(None, embed = embed, view = None)
        self.changeBalance(self.owner, round(self.bet)) # i believe this isnt supposed to be here```

hollow kayak May 5, 2022, 6:10 PM

#

Ye

#

it doesn't change their balance tho

#

Since byAmount is 0

#

It just sets it to their money.

#

Not the issue nor the focus.

distant prawn May 5, 2022, 6:11 PM

#

ah whatever

hollow kayak May 5, 2022, 6:11 PM

#

It's only happening when they win / lose blackjack/crash

#

Which is weird lol

distant prawn May 5, 2022, 6:12 PM

#

race condition is basically when two threads for instance try to write to the same variable for instance

#

only one of the two threads gets their result saved permanently afterwards

hollow kayak May 5, 2022, 6:12 PM

#

hm

#

How would that happen if I have a 5 second cooldown on all commands?

#

Plus an in-game prevention system so no duel games happen.

distant prawn May 5, 2022, 6:12 PM

#

very unlikely but you should still check

hollow kayak May 5, 2022, 6:13 PM

#

I did check I see nothing?

#

I legit see no issues.

#

But yet there's an issue.

distant prawn May 5, 2022, 6:14 PM

#

this ones a toughie ¯_(ツ)_/¯

hollow kayak May 5, 2022, 6:14 PM

#

Yup.

#

So what do I do to fix it?.

#

I've tested it myself and there's no explanation other to say it randomly just happens.

#

It happens even if you don't spam it. I took a 30 min break, came back.. happened.

#

So I don't understand.

#

Anyone know how to fix it 😦

copper sinew May 5, 2022, 6:45 PM

#

I told you, locks

#

Pardon the Google URL, am on the phone

#

Just search for python thread safety and python locks

hollow kayak May 5, 2022, 6:48 PM

#

copper sinew Pardon the Google URL, am on the phone

It makes no sense

#

How do you even know thats the issue

still plover May 5, 2022, 6:48 PM

#

just to confirm the issue is related to the json and database?

copper sinew May 5, 2022, 6:49 PM

#

Educated guess after years of professional python development ... You got a condition going on where variables are being changed in between start and end

#

It's the only explanation

crude lichen May 5, 2022, 6:49 PM

#

hollow kayak The Json Database is fine no issues with it.

So in your example does the json have $20,000 or $6,789?

copper sinew May 5, 2022, 6:49 PM

#

Even if it is in the JSON dB, you got to make it safe for concurrency

hollow kayak May 5, 2022, 6:51 PM

#

crude lichen So in your example does the json have $20,000 or $6,789?

$6789

crude lichen May 5, 2022, 7:05 PM

#

hollow kayak $6789

But it should have $20,000? So the json is wrong

hollow kayak May 5, 2022, 8:35 PM

#

crude lichen But it should have $20,000? So the json is wrong

In that particular demo i didnt have an exact answer. The database is always changing so hard to get an exact answer.

#

Would it be what Fishy said being the lock issue?

hollow kayak May 5, 2022, 11:44 PM

#

Hello?

#

Anyone?

hollow kayak May 6, 2022, 1:04 AM

#

Bruh locking isn't rlly explained anywhere and that isn't even the issue I was having.

crude lichen May 6, 2022, 2:55 AM

#

so you fixed it?

#

@hollow kayak

#

oh they left...

crude needle May 6, 2022, 4:09 AM

#

F

crude lichen May 6, 2022, 4:10 AM

#

and joined and left again 🙃

hollow kayak May 6, 2022, 6:52 AM

#

crude lichen and joined and left again 🙃

look in other one

willow holly May 7, 2022, 2:50 AM

#

miner mends is kinda dumb tbf

fading sable May 7, 2022, 3:48 AM

#

willow holly miner mends is kinda dumb tbf

he dmed me, I asked him why, he then deleted his message and dmed me "what"

#

💀

#

#Python randomly changing values [bug?]