If statement (unexpectedly) returns all. | Pycord | Page 1

tiny rose Sep 24, 2022, 11:49 AM

#

My tag command is only supposed to return a specified tag, but instead it returns all.

#

Here is my code:

#

@bot.command(guild_ids=[1007844136738619545])
async def tag(ctx, tag):
    if tag == 'codeblock':
        await ctx.respond("Please place your code in codeblocks. \`\`\` your code here \`\`\` Your code would appear as this: \`\`\`your code here \`\`\`")
    if tag == 'didnotwork' or 'didntwork':
        await ctx.respond("Just saying that it \"didn\'t work\" isn\'t helpful. Please give us the code in question, and a valid error code. Censor your token!")
    if tag == 'tags':
        await ctx.respond("The tags available are: codeblock, didnotwork, didntwork, reports, report, tryitandsee, tryitands.ee", ephemeral=True)
    if tag == 'report' or 'reports':
        await ctx.respond("Please report your issues using /report.")
    if tag == 'tryitandsee' or 'tryitands.ee':
        await ctx.respond("https://tryitands.ee")
    else:
        await ctx.respond(f"I\'m afraid I can\'t reference tags... that... you know... don\'t exist.",ephemeral=True)

#

If statement (unexpectedly) returns all.

fervent gulch Sep 24, 2022, 11:52 AM

#

can you post the bot response and command input?

tiny rose Sep 24, 2022, 11:53 AM

#

#

/tag tag:tags

fervent gulch Sep 24, 2022, 11:57 AM

#

ah, that's why

#

because you have all of your statements as if instead of elif, it does all of them separately (excluding the last two, which are done together)

tiny rose Sep 24, 2022, 11:58 AM

#

oh ok

fervent gulch Sep 24, 2022, 11:59 AM

#

the reason it gives responses 2, 4, and 5, is because strings are always true ('didntwork' is not being compared to tag but is being evaluated to True)

shadow cairn Sep 24, 2022, 11:59 AM

#

use match case 🙂

fervent gulch Sep 24, 2022, 11:59 AM

#

one way you could do it is

@bot.command(name='tag')
async def tag(ctx, tag):
    if tag == 'codeblock':
        await ctx.respond("Please place your code in codeblocks. \`\`\` your code here \`\`\` Your code would appear as this: \`\`\`your code here \`\`\`")
    elif tag in ['didnotwork', 'didntwork']:
        await ctx.respond("Just saying that it \"didn\'t work\" isn\'t helpful. Please give us the code in question, and a valid error code. Censor your token!")
    elif tag == 'tags':
        await ctx.respond("The tags available are: codeblock, didnotwork, didntwork, reports, report, tryitandsee, tryitands.ee", ephemeral=True)
    elif tag in ['report', 'reports']:
        await ctx.respond("Please report your issues using /report.")
    elif tag in ['tryitandsee', 'tryitands.ee']:
        await ctx.respond("https://tryitands.ee")
    else:
        await ctx.respond(f"I\'m afraid I can\'t reference tags... that... you know... don\'t exist.",ephemeral=True)

tiny rose Sep 24, 2022, 11:59 AM

#

elif doesn't exist on mine?

fervent gulch Sep 24, 2022, 12:00 PM

#

are you sure? it's been in python since forever

#

or use match case, that would probably also be more readable

tiny rose Sep 24, 2022, 12:01 PM

#

yep it throws a fit

fervent gulch Sep 24, 2022, 12:01 PM

#

hover it and screenshot the error for me

#

as in mouseover

shadow cairn Sep 24, 2022, 12:01 PM

#

lol

tiny rose Sep 24, 2022, 12:01 PM

#

shadow cairn Sep 24, 2022, 12:02 PM

#

my guy you really need to take a lesson holy

#

'elif' as your first argument

fervent gulch Sep 24, 2022, 12:02 PM

#

oh i didn't even notice lol

shadow cairn Sep 24, 2022, 12:02 PM

#

you need at least if to start with

fervent gulch Sep 24, 2022, 12:02 PM

#

yeah first is always if, following ones can be elif or else, but else is always last (if there is an else at all)

tiny rose Sep 24, 2022, 12:04 PM

#

Now all the tags are the first one 😅

fervent gulch Sep 24, 2022, 12:05 PM

#

fervent gulch the reason it gives responses 2, 4, and 5, is because strings are always true ('...

.

tiny rose Sep 24, 2022, 12:05 PM

#

the first elif i mean

fervent gulch Sep 24, 2022, 12:05 PM

#

because the string 'didntwork' is being evaluated as just a string and not being compared to tag

tiny rose Sep 24, 2022, 12:05 PM

#

but how would i do it

#

so should i do if 'codeblock' == tag instead

#

?

fervent gulch Sep 24, 2022, 12:06 PM

#

fervent gulch one way you could do it is ```py @bot.command(name='tag') async def tag(ctx, tag...

.

#

or

if tag == 'didnotwork' or tag == 'didntwork':
    # etc.

#

tiny rose Sep 24, 2022, 12:07 PM

#

My PC died in the middle of coding lol

#

ooh its back

shadow cairn Sep 24, 2022, 12:08 PM

#

@bot.command(name='tag')
async def tag(ctx, tag):
    match str(tag):
        case 'codeblock':
            await ctx.respond("Please place your code in codeblocks. \`\`\` your code here \`\`\` Your code would appear as this: \`\`\`your code here \`\`\`")
        case 'didnotwork' | 'didntwork':
            await ctx.respond("Just saying that it \"didn\'t work\" isn\'t helpful. Please give us the code in question, and a valid error code. Censor your token!")
        case 'tags':
            await ctx.respond("The tags available are: codeblock, didnotwork, didntwork, reports, report, tryitandsee, tryitands.ee", ephemeral=True)
        case 'report' | 'reports':
            await ctx.respond("Please report your issues using /report.")
        case 'tryitandsee' | 'tryitands.ee':
            await ctx.respond("https://tryitands.ee")
        case _:
            await ctx.respond(f"I\'m afraid I can\'t reference tags... that... you know... don\'t exist.",ephemeral=True)

tiny rose Sep 24, 2022, 12:09 PM

#

fervent gulch one way you could do it is ```py @bot.command(name='tag') async def tag(ctx, tag...

AYYYY IT WORKED!

#

Closing post now @fervent gulch

#If statement (unexpectedly) returns all.