wind ember
It would be great to add to Bun.serve HMR in developer mode like Webpack Dev Server does.
Pay attention HMR is not a page reload, but a replacement of the changed parts of the code it’s important for SPA apps.
About HMR:
https://webpack.js.org/concepts/hot-module-replacement/
https://en.parceljs.org/hmr.html
wind ember
Example HMR by Vite
smoky oxide
I tried doing that but I can’t get the browser to reflect my changes without refreshing.
wind ember
@agile river, --hot watch and restarts the server, but does not notify the browser about the need to update a certain part of the content. Now --hot works like nodemon.
As front-end developers, we need to update the content of the browser, but without reloading the page.
Please, watch example HMR by Vite above.
@smoky oxide, because you need Websockets to notify the browser about updates.
Here is an example https://github.com/mi4uu/bun-react-template, a working version of Websockets + window.reload.
But it seems to me that without improvements to `Bun.serve', it will not be possible to implement the real HMR.
agile river
woops lemme make that an mp4
@wind ember
wait
this might have just been the webpack dev server
for cra
agile river
ah yea i see what your getting at
wind ember
Here's how HMR is implemented in Vite:
There is a createHotContext function in clients.ts which provides the methods needed by HMR.
In importAnalysis.ts, the result of the createHotContext call is inserted into import.meta.hot for each of the modules.
https://github.com/vitejs/vite/blob/main/packages/vite/src/client/client.ts
https://github.com/vitejs/vite/blob/main/packages/vite/src/node/plugins/importAnalysis.ts
@night anvil, can we expect HMR in Bun out of the box?
I think it will be much faster than Vite.
wide girder
Framework API ( Bun.App ) should be able to do that
wind ember
@wide girder, what do you mean?
wide girder
that it should have HMR
