Upgrading from 7.6.1 to 7.8.0 breaks all transition-related tests

[karmic mulch]

I just upgraded Mantine from 7.6.1 to 7.8.0 and every single unit test for components that use modal/popover/etc. broke.
The tests normally click a button then get the popup content i.e.

const button = getByTestId('open-calendar-button');
fireEvent.click(button);
const dateButton = getByText('5');

I understand something changed in the behaviour of transitions; replacing get with await find in these tests solves the issues i.e.

fireEvent.click(button);
const dateButton = await findByText('5');

...but that's a LOT of tests.
I wonder if there's a way to revert the transition behavior in 7.8.0 to the way it was before (whatever the change is), to prevent everything form breaking?

[winged isle]

There were not any changes to transitions logic between these releases that impact tests. Mantine codebase has about 10000 tests with react testing library. I have several projects with cypress and react testling library tests. All of them are fine in 7.8

[karmic mulch]

That is very very strange... Maybe some changes specifically with modals or popovers?

[winged isle]

You can review changes here – https://github.com/mantinedev/mantine/commits/master/packages/%40mantine/core/src/components/Modal/Modal.tsx
https://github.com/mantinedev/mantine/commits/master/packages/%40mantine/core/src/components/Popover/Popover.tsx

[dense lava]

We had the same issue when upgrading. All tests with modals started failing and we had to await these elements instead.

[karmic mulch]

so you didn't find the cause i assume

[karmic mulch]

@winged isle Hey, I've reviewed the commits and understand there haven't been any real changes to these files. I wonder if maybe something else could have possible changed, perhaps in an internal hook?

I have over a hundred tests that break, all for the same reason:
Before, the test opened a modal/popover by clicking a button, either custom of Mantine's (i.e. date input calendar), and used getByTestId to immediately get a content, and that worked.

In 7.8, using get fails, and I must use await findByTestId instead. This is a hefty change and I do consider this to be a breaking change as it affects so many tests for us.

I understand it's a needle in a haystack but I'd love it if you could help figure this out, or let me know where to maybe look.

[winged isle]

I do not understand what I can do, there were not any changes to anything related to Modals and Popovers, there is nothing to rollback

[karmic mulch]

I just tried a smaller upgrade. Upgrading from 7.6.1 to 7.6.2 also encounters the same issue. Does that narrow it down?

[winged isle]

No, not really

You are welcome to explore changes in this patch

[karmic mulch]

Doing this now.
I believe it might be related to this fix:
https://github.com/mantinedev/mantine/pull/5873
If I understand correctly, this makes the update always wait for animations? Which means that before, it didn't, and executed update immediately, which is why I was able to use get without waiting for elements.

If I'm right, then this does sound like the desired behavior, but it results in unexpected errors for those who used transitions like they worked before, such as myself.

[winged isle]

Yeah, that might be the cause of issues with tests. It won't be reverted because it fixed a long standing issue with transitions. In your tests you can disable transitions entirely by defining defaultProps for Modal and other components on MantineProvider

[karmic mulch]

I will definitely try that! I don't know exactly if that will help, seeing the change in this commit was also moving the setter someplace else, so perhaps more involved, but I'll try and let you know 👍🏼