Meltdown Mitigation in Python, my code runs, but has "Code Smell" | Exercism | Page 1

vagrant edge Jun 10, 2024, 6:17 AM

#

Here is my code, which runs, but has "Code Smell" on the following line.

I read a bit on Code Smell, and I get it, but I don't see how to simplify the code in question.

(I'm only posting the smelly lines because the code block was well over the character limit for a post.)

        return 'NORMAL'```

wicked tundra Jun 10, 2024, 6:23 AM

#

with python you can just write logical chain like normal math when it involve number comparison

#

how would you write this out like normal math?

vagrant edge Jun 10, 2024, 6:26 AM

#

I don't know, I'll go reading up on that, thanks. 🙂

wicked tundra Jun 10, 2024, 6:27 AM

#

this is a simple one. let say i can write : 1 < 2 and 3 > 2. how would you chain them together?

vagrant edge Jun 10, 2024, 6:31 AM

#

        return 'NORMAL'```

#

Thank you!

wicked tundra Jun 10, 2024, 6:32 AM

#

yeah.did it pass?

vagrant edge Jun 10, 2024, 6:32 AM

#

it did, thanks

wicked tundra Jun 10, 2024, 6:32 AM

#

hey can you do me a favor and try this for me. see if it also pass

#

if 0.9 < (temp_neut / threshold) < 1.1:

vagrant edge Jun 10, 2024, 6:32 AM

#

ok, one sec

#

no, it didn't

wicked tundra Jun 10, 2024, 6:34 AM

#

Ok, thanks you. The logic is similar but I wasnt sure if the comparison gonna hold because of math division in python

vagrant edge Jun 10, 2024, 6:35 AM

#

Thanks for your help 🙂

#Meltdown Mitigation in Python, my code runs, but has "Code Smell"