Auto Fish Rework

[pastel finch]

Hi Bomi. i have tried this mod today and everything works except reeling in fish. it pulls back for a second and then the rod is let go and the fish gets away. i have tried removing all mods besides auto fish rework and corelib but this did not help. i am running on version 1.0.0.10

this is the first auto fish mod i have tried so no older versions have been downloaded or enabled

[midnight thistle]

Could you let me know which platform you're playing the game on? If possible, could you also send me your player.log file (please send it right after you encounter the issue, so the log is properly recorded)?

[pastel finch]

playing on pc. will try with the player.log now

[midnight thistle]

is it Steam or gamepass or gog?

[pastel finch]

steam i think

i can live stream it if there is a channel to do this in if it helps

[midnight thistle]

So when the fish appears and the exclamation mark shows up, it reels in the line but there's no fish?

[pastel finch]

no it reels it in for a split second then stops and the fish just gets away

the line "pulls back" for a split second but then is let go

[midnight thistle]

So it happens every time and it can't catch any fish at all??

[pastel finch]

correct

anything that isnt a fish it works perfectly and recasts straight away

[midnight thistle]

So it can catch valuable items and scrap, but not fish?

[pastel finch]

correct

when the fish gets away it recasts automatically once the 25s timer is up

[midnight thistle]

if possible, could you record and send me a short video of the fishing?

[pastel finch]

ill try now

41meg is too big? hmm

i will reduce quality. using windows game bar

[floral mountain]

I use 8mb.video to compress for discord (it's a nice website)

[pastel finch]

ill try it

[midnight thistle]

Ah I know the problem

You are turning on the Fishing minigame

You can try turning off the fishing minigame in the Gameplay settings.

[pastel finch]

oh perfect. i didnt even know the minigame was an option to toggle off

played a 1-2 years ago in early access but picking it up again for 1.0

thanks for the help. very nice work on the mod and apologies if the auto mini game was covered in any notes

[midnight thistle]

I will look into making Auto Fish work for the fishing minigame as well

[midnight thistle]

It is my bad for not considering all the cases

🥹

[pastel finch]

all good. hope the feedback was helpful

[midnight thistle]

Sorry for the inconvenience, and thank you for letting me know about the issue

[midnight thistle]

Update 1.0.1

• No longer requires CoreLib library; the mod should now work on its own.
• Removed all UI, effects, and the notification system that were implemented in the previous version.

[floral mountain]

Should still be able to use the textmanager to have text pop up lol

[floral mountain]

Can also see if minigame is enabled using PrefsManager.fishingMiniGameEnabled

[midnight thistle]

I decided to remove them after overthinking the downvotes and upvotes yesterday. I feel like maybe people don’t like having unofficial things on their game screen? I’m not sure… What do you think? If you really need it, I’ll consider making it an option that can be enabled/disabled

[floral mountain]

I dunno, I thought you removed it cuz CoreLib not being a depend now

[midnight thistle]

Thank you, I will use this to make a check logic to notify users that they need to disable the fishing minigame.

[midnight thistle]

Some code line related to Popup text can be copied from CoreLib’s code, so I usually do that instead of using the entire CoreLib if it’s not necessary

[floral mountain]

It has a getter and setter, I haven't tried it but it might allow you to disable it during autofishing, then enable outside of autofishing

[midnight thistle]

That’s great to know, I’ll check it out

[midnight thistle]

I tried to set Manager.prefs.fishingMiniGameEnabled = false, but the minigame still triggered.
Only after I press ESC to open and close the Pause menu, thats when the value get saved, and the fishing minigame actually turn off

I also tried Manager.prefs.Write(true), but it didn't work, and I still had to open the pause menu for the value to be saved

I think I should add it to the Init() of the mod, so when the world loads, the value will be applied immediately

[floral mountain]

Not how I thought it would work but I see

[daring surge]

Noticed that the autofish stopped working once my cursor was over one of my status or the toolbar. Is that a known issue? 🤔

[surreal marlin]

Theres a preselected option on game that makes your character turn on where ur cursor is. If let's say you were fishing at your right and then you took the cursor on buffs, while doing this you might have accidentally made your character look up from right. Hope it makes sense. Anyways you can go to settings and turning it. I always do that while I'm afk-fishing just incase my cat decides to jump on my pc's desk

[daring surge]

The thing is, my character is facing the same direction (down). Just that when my cursor is also over the hotbar, autofish seems like it can no longer function.

Is the cursor being over the hotbar taking away focus or something? 🤔

[surreal marlin]

hmmm not sure tbh will check it when im home

[daring surge]

I believe you can get the same behaviour by just opening your inventory. While it's open, autofish also seems to not be able to function until it's closed again.

[midnight thistle]

Auto Fish only runs when no other in-game windows are open. If you open the inventory window, the game switches the PlayerController system to the inventory UI, so Auto Fish won't work on that screen

This is part of the game's code, similar to how you can't move the character while the inventory UI is open

[midnight thistle]

about this, I'll check it right away, thanks for reporting

[midnight thistle]

I checked and it indeed doesn't reel the fish when the mouse cursor hovers over something that shows a tooltip (buffs, toolbar,...)
I'll be working on a fix
About able to fish while the inventory is open, I will find a workaround

[daring surge]

Cool, was slightly confused when the main dev put inside changelogs that "Now able to fish with inventory open"

At least according to the wiki, 1.0.0.1 said "Opening the inventory will no longer disrupt fishing."

[midnight thistle]

I added a logic to address the issue: whenever the cursor hovers over those UI elements, the element will be temporarily hidden for at least 0.5 seconds during the fishing rod pulling or bait casting actions only.
Additionally, this logic also applies to the player inventory, meaning that if you accidentally open the inventory window while auto fishing, the inventory window will be temporarily hidden only when casting bait and pulling the fishing rod.

Update 1.0.3

• Added a workaround to prevent Auto Fish from pausing when the cursor hovers over certain UI elements.
  • UI elements that the cursor hovers over will be temporarily hidden for at least 0.5 seconds whenever pulling the rod or casting bait (this works with the Inventory Window).

Please update the mod and maybe restart the game for the changes to take effect!

[daring surge]

Cool, will try it later, currently trying to diagnose why AutoDoor isn't working for me too 😢

[daring surge]

Change works amazingly well, thank you

[surreal cloud]

Can confirm the mod still works after the QoL Update and the fix the devs put out after. (Solo game)

[hybrid tusk]

Will there be an update for this?

[sick holly]

Can you update this as it doesn't work with the current update.

[autumn vessel]

Not working, it says it's not compatible and offers to disable it

[sudden pond]

Saying it's not compatible means it hasn't been updated since the last CK version. I can confirm that it works as expected if you have it enabled. The Disable message is to let you know and give you the option to disable it.

[midnight thistle]

Everything works except it shows a message saying “not compatible”? Thank you for reporting, I’ll take a look at it.

[midnight thistle]

Update 1.0.4

• Updated for compatibility with game version 1.0.1.3 (November 6, 2024)

You might want to update the mod by doing "Check for Update" in the Mod Collection menu.
If it still shows the "Incompatible" message, try unsubscribing and subscribing again to force the latest version to install.

[surreal cloud]

Confirming the update has gone through and can be done. Mod works with no problems.

[fringe lance]

that incompatible thing is a flag on modio site that needs to be set.

[solar widget]

I have noticed after afking while fishing in lava, it lags quite a bit after and I need to restart

[surreal cloud]

for like how long?

[solar widget]

@surreal cloud after say 30m

[surreal cloud]

that sounds like a computer issue tbh.

[midnight thistle]

Hmm... since the mod doesn’t add anything into the game and just hooks into the fishing controls, it’s probably not the cause of the issue.
You might want to check other mods or consider if it could be a performance issue on your computer

[midnight thistle]

Thank you! I just realized that