Make better SQLite DateTime convert Microsoft.EntityFramework

[midnight epoch]

I'm getting:
ArgumentOutOfRangeException: Valid values are between 0 and 999, inclusive. (Parameter 'millisecond')
System.DateTime.ThrowMillisecondOutOfRange()

from DbContext, in model of DbSet<>, I have property public DateTime CreatedAt { get; set; }
in .db table I set valid date, but when I try to get it from model, I'm getting exception

[wheat wigeon]

iirc I got shouted at (not literally) for using DateTime in my database fields. Try DateTimeOffset, but from what I understand, the correct approach for times in databases is Nodatime.

Also, I don't think this is a Discord.Net related question. 😛

[wheat wigeon]

oh 😛

[midnight epoch]

DateTimeOffset also give me same exception

[wheat wigeon]

Where's the error being thrown? What line?

That's not a db error so I assume you're retrieving the date from the database?

[midnight epoch]

idk what line, but I have this:

var reviews = m_dbContext.Reviews.Select(x => UserReview.FromData(x, UserAccount.FromData(m_dbContext.Users.FirstOrDefault(y => y.Id == x.UserId))));

return View(reviews.ToArray());

[wheat wigeon]

That date is Unix Epoch

I think Epoch is long? What's the database type?

[midnight epoch]

datetime

[wheat wigeon]

What database is this? Just curious, unrelated question

Can you show the stacktrace for where it fails?

In the codeblock you gave me I don't see anything related to

ArgumentOutOfRangeException: Valid values are between 0 and 999, inclusive. (Parameter 'millisecond')
System.DateTime.ThrowMillisecondOutOfRange()

[midnight epoch]

sqlite

[wheat wigeon]

All good. Also I double checked, UnixEpoch uses DateTime type. We just need to double check how you're reading from the database.

[midnight epoch]

An unhandled exception occurred while processing the request.
ArgumentOutOfRangeException: Valid values are between 0 and 999, inclusive. (Parameter 'millisecond')

System.DateTime.ThrowMillisecondOutOfRange()

ArgumentOutOfRangeException: Valid values are between 0 and 999, inclusive. (Parameter 'millisecond')

    System.DateTime.ThrowMillisecondOutOfRange()
    System.DateTime..ctor(int year, int month, int day, int hour, int minute, int second, int millisecond)
    Microsoft.Data.Sqlite.SqliteValueReader.FromJulianDate(double julianDate)
    Microsoft.Data.Sqlite.SqliteValueReader.GetDateTime(int ordinal)
    Microsoft.Data.Sqlite.SqliteDataReader.GetDateTime(int ordinal)
    lambda_method61(Closure , QueryContext , DbDataReader , ResultContext , SingleQueryResultCoordinator )
    Microsoft.EntityFrameworkCore.Query.Internal.SingleQueryingEnumerable<T>+Enumerator.MoveNext()
    System.Collections.Generic.LargeArrayBuilder<T>.AddRange(IEnumerable<T> items)
    System.Collections.Generic.EnumerableHelpers.ToArray<T>(IEnumerable<T> source)
    System.Linq.Enumerable.ToArray<TSource>(IEnumerable<TSource> source)
    ArraBruh.Controllers.ReviewsController.Reviews() in ReviewsController.cs

            return View(reviews.ToArray());

lambda_method59(Closure , object , object[] )
Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor+SyncActionResultExecutor.Execute(IActionResultTypeMapper mapper, ObjectMethodExecutor executor, object controller, object[] arguments)
Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeActionMethodAsync()
Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(ref State next, ref Scope scope, ref object state, ref bool isCompleted)
Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeNextActionFilterAsync()
Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)
Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(ref State next, ref Scope scope, ref object state, ref bool isCompleted)
Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeInnerFilterAsync()
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeNextResourceFilter>g__Awaited|25_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, object state, bool isCompleted)
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResourceExecutedContextSealed context)
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(ref State next, ref Scope scope, ref object state, ref bool isCompleted)
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeFilterPipelineAsync()
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Logged|17_1(ResourceInvoker invoker)
Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Logged|17_1(ResourceInvoker invoker)
Microsoft.AspNetCore.Routing.EndpointMiddleware.<Invoke>g__AwaitRequestTask|6_0(Endpoint endpoint, Task requestTask, ILogger logger)
Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

[wheat wigeon]

Go to where that line shows that error and show the code related.

I assume this isn't your project or you're trying to fix someone else's 😄

[midnight epoch]

*```cs
{
ViewData["title"] = nameof(Reviews);
var reviews = m_dbContext.Reviews.Select(x => UserReview.FromData(x, UserAccount.FromData(m_dbContext.Users.FirstOrDefault(y => y.Id == x.UserId))));

return View(reviews.ToArray());
}

[wheat wigeon]

Can you show the object properties for Users?

I'm honestly a bit stuck here tbf. I don't quite understand where the implicit time conversion is happening.

Assuming that is the code at fault.

[manic ledge]

what does userreview.fromdata do

[midnight epoch]

that's the worriest, that's my project, I trying to make a website with ASP.NET and EntityFramework with sqlite
...before I use Django, but for now I'd like to use C#(and ASP.NET)

[midnight epoch]

that's no matter, Users for now has 2 properties, Id and Name

[wheat wigeon]

oh, what object is the DateTime part of?

Or which context more specifically

[midnight epoch]

public static IUserReview FromData(Review data, IUserAccount userAccount)
{
    return new UserReview(
        userAccount,

        data.Id,
        data.Text,

        data.IsEdited,
        data.IsDeleted,

        data.EditedAt,
        data.DeletedAt,
        data.CreatedAt);
}```

[midnight epoch]

Review(db model)
and
UserReview(MVC model)

[manic ledge]

i forget what its called but what is the binding for the db model in EF config? like the code that generates the conversion from & to the database

[wheat wigeon]

Sorry, the only reason I said was because of the naming scheme. m_ is definitely not C# standard now-a-days 😄

Anyway. Looking at the code, I really do not see how it's pulling the datetime. If I understand FromData is pulling specific fields? Though, I maybe entirely wrong here.

[midnight epoch]

Review(db model)

public class Review
{
    public string Id { get; set; }
    public string UserId { get; set; }
    public string Text { get; set; }
    
    public bool IsEdited { get; set; }
    public bool IsDeleted { get; set; }

    public DateTime CreatedAt { get; set; }
    public DateTime? EditedAt { get; set; }
    public DateTime? DeletedAt { get; set; }
}

[manic ledge]

do you have anything like that?

[midnight epoch]

in C++ I liked annotations like this, so I use them ;)

[midnight epoch]

no, I'm overriding only OnConfiguring method

strange, that I ran into a problems only with dates, maybe with another complex data types will be same ;)

[wheat wigeon]

Can you comment out that code you have and just pull the entire object where the Ids match for trying to identify the problem.

[midnight epoch]

pull the entire object - m_dbContext.Reviews ?

[wheat wigeon]

Ya, just assign it something.

[midnight epoch]

am I need to override it ?

[wheat wigeon]

var reviewer = m_dbContext.Reviews.FirstOrDefault(x => x.Id == id);
reviewer.CreatedAt; 

See what the type it thinks it is.

idk what your arg passthrough is for Id, but just pull 1 record

[manic ledge]

i dont think you have to

[midnight epoch]

it'll return nothing, if I try to access to entities in .Reviews it throws exception
in debugger I'm trying to get info about object

just as I say

[manic ledge]

it might not know how to convert a sqlite datetime back to a .net datetime

[wheat wigeon]

Weird. I don't have enough C# experience to know where the issue is tbf. But, something between the Type in your model and the database type is going all screwey.

[midnight epoch]

at System.DateTime.ThrowMillisecondOutOfRange()
   at System.DateTime..ctor(Int32 year, Int32 month, Int32 day, Int32 hour, Int32 minute, Int32 second, Int32 millisecond)
   at Microsoft.Data.Sqlite.SqliteValueReader.FromJulianDate(Double julianDate)
   at Microsoft.Data.Sqlite.SqliteValueReader.GetDateTime(Int32 ordinal)
   at Microsoft.Data.Sqlite.SqliteDataReader.GetDateTime(Int32 ordinal)```I guess it throws betwen db model and db

[midnight epoch]

I tried to use 2 annotations, and use DateTimeOffset, but avary time I'm getting the same exception

[wheat wigeon]

Can you get one object from the set so we can analyse that? We don't need the entire set. I kinda want to try and set the Model to be a long then using DateTimeOffset.FromUnixTimeSeconds(inTme out var theTime)

but idk if this will work since I think it's the mapping that's kinda broken? 😄

[midnight epoch]

*FromUnixTimeMilliseconds

and yeah, that's working for now

[wheat wigeon]

Scuffed workaround 😄 definitely going to bite you in the future

Maybe someone more knowledgable can help with a better solution. 😄

[midnight epoch]

Make better SQLite DateTime convert Microsoft.EntityFramework

[midnight epoch]

anyway, thx <3

[wheat wigeon]

Just a thought. Was the type ever changed in from when data was submitted and now?

I may be entirely wrong but I don't see any easy way to get UnixEpoch time? https://learn.microsoft.com/en-us/dotnet/api/system.datetime.unixepoch?view=net-7.0

The only way I see to get the Epoch time it to kinda go out of the way to get it. 😄

(DateTime.UtcNow - new DateTime(1970, 1, 1)).TotalMilliseconds;

Given this, then the correct field type would be a long and not DateTime.

[midnight epoch]

DateTimeOffset.UtcNow.ToUnixEpochMilliseconds()

DateTimeOffset.UtcNow.DateTime - will return DateTime of it