willbond | Stripe Developers | Page 1

dense lotusBOT Jan 5, 2023, 5:20 PM

#

wise furnace Jan 5, 2023, 5:21 PM

#

Hello

#

Reading

#

Huh seems like your VPS is doing some manipulation here

#

My first recommendation would be to confirm that the above is the case. I would log out subscription.customer.toString() and log out type of subscription.customer.toString()

dawn stratus Jan 5, 2023, 5:25 PM

#

Thanks for answering! I did not log typeof subscription.customer, however I did log subscription and I am receiving a valid string (example: customer: 'cus_N7B_________2J')

wise furnace Jan 5, 2023, 5:25 PM

#

Right but for some reason our API thinks that is JSON

dawn stratus Jan 5, 2023, 5:26 PM

#

If it helps, the raw from the StripeAPIError says: exception: SyntaxError: Unexpected token s in JSON at position 58

wise furnace Jan 5, 2023, 5:28 PM

#

Oh

dawn stratus Jan 5, 2023, 5:28 PM

#

I will try without the .toString() method in the VPS, but it doesn't make much sense since the local is working

wise furnace Jan 5, 2023, 5:28 PM

#

Wait wait wait

#

When you log you get customer: 'cus_N7B_________2J'?

#

That is what the whole subscription.customer.toString() logs?

#

Or subscription.customer.toString() logs just the customer ID?

dawn stratus Jan 5, 2023, 5:29 PM

#

Just the customer ID haha I'm sorry

wise furnace Jan 5, 2023, 5:30 PM

#

Haha okay just making sure

dawn stratus Jan 5, 2023, 5:30 PM

#

and its complete too, I just hid the example customer info with the underscores

wise furnace Jan 5, 2023, 5:32 PM

#

Right right

#

Hmmm

#

It works when you hard code the Customer ID I assume?

#

Does it work if you do the stringify before passing it to the Customer retrieve method?

#

Like let cus = subscription.customer.toString() and then await stripe.customers.retrieve(cus)

dawn stratus Jan 5, 2023, 5:36 PM

#

I didn't try to hard code the ID in the VPS 🤔
Thanks for the suggestions, I will try both and BRB with the results

wise furnace Jan 5, 2023, 5:38 PM

#

Sounds good

dawn stratus Jan 5, 2023, 5:49 PM

#

Ok, bad news 😦
On my VPS, even with a hard-coded ID it returns the same Invalid JSON error.
I did also try the stringify first - retrieve after method and got the same results.
I don't know what to try next, suggestions are welcomed

wise furnace Jan 5, 2023, 5:49 PM

#

Woof

#

Do other methods work?

#

Other Stripe methods that is

dawn stratus Jan 5, 2023, 5:56 PM

#

Well, the stripe.webhooks.constructEvent( /*...*/ ) does work
I'm currently only using constructEvent() and customers.retrieve() methods from stripe

#

I use the "new Stripe" method if this changes anything:
const stripe = new Stripe(stripeKey, { apiVersion: "2022-11-15", });

wise furnace Jan 5, 2023, 5:57 PM

#

Don't think that should change anything

dawn stratus Jan 5, 2023, 5:57 PM

#

Also the stripe.customers.retrieve() works locally so I don't think its a problem with the SDK

wise furnace Jan 5, 2023, 5:58 PM

#

Yeah this sounds specifically like your VPS is doing something the Stripe API doesn't like

dawn stratus Jan 5, 2023, 6:00 PM

#

Do you think it has something to do with the apiVersion?

#

Maybe a newer or older wouldn't do it

wise furnace Jan 5, 2023, 6:04 PM

#

No it shouldn't and you are using the newest

#

I'm thinking

#

But coming up empty at the moment

dawn stratus Jan 5, 2023, 6:09 PM

#

So am I, this is kind of crazy

wise furnace Jan 5, 2023, 6:18 PM

#

I have to step away but my teammate is stepping in... they might have some ideas

dawn stratus Jan 5, 2023, 6:19 PM

#

Thanks for the help @wise furnace !
if you come to think at any ideas please message me, I will be happy to read it

robust oar Jan 5, 2023, 6:22 PM

#

Hello! I'm taking over and catching up...

#

That's really strange. I'd love to see the raw data your server is receiving, will need to figure out if there's a way to have the Node library spit that out somewhere. Does the error tell you which part of the Stripe Node library is throwing the error? Like which file?

#

It's probably StripeResource.ts...

#

The error object you get should have several properties you can log to find out more: headers, statusCode, and requestId. Can you log those and provide the output?

dawn stratus Jan 5, 2023, 6:34 PM

#

This is the complete error log

📎 error.log

robust oar Jan 5, 2023, 6:34 PM

#

Undefined? What the heck...

dawn stratus Jan 5, 2023, 6:34 PM

#

Hahah, I know

robust oar Jan 5, 2023, 6:35 PM

#

And position 58...

#

Wow. Let me think about this for a bit...

dawn stratus Jan 5, 2023, 6:35 PM

#

robust oar It's probably `StripeResource.ts`...

It actually is

dawn stratus Jan 5, 2023, 6:37 PM

#

robust oar And position 58...

Yeah, I was thinking it might be a xml return instead of json, but generally on these cases the JSON.parse error is Unexpected token < in JSON at position 0

robust oar Jan 5, 2023, 6:37 PM

#

Yeah, exactly.

#

After this error is thrown is there anything in customer.lastResponse by chance?

#

If so can you log customer.lastResponse.headers and share the output here?

dawn stratus Jan 5, 2023, 6:52 PM

#

I might be wrong but I think customer isn't assigned anything, because the rest of my code under the stripe.customers.retrieve() doesn´t run

#

So if I do log customer.lastResponse.headers, I guess the log won't run and the last thing to run is the retrieve()

robust oar Jan 5, 2023, 6:55 PM

#

Oh, so you're not catching the error? One sec, let me test something...

dawn stratus Jan 5, 2023, 7:01 PM

#

I do have a general try..catch around the webhook, so I think after this JSON.parse error it returns
return res.status(400).send("Webhook Error:", ${err.message});
for the stripe API

#

I don´t have a try..catch just for the stripe.customers.retrieve() tho

robust oar Jan 5, 2023, 7:03 PM

#

Can you try this instead of the await approach you have now?

stripe.customers.retrieve(subscription.customer.toString(), function (customer) {
    console.log(customer);
});

dawn stratus Jan 5, 2023, 7:04 PM

#

Thanks for the suggestions, I will try it and BRB

robust oar Jan 5, 2023, 7:08 PM

#

Hoping to at least get some response headers out of that. 😅

dawn stratus Jan 5, 2023, 7:09 PM

#

robust oar Can you try this instead of the `await` approach you have now? ```js stripe.cus...

Isn't this lacking a .then()? I can't pass a function to params?: CustomerRetrieveParams

#

customers.retrieve(id: string, params?: Stripe.CustomerRetrieveParams, options?: Stripe.RequestOptions)

robust oar Jan 5, 2023, 7:10 PM

#

This is using the older callback approach.

#

It may not be compatible with TypeScript.

dawn stratus Jan 5, 2023, 7:12 PM

#

yeah, I'm getting a "No overload matches this call."

robust oar Jan 5, 2023, 7:14 PM

#

Hm. Okay, let me look through the library's code, hang on...

dawn stratus Jan 5, 2023, 7:16 PM

#

I might try with .then() just to see if we get some headers:
stripe.customers .retrieve(subscription.customer.toString()) .then((customer_: any) => { console.log(customer_); });

robust oar Jan 5, 2023, 7:21 PM

#

Hm. It may not be set at all due to the nature of the error. That's so strange though...

#

What you could do if all else fails is modify StripeResource.js in the Stripe library and add console.log(headers); after this line: https://github.com/stripe/stripe-node/blob/master/lib/StripeResource.js#L157

dawn stratus Jan 5, 2023, 7:25 PM

#

I think we might be focusing too much in the Stripe parse error and ignoring the fact that it does works on the local environment

#

If it was an error in the StripeResource.js, I don´t think it would work on my end too

robust oar Jan 5, 2023, 7:26 PM

#

I don't think it's an error there, I'm trying to figure out where the mangled response is coming from.

#

I think something is intercepting the request.

#

I want to see the response headers to determine where that response is coming from.

dawn stratus Jan 5, 2023, 7:27 PM

#

Oooh I get it

robust oar Jan 5, 2023, 7:29 PM

#

Like if we see headers that indicate the response actually came from Stripe I will be very surprised. 😅 I'm hoping the headers will indicate something like a firewall, security appliance, egress control, or something along those lines is causing the problem.

dawn stratus Jan 5, 2023, 7:33 PM

#

📎 headers.txt

robust oar Jan 5, 2023, 7:34 PM

#

Headers! And they do seem to be coming from Stripe! Which is baffling! 😅

#

That's strange. It's like they're incomplete...

#

🤔

dawn stratus Jan 5, 2023, 7:35 PM

#

I'm also think that it might be something with firewalls or security appliance

dawn stratus Jan 5, 2023, 7:43 PM

#

robust oar That's strange. It's like they're incomplete...

I'm not sure what should be on these, what is what fields are missing?

robust oar Jan 5, 2023, 7:44 PM

#

Okay, let's try this. in NodeHttpClient.js, add a console.log(response); line under this line: https://github.com/stripe/stripe-node/blob/13e955edf64b44aa2f2e90b1228b65caf33cf1a2/lib/net/NodeHttpClient.js#L97

#

Let's see what that response looks like.

dawn stratus Jan 5, 2023, 7:52 PM

#

Ok, 10 mins

robust oar Jan 5, 2023, 8:00 PM

#

Wait!

#

That's the wrong line!

#

After this line: https://github.com/stripe/stripe-node/blob/master/lib/net/NodeHttpClient.js#L98

#

So it would look like this:

      this._res.once('end', () => {
        console.log(response);
        try {
          resolve(JSON.parse(response));
        } catch (e) {
          reject(e);
        }
      });

#

I had an off by one error with the line number, sorry! 😅

robust oar Jan 5, 2023, 8:27 PM

#

Any luck?

dawn stratus Jan 5, 2023, 8:30 PM

#

oh, interesting

 {
   "error": {
     "message": "Invalid API Key provided: "sk_test************************************************************************************************Pckr",
     "type": "invalid_request_error"
   }
 }

robust oar Jan 5, 2023, 8:31 PM

#

😮

#

... That's not valid JSON? 😅

dawn stratus Jan 5, 2023, 8:33 PM

#

I'm honestly lost hahah

robust oar Jan 5, 2023, 8:33 PM

#

Wow, it's not.

dawn stratus Jan 5, 2023, 8:33 PM

#

the "message" line does lack a quote

robust oar Jan 5, 2023, 8:33 PM

#

Oh...

#

Well, the real issue is that the quotes around the redacted key aren't escaped.

#

Wow. Okay.

dawn stratus Jan 5, 2023, 8:34 PM

#

 {
   "error": {
     "message": "Invalid API Key provided: 'sk_test************************************************************************************************Pckr'
",
     "type": "invalid_request_error"
   }
 }

#

it should be something like this

robust oar Jan 5, 2023, 8:35 PM

#

I think it should actually be this:

{
    "error": {
        "message": "Invalid API Key provided: \"sk_test************************************************************************************************Pckr\"",
        "type": "invalid_request_error"
    }
}

dawn stratus Jan 5, 2023, 8:35 PM

#

yeah, you're right, I just noticed

robust oar Jan 5, 2023, 8:35 PM

#

Wild. Okay, we need to fix this on our end and I'll get that work started now. In the meantime, at least you know why the error is happening. Looks like you've got a...

#

Wait.

#

WAIT!

#

Does your key have the quotes included?

#

Like do you have "sk_test_..." as the value instead of sk_test_...?

#

Or just that first " actually.

#

I think we're maybe spitting back what we see coming in, and we're seeing a " come in as part of the key?

#

But we're not escaping it correctly.

dawn stratus Jan 5, 2023, 8:37 PM

#

well, it does have quotes on the .env, but I assume node does parse the quotes

robust oar Jan 5, 2023, 8:37 PM

#

I don't think it does. Try removing the quotes.

dawn stratus Jan 5, 2023, 8:38 PM

#

well, I do use quotes on my pc and its working

#

I guess the .env on the server is missing a quote

robust oar Jan 5, 2023, 8:38 PM

#

Ah, it only has the leading quote?

dawn stratus Jan 5, 2023, 8:39 PM

#

Damn, it was a quote all along. You found it!

robust oar Jan 5, 2023, 8:39 PM

#

That was a wild ride.

dawn stratus Jan 5, 2023, 8:40 PM

#

both my pc and my VPS have the KEY as STRIPE_KEY="sk_test_actualkey", except the VPS was without the finishing comman

robust oar Jan 5, 2023, 8:40 PM

#

Ultimately this is a problem with the API; we are indeed not doing the right thing. I can reproduce with a raw curl command and get back invalid JSON.

#

So we're going to get that fixed!

dawn stratus Jan 5, 2023, 8:40 PM

#

I guess in the end this is a problem with both of our APIs 😅

robust oar Jan 5, 2023, 8:41 PM

#

At least we're not bored!

#

Anything else I can help you with?

dawn stratus Jan 5, 2023, 8:42 PM

#

Nothing else, at least not for now. Thanks for your help @robust oar , I appreciate your concern and calm investigating this with me

robust oar Jan 5, 2023, 8:43 PM

#

Happy to help!

dawn stratus Jan 5, 2023, 8:43 PM

#

Also thanks @wise furnace too!

robust oar Jan 5, 2023, 8:43 PM

#

I'll let them know!

#

Oh, don't forget to undo the changes you made to the Stripe library (or download a fresh unaltered copy). 🙂

#willbond