arn4v | Stripe Developers | Page 1

ruby slateBOT Dec 2, 2022, 7:44 AM

#

spark valve Dec 2, 2022, 7:45 AM

#

hrm, are you using multi-currency prices? https://stripe.com/docs/payments/checkout/present-local-currencies

unborn robin Dec 2, 2022, 7:46 AM

#

Yes, exactly.

#

Note that we are dealing with subscriptions, not one time payments.

spark valve Dec 2, 2022, 7:53 AM

#

hrmhrm, it looks like currency was removed on purpose https://github.com/stripe/stripe-node/issues/1575, https://github.com/stripe/stripe-node/blob/v11.1.0/CHANGELOG.md#10140---2022-10-13

#

gimme a while to take a closer look

#

ignore what i said previously - it was removed for line items only. I see currency defined here : https://github.com/stripe/stripe-node/blob/master/types/Checkout/SessionsResource.d.ts#L55

#

I haven't tested it personally, but how about trying with either currency and/or locale when creating the Checkout Session to see if it's able to override?

#

you should definitely follow up in the ticket though. It sounds like we didn't consider your use case where a Customer is first created and I'd think we should handle such a scenario.

unborn robin Dec 2, 2022, 8:05 AM

#

We're currently on 8.115.0, there's no currency property.

#

Locale is not the problem/use case, so not testing that.

Locale and currency behaviour shouldn't be bundled anyway in my opinion.

spark valve Dec 2, 2022, 8:23 AM

#

okay sorry, this took me a while to track down, it looks like we added currency to SessionCreateParams in https://github.com/stripe/stripe-node/blob/v11.1.0/CHANGELOG.md#9120---2022-07-07 based on the changelog

unborn robin Dec 2, 2022, 8:27 AM

#

Hmm, but as I understand bumping library version also requires bumping the API version we use, right?

spark valve Dec 2, 2022, 8:28 AM

#

no not for node. You can explicitly define the API version to use - https://github.com/stripe/stripe-node#initialize-with-config-object

#

there's some points to note if you're using TypeScript mentioned here : https://github.com/stripe/stripe-node#using-old-api-versions-with-typescript

unborn robin Dec 2, 2022, 8:31 AM

#

Gotcha. Can you help confirm if currency override exists on 2020-08-27?

spark valve Dec 2, 2022, 8:44 AM

#

you mean if the currency parameter exists on API version 2020-08-27?

#

it should, since https://github.com/stripe/stripe-node/blob/v11.1.0/CHANGELOG.md#9120---2022-07-07 was done for the 2022-07-07 API version

GitHub

stripe-node/CHANGELOG.md at v11.1.0 · stripe/stripe-node

Node.js library for the Stripe API. . Contribute to stripe/stripe-node development by creating an account on GitHub.

unborn robin Dec 2, 2022, 8:46 AM

#

spark valve you mean if the currency parameter exists on API version 2020-08-27?

Yes, that's what I mean

unborn robin Dec 2, 2022, 8:46 AM

#

spark valve it should, since https://github.com/stripe/stripe-node/blob/v11.1.0/CHANGELOG.md...

Didn't get you. 2022-07-07 is a newer version than 2020-08-27.

spark valve Dec 2, 2022, 8:46 AM

#

🤦‍♂️

#

sorry my bad

#

so you can use currency on API version 2020-08-27, optional request parameters to existing API methods are backwards compatible. If there're any breaking changes, it'll explicitly be mentioned here : https://stripe.com/docs/upgrades#api-versions

hard dirge Dec 2, 2022, 9:11 AM

#

Hey, taking over here. Let me know if there's any follow-up Qs I can answer!

#arn4v