Error: Cannot access 'ASTRO_VERSION' before initialization | Astro Lounge | Page 1

jolly fox May 21, 2024, 2:24 AM

#

STATUS: solved underlying problem by just using static redirects.

CONTEXT: cloudflare hosted starlight site at https://ratatui.rs
I'm trying to rename some content paths and add redirects.

Added cloudflare adapter, switched to hybrid mode added some ssr settings to the vite config (relevant commit)

Running npm astro build sees the following error:

Cannot access 'ASTRO_VERSION' before initialization
  Stack trace:
    at createAstro (file:///Users/joshka/local/ratatui-website/dist/_worker.js/chunks/astro_AtHjLoge.mjs:393:26)
    at ModuleJob.run (node:internal/modules/esm/module_job:218:25)
    at async BuildPipeline.retrieveManifest (file:///Users/joshka/local/ratatui-website/node_modules/astro/dist/core/build/pipeline.js:93:26)
    at async staticBuild (file:///Users/joshka/local/ratatui-website/node_modules/astro/dist/core/build/static-build.js:108:7)
    at async AstroBuilder.run (file:///Users/joshka/local/ratatui-website/node_modules/astro/dist/core/build/index.js:164:7)

I'm guessing that this is something to do with the way that the async happens here.
I'm not entirely sure how this file is generated (guessing it's vite, but I'm not a frontend dev)
Any ideas on how to fix this?

wintry magnet May 21, 2024, 2:28 AM

#

Did you do npm astro build or npm run build?

If the former, try the latter

jolly fox May 21, 2024, 2:36 AM

#

Same problem - npm astro build runs astro check && astro build, and the problem is in the astro build step.

wintry magnet May 21, 2024, 2:41 AM

#

Okie, lemme look through that commit a bit

Also love your crate name houston_love

jolly fox May 21, 2024, 2:41 AM

#

🙂

jolly fox May 21, 2024, 2:59 AM

#

wintry magnet Okie, lemme look through that commit a bit Also love your crate name <:houston_...

The main bit is up the top, the renames are not too relevant to the change.
npm run dev runs fine locally, it's just the build step.

wintry magnet May 21, 2024, 3:11 AM

#

Hmm tough to say, your implementation seems to be fine

jolly fox May 21, 2024, 3:12 AM

#

I wonder if it's something to do with the ssr external section?

ssr: {
      external: ["node:url", "node:path", "node:child_process"],
    },

Added those to get around errors being spat out from the build steps, but I suspect they will fail on cloudflare as not supported APIs. https://developers.cloudflare.com/workers/runtime-apis/nodejs

wintry magnet May 21, 2024, 3:15 AM

#

If you remove them are you still able to build locally?

jolly fox May 21, 2024, 3:15 AM

#

no

wintry magnet May 21, 2024, 3:15 AM

#

Hmmm

jolly fox May 21, 2024, 3:15 AM

#

20:12:52 [ERROR] [vite] x Build failed in 261ms
[commonjs--resolver] [plugin vite:resolve] Cannot bundle Node.js built-in "node:url" imported from "node_modules/@astrojs/starlight/utils/route-data.ts". Consider disabling ssr.noExternal or remove the built-in dependency.
  Stack trace:
    at getRollupError (file:///Users/joshka/local/ratatui-website/node_modules/rollup/dist/es/shared/parseAst.js:394:41)
    at Object.error (file:///Users/joshka/local/ratatui-website/node_modules/rollup/dist/es/shared/node-entry.js:19593:20)
    at Object.handler (file:///Users/joshka/local/ratatui-website/node_modules/vite/dist/node/chunks/dep-cNe07EU9.js:67676:19)
    at async PluginDriver.hookFirstAndGetPlugin (file:///Users/joshka/local/ratatui-website/node_modules/rollup/dist/es/shared/node-entry.js:19678:28)
    at async ModuleLoader.resolveId (file:///Users/joshka/local/ratatui-website/node_modules/rollup/dist/es/shared/node-entry.js:18762:15)

#

(which might mean that using the cloudflare adapter isn't supported for starlight)

wintry magnet May 21, 2024, 3:16 AM

#

Might not hurt to ask in #starlight to verify

jolly fox May 21, 2024, 3:19 AM

#

done. I might try a minimal repro with starlight a bit later.

#

confirmed this is the same error seen for a standard starlight app, adding the cloudflare adapter

wintry magnet May 21, 2024, 3:37 AM

#

Ah interesting, is there an issue for it on the repo? If not feel free to submit it houston_fingerguns

jolly fox May 21, 2024, 3:39 AM

#

Ah https://github.com/withastro/starlight/issues/1333

GitHub

Can't deploy on Cloudflare · Issue #1333 · withastro/starlight

What version of starlight are you using? 0.15.2 What version of astro are you using? 4.0.9 What package manager are you using? pnpm What operating system are you using? Mac What browser are you usi...

#

I think I'll just slap a bunch of static routes in there instead of the dynamic ones and call it a day

jade bridge May 21, 2024, 9:36 AM

#

jolly fox Ah https://github.com/withastro/starlight/issues/1333

Just noting that this issue is a bit old — we do now support SSR as of Starlight v0.18 (released in February).

#

I haven’t tried with the Cloudflare adapter personally but I believe @mint lotus and @wary tendon have?

wary tendon May 21, 2024, 9:48 AM

#

Yeah I tested it and it worked for me. But this 'ASTRO_VERSION' error comes up from time to time, not sure why, still trying to figure it out 🤔

#

e.g. https://github.com/astrolicious/astro-tips.dev is a starlight site deployed to cloudflare..

jade bridge May 21, 2024, 10:07 AM

#

Interesting. ASTRO_VERSION is not something Starlight accesses, so I guess it’s an issue on the Astro level?

jolly fox May 21, 2024, 10:18 AM

#

node --version
v20.12.2

npm create astro@latest -- --template starlight
cd planetary-parsec
git commit -m 'init'
npm install
npm run build
(succeeds)
npx astro add cloudflare
npm run build
(fails)

03:15:05 [ERROR] [vite] x Build failed in 202ms
[commonjs--resolver] [plugin vite:resolve] Cannot bundle Node.js built-in "node:url" imported from "node_modules/@astrojs/starlight/utils/route-data.ts". Consider disabling ssr.noExternal or remove the built-in dependency.
  Stack trace:
    at getRollupError (file:///Users/joshka/local/planetary-parsec/node_modules/rollup/dist/es/shared/parseAst.js:394:41)
    at Object.error (file:///Users/joshka/local/planetary-parsec/node_modules/rollup/dist/es/shared/node-entry.js:19593:20)
    at Object.handler (file:///Users/joshka/local/planetary-parsec/node_modules/vite/dist/node/chunks/dep-cNe07EU9.js:67676:19)
    at async PluginDriver.hookFirstAndGetPlugin (file:///Users/joshka/local/planetary-parsec/node_modules/rollup/dist/es/shared/node-entry.js:19678:28)
    at async ModuleLoader.resolveId (file:///Users/joshka/local/planetary-parsec/node_modules/rollup/dist/es/shared/node-entry.js:18762:15)

#

added the ssr settings that get past that, boom:

Cannot access 'ASTRO_VERSION' before initialization
  Stack trace:
    at createAstro (file:///Users/joshka/local/planetary-parsec/dist/_worker.js/chunks/astro_BiHw7Ve8.mjs:393:26)
    at ModuleJob.run (node:internal/modules/esm/module_job:222:25)
    at async BuildPipeline.retrieveManifest (file:///Users/joshka/local/planetary-parsec/node_modules/astro/dist/core/build/pipeline.js:93:26)
    at async staticBuild (file:///Users/joshka/local/planetary-parsec/node_modules/astro/dist/core/build/static-build.js:108:7)
    at async AstroBuilder.run (file:///Users/joshka/local/planetary-parsec/node_modules/astro/dist/core/build/index.js:164:7)

#

https://github.com/joshka/planetary-parsec

GitHub

GitHub - joshka/planetary-parsec

Contribute to joshka/planetary-parsec development by creating an account on GitHub.

jade bridge May 21, 2024, 10:25 AM

#

Thanks for the details. Way beyond my knowledge of SSR to be of much use. My understanding was we’d built SSR support in Starlight in such a way that things like that @astrojs/starlight/utils/route-data would run at build time and not need to run in Cloudflare’s environment.

#

Maybe https://github.com/withastro/starlight/pull/1255 will help here — it’s been slow to review because it’s a big PR, but we have now tested it with all adapters, so could help.

#

Although it’s also odd that as Alex mentioned, he has a Starlight site deployed to Cloudflare SSR, so I guess this problem only occurs in specific circumstances.

jolly fox May 21, 2024, 10:30 AM

#

To be clear, the only reason I was worried about this was that I tried to get dynamic redirects to work, which turned into a yak shave. The underlying goal is achieved by using static redirects for the pages in question instead of dynamic.

obtuse bridge May 21, 2024, 12:58 PM

#

Also might wanna add nodejs_compat to your Cloudflare Pages settings

https://developers.cloudflare.com/workers/runtime-apis/nodejs/#enable-nodejs-with-workers

Cloudflare Docs

Node.js compatibility · Cloudflare Workers docs

Implemented Node.js runtime APIs and enablement instructions for your Worker project.

#

You can also do it by adding it in wrangler.toml

jolly fox May 21, 2024, 1:08 PM

#

obtuse bridge Also might wanna add `nodejs_compat` to your Cloudflare Pages settings https:/...

Yeah - I did that in anticipation of deploying the adapter, but it turned out not to be necessary to add the adapter for what we needed

mint lotus May 21, 2024, 1:51 PM

#

Are you running the build portion inside of Cloudflare? That is when that stack trace happens.
I'd suggest building in your preferred CI and deploy just the build result to Cloudflare

jolly fox May 21, 2024, 1:52 PM

#

This is a local build.

#

Minimal repro steps are noted in #1242301878994468916 message with a link to a minimal repro repo just after that

mint lotus May 21, 2024, 1:54 PM

#

Interesting

#

I'll take a look later

jolly fox May 21, 2024, 1:55 PM

#

(no rush - the underlying goal is satisfied)

plain vale May 25, 2024, 10:41 PM

#

I just stumbled across this on a non-startlight site after updating astro - just wondering if anyone had a further look

#

if I take this repo from github https://github.com/IdealProject/ideal - and change it to use astrojs/cloudflare version 10 rather then 9.2.1 I get the ASTRO_VERSION error

#Error: Cannot access 'ASTRO_VERSION' before initialization