#TPDb rate limit not working as expected - still getting error 429

1 messages · Page 1 of 1 (latest)

nova plank
#

Running a big collection update on my end, I found this issue the last couple of days. I saw the chat about a rate limit being implemented in TPDb and also a new commit for PMM that should work around this somehow.

This commit has been in effect for a while but I still did not see any changes in Plex, so I took a look and ran the command twice; the errors start at the exact same poster each run. I have created a test config to limit the time it needs to complete so we can specifically test with that.

visual micaBOT
#

Welcome @nova plank!

Someone from <@&938443185347244033> will assist when they're available.

Including the meta.log from the beginning is a huge help, type !logs for more information.

#

You can press the "Close Post" button above or type /close at any time to close this post.

visual micaBOT
torn dew
#

Thanks for opening the thread

nova plank
visual micaBOT
#

📝 If you want to review this again, minimyself:
:one: Right-click (or long press with phone) on the message that contains the log
:two: Select: Copy Message Link
:three: Use the command: /logscan <message_link> or !logscan <message_link> and paste the value copied from the previous step where you see <message_link> 📝

torn dew
#

I'll review in a bit

nova plank
#

take your time ;)

torn dew
#

Can you provide the yaml you're using

#

It will help if we can run the same thing ourselves

nova plank
#

yes, let me get rid of my connection lines here. 1 minute

visual micaBOT
#

yaml files.

torn dew
#

ty

#

are you browsing TPDb at the same time as running this @nova plank ?

#

I've run the file with no issues

image.png
#

If you're browsing TPDb at the same time then that's likely what's causing this since PMM is using the full rate limit per minute, anything you're doing above and beyond that would cause the rate limit to be exceeded

nova plank
#

I am not no

#

Could it be that the media is not all in my Plex Library, so it does not create the collections except for the ones that it finds.

I added Buddy Games manually at the end since I know that one is in there.

But looking at the collections I see it starting to say 'no poster found' at the eleventh one each time which seems to be right over the limit of requests in 1 minute

#

What I could do is delete PMM and pull it again to make sure the code is up-to-date?

rigid minnow
#

There should be no need for that. git status will show you if it's up to date.

nova plank
#

I don't know if that works in Docker, but the image is up-to-date as far as I can tell with nightly

rigid minnow
#

If you're running docker and are using the most recent image, there's even less reason to nuke it and start again, since there's no way [barring heroic efforts by you or someone with access to the machine] to modify the code inside the image.

nova plank
#

got it, then I am clueless :( I would like it to work but I am unclear about the reason why it fails.
I do know that when I am running it and the limit is hit at 10 request per minute, I can confirm that by going on the website manually.

torn dew
#

I might see the issue

#

yes I see the issue

nova plank
#

do tell!

torn dew
#

Let me review the relevant code to be 100%

#

Okay so

#

The rate limiter is only brought in when PMM uploads the image to Plex

#

which isn't done on subsequent runs since the image is already set

#

it's an oversight in the code

nova plank
#

Riiight, I think I get what you mean. In my case it does not even create a collection the first 10 requests. So it is not uploading anything to Plex at that point. But it does seem to hit the limit.

After, when it finally gets to another collection where it meets the requirements and it will create the collection: the poster is not found on the page because it displays the 429 error and the collection is created without a poster.
No matter how many times I run it.

You are saying the same logic will apply if the collections and/or images already exist in plex/the asset folder?

torn dew
#

Even if the collection isn't created, PMM verifies that the URL is valid which counts as a tick on TPDB's side

#

but PMM isn't counting that as a tick to PMM's rate limit

nova plank
#

aha, then yes that is a valid bug if this is something you would want to count

torn dew
#

Using local assets will resolve this if you have prioritize_assets: true in your settings

#

Actually it may not if the collection isn't created

#

since the poster wouldn't download

#

There'll need to be a code update to truly resolve this

nova plank
nova plank
torn dew
#

Yeah 🙂

nova plank
#

Let me know if I can test anything further after updates are done, if any.

torn dew
#

We'll definitely need to address this

#

I don't have the coding knowledge to resolve it myself, but I've made the developer aware

#

as you've maybe seen in #announcements we're going through a big rebranding effort, so I don't know how quickly this particular issue will be fixed

#

hopefully sooner rather than later

#

keep an eye on #nightly-updates 🙂

nova plank
#

Thanks for the quick analysis! I will patiently wait for any updates, no rush. I understand priorities ;)

torn dew
torn dew
#

This has been resolved in nightly @nova plank

nova plank
#

I will confirm tonight, in about 7 hours

nova plank
#

I did another couple runs after the nightly fix, 0 errors/warnings now!

torn dew
#

yay 🙂

#

I'll close this thread

#

thanks for verifying