streaming.yml modification - filename regex | Kometa | Page 3

distant needle Nov 21, 2023, 1:20 PM

#

And set it to something else, exit. Go back in and set it back to what you want

modest dove Nov 21, 2023, 1:20 PM

#

but might have been from before i changed dirs

distant needle Nov 21, 2023, 1:21 PM

#

Remove overlay label as well

#

just manually set it to a non-overlaid version for now and remove overlay label

#

On next run, it should resolve

modest dove Nov 21, 2023, 1:21 PM

#

ok

#

yea not a big deal

#

one show outa hundreds

#

one thing otherwise

distant needle Nov 21, 2023, 1:22 PM

#

For some people that's the biggest deal in the world. Different people have different priorities

modest dove Nov 21, 2023, 1:22 PM

#

distant needle Nov 21, 2023, 1:22 PM

#

Ahhh

modest dove Nov 21, 2023, 1:22 PM

#

is this because it was set to an overlay?

#

and it overlaid the overlay?

#

or something else

#

only one ive seen so far

#

scrolling through them all

distant needle Nov 21, 2023, 1:23 PM

#

Check the logs

#

Meta.log should have entry for Barry

modest dove Nov 21, 2023, 1:23 PM

#

so obvious 😛 youre so smart

distant needle Nov 21, 2023, 1:23 PM

#

And you can see

#

We check the exif tag to be extra sure that we don't double up on overlays

#

We check the exif tag to be extra sure that we don't double up on overlays

modest dove Nov 21, 2023, 1:25 PM

#

| Barry |
[2023-11-21 06:55:33,459] [overlays.py:192] [TRACE] | Overlay Reason: New image detected |
[2023-11-21 06:55:33,569] [overlays.py:358] [INFO] | Overlays Applied: Overlay File (0) Amazon, Overlay File (0) WEB, Overlay File (4) ended_shows |
[2023-11-21 06:55:33,687] [overlays.py:180] [INFO] | |
| Based on a True Story |

#

yea

distant needle Nov 21, 2023, 1:25 PM

#

So we should not be overlaying that.

modest dove Nov 21, 2023, 1:25 PM

#

it doubled the regex

#

but i'm not sure why

#

let me go to that dir

distant needle Nov 21, 2023, 1:25 PM

#

File name?

modest dove Nov 21, 2023, 1:25 PM

#

series

#

📎 message.txt

#

i'm gonna upgrade S01

#

and say fuck it

distant needle Nov 21, 2023, 1:26 PM

#

Ohhhh and inside of that folder you probably have mixed episodes

modest dove Nov 21, 2023, 1:26 PM

#

yea

#

but i thoguht you or someone aid it takes the one that matches the most?

#

were they tied?

#

lol

distant needle Nov 21, 2023, 1:27 PM

#

Are you using weights

modest dove Nov 21, 2023, 1:27 PM

#

yes

#

i should adjust them?

#

i lower preferred or no

distant needle Nov 21, 2023, 1:27 PM

#

Well... if the weights are all different, then this should not happen

modest dove Nov 21, 2023, 1:27 PM

#

there's literally twice as much AMZN as WEB

distant needle Nov 21, 2023, 1:27 PM

#

We don't "add" weights

modest dove Nov 21, 2023, 1:28 PM

#

and the same amount of HMAX

distant needle Nov 21, 2023, 1:28 PM

#

Wait... you are talking about percentage stuff

modest dove Nov 21, 2023, 1:28 PM

#

OHHH

#

i dont think i got HMAX as a tag in my regex

#

so it would be tied

#

but they are weighted

thorn thistle Nov 21, 2023, 1:29 PM

#

highest weight wins

distant needle Nov 21, 2023, 1:29 PM

#

Any ideas why Barry would have both applied? Web and Amazon overlay?

thorn thistle Nov 21, 2023, 1:29 PM

#

yea he just said why

modest dove Nov 21, 2023, 1:29 PM

#

are they added

thorn thistle Nov 21, 2023, 1:29 PM

#

he doesnt have HMAX in the regex

modest dove Nov 21, 2023, 1:29 PM

#

thing is

#

web is weighted 90

distant needle Nov 21, 2023, 1:29 PM

#

They are not added

thorn thistle Nov 21, 2023, 1:29 PM

#

so web-dl matches the regular and HMAX ones

modest dove Nov 21, 2023, 1:29 PM

#

amazon is weighted like 1600

distant needle Nov 21, 2023, 1:30 PM

#

They are not added

modest dove Nov 21, 2023, 1:30 PM

#

ok.

#

but 1600 > 90

#

regardless of if you added only the web

distant needle Nov 21, 2023, 1:30 PM

#

Is it?

modest dove Nov 21, 2023, 1:30 PM

#

i mean....numbers?

distant needle Nov 21, 2023, 1:30 PM

#

I wonder if it thinks that is a string

modest dove Nov 21, 2023, 1:30 PM

#

lol

#

thinks what is a string

distant needle Nov 21, 2023, 1:31 PM

#

1900 and 90

#

90 would be higher in a string sort

modest dove Nov 21, 2023, 1:31 PM

#

  Amazon:
    template:
      - name: rip_source
        weight: 1600
        regex: '(?i)\b(amzn|amazon)\b'```

#

oh so lower is preferred?

distant needle Nov 21, 2023, 1:31 PM

#

String sort

thorn thistle Nov 21, 2023, 1:31 PM

#

higher should always win

modest dove Nov 21, 2023, 1:31 PM

#

oh

distant needle Nov 21, 2023, 1:31 PM

#

Not integer sort

modest dove Nov 21, 2023, 1:31 PM

#

i mean it should become a number

#

ill change to 190

#

ohh that would still do it

distant needle Nov 21, 2023, 1:32 PM

#

I agree... and we would have seen that bug

modest dove Nov 21, 2023, 1:32 PM

#

here let me show you the config

#

📎 message.txt

thorn thistle Nov 21, 2023, 1:32 PM

#

i think supression would be good for this @distant needle

distant needle Nov 21, 2023, 1:32 PM

#

Because we have weights that are 2 and 3 digits in some files I believe

thorn thistle Nov 21, 2023, 1:33 PM

#

like we use in resolution/edition

distant needle Nov 21, 2023, 1:33 PM

#

Maybe yeah...

thorn thistle Nov 21, 2023, 1:33 PM

#

like use suppression with a conditional that says if the service overlay is used, supress the web

distant needle Nov 21, 2023, 1:33 PM

#

Weight should deal with that

#

I am just wondering what happens when there is a mix of items in a tv show episodes list

#

How does it roll up to the show and season posters

thorn thistle Nov 21, 2023, 1:35 PM

#

it uses percentage

#

the log shows the percentage too

#

the percentage of the overlay applied

modest dove Nov 21, 2023, 1:36 PM

#

where is this, what can i search for

thorn thistle Nov 21, 2023, 1:36 PM

#

percentage

#

i dont remember the full line

#

[2023-11-18 08:37:30,957] [overlays.py:396]           [INFO]     |================================ Gathering Items for 4K-DV Overlay =================================|
[2023-11-18 08:37:30,957] [builder.py:2691]           [INFO]     |                                                                                                    |
[2023-11-18 08:37:30,957] [builder.py:2693]           [INFO]     | Collection Filter episodes: {'has_dolby_vision': True, 'percentage': 50}                           |
[2023-11-18 08:37:30,957] [overlays.py:404]           [DEBUG]    |                                                                                                    |
[2023-11-18 08:37:30,957] [overlays.py:405]           [DEBUG]    | Builder: plex_search: (2, "Plex Show Search\nSort By: ['title.asc']\nFilter:\n  Match all of the following:\n    Match any of the following:\n      Resolution is 4K", '?type=2&sort=titleSort&push=1&episode.resolution=4k&pop=1') |
[2023-11-18 08:37:30,957] [overlays.py:406]           [INFO]     |                                                                                                    |
[2023-11-18 08:37:30,957] [plex.py:1071]              [INFO]     | Processing Plex Show Search                                                                        |
                                                                 | Sort By: ['title.asc']                                                                             |
                                                                 | Filter:                                                                                            |
                                                                 |   Match all of the following:                                                                      |
                                                                 |     Match any of the following:                                                                    |
                                                                 |       Resolution is 4K                                                                             |

#

Collection Filter episodes: {'has_dolby_vision': True, 'percentage': 50}

modest dove Nov 21, 2023, 1:38 PM

#

but i mean thatll show up a million times then

#

lol

distant needle Nov 21, 2023, 1:39 PM

#

It's only scrolling and reading....

modest dove Nov 21, 2023, 1:40 PM

#

[2023-11-21 06:53:29,552] [builder.py:2693] [INFO] | Collection Filter episodes: {'filepath.regex': ['(?i)^(?!.(amzn|amazon|atvp|aptv|Apple TV|Canal|CW|CC|DISC|DSC|dsnp|dsny|disney|hbo|ma|nf|netflix|P(ea)?co(c)?k|sho|stan)\b).\bWEB[ _-]?(DL|Rip)?'], 'percentage': 50} |

#

this is where s01 of barry shows up

distant needle Nov 21, 2023, 1:40 PM

#

So does this mean that it found 50%?

thorn thistle Nov 21, 2023, 1:41 PM

#

i assume so. I just remember seeing percentage in a log I was looking at yesterday

#

I never saw it before

#

but it only shows under overlays

#

so I assumed it was for the percentage of matches

modest dove Nov 21, 2023, 1:42 PM

#

why is [2023-11-21 06:53:05,989] [builder.py:2693] [INFO] | Collection Filter episodes: {'filepath.regex': ['(?i)\b(sho|showtime)\b'], 'percentage': 50} |

#

[2023-11-21 06:53:06,025] [util.py:541] [TRACE] | Regex Values: ['/tv/1923/S01/1923 (2022) - S01E03 - The War Has Come Home [AMZN DDP 5.1 WEBDL-1080p][h264]-NTb.mkv'] |

#

matching all this shit

#

does that not mean it matched?

#

cuz it doesnt make sense

thorn thistle Nov 21, 2023, 1:44 PM

#

its probably not matching it, its likely just scanning file by file 🤷‍♂️

modest dove Nov 21, 2023, 1:45 PM

#

oh

#

im just gonna upgrade the fucking S01

#

and keep looking

#

i havent seen any others yet

#

can i get a review on my weights?

#

they look fine?

thorn thistle Nov 21, 2023, 1:50 PM

#

@distant needle what if he used a group again? we couldnt use group because he was using queues and queues cant use groups

#

I think group only allows 1 overlay to apply

#

yep

#

Overlay groups are defined by the name given to the group attribute. Only one overlay with the highest weight per group will be applied.

#

I would go back to using a group @modest dove

modest dove Nov 21, 2023, 1:52 PM

#

just thrwo group: sources in there?

#

that's all?

#

in overlay?

thorn thistle Nov 21, 2023, 1:53 PM

#

    overlay:
      name: <<overlay_name>>
      file: /config/sources/<<overlay>>.png
      back_color: <<back_color>>
      back_width: <<back_width>>
      back_height: <<back_height>>
      font: <<font>>
      font_size: <<font_size>>
      font_color: <<font_color>>
      back_radius: <<back_radius>>
      horizontal_offset: <<horizontal_offset>>
      horizontal_align: <<horizontal_align>>
      vertical_offset: <<vertical_offset>>
      vertical_align: <<vertical_align>>
      weight: <<weight_<<key>>>>
      group: sources

modest dove Nov 21, 2023, 1:53 PM

#

ya that's what i thought

#

found 2 that werent tagged

#

and that barry shit

#

i need to add starz

#

lol

#

rick and morty, silicon valley, and power

#

(just making notes so i dnt lose them)

thorn thistle Nov 21, 2023, 1:54 PM

#

btw this is suppression if your curious. we use it in resolution. basically if a 4k hdr movie is found itll use the combined 4k-hdr.png instead of applying 4k.png, hdr.png and 4k-hdr.png

#

https://metamanager.wiki/en/latest/metadata/overlay.html#suppress-overlays

#

but group should work for you

modest dove Nov 21, 2023, 1:56 PM

#

superstore

#

#

another dupe

#

but as u said group should fix that

#

k thats all

thorn thistle Nov 21, 2023, 1:57 PM

#

yea that one added 3

modest dove Nov 21, 2023, 1:58 PM

#

i know

#

lol

#

should i weigh these based on preference?

#

like how does this essentially work with weights

#

shouldnt have the overlay issue in movies since theres only one file

thorn thistle Nov 21, 2023, 2:00 PM

#

i personally would only worry about blu ray, dvd and web. you shouldnt have any file names with AMZN DSNP fo rexample

#

but you always have WEB

modest dove Nov 21, 2023, 2:00 PM

#

web excludes matching of the streaming tags

thorn thistle Nov 21, 2023, 2:00 PM

#

well i guess you could on the show level

modest dove Nov 21, 2023, 2:01 PM

#

i do a negative lookaround

thorn thistle Nov 21, 2023, 2:01 PM

#

so yea I would weigh in order of preference

modest dove Nov 21, 2023, 2:01 PM

#

higher or lower is better

#

i'm confused on that

#

if i prefer if there are amazons to show amazon

#

i'd put it lower?

thorn thistle Nov 21, 2023, 2:01 PM

#

highest integer being your most preferred

modest dove Nov 21, 2023, 2:02 PM

#

that's what i assumed

#

thanks

#

#

weird.

#

i'm going to get donuts ill be back in a few

#

nevermind i just remember my car is at the dealership

#

smh

glass spire Nov 21, 2023, 3:39 PM

#

now I want some donuts 😭

modest dove Nov 21, 2023, 4:10 PM

#

so i'm down to nitpicking

#

the disney logo i also too tall so it gets squished like bluray did, and the moviesanywhere logo looks a bit out of place

#

:/

ancient ice Nov 21, 2023, 4:33 PM

#

fix it

#

😄

modest dove Nov 21, 2023, 4:33 PM

#

not a graphical person :/

ancient ice Nov 21, 2023, 4:35 PM

#

modest dove Nov 21, 2023, 4:36 PM

#

blue? lol

ancient ice Nov 21, 2023, 4:36 PM

#

it#s a blue logo

#

what did you want your majesty

#

😛

modest dove Nov 21, 2023, 4:36 PM

#

lol i am googling now

#

you're right its like dark blue

#

i thought it was white

ancient ice Nov 21, 2023, 4:36 PM

#

if it pleases you

modest dove Nov 21, 2023, 4:37 PM

#

LOL

#

❤️

#

can you pretty please with sugar on top make the text on the MoviesAnywhere png white?

ancient ice Nov 21, 2023, 4:37 PM

#

send it

modest dove Nov 21, 2023, 4:38 PM

#

its ont he repo hld on lemme pull it up

#

ancient ice Nov 21, 2023, 4:40 PM

#

modest dove Nov 21, 2023, 4:40 PM

#

testyou changed it?

ancient ice Nov 21, 2023, 4:40 PM

#

some white was showing behind the logo

modest dove Nov 21, 2023, 4:41 PM

#

#

PERFECT!

#

lol

ancient ice Nov 21, 2023, 4:42 PM

#

ah yes

#

lovely

modest dove Nov 21, 2023, 4:43 PM

#

rerunning test

#

whats a standard height?

#

i screwed up my AR

#

lol

ancient ice Nov 21, 2023, 4:43 PM

#

idfk

modest dove Nov 21, 2023, 4:43 PM

#

lolol

ancient ice Nov 21, 2023, 4:43 PM

#

😄

modest dove Nov 21, 2023, 4:44 PM

#

im also getting weird no 576 720p 2160p regex errors

#

and i guess 2160 i dont have, but i know i have the other two

ancient ice Nov 21, 2023, 4:44 PM

#

do you have case insensitive?

#

720p v 720P

modest dove Nov 21, 2023, 4:45 PM

#

its the default resolution template thing

ancient ice Nov 21, 2023, 4:45 PM

#

ah ok

modest dove Nov 21, 2023, 4:45 PM

#

i didnt do this for resolution

ancient ice Nov 21, 2023, 4:45 PM

#

I trust them more than you 😄

modest dove Nov 21, 2023, 4:45 PM

#

you guys had that covered

ancient ice Nov 21, 2023, 4:45 PM

#

I blame your library

modest dove Nov 21, 2023, 4:47 PM

#

yea its not lacking.

jovial thornBOT Nov 21, 2023, 4:47 PM

#

TRaSH Guides Naming Scheme

When using third-party services such as Sonarr or Radarr to manage media, we recommend following the TRaSH Guides Recommended Naming Scheme guide to ensure compatibility when using the PMM Default Overlay files.

Without using these naming schemes, we cannot guarantee that the default PMM overlays will work with your library.

Further information can be found on the TRaSH Guides website:

ancient ice Nov 21, 2023, 4:47 PM

#

👼

modest dove Nov 21, 2023, 4:47 PM

#

bro

ancient ice Nov 21, 2023, 4:47 PM

#

LOL

modest dove Nov 21, 2023, 4:47 PM

#

ancient ice Nov 21, 2023, 4:48 PM

#

contribute but can't name your files correctly

#

🤷‍♂️

#

💅

#

I'm telling TRaSH 🤣

modest dove Nov 21, 2023, 4:49 PM

#

i see the problem

#

ancient ice Nov 21, 2023, 4:49 PM

#

is it you?

#

are you the problem?

#

😄

modest dove Nov 21, 2023, 4:49 PM

#

sonarr is doing 480p for 576

ancient ice Nov 21, 2023, 4:49 PM

#

ah

modest dove Nov 21, 2023, 4:50 PM

#

#

yep

#

i only get 576p for bluray

#

that ive seen and just want to archive

ancient ice Nov 21, 2023, 4:50 PM

#

time for a sonarr fork

#

zakarr

modest dove Nov 21, 2023, 4:50 PM

#

im not sure they have a bluray576p

#

bro i got too many repo's and projects im on already

ancient ice Nov 21, 2023, 4:50 PM

#

🤣

modest dove Nov 21, 2023, 4:50 PM

#

i cant fork a language i dont know

#

and learn it

#

that's nuts

ancient ice Nov 21, 2023, 4:51 PM

#

still waiting for you to make the PMM GUI

modest dove Nov 21, 2023, 4:51 PM

#

its almost done

#

i gotchu

ancient ice Nov 21, 2023, 4:51 PM

#

yas

#

you'll get a $2 gift card to Walmart when it's done

modest dove Nov 21, 2023, 4:56 PM

#

ancient ice Nov 21, 2023, 4:56 PM

#

yas

modest dove Nov 21, 2023, 4:57 PM

#

#

perfect

#

    - pmm: audio_codec
          vertical_offset: 15```

vocal turtleBOT Nov 21, 2023, 4:59 PM

#

YAML checked and is NOT valid. Error message:

mapping values are not allowed here
in "<unicode string>", line 3, column 26:
vertical_offset: 15
^

modest dove Nov 21, 2023, 4:59 PM

#

yea no shit.

#

lol

#

forgot template i guess?

#

it doesnt look like it changed it though

ancient ice Nov 21, 2023, 5:02 PM

#

- pmm: audio_codec
  template_variables:
    vertical_offset: 15

#

or try setting style: standard

#

which adjusts the back height from 105 to 189

modest dove Nov 21, 2023, 5:04 PM

#

| 2 | Plex Error: resolution: No matches found with regex pattern (?i)720

#

i know that i have 720

ancient ice Nov 21, 2023, 5:05 PM

#

🤷‍♂️

#

not according to the regex 😄

modest dove Nov 21, 2023, 5:05 PM

#

ancient ice ```yml - pmm: audio_codec template_variables: vertical_offset: 15 ```

| 1 | YAML Error: while constructing a mapping

ancient ice Nov 21, 2023, 5:05 PM

#

nuh uh

#

i blame you

#

what'd you do

modest dove Nov 21, 2023, 5:05 PM

#

oh you know what it is

#

test library....

#

the other thing is valid, sonarr is broken

#

markus is parsing 576 as 480p

#

there are no 576 resolutions in the quality profiles

#

                        resolution == Resolution.R540p || resolution == Resolution.R576p)
                    {
                        result.Quality = Quality.Bluray480p;
                        return result;
                    }```

ancient ice Nov 21, 2023, 5:06 PM

#

💩

#

It doesn't really mater does it?

#

matter*

#

it'll match at 480

modest dove Nov 21, 2023, 5:09 PM

#

yea cuz we are obviously not nitpicking this right?

#

https://tenor.com/view/eye-roll-annoyed-sassy-gif-165183114244591379

Tenor

ancient ice Nov 21, 2023, 5:15 PM

#

what about 360p 😮

modest dove Nov 21, 2023, 5:26 PM

#

that's like handycam footage from 1998

ancient ice Nov 21, 2023, 5:30 PM

#

sonarr won't take it as 360p though

#

right?

#

so you have the same issue with that 😄

modest dove Nov 21, 2023, 5:31 PM

#

i dont give a fuck about 360

ancient ice Nov 21, 2023, 5:31 PM

#

hahaha

modest dove Nov 21, 2023, 5:31 PM

#

but im raising the issue

#

and it should be fixed

modest dove Nov 21, 2023, 6:23 PM

#

https://github.com/Sonarr/Sonarr/issues/6203

jovial thornBOT Nov 21, 2023, 6:23 PM

#

Sonarr/Sonarr

Issue #6203 | Add 576p Bluray Resolution

Is there an existing issue for this?

[X] I have searched the existing open and closed issues

Is your feature request related to a problem? Please describe

https://github.com/Sonarr/Sonarr/blob/c7824bb593291634bf14a5f7aa689666969b03bf/src/NzbDrone.Core/Parser/QualityParser.cs#L150-L155

This causes 576p to incorrectly parse, not as 576p but 480p instead.

This also applies to 360p and 540p but those are admittedly much less common than 576 would be.

Describe the solution you'd like

Correctly identify 576p

Describe alternatives you've considered

.

Anything else?

No response

State:

open

Comments:

1

Is Locked:

False

Labels:

enhancement, up-for-grabs

Reactions:

0 👍 | 0 👎 | 0 😄 | 0 😕 | 0 ❤️ | 1 🎉 | 0 🚀 | 0 👀

modest dove Nov 21, 2023, 6:44 PM

#

fuck it

glass spire Nov 21, 2023, 7:18 PM

#

expect the bork

modest dove Nov 21, 2023, 7:18 PM

#

well see.

distant needle Nov 21, 2023, 8:50 PM

#

1998 was a good year

#

Everyone in It was highly sought after because of the Y2K bug

#

Which was the biggest non-event ever

#

So I also recall that this thread mentioned.... we want color overlays

#

All of a sudden, things have changed...

#

All good though.

#

Do I need to update anything in the video_format folder on our images repo?

modest dove Nov 21, 2023, 10:11 PM

#

so just one show i cant figure out why it wont match bluray, or max, or amzn

modest dove Nov 21, 2023, 10:30 PM

#

yea i've checked logs

#

i must be missing something, but i dont know how it would be not applying to just this one show that follows the same naming scheme

#

its got HMAX, Bluray, amzn, and none of them are overlaying, but i dont see any others anywhere

distant needle Nov 21, 2023, 11:06 PM

#

Do you know if the Overlay label is there which makes PMM believe there is an overlay already and hence won't apply?

jovial thornBOT Nov 21, 2023, 11:07 PM

#

Understanding the Overlay label

When PMM applies an overlay, it attaches an Overlay label to the item so that it knows what has an Overlay and what does not. If you [or plex] changes the image, then PMM has no way of knowing this. The easiest way to force overlays to apply to a "new" image is to remove the Overlay label either before or after you change the image.

Unfortunately, Plex does not display the labels attached to Seasons or Episodes, so we have to use collections to force a remove of these labels (we make sure the collection isn't actually built).

Removing Season Overlay Label

collections:
  Remove Overlay Labels:
    build_collection: false
    builder_level: season
    item_label.remove: Overlay
    plex_search:
      all:
        season_label: Overlay
        title:  NAME OF SHOW HERE

Removing Episode Overlay Label

collections:
  Remove Overlay Labels:
    build_collection: false
    builder_level: episode
    item_label.remove: Overlay
    plex_search:
      all:
        episode_label: Overlay
        title:  NAME OF SHOW HERE

modest dove Nov 21, 2023, 11:07 PM

#

i changed the poster to a blank one

#

now it doesnt do anything

distant needle Nov 21, 2023, 11:07 PM

#

The label

#

Is it a movie or show

modest dove Nov 21, 2023, 11:08 PM

#

show

#

Rick and Morty

distant needle Nov 21, 2023, 11:08 PM

#

See the bottom@of the bot message there

modest dove Nov 21, 2023, 11:08 PM

#

it put the status overlay on it

distant needle Nov 21, 2023, 11:08 PM

#

Oh

modest dove Nov 21, 2023, 11:08 PM

#

just not the sources

#

but i checked the files

#

and at least 2 of the schemes match something

#

and even if it didnt, web would match

#

there's bluray, hbomax, and amzn

distant needle Nov 21, 2023, 11:09 PM

#

And no errors in the log

modest dove Nov 21, 2023, 11:09 PM

#

and all of those labels are being applied elsewhere

#

not that i could find

#

it regex's them

#

then no updates needed

#

i'm gonna run again in a second

#

i can send the latest

distant needle Nov 21, 2023, 11:09 PM

#

Ok... is this a test library or product Plex library

modest dove Nov 21, 2023, 11:09 PM

#

📎 meta.log

#

this is my last run

vocal turtleBOT Nov 21, 2023, 11:09 PM

#

📝 Great! Let's start to review and make recommendations, zak.ary... 📝

#

📝 If you want to review this again, zak.ary:
:one: Right-click (or long press with phone) on the message that contains the log
:two: Select: Copy Message Link
:three: Use the command: /logscan <message_link> or !logscan <message_link> and paste the value copied from the previous step where you see <message_link> 📝

#

**User Info**

Table of Contents:
Page 01: User Info
Page 02: PMM Info
Page 03: PMM Summary Info
Page 04: PMM Config.yml YAML Validation ✅
Page 05: Plex Configuration - Section 1
Page 06: Plex Configuration - Section 2
Page 07: Rec 01 - 💬 CONVERT ERROR
Page 08: Rec 02 - 💬 LEGACY SCHEMA DETECTED
Page 09: Rec 03 - 💥 NO ITEMS FOUND IN PLEX
Page 10: Rec 04 - ❌ PLEX REGEX ERROR

#

📎 parsed_meta.log_config.yml

distant needle Nov 21, 2023, 11:10 PM

#

Ok... this is not a test library

modest dove Nov 21, 2023, 11:10 PM

#

lol no i ran through the whole thing

#

and this is the outlier

#

everything else is solid

distant needle Nov 21, 2023, 11:11 PM

#

If you move Rick and Morty to your test library, same problem?

modest dove Nov 21, 2023, 11:11 PM

#

let me try it

distant needle Nov 21, 2023, 11:11 PM

#

This way we can isolate it

modest dove Nov 21, 2023, 11:11 PM

#

gimme a few ill tag you when i have the log

distant needle Nov 21, 2023, 11:11 PM

#

Sure thing

modest dove Nov 21, 2023, 11:11 PM

#

thx

#

i'm linking the entire folder

#

just so its not anything different

#

like the exact same naming, ALL the same files, etc

distant needle Nov 21, 2023, 11:14 PM

#

Sure symlinks.

modest dove Nov 21, 2023, 11:28 PM

#

ya its doing the same thing

#

can pmm not tell when i change a poster back to default @distant needle

snow wren Nov 21, 2023, 11:31 PM

#

PMM has no idea what you may have done with the art in Plex

modest dove Nov 21, 2023, 11:31 PM

#

so how does it know which poster to apply the overlay too

#

i chose a different image so i can see the background and adjust it

#

and now its not updating

snow wren Nov 21, 2023, 11:32 PM

#

The first time it applies an overlay, it takes a backup of the current art. That backup is used as the base for future overlay changes.

modest dove Nov 21, 2023, 11:32 PM

#

so delete from overlays

#

and it will grab it again

snow wren Nov 21, 2023, 11:32 PM

#

If you change the art in Plex, you have to remove the Overlay sharing label to get it to pull that new art.

#

Removing the backup won't do that.

#

It will just cause trouble

#

Just remove the label if you change art in Plex

#

Or better, don't change art in Plex and use the asset directory instead.

modest dove Nov 21, 2023, 11:34 PM

#

#

that?

snow wren Nov 21, 2023, 11:34 PM

#

No. In Plex. Edit the item, go to Sharing labels

modest dove Nov 21, 2023, 11:36 PM

#

thanks

snow wren Nov 21, 2023, 11:36 PM

#

distant needle Nov 21, 2023, 11:36 PM

#

He is on Shows Carrot

modest dove Nov 21, 2023, 11:37 PM

#

i got it

distant needle Nov 21, 2023, 11:37 PM

#

Shows does not expose this

#

That's why I shared the cakey

modest dove Nov 21, 2023, 11:37 PM

#

📎 meta.log

vocal turtleBOT Nov 21, 2023, 11:37 PM

#

📝 Great! Let's start to review and make recommendations, zak.ary... 📝

#

📝 If you want to review this again, zak.ary:
:one: Right-click (or long press with phone) on the message that contains the log
:two: Select: Copy Message Link
:three: Use the command: /logscan <message_link> or !logscan <message_link> and paste the value copied from the previous step where you see <message_link> 📝

distant needle Nov 21, 2023, 11:37 PM

#

!overlabels

vocal turtleBOT Nov 21, 2023, 11:37 PM

#

**User Info**

Table of Contents:
Page 01: User Info
Page 02: PMM Info
Page 03: PMM Summary Info
Page 04: PMM Config.yml YAML Validation ✅
Page 05: Plex Configuration - Section 1
Page 06: Plex Configuration - Section 2
Page 07: Rec 01 - 💬 LEGACY SCHEMA DETECTED
Page 08: Rec 02 - 💥 NO ITEMS FOUND IN PLEX
Page 09: Rec 03 - ❌ PLEX REGEX ERROR

#

📎 parsed_meta.log_config.yml

thorn thistle Nov 21, 2023, 11:37 PM

#

Shows does expose labels

modest dove Nov 21, 2023, 11:37 PM

#

everything is applying

thorn thistle Nov 21, 2023, 11:37 PM

#

It's episodes and seasons that dont

modest dove Nov 21, 2023, 11:37 PM

#

except HBOMAX AMZN or Bluray

#

all of which have files

#

yea i had labels

#

i removed overlay

jovial thornBOT Nov 21, 2023, 11:38 PM

#

Understanding the Overlay label

When PMM applies an overlay, it attaches an Overlay label to the item so that it knows what has an Overlay and what does not. If you [or plex] changes the image, then PMM has no way of knowing this. The easiest way to force overlays to apply to a "new" image is to remove the Overlay label either before or after you change the image.

Unfortunately, Plex does not display the labels attached to Seasons or Episodes, so we have to use collections to force a remove of these labels (we make sure the collection isn't actually built).

Removing Season Overlay Label

collections:
  Remove Overlay Labels:
    build_collection: false
    builder_level: season
    item_label.remove: Overlay
    plex_search:
      all:
        season_label: Overlay
        title:  NAME OF SHOW HERE

Removing Episode Overlay Label

collections:
  Remove Overlay Labels:
    build_collection: false
    builder_level: episode
    item_label.remove: Overlay
    plex_search:
      all:
        episode_label: Overlay
        title:  NAME OF SHOW HERE

modest dove Nov 21, 2023, 11:38 PM

#

#

that little dot is supposed to be there

#

but im supposed to have a thing in the top left like i've shown you

#

distant needle Nov 21, 2023, 11:40 PM

#

Blue dots, red dots, green dots.... what does it all mean?!?! lol

modest dove Nov 21, 2023, 11:40 PM

#

status

#

green is airing, blue is returning, red is cancelled or ended

distant needle Nov 21, 2023, 11:40 PM

#

The source of your problem is the color of your dots

#

Kidding of course

modest dove Nov 21, 2023, 11:40 PM

#

i was gonna say....

#

that would be odd af

#

and this started before i switched to dots 😄

snow wren Nov 21, 2023, 11:40 PM

#

Is that last log the run that produced this result?

modest dove Nov 21, 2023, 11:40 PM

#

yes

#

i mean its only on the rick and morty

#

the other shit was already there

#

i removed hte label on rick and morty and ran it again

#

to isolate it all

#

📎 message.txt

#

that's the template stuff

#

it applies elsewhere just fine....and regex shows matching on the few i've tested so it should apply SOMETHING

#

#

same naming scheme

#

shows up there

snow wren Nov 21, 2023, 11:44 PM

#

And what are the names of the rick and morty files?

#

nvm they're in the log

modest dove Nov 21, 2023, 11:46 PM

#

📎 message.txt

#

heres a cleaner look if you want it

#

but yea they're in the logs

snow wren Nov 21, 2023, 11:50 PM

#

Well, there should be matches here, but PMM disagrees:

[WARNING]  | No Items found for Overlay File (0) BluRay                                                         |

modest dove Nov 21, 2023, 11:51 PM

#

well yea

#

i know that...

#

thats more ro less what i'm saying lol

#

i tested in regex101

#

shows they match

#

at least one should match

#

there's potentially 4 overlays that should apply

#

web, hmax, bluray, and amzn

snow wren Nov 21, 2023, 11:52 PM

#

I guess my next step would be to run it in a debugger.

modest dove Nov 21, 2023, 11:53 PM

#

i'm gonna try and match it on 'Rick.+'

distant needle Nov 21, 2023, 11:53 PM

#

Are you applying at season or episode builder_level?

#

Or only at show level?

modest dove Nov 21, 2023, 11:53 PM

#

show only...

#

but i posted my current yml

modest dove Nov 21, 2023, 11:53 PM

#

modest dove

this

distant needle Nov 21, 2023, 11:53 PM

#

On my phone

modest dove Nov 21, 2023, 11:53 PM

#

oh

#

| Overlays Applied: Overlay File (0) Max2, Overlay File (1) airing_shows

#

matched for Rick

#

i might just do it like that

#

i didnt find any others....

snow wren Nov 21, 2023, 11:58 PM

#

wait a minute, what about percentage?

modest dove Nov 22, 2023, 12:00 AM

#

i dunno, but like i said there are 4, and they are grouped

#

so i'd imagine SOMETHING would show up

#

i dont really understand the percentages

snow wren Nov 22, 2023, 12:06 AM

#

65 episodes

20 match AMZN
31 match bluray
14 match hmax
none match web

They are all requiring a 50% threshold:

| Collection Filter episodes: {'filepath.regex': ['(?i)\\b(BluRay|BDRip|Blu-Ray)\\b'], 'percentage': 50} |
| Collection Filter episodes: {'filepath.regex': ['(?i)\\b(amzn|amazon)\\b'], 'percentage': 50}      |
| Collection Filter episodes: {'filepath.regex': ['(?i)\\b(hmax|hbom|hbo[ ._-]max)\\b.+\\bweb[ ._-]?(dl|rip)?\\b'], 'percentage': 50} |
| Collection Filter episodes: {'filepath.regex': ['(?i)^(?!.*(amzn|amazon|atvp|aptv|Apple TV|Canal|CW|CBC|CC|DISC|DSC|dsnp|dsny|disney|hbo|h?max|ma|nf|netflix|P(ea)?co(c)?k|sho|stan)\\b).*\\bWEB[ _-]?(DL|Rip)?'], 'percentage': 50} |

I suspect that since none of them match at least 33 items, none of them get applied.

modest dove Nov 22, 2023, 12:07 AM

#

is that default?

#

so if i went and, for example, downloaded more of bluray

#

it would match...

#

hmm

#

i can just throw default_percent:35 for instance?

#

in default?

distant needle Nov 22, 2023, 12:10 AM

#

I always thought it was doing a max, and not a percentage

#

Meaning that bluray has 31 and has the highest percentage and occurs the most number of times and hence applies. I was all wrong about that.

modest dove Nov 22, 2023, 12:11 AM

#

docs say it only applies to seasons or episodes

#

how do i apply percent threshold to this?

#

or is this special filter?

#

yea didnt work

#

i set it to 35

distant needle Nov 22, 2023, 12:12 AM

#

It's more like a threshold.

modest dove Nov 22, 2023, 12:14 AM

#

i add it just like i did horizontal_offset right?

#

or does this go somewhere else

distant needle Nov 22, 2023, 12:16 AM

#

This being episodes.percentage: 35 ?

modest dove Nov 22, 2023, 12:16 AM

#

i mean, i dunno how it would be added

#

https://metamanager.wiki/en/latest/metadata/details/definition.html

#

i was just setting the default

distant needle Nov 22, 2023, 12:17 AM

#

I was here: https://metamanager.wiki/en/nightly/builders/filters/?h=percentage#attribute_5

modest dove Nov 22, 2023, 12:17 AM

#

default_percent: 35

distant needle Nov 22, 2023, 12:17 AM

#

Hmmm

#

Let me look at your wiki page

modest dove Nov 22, 2023, 12:18 AM

#

i dont want this to be a problem with other keys either

#

so i figured default was the way to go

#

because they're still weighted

#

so it should come out in the wash right?

#

why is there no show?

distant needle Nov 22, 2023, 12:19 AM

#

So we had to find a way to determine who would win

#

When you are in a mixed scenario as you have

modest dove Nov 22, 2023, 12:20 AM

#

yea, i thought weighted stuff was the way

#

i weighted them accordingly

distant needle Nov 22, 2023, 12:20 AM

#

No

#

What I am trying to explain... poorly that is..

modest dove Nov 22, 2023, 12:20 AM

#

its ok im dense anyway

distant needle Nov 22, 2023, 12:21 AM

#

Your exact scenario... imagine the lowest layer here... at episode level... we can apply each regex 1 time per episode... so they each get one overlay.

#

So if they are all different, how do we decide what to give the season level?

#

We assign a threshold percentage of the episodes to say... apply this.

modest dove Nov 22, 2023, 12:22 AM

#

whichever has the most?

#

what if two are both at 50%

#

THEN weights?

distant needle Nov 22, 2023, 12:23 AM

#

31/65 = 47%

modest dove Nov 22, 2023, 12:23 AM

#

no i get that

#

i'm just coneptually trying to grasp the implications

#

right now i'm thinking ill just go grab more bluray if i can

distant needle Nov 22, 2023, 12:23 AM

#

We'd need to look at the code to understand what happens

modest dove Nov 22, 2023, 12:23 AM

#

cause this is work that could easily be avoided

#

and i've taken so much of you guys time already

distant needle Nov 22, 2023, 12:24 AM

#

Well that would work but be kind of silly as you will most definitely encounter this on another show

modest dove Nov 22, 2023, 12:24 AM

#

yea

#

i know that....

distant needle Nov 22, 2023, 12:24 AM

#

Then you'll be back.

#

😉
-)

modest dove Nov 22, 2023, 12:24 AM

#

but you might forget that i've ben bugging you for like 2 days about these nuances

#

by then

#

😛

distant needle Nov 22, 2023, 12:25 AM

#

These are not bad things. You should see some of the other challenges we have with people

modest dove Nov 22, 2023, 12:25 AM

#

i feel like as a dev myself, i should grasp these things much easier

distant needle Nov 22, 2023, 12:25 AM

#

So default_percent is likely something you can set in your config.yml

#

Which would globally set the threshold

#

If you do it at the yml level it will take precedence over the default_percent set in config.yml

#

I also think that this issue has come up because you have up to 4 possible answers?

modest dove Nov 22, 2023, 12:27 AM

#

technically 3

#

its just a mishmash

#

i was wrong about WEB

distant needle Nov 22, 2023, 12:28 AM

#

As such, I would set the threshold to 25

#

Ok if it's three, then 33

modest dove Nov 22, 2023, 12:28 AM

#

it could be 4 on some other show

#

i dunno what scenarios id run into

#

what if i set it to 1

distant needle Nov 22, 2023, 12:28 AM

#

The world might end

#

Well... setting it too low would likely mean that the winner is split by many overlays

#

Because multiple would reach that "1"

modest dove Nov 22, 2023, 12:30 AM

#

ok but youre telling me it doesnt do the most weighted then?

#

if multiple match and meet the threshold?

distant needle Nov 22, 2023, 12:31 AM

#

To be tested

modest dove Nov 22, 2023, 12:31 AM

#

in these edgecases im not so concerned about it being 100% accurate majority

#

| Rick and Morty |
| Overlay Update Not Needed

#

lol...

distant needle Nov 22, 2023, 12:31 AM

#

Weight assumes that you only hit that item once, not 5 times...

modest dove Nov 22, 2023, 12:32 AM

#

distant needle Nov 22, 2023, 12:32 AM

#

Right side nice the green dot was applied in the last log

modest dove Nov 22, 2023, 12:33 AM

#

i put default_percentage: 35

#

in the default: section

#

it error'd yaml when i put it in overlay

distant needle Nov 22, 2023, 12:33 AM

#

I did say in config

#

Not in yml

modest dove Nov 22, 2023, 12:33 AM

#

oh

#

i just threw it right below my - file

#

it didnt error

#

but it didnt apply anything new

#

or was there someone you can specifically say "it goes here"

#

i just kinda assumed it was where the overlay stuff went

#

    overlay_path:
      - file: /config/sources.yml
      - default_percent: 35
      - pmm: resolution
        template_variables:

distant needle Nov 22, 2023, 12:39 AM

#

I am doing 4 things at once.

#

settings:                                           # Can be individually specified per library as well
  cache: true
  cache_expiration: 60
  asset_directory: config/assets
  asset_folders: true
  asset_depth: 0
  create_asset_folders: false
  prioritize_assets: false
  dimensional_asset_rename: false
  download_url_assets: false
  show_missing_season_assets: false
  show_missing_episode_assets: false
  show_asset_not_needed: false
  sync_mode: sync
  default_collection_order:
  minimum_items: 1
  delete_below_minimum: true
  delete_not_scheduled: false
  run_again_delay: 1
  missing_only_released: true
  show_unconfigured: true
  show_unmanaged: true
  show_filtered: true
  show_options: true
  show_missing: false
  only_filter_missing: false
  show_missing_assets: false
  save_report: false
  tvdb_language: eng
  ignore_ids:
  ignore_imdb_ids:
  item_refresh_delay: 0
  playlist_sync_to_users: all
  playlist_report: true
  custom_repo:
  verify_ssl: true
  check_nightly: true
  playlist_exclude_users:
  default_percent: 35

#

I believe that default_percent is placed there in settings

#

It could also go into the library settings section

#

    settings:
      asset_directory: config/assets/TV Shows/
      prioritize_assets: true                       # The asset_directory contains folders per media item with respective posters
      default_percent: 35

modest dove Nov 22, 2023, 12:44 AM

#

i put it in settings at the bottom

distant needle Nov 22, 2023, 12:44 AM

#

So I think the best place is to try the library one first

modest dove Nov 22, 2023, 12:44 AM

#

it didnt apply

distant needle Nov 22, 2023, 12:44 AM

#

Or there

#

Try library settings as my second example showed

#

Is it giving an error, just ignoring it?

#

If you search for the default_percent in the logs, does it show up?

modest dove Nov 22, 2023, 12:46 AM

#

it didnt error

#

it shows in settings

#

[2023-11-21 18:43:46,961] [builder.py:2693] [INFO] | Collection Filter episodes: {'filepath.regex': ['(?i)\b(BluRay|BDRip|Blu-Ray)\b'], 'percentage': 50} |

#

but still shows 50 in percentage

distant needle Nov 22, 2023, 12:48 AM

#

You didn't add anything to sources.yml related to percentage?

modest dove Nov 22, 2023, 12:48 AM

#

no

distant needle Nov 22, 2023, 12:49 AM

#

Maybe we are not calling out default_percent in the right place. I did a search and only 1 hit. On a page with zero examples:

modest dove Nov 22, 2023, 12:49 AM

#

thats what i found...

#

the page i pasted earlier

distant needle Nov 22, 2023, 12:49 AM

#

https://metamanager.wiki/en/latest/metadata/details/definition.html

modest dove Nov 22, 2023, 12:49 AM

#

yep that's the one

#

"it's a function"

#

that's it

distant needle Nov 22, 2023, 12:49 AM

#

Well... you know python?

modest dove Nov 22, 2023, 12:50 AM

#

yes

#

not like, well enough to write pmm

distant needle Nov 22, 2023, 12:50 AM

#

Search for that default_percent string in GitHub

#

And see what or where it's being called

#

And how

modest dove Nov 22, 2023, 12:50 AM

#

that's a good idea

distant needle Nov 22, 2023, 12:50 AM

#

Look at nightly branch

modest dove Nov 22, 2023, 12:51 AM

#

builder.py

distant needle Nov 22, 2023, 12:51 AM

#

Ok...

modest dove Nov 22, 2023, 12:52 AM

#

hold on

distant needle Nov 22, 2023, 12:52 AM

#

So it's a builder

modest dove Nov 22, 2023, 12:52 AM

#

reading

#

does that tell you enough?

distant needle Nov 22, 2023, 12:52 AM

#

Me..nope..

modest dove Nov 22, 2023, 12:52 AM

#

yea

#

didnt think so

#

gimme a few

#

i gotta back track, would probably be easier to clone the repo

#

cause its a property on self

#

and that doenst tell me where its coming from

distant needle Nov 22, 2023, 12:53 AM

#

Because ultimately the overlays.py is applying the overlay

#

So something is leveraging the builder.py

#

Where default_percent should be referenced

modest dove Nov 22, 2023, 12:53 AM

#

CollectionBuilder

#

i'm gonna clone this repo

#

hold on

distant needle Nov 22, 2023, 12:54 AM

#

Sure

modest dove Nov 22, 2023, 12:54 AM

#

its dense code

#

i need an IDE

distant needle Nov 22, 2023, 12:54 AM

#

PyCharm

modest dove Nov 22, 2023, 12:57 AM

#

        self.filtered_keys = {}
        self.run_again_movies = []
        self.run_again_shows = []
        self.notification_additions = []
        self.notification_removals = []
        self.items = []
        self.remove_item_map = {}
        self.schedule = ""
        self.beginning_count = 0
        self.default_percent = 50
        self.minimum = self.library.minim```

#

its set in a class that sets those

#

if those mean anything to you

#

i'm gonna trace where its called now

#

but figured id give you some context...i could also just replace the .py file....but i'd rather know how to do it in a config

#

server_preroll

#

its an overlay attribute

#

'percentage' is something you can define in the keys

#

so i set

#

[2023-11-21 19:09:09,021] [meta.py:218] [TRACE] | Original: {'name': 'rip_source', 'percentage': 40, 'weight': 1370, 'regex': '(?i)\b(?<!hbo[ .-])max\b.+\bweb[ .-]?(dl|rip)?\b'} |

#

wrong one

#

nope im wrong

#

i have no idea

#

[2023-11-21 19:09:15,688] [overlays.py:394] [INFO] | |
[2023-11-21 19:09:15,688] [overlays.py:396] [INFO] |================================= Gathering Items for Max Overlay ==================================|
[2023-11-21 19:09:15,688] [builder.py:2691] [INFO] | |
[2023-11-21 19:09:15,689] [builder.py:2693] [INFO] | Collection Filter episodes: {'filepath.regex': ['(?i)\b(?<!hbo[ .-])max\b.+\bweb[ .-]?(dl|rip)?\b'], 'percentage': 50} |

#

before i go deeper

#

i'm gonna change the default in the code

#

and see if that fixes it

distant needle Nov 22, 2023, 1:16 AM

#

You could.

#

Just arrived home need to eat and do family stuff

modest dove Nov 22, 2023, 1:20 AM

#

|   Overlay Reason: Overlay changed text(●)status40right4590bottom/fonts/Inter-Medium.ttf6400center(50, 205, 50, 255)(0, 0, 0, 153)300(0, 0, 0, 153)6 not in {'BluRaysources1800left1520top325105center(0, 0, 0, 153)3000': 'Overlay File (0) BluRay', 'text(●)status40right4590bottomfonts/Inter-Medium.ttf6400center(50, 205, 50, 255)(0, 0, 0, 153)300(0, 0, 0, 153)6': 'Overlay File (1) airing_shows'} |
|   Overlays Applied: Overlay File (0) BluRay, Overlay File (1) airing_shows ```

#

well thats cool

#

so at least we know what the problem is

distant needle Nov 22, 2023, 1:38 AM

#

You set it to why in the code?

modest dove Nov 22, 2023, 1:39 AM

#

35

#

worked

distant needle Nov 22, 2023, 1:39 AM

#

So we just need to figure out how to pass 35 into the running code

modest dove Nov 22, 2023, 1:39 AM

#

i tried where it seemed like it would go based on what i was seeing in logs

#

but it shows percentage

#

then never gets passed down

#

filters:

  filepath.regex: <<regex>>

#

maybe here.

#

seems like that's a possibility based on what i'm seeing

#

[2023-11-21 19:42:29,290] [builder.py:963] [DEBUG] | Value: {'percentage': 45, 'filepath.regex': '(?i)\b(BluRay|BDRip|Blu-Ray)\b'} |
[2023-11-21 19:42:29,292] [overlays.py:436] [DEBUG] | Traceback (most recent call last): |
| File "/modules/overlays.py", line 393, in compile_overlays |
| builder = CollectionBuilder(self.config, overlay_file, k, v, library=self.library, overlay=True) |
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
| File "/modules/builder.py", line 1054, in init |
| self._filters(method_name, method_data) |
| File "/modules/builder.py", line 1863, in _filters |
| raise Failed(message) |
| modules.util.Failed: Overlay Error: percentage is not a valid filter attribute |
| |
[2023-11-21 19:42:29,293] [overlays.py:437] [ERROR] | Overlay Error: percentage is not a valid filter attribute

distant needle Nov 22, 2023, 1:43 AM

#

ffs: In case anyones interested the issue was solved with the default_percent prop, i just put it in the wrong place, so hdr10+ detection goes something like this:

    default_percent: 2
    template:
      - name: Resolution
        weight: 400
        opt1: hdr10p
    plex_search:
      all:
        hdr: true
    filters:
      filepath.regex: 'HDR10\+|HDR10P'```

#

#general-chat message

#

implemented in May 2022: #nightly-updates message

modest dove Nov 22, 2023, 1:45 AM

#

[2023-11-21 19:44:47,702] [builder.py:2693] [INFO] | Collection Filter episodes: {'filepath.regex': ['(?i)\b(BluRay|BDRip|Blu-Ray)\b'], 'percentage': 45} |

#

yep

#

sounds like putting it in the wrong place is a repeat problem

#

docs need examples :/

distant needle Nov 22, 2023, 1:48 AM

#

so the above was a "good" example

modest dove Nov 22, 2023, 1:48 AM

#

yes

#

lol

distant needle Nov 22, 2023, 1:48 AM

#

i did a search for default_percent on ALL of our discord... 17 hits... 4 outside of this thread

#

and happened to hit that one person that was actually trying something similar to us with that example

#

of course.. I still think we are chasing this problem

modest dove Nov 22, 2023, 1:50 AM

#

out of 12k episodes

distant needle Nov 22, 2023, 1:50 AM

#

no... for Rick and Morty

modest dove Nov 22, 2023, 1:50 AM

#

no im saying

#

1 show

#

out of 12k episodes and 358 series

distant needle Nov 22, 2023, 1:51 AM

#

thats just a luck thing

modest dove Nov 22, 2023, 1:51 AM

#

ill make a point to be consistent about sourcing if possible

#

i dunno what else to do about it

#

adjust threshold as needed

distant needle Nov 22, 2023, 1:51 AM

#

the only logical thing to do is take the number of possible overlays / 100

#

what I dont know is what if 2 or more things hit that threshold

modest dove Nov 22, 2023, 1:52 AM

#

lol

#

thats like 3.7%

#

there's 21 overlays

#

not all could conflict though

distant needle Nov 22, 2023, 1:52 AM

#

because of the hbo, hbomax, MA, etc?

modest dove Nov 22, 2023, 1:52 AM

#

HDTV obviously can't be HBO

#

yea

#

i counted them

distant needle Nov 22, 2023, 1:53 AM

#

so what happens if you set it to 10%

modest dove Nov 22, 2023, 1:53 AM

#

there's really like, 19 potetial conflicts

#

the likelihood that it would be anything <30% is low af

#

i'd imagine there would be MAYBE AMZN and Bluray, and maybe one other at the most

distant needle Nov 22, 2023, 1:54 AM

#

if you say so

modest dove Nov 22, 2023, 1:54 AM

#

i have it setup to upgrade in sonarr

distant needle Nov 22, 2023, 1:54 AM

#

doesnt that depend on the source in the end

modest dove Nov 22, 2023, 1:55 AM

#

there'd only be a select few shows that release on different services over the course of a series

#

like if its on NF, its pretty stable on netflix, and if it gets taken off it might pop up on another, but its not gonna pop up on like 4 different ones

#

that seems extremely unlikely

#

but either way now i can adjust it if need be

#

i think setting it to a default of 10 or something could cause mroe problems than it solves?

distant needle Nov 22, 2023, 1:59 AM

#

just to see what happens against your test-library

modest dove Nov 22, 2023, 1:59 AM

#

i mean sure

#

no change

distant needle Nov 22, 2023, 2:47 AM

#

Interesting

#

So multiple overlays met 10% and the one with the largest value won

modest dove Nov 22, 2023, 3:25 AM

#

yes that appears to be the case

distant needle Nov 22, 2023, 11:58 AM

#

added this example to the wiki and waiting for the PR to be merged
#1176100803996549161 message

modest dove Nov 22, 2023, 5:26 PM

#

👍

#streaming.yml modification - filename regex

Is there an existing issue for this?

Is your feature request related to a problem? Please describe

Describe the solution you'd like

Describe alternatives you've considered

Anything else?