#Nuke Command rework

1 messages · Page 1 of 1 (latest)

polar flame
#

Immediately after the adonis update a game I work for started to have explosion exploits, nothing has changed except for adonis so I'm predicting an vulnerability in the nuke command.

image.png
polar flame
#

Oh and this helps tamper protection was triggered too.

image.png
#

Sadly the server was shutdown by people over me before I could get in and look at anything.

#

I mean this is the only thing I can pin it to because we haven't had explosion exploits in close to a year but as soon as the update dropped that happened.

#

Laredo TX, Border RP owned by charliestudios

#

We banned the user that exploitlogs flagged for tamper protection and shutdown that server and the explosions stopped but.

neat arch
#

I don't think it's the nuke command, but even if it was that'd be awfully quick for someone to find and abuse something like that

rough stump
#

what

#

no

#

live fire i think

smoky violet
languid jay
#

The new nuke cannot even cause explosions

rough stump
#

surely because nuke is a command like everything else, that would mean there is a vulnerability in admin that handles commands?

#

instead of the single command being exploited

#

exploiters wont be able to access :nuke without bypassing other core modules

smoky violet
#

who knows

languid jay
#

I'll check if V3rmillion has anything about this

languid jay
#

I can't find anything on any exploit about this publicly

#

Anyways I made a pull to re-add the nuke command

neat arch
#

I only reverted it because of the separate module for it that was being loaded, it looked like there was a lot it was doing outside of any functions before it returns anything so I didn't want to run the risk that something in there was causing issues

#

also figured it'd be the fastest way to settle the argument

#

allllssssoooooo reverted because someone was complaining about it changing the skybox without changing it back after

languid jay
#

Ok i'll try to see what fixed it

#

Oh yeah

#

I'll fixd it

#

Also I made a lot of pulls to fix stuff

#

Dont merge them yet tho

#

Ok scel now I have a lot of fixes to be merged

languid jay
languid jay
#

Can you do :oldlogs ?

#

This would allow us to see info about it

#

Potentially

languid jay
languid jay
#

(Before a nuke)

#

Nothing here looks like it could cause an explosion

#

Anyways the nuke module can't create Explosion instances. It only uses meshesh.

#

So it has to be something else which is not the nuke.

neat arch
#

meh

#

also for the love of all that is holy why

image.png
languid jay
#

:P

neat arch
#

less readable code

languid jay
#

Ok I'll make it more readable

#

Done

polar flame
polar flame
languid jay
#

There is still 1 problem with the nuke command

#

Is that it if you run :nuke then it removes all skyboxes after the nuke skybox is removed

#

I'll fix that bug

polar flame
#

I saw nothing of concern.

languid jay
#

Nvm wtf it doesn't

#

Ok scel now I made it so that the nuke no longer breaks skyboxes

polar flame
#

I had it happen again,

image.png
languid jay
#

Ok its not because of the nuke command

#

We can safely add the nuke command

languid jay
polar flame
languid jay
#

Did you get to do :errorlogs?

#

So all they can do is explosions?

#

Also ban the person who said infinite yield is already runnin

#

Because it means they are using an exploit

polar flame
polar flame
polar flame
languid jay
#

Hard to explain

polar flame
#

Is it anything I should be concerned about if it’s flagging people constantly

neat arch
#

It means something triggered the stuff meant to protect the Adonis client

smoky violet
#

adonis anti is very big brain

languid jay
polar flame